Re: [Qemu-devel] [Qemu-ppc] [PATCH 23/77] ppc: Turn a bunch of booleans from int to bool

On Wed, Nov 11, 2015 at 11:27:36AM +1100, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson > --- > target-ppc/translate.c | 39 +++ > 1 file changed, 19

Re: [Qemu-devel] [PATCH] memory: emulate ioeventfd

On Fri, Nov 20, 2015 at 12:37:16PM +0300, Pavel Fedin wrote: > The ioeventfd mechanism is used by vhost, dataplane, and virtio-pci to > turn guest MMIO/PIO writes into eventfd file descriptor events. This > allows arbitrary threads to be notified when the guest writes to a > specific MMIO/PIO

Re: [Qemu-devel] [PATCH 1/2] mirror: Rewrite mirror_iteration

On Wed, 11/18 11:38, Paolo Bonzini wrote: > > > On 17/11/2015 12:41, Fam Zheng wrote: > > +/* Wait for I/O to this cluster (from a previous iteration) to be > > + * done.*/ > > +while (test_bit(next_chunk, s->in_flight_bitmap)) { > > +

[Qemu-devel] [PATCH for-2.5] iothread: include id in thread name

This makes it easier to find the desired thread Signed-off-by: Paolo Bonzini --- iothread.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/iothread.c b/iothread.c index da6ce7b..8a1d6f8 100644 --- a/iothread.c +++ b/iothread.c @@ -72,6 +72,7 @@

Re: [Qemu-devel] [PATCH] PCI: minor performance optimization

On Fri, Nov 20, 2015 at 07:58:01PM +0800, Cao jin wrote: > > > On 11/20/2015 07:26 PM, Michael S. Tsirkin wrote: > >On Fri, Nov 20, 2015 at 07:04:07PM +0800, Cao jin wrote: > >> > >> > >>On 11/20/2015 06:45 PM, Michael S. Tsirkin wrote: > >>>On Fri, Nov 20, 2015 at 06:45:01PM +0800, Cao jin

Re: [Qemu-devel] [PULL 00/14] Migration pull request

Am 20.11.2015 um 15:00 hat Peter Lieven geschrieben: > Am 20.11.2015 um 14:53 schrieb Kevin Wolf: > > Am 20.11.2015 um 14:44 hat Peter Lieven geschrieben: > >> Am 20.11.2015 um 12:33 schrieb Peter Maydell: > >>> On 20 November 2015 at 09:38, Peter Lieven wrote: > I wonder if

[Qemu-devel] [PATCH for-2.5] target-arm: Don't mask out bits [47:40] in LPAE descriptors for v8

In an LPAE format descriptor in ARMv8 the address field extends up to bit 47, not just bit 39. Correct the masking so we don't give incorrect results if the output address size is greater than 40 bits, as it can be for AArch64. (Note that we don't yet support the new-in-v8 Address Size fault

Re: [Qemu-devel] [PATCH 06/18] armv7m: new NVIC utility functions

On 9 November 2015 at 01:11, Michael Davidsaver wrote: > Internal functions for operations previously done > by GIC internals. > > nvic_irq_update() recalculates highest pending/active > exceptions. > > armv7m_nvic_set_pending() include exception escalation > logic. > >

Re: [Qemu-devel] [PATCH v2 1/9] cpus: Reclaim vCPU objects

On 11/19/2015 09:33 PM, Bharata B Rao wrote: > On Thu, Nov 19, 2015 at 10:10:06AM -0500, Matthew Rosato wrote: >> From: Gu Zheng >> >> In order to deal well with the kvm vcpus (which can not be removed without >> any >> protection), we do not close KVM vcpu fd, just

Re: [Qemu-devel] [PULL 00/14] Migration pull request

Am 20.11.2015 um 12:33 schrieb Peter Maydell: > On 20 November 2015 at 09:38, Peter Lieven wrote: >> I wonder if there is a glitch in the PIO implementation of test-ide.c. As >> far as I understand the specs >> it is not allowed to read data while the BSY flag is set. With the

[Qemu-devel] [PATCH] target-mips: flush QEMU TLB when disabling 64-bit addressing

CP0.Status.KX/SX/UX bits are responsible for enabling access to 64-bit Kernel/Supervisor/User Segments. If bit is cleared an access to corresponding segment should generate Address Error Exception. However, the guest may still be able to access some pages belonging to the disabled 64-bit segment

[Qemu-devel] [PATCH v1 1/1] xlnx-ep108: Fix minimum RAM check

The minimum RAM check logic for the Xiilnx EP108 was off by one, which caused a false positive. Correct the logic to only print warnings when the RAM is below 0x800. Signed-off-by: Alistair Francis --- hw/arm/xlnx-ep108.c | 2 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH 00/18] Fix exception handling and msr/mrs access

On 17 November 2015 at 17:07, Peter Maydell wrote: > On 9 November 2015 at 01:11, Michael Davidsaver wrote: >> This series grew from a previous incorrect patch attempting to fix >> some incorrect behavior. After spending some time going through

Re: [Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak

On Fri, Nov 20, 2015 at 02:00:40PM +0100, Markus Armbruster wrote: > qmp_query_memdev() doesn't fail. Instead, it returns an empty list. > That's wrong. > > Two error paths: > > * When object_get_objects_root() returns null. It never does, so > simply drop the useless error handling. > > *

Re: [Qemu-devel] [PATCH] tests: fix cdrom_pio_impl in ide-test

On 20 November 2015 at 14:29, Peter Lieven wrote: > The check for the cleared BSY flag has to be performed > before each data transfer and not just before the > first one. > > Commit 5f81724d revealed this glitch as the BSY flag > was not set in ATAPI PIO transfers before. > > While

Re: [Qemu-devel] [PATCH v9 1/6] target-arm: kvm64 - introduce kvm_arm_init_debug()

On 20 November 2015 at 15:05, Peter Maydell wrote: > On 12 November 2015 at 16:20, Alex Bennée wrote: >> As we haven't always had guest debug support we need to probe for it. >> Additionally we don't do this in the start-up capability code so we

Re: [Qemu-devel] [PATCH 11/18] armv7m: fix I and F flag handling

On 9 November 2015 at 01:11, Michael Davidsaver wrote: > Despite having the same notation, these bits > have completely different meaning than -AR. > > Add armv7m_excp_unmasked() > to calculate the currently runable exception priority > taking into account masks and active

Re: [Qemu-devel] [PULL 00/14] Migration pull request

Am 20.11.2015 um 14:53 schrieb Kevin Wolf: > Am 20.11.2015 um 14:44 hat Peter Lieven geschrieben: >> Am 20.11.2015 um 12:33 schrieb Peter Maydell: >>> On 20 November 2015 at 09:38, Peter Lieven wrote: I wonder if there is a glitch in the PIO implementation of test-ide.c. As

Re: [Qemu-devel] [PATCH v9 1/6] target-arm: kvm64 - introduce kvm_arm_init_debug()

On 12 November 2015 at 16:20, Alex Bennée wrote: > As we haven't always had guest debug support we need to probe for it. > Additionally we don't do this in the start-up capability code so we > don't fall over on old kernels. > > Signed-off-by: Alex Bennée

Re: [Qemu-devel] [Qemu-ppc] [OpenBIOS] CUDA has problems with Mac OS 10.4

On Thu, 19 Nov 2015, Segher Boessenkool wrote: Some mac99/pmu99 hardware has an ADB keyboard, fwiw (tibook, for example). The do have built-in USB; that, and being newworld, are not directly related things. Maybe, but the PowerMac3,1 we are trying to emulate here does not have ADB AFAIK.

Re: [Qemu-devel] [PULL 00/14] Migration pull request

Am 20.11.2015 um 14:44 hat Peter Lieven geschrieben: > Am 20.11.2015 um 12:33 schrieb Peter Maydell: > > On 20 November 2015 at 09:38, Peter Lieven wrote: > >> I wonder if there is a glitch in the PIO implementation of test-ide.c. As > >> far as I understand the specs > >> it is

[Qemu-devel] [PATCH] tests: fix cdrom_pio_impl in ide-test

The check for the cleared BSY flag has to be performed before each data transfer and not just before the first one. Commit 5f81724d revealed this glitch as the BSY flag was not set in ATAPI PIO transfers before. While at it fix the desciptions and add a comment before the nested for loop that

Re: [Qemu-devel] [vfio-users] [PATCH 2/2] input: linux evdev support

2015-11-18 20:55 GMT+03:00 Gerd Hoffmann : > The advantage is that it'll work without virtio-input drivers in the > guest, the events are delivered to the usual ps/2 or usb input devices > (depending on what the machine happens to have). And for keyboards > qemu is able to

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

On Fri, Nov 20, 2015 at 04:36:15PM +0800, Tian, Kevin wrote: > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: Friday, November 20, 2015 4:26 PM > > > > Hi, > > > > > > iGVT-g_Setup_Guide.txt mentions a "Indirect Display Mode", but doesn't > > > > explain how the guest framebuffer

Re: [Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak

Eduardo Habkost writes: > On Fri, Nov 20, 2015 at 02:00:40PM +0100, Markus Armbruster wrote: >> qmp_query_memdev() doesn't fail. Instead, it returns an empty list. >> That's wrong. >> >> Two error paths: >> >> * When object_get_objects_root() returns null. It never does,

Re: [Qemu-devel] [PATCH for-2.5] target-arm: Don't mask out bits [47:40] in LPAE descriptors for v8

Hello, On Fri, Nov 20, 2015 at 3:32 PM, Peter Maydell wrote: > In an LPAE format descriptor in ARMv8 the address field extends > up to bit 47, not just bit 39. Correct the masking so we don't > give incorrect results if the output address size is greater > than 40 bits,

Re: [Qemu-devel] [PULL 00/14] Migration pull request

Am 19.11.2015 um 16:16 schrieb Dr. David Alan Gilbert: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 19 November 2015 at 14:44, Peter Maydell wrote: >>> On 19 November 2015 at 13:21, Peter Maydell >>> wrote: On 19 November

Re: [Qemu-devel] [PATCH] PCI: minor performance optimization

On Fri, Nov 20, 2015 at 07:04:07PM +0800, Cao jin wrote: > > > On 11/20/2015 06:45 PM, Michael S. Tsirkin wrote: > >On Fri, Nov 20, 2015 at 06:45:01PM +0800, Cao jin wrote: > >>1. Do param check in pci_add_capability2(), as it is a public API. > > > >Separate patch pls. > > OK > > > > >>2. As

Re: [Qemu-devel] [PULL v3 00/15] Tracing patches

On Fri, Nov 13, 2015 at 10:33 PM, Edgar E. Iglesias wrote: > On Fri, Nov 13, 2015 at 11:28:41AM +, Peter Maydell wrote: >> On 13 November 2015 at 10:30, Peter Maydell wrote: >> > I also now get a handful of extra warnings in the 'make

Re: [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings

On Mon, Nov 16, 2015 at 06:47:03PM +0200, Michael S. Tsirkin wrote: > We are currently only sending VRING_ENABLE message for the first ring, > that's wrong: we must start/stop them all. > > Reported-by: Victor Kaplansky > Signed-off-by: Michael S. Tsirkin >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 25/77] ppc: Add P7/P8 Power Management instructions

On Wed, Nov 11, 2015 at 11:27:38AM +1100, Benjamin Herrenschmidt wrote: > This adds the ISA 2.06 and later power management instructions > (doze, nap, sleep and rvwinkle) and associated wakeup cause testing > in LPCR > > Signed-off-by: Benjamin Herrenschmidt Looks

[Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120

Otherwise, a window flashes on my desktop (built with SDL). Other iotest cases have that. Signed-off-by: Fam Zheng --- tests/qemu-iotests/120 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120 index

[Qemu-devel] [PATCH for-2.5] call bdrv_drain_all() even if the vm is stopped

There are still I/O operations when the vm is stopped. For example, stop the vm, and do block migration. In this case, we don't drain all I/O operation, and may meet the following problem: qemu-system-x86_64: migration/block.c:731: block_save_complete: Assertion `block_mig_state.submitted == 0'

Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu

On Thu, Nov 19, 2015 at 10:00:38PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Nov 19, 2015 at 03:38:03PM -0500, Bandan Das wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > From: Bandan Das > >> > > >> >

Re: [Qemu-devel] [PATCH V5 7/8] introduce xlnx-dp

On Fri, Oct 16, 2015 at 7:11 PM, wrote: > From: KONRAD Frederic > > This is the implementation of the DisplayPort. > It has an aux-bus to access dpcd and edid. > > Graphic plane is connected to the channel 3. > Video plane is connected to

[Qemu-devel] [PATCH] memory: emulate ioeventfd

The ioeventfd mechanism is used by vhost, dataplane, and virtio-pci to turn guest MMIO/PIO writes into eventfd file descriptor events. This allows arbitrary threads to be notified when the guest writes to a specific MMIO/PIO address. qtest and TCG do not support ioeventfd because memory writes

[Qemu-devel] [PATCH for-2.5] block-migration: limit the memory usage

If we set migration speed in a very large value, block-migration will try to read all data to the memory. Because (block_mig_state.submitted + block_mig_state.read_done) * BLOCK_SIZE will be overflow, and it will be always less than rate limit. There is no need to read too many data into

Re: [Qemu-devel] [PATCH] PCI: minor performance optimization

On 11/20/2015 06:45 PM, Michael S. Tsirkin wrote: On Fri, Nov 20, 2015 at 06:45:01PM +0800, Cao jin wrote: 1. Do param check in pci_add_capability2(), as it is a public API. Separate patch pls. OK 2. As spec says, each capability must be DWORD aligned, so an optimization can be

[Qemu-devel] [PATCH v5 05/10] cpu: Add a sync version of cpu_remove()

This sync API will be used by the CPU hotplug code to wait for the CPU to completely get removed before flagging the failure to the device_add command. Sync version of this call is needed to correctly recover from CPU realization failures when ->plug() handler fails. Signed-off-by: Bharata B Rao

[Qemu-devel] [PATCH v5 06/10] xics_kvm: Add cpu_destroy method to XICS

XICS is setup for each CPU during initialization. Provide a routine to undo the same when CPU is unplugged. This allows reboot of a VM that has undergone CPU hotplug and unplug to work correctly. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson

[Qemu-devel] [PATCH v5 04/10] cpu: Reclaim vCPU objects

From: Gu Zheng In order to deal well with the kvm vcpus (which can not be removed without any protection), we do not close KVM vcpu fd, just record and mark it as stopped into a list, so that we can reuse it for the appending cpu hot-add request if possible. It is also

Re: [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings

On Fri, Nov 20, 2015 at 02:56:43PM +0200, Victor Kaplansky wrote: > On Mon, Nov 16, 2015 at 06:47:03PM +0200, Michael S. Tsirkin wrote: > > We are currently only sending VRING_ENABLE message for the first ring, > > that's wrong: we must start/stop them all. > > > > Reported-by: Victor Kaplansky

Re: [Qemu-devel] [Qemu-ppc] [PATCH 24/77] ppc: Move exception generation code out of line

On Wed, Nov 11, 2015 at 11:27:37AM +1100, Benjamin Herrenschmidt wrote: > There's no point inlining this, if you hit the exception case you exit > anyway, That doesn't quite seem relevant - IIUC this is affecting inlining in the code generation path, rather than the code execution path. > and

Re: [Qemu-devel] [RFC v1] virtio-crypto specification

Hi Michael, > -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Friday, November 20, 2015 5:40 PM > > Thanks, looks good overall. > You might want to join the TC if you maintain a device. Yes, IIRC Jani is a member of the TC, right? Jani ? > Generally, I

[Qemu-devel] [PATCH] PCI: minor performance optimization

1. Do param check in pci_add_capability2(), as it is a public API. 2. As spec says, each capability must be DWORD aligned, so an optimization can be done via Loop Unrolling. Signed-off-by: Cao jin --- hw/pci/pci.c | 12 1 file changed, 8 insertions(+),

Re: [Qemu-devel] [PATCH] PCI: minor performance optimization

On Fri, Nov 20, 2015 at 06:45:01PM +0800, Cao jin wrote: > 1. Do param check in pci_add_capability2(), as it is a public API. Separate patch pls. > 2. As spec says, each capability must be DWORD aligned, so an optimization can >be done via Loop Unrolling. Why do we want to optimize it? >

Re: [Qemu-devel] [PATCH for-2.5] eepro100: Prevent two endless loops

+-- On Fri, 20 Nov 2015, Stefan Weil wrote --+ | include/hw/pci/pci.h:static inline uint##_bits##_t | ld##_l##_pci_dma(PCIDevice *dev, \ I see. | Is there an ideal count? If it is too low, it might break some use cases. | If it is too high, it will take longer until the loop is

Re: [Qemu-devel] [PATCH] PCI: minor performance optimization

On 11/20/2015 07:26 PM, Michael S. Tsirkin wrote: On Fri, Nov 20, 2015 at 07:04:07PM +0800, Cao jin wrote: On 11/20/2015 06:45 PM, Michael S. Tsirkin wrote: On Fri, Nov 20, 2015 at 06:45:01PM +0800, Cao jin wrote: 2. As spec says, each capability must be DWORD aligned, so an optimization

[Qemu-devel] [PATCH v5 00/10] sPAPR CPU hotplug

This patchset adds CPU hotplug support for sPAPR PowerPC guests using device_add and device_del commands (qemu) device_add POWER8-powerpc64-cpu,id=cpu0 The first 5 patches are generic changes. Out of these 4/10 is required by x86 and s390 as well and has been posted in their CPU hotplug

Re: [Qemu-devel] [Qemu-ppc] [PATCH 22/77] ppc: Add real mode CI load/store instructions for P7 and P8

On Wed, Nov 11, 2015 at 11:27:35AM +1100, Benjamin Herrenschmidt wrote: > Those instructions are only available in hypervisor real mode and > allow cache inhibited garded access to devices in that mode. > > Signed-off-by: Benjamin Herrenschmidt > --- > target-ppc/cpu.h

Re: [Qemu-devel] [Qemu-ppc] [PATCH 21/77] ppc: Rework generation of priv and inval interrupts

On Wed, Nov 11, 2015 at 11:27:34AM +1100, Benjamin Herrenschmidt wrote: > Recent server processors use the Hypervisor Emulation Assistance > interrupt for illegal instructions and *some* type of SPR accesses. > > Also the code was always generating inval instructions even for priv > violations

[Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

"s->bitmap" tracks done sectors, we only check bit states without using any iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and more memory efficient. Meanwhile, rename it to done_bitmap, to reflect the intention. Signed-off-by: Fam Zheng ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH 26/77] ppc/pnv: Add skeletton PowerNV platform

On Wed, Nov 11, 2015 at 11:27:39AM +1100, Benjamin Herrenschmidt wrote: > No devices yet, not even an interrupt controller, just to get > started. > > Signed-off-by: Benjamin Herrenschmidt > --- > default-configs/ppc64-softmmu.mak | 1 + > hw/ppc/Makefile.objs

[Qemu-devel] [PATCH for 2.6 2/3] block: Hide HBitmap in block dirty bitmap interface

HBitmap is an implementation detail of block dirty bitmap that should be hidden from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying HBitmapIter. A small difference in the interface is, before, an HBitmapIter is initialized in place, now the new BdrvDirtyBitmapIter must be

[Qemu-devel] [PATCH v6 1/2] mirror: Rewrite mirror_iteration

The "pnum < nb_sectors" condition in deciding whether to actually copy data is unnecessarily strict, and the qiov initialization is unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. Rewrite mirror_iteration to fix both flaws. Signed-off-by: Fam Zheng --- v5:

[Qemu-devel] [PATCH v6 2/2] mirror: Add mirror_wait_for_io

The three lines are duplicated a number of times now, refactor a function. Signed-off-by: Fam Zheng --- block/mirror.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index ff8149d..ea5a76a 100644

[Qemu-devel] [PATCH v6 0/2] mirror: Improve zero write and discard

v6: Address Paolo's comments in mirror_iteration: - break if we've already got a chunk to work on; - fix a typo in comment. Patch 1 rewrites mirror_iteration. Patch 2 is a small DRY cleaning up. Fam Zheng (2): mirror: Rewrite mirror_iteration mirror: Add mirror_wait_for_io

Re: [Qemu-devel] [PATCH] Assume madvise for (no)hugepage works

"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > madvise() returns EINVAL in the case of many failures, but also > returns it in cases where the host kernel doesn't have THP enabled. > Postcopy only really cares that THP is off

[Qemu-devel] [PATCH v5 08/10] spapr: CPU hotplug support

Support CPU hotplug via device-add command. Set up device tree entries for the hotplugged CPU core and use the exising EPOW event infrastructure to send CPU hotplug notification to the guest. Create only cores explicitly from boot path as well as hotplug path and let the ->plug() handler of the

[Qemu-devel] [PATCH v5 02/10] exec: Remove cpu from cpus list during cpu_exec_exit()

CPUState *cpu gets added to the cpus list during cpu_exec_init(). It should be removed from cpu_exec_exit(). cpu_exec_init() is called from generic CPU::instance_finalize and some archs like PowerPC call it from CPU unrealizefn. So ensure that we dequeue the cpu only once. Now -1 value for

[Qemu-devel] [PATCH v5 07/10] spapr: Enable CPU hotplug for pseries-2.5 and add CPU DRC DT entries

Start supporting CPU hotplug from pseries-2.5 onwards. Add CPU DRC (Dynamic Resource Connector) device tree entries. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- hw/ppc/spapr.c | 23 +++

[Qemu-devel] [PATCH v5 03/10] exec: Do vmstate unregistration from cpu_exec_exit()

cpu_exec_init() does vmstate_register and register_savevm for the CPU device. These need to be undone from cpu_exec_exit(). These changes are needed to support CPU hot removal and also to correctly fail hotplug attempts beyond max_cpus. Signed-off-by: Bharata B Rao

Re: [Qemu-devel] [PATCH for-2.5] iothread: include id in thread name

* Paolo Bonzini (pbonz...@redhat.com) wrote: > This makes it easier to find the desired thread > > Signed-off-by: Paolo Bonzini > --- > iothread.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/iothread.c b/iothread.c > index

Re: [Qemu-devel] [RFC v1] virtio-crypto specification

Thanks, looks good overall. You might want to join the TC if you maintain a device. Generally, I think this needs a bit more formal conformance statements. Some examples below. On Fri, Nov 20, 2015 at 03:27:51AM +, Gonglei (Arei) wrote: > Hi guys, > > After initial discussion at this year's

[Qemu-devel] [PATCH for 2.6 3/3] hbitmap: Drop "granularity"

Sometimes confused with the granularity with coarse levels in HBitmap, the granularity in the hbitmap_alloc is not an essential concept of a bitmap. Now that all callers except the test code use zero, it's possible to drop the parameter to make the interface cleaner and more intuitive. Test code

[Qemu-devel] [PATCH for 2.6 0/3] Bitmap clean-up patches for 2.6

This makes a cleaner base for more dirty bitmap work. "granularity" appearing with different representations have always been mind twisting, remove it from HBitmap to make the interface and implementation simpler. Upon this, it is a bit easier to add persistent dirty bitmap functionalities. Block

[Qemu-devel] [PATCH v5 10/10] target-ppc: Enable CPU hotplug for POWER8 CPU family

Support CPU hotplug on POWER8 by enabling device_add semantics. Signed-off-by: Bharata B Rao --- target-ppc/translate_init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 245d73a..45d1b7c 100644

[Qemu-devel] [PATCH v5 09/10] spapr: CPU hot unplug support

Support hot removal of CPU for sPAPR guests by sending the hot unplug notification to the guest via EPOW interrupt. Release the vCPU object after CPU hot unplug so that vCPU fd can be parked and reused. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 71

[Qemu-devel] [PATCH v5 01/10] vl: Don't allow CPU toplogies with partially filled cores

Prevent guests from booting with CPU topologies that have partially filled CPU cores or can result in partially filled CPU cores after CPU hotplug like -smp 15,sockets=1,cores=4,threads=4,maxcpus=16 or -smp 15,sockets=1,cores=4,threads=4,maxcpus=17. Signed-off-by: Bharata B Rao

Re: [Qemu-devel] [Qemu-ppc] [PATCH 14/77] ppc: Change 'invalid' bit mask of tlbiel and tlbie

On Wed, Nov 11, 2015 at 11:27:27AM +1100, Benjamin Herrenschmidt wrote: > Otherwise it will trip on the forms used in recent architecture. > > Ideally, we should have different handlers for different architecture > levels but our current implementation of TLB flushing is dumb enough > that this

Re: [Qemu-devel] [PULL for-2.5 v2 00/10] QOM devices patch queue 2015-11-19

On 19 November 2015 at 14:35, Andreas Färber wrote: > Hello Peter, > > This is my late QOM (devices) patch queue. Please pull. > > v2: GLib version incompatibility addressed, Reviewed-bys added. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: Daniel

Re: [Qemu-devel] [PULL 00/14] Migration pull request

On 20 November 2015 at 09:38, Peter Lieven wrote: > I wonder if there is a glitch in the PIO implementation of test-ide.c. As far > as I understand the specs > it is not allowed to read data while the BSY flag is set. With the following > change to the test-ide script > the test

Re: [Qemu-devel] [PATCH V5 8/8] arm: xlnx-zynqmp: Add xlnx-dp and xlnx-dpdma

On Fri, Oct 16, 2015 at 7:11 PM, wrote: > From: KONRAD Frederic > > This adds the DP and the DPDMA to the Zynq MP platform. > > Signed-off-by: KONRAD Frederic > Reviewed-by: Peter Crosthwaite

[Qemu-devel] [PATCH] block/qapi: Plug memory leak on query-block error path

Spotted by Coverity. Signed-off-by: Markus Armbruster --- block/qapi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index d20262d..267f147 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -436,7 +436,9 @@ BlockInfoList

[Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak

qmp_query_memdev() doesn't fail. Instead, it returns an empty list. That's wrong. Two error paths: * When object_get_objects_root() returns null. It never does, so simply drop the useless error handling. * When query_memdev() fails. This can happen, and the error to return is the one

Re: [Qemu-devel] [PATCH v9 2/6] target-arm: kvm - implement software breakpoints

On 12 November 2015 at 16:20, Alex Bennée wrote: > These don't involve messing around with debug registers, just setting > the breakpoint instruction in memory. GDB will not use this mechanism if > it can't access the memory to write the breakpoint. > > All the kernel has

Re: [Qemu-devel] [PATCH v9 3/6] target-arm: kvm - support for single step

On 12 November 2015 at 16:20, Alex Bennée wrote: > This adds support for single-step. There isn't much to do on the QEMU > side as after we set-up the request for single step via the debug ioctl > it is all handled within the kernel. > > Signed-off-by: Alex Bennée

Re: [Qemu-devel] [PATCH v9 4/6] target-arm: kvm - add support for HW assisted debug

On 12 November 2015 at 16:20, Alex Bennée wrote: > This adds basic support for HW assisted debug. The ioctl interface to > KVM allows us to pass an implementation defined number of break and > watch point registers. When KVM_GUESTDBG_USE_HW is specified these > debug

Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu

"Michael S. Tsirkin" writes: > On Thu, Nov 19, 2015 at 10:00:38PM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Thu, Nov 19, 2015 at 03:38:03PM -0500, Bandan Das wrote: >> >> "Michael S. Tsirkin" writes: >> >> >>

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

On Fri, 2015-11-20 at 07:09 +, Tian, Kevin wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Friday, November 20, 2015 4:03 AM > > > > > > > > > > The proposal is therefore that GPU vendors can expose vGPUs to > > > > userspace, and thus to QEMU, using the VFIO

Re: [Qemu-devel] [PATCH v9 5/6] target-arm: kvm - re-inject guest debug exceptions

On 12 November 2015 at 16:20, Alex Bennée wrote: > From: Alex Bennée > > If we can't find details for the debug exception in our debug state > then we can assume the exception is due to debugging inside the guest. > To inject the exception into the guest

Re: [Qemu-devel] [PATCH for 2.6 3/3] hbitmap: Drop "granularity"

On 20.11.2015 12:59, Fam Zheng wrote: Sometimes confused with the granularity with coarse levels in HBitmap, the granularity in the hbitmap_alloc is not an essential concept of a bitmap. Now that all callers except the test code use zero, it's possible to drop the parameter to make the

Re: [Qemu-devel] [PATCH] tests: fix cdrom_pio_impl in ide-test

On 11/20/2015 09:37 AM, Peter Maydell wrote: > On 20 November 2015 at 14:29, Peter Lieven wrote: >> The check for the cleared BSY flag has to be performed >> before each data transfer and not just before the >> first one. >> >> Commit 5f81724d revealed this glitch as the BSY flag

Re: [Qemu-devel] [PATCH v9 1/6] target-arm: kvm64 - introduce kvm_arm_init_debug()

Peter Maydell writes: > On 20 November 2015 at 15:05, Peter Maydell wrote: >> On 12 November 2015 at 16:20, Alex Bennée wrote: >>> As we haven't always had guest debug support we need to probe for it. >>> Additionally

Re: [Qemu-devel] [PATCH v9 6/6] tests/guest-debug: introduce basic gdbstub tests

On 12 November 2015 at 16:20, Alex Bennée wrote: > From: Alex Bennée > > The aim of these tests is to combine with an appropriate kernel > image (with symbol-file vmlinux) and check it behaves as it should. > Given a kernel it checks: > > - single step

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi - Original Message - > Everybody's favourite device model has "size" property. It's declared > as *string* > > DEFINE_PROP_STRING("size", IVShmemState, sizearg), > > which gets converted to a size manually in the realize method: > > } else if (s->sizearg == NULL) { >

Re: [Qemu-devel] [PATCH for 2.6 2/3] block: Hide HBitmap in block dirty bitmap interface

On 20.11.2015 12:59, Fam Zheng wrote: HBitmap is an implementation detail of block dirty bitmap that should be hidden from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying HBitmapIter. A small difference in the interface is, before, an HBitmapIter is initialized in place,

Re: [Qemu-devel] [PATCH for-2.5] target-arm: Don't mask out bits [47:40] in LPAE descriptors for v8

On 20 November 2015 at 15:18, Laurent Desnogues wrote: > Hello, > > On Fri, Nov 20, 2015 at 3:32 PM, Peter Maydell > wrote: >> In an LPAE format descriptor in ARMv8 the address field extends >> up to bit 47, not just bit 39. Correct the

Re: [Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak

On Fri, Nov 20, 2015 at 03:57:17PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Fri, Nov 20, 2015 at 02:00:40PM +0100, Markus Armbruster wrote: > >> qmp_query_memdev() doesn't fail. Instead, it returns an empty list. > >> That's wrong. > >> > >> Two

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

On 20.11.2015 12:59, Fam Zheng wrote: "s->bitmap" tracks done sectors, we only check bit states without using any iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and more memory efficient. Meanwhile, rename it to done_bitmap, to reflect the intention. Signed-off-by: Fam

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120

On 20.11.2015 10:35, Fam Zheng wrote: > Otherwise, a window flashes on my desktop (built with SDL). Other > iotest cases have that. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/120 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH for 2.6 0/3] Bitmap clean-up patches for 2.6

Hi Fam! Thanks for it, I really like the idea about dropping granularity from hbitmap. I've waste lots of time understanding the code about bitmaps. Keeping in mind what units are in what granularity and what granularity is in what units is more than inconvenient) On 20.11.2015 12:59, Fam

Re: [Qemu-devel] [RESEND RFC 0/6] AMD XGBE KVM platform passthrough

Hi Alex, On 11/20/2015 12:44 AM, Alex Williamson wrote: > On Thu, 2015-11-19 at 15:22 +, Eric Auger wrote: >> I am resending this RFC from Oct 12, after kernel 4.4-rc1 and >> QEMU 2.5-rc1, hoping things have calmed down a little bit. >> >> This RFC allows to set up AMD XGBE passthrough. This

Re: [Qemu-devel] [Qemu-ppc] [OpenBIOS] CUDA has problems with Mac OS 10.4

On Nov 20, 2015, at 8:39 AM, BALATON Zoltan wrote: > On Thu, 19 Nov 2015, Segher Boessenkool wrote: >> Some mac99/pmu99 hardware has an ADB keyboard, fwiw (tibook, for example). >> The do have built-in USB; that, and being newworld, are not directly >> related things. > > Maybe, but the

Re: [Qemu-devel] [PATCH COLO-Frame v10 19/38] COLO failover: Introduce state to record failover process

* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > When handling failover, we do different things according to the different > stage > of failover process, here we introduce a global atomic variable to record the > status of failover. > > We add four failover status to indicate the

[Qemu-devel] ivshmem property size should be a size, not a string

Everybody's favourite device model has "size" property. It's declared as *string* DEFINE_PROP_STRING("size", IVShmemState, sizearg), which gets converted to a size manually in the realize method: } else if (s->sizearg == NULL) { s->ivshmem_size = 4 << 20; /* 4 MB default */

Re: [Qemu-devel] [PATCH] tests: fix cdrom_pio_impl in ide-test

Am 20.11.2015 um 15:29 hat Peter Lieven geschrieben: > The check for the cleared BSY flag has to be performed > before each data transfer and not just before the > first one. > > Commit 5f81724d revealed this glitch as the BSY flag > was not set in ATAPI PIO transfers before. > > While at it fix

Re: [Qemu-devel] [PATCH for-2.5] target-arm: Don't mask out bits [47:40] in LPAE descriptors for v8

On Fri, Nov 20, 2015 at 4:20 PM, Peter Maydell wrote: > On 20 November 2015 at 15:18, Laurent Desnogues > wrote: >> Hello, >> >> On Fri, Nov 20, 2015 at 3:32 PM, Peter Maydell >> wrote: >>> In an LPAE format

Re: [Qemu-devel] [PATCH] memory: emulate ioeventfd

On 20/11/2015 10:37, Pavel Fedin wrote: > The ioeventfd mechanism is used by vhost, dataplane, and virtio-pci to > turn guest MMIO/PIO writes into eventfd file descriptor events. This > allows arbitrary threads to be notified when the guest writes to a > specific MMIO/PIO address. > > qtest

Re: [Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version()

On 12 November 2015 at 15:04, Eduardo Habkost wrote: > On Thu, Nov 12, 2015 at 01:39:24PM +0200, Michael S. Tsirkin wrote: >> On Wed, Nov 11, 2015 at 07:42:47PM -0200, Eduardo Habkost wrote: >> > nseries doesn't use qemu_set_hw_version() and doesn't need the >> >

  1   2   3   >