Re: [Qemu-devel] [PATCH COLO-Frame v11 18/39] COLO: Flush PVM's cached RAM into SVM's memory

* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > During the time of VM's running, PVM may dirty some pages, we will transfer > PVM's dirty pages to SVM and store them into SVM's RAM cache at next > checkpoint > time. So, the content of SVM's RAM cache will always be some with PVM's

[Qemu-devel] [PATCH v5 4/4] i.MX: Add an i.MX25 specific CCM class/instance.

With this CCM, i.MX25 timer is accurate with "real world time". Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * rework loging to match other i.MX drivers Changes since v2: * We moved to an inheritance QOM scheme Changes since v3: * Rework logging based on

[Qemu-devel] [PATCH v5 1/4] i.MX: Fix i.MX31 default/reset configuration.

Linux on i.MX31/KZM is expecting the CCM to use the CKIH ref clock instead of the CKIL plus the FPM multiplier. We change the CCMR reg reset value to match linux expected config. This allow the CCM to provide a 39MHz clk (as expected by linux) instead of the actual 50MHz. With this change the

Re: [Qemu-devel] [PATCH] spapr/pci: populate PCI DT in reverse order

On 30/11/15 11:45, Greg Kurz wrote: > Since commit 1d2d974244c6 "spapr_pci: enumerate and add PCI device tree", QEMU > populates the PCI device tree in the opposite order compared to SLOF. > > Before 1d2d974244c6: > > Populating /pci@8002000 > 00 (D) : 1af4 1000

Re: [Qemu-devel] [PATCH v13 12/14] qapi: Enforce (or whitelist) case conventions on qapi members

On 11/27/2015 02:03 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We document that members of enums and objects should be >> 'lower-case', although we were not enforcing it. We have to >> whitelist a few pre-existing entities that violate the norms. >> Add three new

Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

Hi Samuel, On 29/07/15 00:57, Samuel Thibault wrote: > Samuel Thibault, le Wed 29 Jul 2015 00:13:57 +0200, a écrit : > > This is another respin of IPv6 in Qemu -net user mode. > > These patches add ICMPv6, NDP, and make UDP and TCP compatible with > IPv6. We have made some refactoring to make

Re: [Qemu-devel] [PULL for-2.5 0/4] s390x fixes for 2.5

> > are available in the git repository at: > > git://github.com/cohuck/qemu tags/s390x-20151201 > > for you to fetch changes up to f0a399dbae6a2d0e2e15eb7ce0783286bbd9fe04: > > s390x/pci: fix up IOMMU size (2015-12-01 09:57:28 +0100) > > ---

Re: [Qemu-devel] [PATCH V3 3/3] hw/i386: extend pxb query for all PC machines

On Tue, Dec 01, 2015 at 10:53:07PM +0200, Marcel Apfelbaum wrote: > On 12/01/2015 08:20 PM, Eduardo Habkost wrote: > >On Thu, Nov 26, 2015 at 06:00:28PM +0200, Marcel Apfelbaum wrote: > >>Add bus property to PC machines and use it when looking > >>for primary PCI root bus (bus 0). > >> >

[Qemu-devel] [PATCH v5 0/4] Add an i.MX25 specific CCM driver

i.MX25 SOC has a different CCM device than i.MX31. Qemu i.MX25 emulation was built with i.MX31 CCM driver. This allows Linux to work on top of the i.MX25 emultion but this is not correct. Furthermore, other SOC we could emulate like i.MX6 have yet a different implementation of the CCM device.

[Qemu-devel] [PATCH v5 2/4] i.MX: rename i.MX CCM get_clock() function and CLK ID enum names

This is to prepare for CCM code refactoring. This is just a bit of function and enum values renaming. We also remove some useless intermediate variables. Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since

Re: [Qemu-devel] [PATCH] virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method

On 12/01/2015 09:30 PM, Shmulik Ladkani wrote: Hi, On Tue, 1 Dec 2015 18:36:39 +0200 Marcel Apfelbaum wrote: +if (pci_is_express(pci_dev) && pci_bus_is_express(pci_dev->bus) && +!pci_bus_is_root(pci_dev->bus)) { int pos; Here you should check only

Re: [Qemu-devel] [PATCH V3 3/3] hw/i386: extend pxb query for all PC machines

On 12/01/2015 08:20 PM, Eduardo Habkost wrote: On Thu, Nov 26, 2015 at 06:00:28PM +0200, Marcel Apfelbaum wrote: Add bus property to PC machines and use it when looking for primary PCI root bus (bus 0). Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 3 +--

[Qemu-devel] [PATCH v5 3/4] i.MX: Split the CCM class into an abstact base class and a concrete class.

The IMX_CCM class is now the base abstract class that is used by EPIT and GPT timer implementation. IMX31_CCM class is the concrete class implementing CCM for i.MX31 SOC. For now the i.MX25 continues to use the i.MX31 CCM implementation. An i.MX25 specific CCM will be introduced in a later

[Qemu-devel] [PATCH v3 5/6] pc: Remove enforce-aligned-dimm QOM property

The property is read-only and not used for anything. Cc: Igor Mammedov Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 11 --- include/hw/i386/pc.h | 1 - 2 files changed, 12 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c

[Qemu-devel] [PATCH v3 1/6] pc: Move compat boolean globals to PCMachineClass

This way the compat flags can be initialized in the machine_options() function. This will help us to eventually eliminate the pc_compat_*() functions. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 8 + hw/i386/pc_piix.c| 84

[Qemu-devel] [PATCH v3 6/6] pc: Move option_rom_has_mr/rom_file_has_mr globals to MachineClass

This way, these settings can be simply set on the corresponding machine_options() function, instead of requiring code in pc_compat_*() functions. Signed-off-by: Eduardo Habkost --- hw/core/loader.c| 10 +- hw/core/machine.c | 1 + hw/i386/pc_piix.c | 8

Re: [Qemu-devel] [PATCH v4 01/11] dump-guest-memory: cleanup: removing dump_{error|cleanup}().

On Tue, 12/01 21:28, Peter Xu wrote: > It might be a little bit confusing to do dump_cleanup() in these two > functions and error prone. A better way is to do dump_cleanup() I would say "It might be a little bit confusing and error prone to do dump_cleanup() in ..." Other than that,

[Qemu-devel] [PULL] tcg: Increase the highwater reservation

If there are a lot of guest memory ops in the TB, the amount of code generated by tcg_out_tb_finalize could be well more than 1k. In the short term, increase the reservation larger than any TB seen in practice. Reported-by: Aurelien Jarno Reviewed-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH for-2.5] tcg: Increase the highwater reservation

On 12/01/2015 08:40 AM, Aurelien Jarno wrote: On 2015-12-01 17:34, Aurelien Jarno wrote: On 2015-12-01 16:28, Peter Maydell wrote: On 1 December 2015 at 16:19, Richard Henderson wrote: If there are a lot of guest memory ops in the TB, the amount of code generated by

Re: [Qemu-devel] [PATCH for-2.5] tcg: Increase the highwater reservation

On 1 December 2015 at 23:06, Richard Henderson wrote: > On 12/01/2015 08:40 AM, Aurelien Jarno wrote: >> That said the problem reported is likely fixed by this commit that went >> just after it has been reported: > > > It does seem likely, but I don't see how we can know that

Re: [Qemu-devel] [PATCH v4 03/11] dump-guest-memory: using static DumpState, add DumpStatus

On Tue, 12/01 21:28, Peter Xu wrote: > Instead of malloc/free each time for DumpState, make it > static. Added DumpStatus to show status for dump. > > This is to be used for detached dump. > > Signed-off-by: Peter Xu > --- > dump.c| 20 +--- >

Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

Thomas Huth, on Tue 01 Dec 2015 22:28:10 +0100, wrote: > Are you still planning to rebase the patches again to current master and > repost them, so we could maybe get this in for QEMU 2.6 ? If we can get this reviewed, yes, sure! > If you put me on CC:, I can try to review the series if you like

[Qemu-devel] [PULL for-2.5] TCG highwater fix

/qemu.git tags/pull-tcg-20151201 for you to fetch changes up to b17a6d3390f87620735f7efb03bb1c96682ff449: tcg: Increase the highwater reservation (2015-12-01 14:36:32 -0800) Last minute fix

[Qemu-devel] [PATCH for-2.6 2/3] iotests: 124: move incremental failure test

Code motion only, in preparation for adjusting the setUp procedure for this test. Signed-off-by: John Snow --- tests/qemu-iotests/124 | 117 + 1 file changed, 60 insertions(+), 57 deletions(-) diff --git a/tests/qemu-iotests/124

[Qemu-devel] [PATCH for-2.6 3/3] iotests: 124: don't reopen qcow2

Don't create two interfaces to the same drive in the recently moved failure test. Signed-off-by: John Snow --- tests/qemu-iotests/124 | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/tests/qemu-iotests/124

[Qemu-devel] [PATCH for-2.6 0/3] iotests: 124: Don't reopen qcow2 file

Kevin caught me being Naughty, and because I don't want Santa to be mad at me, I have corrected my ways. Split iotest 124 into two classes so that the iotest that requires a blkdebug filter from the get-go can forego the standard setUp routine and just do it correct the first time. Does this

[Qemu-devel] [PATCH for-2.6 1/3] iotests: 124: Split into two test classes

Split it into an abstract test class and an implementation class. The split is primarily to facilitate more flexible setUp variations for other kinds of tests without having to rewrite or shuffle around all of these helpers. See the following two patches for more of the "why." Signed-off-by:

[Qemu-devel] [PATCH v3 2/6] pc: Move legacy_acpi_table_size global to PCMachineClass

This way we can set legacy_acpi_table_size on the machine_options() functions, instead of requirng code in pc_compat_*() functions. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 40 +++- include/hw/i386/pc.h | 1 + 2 files

[Qemu-devel] [PATCH v3 0/6] pc: Initialization and compat function cleanup

This moves most compat data that are globals or PCMachineState fields to PCMachineClass. It looks like v2 (sent in August) has slipped through the cracks. Rebased to latest qemu.git, and added 2 additional patches. Eduardo Habkost (6): pc: Move compat boolean globals to PCMachineClass pc:

[Qemu-devel] [PATCH v3 3/6] pc: Move acpi_data_size global to PCMachineClass

This way we don't need code in pc_compat_*() functions to set the legacy acpi_data_size value. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 17 ++--- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- include/hw/i386/pc.h | 6 -- 4

[Qemu-devel] [PATCH v3 4/6] pc: Move enforce_aligned_dimm to PCMachineClass

enforce_aligned_dimm never changes after the machine is initialized, so it can be simply set in PCMachineClass like all the other compat fields. Cc: Igor Mammedov Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 12 +++-

Re: [Qemu-devel] [Patch v12 00/10] Block replication for continuous checkpoints

On 12/01/2015 06:40 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> Block replication is a very important feature which is used for >> continuous checkpoints(for example: COLO). >> >> You can get the detailed information about block replication from here: >>

[Qemu-devel] [PATCH 00/16] pc: Eliminate struct PcGuestInfo

This moves all data from PcGuestInfo to either PCMachineState or PCMachineClass. This series depends on other two series: * [PATCH v3 0/6] pc: Initialization and compat function cleanup * [PATCH V3 0/3] hw/pcie: Multi-root support for Q35 For reference, there's a git tree containing this series

[Qemu-devel] [PATCH 05/16] acpi: Remove unused build_facs() PcGuestInfo paramter

Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 74f0922..85a5c53 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -295,7 +295,7 @@

[Qemu-devel] [PATCH 01/16] pc: Move PcGuestInfo declaration to top of file

The struct will be used inside PCMachineState. Signed-off-by: Eduardo Habkost --- include/hw/i386/pc.h | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 9811229..a74bded

[Qemu-devel] [PATCH 04/16] acpi: Make acpi_setup() get PCMachineState as argument

Lots of PcGuestInfo fields are duplicates of PCMachineClass or PCMachineState fields. Pass PCMachineState as argument to acpi_setup(), so we can simply let the ACPI code use those fields directly. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 3 ++-

Re: [Qemu-devel] [PATCH v3 02/12] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

On Tue, Dec 01, 2015 at 04:09:48PM +0100, Paolo Bonzini wrote: > > > On 01/12/2015 03:18, Peter Xu wrote: > > I think (2) is better in term of lines of codes (and also > > clear). However I may need to keep the QMP interface (to keep the > > has_detach parameter in qmp_dump_guest_memory), so I'd

Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED

On Tue, 12/01 21:28, Peter Xu wrote: > One new QMP event DUMP_COMPLETED is added. When a dump finishes, one > DUMP_COMPLETED event will occur to notify the user. > > Signed-off-by: Peter Xu > --- > docs/qmp-events.txt | 16 > dump.c | 11

[Qemu-devel] [PATCH 06/16] acpi: Save PCMachineState on AcpiBuildState

PCMachineState will be used in some of the steps of ACPI table building. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 85a5c53..ca11c88

[Qemu-devel] [PATCH 11/16] pc: Simplify signature of xen_load_linux()

We don't need the FWCfgState return value and the PcGuestInfo parameter. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 5 + hw/i386/pc_piix.c| 2 +- include/hw/i386/pc.h | 3 +-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/hw/i386/pc.c

[Qemu-devel] [PATCH 15/16] pc: Move PcGuestInfo.apic_xrupt_override field to PCMachineState

Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 7 --- hw/i386/pc.c | 2 +- include/hw/i386/pc.h | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 7771be7..cdbe5b9 100644 ---

[Qemu-devel] [PATCH 12/16] pc: Remove PcGuestInfo.isapc_ram_fw field

The code can use the PCMachineClass.pci_enabled field directly. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 2 +- hw/i386/pc_piix.c| 1 - hw/i386/pc_q35.c | 1 - include/hw/i386/pc.h | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 2/2] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

On Tue, Dec 01, 2015 at 11:49:31AM -0800, Sukadev Bhattiprolu wrote: > David Gibson [da...@gibson.dropbear.id.au] wrote: > | > @@ -240,6 +241,36 @@ static void rtas_ibm_get_system_parameter(PowerPCCPU > *cpu, > | > target_ulong ret = RTAS_OUT_SUCCESS; > | > > | > switch (parameter) {

Re: [Qemu-devel] [PATCH v5 01/10] vl: Don't allow CPU toplogies with partially filled cores

On Tue, Dec 01, 2015 at 11:37:03AM +1100, David Gibson wrote: > On Fri, Nov 20, 2015 at 06:24:30PM +0530, Bharata B Rao wrote: > > Prevent guests from booting with CPU topologies that have partially > > filled CPU cores or can result in partially filled CPU cores after > > CPU hotplug like > > >

Re: [Qemu-devel] [Patch v12 00/10] Block replication for continuous checkpoints

On 12/01/2015 07:58 PM, Hailiang Zhang wrote: > On 2015/12/1 18:40, Dr. David Alan Gilbert wrote: >> * Wen Congyang (we...@cn.fujitsu.com) wrote: >>> Block replication is a very important feature which is used for >>> continuous checkpoints(for example: COLO). >>> >>> You can get the detailed

[Qemu-devel] [PATCH 09/16] acpi: Remove ram size fields fron PcGuestInfo

The ACPI code can use the PCMachineState fields directly. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 10 +- hw/i386/pc.c | 2 -- include/hw/i386/pc.h | 1 - 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/i386/acpi-build.c

[Qemu-devel] [PATCH 02/16] pc: Eliminate struct PcGuestInfoState

Instead of allocating a new struct just for PcGuestInfo and the mchine_done Notifier, place them inside PCMachineState. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 27 ++- include/hw/i386/pc.h | 2 ++ 2 files changed, 12 insertions(+),

[Qemu-devel] [PATCH 03/16] pc: Remove guest_info parameter from pc_memory_init()

We can get the PcGuestInfo struct directly from PCMachineState. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 4 ++-- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- include/hw/i386/pc.h | 3 +-- 4 files changed, 5 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH 07/16] acpi: Make acpi_build() get PCMachineState as argument

Some PCMachineState and PCMachineClass fields will be used by acpi_build(). Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index ca11c88..b1548e7

[Qemu-devel] [PATCH 13/16] q35: Remove MCHPCIState.guest_info field

The field is not used for anything. Signed-off-by: Eduardo Habkost --- hw/i386/pc_q35.c | 1 - include/hw/pci-host/q35.h | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index f124e59..ad7a51e 100644 --- a/hw/i386/pc_q35.c

[Qemu-devel] [PATCH 16/16] pc: Move APIC and NUMA data from PcGuestInfo to PCMachineState

With this, we can eliminate struct PcGuestInfo completely. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 25 +++-- hw/i386/pc.c | 23 ++- include/hw/i386/pc.h | 15 +-- 3 files changed, 26

[Qemu-devel] [PATCH 10/16] pc: Move PcGuestInfo.fw_cfg field to PCMachineState

Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 6 +++--- hw/i386/pc.c | 8 include/hw/i386/pc.h | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 9f2129d..efc4151 100644 ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH 41/77] ppc/pnv: Add LPC controller and hook it up with a UART and RTC

On 12/01/2015 05:43 PM, David Gibson wrote: On Tue, Nov 17, 2015 at 11:40:04AM +1100, Benjamin Herrenschmidt wrote: On Tue, 2015-11-17 at 11:32 +1100, Alexey Kardashevskiy wrote: On 11/11/2015 11:27 AM, Benjamin Herrenschmidt wrote: This adds a model of the POWER8 LPC controller. It is then

Re: [Qemu-devel] [PATCH v4 03/11] dump-guest-memory: using static DumpState, add DumpStatus

On Wed, Dec 02, 2015 at 08:46:49AM +0800, Fam Zheng wrote: > On Tue, 12/01 21:28, Peter Xu wrote: > > +if (*errp) { > > +s->status = DUMP_STATUS_FAILED; > > +} else { > > +s->status = DUMP_STATUS_COMPLETED; > > +} > > + > > To detect error, it's better to use local_err

Re: [Qemu-devel] [PATCH v4 05/11] dump-guest-memory: introduce dump_process() helper function.

On Tue, 12/01 21:28, Peter Xu wrote: > No functional change. Cleanup only. > > Signed-off-by: Peter Xu > --- > dump.c| 35 ++- > include/sysemu/dump.h | 3 +++ > 2 files changed, 25 insertions(+), 13 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v4 06/11] dump-guest-memory: disable dump when in INMIGRATE state

On Tue, 12/01 21:28, Peter Xu wrote: > Signed-off-by: Peter Xu > --- > dump.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/dump.c b/dump.c > index e46749d..65d1f7e 100644 > --- a/dump.c > +++ b/dump.c > @@ -1626,13 +1626,17 @@ void

Re: [Qemu-devel] [PATCH v4 09/11] DumpState: adding total_size and written_size fields

On Tue, 12/01 21:28, Peter Xu wrote: > Here, total_size is the size in bytes to be dumped (raw data, which > means before compression), while written_size are bytes handled (raw > size too). > > Signed-off-by: Peter Xu > --- > dump.c| 32

[Qemu-devel] [PATCH 14/16] acpi: Use PCMachineClass fields directly

Remove the fields: legacy_acpi_table_size, has_acpi_build, has_reserved_memory, and rsdp_in_ram from PcGuestInfo, and let the ACPI code use the PCMachineClass fields directly. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 11 ++- hw/i386/pc.c |

[Qemu-devel] [PATCH 08/16] acpi: Make build_srat() get PCMachineState as argument

Some PCMachineState and PCMachineClass fields will be used by build_srat(). Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b1548e7..8841798

[Qemu-devel] [PATCH] tests/vhost-user-test: Fix potential use-after-free

ae31fb5 "vhost-user-test: wrap server in TestServer struct" cleaned up the handling of the test server in vhost-user-test. Unfortunately it introduced a subtle use-after-free if a race goes the wrong way. When the server structure is freed inside test_server_free() the GThread started earlier is

Re: [Qemu-devel] [PATCH v4 01/11] dump-guest-memory: cleanup: removing dump_{error|cleanup}().

On Wed, Dec 02, 2015 at 08:37:36AM +0800, Fam Zheng wrote: > On Tue, 12/01 21:28, Peter Xu wrote: > > It might be a little bit confusing to do dump_cleanup() in these two > > functions and error prone. A better way is to do dump_cleanup() > > I would say "It might be a little bit confusing and

Re: [Qemu-devel] Highlighting changes in QEMU 2.5

On 12/01/2015 07:16 AM, Amit Shah wrote: > Ping. > > I haven't received any responses so far, please let me know if you're > planning on doing this. > > Thanks, > I did amend the changelog on the wiki for my part, but I don't have anything better than a webcam. I have hunches that hewn

[Qemu-devel] [PATCH] tests/vhost-user-bridge.c: fix fd leakage

This fixes file descriptor leakage in vhost-user-bridge application. Whenever a new callfd or kickfd is set, the previous one should be explicitly closed. File descriptors used to map guest's memory are closed immediately after mmap call. Signed-off-by: Victor Kaplansky ---

Re: [Qemu-devel] [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

On Tue, Dec 1, 2015 at 7:28 AM, Michael S. Tsirkin wrote: > On Tue, Dec 01, 2015 at 11:04:31PM +0800, Lan, Tianyu wrote: >> >> >> On 12/1/2015 12:07 AM, Alexander Duyck wrote: >> >They can only be corrected if the underlying assumptions are correct >> >and they aren't. Your

Re: [Qemu-devel] [PATCH V3 3/3] hw/i386: extend pxb query for all PC machines

On Tue, Dec 01, 2015 at 06:50:15PM +0200, Marcel Apfelbaum wrote: > On 12/01/2015 05:09 PM, Eduardo Habkost wrote: > >On Tue, Dec 01, 2015 at 04:55:57PM +0200, Marcel Apfelbaum wrote: > >>On 12/01/2015 04:48 PM, Eduardo Habkost wrote: > >>>On Tue, Dec 01, 2015 at 04:07:33PM +0200, Marcel Apfelbaum

Re: [Qemu-devel] [PATCH for-2.5] tcg: Increase the highwater reservation

On 12/01/2015 08:28 AM, Peter Maydell wrote: On 1 December 2015 at 16:19, Richard Henderson wrote: If there are a lot of guest memory ops in the TB, the amount of code generated by tcg_out_tb_finalize could be well more than 1k. In the short term, increase the reservation

[Qemu-devel] [QEMU 2.1.2] block in bdrv_drain_all()

Hi, I am using qemu 2.1.2 and some VMs hang while playing videos. QEMU parameters and stack information is as follows: /usr/bin/qemu-system-x86_64 -name S398_ABC-047 -S -machine pc-i440fx-2.1,accel=kvm,usb=off -m 1024 -realtime mlock=off -smp 1,sockets=1,cores=1,threads=1 -uuid

Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area

On Tue, Dec 01, 2015 at 09:09:47AM -0800, Richard Henderson wrote: > On 11/30/2015 03:18 AM, Paolo Bonzini wrote: > >Because this is always little endian, I would write it as uint8_t[16][16]. > > Maybe. That isn't altogether handy for TCG, since we'll be wanting to bswap > these buffers

Re: [Qemu-devel] [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

On Tue, Dec 01, 2015 at 09:04:32AM -0800, Alexander Duyck wrote: > On Tue, Dec 1, 2015 at 7:28 AM, Michael S. Tsirkin wrote: > > On Tue, Dec 01, 2015 at 11:04:31PM +0800, Lan, Tianyu wrote: > >> > >> > >> On 12/1/2015 12:07 AM, Alexander Duyck wrote: > >> >They can only be

Re: [Qemu-devel] [PATCH V3 3/3] hw/i386: extend pxb query for all PC machines

On 12/01/2015 05:09 PM, Eduardo Habkost wrote: On Tue, Dec 01, 2015 at 04:55:57PM +0200, Marcel Apfelbaum wrote: On 12/01/2015 04:48 PM, Eduardo Habkost wrote: On Tue, Dec 01, 2015 at 04:07:33PM +0200, Marcel Apfelbaum wrote: On 11/30/2015 05:07 PM, Eduardo Habkost wrote: On Sun, Nov 29,

[Qemu-devel] [QEMU 2.1.2] block in bdrv_drain_all()

Hi, I am using qemu 2.1.2 and some VMs hang while playing videos. QEMU parameters and stack information is as follows: /usr/bin/qemu-system-x86_64 -name S398_ABC-047 -S -machine pc-i440fx-2.1,accel=kvm,usb=off -m 1024 -realtime mlock=off -smp 1,sockets=1,cores=1,threads=1 -uuid

[Qemu-devel] [QEMU 2.12] block in bdrv_drain_all()

Hi, I am using qemu 2.1.2 and some VMs hang while playing videos. QEMU parameters and stack information is as follows: /usr/bin/qemu-system-x86_64 -name S398_ABC-047 -S -machine pc-i440fx-2.1,accel=kvm,usb=off -m 1024 -realtime mlock=off -smp 1,sockets=1,cores=1,threads=1 -uuid

Re: [Qemu-devel] [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target

> What do you think about virtio-nvme+vhost-nvme? What would be the advantage over virtio-blk? Multiqueue is not supported by QEMU but it's already supported by Linux (commit 6a27b656fc). To me, the advantage of nvme is that it provides more than decent performance on unmodified Windows

Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area

On 11/30/2015 03:18 AM, Paolo Bonzini wrote: Because this is always little endian, I would write it as uint8_t[16][16]. Maybe. That isn't altogether handy for TCG, since we'll be wanting to bswap these buffers (probably in uint64_t chunks). r~

Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area

On 12/01/2015 09:15 AM, Eduardo Habkost wrote: On Tue, Dec 01, 2015 at 09:09:47AM -0800, Richard Henderson wrote: On 11/30/2015 03:18 AM, Paolo Bonzini wrote: Because this is always little endian, I would write it as uint8_t[16][16]. Maybe. That isn't altogether handy for TCG, since we'll

Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area

On 01/12/2015 18:20, Richard Henderson wrote: >> >> X86XSaveArea will be used only when loading/saving state using >> xsave, not for executing regular instructions. > > ... like the regular instruction xsave? > > https://patchwork.ozlabs.org/patch/493318/ Right, but that's a helper anyway.

Re: [Qemu-devel] [RFC PATCH 0/9] Add colo-proxy based on netfilter

* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > > Hi,all > > This patch add an colo-proxy object, COLO-Proxy is a part of COLO, > based on qemu netfilter and it's a plugin for qemu netfilter. the function > keep Secondary VM connect normal to Primary VM and compare packets > sent by PVM

Re: [Qemu-devel] [PATCH COLO-Frame v11 14/39] ram: Split host_from_stream_offset() into two helper functions

* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > Split host_from_stream_offset() into two parts: > One is to get ram block, which the block idstr may be get from migration > stream, the other is to get hva (host) address from block and the offset. > > Signed-off-by: zhanghailiang

[Qemu-devel] Regression: Xen guest with 5G of RAM on 32bit fail to boot

Hi, Under Xen, a guest with 5G of RAM, with a 32bit binary QEMU (well, with a 32bit dom0) does not boot anymore. QEMU abort() with "Bad ram offset efffd000". This issue first appear in 4ed023ce2a39ab5812d33cf4d819def168965a7f (Round up RAMBlock sizes to host page sizes). The problem is in

Re: [Qemu-devel] [PATCH V3 3/3] hw/i386: extend pxb query for all PC machines

On Thu, Nov 26, 2015 at 06:00:28PM +0200, Marcel Apfelbaum wrote: > Add bus property to PC machines and use it when looking > for primary PCI root bus (bus 0). > > Signed-off-by: Marcel Apfelbaum > --- > hw/i386/acpi-build.c | 3 +-- > hw/i386/pc.c | 2 +- >

Re: [Qemu-devel] [PATCH RFC] allow to delete sheepdog snapshot

2015-12-02 8:23 GMT+03:00 Hitoshi Mitake : > Seems that your patch violates the coding style of qemu. You can check the > style with scripts/checkpatch.pl. > > > Comment outed code isn't good. You should remove it (in addition, it > wouldn't be required). Thanks! --

[Qemu-devel] [PATCH v9 1/5] nvdimm: implement NVDIMM device abstract

Introduce "nvdimm" device which is based on pc-dimm device type Currently, nothing is specific for nvdimm but hotplug is disabled Reviewed-by: Stefan Hajnoczi Signed-off-by: Xiao Guangrong --- default-configs/i386-softmmu.mak | 1 +

[Qemu-devel] [PATCH v9 0/5] implement vNVDIMM

This patchset can be found at: https://github.com/xiaogr/qemu.git nvdimm-v9 It is based on pci branch on Michael's tree and the top commit is: commit 0c73277af7 (vhost-user-test: fix crash with glib < 2.36). Changelog in v9: - the changes address Michael's comments: 1) move the control

[Qemu-devel] [PATCH v9 3/5] nvdimm acpi: build ACPI NFIT table

NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) Currently, we only support PMEM mode. Each device has 3 structures: - SPA structure, defines the PMEM region info - MEM DEV structure, it has the @handle which is used to associate specified ACPI NVDIMM device we will

[Qemu-devel] [PATCH v9 2/5] acpi: support specified oem table id for build_header

Let build_header() support specified OEM table id so that we can build multiple SSDT later If the oem table id is not specified (aka, NULL), we use the default id instead as the previous behavior Reviewed-by: Stefan Hajnoczi Signed-off-by: Xiao Guangrong

Re: [Qemu-devel] [PATCH v4 06/11] dump-guest-memory: disable dump when in INMIGRATE state

On Wed, Dec 02, 2015 at 08:50:48AM +0800, Fam Zheng wrote: > On Tue, 12/01 21:28, Peter Xu wrote: > > /* if there is a dump in background, we should wait until the dump > > * finished */ > > if (dump_in_progress()) { > > error_setg(errp, "There is a dump in process, please

[Qemu-devel] [PATCH v9 4/5] nvdimm acpi: build ACPI nvdimm devices

NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices There is a root device under \_SB and specified NVDIMM devices are under the root device. Each NVDIMM device has _ADR which returns its handle used to associate MEMDEV structure in NFIT Currently, we do not support any function on _DSM,

[Qemu-devel] [PATCH v9 5/5] nvdimm: add maintain info

Add NVDIMM maintainer Reviewed-by: Stefan Hajnoczi Signed-off-by: Xiao Guangrong --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bb1f3e4..7e82340 100644 --- a/MAINTAINERS +++

Re: [Qemu-devel] [Patch v12 00/10] Block replication for continuous checkpoints

On 12/02/2015 09:00 AM, Wen Congyang wrote: > On 12/01/2015 06:40 PM, Dr. David Alan Gilbert wrote: >> * Wen Congyang (we...@cn.fujitsu.com) wrote: >>> Block replication is a very important feature which is used for >>> continuous checkpoints(for example: COLO). >>> >>> You can get the detailed

Re: [Qemu-devel] [PATCH] vhost-user: verify that number of queues is non-zero

On 12/01/2015 09:32 PM, Victor Kaplansky wrote: > Fix QEMU crash when -netdev type=vhost-user,queues=n is passed > with zero number of queues. > > Signed-off-by: Victor Kaplansky > --- > net/vhost-user.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [Qemu-devel] Highlighting changes in QEMU 2.5

On Tue, Dec 01, 2015 at 11:45:15AM -0500, John Snow wrote: > On 12/01/2015 07:16 AM, Amit Shah wrote: > > Ping. > > > > I haven't received any responses so far, please let me know if you're > > planning on doing this. > > > > Thanks, > > > > I did amend the changelog on the wiki for my part,

[Qemu-devel] scripts/gdb: Fix a python exception in mtree.py

The following exception is threw: Python Exception name 'long' is not defined: Error occurred in Python command: name 'long' is not defined In python3, long is rename to int Signed-off-by: Yang Wei --- scripts/qemugdb/mtree.py | 17 - 1 file changed, 12

Re: [Qemu-devel] [PATCH v5 04/10] cpu: Reclaim vCPU objects

On Mon, Nov 30, 2015 at 06:30:52PM +1100, Alexey Kardashevskiy wrote: > On 11/20/2015 11:54 PM, Bharata B Rao wrote: > >From: Gu Zheng > > > >In order to deal well with the kvm vcpus (which can not be removed without > >any > >protection), we do not close KVM vcpu fd,

[Qemu-devel] [PATCH v14 04/15] qapi: Simplify visiting of alternate types

Previously, working with alternates required two lookup arrays and some indirection: for type Foo, we created Foo_qtypes[] which maps each qtype to a value of the generated FooKind enum, then look up that value in FooKind_lookup[] like we do for other union types. This has a couple of subtle

[Qemu-devel] [PATCH v14 07/15] qapi: Fix alternates that accept 'number' but not 'int'

The QMP input visitor allows integral values to be assigned by promotion to a QTYPE_QFLOAT. However, when parsing an alternate, we did not take this into account, such that an alternate that accepts 'number' and some other type, but not 'int', would reject integral values. With this patch, we

[Qemu-devel] [PATCH v14 14/15] qapi: Move duplicate collision checks to schema check()

With the recent commit 'qapi: Detect collisions in C member names', we have two different locations for detecting clashes - one at parse time, and another at QAPISchema*.check() time. Remove all of the ad hoc parser checks, and delete associated code (for example, the global check_member_clash()

[Qemu-devel] [PATCH v14 11/15] qapi: Track enum values by QAPISchemaMember, not string

Rather than using just an array of strings, make enum.values be an array of the new QAPISchemaMember type, and add a helper member_names() method to get back at the original list of names. Likewise, creating an enum requires wrapping strings, via a new QAPISchema._make_enum_members() method. The

Re: [Qemu-devel] [PATCH RFC] allow to delete sheepdog snapshot

On Wed, Dec 2, 2015 at 1:12 AM, Vasiliy Tolstov wrote: > Signed-off-by: Vasiliy Tolstov > --- > block/sheepdog.c | 59 > ++-- > 1 file changed, 57 insertions(+), 2 deletions(-) > Seems that your

[Qemu-devel] [Patch v12 resend 05/10] docs: block replication's description

Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- docs/block-replication.txt | 227 + 1 file changed, 227 insertions(+) create mode

[Qemu-devel] [Patch v12 resend 06/10] Add new block driver interfaces to control block replication

Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Luiz Capitulino Cc: Michael Roth Reviewed-by: Paolo Bonzini

  1   2   3   >