Re: [Qemu-devel] [PATCH] i2c-tiny-usb: add new usb to i2c bridge

2016-01-04 Thread Gerd Hoffmann
> +case 0x4107: > +/* this seems to be a byte type access */ > +if (i2c_start_transfer(s->i2cbus, /*address*/index, 0)) { > +trace_usb_i2c_tiny_i2c_start_transfer_failed(); > +p->actual_length = 0; /* write failure */ > +break; > +} >

[Qemu-devel] [PATCH v2 2/3] qemu-nbd: Minor texi updates

2016-01-04 Thread Sitsofe Wheeler
- Change some spacing. - Add disconnect usage to synopsis. - Highlight the command and its options in the synopsis. - Fix up the grammar in the description. - Move filename variable description out of the option table. - Add a description of the dev variable. - Remove duplicate entry for --format.

[Qemu-devel] [PATCH v2 3/3] qemu-nbd: Fix texi sentence capitalisation

2016-01-04 Thread Sitsofe Wheeler
Capitalise the first letter of sentences (and reword for grammar) the options section of qemu-nbd.texi. Signed-off-by: Sitsofe Wheeler --- qemu-nbd.texi | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/qemu-nbd.texi b/qemu-nbd.texi inde

[Qemu-devel] [PATCH v2 1/3] qemu-nbd: Fix unintended texi verbatim formatting

2016-01-04 Thread Sitsofe Wheeler
Indented lines in the texi meant the perlpod produced interpreted the paragraph as being verbatim (thus formatting codes were not interpreted). Fix this by un-indenting problem lines. Signed-off-by: Sitsofe Wheeler --- qemu-nbd.texi | 58 +-

Re: [Qemu-devel] [PATCH v2 1/4] Add Error **errp for xen_host_pci_device_get()

2016-01-04 Thread Cao jin
On 01/04/2016 11:15 PM, Stefano Stabellini wrote: On Sun, 27 Dec 2015, Cao jin wrote: To catch the error msg. Also modify the caller Signed-off-by: Cao jin This looks much better, thanks. [...] -int xen_host_pci_device_get(XenHostPCIDevice *d, uint16_t domain, -

Re: [Qemu-devel] [PATCH 0/2] Fix some coverity reported defects

2016-01-04 Thread Gerd Hoffmann
On Mi, 2015-12-23 at 14:39 +0530, Bandan Das wrote: > The first change replaces QLIST_FOREACH with the safe variant > and the second was incorrectly using MTPObject * in the trace function > after freeing it. > > Bandan Das (2): > usb-mtp: use safe variant when cleaning events list > usb-mtp:

Re: [Qemu-devel] [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

2016-01-04 Thread Gerd Hoffmann
Hi, > like this? > > cgroup_controllers = [ "cpu", "memory", "blkio", "cpuset", "cpuacct" ] yes (+libvirtd restart so it re-reads the config). cheers, Gerd

Re: [Qemu-devel] [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

2016-01-04 Thread Gerd Hoffmann
On Mo, 2016-01-04 at 13:19 +, Jonathan Scruggs wrote: > Oh. I just changed /dev/input/eventx (replace x with correct number > for my devices) to permissions of 666 and it worked. I guess I had to > change the conf file and change the permissions. Is there a way to > make the devices work with q

Re: [Qemu-devel] [PATCH] sdhci: add quirk property for card insert interrupt status on Raspberry Pi

2016-01-04 Thread Peter Crosthwaite
On Mon, Jan 4, 2016 at 2:12 PM, Andrew Baumann wrote: >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Thursday, 31 December 2015 21:38 >> On Thu, Dec 31, 2015 at 1:40 PM, Andrew Baumann >> wrote: >> > This quirk is a workaround for the following hardware behaviour, on >> >

Re: [Qemu-devel] [XenGT][IGVT-g] Device model creation failed

2016-01-04 Thread Tian, Kevin
For below error: [ 5023.070461] vGT error:(g2h_gm_range:1660) VM(21): invalid address range: g_addr(0x1000), size(0x1000) Likely you didn’t use a XenGT-aware i915 driver inside VM, which is required e.g. to handle address space ballooning. A simple way is to copy same Dom0 kernel/initrd/module

Re: [Qemu-devel] [PATCH v2 1/4] Add Error **errp for xen_host_pci_device_get()

2016-01-04 Thread Cao jin
On 01/04/2016 11:15 PM, Stefano Stabellini wrote: On Sun, 27 Dec 2015, Cao jin wrote: To catch the error msg. Also modify the caller Signed-off-by: Cao jin This looks much better, thanks. [...] -int xen_host_pci_device_get(XenHostPCIDevice *d, uint16_t domain, -

Re: [Qemu-devel] [PATCH v3 1/1] xlnx-zynqmp: Add support for high DDR memory regions

2016-01-04 Thread Peter Crosthwaite
On Mon, Jan 4, 2016 at 12:47 PM, Alistair Francis wrote: > The Xilinx ZynqMP SoC and EP108 board supports three memory regions: > - A 2GB region starting at 0 > - A 32GB region starting at 32GB > - A 256GB region starting at 768GB > > This patch adds support for the first two memory regions, wh

Re: [Qemu-devel] [PATCH v4 11/14] vmdk: Return extent's file in bdrv_get_block_status

2016-01-04 Thread Fam Zheng
On Mon, 01/04 21:48, Max Reitz wrote: > On 24.12.2015 06:50, Fam Zheng wrote: > > Reviewed-by: Stefan Hajnoczi > > Signed-off-by: Fam Zheng > > --- > > block/vmdk.c | 11 +-- > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > diff --git a/block/vmdk.c b/block/vmdk.c > > index f

Re: [Qemu-devel] [PATCH v4 01/14] block: Add "file" output parameter to block status query functions

2016-01-04 Thread Fam Zheng
On Mon, 01/04 22:00, Max Reitz wrote: > On 24.12.2015 06:50, Fam Zheng wrote: > > The added parameter can be used to return the BDS pointer which the > > valid offset is referring to. It's value should be ignored unless > > *Its > > > BDRV_BLOCK_OFFSET_VALID in ret is set. > > > > Until block dr

Re: [Qemu-devel] [PATCH v5 0/4] Extend TPM support with a QEMU-external TPM

2016-01-04 Thread Stefan Berger
"Xu, Quan" wrote on 01/04/2016 08:26:03 PM: > Date: 01/04/2016 08:26 PM > Subject: RE: [PATCH v5 0/4] Extend TPM support with a QEMU-external TPM > > On January 04 2016 11:23 PM, wrote: > > The following series of patches extends TPM support with an > external TPM that > > offers a Linux CUSE

Re: [Qemu-devel] [RFC PATCH 0/3] x86: Add support for guest DMA dirty page tracking

2016-01-04 Thread Alexander Duyck
On Mon, Jan 4, 2016 at 12:41 PM, Konrad Rzeszutek Wilk wrote: > On Sun, Dec 13, 2015 at 01:28:09PM -0800, Alexander Duyck wrote: >> This patch set is meant to be the guest side code for a proof of concept >> involving leaving pass-through devices in the guest during the warm-up >> phase of guest l

[Qemu-devel] [PATCH v8 4/4] arm_mptimer: Convert to use ptimer

2016-01-04 Thread Dmitry Osipenko
Current ARM MPTimer implementation uses QEMUTimer for the actual timer, this implementation isn't complete and mostly tries to duplicate of what generic ptimer is already doing fine. Conversion to ptimer brings the following benefits and fixes: - Simple timer pausing implementation

[Qemu-devel] [PATCH v8 2/4] hw/ptimer: Perform tick and counter wrap around if timer already expired

2016-01-04 Thread Dmitry Osipenko
ptimer_get_count() might be called while QEMU timer already been expired. In that case ptimer would return counter = 0, which might be undesirable in case of polled timer. Do counter wrap around for periodic timer to keep it distributed. In addition, there is no reason to keep expired timer tick d

[Qemu-devel] [PATCH v8 3/4] hw/ptimer: Update .delta on period/freq change

2016-01-04 Thread Dmitry Osipenko
Delta value must be updated on period/freq change, otherwise running timer would be restarted (counter reloaded with old delta). Only m68k/mcf520x and arm/arm_timer devices are currently doing freq change correctly, i.e. stopping the timer. Perform delta update to fix affected devices and eliminate

[Qemu-devel] [PATCH v8 1/4] hw/ptimer: Fix issues caused by the adjusted timer limit value

2016-01-04 Thread Dmitry Osipenko
Multiple issues here related to the timer with a adjusted .limit value: 1) ptimer_get_count() returns incorrect counter value for the disabled timer after loading the counter with a small value, because adjusted limit value is used instead of the original. For instance: 1) ptimer_stop(t)

[Qemu-devel] [PATCH v8 0/4] PTimer fixes and ARM MPTimer conversion

2016-01-04 Thread Dmitry Osipenko
Changelog for ARM MPTimer QEMUTimer to ptimer conversion: V2: Fixed changing periodic timer counter value "on the fly". I added a test to the gist to cover that issue. V3: Fixed starting the timer with load = 0 and counter != 0, added tests to the gist for this issue. Chan

Re: [Qemu-devel] [Qemu-ppc] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-04 Thread Programmingkid
> As the IDEState lba field is an int32_t, make sure we cast to int64_t before > shifting to calculate the offset. Otherwise we end up with an overflow when > trying to access sectors beyond 2GB as can occur when using DVD images. > > Signed-off-by: Mark Cave-Ayland > --- > hw/ide/macio.c |2

Re: [Qemu-devel] [PATCH v5 0/4] Extend TPM support with a QEMU-external TPM

2016-01-04 Thread Xu, Quan
On January 04 2016 11:23 PM, wrote: > The following series of patches extends TPM support with an external TPM that > offers a Linux CUSE (character device in userspace) interface. This TPM lets > each VM access its own private vTPM. > The CUSE TPM supports suspend/resume and migration. Much out-o

[Qemu-devel] [v15 08/15] vfio: add check host bus reset is support or not

2016-01-04 Thread Cao jin
From: Chen Fan when init vfio devices done, we should test all the devices supported aer whether conflict with others. For each one, get the hot reset info for the affected device list. For each affected device, all should attach to the VM and on/below the same bus. also, we should test all of t

[Qemu-devel] [v15 14/15] vfio-pci: pass the aer error to guest

2016-01-04 Thread Cao jin
From: Chen Fan when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, the results in the qemu eventfd handler getting invoked. this patch is to pass the error to guest and have the guest driver recover from the

[Qemu-devel] [v15 12/15] vfio: add bus in reset flag

2016-01-04 Thread Cao jin
From: Chen Fan mark the host bus be in reset. avoid multiple devices trigger the host bus reset many times. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 6 ++ include/hw/vfio/vfio-common.h | 1 + 2 files changed, 7 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c in

[Qemu-devel] [v15 05/15] vfio: add pcie extanded capability support

2016-01-04 Thread Cao jin
From: Chen Fan For vfio pcie device, we could expose the extended capability on PCIE bus. in order to avoid config space broken, we introduce a copy config for parsing extended caps. and rebuild the pcie extended config space. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 70

[Qemu-devel] [v15 09/15] add check reset mechanism when hotplug vfio device

2016-01-04 Thread Cao jin
From: Chen Fan Since we support multi-function hotplug. the function 0 indicate the closure of the slot, so we have the chance to do the check. Signed-off-by: Chen Fan --- hw/pci/pci.c | 29 + hw/vfio/pci.c| 19 +++ hw/vfio/pc

[Qemu-devel] [v15 15/15] vfio: add 'aer' property to expose aercap

2016-01-04 Thread Cao jin
From: Chen Fan add 'aer' property to let user able to decide whether expose the aer capability. by default we should disable aer feature, because it needs configuration restrictions. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vfio/pci.c b

[Qemu-devel] [v15 13/15] pcie_aer: expose pcie_aer_msg() interface

2016-01-04 Thread Cao jin
From: Chen Fan For vfio device, we need to propagate the aer error to Guest OS. we use the pcie_aer_msg() to send aer error to guest. Signed-off-by: Chen Fan Reviewed-by: Michael S. Tsirkin --- hw/pci/pcie_aer.c | 2 +- include/hw/pci/pcie_aer.h | 1 + 2 files changed, 2 insertions(+)

[Qemu-devel] [v15 04/15] vfio: make the 4 bytes aligned for capability size

2016-01-04 Thread Cao jin
From: Chen Fan this function search the capability from the end, the last size should 0x100 - pos, not 0xff - pos. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index a63cf85..288f2c7 100644 --- a/h

[Qemu-devel] [v15 11/15] vfio: add hot reset callback

2016-01-04 Thread Cao jin
From: Chen Fan For Vfio device, Once need to recovery devices by bus reset such as AER, we always need to reset the host bus to recovery the devices under the bus, so we need to specify to do host bus reset. --- hw/vfio/pci.c | 15 +++ hw/vfio/pci.h | 1 + 2 files changed, 16 insert

[Qemu-devel] [v15 01/15] vfio: extract vfio_get_hot_reset_info as a single function

2016-01-04 Thread Cao jin
From: Chen Fan the function is used to get affected devices by bus reset. so here extract it, and can used for aer soon. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 66 +++ 1 file changed, 48 insertions(+), 18 deletions(-) diff --git a/h

[Qemu-devel] [v15 10/15] pci: Introduce device hot reset

2016-01-04 Thread Cao jin
From: Chen Fan The secondary bus reset in bridge control register setting trigger a hot reset, Specially for vfio device, we usually need to do a hot reset for the host bus other than the device reset. Signed-off-by: Chen Fan --- hw/core/qdev.c | 24 hw/pci/pci

[Qemu-devel] [v15 03/15] pcie: modify the capability size assert

2016-01-04 Thread Cao jin
From: Chen Fan Device's Offset and size can reach PCIE_CONFIG_SPACE_SIZE, fix the corresponding assert. Signed-off-by: Chen Fan Reviewed-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c

[Qemu-devel] [v15 07/15] vfio: add aer support for vfio device

2016-01-04 Thread Cao jin
From: Chen Fan Calling pcie_aer_init to initilize aer related registers for vfio device, then reload physical related registers to expose device capability. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 81 --- hw/vfio/pci.h | 3 +++ 2 fil

[Qemu-devel] [v15 06/15] aer: impove pcie_aer_init to support vfio device

2016-01-04 Thread Cao jin
From: Chen Fan pcie_aer_init was used to emulate an aer capability for pcie device, but for vfio device, the aer config space size is mutable and is not always equal to PCI_ERR_SIZEOF(0x48). it depends on where the TLP Prefix register required, so here we add a size argument. Signed-off-by: Chen

[Qemu-devel] [v15 00/15] vfio-pci: pass the aer error to guest

2016-01-04 Thread Cao jin
From: Chen Fan For now, for vfio pci passthough devices when qemu receives an error from host aer report, currentlly just terminate the guest, but usually user want to know what error occurred but stopping the guest, so this patches add aer capability support for vfio device, and pass the error t

[Qemu-devel] [v15 02/15] vfio: squeeze out vfio_pci_do_hot_reset for support bus reset

2016-01-04 Thread Cao jin
From: Chen Fan squeeze out vfio_pci_do_hot_reset to do host bus reset when AER recovery. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 75 +++ 1 file changed, 44 insertions(+), 31 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c ind

[Qemu-devel] [PATCH v2] l2tpv3: fix cookie decoding

2016-01-04 Thread Alexis Dambricourt
If a 32 bits l2tpv3 frame cookie MSB if set to 1, the cast to uint64_t cookie will spread 1 to the four most significant bytes. Then the condition (cookie != s->rx_cookie) becomes false. Signed-off-by: Alexis Dambricourt --- net/l2tpv3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification

2016-01-04 Thread John Snow
Since Max didn't offer a grammatical review, here's my attempt at some suggestions. On 12/23/2015 12:49 PM, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store vi

Re: [Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification

2016-01-04 Thread John Snow
On 12/24/2015 05:00 AM, Vladimir Sementsov-Ogievskiy wrote: > On 24.12.2015 02:41, Eric Blake wrote: >> On 12/23/2015 10:49 AM, Vladimir Sementsov-Ogievskiy wrote: >>> The new feature for qcow2: storing bitmaps. >>> >>> This patch adds new header extension to qcow2 - Bitmaps Extension. It >>> pro

Re: [Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification

2016-01-04 Thread Max Reitz
On 23.12.2015 18:49, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one type of such bi

Re: [Qemu-devel] [PATCH] sdhci: add quirk property for card insert interrupt status on Raspberry Pi

2016-01-04 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Thursday, 31 December 2015 21:38 > On Thu, Dec 31, 2015 at 1:40 PM, Andrew Baumann > wrote: > > This quirk is a workaround for the following hardware behaviour, on > > which UEFI (specifically, the bootloader for Windows on Pi2)

Re: [Qemu-devel] [Bug 1529859] [NEW] qemu 2.5.0 ivshmem segfault with msi=off option

2016-01-04 Thread Marc-André Lureau
See previously posted patch: http://lists.gnu.org/archive/html/qemu-stable/2015-12/msg00034.html On Mon, Jan 4, 2016 at 9:24 PM, Eric Blake wrote: > On 12/29/2015 06:38 AM, maquefel wrote: >> Public bug reported: >> >> Launching qemu with "-device ivshmem,chardev=ivshmemid,msi=off -chardev >> so

Re: [Qemu-devel] [PATCH 2/6] device_tree: introduce load_device_tree_from_sysfs

2016-01-04 Thread Peter Maydell
On 4 January 2016 at 17:37, Eric Auger wrote: > Hi Peter, > On 12/18/2015 03:10 PM, Peter Maydell wrote: >> Does this code compile on non-Linux hosts? (You've put it in a file >> which is built everywhere, but it's definitely semantically Linux >> specific.) > > I struggled quite a lot while cross

Re: [Qemu-devel] [PATCH v5 4/6] expose floppy drive geometry and CMOS type

2016-01-04 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 03:44:42PM -0500, John Snow wrote: > > > On 12/30/2015 03:11 PM, Roman Kagan wrote: > > Make it possible to query the geometry and the CMOS type of a floppy > > drive outside of the respective source files. > > > > It will be useful, in particular, when dynamically buildi

Re: [Qemu-devel] [PATCH v4 00/14] qemu-img map: Allow driver to return file of the allocated block

2016-01-04 Thread Max Reitz
On 24.12.2015 06:50, Fam Zheng wrote: > v4: Rebase and resend, adding Eric's and Stefan's reviewed-by. > > Fix one typo in patch 13. > > Drop previous patch 14 for a later rework because it is not a hard > requirement, but it is pending on Eric's QAPI-to-JSON visitor series: > >

Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-04 Thread John Snow
On 01/04/2016 03:54 PM, Mark Cave-Ayland wrote: > On 04/01/16 20:36, John Snow wrote: > >> On 01/04/2016 02:15 PM, Mark Cave-Ayland wrote: >>> On 04/01/16 19:04, P J P wrote: >>> +-- On Mon, 4 Jan 2016, Mark Cave-Ayland wrote --+ | /* Calculate current offset */ | -offset

Re: [Qemu-devel] [PATCH v4 01/14] block: Add "file" output parameter to block status query functions

2016-01-04 Thread Max Reitz
On 24.12.2015 06:50, Fam Zheng wrote: > The added parameter can be used to return the BDS pointer which the > valid offset is referring to. It's value should be ignored unless *Its > BDRV_BLOCK_OFFSET_VALID in ret is set. > > Until block drivers fill in the right value, let's clear it explicitly

Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-04 Thread Mark Cave-Ayland
On 04/01/16 20:36, John Snow wrote: > On 01/04/2016 02:15 PM, Mark Cave-Ayland wrote: >> On 04/01/16 19:04, P J P wrote: >> >>> +-- On Mon, 4 Jan 2016, Mark Cave-Ayland wrote --+ >>> | /* Calculate current offset */ >>> | -offset = (int64_t)(s->lba << 11) + s->io_buffer_index; >>> | +

Re: [Qemu-devel] [PATCH v2 1/1] xlnx-zynqmp: Add support for high DDR memory regions

2016-01-04 Thread Alistair Francis
On Wed, Dec 30, 2015 at 6:35 PM, Peter Crosthwaite wrote: > On Wed, Dec 30, 2015 at 6:19 PM, Peter Crosthwaite > wrote: >> This concept might also be relevant to rPI work, where the SoC aliases >> RAM. CC Andrew. >> >> On Wed, Dec 16, 2015 at 11:27 AM, Alistair Francis >> wrote: >>> The Xilinx Z

[Qemu-devel] [PATCH v3 1/1] xlnx-zynqmp: Add support for high DDR memory regions

2016-01-04 Thread Alistair Francis
The Xilinx ZynqMP SoC and EP108 board supports three memory regions: - A 2GB region starting at 0 - A 32GB region starting at 32GB - A 256GB region starting at 768GB This patch adds support for the first two memory regions, which is automatically created based on the size specified by the QEMU

Re: [Qemu-devel] [PATCH v4 11/14] vmdk: Return extent's file in bdrv_get_block_status

2016-01-04 Thread Max Reitz
On 24.12.2015 06:50, Fam Zheng wrote: > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/block/vmdk.c b/block/vmdk.c > index f5a56fd..b60a5af 100644 > --- a/block/vmdk.c > +++ b/bloc

Re: [Qemu-devel] [PATCH v5 4/6] expose floppy drive geometry and CMOS type

2016-01-04 Thread John Snow
On 12/30/2015 03:11 PM, Roman Kagan wrote: > Make it possible to query the geometry and the CMOS type of a floppy > drive outside of the respective source files. > > It will be useful, in particular, when dynamically building ACPI tables, > and will allow to properly populate the corresponding A

Re: [Qemu-devel] [RFC PATCH 0/3] x86: Add support for guest DMA dirty page tracking

2016-01-04 Thread Konrad Rzeszutek Wilk
On Sun, Dec 13, 2015 at 01:28:09PM -0800, Alexander Duyck wrote: > This patch set is meant to be the guest side code for a proof of concept > involving leaving pass-through devices in the guest during the warm-up > phase of guest live migration. In order to accomplish this I have added a What doe

Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-04 Thread John Snow
On 01/04/2016 02:15 PM, Mark Cave-Ayland wrote: > On 04/01/16 19:04, P J P wrote: > >> +-- On Mon, 4 Jan 2016, Mark Cave-Ayland wrote --+ >> | /* Calculate current offset */ >> | -offset = (int64_t)(s->lba << 11) + s->io_buffer_index; >> | +offset = ((int64_t)(s->lba) << 11) + s->io

Re: [Qemu-devel] [Bug 1529859] [NEW] qemu 2.5.0 ivshmem segfault with msi=off option

2016-01-04 Thread Eric Blake
On 12/29/2015 06:38 AM, maquefel wrote: > Public bug reported: > > Launching qemu with "-device ivshmem,chardev=ivshmemid,msi=off -chardev > socket,path=/tmp/ivshmem_socket,id=ivshmemid" > > Causes segfault because, s->msi_vectors is not initialized and > s->msi_vectors == 0. > > Does ivshmem ex

Re: [Qemu-devel] How to reserve guest physical region for ACPI

2016-01-04 Thread Laszlo Ersek
Michael CC'd me on the grandparent of the email below. I'll try to add my thoughts in a single go, with regard to OVMF. On 12/30/15 20:52, Michael S. Tsirkin wrote: > On Wed, Dec 30, 2015 at 04:55:54PM +0100, Igor Mammedov wrote: >> On Mon, 28 Dec 2015 14:50:15 +0200 >> "Michael S. Tsirkin" wrote

Re: [Qemu-devel] [PATCH v4 4/5] qmp: Add blockdev-mirror command

2016-01-04 Thread Max Reitz
On 24.12.2015 05:45, Fam Zheng wrote: > This will start a mirror job from a named device to another named > device, its relation with drive-mirror is similar with blockdev-backup > to drive-backup. > > In blockdev-mirror, the target node should be prepared by blockdev-add, > which will be responsi

Re: [Qemu-devel] [PATCH v3 4/5] qmp: Add blockdev-mirror command

2016-01-04 Thread Max Reitz
On 24.12.2015 04:25, Fam Zheng wrote: > On Thu, 12/24 01:53, Max Reitz wrote: >> On 23.12.2015 06:59, Fam Zheng wrote: >>> This will start a mirror job from a named device to another named >>> device, its relation with drive-mirror is similar with blockdev-backup >>> to drive-backup. >>> >>> In blo

Re: [Qemu-devel] [PATCH v8 1/2] mirror: Rewrite mirror_iteration

2016-01-04 Thread Max Reitz
On 24.12.2015 04:15, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > > Signed-

Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-04 Thread Mark Cave-Ayland
On 04/01/16 19:04, P J P wrote: > +-- On Mon, 4 Jan 2016, Mark Cave-Ayland wrote --+ > | /* Calculate current offset */ > | -offset = (int64_t)(s->lba << 11) + s->io_buffer_index; > | +offset = ((int64_t)(s->lba) << 11) + s->io_buffer_index; > > Maybe ((int64_t)s->lba << 11) ? No par

Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-04 Thread P J P
+-- On Mon, 4 Jan 2016, Mark Cave-Ayland wrote --+ | /* Calculate current offset */ | -offset = (int64_t)(s->lba << 11) + s->io_buffer_index; | +offset = ((int64_t)(s->lba) << 11) + s->io_buffer_index; Maybe ((int64_t)s->lba << 11) ? No parenthesis around s->lba. -- - P J P 47AF CE6

[Qemu-devel] [PATCH 5/6] nvdimm acpi: let qemu handle _DSM method

2016-01-04 Thread Xiao Guangrong
If dsm memory is successfully patched, we let qemu fully emulate the dsm method This patch saves _DSM input parameters into dsm memory, tell dsm memory address to QEMU, then fetch the result from the dsm memory Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 27 ++ hw/a

[Qemu-devel] [PATCH 4/6] acpi: allow using acpi named offset for OperationRegion

2016-01-04 Thread Xiao Guangrong
Extend aml_operation_region() to use named object Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 4 ++-- hw/i386/acpi-build.c| 7 --- include/hw/acpi/aml-build.h | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-

Re: [Qemu-devel] [PATCH COLO-Frame v13 17/39] COLO: Load VMState into qsb before restore it

2016-01-04 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > We should not destroy the state of SVM (Secondary VM) until we receive the > whole > state from the PVM (Primary VM), in case the primary fails in the middle of > sending > the state, so, here we cache the device state in Secondary before

[Qemu-devel] [PATCH 2/6] nvdimm acpi: initialize the resource used by NVDIMM ACPI

2016-01-04 Thread Xiao Guangrong
IO port 0x0a18 - 0x0a20 in guest is reserved for NVDIMM ACPI emulation, the table, NVDIMM_DSM_MEM_FILE, will be patched into NVDIMM ACPI binary code OSPM uses this port to tell QEMU the final address of the DSM memory and notify QEMU to emulate the DSM method Signed-off-by: Xiao Guangrong --- h

[Qemu-devel] [PATCH 3/6] nvdimm acpi: introduce patched dsm memory

2016-01-04 Thread Xiao Guangrong
The dsm memory is used to save the input parameters and store the dsm result which is filled by QEMU. The address of dsm memory is decided by bios and patched into int64 object returned by "MEMA" method Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 12 hw/acpi/nvd

[Qemu-devel] [PATCH 6/6] nvdimm acpi: emulate dsm method

2016-01-04 Thread Xiao Guangrong
Emulate dsm method after IO VM-exit Currently, we only introduce the framework and no function is actually supported Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 2 +- hw/acpi/nvdimm.c| 83 - include/hw/acpi/aml-build.h

[Qemu-devel] [PATCH 1/6] pc: acpi: bump DSDT/SSDT compliance revision to v2

2016-01-04 Thread Xiao Guangrong
From: Igor Mammedov It turns on 64-bit integer handling in OSPM, which will be used for writing simpler/smaller AML code in following patch. Tested with Windows XP and Windows Server 2008, Linux: * XP doesn't care about revision and continues to use 32 integers and boots just fine with

[Qemu-devel] [PATCH 0/6] NVDIMM ACPI: introduce the framework of QEMU emulated DSM

2016-01-04 Thread Xiao Guangrong
This patchset is against commit 5530427f0ca (acpi: extend aml_and() to accept target argument) on pci branch of Michael's git tree and can be found at: https://github.com/xiaogr/qemu.git nvdimm-acpi-v1 This is the second part of vNVDIMM implementation which implements the BIOS patched dsm me

Re: [Qemu-devel] [PATCH v1] qemu-iotests: s390x: fix test 051

2016-01-04 Thread Max Reitz
On 04.01.2016 06:29, Bo Tu wrote: > From: Bo Tu > > Replace the remaining "-drive file..." > by "-drive file=...,if=none,id=$device_id", then x86 and s390x > can get the common output. > "if=ide, if=floppy, if=scsi" are not supported by s390x, > so these test cases are not executed for s390x pla

[Qemu-devel] [PATCH V6 7/8] introduce xlnx-dp

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This is the implementation of the DisplayPort. It has an aux-bus to access dpcd and edid. Graphic plane is connected to the channel 3. Video plane is connected to the channel 0. Audio stream are connected to the channels 4 and 5. Signed-off-by: KONRAD Frederic Tested-By:

[Qemu-devel] [PATCH V6 5/8] hw/i2c-ddc.c: Implement DDC I2C slave

2016-01-04 Thread fred . konrad
From: Peter Maydell Implement an I2C slave which implements DDC and returns the EDID data for an attached monitor. Signed-off-by: Peter Maydell - Rebased on the current master. - Modified for QOM. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Tested-By: Hyun Kwon --- de

[Qemu-devel] [PATCH V6 6/8] introduce xlnx-dpdma

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This is the implementation of the DPDMA. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Tested-By: Hyun Kwon --- hw/dma/Makefile.objs| 1 + hw/dma/xlnx_dpdma.c | 792 include/hw/dma/xlnx_dpdma.

[Qemu-devel] [PATCH V6 8/8] arm: xlnx-zynqmp: Add xlnx-dp and xlnx-dpdma

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This adds the DP and the DPDMA to the Zynq MP platform. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- hw/arm/xlnx-zynqmp.c | 30 ++ include/hw/arm/xlnx-zynqmp.h | 5 + 2 files changed, 35

[Qemu-devel] [PATCH V6 0/8] Xilinx DisplayPort.

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This is the 6th version of this patch-set of the implementation of the Xilinx DisplayPort and DPDMA. This 6th version fixes some minors issues. Second patch introduces an AUX bus needed by the DP to read the DPCD. It's also possible to connect an I2C device on it to to I2C

[Qemu-devel] [PATCH V6 2/8] introduce aux-bus

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This introduces a new bus: aux-bus. It contains an address space for aux slaves devices and a bridge to an I2C bus for I2C through AUX transactions. Signed-off-by: KONRAD Frederic Tested-By: Hyun Kwon --- default-configs/aarch64-softmmu.mak | 1 + hw/misc/Makefile.obj

[Qemu-devel] [PATCH V6 3/8] i2c: implement broadcast write

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This does a write to every slaves when the I2C bus get a write to address 0. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- hw/i2c/core.c | 129 ++-

[Qemu-devel] [PATCH V6 1/8] i2cbus: remove unused dev field

2016-01-04 Thread fred . konrad
From: KONRAD Frederic The dev field in i2cbus is not used. So just drop it. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- hw/i2c/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i2c/core.c b/hw/i2c/core.c ind

[Qemu-devel] [PATCH V6 4/8] introduce dpcd module

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This introduces dpcd module. It wires on a aux-bus and can be accessed by the driver to get lane-speed, etc. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- default-configs/aarch64-softmmu.mak | 1 +

Re: [Qemu-devel] [PATCH 2/2] qemu-nbd: Minor texi updates

2016-01-04 Thread Eric Blake
On 12/30/2015 12:57 PM, Sitsofe Wheeler wrote: > - Change some spacing. > - Remove duplicate entry for --format. > - Reword --discard documentation. > - Add --detect-zeroes documentation. > > Signed-off-by: Sitsofe Wheeler > --- > qemu-nbd.texi | 22 ++ > 1 file changed, 14 i

Re: [Qemu-devel] An RDMA race?

2016-01-04 Thread Dr. David Alan Gilbert
* Michael R. Hines (mhi...@digitalocean.com) wrote: > Adding such a control message would defeat the benefits of RDMA, as there > shouldn't be any signalling in the actual DMA path, or RDMA latency would > be too high. If you're sending control messages for individual writes, then > you need to cha

Re: [Qemu-devel] [PATCH 1/2] qemu-nbd: Fix unintended texi verbatim formatting

2016-01-04 Thread Eric Blake
On 12/30/2015 12:54 PM, Sitsofe Wheeler wrote: [meta-comment] When sending a patch series, it's best to also include a 0/2 cover letter that summarizes the series. Doable with 'git config format.coverLetter auto'. > Indented lines in the texi meant the perlpod produced interpreted the > paragrap

[Qemu-devel] [Bug 1399191] Re: Large VHDX image size

2016-01-04 Thread Max Reitz
Hi Jan, ls -l returns the length of the file; qemu-img info prints the size of the file (just like du does). Those are not necessarily the same, as you can see. On modern filesystems, files can have holes in them which do contribute to the file length, but which do not use any space on disk and th

Re: [Qemu-devel] [PATCH v2] target-mips: Fix ALIGN instruction when bp=0

2016-01-04 Thread P J P
Hello Miodrag, +-- On Mon, 4 Jan 2016, Miodrag Dinic wrote --+ | thanks for your comments and review. | Version 2 of the patch is in the attachment. -> http://qemu-project.org/Contribute/SubmitAPatch#Do_not_send_as_an_attachment Generally it is preferred to have patches inline, instead of att

Re: [Qemu-devel] could i using qemu-img covert && rebase -u to do qcow2 rollback?

2016-01-04 Thread Eric Blake
On 01/04/2016 10:45 AM, Max Reitz wrote: > On 30.12.2015 12:31, Huan Zhang wrote: >> Hi, >> We are finding a way to do rollback for qcow2 in production environment, >> But we can't ensure the below way will work well, and user data are safe. >> >> for example, >> snap0.qcow2 -> snap1.qcow2 ->snap2.

Re: [Qemu-devel] could i using qemu-img covert && rebase -u to do qcow2 rollback?

2016-01-04 Thread Max Reitz
On 30.12.2015 12:31, Huan Zhang wrote: > Hi, > We are finding a way to do rollback for qcow2 in production environment, > But we can't ensure the below way will work well, and user data are safe. > > for example, > snap0.qcow2 -> snap1.qcow2 ->snap2.qcow2 -> active.qcow2 > > rollback to snap1 usi

Re: [Qemu-devel] qcow2 snapshot + resize

2016-01-04 Thread Max Reitz
On 29.12.2015 10:38, lihuiba wrote: > Hi, > > In our production environment, we need to extend a qcow2 image with > snapshots in it. This feature, however, is not implemented yet. > > So I want to ask, if this feature is under active development? No, it is not. > How can I > help with this fea

Re: [Qemu-devel] [PATCH 2/6] device_tree: introduce load_device_tree_from_sysfs

2016-01-04 Thread Eric Auger
Hi Peter, On 12/18/2015 03:10 PM, Peter Maydell wrote: > On 17 December 2015 at 12:29, Eric Auger wrote: >> This function returns the host device tree blob from sysfs >> (/sys/firmware/devicetree/base). It uses a recursive function >> inspired from dtc read_fstree. >> >> Signed-off-by: Eric Auger

[Qemu-devel] [PATCH] i2c-tiny-usb: add new usb to i2c bridge

2016-01-04 Thread Tim Sander
Version 3 with improvements suggested by Gerd Hoffmann Signed-off-by: Tim Sander i2c-tiny-usb is a small usb to i2c bridge:

[Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-04 Thread Mark Cave-Ayland
As the IDEState lba field is an int32_t, make sure we cast to int64_t before shifting to calculate the offset. Otherwise we end up with an overflow when trying to access sectors beyond 2GB as can occur when using DVD images. Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c |2 +- 1 file ch

Re: [Qemu-devel] [PATCH] hw/i386: fill in the CENTURY field of the FADT (FACP) ACPI table

2016-01-04 Thread Laszlo Ersek
On 12/10/15 19:53, Igor Mammedov wrote: > On Thu, 10 Dec 2015 18:25:34 +0100 > Laszlo Ersek wrote: > >> The ACPI specification (minimally versions 1.0b through 6.0) define >> the FADT.CENTURY field as: >> >> The RTC CMOS RAM index to the century of data value (hundred and >> thousand year dec

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2016-01-04 Thread Max Reitz
On 24.12.2015 06:41, Denis V. Lunev wrote: > On 12/24/2015 02:19 AM, Max Reitz wrote: >> So the benefits of a qcow2 flag are only minor ones. However, I >> personally believe that automatic unlock on crash is a very minor >> benefit as well. That should never happen in practice anyway, and a >> cra

Re: [Qemu-devel] [Qemu-block] ping Re: [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-01-04 Thread Programmingkid
On Jan 4, 2016, at 11:35 AM, Max Reitz wrote: > On 29.12.2015 01:27, Programmingkid wrote: >> I do realize you are busy Kevin, but I would >> appreciate knowing my patch is in line >> for review. > > Primarily, he's been on holiday since before christmas until next week. > > (I'm telling you s

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-04 Thread Lars Kurth
On 04/01/2016 14:47, "Stefano Stabellini" wrote: >Unfortunately I don't have a setup to test this either. Maybe Lars can >find out who should be involved on the Intel side on this. I can certainly help to this and get back to you. What exactly are we asking Intel to do? It is not clear to me f

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-04 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > > On 01/04/2016 04:16 PM, Zhang Chen wrote: > > > > > > On 01/04/2016 01:37 PM, Jason Wang wrote: > >> > >> On 12/31/2015 04:40 PM, Zhang Chen wrote: > >>> > >>> On 12/31/2015 10:36 AM, Jason Wang wrote: > On 12/22/2015 06:42 PM, Zhang Chen wrote

Re: [Qemu-devel] [Qemu-block] ping Re: [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-01-04 Thread Max Reitz
On 29.12.2015 01:27, Programmingkid wrote: > I do realize you are busy Kevin, but I would > appreciate knowing my patch is in line > for review. Primarily, he's been on holiday since before christmas until next week. (I'm telling you so you don't wonder why nothing happens.) Max signature.as

[Qemu-devel] [PATCH v2 1/3] Enable PPC64 with TPM support

2016-01-04 Thread Stefan Berger
From: Stefan Berger Compile the TPM passthrough device emulation on ppc64. Signed-off-by: Stefan Berger CC: Alexander Graf CC: qemu-...@nongnu.org --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 83b40fc..82ca1b5 100755 --- a/conf

  1   2   >