Re: [Qemu-devel] [PATCH 3/4] usb-bot: hotplug support

2016-02-02 Thread Gerd Hoffmann
On Di, 2016-02-02 at 19:16 +0100, Andreas Färber wrote: > Am 02.02.2016 um 14:36 schrieb Markus Armbruster: > > Gerd Hoffmann writes: > > > >> This patch marks usb-bot as hot-pluggable device, makes attached > >> property settable and turns off auto-attach in case the device > >> was hotplugged.

Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix tracefs access checking

2016-02-02 Thread Paolo Bonzini
On 03/02/2016 08:41, Janosch Frank wrote: > The following patch fixes the access checking behavior changed in > 7aa4ee5. Kvm_stat will now fall back to debugfs statistics if the > tracefs ones were chosen but are not available. It will then print a > warning and wait five seconds until it continu

[Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix tracefs access checking

2016-02-02 Thread Janosch Frank
The following patch fixes the access checking behavior changed in 7aa4ee5. Kvm_stat will now fall back to debugfs statistics if the tracefs ones were chosen but are not available. It will then print a warning and wait five seconds until it continues. Five seconds are not long, but I do not want to

[Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix tracefs access checking

2016-02-02 Thread Janosch Frank
On kernels build without CONFIG_TRACING kvm_stat will bail out even when traces are not used. This is not very helpful, especially if the user can't install a new kernel. Instead, we should warn the user and fall back to debugfs statistics. These changes check if trace statistics were selected wit

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-02 Thread Markus Armbruster
Thomas Huth writes: > On 02.02.2016 19:53, Markus Armbruster wrote: >> Lluís Vilanova writes: > ... > >>> diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h >>> index 7ab2355..6c2f142 100644 >>> --- a/include/qemu/error-report.h >>> +++ b/include/qemu/error-report.h >>> @@ -4

Re: [Qemu-devel] iotest 013 failure under clang -fsanitize=undefined

2016-02-02 Thread Markus Armbruster
Paolo Bonzini writes: > On 02/02/2016 22:59, Eric Blake wrote: >> I'd be okay with this patch, if you want to make it a formal >> submission, and if no one else chimes in with any opinion other >> than disgust at clang's shenanigans. > > I'm not okay with the patch. What's wrong with > -fno-sani

Re: [Qemu-devel] iotest 013 failure under clang -fsanitize=undefined

2016-02-02 Thread Markus Armbruster
Laszlo Ersek writes: > On 02/02/16 21:03, John Snow wrote: >> Recently, qemu iotest 013 has started to fail for me: >> >> Fedora release 22 (Twenty Two) >> >> 3.5.0-9.fc22 >> clang version 3.5.0 (tags/RELEASE_350/final) >> Target: x86_64-redhat-linux-gnu >> Thread model: posix >> >> >> +4 KiB

Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse

2016-02-02 Thread Michael Tokarev
28.01.2016 21:22, Wei Huang wrote: > When QEMU is hook'ed up with libvirt/virsh, the first ACPI reboot > request will succeed; but the following shutdown/reboot requests > fail to trigger VMs to react. Notice that in mach-virt machine > model GPIO is defined as edge-triggered and active-high in ACP

Re: [Qemu-devel] [PATCH] Fix inconsistency between comment and variable name

2016-02-02 Thread Michael Tokarev
03.02.2016 06:19, Cao jin wrote: > Signed-off-by: Cao jin > --- > include/hw/qdev-core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index abcdee8..42fa5db 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev

Re: [Qemu-devel] [PATCH v2 0/2] CCID QOMify

2016-02-02 Thread Michael Tokarev
Applied both to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc

2016-02-02 Thread Markus Armbruster
Eric Blake writes: > On 02/02/2016 01:04 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Commit 86f4b687 broke compilation on sparc, which has a preprocessor >>> pollution of '#define sparc 1'. Treat it the same way as we do for >>> the pollution with 'unix', so that QMP remains back

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Tian, Kevin
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Tuesday, February 02, 2016 4:56 PM > > Hi, > > > > I'd have qemu copy the data on 0xfc write then, so things continue to > > > work without updating seabios. So, the firmware has to allocate space, > > > reserve it etc., and programming

Re: [Qemu-devel] CPU hotplug

2016-02-02 Thread David Gibson
On Wed, Feb 03, 2016 at 10:33:48AM +0530, Bharata B Rao wrote: > On Mon, Feb 01, 2016 at 04:35:17PM +1100, David Gibson wrote: > > Hi, > > > > It seems to me we're getting rather bogged down in how to proceed with > > an improved CPU hotplug (and hot unplug) interface, both generically > > and for

Re: [Qemu-devel] [PATCH v4 5/6] .travis.yml: reduce the test matrix a little

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:34:07PM +, Alex Bennée wrote: > As we are now running "make check" on more of the matrix it is worth > making more of an effort to reduce the overall load on Travis. I've done > a few things: > > - Combining a number of the targets > - Building one target for eac

Re: [Qemu-devel] [PATCH v4 3/6] .travis.yml: enable each of the co-routine backends

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:34:05PM +, Alex Bennée wrote: > We disable "make check" for the gthread backend as it is broken. > > Signed-off-by: Alex Bennée Reviewed-by: David Gibson Tested-by: David Gibson > --- > .travis.yml | 15 ++- > 1 file changed, 14 insertions(+), 1 del

Re: [Qemu-devel] [PATCH v4 2/6] .travis.yml: run make check for all matrix targets

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:34:04PM +, Alex Bennée wrote: > We only ran make check once before it used to be an unreliable target. > It was only a stop gap measure and we should be able to revert it now. > This also stops us needing a large all-MMU build. > > We disable "make check" for a coupl

Re: [Qemu-devel] [PATCH v4 6/6] MAINTAINERS: Add .travis.yml

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:34:08PM +, Alex Bennée wrote: > Signed-off-by: Alex Bennée Reviewed-by: David Gibson > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b6ed87a..426a735 100644 > --- a/MAINTAINERS > +++ b/MAINTAINE

Re: [Qemu-devel] [PATCH v4 4/6] .travis.yml: enable ccache for the builds

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:34:06PM +, Alex Bennée wrote: > Travis support ccache on a cache-per-branch basis. Given not much of the > build changes between pushes as well as the duplication in each build it > seems worthwhile enabling this. > > Signed-off-by: Alex Bennée Reviewed-by: David G

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Tian, Kevin
> From: Kirti Wankhede > Sent: Tuesday, February 02, 2016 5:25 PM > > On 2/2/2016 1:12 PM, Tian, Kevin wrote: > >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > >> Sent: Tuesday, February 02, 2016 9:48 AM > >> > >> Resending this mail again, somehow my previous mail didn't reached every > >

Re: [Qemu-devel] Migrating decrementer

2016-02-02 Thread Alexander Graf
> Am 03.02.2016 um 06:59 schrieb David Gibson : > >> On Tue, Feb 02, 2016 at 11:41:40PM +, Mark Cave-Ayland wrote: >> On 01/02/16 00:52, David Gibson wrote: >> Thanks for more pointers - I think I'm slowly getting there. My current thoughts are that the basic migration algorithm i

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Wednesday, February 03, 2016 1:11 AM > > On Tue, 2016-02-02 at 00:31 -0800, Neo Jia wrote: > > On Tue, Feb 02, 2016 at 08:18:44AM +, Tian, Kevin wrote: > > > > From: Neo Jia [mailto:c...@nvidia.com] > > > > Sent: Tuesday, Febr

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 10:47:35PM +0100, Thomas Huth wrote: > On 02.02.2016 19:53, Markus Armbruster wrote: > > Lluís Vilanova writes: > ... > > >> diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h > >> index 7ab2355..6c2f142 100644 > >> --- a/include/qemu/error-report.h > >

Re: [Qemu-devel] [PATCH v6 4/5] util: [ppc] Use new error_report_abort() instead of abort()

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:14:15PM +0100, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > target-ppc/kvm.c|4 ++-- > target-ppc/kvm_ppc.h| 15 +-- > target-ppc/mmu-hash32.c |5 +++-- > target-ppc/mmu_helper.c |3 +-- > 4 files changed, 15 insert

Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 03:37:12PM -0200, Eduardo Habkost wrote: > On Mon, Feb 01, 2016 at 01:33:09PM +1100, David Gibson wrote: > > On Fri, Jan 22, 2016 at 03:32:52PM +0100, Igor Mammedov wrote: > > > On Fri, 22 Jan 2016 15:21:05 +0100 > > > Paolo Bonzini wrote: > > > > > > > On 22/01/2016 11:02

Re: [Qemu-devel] CPU hotplug

2016-02-02 Thread Bharata B Rao
On Mon, Feb 01, 2016 at 04:35:17PM +1100, David Gibson wrote: > Hi, > > It seems to me we're getting rather bogged down in how to proceed with > an improved CPU hotplug (and hot unplug) interface, both generically > and for ppc in particular. > > So here's a somewhat more concrete suggestion of a

Re: [Qemu-devel] Migrating decrementer

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 11:41:40PM +, Mark Cave-Ayland wrote: > On 01/02/16 00:52, David Gibson wrote: > > >> Thanks for more pointers - I think I'm slowly getting there. My current > >> thoughts are that the basic migration algorithm is doing the right thing > >> in that it works out the numb

Re: [Qemu-devel] [PULL 00/17] Net patches

2016-02-02 Thread Jason Wang
On 02/02/2016 07:05 PM, Peter Maydell wrote: > On 2 February 2016 at 02:36, Jason Wang wrote: >> The following changes since commit 0430891ce162b986c6e02a7729a942ecd2a32ca4: >> >> hw: Clean up includes (2016-01-29 15:07:25 +) >> >> are available in the git repository at: >> >> https://gi

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Eric Blake
On 02/02/2016 09:21 PM, Programmingkid wrote: >>> #if defined(__APPLE__) && defined(__MACH__) >>>/* if a physical device experienced an error while being opened */ >>>if (strncmp((*bsd_path ? bsd_path : filename), "/dev/", 5) == 0) { >>>print_unmounting_directions(*bsd_

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
On Feb 2, 2016, at 9:30 PM, Eric Blake wrote: > On 02/02/2016 06:15 PM, Programmingkid wrote: > >>> No, keep filename as a const char * pointer. It's easy to avoid use of >>> uninitialized memory. Try this: >>> >>> const char *filename; >>> char bsd_path[MAXPATHLEN] = ""; >>> ... >>> if (strn

Re: [Qemu-devel] [PATCH v14 5/8] docs: block replication's description

2016-02-02 Thread Wen Congyang
On 02/03/2016 11:35 AM, Eric Blake wrote: > On 02/02/2016 08:18 PM, Changlong Xie wrote: >> On 02/02/2016 11:20 PM, Eric Blake wrote: >>> On 01/13/2016 02:18 AM, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-b

Re: [Qemu-devel] [PATCH v14 5/8] docs: block replication's description

2016-02-02 Thread Eric Blake
On 02/02/2016 08:18 PM, Changlong Xie wrote: > On 02/02/2016 11:20 PM, Eric Blake wrote: >> On 01/13/2016 02:18 AM, Changlong Xie wrote: >>> From: Wen Congyang >>> >>> Signed-off-by: Wen Congyang >>> Signed-off-by: zhanghailiang >>> Signed-off-by: Gonglei >>> Signed-off-by: Changlong Xie >>> -

Re: [Qemu-devel] [PATCH v2 00/14] QOM'ify hw/timer/*

2016-02-02 Thread
ping ... At 2016-01-27 10:54:34, "xiaoqiang zhao" wrote: >This patch series QOM'ify timer code under hw/timer directory. >Main idea is to split the initfn's work, some to TypeInfo.instance_init >and some is placed in DeviceClass::realize. >Drop the use of SysBusDeviceClass::init if possibl

Re: [Qemu-devel] CPU hotplug

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 04:33:27PM -0200, Eduardo Habkost wrote: > On Mon, Feb 01, 2016 at 04:35:17PM +1100, David Gibson wrote: > > Hi, > > > > It seems to me we're getting rather bogged down in how to proceed with > > an improved CPU hotplug (and hot unplug) interface, both generically > > and f

[Qemu-devel] [PATCH] Fix inconsistency between comment and variable name

2016-02-02 Thread Cao jin
Signed-off-by: Cao jin --- include/hw/qdev-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index abcdee8..42fa5db 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -221,7 +221,7 @@ typedef struct BusChild

Re: [Qemu-devel] [PATCH v14 5/8] docs: block replication's description

2016-02-02 Thread Changlong Xie
On 02/02/2016 11:20 PM, Eric Blake wrote: On 01/13/2016 02:18 AM, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- docs/block-replication.txt | 229

Re: [Qemu-devel] [PATCH v5 04/10] qemu-io: add support for --object command line arg

2016-02-02 Thread Eric Blake
On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: > Allow creation of user creatable object types with qemu-io > via a new --object command line arg. This will be used to supply > passwords and/or encryption keys to the various block driver > backends via the recently added 'secret' object type. >

[Qemu-devel] [PATCH v2 2/2] Passthru CCID card: QOMify

2016-02-02 Thread Cao jin
Signed-off-by: Cao jin --- hw/usb/ccid-card-passthru.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c index 9f49c05..858e78e 100644 --- a/hw/usb/ccid-card-passthru.c +++ b/hw/usb/ccid-card-passthru.c @@

[Qemu-devel] [PATCH v2 0/2] CCID QOMify

2016-02-02 Thread Cao jin
v2 changelog 1. move macro definition to its home .c file Cao jin (2): Emulated CCID card: QOMify Passthru CCID card: QOMify hw/usb/ccid-card-emulated.c | 23 +-- hw/usb/ccid-card-passthru.c | 14 -- 2 files changed, 21 insertions(+), 16 deletions(-) -- 2.1.

[Qemu-devel] [PATCH v2 1/2] Emulated CCID card: QOMify

2016-02-02 Thread Cao jin
Signed-off-by: Cao jin --- hw/usb/ccid-card-emulated.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c index 869a63c..fe9ec5c 100644 --- a/hw/usb/ccid-card-emulated.c +++ b/hw/usb/ccid-card-emu

Re: [Qemu-devel] [PATCH v5 03/10] qemu-nbd: add support for --object command line arg

2016-02-02 Thread Eric Blake
On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: > Allow creation of user creatable object types with qemu-nbd > via a new --object command line arg. This will be used to supply > passwords and/or encryption keys to the various block driver > backends via the recently added 'secret' object type. >

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Eric Blake
On 02/02/2016 06:15 PM, Programmingkid wrote: >> No, keep filename as a const char * pointer. It's easy to avoid use of >> uninitialized memory. Try this: >> >> const char *filename; >> char bsd_path[MAXPATHLEN] = ""; >> ... >> if (strncmp("/dev/cdrom"...) { >>bsd_path = ... >> } >> ... >> i

[Qemu-devel] [PATCH v11 1/2] mirror: Rewrite mirror_iteration

2016-02-02 Thread Fam Zheng
The "pnum < nb_sectors" condition in deciding whether to actually copy data is unnecessarily strict, and the qiov initialization is unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. Rewrite mirror_iteration to fix both flaws. The output of iotests 109 is updated because we now report

[Qemu-devel] [PATCH v11 2/2] mirror: Add mirror_wait_for_io

2016-02-02 Thread Fam Zheng
The three lines are duplicated a number of times now, refactor a function. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- block/mirror.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 8b06a31..219decd 100

[Qemu-devel] [PATCH v11 0/2] mirror: Improve zero write and discard

2016-02-02 Thread Fam Zheng
v11: Rebase. The only difference is the "file" parameter of bdrv_get_block_status_above. Patch 1 rewrites mirror_iteration. Patch 2 is a small DRY cleaning up. The main benefit is copying unallocated sectors (both zeroed and discarded) doesn't go through the iov setup loop, as they don't nee

Re: [Qemu-devel] [PATCH v10 1/2] mirror: Rewrite mirror_iteration

2016-02-02 Thread Fam Zheng
On Tue, 02/02 18:20, Max Reitz wrote: > On 13.01.2016 03:50, Fam Zheng wrote: > > The "pnum < nb_sectors" condition in deciding whether to actually copy > > data is unnecessarily strict, and the qiov initialization is > > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > > > Rewrit

Re: [Qemu-devel] [PATCH v14 7/8] Implement new driver for block replication

2016-02-02 Thread Wen Congyang
On 02/02/2016 10:34 PM, Stefan Hajnoczi wrote: > On Mon, Feb 01, 2016 at 09:13:36AM +0800, Wen Congyang wrote: >> On 01/29/2016 11:46 PM, Stefan Hajnoczi wrote: >>> On Fri, Jan 29, 2016 at 11:13:42AM +0800, Changlong Xie wrote: On 01/28/2016 11:15 PM, Stefan Hajnoczi wrote: > On Thu, Jan 2

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
On Feb 2, 2016, at 5:04 PM, Eric Blake wrote: > On 02/02/2016 02:23 PM, Programmingkid wrote: > >>> And why isn't bsd_path usable for that purpose? >> >> After trying it out, I found out why bsd_path isn't usable for that purpose. >> It is because the user might try to use a flash drive as the

Re: [Qemu-devel] [PATCH v5 02/10] qemu-img: add support for --object command line arg

2016-02-02 Thread Eric Blake
On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: > Allow creation of user creatable object types with qemu-img > via a new --object command line arg. This will be used to supply > passwords and/or encryption keys to the various block driver > backends via the recently added 'secret' object type. >

Re: [Qemu-devel] [PATCH v5 01/10] qom: add helpers for UserCreatable object types

2016-02-02 Thread Eric Blake
On 02/02/2016 04:41 PM, Andreas Färber wrote: > Am 03.02.2016 um 00:38 schrieb Eric Blake: >> On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: >>> The QMP monitor code has two helper methods object_add >>> and qmp_object_del that are called from several places >>> in the code (QMP, HMP and main em

Re: [Qemu-devel] Migrating decrementer

2016-02-02 Thread Mark Cave-Ayland
On 01/02/16 00:52, David Gibson wrote: >> Thanks for more pointers - I think I'm slowly getting there. My current >> thoughts are that the basic migration algorithm is doing the right thing >> in that it works out the number of host ticks different between source >> and destination. > > Sorry, I'

Re: [Qemu-devel] [PATCH v5 01/10] qom: add helpers for UserCreatable object types

2016-02-02 Thread Andreas Färber
Am 03.02.2016 um 00:38 schrieb Eric Blake: > On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: >> The QMP monitor code has two helper methods object_add >> and qmp_object_del that are called from several places >> in the code (QMP, HMP and main emulator startup). >> >> The HMP and main emulator sta

Re: [Qemu-devel] [PATCH v5 01/10] qom: add helpers for UserCreatable object types

2016-02-02 Thread Eric Blake
On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: > The QMP monitor code has two helper methods object_add > and qmp_object_del that are called from several places > in the code (QMP, HMP and main emulator startup). > > The HMP and main emulator startup code also share > further logic that extract

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Kay, Allen M
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, February 02, 2016 11:37 AM > To: Kay, Allen M; Tian, Kevin; Gerd Hoffmann; qemu-devel@nongnu.org > Cc: igv...@ml01.01.org; xen-de...@lists.xensource.com; Eduardo Habkost; > Stefano Stabellini

Re: [Qemu-devel] [PATCH] Added code for synchronzing the internal simulation clock with an external simulation clock

2016-02-02 Thread Eric Blake
On 02/02/2016 01:49 PM, James Nutaro wrote: It looks like you are a first-time contributor. First, welcome to the community. What I say below may sound like a lot, but it's meant to help you be more successful in your contribution, not to scare you off. Subject line is too long. I'd suggest so

Re: [Qemu-devel] [RFC 09/14] Implement remaining PMU functionality

2016-02-02 Thread Alistair Francis
On Tue, Feb 2, 2016 at 3:01 PM, Christopher Covington wrote: > Hi Alistair, > > On 02/02/2016 04:22 PM, Alistair Francis wrote: >> On Wed, Aug 5, 2015 at 9:51 AM, Christopher Covington >> wrote: >>> This adds logic to increment PMEVCNTR's based on different event inputs, >>> implements all remain

Re: [Qemu-devel] [RFC 09/14] Implement remaining PMU functionality

2016-02-02 Thread Christopher Covington
Hi Alistair, On 02/02/2016 04:22 PM, Alistair Francis wrote: > On Wed, Aug 5, 2015 at 9:51 AM, Christopher Covington > wrote: >> This adds logic to increment PMEVCNTR's based on different event inputs, >> implements all remaining CP registers, and triggers an interrupt on >> event overflow. > >

Re: [Qemu-devel] [PATCH 2/6] i.MX: simplify CCM to only handle clock required by timers.

2016-02-02 Thread Jean-Christophe DUBOIS
Le 02/02/2016 17:22, Peter Maydell a écrit : On 26 January 2016 at 21:44, Jean-Christophe Dubois wrote: Various i.MX timers (GPT, EPIT, PWM, ...) are only requesting 4 clocks from the system. * CLK_NONE, * CLK_IPG, * CLK_IPG_HIGH, * CLK_32k Other "clocks" are not required by the qemu framewor

Re: [Qemu-devel] iotest 013 failure under clang -fsanitize=undefined

2016-02-02 Thread Paolo Bonzini
On 02/02/2016 22:59, Eric Blake wrote: > I'd be okay with this patch, if you want to make it a formal > submission, and if no one else chimes in with any opinion other > than disgust at clang's shenanigans. I'm not okay with the patch. What's wrong with -fno-sanitize=float-divide-by-zero? GCC

[Qemu-devel] [PATCH] Added code for synchronzing the internal simulation clock with an external simulation clock

2016-02-02 Thread James Nutaro
This patch adds an interface via UNIX shared memory for pacing the execution of QEMU to match an external simulation clock. The aim is to allow QEMU to be used as a module inside of a larger simulation system. The body of the patch is below. Signed-off-by: Jim Nutaro (nut...@gmail.com) >From 0e0

Re: [Qemu-devel] [PATCH 3/3] balloon: don't use NVDIMM for ballooning

2016-02-02 Thread Eric Blake
On 01/27/2016 11:51 PM, Vladimir Sementsov-Ogievskiy wrote: > NVDIMM for now is planned to use as a backing store for DAX filesystem > in the guest and thus this memory is excluded from guest memory > management and LRUs. > > In this case libvirt running QEMU along with configured balloon almost >

Re: [Qemu-devel] iotest 013 failure under clang -fsanitize=undefined

2016-02-02 Thread Laszlo Ersek
On 02/02/16 23:00, John Snow wrote: > > > On 02/02/2016 04:47 PM, Laszlo Ersek wrote: >> On 02/02/16 21:03, John Snow wrote: >>> Recently, qemu iotest 013 has started to fail for me: >>> >>> Fedora release 22 (Twenty Two) >>> >>> 3.5.0-9.fc22 >>> clang version 3.5.0 (tags/RELEASE_350/final) >>> T

Re: [Qemu-devel] [PATCH 2/3] pcdimm: add 'type' field to PCDIMMDeviceInfo

2016-02-02 Thread Eric Blake
On 01/27/2016 11:51 PM, Vladimir Sementsov-Ogievskiy wrote: > The field is needed to distinguish pc-dimm and nvdimm. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Xiao Guangrong > CC: "Michael S. Tsirkin" > CC: Igor Mammedov > CC:

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Eric Blake
On 02/02/2016 02:23 PM, Programmingkid wrote: >> And why isn't bsd_path usable for that purpose? > > After trying it out, I found out why bsd_path isn't usable for that purpose. > It is because the user might try to use a flash drive as the the cdrom. Say a > flash drive is set to /dev/disk2s9.

Re: [Qemu-devel] iotest 013 failure under clang -fsanitize=undefined

2016-02-02 Thread John Snow
On 02/02/2016 04:47 PM, Laszlo Ersek wrote: > On 02/02/16 21:03, John Snow wrote: >> Recently, qemu iotest 013 has started to fail for me: >> >> Fedora release 22 (Twenty Two) >> >> 3.5.0-9.fc22 >> clang version 3.5.0 (tags/RELEASE_350/final) >> Target: x86_64-redhat-linux-gnu >> Thread model: po

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc

2016-02-02 Thread Eric Blake
On 02/02/2016 01:04 PM, Markus Armbruster wrote: > Eric Blake writes: > >> Commit 86f4b687 broke compilation on sparc, which has a preprocessor >> pollution of '#define sparc 1'. Treat it the same way as we do for >> the pollution with 'unix', so that QMP remains backwards compatible >> and only

Re: [Qemu-devel] iotest 013 failure under clang -fsanitize=undefined

2016-02-02 Thread Eric Blake
On 02/02/2016 01:03 PM, John Snow wrote: > The problem is that in the print report for read_f, t2 and t1 can > actually be the same exact timestamp, and tdiv will try to divide by 0.0. > > Normally this is not a problem as this is defined to be INFINITY in C99 > Annex F. > > Clang, however, has

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-02 Thread Thomas Huth
On 02.02.2016 19:53, Markus Armbruster wrote: > Lluís Vilanova writes: ... >> diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h >> index 7ab2355..6c2f142 100644 >> --- a/include/qemu/error-report.h >> +++ b/include/qemu/error-report.h >> @@ -43,4 +43,23 @@ void error_report(c

Re: [Qemu-devel] iotest 013 failure under clang -fsanitize=undefined

2016-02-02 Thread Laszlo Ersek
On 02/02/16 21:03, John Snow wrote: > Recently, qemu iotest 013 has started to fail for me: > > Fedora release 22 (Twenty Two) > > 3.5.0-9.fc22 > clang version 3.5.0 (tags/RELEASE_350/final) > Target: x86_64-redhat-linux-gnu > Thread model: posix > > > +4 KiB/home/jsnow/src/qemu/qemu-io-cmds.c:

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
On Feb 2, 2016, at 2:24 PM, Eric Blake wrote: > On 02/02/2016 12:10 PM, Programmingkid wrote: > >>> There was/is no leak because it qdict_get_str() returns 'const char *' and >>> so nothing needs freeing. So your change is still a backwards steps IMHO. >> >> char filename[MAXPATHLEN]; >> snprin

Re: [Qemu-devel] [RFC 09/14] Implement remaining PMU functionality

2016-02-02 Thread Alistair Francis
On Wed, Aug 5, 2015 at 9:51 AM, Christopher Covington wrote: > This adds logic to increment PMEVCNTR's based on different event inputs, > implements all remaining CP registers, and triggers an interrupt on > event overflow. We (Xilinx) need parts of this patch to avoid kernel panics when booting

Re: [Qemu-devel] [PATCH v3] vfio/common: Check iova with limit not with size

2016-02-02 Thread Bandan Das
Pierre Morel writes: > In vfio_listener_region_add(), we try to validate that the region is not > zero sized and hasn't overflowed the addresses space. > > But the calculation uses the size of the region instead of > using the region's limit (size - 1). > > This leads to Int128 overflow when the

Re: [Qemu-devel] [PULL v2 00/50] Block patches

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 17:34, Max Reitz wrote: > This pull request supersedes Kevin's pull request from Friday > (http://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg06026.html). > > > The following changes since commit d2ea854c382d4d080de1f149167e60290108f79b: > > Merge remote-tracking br

Re: [Qemu-devel] [PATCH v2 0/5] block: reduce reliance on bs->job pointer

2016-02-02 Thread John Snow
ping, I think this one is up to you, jtc? On 01/26/2016 06:54 PM, John Snow wrote: > This is a small collection of patches to reduce our use of the bs->job > pointer where possible. There are still more usages in the code, but > this cuts down on a few. > > The goal is to eventually eliminate all

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Alex Williamson
On Tue, 2016-02-02 at 11:31 -0500, Kevin O'Connor wrote: > On Tue, Feb 02, 2016 at 09:56:20AM +0100, Gerd Hoffmann wrote: > >   Hi, > >  > > > > I'd have qemu copy the data on 0xfc write then, so things continue to > > > > work without updating seabios.  So, the firmware has to allocate space, > >

qemu-devel@nongnu.org

2016-02-02 Thread John Snow
On 02/02/2016 11:14 AM, Lluís Vilanova wrote: > Replaces all direct uses of 'error_setg(&error_fatal/abort)' with > 'error_report_fatal/abort'. Also reimplements the former on top of the > latter. > > Signed-off-by: Lluís Vilanova > --- > hw/block/fdc.c |6 +++--- > hw/ppc/spapr.c

[Qemu-devel] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU

2016-02-02 Thread Alex Williamson
When assigning Intel IGD graphics via QEMU/vfio, the OpRegion for the device may be exposed as a fw_cfg file. Allocate space for this, copy the contents and write the ASL Storage register (0xFC) to point to this buffer. NB, it's possible for QEMU to use the write to the ASL Storage register to ma

[Qemu-devel] [RFC PATCH v2 7/7] vfio/pci: Find and expose Intel IGD OpRegion

2016-02-02 Thread Alex Williamson
This is provided via a device specific region, look for it on Intel VGA class devices. Our default mechanism to expose this to the BIOS is via fw_cfg where it's expected that the BIOS will copy the data into a reserved RAM area and update the ASL Storage register to reference the GPA of that buffe

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc

2016-02-02 Thread Markus Armbruster
Eric Blake writes: > Commit 86f4b687 broke compilation on sparc, which has a preprocessor > pollution of '#define sparc 1'. Treat it the same way as we do for > the pollution with 'unix', so that QMP remains backwards compatible > and only the C code needs to use the alternative 'q_sparc' spelli

[Qemu-devel] iotest 013 failure under clang -fsanitize=undefined

2016-02-02 Thread John Snow
Recently, qemu iotest 013 has started to fail for me: Fedora release 22 (Twenty Two) 3.5.0-9.fc22 clang version 3.5.0 (tags/RELEASE_350/final) Target: x86_64-redhat-linux-gnu Thread model: posix +4 KiB/home/jsnow/src/qemu/qemu-io-cmds.c:230:18: runtime error: division by zero The problem is t

Re: [Qemu-devel] [PATCH v1 13/22] migration: convert RDMA to use QIOChannel interface

2016-02-02 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > This converts the RDMA code to provide a subclass of > QIOChannel that uses RDMA for the data transport. > > The RDMA code would be much better off it it could > be split up in a generic RDMA layer, a QIOChannel > impl based on RMDA, and then the

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
On Feb 2, 2016, at 2:24 PM, Eric Blake wrote: > On 02/02/2016 12:10 PM, Programmingkid wrote: > >>> There was/is no leak because it qdict_get_str() returns 'const char *' and >>> so nothing needs freeing. So your change is still a backwards steps IMHO. >> >> char filename[MAXPATHLEN]; >> snprin

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Alex Williamson
On Tue, 2016-02-02 at 19:10 +, Kay, Allen M wrote: >  > > -Original Message- > > From: Tian, Kevin > > Sent: Monday, February 01, 2016 11:08 PM > > To: Kay, Allen M; Alex Williamson; Gerd Hoffmann; qemu-devel@nongnu.org > > Cc: igv...@ml01.01.org; xen-de...@lists.xensource.com; Eduardo

Re: [Qemu-devel] [PATCH v6 4/5] util: [ppc] Use new error_report_abort() instead of abort()

2016-02-02 Thread Eric Blake
On 02/02/2016 09:14 AM, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > target-ppc/kvm.c|4 ++-- > target-ppc/kvm_ppc.h| 15 +-- > target-ppc/mmu-hash32.c |5 +++-- > target-ppc/mmu_helper.c |3 +-- > 4 files changed, 15 insertions(+), 12 deleti

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Eric Blake
On 02/02/2016 10:28 AM, Programmingkid wrote: >> Whats the rationale here ? Using pre-allocated fixed >> length arrays is pretty bad practice in general, but >> especially so for filenames > > With an automatic variable there is no worry about when to release it. Yeah, but it comes with the dow

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Eric Blake
On 02/02/2016 12:10 PM, Programmingkid wrote: >> There was/is no leak because it qdict_get_str() returns 'const char *' and >> so nothing needs freeing. So your change is still a backwards steps IMHO. > > char filename[MAXPATHLEN]; > snprintf(filename, MAXPATHLEN, "%s", qdict_get_str(options, "fi

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Kay, Allen M
> -Original Message- > From: Tian, Kevin > Sent: Monday, February 01, 2016 11:08 PM > To: Kay, Allen M; Alex Williamson; Gerd Hoffmann; qemu-devel@nongnu.org > Cc: igv...@ml01.01.org; xen-de...@lists.xensource.com; Eduardo Habkost; > Stefano Stabellini; Cao jin; vfio-us...@redhat.com > Su

Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-02 Thread Markus Armbruster
Lluís Vilanova writes: > Gives some general guidelines for reporting errors in QEMU. > > Signed-off-by: Lluís Vilanova > --- > HACKING | 37 + > 1 file changed, 37 insertions(+) > > diff --git a/HACKING b/HACKING > index 12fbc8a..b738bce 100644 > --- a/HACK

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
On Feb 2, 2016, at 12:31 PM, Daniel P. Berrange wrote: > On Tue, Feb 02, 2016 at 12:28:24PM -0500, Programmingkid wrote: >> >> On Feb 2, 2016, at 12:16 PM, Daniel P. Berrange wrote: >> >>> On Tue, Feb 02, 2016 at 12:08:31PM -0500, Programmingkid wrote: https://patchwork.ozlabs.org/patch/57

[Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc

2016-02-02 Thread Eric Blake
Commit 86f4b687 broke compilation on sparc, which has a preprocessor pollution of '#define sparc 1'. Treat it the same way as we do for the pollution with 'unix', so that QMP remains backwards compatible and only the C code needs to use the alternative 'q_sparc' spelling. CC: Peter Maydell Signe

Re: [Qemu-devel] [PATCH v1 12/22] migration: convert exec socket protocol to use QIOChannel

2016-02-02 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Convert the exec socket migration protocol driver to use > QIOChannel and QEMUFileChannel, instead of the stdio > popen APIs. It can be unconditionally built because the > QIOChannelCommand class can report suitable error messages > on platforms w

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-02 Thread Markus Armbruster
I'm struggling with my review queue, and have had to resort to subsystem batching to increase throughput. Because of that, v3-v5 have flown by without a peep from me. My sincere apologies. Lluís Vilanova writes: > Provide two lean functions to report error messages that fatal/abort > QEMU. > >

Re: [Qemu-devel] [PATCH v1 11/22] migration: convert fd socket protocol to use QIOChannel

2016-02-02 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Convert the fd socket migration protocol driver to use > QIOChannel and QEMUFileChannel, instead of plain sockets > APIs. It can be unconditionally built because the > QIOChannel APIs it uses will take care to report suitable > error messages if n

Re: [Qemu-devel] CPU hotplug

2016-02-02 Thread Eduardo Habkost
On Mon, Feb 01, 2016 at 04:35:17PM +1100, David Gibson wrote: > Hi, > > It seems to me we're getting rather bogged down in how to proceed with > an improved CPU hotplug (and hot unplug) interface, both generically > and for ppc in particular. > > So here's a somewhat more concrete suggestion of a

[Qemu-devel] [PATCH] target-arm: Don't report presence of EL2 if it doesn't exist

2016-02-02 Thread Peter Maydell
We already modify the processor feature bits to not report EL3 support to the guest if EL3 isn't enabled for the CPU we're emulating. Add similar support for not reporting EL2 unless it is enabled. This is necessary because real world guest code running at EL3 (trusted firmware or bootloaders) will

Re: [Qemu-devel] [PATCH v1 10/22] migration: convert tcp socket protocol to use QIOChannel

2016-02-02 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Convert the tcp socket migration protocol driver to use > QIOChannel and QEMUFileChannel, instead of plain sockets > APIs. > > While this now looks pretty similar to the migration/unix.c > file from the previous patch, it was decided not to merge

Re: [Qemu-devel] [PATCH 3/4] usb-bot: hotplug support

2016-02-02 Thread Andreas Färber
Am 02.02.2016 um 14:36 schrieb Markus Armbruster: > Gerd Hoffmann writes: > >> This patch marks usb-bot as hot-pluggable device, makes attached >> property settable and turns off auto-attach in case the device >> was hotplugged. >> >> Hot-plugging a usb-bot device with one or more scsi devices ca

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 17:45, Eric Blake wrote: > On 02/02/2016 10:26 AM, Peter Maydell wrote: >> On 2 February 2016 at 14:51, Eric Blake wrote: >>> Commit 86f4b687 broke compilation on MIPS, which has a preprocessor >>> pollution of '#define mips 1'. Treat it the same way as we do for >>> the po

[Qemu-devel] [PULL v2 41/50] vdi: Assign bs->file->bs to file in vdi_co_get_block_status

2016-02-02 Thread Max Reitz
From: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng Message-id: 1453780743-16806-10-git-send-email-f...@redhat.com Signed-off-by: Max Reitz --- block/vdi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/vdi.c b/block/vdi.c index 294c438..b403243 100644 --- a/block

[Qemu-devel] [PULL v2 48/50] iotests: Add "qemu-img map" test for VMDK extents

2016-02-02 Thread Max Reitz
From: Fam Zheng Signed-off-by: Fam Zheng Message-id: 1453780743-16806-17-git-send-email-f...@redhat.com Reviewed-by: Max Reitz Signed-off-by: Max Reitz --- tests/qemu-iotests/059 | 10 ++ tests/qemu-iotests/059.out | 25 + 2 files changed, 35 insertions(+)

[Qemu-devel] [PULL v2 40/50] sheepdog: Assign bs to file in sd_co_get_block_status

2016-02-02 Thread Max Reitz
From: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng Message-id: 1453780743-16806-9-git-send-email-f...@redhat.com Signed-off-by: Max Reitz --- block/sheepdog.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index 2ea05a6..a0098c1 1

  1   2   3   4   >