Re: [Qemu-devel] [PATCH] net.c: Moved large array in nc_sendv_compat from the stack to the heap

Nikos Filippakis writes: > Hello everyone! I am interested in getting to know the codebase a little > better > so that I can eventually apply for a GSOC position. > This is my first attempt at posting a patch to a mailing list, any feedback > is greatly appreciated. OK

Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup

> On Mar 1, 2016, at 3:01 PM, Paolo Bonzini wrote: > > This is done > because the worker threads only care about the queued request list, not > about active or completed requests. Do you think it would be useful to add an API for inserting one request back to the queued

Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup

> On Mar 1, 2016, at 3:34 PM, Stefan Hajnoczi wrote: > > Have you seen Linux Documentation/device-mapper/delay.txt? > > You could set up a loopback block device and put the device-mapper delay > target on top to simulate latency. I’m working on one idea to emulate the

[Qemu-devel] [PATCH] kvm/irqchip: use bitmap utility for gsi tracking

By using utilities in bitops and bitmap, this patch tries to make it more friendly to audience. No functional change. Signed-off-by: Wei Yang --- kvm-all.c | 34 ++ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 2/4] qapi-schema.json: Add power and keypad equal keys

On Mar 5, 2016, at 7:03 PM, Eric Blake wrote: > On 03/04/2016 10:17 PM, Programmingkid wrote: >> Add the power and keypad equal keys. These keys are found on a real Macintosh >> keyboard. >> >> Signed-off-by: John Arbuckle >> --- >> qapi-schema.json | 3 ++- >> 1 file

Re: [Qemu-devel] [PATCH v3 1/4] adb-keys.h: initial commit

On Mar 5, 2016, at 7:02 PM, Eric Blake wrote: > On 03/04/2016 10:15 PM, Programmingkid wrote: >> This commit implements the adb-keys.h file. It holds information on adb >> keycode >> values. >> >> Signed-off-by: John Arbuckle >> --- >> Changed name of file from

Re: [Qemu-devel] [PATCH v3 1/4] adb-keys.h: initial commit

On 03/04/2016 10:15 PM, Programmingkid wrote: > This commit implements the adb-keys.h file. It holds information on adb > keycode > values. > > Signed-off-by: John Arbuckle > --- > Changed name of file from MacKeys.h to adb-keys.h. > Changed name of constants from

Re: [Qemu-devel] [PATCH v3 2/4] qapi-schema.json: Add power and keypad equal keys

On 03/04/2016 10:17 PM, Programmingkid wrote: > Add the power and keypad equal keys. These keys are found on a real Macintosh > keyboard. > > Signed-off-by: John Arbuckle > --- > qapi-schema.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by:

[Qemu-devel] [PATCH v13 18/18] qapi: Change visit_type_FOO() to no longer return partial objects

Returning a partial object on error is an invitation for a careless caller to leak memory. As no one outside the testsuite was actually relying on these semantics, it is cleaner to just document and guarantee that ALL pointer-based visit_type_FOO() functions always leave a safe value in *obj

[Qemu-devel] [PATCH v13 07/18] qapi: Document visitor interfaces, add assertions

The visitor interface for mapping between QObject/QemuOpts/string and QAPI is scandalously under-documented, making changes to visitor core, individual visitors, and users of visitors difficult to coordinate. Among other questions: when is it safe to pass NULL, vs. when a string must be provided;

[Qemu-devel] [PATCH v13 13/18] qapi: Split visit_end_struct() into pieces

As mentioned in previous patches, we want to call visit_end_struct() functions unconditionally, so that visitors can release resources tied up since the matching visit_start_struct() without also having to worry about error priority if more than one error occurs. Even though error_propagate() can

[Qemu-devel] [PATCH v13 01/18] qapi-visit: Add visitor.type classification

We have three classes of QAPI visitors: input, output, and dealloc. Currently, all implementations of these visitors have one thing in common based on their visitor type: the implementation used for the visit_type_enum() callback. But since we plan to add more such common behavior, in relation to

[Qemu-devel] [PATCH v13 16/18] qmp-input: Require struct push to visit members of top dict

Don't embed the root of the visit into the stack of current containers being visited. That way, we no longer get confused on whether the first visit of a dictionary is to the dictionary itself or to one of the members of the dictionary, and we no longer have to require the root visit to pass

[Qemu-devel] [PATCH v13 06/18] qmp-input: Refactor when list is advanced

Refactor the code to advance the QListEntry pointer at the point where visit_type_FOO() is called, rather than visit_next_list(). This will allow a future patch to move the visit of the list head into visit_start_list(), and get rid of the 'first' flag. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v13 15/18] qom: Wrap prop visit in visit_start_struct

The qmp-input visitor was playing rather fast and loose: when visiting a QDict, you could grab members of the root dictionary without first pushing into the dict. But we are about to tighten the input visitor, at which point user_creatable_add_type() MUST follow the same paradigms as everyone

[Qemu-devel] [PATCH v13 14/18] qapi-commands: Wrap argument visit in visit_start_struct

The qmp-input visitor was playing rather fast and loose: when visiting a QDict, you could grab members of the root dictionary without first pushing into the dict. But we are about to tighten the input visitor, at which point the generated marshal code MUST follow the same paradigms as everyone

[Qemu-devel] [PATCH v13 17/18] qapi: Simplify semantics of visit_next_list()

We have two uses of list visits in the entire code base: one in spapr_drc (which completely avoids visit_next_list(), feeding in integers from a different source than uint8List), and one in qapi-visit.py (that is, all other list visitors are generated in qapi-visit.c, and share the same paradigm

[Qemu-devel] [PATCH v13 02/18] qapi: Guarantee NULL obj on input visitor callback error

Our existing input visitors were not very consistent on errors in a function taking 'TYPE **obj'. While all of them set '*obj' to allocated storage on success, it was not obvious whether '*obj' was guaranteed safe on failure, or whether it was left uninitialized. But a future patch wants to

[Qemu-devel] [PATCH v13 12/18] qmp: Tighten output visitor rules

Add a new qmp_output_visitor_reset(), which must be called before reusing an exising QmpOutputVisitor on a new root object. Tighten assertions to require that qmp_output_get_qobject() can only be called after pairing a visit_end_* for every visit_start_* (rather than allowing it to return a

[Qemu-devel] [PATCH v13 03/18] qmp: Drop dead command->type

Ever since QMP was first added back in commit 43c20a43, we have never had any QmpCommandType other than QCT_NORMAL. It's pointless to carry around the cruft. Signed-off-by: Eric Blake --- v13: no change v12: new patch --- include/qapi/qmp/dispatch.h | 6 --

[Qemu-devel] [PATCH v13 10/18] qmp: Support explicit null during visits

Implement the new type_null() callback for the qmp input and output visitors. While we don't yet have a use for this in QAPI input (the generator will need some tweaks first), one usage is already envisioned: when changing blockdev parameters, it would be nice to have a difference between leaving

[Qemu-devel] [PATCH v13 09/18] qapi: Add visit_type_null() visitor

Right now, qmp-output-visitor happens to produce a QNull result if nothing is actually visited between the creation of the visitor and the request for the resulting QObject. A stronger protocol would require that a QMP output visit MUST visit something. But to still be able to produce a JSON

[Qemu-devel] [PATCH v13 11/18] spapr_drc: Expose 'null' in qom-get when there is no fdt

Now that the QMP output visitor supports an explicit null output, we should utilize it to make it easier to diagnose the difference between a missing fdt ('null') vs. a present-but-empty one ('{}'). (Note that this reverts the behavior of commit ab8bf1d, taking us back to the behavior of commit

[Qemu-devel] [PATCH v13 04/18] qmp-input: Clean up stack handling

Management of the top of stack was a bit verbose; creating a temporary variable and adding some comments makes the existing code more legible before the next few patches improve things. No semantic changes other than asserting that we are always visiting a QObject, and not a NULL value.

[Qemu-devel] [PATCH v13 00/18] qapi visitor cleanups (post-introspection cleanups subset E)

Requires these patches first ("v4 implicit types"): https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg01205.html which in turn requires Markus' qapi-next branch: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg01182.html v13: Minor rebase improvements v12:

[Qemu-devel] [PATCH v13 08/18] tests: Add check-qnull

Add a new test, for checking reference counting of qnull(). As part of the new file, move a previous reference counting change added in commit a861564 into a more logical place. Signed-off-by: Eric Blake --- v13: no change v12: new patch --- tests/check-qnull.c |

[Qemu-devel] [PATCH v13 05/18] qmp-input: Don't consume input when checking has_member

Commit e8316d7 mistakenly passed consume=true when checking if an optional member was present, but the mistake was silently ignored since the code happily let us extract a member more than once. Tighten up the input visitor to ensure that a member is consumed exactly once. To keep the testsuite

[Qemu-devel] [PATCH] net.c: Moved large array in nc_sendv_compat from the stack to the heap

Hello everyone! I am interested in getting to know the codebase a little better so that I can eventually apply for a GSOC position. This is my first attempt at posting a patch to a mailing list, any feedback is greatly appreciated. Signed-off-by: Nikos Filippakis ---

[Qemu-devel] [PATCH] ui/console: add escape sequence \e[5,6n

This patch add support of escape sequence "\e[5,6n". This implementation similar to that of linux tty driver. Signed-off-by: Ren Kimura --- ui/console.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/ui/console.c

[Qemu-devel] [PATCH] ui/console: add escape sequence \e[5,6n

Signed-off-by: Ren Kimura --- ui/console.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c index ae61382..854ec98 100644 --- a/ui/console.c +++ b/ui/console.c @@ -757,6 +757,25 @@ static void

Re: [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization

On Fri, Mar 04, 2016 at 03:49:37PM +, Li, Liang Z wrote: > > > > > > > Only detect the unmapped/zero mapped pages is not enough. > > > > Consider > > > > > > the > > > > > > > situation like case 2, it can't achieve the same result. > > > > > > > > > > > > Your case 2 doesn't exist in the real

Re: [Qemu-devel] [PATCH v10 3/3] qmp: add monitor command to add/remove a child

On 16.02.2016 10:37, Changlong Xie wrote: > From: Wen Congyang > > The new QMP command name is x-blockdev-change. It's just for adding/removing > quorum's child now, and doesn't support all kinds of children, all kinds of > operations, nor all block drivers. So it is

Re: [Qemu-devel] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 16.02.2016 10:37, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie

[Qemu-devel] [PATCH v2] target-i386: Dump unknown opcodes with -d unimp

We discriminate here between opcodes that are illegal in the current cpu mode or with illegal arguments (such as modrm.mod == 3) and encodings that are unknown (such as an unimplemented isa extension). Signed-off-by: Richard Henderson --- PS: The upshot of this rule is that

Re: [Qemu-devel] [PATCH][Outreachy]

On 05/03/2016 07:45, Sarah Khan wrote: > util/envlist.c:This patch replaces malloc with g_malloc This should be placed in the subject. Please follow the instructions at http://wiki.qemu.org/Contribute/SubmitAPatch#Submitting_your_Patches to format the patch correctly. > - if ((envlist =

Re: [Qemu-devel] [PATCH v10 1/3] Add new block driver interface to add/delete a BDS's child

Sorry that I wasn't so pedantic last time; or maybe I should rather be sorry that I'm so pedantic this time. On 16.02.2016 10:37, Changlong Xie wrote: > From: Wen Congyang > > In some cases, we want to take a quorum child offline, and take > another child online. > >

[Qemu-devel] [PATCH v4 09/10] qapi: Use anonymous bases in QMP flat unions

Now that the generator supports it, we might as well use an anonymous base rather than breaking out a single-use Base structure, for all three of our current QMP flat unions. Oddly enough, this change does not affect the resulting introspection output (because we already inline the members of a

[Qemu-devel] [PATCH v4 04/10] qapi: Emit implicit structs in generated C

We already have several places that want to visit all the members of an implicit object within a larger context (simple union variant, event with anonymous data, command with anonymous arguments struct); and will be adding another one soon (the ability to declare an anonymous base for a flat

[Qemu-devel] [PATCH v4 10/10] qapi: Populate info['name'] for each entity

Every non-implicit entity is associated with an 'info' dictionary, but it is not easy to reverse-engineer the name of the top-most entity associated with that 'info'. Our use of 'case_whitelist' (added in commit 893e1f2) is thus currently tied to the owner of a member instead; but as the previous

[Qemu-devel] [PATCH v4 03/10] qapi: Make c_type() more OO-like

QAPISchemaType.c_type() was a bit awkward. Rather than having two optional orthogonal boolean flags that should never both be true, and where all callers should pass a compile-time constant (well, our use of is_unboxed wasn't constant, but a future patch is about to remove the special case for

[Qemu-devel] [PATCH v4 02/10] qapi: Fix command with named empty argument type

The generator special-cased { 'command':'foo', 'data': {} } to avoid emitting a visitor variable, but failed to see that { 'struct':'NamedEmptyType, 'data': {} } { 'command':'foo', 'data':'NamedEmptyType' } needs the same treatment. There, the generator happily generates a visitor to get

[Qemu-devel] [PATCH v4 05/10] qapi: Utilize implicit struct visits

Rather than generate inline per-member visits, take advantage of the 'visit_type_FOO_members()' function for both event and command marshalling. This is possible now that implicit structs can be visited like any other. Generated code shrinks accordingly; events initialize a struct based on

[Qemu-devel] [PATCH v4 00/10] easier unboxed visits/qapi implicit types

This is patches 10-19 of v2: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg06079.html Depends on Markus' qapi-next branch (which includes v3 of this series mapping to the first half of v2). Also available as a tag at this location: git fetch git://repo.or.cz/qemu/ericb.git

[Qemu-devel] [PATCH v4 08/10] qapi: Allow anonymous base for flat union

Rather than requiring all flat unions to explicitly create a separate base struct, we can allow the qapi schema to specify the common members via an inline dictionary. This is similar to how commands can specify an inline anonymous type for its 'data'. We already have several struct types that

[Qemu-devel] [PATCH v4 07/10] qapi: Don't special-case simple union wrappers

Simple unions were carrying a special case that hid their 'data' QMP member from the resulting C struct, via the hack method QAPISchemaObjectTypeVariant.simple_union_type(). But by using the work we started by unboxing flat union and alternate branches, coupled with the ability to visit the

[Qemu-devel] [PATCH v4 06/10] qapi-commands: Inline single-use helpers of gen_marshal()

Originally, gen_marshal_input_visit() (or gen_visitor_input_block() before commit f1538019) was factored out to make it easy to do two passes of a visit to each member of a (possibly-implicit) object, without duplicating lots of code. But after recent changes, those visits now occupy a single

[Qemu-devel] [PATCH v4 01/10] qapi: Assert in places where variants are not handled

We are getting closer to the point where we could use one union as the base or variant type within another union type (as long as there are no collisions between any possible combination of member names allowed across all discriminator choices). But until we get to that point, it is worth

Re: [Qemu-devel] [PATCH v1 01/10] qdict: implement a qdict_crumple method for un-flattening a dict

On 03.03.2016 12:01, Daniel P. Berrange wrote: > On Wed, Mar 02, 2016 at 05:13:59PM +0100, Max Reitz wrote: >> On 19.02.2016 17:47, Daniel P. Berrange wrote: >>> The qdict_flatten() method will take a dict whose elements are >>> further nested dicts/lists and flatten them by concatenating >>>

Re: [Qemu-devel] [PATCH v8 5/9] qemu-log: new option -dfilter to limit output

On 03/04/2016 03:18 AM, Alex Bennée wrote: +case '+': +{ +unsigned long len; +err |= qemu_strtoull(r2, NULL, 0, ); +if (len > 0) { +range.end = range.begin + (len - 1); +

[Qemu-devel] [PATCH] bitmap: refine and move BITMAP_{FIRST/LAST}_WORD_MASK

According to linux kernel commit <89c1e79eb30> ("linux/bitmap.h: improve BITMAP_{LAST,FIRST}_WORD_MASK"), these two macro could be improved. This patch takes this change and also move them all in header file. Signed-off-by: Wei Yang --- include/qemu/bitmap.h | 7

Re: [Qemu-devel] [PATCH v4 RFC 00/17] qcow2: persistent dirty bitmaps

On 04.03.2016 21:00, John Snow wrote: On 02/17/2016 10:28 AM, Vladimir Sementsov-Ogievskiy wrote: This series add persistent dirty bitmaps feature to qcow2. Specification is in docs/spec/qcow2.txt (not merged yet, see [PATCH v10] spec: add qcow2 bitmaps extension specification) This series

Re: [Qemu-devel] [PATCH v2 02/10] ipmi: replace IPMI_ADD_RSP_DATA() macro with inline helpers

On 03/02/2016 04:14 AM, Cédric Le Goater wrote: The IPMI command handlers in the BMC simulator use a macro IPMI_ADD_RSP_DATA() to push bytes in a response buffer. The macro hides the fact that it implicitly uses variables local to the handler, which is misleading. This patch introduces a simple

Re: [Qemu-devel] [PATCH v2 04/10] ipmi: add rsp_buffer_set_error() helper

On 03/02/2016 04:14 AM, Cédric Le Goater wrote: The third byte in the response buffer of an IPMI command holds the error code. In many IPMI command handlers, this byte is updated directly. This patch adds a helper routine to clarify why this byte is being used. Signed-off-by: Cédric Le Goater

Re: [Qemu-devel] [PATCH v2 01/10] ipmi: remove IPMI_CHECK_CMD_LEN() macro

On 03/02/2016 04:14 AM, Cédric Le Goater wrote: Most IPMI command handlers in the BMC simulator start with a call to the macro IPMI_CHECK_CMD_LEN() which verifies that a minimal number of arguments expected by the command are indeed available. To achieve this task, the macro implicitly uses

Re: [Qemu-devel] [PATCH v2][Outreachy Round 12]

Your commit message isn't quite right, yet. The first line is empty, which leads to Subject: [PATCH v2][Outreachy Round 12] in e-mail, which isn't really useful. It should be a line of the form subsystem: Headline describing the patch briefly In e-mail, this becomes something like

[Qemu-devel] Hi good afternoon, some small support

Hi, I am trying to execute an image created by ARM in QEMU using windows OS, could you give me guide to example the command line? The command line in Unix work well, but I don't understood all the options. This the reason that I looking for some help

[Qemu-devel] [PULL v2 06/12] qapi: Update docs to match recent generator changes

From: Eric Blake Several commits have been changing the generator, but not updating the docs to match: - The implicit tag member is named "type", not "kind". Screwed up in commit 39a1815. - Commit 9f08c8ec made list types lazy, and thereby dropped UserDefOneList if nothing

[Qemu-devel] [PULL v2 12/12] qapi: Drop useless 'data' member of unions

From: Eric Blake We started moving away from the use of the 'void *data' member in the C union corresponding to a QAPI union back in commit 544a373; recent commits have gotten rid of other uses. Now that it is completely unused, we can remove the member itself as well as the

[Qemu-devel] [PULL v2 09/12] ui: Shorten references into InputEvent

From: Eric Blake An upcoming patch will alter how simple unions, like InputEvent, are laid out, which will impact all lines of the form 'evt->u.XXX' (expanding it to the longer 'evt->u.XXX.data'). For better legibility in that patch, and less need for line wrapping, it's

[Qemu-devel] [PULL v2 01/12] qmp-shell: fix pretty printing of JSON responses

From: "Daniel P. Berrange" Pretty printing of JSON responses is important to be able to understand large responses from query commands in particular. Unfortunately this was broken during the addition of the verbose flag in commit 1ceca07e48ead0dd2e41576c81d40e6a91cafefd

[Qemu-devel] [PULL v2 11/12] chardev: Drop useless ChardevDummy type

From: Eric Blake Commit d0d7708b made ChardevDummy be an empty wrapper type around ChardevCommon. But there is no technical reason for this indirection, so simplify the code by directly using the base type. Also change the fallback assignment to assign u.null rather than

[Qemu-devel] [PULL v2 10/12] qapi: Avoid use of 'data' member of QAPI unions

From: Eric Blake QAPI code generators currently create a 'void *data' member as part of the anonymous union embedded in the C struct corresponding to a QAPI union. However, directly assigning to this member of the union feels a bit fishy, when we can assign to another member

[Qemu-devel] [PULL v2 05/12] qapi-visit: Expose visit_type_FOO_members()

From: Eric Blake Dan Berrange reported a case where he needs to work with a QCryptoBlockOptions union type using the OptsVisitor, but only visit one of the branches of that type (the discriminator is not visited directly, but learned externally). When things were boxed, it

[Qemu-devel] [PULL v2 04/12] qapi: Rename 'fields' to 'members' in generated C code

From: Eric Blake C types and JSON objects don't have fields, but members. We shouldn't gratuitously invent terminology. This patch is a strict renaming of static genarated functions, plus the naming of the dummy filler member for empty structs, before the next patch exposes

[Qemu-devel] [PULL v2 08/12] util: Shorten references into SocketAddress

From: Eric Blake An upcoming patch will alter how simple unions, like SocketAddress, are laid out, which will impact all lines of the form 'addr->u.XXX' (expanding it to the longer 'addr->u.XXX.data'). For better legibility in that patch, and less need for line wrapping, it's

[Qemu-devel] [PULL v2 03/12] qapi: Rename 'fields' to 'members' in generator

From: Eric Blake C types and JSON objects don't have fields, but members. We shouldn't gratuitously invent terminology. This patch is a strict renaming of generator code internals (including testsuite comments), before later patches rename C interfaces. No change to

[Qemu-devel] [PULL v2 02/12] qapi-dealloc: Reduce use outside of generated code

From: Eric Blake No need to roll our own use of the dealloc visitors when we can just directly use the qapi_free_FOO() functions that do what we want in one line. In net.c, inline net_visit() into its remaining lone caller. After this patch, test-visitor-serialization.c is

[Qemu-devel] [PULL v2 07/12] chardev: Shorten references into ChardevBackend

From: Eric Blake An upcoming patch will alter how simple unions, like ChardevBackend, are laid out, which will impact all lines of the form 'backend->u.XXX' (expanding it to the longer 'backend->u.XXX.data'). For better legibility in that patch, and less need for line

[Qemu-devel] [PULL v2 00/12] QAPI patches for 2016-03-04

v2: Missing S-o-b supplied The following changes since commit 3c0f12df65da872d5fbccae469f2cb21ed1c03b7: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160304' into staging (2016-03-04 11:46:32 +) are available in the git repository at: