Re: [Qemu-devel] [PATCHv2 2/3] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT

2016-03-23 Thread David Gibson
On Tue, Mar 22, 2016 at 05:33:45PM +0100, Laurent Vivier wrote: > Hi David, > > using kvm-unit-tests, I've found a side effect of your patches: the MSR > is cleared (and perhaps some others). > > I was trying to test my patch on top of QEMU master: > > "ppc64: set MSR_SF bit" >

Re: [Qemu-devel] [RFC] host and guest kernel trace merging

2016-03-23 Thread Peter Xu
Hi, Steven, On Fri, Mar 04, 2016 at 08:23:11AM -0500, Steven Rostedt wrote: > My idea for a trace-cmd server, is to have a --client operation, for > running on the guest. > > trace-cmd server --client > > The connection will be some socket, either network or something > directly attached to

[Qemu-devel] [PULL 14/16] hw/net/spapr_llan: Fix receive buffer handling for better performance

2016-03-23 Thread David Gibson
From: Thomas Huth tl;dr: This patch introduces an alternate way of handling the receive buffers of the spapr-vlan device, resulting in much better receive performance for the guest. Full story: One of our testers recently discovered that the performance of the spapr-vlan

[Qemu-devel] [PULL 16/16] ppc: move POWER8 Book4 regs in their own routine

2016-03-23 Thread David Gibson
From: Cédric Le Goater commit fce55481360d "ppc: A couple more dummy POWER8 Book4 regs" squashed in to rapidly a set of POWER8 Book4 regs in the wrong routine. This patch introduces the missing gen_spr_power8_book4() routine to fix their location. Signed-off-by: Cédric Le

[Qemu-devel] [PULL 09/16] ppc: Fix writing to AMR/UAMOR

2016-03-23 Thread David Gibson
From: Benjamin Herrenschmidt The masks weren't chosen nor applied properly. The architecture specifies that writes to AMR are masked by UAMOR for PR=1, otherwise AMOR for HV=0. The writes to UAMOR are masked by AMOR for HV=0 Signed-off-by: Benjamin Herrenschmidt

[Qemu-devel] [PULL 03/16] ppc: Update SPR definitions

2016-03-23 Thread David Gibson
From: Benjamin Herrenschmidt Add definitions for additional SPR numbers and SPR bit definitions that will be relevant for subsequent improvements to POWER8 emulation Also fix the definition of LPIDR which was incorrect (and is different for server and embedded).

[Qemu-devel] [PULL 10/16] ppc: Add POWER8 IAMR register

2016-03-23 Thread David Gibson
From: Benjamin Herrenschmidt With appropriate AMR-like masks. Not actually used by the translation logic at that point Signed-off-by: Benjamin Herrenschmidt [clg: changed spr_register_hv(SPR_IAMR) to spr_register_kvm_hv(SPR_IAMR)

[Qemu-devel] [PULL 13/16] hw/net/spapr_llan: Extract rx buffer code into separate functions

2016-03-23 Thread David Gibson
From: Thomas Huth Refactor the code a little bit by extracting the code that reads and writes the receive buffer list page into separate functions. There should be no functional change in this patch, this is just a preparation for the upcoming extensions that introduce receive

[Qemu-devel] [PULL 12/16] ppc: A couple more dummy POWER8 Book4 regs

2016-03-23 Thread David Gibson
From: Benjamin Herrenschmidt Signed-off-by: Benjamin Herrenschmidt [clg: squashed in patch 'ppc: Add dummy ACOP SPR' ] Signed-off-by: Cédric Le Goater Reviewed-by: Thomas Huth Reviewed-by: David Gibson

[Qemu-devel] [PULL 07/16] ppc: Add dummy SPR_IC for POWER8

2016-03-23 Thread David Gibson
From: Benjamin Herrenschmidt It's supposed to be an instruction counter. For now make us not crash when accessing it. Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Thomas Huth Reviewed-by: David Gibson

[Qemu-devel] [PULL 02/16] spapr/target-ppc/kvm: Only add hcall-instructions if KVM supports it

2016-03-23 Thread David Gibson
From: Alexey Kardashevskiy ePAPR defines "hcall-instructions" device-tree property which contains code to call hypercalls in ePAPR paravirtualized guests. In general pseries guests won't use this property, instead using the PAPR defined hypercall interface. However, this

[Qemu-devel] [PULL 08/16] ppc: Initialize AMOR in PAPR mode

2016-03-23 Thread David Gibson
From: Benjamin Herrenschmidt Make sure we give the guest full authorization Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Thomas Huth Reviewed-by: David Gibson Signed-off-by: David Gibson

[Qemu-devel] [PULL 11/16] ppc: Add dummy CIABR SPR

2016-03-23 Thread David Gibson
From: Benjamin Herrenschmidt We should implement HW breakpoint/watchpoint, qemu supports them... Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Thomas Huth Reviewed-by: David Gibson

[Qemu-devel] [PULL 06/16] ppc: Create cpu_ppc_set_papr() helper

2016-03-23 Thread David Gibson
From: Benjamin Herrenschmidt And move the code adjusting the MSR mask and calling kvmppc_set_papr() to it. This allows us to add a few more things such as disabling setting of MSR:HV and appropriate LPCR bits which will be used when fixing the exception model.

[Qemu-devel] [PULL 15/16] hw/net/spapr_llan: Enable the RX buffer pools by default for new machines

2016-03-23 Thread David Gibson
From: Thomas Huth RX buffer pools are now enabled by default for new machine types. For older machine types, they are still disabled to avoid breaking migration. Signed-off-by: Thomas Huth Reviewed-by: David Gibson Reviewed-by:

[Qemu-devel] [PULL 01/16] ppc64: set MSR_SF bit

2016-03-23 Thread David Gibson
From: Laurent Vivier When a qemu-system-ppc64 is started, the 64-bit mode bit is not set in MSR. Signed-off-by: Laurent Vivier Reviewed-by: Alexander Graf Signed-off-by: David Gibson ---

[Qemu-devel] [PULL 04/16] ppc: Add macros to register hypervisor mode SPRs

2016-03-23 Thread David Gibson
From: Benjamin Herrenschmidt The current set of spr_register_* macros only take the user and supervisor function pointers. To make the transition easy, we don't change that but we add "_hv" variants that can be used to register all 3 sets. To simplify the transition,

[Qemu-devel] [PULL 05/16] ppc: Add a bunch of hypervisor SPRs to Book3s

2016-03-23 Thread David Gibson
From: Benjamin Herrenschmidt We don't give them a KVM reg number to most of the registers yet as no current KVM version supports HV mode. For DAWR and DAWRX, the KVM reg number is needed since this register can be set by the guest via the H_SET_MODE hypercall.

[Qemu-devel] [PULL 00/16] ppc-for-2.6 queue 20160324

2016-03-23 Thread David Gibson
The following changes since commit 2538039f2c26d66053426fb547e4f25e669baf62: Merge remote-tracking branch 'remotes/armbru/tags/pull-ivshmem-2016-03-18' into staging (2016-03-23 12:57:44 +) are available in the git repository at: git://github.com/dgibson/qemu.git

Re: [Qemu-devel] [PATCH] quorum: Implement bdrv_get_specific_info

2016-03-23 Thread Fam Zheng
On Thu, 03/24 11:17, Wen Congyang wrote: > The monitor command 'query-block' or 'info block' will output the format > specific > information. So we can get each child's child-name after this patch. This > useful > for dynamic reconfiguration. > > Signed-off-by: Wen Congyang

[Qemu-devel] [PATCH] quorum: Implement bdrv_get_specific_info

2016-03-23 Thread Wen Congyang
The monitor command 'query-block' or 'info block' will output the format specific information. So we can get each child's child-name after this patch. This useful for dynamic reconfiguration. Signed-off-by: Wen Congyang --- block/quorum.c | 27

Re: [Qemu-devel] [PULL v3 02/13] crypto: add support for PBKDF2 algorithm

2016-03-23 Thread Wen Congyang
On 03/18/2016 12:53 AM, Daniel P. Berrange wrote: > The LUKS data format includes use of PBKDF2 (Password-Based > Key Derivation Function). The Nettle library can provide > an implementation of this, but we don't want code directly > depending on a specific crypto library backend. Introduce > a

[Qemu-devel] [PATCH v7 4/4] arm: implement query-gic-capabilities

2016-03-23 Thread Peter Xu
For emulated GIC capabilities, currently only gicv2 is supported. We need to add gicv3 in when emulated gicv3 ready. For KVM accelerated ARM VM, we detect the capability bits by creating a scratch VM. Signed-off-by: Peter Xu --- target-arm/monitor.c | 58

[Qemu-devel] [PATCH v7 3/4] kvm: add kvm_device_supported() helper function

2016-03-23 Thread Peter Xu
This can be used when probing whether KVM support specific device. Here, a raw vmfd is used. Signed-off-by: Peter Xu --- include/sysemu/kvm.h | 9 + kvm-all.c| 15 +++ 2 files changed, 24 insertions(+) diff --git a/include/sysemu/kvm.h

[Qemu-devel] [PATCH v7 2/4] arm: enhance kvm_arm_create_scratch_host_vcpu

2016-03-23 Thread Peter Xu
Some more lines to make sure we allow NULL for 1st/3rd parameter. Signed-off-by: Peter Xu --- target-arm/kvm.c | 14 +- target-arm/kvm_arm.h | 6 -- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/target-arm/kvm.c b/target-arm/kvm.c index

[Qemu-devel] [PATCH v7 1/4] arm: qmp: add query-gic-capabilities interface

2016-03-23 Thread Peter Xu
This patch add "query-gic-capabilities" but does not implemnet it. The command is ARM-only. The command will return a list of GICCapability struct that describes all GIC versions that current QEMU and system support. Libvirt is possibly the first consumer of this new command. Before this patch,

[Qemu-devel] [PATCH v7 0/4] ARM: add query-gic-capabilities QMP command

2016-03-23 Thread Peter Xu
v7 changes: - patch 1 - add more to commit log, about how to use the results [Markus] - change interface from dict back to array [Markus, Eric] - patch 2 - kvm_arm_create_scratch_host_vcpu should raise error when init non-zero, but failed to find a good CPU model [Sergey] - patch 3 -

Re: [Qemu-devel] [PATCH qemu v14 18/18] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2016-03-23 Thread Alexey Kardashevskiy
On 03/23/2016 05:11 PM, David Gibson wrote: On Wed, Mar 23, 2016 at 02:28:01PM +1100, Alexey Kardashevskiy wrote: On 03/23/2016 01:13 PM, David Gibson wrote: On Mon, Mar 21, 2016 at 06:47:06PM +1100, Alexey Kardashevskiy wrote: This adds support for Dynamic DMA Windows (DDW) option defined by

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 04:17:25PM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, Mar 23, 2016 at 01:21:52PM +0100, Markus Armbruster wrote: > >> Can you tell me what a management application is supposed to do with the > >> information returned by

Re: [Qemu-devel] [Qemu-arm] [PATCH v6 4/4] arm: implement query-gic-capabilities

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 03:33:25PM +0300, Sergey Fedorov wrote: > On 23/03/16 08:32, Peter Xu wrote: > > diff --git a/target-arm/monitor.c b/target-arm/monitor.c > > index 254a9c9..4a2db59 100644 > > --- a/target-arm/monitor.c > > +++ b/target-arm/monitor.c > > @@ -21,8 +21,66 @@ > (snip) > >

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Wei Yang
On Thu, Mar 24, 2016 at 01:32:25AM +, Li, Liang Z wrote: >> >> >> > >> >> >> >6. Handling page cache in the guest The memory used for page >> >> >> >cache in the guest will change depends on the workload, if guest >> >> >> >run some block IO intensive work load, there will >> >> >> >> >> >>

Re: [Qemu-devel] [PATCH v6 3/4] kvm: add kvm_support_device() helper function

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 06:03:32PM +0300, Sergey Fedorov wrote: > Yes, but kvm_create_device() returns a file descriptor whereas this > function is predicative. Personally, I like the convention described in > chapter 16 of Linux kernel coding style [1]: > > If the name of a function is an

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Li, Liang Z
> >> >> > > >> >> >6. Handling page cache in the guest The memory used for page > >> >> >cache in the guest will change depends on the workload, if guest > >> >> >run some block IO intensive work load, there will > >> >> > >> >> Would this improvement benefit a lot when guest only has little free

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Wei Yang
On Wed, Mar 23, 2016 at 06:48:22AM +, Li, Liang Z wrote: [...] >> > 8. Pseudo code >> > Dirty page logging should be enabled before getting the free page >> > information from guest, this is important because during the process >> > of getting free pages, some free pages may be used and

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Li, Liang Z
> >>> >From guest's point of view, there are some pages currently not used > >>> >by > >> > >> I see in your original RFC patch and your RFC doc, this line starts > >> with a character '>'. Not sure this one has a special purpose? > >> > > > > No special purpose. Maybe it's caused by the email

[Qemu-devel] [PATCH 4/4] adb.c: add power key support

2016-03-23 Thread Programmingkid
Add support for the power key. It has to be handled differently from the other keys because it is the only 16-bit value key. Signed-off-by: John Arbuckle --- hw/input/adb.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Li, Liang Z
> > > > 2. Why not use virtio-balloon > > > > Actually, the virtio-balloon can do the similar thing by inflating > > > > the balloon before live migration, but its performance is no good, > > > > for an 8GB idle guest just boots, it takes about 5.7 Sec to > > > > inflate the balloon to 7GB, but it

[Qemu-devel] [PATCH 3/4] adb.c: NO_KEY

2016-03-23 Thread Programmingkid
Sets keys that are not supported by ADB to an unusable value of 0xff. Signed-off-by: John Arbuckle --- hw/input/adb.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/hw/input/adb.c b/hw/input/adb.c index

[Qemu-devel] [PATCH 2/4] adb-keys.h - initial commit

2016-03-23 Thread Programmingkid
Add the adb-keys.h file. It maps ADB transition key codes with values. Signed-off-by: John Arbuckle --- include/hw/input/adb-keys.h | 147 1 file changed, 147 insertions(+) create mode 100644 include/hw/input/adb-keys.h

[Qemu-devel] [PATCH 1/4] adb.c: add support for QKeyCode

2016-03-23 Thread Programmingkid
The old pc scancode translation is replaced with QEMU's QKeyCode. Signed-off-by: John Arbuckle --- hw/input/adb.c | 222 + 1 file changed, 176 insertions(+), 46 deletions(-) diff --git a/hw/input/adb.c

[Qemu-devel] [PATCH 0/4] ADB improvements

2016-03-23 Thread Programmingkid
From 949a986e68aa575146039d4d4493dca240a84266 Mon Sep 17 00:00:00 2001 From: John Arbuckle Date: Wed, 23 Mar 2016 20:55:14 -0400 Subject: [PATCH 0/4] ADB improvements This patch series makes several improvements to the ADB code. To test this code, please implement the

[Qemu-devel] [PATCH v3 1/1] Introduce "xen-load-devices-state"

2016-03-23 Thread Changlong Xie
From: Wen Congyang Introduce a "xen-load-devices-state" QAPI command that can be used to load the state of all devices, but not the RAM or the block devices of the VM. We only have hmp commands savevm/loadvm, and qmp commands xen-save-devices-state. We use this new

[Qemu-devel] [PATCH v3 0/1] Introduce "xen-load-devices-state"

2016-03-23 Thread Changlong Xie
Changelog v3: 1. Addressed on David's commets, fix a bug v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1): Introduce "xen-load-devices-state" migration/savevm.c | 36 qapi-schema.json | 14

Re: [Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt power button

2016-03-23 Thread Shannon Zhao
On 2016/3/24 1:14, Wei Huang wrote: > > On 03/23/2016 11:12 AM, Peter Maydell wrote: >> > On 17 March 2016 at 13:25, Shannon Zhao wrote: >>> >> From: Shannon Zhao >>> >> >>> >> There is a problem for power button that it will not work if an

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Wei Yang
On Wed, Mar 23, 2016 at 02:35:42PM +, Li, Liang Z wrote: >> >No special purpose. Maybe it's caused by the email client. I didn't >> >find the character in the original doc. >> > >> >> https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg00715.html >> >> You could take a look at this

Re: [Qemu-devel] [PATCH v2 5/5] .travis.yml: reduce target list on core configure tweaks

2016-03-23 Thread David Gibson
On Wed, Mar 23, 2016 at 05:20:57PM +, Alex Bennée wrote: > A number of configure options only really affect the core code and any > arch specific stuff should be flushed out by other builds: > > - trace-backends, log build is all targets, others can be less > - --disable-build, ensuring

Re: [Qemu-devel] [PATCH v3 2/2] hw/pci-bridge: Convert pxb initialization functions to Error

2016-03-23 Thread Wei, Jiangang
On Wed, 2016-03-23 at 13:05 +0100, Markus Armbruster wrote: > Wei Jiangang writes: > > > Firstly, convert pxb_dev_init_common() to Error and rename > > it to pxb_dev_realize_common(). > > Actually, pxb_register_bus() is converted as well. > > > > And then, > > convert

[Qemu-devel] [PATCH v2] vfio: convert to 128 bit arithmetic calculations when adding mem regions

2016-03-23 Thread Bandan Das
vfio_listener_region_add for a iommu mr results in an overflow assert since iommu memory region is initialized with UINT64_MAX. Convert calculations to 128 bit arithmetic for iommu memory regions and let int128_get64 assert for non iommu regions if there's an overflow. Suggested-by: Alex

Re: [Qemu-devel] [PATCH] vfio: convert to 128 bit arithmetic calculations when adding mem regions

2016-03-23 Thread Bandan Das
Alex Williamson writes: ... >> >> diff --git a/hw/vfio/common.c b/hw/vfio/common.c >> index fb588d8..9489ff3 100644 >> --- a/hw/vfio/common.c >> +++ b/hw/vfio/common.c >> @@ -323,7 +323,7 @@ static void vfio_listener_region_add(MemoryListener >> *listener, >> { >>

Re: [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h

2016-03-23 Thread Eric Blake
On 03/23/2016 06:17 PM, Eric Blake wrote: > On 03/20/2016 08:43 AM, Veronia wrote: >> >> Signed-off-by: Veronia Bahaa > > Space before <. 'git commit -s' (or 'git commit --amend -s' on an > existing commit) will space things correctly if your ~/.gitconfig is >

Re: [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h

2016-03-23 Thread Eric Blake
On 03/20/2016 08:43 AM, Veronia wrote: > move declarations out of qemu-common.h for functions declared in > utils/ files: e.g. include/qemu/path.h for utils/path.c. > move inline functions out of qemu-common.h and into new files (e.g. > include/qemu/bcd.h) > > Signed-off-by: Veronia

Re: [Qemu-devel] [PATCH qemu v14 17/18] vfio/spapr: Use VFIO_SPAPR_TCE_v2_IOMMU

2016-03-23 Thread Alexey Kardashevskiy
On 03/23/2016 05:03 PM, David Gibson wrote: On Wed, Mar 23, 2016 at 02:06:36PM +1100, Alexey Kardashevskiy wrote: On 03/23/2016 01:53 PM, David Gibson wrote: On Wed, Mar 23, 2016 at 01:12:59PM +1100, Alexey Kardashevskiy wrote: On 03/23/2016 12:08 PM, David Gibson wrote: On Tue, Mar 22, 2016

Re: [Qemu-devel] [PATCH] vfio: convert to 128 bit arithmetic calculations when adding mem regions

2016-03-23 Thread Alex Williamson
On Wed, 23 Mar 2016 16:57:35 -0400 Bandan Das wrote: > vfio_listener_region_add for a iommu mr results in > an overflow assert since vt-d memory region is initialized > with UINT64_MAX. Convert calculations to 128 bit arithmetic > for such regions and let int128_get64 assert for

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Wei Yang
On Wed, Mar 23, 2016 at 10:53:42AM -0600, Eric Blake wrote: >On 03/23/2016 01:18 AM, Li, Liang Z wrote: > >From guest's point of view, there are some pages currently not used by >>> >>> I see in your original RFC patch and your RFC doc, this line starts with a >>> character '>'. Not sure

Re: [Qemu-devel] [PATCH 03/12] block: Introduce BlockBackendPublic

2016-03-23 Thread Eric Blake
On 03/23/2016 03:09 AM, Kevin Wolf wrote: >>> +++ b/block/block-backend.c >>> @@ -33,6 +33,7 @@ struct BlockBackend { >>> DriveInfo *legacy_dinfo;/* null unless created by drive_new() */ >>> QTAILQ_ENTRY(BlockBackend) link; /* for block_backends */ >>>

[Qemu-devel] [PATCH] exec.c: Ensure right alignment also for file backed ram

2016-03-23 Thread Dominik Dingel
While in the anonymous ram case we already take care of the right alignment such an alignment gurantee does not exist for file backed ram allocation. Instead, pagesize is used for alignment. On s390 this is not enough for gmap, as we need to satisfy an alignment up to segments. Reported-by:

Re: [Qemu-devel] [PATCH 10/12] block: Drain throttling queue with BdrvChild callback

2016-03-23 Thread Paolo Bonzini
On 22/03/2016 16:33, Kevin Wolf wrote: > This removes the last part of I/O throttling from block/io.c and moves > it to the BlockBackend. > > When draining the queue of a BlockDriverState, we must make sure that no > new requests can come in for it. Request sources from outside the block >

Re: [Qemu-devel] [PATCH v1] util: fix comment typos

2016-03-23 Thread Eric Blake
On 03/14/2016 03:58 AM, Wei Jiangang wrote: > Signed-off-by: Wei Jiangang > --- > util/buffer.c | 4 ++-- > util/qemu-sockets.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat

Re: [Qemu-devel] [PATCH] Fix some typos found by codespell

2016-03-23 Thread Eric Blake
On 03/23/2016 11:13 AM, Stefan Weil wrote: > I'm no longer sure which spelling is correct. :-) > >>From https://www.fsf.org/about/history.html: > 1985 Richard Stallman creates the Free Sofware Foundation I got a good chuckle out of that; then sent off a bug report to the webmaster. That

[Qemu-devel] [PATCH] vfio: convert to 128 bit arithmetic calculations when adding mem regions

2016-03-23 Thread Bandan Das
vfio_listener_region_add for a iommu mr results in an overflow assert since vt-d memory region is initialized with UINT64_MAX. Convert calculations to 128 bit arithmetic for such regions and let int128_get64 assert for non iommu regions only. Suggested-by: Alex Williamson

Re: [Qemu-devel] [PATCH] quorum: add child name into filename

2016-03-23 Thread Max Reitz
On 18.03.2016 04:21, Wen Congyang wrote: > The monitor command 'query-block' or 'info block' will output the filename. > So we can get each children's child-name after this patch. This useful for > dynamic reconfiguration. > > Signed-off-by: Wen Congyang > --- >

Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver

2016-03-23 Thread Eric Blake
On 03/18/2016 09:19 AM, Kevin Wolf wrote: +ov = opts_visitor_new(opts); + +visit_start_struct(opts_get_visitor(ov), + "luks", NULL, 0, _err); >>> >>> As this refers to "luks" specifically, shouldn't it be inside the switch >>> below? >> >> Or

Re: [Qemu-devel] [RFC v1 09/11] tcg: drop global lock during TCG code execution

2016-03-23 Thread Jan Kiszka
On 2016-03-23 17:27, Alex Bennée wrote: > > KONRAD Frederic writes: > >> Hi Alex, >> >> Thanks for having pulling all that together! >> About this patch the original author was Jan Kiszka >> (https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg03323.html) >> >>

Re: [Qemu-devel] [PATCH 1/3] ide: don't loose pending dma state

2016-03-23 Thread Paolo Bonzini
On 23/03/2016 11:26, Denis V. Lunev wrote: > If the migration occurs after the IDE DMA has been set up but before it > has been initiated, the state gets lost upon save/restore. Specifically, > ->dma_cb callback gets cleared, so, when the guest eventually starts bus > mastering, the DMA never

Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon()

2016-03-23 Thread Max Reitz
On 18.03.2016 11:31, Kevin Wolf wrote: > The call in hmp_drive_del() is dead code because blk_remove_bs() is > called a few lines above. Ah, so that's why I didn't have it in v3. Thanks for solving that mystery for me. :-) > The only other remaining user is >

Re: [Qemu-devel] [PATCH 3/3] ide: really restart pending and in-flight atapi dma

2016-03-23 Thread John Snow
On 03/23/2016 06:26 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > Restart of ATAPI DMA used to be unreachable, because the request to do > so wasn't indicated in bus->error_status due to the lack of spare bits, and > ide_restart_bh() would return early doing

Re: [Qemu-devel] [PATCH v4 00/17] blockdev: Further BlockBackend work

2016-03-23 Thread Max Reitz
On 17.03.2016 14:44, Kevin Wolf wrote: > Am 16.03.2016 um 19:54 hat Max Reitz geschrieben: >> This series appears to reinvent itself with every revision. This time, >> its main implication is that BBs are no longer automatically treated as >> monitor-owned, and that a BB's name is tightly tied to

[Qemu-devel] [Qemu-Devel] [PATCH] Changed malloc to g_malloc, free to g_free in linux-user/qemu.h

2016-03-23 Thread Md Haris Iqbal
Signed-off-by: Md Haris Iqbal --- linux-user/qemu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 26b0ba2..3c3fd15 100644 --- a/linux-user/qemu.h +++ b/linux-user/qemu.h @@ -381,7 +381,7 @@ static inline

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-23 Thread Kevin Wolf
Am 23.03.2016 um 18:58 hat Wouter Verhelst geschrieben: > On Wed, Mar 23, 2016 at 05:16:02PM +0300, Denis V. Lunev wrote: > > +The type of information required by the client is passed to server in > > the > > +command flags field. If the server does not implement requested type or > > +

Re: [Qemu-devel] [PATCH for-2.6 0/7] block: VHD format fixes

2016-03-23 Thread Stefan Hajnoczi
On Tue, Mar 22, 2016 at 11:33:37PM -0400, Jeff Cody wrote: > Fixes for a regression in vpc_create(), as well as a few issues with VHD > format > compatibility. > > > Jeff Cody (6): > block/vpc: fix VPC 'qemu-img create' regression > block/vpc: use current_size field for XenConverter VHD

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-23 Thread Wouter Verhelst
On Wed, Mar 23, 2016 at 05:16:02PM +0300, Denis V. Lunev wrote: > From: Pavel Borzenkov > > With the availability of sparse storage formats, it is often needed to > query status of a particular LBA range and read only those blocks of > data that are actually present on

Re: [Qemu-devel] [PATCH v5 0/4] Implement some QKeyCode support

2016-03-23 Thread Peter Maydell
On 23 March 2016 at 16:52, Programmingkid wrote: > On Mar 23, 2016, at 10:37 AM, Peter Maydell wrote: >> I've put the qapi-schema.json and the ui/cocoa.m patches into the >> cocoa pull I've just sent. For the ADB keyboard part, I definitely >> think that the best

Re: [Qemu-devel] [Nbd] [PATCH 1/2] NBD proto: add WRITE_ZEROES extension

2016-03-23 Thread Wouter Verhelst
On Wed, Mar 23, 2016 at 09:14:10AM -0600, Eric Blake wrote: > On 03/23/2016 08:16 AM, Denis V. Lunev wrote: [...] > [1] Oh, you ARE adding this to the "Experimental extensions" section of > the document, so your wording IS correct. I guess the idea is that we > write up the documentation in the

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] Various block-stream fixes

2016-03-23 Thread Jeff Cody
On Mon, Mar 21, 2016 at 03:47:24PM +0200, Alberto Garcia wrote: > This series is a follow-up to the patch I sent last week[1]. It > contains a few fixes from my intermediate block streaming branch, but > are independent from that feature, so they can be applied now without > problems. > > Berto >

[Qemu-devel] [PATCH v2 5/5] .travis.yml: reduce target list on core configure tweaks

2016-03-23 Thread Alex Bennée
A number of configure options only really affect the core code and any arch specific stuff should be flushed out by other builds: - trace-backends, log build is all targets, others can be less - --disable-build, ensuring disabling stuff doesn't break host - co-routine, default already built

[Qemu-devel] [PATCH v2 4/5] ./configure: accept stems to match a range of targets

2016-03-23 Thread Alex Bennée
This is useful if you want to build all targets of a given architecture or type. A simple submatch to an real target will add it to the list. Signed-off-by: Alex Bennée --- configure | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v2 3/5] .travis.yml: make -j3

2016-03-23 Thread Alex Bennée
The move from Travis VMs to Containers came with a upgrade from 1.5 cores to 2. The received wisdom is -j N+1 means a core can be doing work while other threads wait for IO to complete. This is hard to test on the Travis infrastructure but an initial before/after eyeballing seems to confirm it is

Re: [Qemu-devel] [Nbd] [PATCH 1/2] NBD proto: add WRITE_ZEROES extension

2016-03-23 Thread Wouter Verhelst
Hi, On Wed, Mar 23, 2016 at 05:16:01PM +0300, Denis V. Lunev wrote: > From: Pavel Borzenkov > > There exist some cases when a client knows that the data it is going to > write is all zeroes. Such cases include mirroring or backing up a device > implemented by a sparse

[Qemu-devel] [PATCH v2 0/5] travis: reduce the matrix, add OSX, speed-up builds

2016-03-23 Thread Alex Bennée
Here is v2. I've added two new patches, a tweak to configure to accept stems for target lists and then using that to cut the build time where it makes sense. There has been a little tweak to the OSX build and finally I've added r-b tags to the collapse and j3 patches. Alex Bennée (5):

[Qemu-devel] [PATCH v2 2/5] .travis.yml: enable OSX builds

2016-03-23 Thread Alex Bennée
Travis has support for OSX builds. Making the setup work cleanly involves a little hacking about with the .travis.yml file but rather than make it too messy I've pushed all the "brew" install stuff into a support script called ./scripts/macosx-brew.sh. Currently only the default ./configure

[Qemu-devel] [PATCH v2 1/5] .travis.yml: collapse the test matrix

2016-03-23 Thread Alex Bennée
Remove the concept of TARGETS and build the complete target list for each config combination. Now the matrix is just based on CONFIG stanzas and we use the additional stuff for: - things that only work on one compiler (sparse, gcov, gprof) - combos where "make check" fails Signed-off-by:

Re: [Qemu-devel] [PATCH 2/2] trace: separate MMIO tracepoints from TB-access tracepoints

2016-03-23 Thread Hollis Blanchard
On Wed, 2016-03-23 at 17:53 +0100, Paolo Bonzini wrote: > > On 23/03/2016 17:47, Hollis Blanchard wrote: > > > > Paolo, is it true that only TB-invalidating writes go through the > > io_mem_notdirty path? I'm looking at the live migration code now, > > and it > > seems like every memory write

Re: [Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt power button

2016-03-23 Thread Wei Huang
On 03/23/2016 11:12 AM, Peter Maydell wrote: > On 17 March 2016 at 13:25, Shannon Zhao wrote: >> From: Shannon Zhao >> >> There is a problem for power button that it will not work if an early >> system_powerdown request happens before guest

Re: [Qemu-devel] [PATCH] Fix some typos found by codespell

2016-03-23 Thread Stefan Weil
Am 23.03.2016 um 17:36 schrieb Peter Maydell: > On 23 March 2016 at 14:59, Stefan Weil wrote: >> - * This program is free sofware: you can redistribute it and/or modify >> + * This program is free software: you can redistribute it and/or modify >> * it under the terms of the

Re: [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression

2016-03-23 Thread Stefan Hajnoczi
On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote: > This fails silently as well, since vpc_create() did not set errp > in this failuer case. Set errp in all instances in vpc_create(). s/faileur/failure/ Can be done when merging, no need to resend. signature.asc Description: PGP

[Qemu-devel] [PULL 2/2] default-configs: add mips-softmmu-common.mak

2016-03-23 Thread Leon Alrae
Add mips-softmmu-common.mak and include it in existing mips*-softmmu.mak files to avoid having to repeat CONFIG defines four times. Suggested-by: Peter Maydell Signed-off-by: Leon Alrae --- default-configs/mips-softmmu-common.mak | 32

[Qemu-devel] [PULL 0/2] target-mips queue

2016-03-23 Thread Leon Alrae
since commit ffa6564c9b13cea4b704e184d29d721f2cb061bb: Merge remote-tracking branch 'remotes/weil/tags/pull-wxx-20160322' into staging (2016-03-22 20:27:55 +) are available in the git repository at: git://github.com/lalrae/qemu.git tags/mips-20160323 for you to fetch changes up to b7c4ab809a4bfde4ab322b49fbe2e47536da7487

[Qemu-devel] [PULL 1/2] target-mips: indicate presence of IEEE 754-2008 FPU in R6/R5+MSA CPUs

2016-03-23 Thread Leon Alrae
MIPS Release 6 and MIPS SIMD Architecture make it mandatory to have IEEE 754-2008 FPU which is indicated by CP1 FIR.HAS2008, FCSR.ABS2008 and FCSR.NAN2008 bits set to 1. In QEMU we still keep these bits cleared as there is no 2008-NaN support. However, this now causes problems preventing from

Re: [Qemu-devel] [PATCH v5 1/7] replay: character devices

2016-03-23 Thread Paolo Bonzini
On 23/03/2016 16:45, Kevin Wolf wrote: > Am 14.03.2016 um 08:44 hat Pavel Dovgalyuk geschrieben: >> This patch implements record and replay of character devices. >> It records chardevs communication in replay mode. Recorded information >> include data read from backend and counter of bytes

Re: [Qemu-devel] [PATCH 2/2] trace: separate MMIO tracepoints from TB-access tracepoints

2016-03-23 Thread Paolo Bonzini
On 23/03/2016 17:47, Hollis Blanchard wrote: > Paolo, is it true that only TB-invalidating writes go through the > io_mem_notdirty path? I'm looking at the live migration code now, and it > seems like every memory write will go through that path when global > dirty memory logging is enabled.

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Eric Blake
On 03/23/2016 01:18 AM, Li, Liang Z wrote: >>> >>> >From guest's point of view, there are some pages currently not used by >> >> I see in your original RFC patch and your RFC doc, this line starts with a >> character '>'. Not sure this one has a special purpose? >> > > No special purpose. Maybe

Re: [Qemu-devel] [PATCH v5 0/4] Implement some QKeyCode support

2016-03-23 Thread Programmingkid
On Mar 23, 2016, at 10:37 AM, Peter Maydell wrote: > On 15 March 2016 at 17:13, Programmingkid wrote: >> This patchset adds QKeyCode support to the adb and cocoa code. >> >> Note: you do not need to be on a Mac to test out the adb.c, qapi-schema.json, >> and

Re: [Qemu-devel] [PATCH 00/15] NVDIMM: introduce nvdimm label support

2016-03-23 Thread Stefan Hajnoczi
On Wed, Mar 23, 2016 at 10:46:56AM +0800, Xiao Guangrong wrote: > On 03/23/2016 04:30 AM, Stefan Hajnoczi wrote: > >On Tue, Mar 22, 2016 at 08:37:40AM -0700, Dan Williams wrote: > >>On Thu, Mar 17, 2016 at 3:04 AM, Stefan Hajnoczi wrote: > >>>On Thu, Mar 17, 2016 at 04:32:46PM

Re: [Qemu-devel] [PATCH 2/2] trace: separate MMIO tracepoints from TB-access tracepoints

2016-03-23 Thread Hollis Blanchard
Paolo, is it true that only TB-invalidating writes go through the io_mem_notdirty path? I'm looking at the live migration code now, and it seems like every memory write will go through that path when global dirty memory logging is enabled. -- Hollis Blanchard Mentor

Re: [Qemu-devel] [PATCH] Fix some typos found by codespell

2016-03-23 Thread Peter Maydell
On 23 March 2016 at 14:59, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > > I hope that it is fine not to split this in lots of > small patches. > --- a/qga/channel-win32.c > +++ b/qga/channel-win32.c > @@ -77,7 +77,7 @@ static gboolean

Re: [Qemu-devel] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-23 Thread Eric Blake
On 03/23/2016 08:16 AM, Denis V. Lunev wrote: > From: Pavel Borzenkov > > With the availability of sparse storage formats, it is often needed to > query status of a particular LBA range and read only those blocks of > data that are actually present on the block device.

Re: [Qemu-devel] [RFC v1 09/11] tcg: drop global lock during TCG code execution

2016-03-23 Thread Alex Bennée
KONRAD Frederic writes: > Hi Alex, > > Thanks for having pulling all that together! > About this patch the original author was Jan Kiszka > (https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg03323.html) > > This has probably been dropped during a rebase. I'll

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: fix help menus

2016-03-23 Thread Peter Maydell
On 23 March 2016 at 16:00, Gerd Hoffmann wrote: > On Mi, 2016-03-23 at 14:35 +, Peter Maydell wrote: >> On 15 March 2016 at 19:02, Programmingkid wrote: >> > Make the help menus actually work. The code will search thru three >> > different >> >

Re: [Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt power button

2016-03-23 Thread Peter Maydell
On 17 March 2016 at 13:25, Shannon Zhao wrote: > From: Shannon Zhao > > There is a problem for power button that it will not work if an early > system_powerdown request happens before guest gpio driver loads. > > Here we add the emulation of

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: fix help menus

2016-03-23 Thread Gerd Hoffmann
On Mi, 2016-03-23 at 14:35 +, Peter Maydell wrote: > On 15 March 2016 at 19:02, Programmingkid wrote: > > Make the help menus actually work. The code will search thru three different > > locations for the help file. If it can't be found a dialog will tell the > >

  1   2   3   >