Re: [Qemu-devel] [RFC PATCH 6/8] intel_iommu: support device iotlb descriptor

On Wed, Mar 30, 2016 at 01:08:45PM +0800, Jason Wang wrote: [...] > >> +} else { > >> +sz = VTD_PAGE_SIZE; > >> +} > >> + > >> +entry.target_as = _dev_as->as; > >> +entry.addr_mask = sz - 1; > >> +entry.iova = addr; > >> +

Re: [Qemu-devel] [RFC PATCH 6/8] intel_iommu: support device iotlb descriptor

On 03/28/2016 11:37 AM, Peter Xu wrote: > On Fri, Mar 25, 2016 at 10:13:27AM +0800, Jason Wang wrote: >> This patch enables device IOTLB support for intel iommu. The major >> work is to implement QI device IOTLB descriptor processing and notify >> the device through iommu notifier. >> >> Cc:

Re: [Qemu-devel] [PATCH v3] Add param Error ** for msi_init()

Hi Marcel, Thanks for your quick review for this big fat patch:) please see my comments inline. On 03/30/2016 04:56 AM, Marcel Apfelbaum wrote: On 03/28/2016 01:44 PM, Cao jin wrote: -#define VMXNET3_USE_64BIT (true) -#define VMXNET3_PER_VECTOR_MASK (false) - -static bool

Re: [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races

Hi Christian: On 03/30/2016 12:31 AM, Christian Borntraeger wrote: On 03/29/2016 03:42 PM, Michael S. Tsirkin wrote: This works around races that data plane introduces simply by exiting immediately if we detect that dataplane is active. It's a small but ugly patch, it's only justification is

Re: [Qemu-devel] [PATCH] crypto: do an explicit check for nettle pbkdf functions

On 03/29/2016 10:50 PM, Daniel P. Berrange wrote: > Support for the PBKDF functions in nettle was not introduced > until version 2.6. Some distros QEMU targets have older > versions and thus lack PBKDF support. Address this by doing > a check in configure for the desired function and then skipping

Re: [Qemu-devel] [PATCH v7 1/4] arm: qmp: add query-gic-capabilities interface

On 03/23/2016 08:55 PM, Peter Xu wrote: > This patch add "query-gic-capabilities" but does not implemnet it. The s/implemnet/implement/ > command is ARM-only. The command will return a list of GICCapability > struct that describes all GIC versions that current QEMU and system > support. > >

Re: [Qemu-devel] [Question]Ctrl_R or Alt_R Key Can Not Be Released through noVNC connection

> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, March 29, 2016 6:37 PM > To: Xulei (Stone) > Cc: qemu-devel@nongnu.org; kra...@redhat.com; Gonglei (Arei); Wulizhen > (Pss) > Subject: Re: [Qemu-devel] [Question]Ctrl_R or Alt_R Key Can Not Be

[Qemu-devel] [Bug 1563612] [NEW] pulseaudio applications crash under linux-user-x86_64

Public bug reported: Running a simple application that uses pulseaudio under qemu-i386 or qemu-x86_64 makes it crash (tested on Debian 8.0): # apt-get install build-essential qemu-user libpulse-dev pulseaudio $ cat > test.c << __EOF #include int main(void) { pa_simple *s;

[Qemu-devel] [PULL V2 7/7] Revert "e1000: fix hang of win2k12 shutdown with flood ping"

From: Sameeh Jubran This reverts commit 9596ef7c7b8528bedb240792ea1fb598543ad3c4. This workaround in order to fix endless interrupts is no longer needed because it was superseded by the previous patch (e1000: Fixing interrupt pace). Signed-off-by: Sameeh Jubran

[Qemu-devel] [PULL V2 5/7] tests/test-filter-redirector: Add unit test for filter-redirector

From: Zhang Chen In this unit test,we will test the filter redirector function. Case 1, tx traffic flow: qemu side | test side | +-+| +---+ | backend <---+ sock0 | +++|

[Qemu-devel] [PULL V2 4/7] net/filter-mirror: implement filter-redirector

From: Zhang Chen Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter. filter +

[Qemu-devel] [PULL V2 6/7] e1000: Fixing interrupts pace.

From: Sameeh Jubran This patch introduces an upper bound for number of interrupts per second. Without this bound an interrupt storm can occur as it has been observed on Windows 10 when disabling the device. According to the SPEC - Intel PCI/PCI-X Family of Gigabit Ethernet

[Qemu-devel] [PULL V2 2/7] tests/test-filter-mirror:add filter-mirror unit test

From: Zhang Chen In this unit test we will test the mirror function. start qemu with: -netdev socket,id=qtest-bn0,fd=sockfd -device e1000,netdev=qtest-bn0,id=qtest-e0 -chardev socket,id=mirror0,path=/tmp/filter-mirror-test.sock,server,nowait

[Qemu-devel] [PULL V2 0/7] Net patches

The following changes since commit 553934db664ecee676650fac0330dceff3531736: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2016-03-29 19:54:49 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for

[Qemu-devel] [PULL V2 1/7] net/filter-mirror:Add filter-mirror

From: Zhang Chen Filter-mirror is a netfilter plugin. It gives qemu the ability to mirror packets to a chardev. usage: -netdev tap,id=hn0 -chardev socket,id=mirror0,host=ip_primary,port=X,server,nowait

[Qemu-devel] [PULL V2 3/7] net/filter-mirror: Change filter_mirror_send interface

From: Zhang Chen Change filter_mirror_send interface to make it easier to used by other filter Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang Signed-off-by: Li Zhijian

Re: [Qemu-devel] [PULL 0/7] Net patches

On 03/30/2016 12:39 AM, Peter Maydell wrote: > On 25 March 2016 at 07:42, Jason Wang wrote: >> The following changes since commit b68a80139e37e806f004237e55311ebc42151434: >> >> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into >> staging (2016-03-24

Re: [Qemu-devel] [RFC PATCH 4/8] exec: introduce address_space_get_iotlb_entry()

On 03/28/2016 10:18 AM, Peter Xu wrote: > On Fri, Mar 25, 2016 at 10:13:25AM +0800, Jason Wang wrote: >> This patch introduces a helper to query the iotlb entry for a >> possible iova. This will be used by later device IOTLB API to enable >> the capability for a dataplane (e.g vhost) to query

Re: [Qemu-devel] [RFC PATCH 2/8] intel_iommu: name vtd address space with devfn

On 03/28/2016 10:02 AM, Peter Xu wrote: > On Fri, Mar 25, 2016 at 10:13:23AM +0800, Jason Wang wrote: >> To avoid duplicated name and ease debugging. >> >> Cc: Michael S. Tsirkin >> Cc: Paolo Bonzini >> Cc: Richard Henderson >> Cc:

[Qemu-devel] [ANNOUNCE] QEMU 2.5.1 Stable released

Hi everyone, I am pleased to announce that the QEMU v2.5.1 stable release is now available at: http://wiki.qemu.org/download/qemu-2.5.1.tar.bz2 v2.5.1 is now tagged in the official qemu.git repository, and the stable-2.5 branch has been updated accordingly:

Re: [Qemu-devel] [PATCH v2 3/3] doc: Propose Structured Read extension

On 03/29/2016 05:01 PM, Eric Blake wrote: > The existing transmission phase protocol is difficult to sniff, > because correct interpretation of the server stream requires > context from the client stream (or risks false positives if > data payloads happen to contain the protocol magic numbers).

Re: [Qemu-devel] [PATCHv2] Strawman proposal for NBD structured replies

On 03/29/2016 04:48 PM, Alex Bligh wrote: > Here's a strawman for the structured reply section. I haven't > covered negotation. > > Also at: > https://github.com/abligh/nbd/tree/strawman-structured-reply > Markdown at: >

[Qemu-devel] [PATCH v2 3/3] doc: Propose Structured Read extension

The existing transmission phase protocol is difficult to sniff, because correct interpretation of the server stream requires context from the client stream (or risks false positives if data payloads happen to contain the protocol magic numbers). It also prohibits the ability to do efficient

[Qemu-devel] [PATCH v2 1/3] NBD proto: add "Command flags" section

From: Pavel Borzenkov Add separate "Command flags" section to make it clear which flags are currently defined by the protocol. Signed-off-by: Pavel Borzenkov Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev

[Qemu-devel] [PATCH v2 0/3] NBD Structured Read

I wrote this in parallel with Alex's strawman proposals, so I may have picked up on some of his ideas, while diverging in other places. Changes since v1: rebase, resend some pre-req patches, switch from global/client flag negotiation over to option negotiation, document a flags/type scheme in all

[Qemu-devel] [PATCH v2 2/3] doc: Mention proper use of handle

Although the proper use of the handle field during transmission phase was implied, it never hurts to make it more explicit that clients should use distinct handles for multiple in-flight requests. Likewise, the server must repeat the handle unchanged, in order for the client to track when the

Re: [Qemu-devel] [Nbd] [PATCH] Strawman proposal for NBD structured replies

On 03/29/2016 04:31 PM, Wouter Verhelst wrote: > > Maybe the "MAY set the offset" above should just be a "MUST set the > offset", with the clarification that the offset "MUST not be beyond the > actual error location, but MAY be before it if the server has no > detailed information", or something

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On 29 Mar 2016, at 23:45, Wouter Verhelst wrote: > Doing that requires performing a lookup to negotiated state (and a code > branch) for every response type that can possibly be structured or > nonstructured, and introduces exactly the two code paths that I think > should be

[Qemu-devel] [PATCHv2] Strawman proposal for NBD structured replies

Here's a strawman for the structured reply section. I haven't covered negotation. Also at: https://github.com/abligh/nbd/tree/strawman-structured-reply Markdown at: https://github.com/abligh/nbd/blob/strawman-structured-reply/doc/proto.md Changes since v1: * Fixed some formatting *

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On Tue, Mar 29, 2016 at 11:05:38PM +0100, Alex Bligh wrote: > > On 29 Mar 2016, at 22:05, Wouter Verhelst wrote: > > >>> For all remaining existing commands, that is just more overhead on the > >>> wire. The existing non-structured replies do not send any data; they > >>> are 16

[Qemu-devel] [Bug 1006655] Re: Can't convert to vmdk with the streamOptimized subformat

I'm confused- this is marked as affecting qemu-kvm in precise, but the preceding patch (c6ac36e) which introduced the bug is not there either. So I'm going to mark this as not affecting precise unless someone speaks up to say that we in fact need the whole dependent series. ** Changed in:

Re: [Qemu-devel] [Nbd] [PATCH] Strawman proposal for NBD structured replies

On Tue, Mar 29, 2016 at 10:59:18PM +0100, Alex Bligh wrote: > On 29 Mar 2016, at 21:57, Wouter Verhelst wrote: > > > > I understand why you do it this way (we don't need 2^16 reply types), > > but (in contrast to the flags in the request packet) this makes it > > harder to specify

[Qemu-devel] [Bug 1562653] Re: Ubuntu 15.10: QEMU VM hang if memory >= 1T

Hi, just to be sure, if you run kvm -vnc :1 -m 1.5G kvm -vnc :1 -m 1.5G --no-hpet do those also crash? Can you please show the contents of /var/log/libvirt/qemu/u1510-1.log ** Package changed: kvm (Ubuntu) => qemu (Ubuntu) ** Also affects: qemu Importance: Undecided Status: New

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

But unfortunately we do not know which patch fixed it, making an SRU much more problematic. Someone who is able to reproduce the bug would need to try to either bisect, or make educated guesses and test patch cherrypicks. -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On 29 Mar 2016, at 22:05, Wouter Verhelst wrote: >>> For all remaining existing commands, that is just more overhead on the >>> wire. The existing non-structured replies do not send any data; they >>> are 16 bytes each (only NBD_CMD_READ sends more than 16 bytes in one >>>

Re: [Qemu-devel] [Nbd] [PATCH] Strawman proposal for NBD structured replies

On 29 Mar 2016, at 21:57, Wouter Verhelst wrote: > > I understand why you do it this way (we don't need 2^16 reply types), > but (in contrast to the flags in the request packet) this makes it > harder to specify flags and command type as separate fields (there is no > 24-bit

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

Hi Alex, On Tue, Mar 29, 2016 at 09:44:39PM +0100, Alex Bligh wrote: > Eric, > > For all remaining existing commands, that is just more overhead on the > > wire. The existing non-structured replies do not send any data; they > > are 16 bytes each (only NBD_CMD_READ sends more than 16 bytes in

Re: [Qemu-devel] [Nbd] [PATCH] Strawman proposal for NBD structured replies

On Tue, Mar 29, 2016 at 09:39:43PM +0100, Alex Bligh wrote: > Here's a strawman for the structured reply section. I haven't > covered negotation. LGTM, for the most part. [...] > +Each chunk consists of the following: > + > +S: 32 bits, 0x668e33ef, magic (`NBD_STRUCTURED_REPLY_MAGIC`) > +S: 32

Re: [Qemu-devel] [PATCH v3] Add param Error ** for msi_init()

On 03/28/2016 01:44 PM, Cao jin wrote: Add param Error **errp, and change pci_add_capability() to pci_add_capability2(), because pci_add_capability() report error, and msi_init() is widely used in realize(), so it is not suitable for realize(). Hi, The patch is looking good in my opinion, a

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

Eric, > I'm liking it - then we aren't sending a mandatory 0 error field on read > chunks. Straw man patch sent through. Alternatively at: https://github.com/abligh/nbd/commit/3c40272704904ac74040ceb099fee0b44e355e1e and in markdown format at:

[Qemu-devel] [PATCH] Strawman proposal for NBD structured replies

Here's a strawman for the structured reply section. I haven't covered negotation. Signed-off-by: Alex Bligh --- doc/proto.md | 114 +-- 1 file changed, 111 insertions(+), 3 deletions(-) diff --git a/doc/proto.md

Re: [Qemu-devel] [PATCH v2 2/3] tcg: reorganize tb_find_physical loop

On 03/29/2016 12:48 PM, Sergey Fedorov wrote: > From: Alex Bennée > > Put some comments and improve code structure. This should help reading > the code. > > Signed-off-by: Alex Bennée > [Sergey Fedorov: provide commit message; bring back

Re: [Qemu-devel] [PATCH v2 2/3] tcg: reorganize tb_find_physical loop

On 03/29/2016 12:48 PM, Sergey Fedorov wrote: > +while (tb) { > if (tb->pc == pc && > tb->page_addr[0] == phys_page1 && > tb->cs_base == cs_base && > tb->flags == flags) { > -/* check next page if needed */ > -if

Re: [Qemu-devel] [PATCH] xilinx_zynq: merged support for ULPI PHY and ULPI viewport from xilinx/qemu

On Tue, Mar 29, 2016 at 12:51 PM, wrote: > Signed-off-by: Joscha Benz Hello Joscha , Thanks for the patch. In future can you please use git send-email to send the patches instead of attaching the patch file. You can find more information on doing this at:

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On 29 Mar 2016, at 21:00, Eric Blake wrote: > I'm liking it - then we aren't sending a mandatory 0 error field on read > chunks. I'm writing it up as a strawman. I'll comment in a sec in further detail. -- Alex Bligh signature.asc Description: Message signed with

Re: [Qemu-devel] [PATCH v12 0/9] PTimer fixes/features and ARM MPTimer conversion

29.03.2016 22:00, Peter Maydell пишет: On 28 March 2016 at 14:22, Dmitry Osipenko wrote: Hello Peter, 16.03.2016 17:36, Peter Maydell пишет: On 30 January 2016 at 16:43, Dmitry Osipenko wrote: Changelog for ARM MPTimer QEMUTimer to ptimer conversion:

Re: [Qemu-devel] [PATCH v7 0/4] ARM: add query-gic-capabilities QMP command

On 24 March 2016 at 02:55, Peter Xu wrote: > This patch is to add ARM-specific command "query-gic-capability". > > The new command can report which kind of GIC device the host/QEMU > support. The returned result is in the form of array. > > Sample command and output: > >

Re: [Qemu-devel] [PATCH v2 1/3] tcg: code_bitmap is not used by user-mode emulation

On 03/29/2016 12:48 PM, Sergey Fedorov wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > [Sergey Fedorov: eliminate the field entirely in user-mode] > Signed-off-by: Sergey Fedorov > --- > > Notes: >

Re: [Qemu-devel] [PATCH v7 2/4] arm: enhance kvm_arm_create_scratch_host_vcpu

On 24 March 2016 at 02:55, Peter Xu wrote: > Some more lines to make sure we allow NULL for 1st/3rd parameter. > > Signed-off-by: Peter Xu > --- > target-arm/kvm.c | 14 +- > target-arm/kvm_arm.h | 6 -- > 2 files changed, 17

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On 03/29/2016 01:39 PM, Alex Bligh wrote: > I think we are paying too much attention to trying to keep NBD_RESPONSE > intact. The justification for this was (I think) that it made it easier > for existing protocol analysers. It doesn't, really, as all the data > is going to come BEFORE the

Re: [Qemu-devel] [PULL 00/48] Block layer patches

On 29 March 2016 at 16:08, Kevin Wolf wrote: > The following changes since commit b68a80139e37e806f004237e55311ebc42151434: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into > staging (2016-03-24 16:24:02 +) > > are available in the git repository

Re: [Qemu-devel] [PULL 00/21] target-mips queue for 2.6

ce commit b68a80139e37e806f004237e55311ebc42151434: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into > staging (2016-03-24 16:24:02 +) > > are available in the git repository at: > > git://github.com/lalrae/qemu.git tags/mips-20160329 > >

[Qemu-devel] [PATCH] xilinx_zynq: merged support for ULPI PHY and ULPI viewport from xilinx/qemu

Signed-off-by: Joscha Benz --- hw/usb/hcd-ehci-sysbus.c | 175 ++--- hw/usb/hcd-ehci.c| 1 + hw/usb/hcd-ehci.h| 31 ++ include/hw/register.h| 245 +++ 4 files changed, 441

[Qemu-devel] [PATCH v2 2/3] tcg: reorganize tb_find_physical loop

From: Alex Bennée Put some comments and improve code structure. This should help reading the code. Signed-off-by: Alex Bennée [Sergey Fedorov: provide commit message; bring back resetting of tb_invalidated_flag] Signed-off-by: Sergey Fedorov

[Qemu-devel] [PATCH v2 3/3] cpu-exec: elide more icount code if CONFIG_USER_ONLY

From: Paolo Bonzini Signed-off-by: Paolo Bonzini [Alex Bennée: #ifndef replay code to match elided functions] Signed-off-by: Alex Bennée Signed-off-by: Sergey Fedorov --- cpu-exec.c | 8 1

Re: [Qemu-devel] [PULL 0/3] Block patches for 2.6

On 29 March 2016 at 03:49, Jeff Cody wrote: > The following changes since commit b68a80139e37e806f004237e55311ebc42151434: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into > staging (2016-03-24 16:24:02 +) > > are available in the git repository

[Qemu-devel] [PATCH v2 0/3] tcg: Misc clean-up patches from Paolo and Alex

From: Sergey Fedorov This patch series consists of various general TCG clean-up patches extracted from Paolo's MTTCG tree [1] and Alex's MTTCG base enablement tree [2]. The idea is to review and merge these patches separately from the MTTCG series to cut the latter and make

Re: [Qemu-devel] [PATCH v5 0/6] Add i.MX6 (Single/Dual/Quad) support

On 26 March 2016 at 11:06, Jean-Christophe Dubois wrote: > This patch series adds support for the Freescale i.MX6 processor. > > For now we only support the following devices: > * up to 4 Cortex A9 cores > * A9 MPCORE (SCU, GIC, TWD) > * 5 i.MX UARTs > * 2 EPIT timers > * 1

[Qemu-devel] [PATCH v2 1/3] tcg: code_bitmap is not used by user-mode emulation

From: Paolo Bonzini Signed-off-by: Paolo Bonzini [Sergey Fedorov: eliminate the field entirely in user-mode] Signed-off-by: Sergey Fedorov --- Notes: Changes in v2: * The field is eliminated entirely in user-mode

Re: [Qemu-devel] [PATCH v5 1/6] ARM: Factor out ARM on/off PSCI control functions

On 26 March 2016 at 11:06, Jean-Christophe Dubois wrote: > Split ARM on/off function from PSCI support code. > > This will allow to reuse these functions in other code. > > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since V1: > * Not

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On 29 Mar 2016, at 19:51, Wouter Verhelst wrote: >> >> But I was envisioning the opposite: the server must NOT send X bytes >> unless it knows they are valid; if it encounters a read error at Z, >> then it sends a structured read of Z-1 bytes before the final normal >> message

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On Tue, Mar 29, 2016 at 08:51:57PM +0200, Wouter Verhelst wrote: > On Tue, Mar 29, 2016 at 12:23:31PM -0600, Eric Blake wrote: > > Unfortunately, I chose the design of 0 or more structured replies > > followed by a normal reply, so that the normal reply is a reliable > > indicator that the read is

Re: [Qemu-devel] [PATCH 0/3] Add guest PMU in machine virt

On 25 March 2016 at 09:46, Shannon Zhao wrote: > From: Shannon Zhao > > KVM-ARM64 supports guest PMU now. This series add the support in machine > virt so that guest could use PMU. > > Shannon Zhao (3): > target-arm: kvm64: set guest PMUv3

Re: [Qemu-devel] [PATCH v12 0/9] PTimer fixes/features and ARM MPTimer conversion

On 28 March 2016 at 14:22, Dmitry Osipenko wrote: > Hello Peter, > > 16.03.2016 17:36, Peter Maydell пишет: >> >> On 30 January 2016 at 16:43, Dmitry Osipenko wrote: >> >>> Changelog for ARM MPTimer QEMUTimer to ptimer conversion: >> >> >> So, where are we

Re: [Qemu-devel] [PATCH 9/9] block: Remove BlockDriverState.blk

On 22.03.2016 20:36, Kevin Wolf wrote: > This patch removes the remaining users of bs->blk, which will allow us > to have multiple BBs on top of a single BDS. All checks that are > currently in place to prevent the user from creating such setups. I think this sentence is missing a word or two. >

Re: [Qemu-devel] [PULL 0/5] slirp updates

On 29 March 2016 at 00:28, Samuel Thibault wrote: > Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2016-03-21-tag' > into staging (2016-03-22 17:39:48 +) > > are available in the git repository at: > > http://people.debian.org/~sthibault/qemu.git

Re: [Qemu-devel] [PATCH 8/9] block: Don't return throttling info in query-named-block-nodes

On 22.03.2016 20:36, Kevin Wolf wrote: > query-named-block-nodes should not return information that is related > to the attached BlockBackend rather than the node itself, so throttling > information needs to be removed from it. > > Signed-off-by: Kevin Wolf > --- >

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On Tue, Mar 29, 2016 at 12:23:31PM -0600, Eric Blake wrote: > On 03/29/2016 11:53 AM, Wouter Verhelst wrote: > > Hi Eric, > > > > Having read this in more detail now: > > > > On Mon, Mar 28, 2016 at 09:56:36PM -0600, Eric Blake wrote: > >> + The server MUST ensure that each read chunk lies

Re: [Qemu-devel] [PATCH 7/9] block: Avoid bs->blk in bdrv_next()

On 22.03.2016 20:36, Kevin Wolf wrote: > We need to introduce a separate BdrvNextIterator struct that can keep > more state than just the current BDS in order to avoid using the bs->blk > pointer. > > Signed-off-by: Kevin Wolf > --- > block.c| 34

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On 03/29/2016 12:19 PM, Wouter Verhelst wrote: > On Tue, Mar 29, 2016 at 12:07:59PM -0600, Eric Blake wrote: >> On 03/29/2016 12:03 PM, Wouter Verhelst wrote: >>> On Tue, Mar 29, 2016 at 11:45:45AM -0600, Eric Blake wrote: Supporting DF merely transfers the burden of collection between server

Re: [Qemu-devel] [PATCH 6/9] block: Remove bdrv_move_feature_fields()

On 22.03.2016 20:36, Kevin Wolf wrote: > bdrv_move_feature_fields() and swap_feature_fields() are empty now, they > can be removed. > > Signed-off-by: Kevin Wolf > --- > block.c | 30 -- > 1 file changed, 30 deletions(-) Nice. :-) Reviewed-by: Max

Re: [Qemu-devel] [PATCH 5/9] block: Avoid BDS.blk in bdrv_next()

On 22.03.2016 20:36, Kevin Wolf wrote: > We just want to know whether a BDS has at least one BB attached in order > to avoid enumerating it twice. This doesn't depend on the exact BB that > is attached and is still a valid question when more than one BB can be > attached, so just answer it by

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On 03/29/2016 11:53 AM, Wouter Verhelst wrote: > Hi Eric, > > Having read this in more detail now: > > On Mon, Mar 28, 2016 at 09:56:36PM -0600, Eric Blake wrote: >> + The server MUST ensure that each read chunk lies within the original >> + offset and length of the original client request,

Re: [Qemu-devel] [PATCH 4/9] block: Remove bdrv_aio_multiwrite()

On 22.03.2016 20:36, Kevin Wolf wrote: > Since virtio-blk implements request merging itself these days, the only > remaining users are test cases for the function. That doesn't make the > function exactly useful any more. > > Signed-off-by: Kevin Wolf > --- >

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On Tue, Mar 29, 2016 at 12:07:59PM -0600, Eric Blake wrote: > On 03/29/2016 12:03 PM, Wouter Verhelst wrote: > > On Tue, Mar 29, 2016 at 11:45:45AM -0600, Eric Blake wrote: > >> Supporting DF merely transfers the burden of collection between server > >> and client. I suspect that there are cases

Re: [Qemu-devel] [PATCH 3/9] block jobs: Use BdrvChild callbacks for iostatus operations

On 22.03.2016 20:36, Kevin Wolf wrote: > The block jobs currently modify the target BB's error handling options > and require that the source BB's iostatus is enabled in order to > implement the per-job error options. It's obvious that this is something > between ugly, adventurous and plain wrong,

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On 29 Mar 2016, at 19:03, Wouter Verhelst wrote: > There are other ways to handle that; e.g., the server could have a > "request too large for non-fragmented read" error message. The spec > should give a minimum size that the server MUST support (which should be > reasonably

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On 03/29/2016 12:03 PM, Wouter Verhelst wrote: > On Tue, Mar 29, 2016 at 11:45:45AM -0600, Eric Blake wrote: >> On 03/29/2016 11:34 AM, Alex Bligh wrote: >>> I would agree. I think if it supports the structured reply semantics, >>> it should also support 'DF'. So if you know the server supports

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On Tue, Mar 29, 2016 at 11:45:45AM -0600, Eric Blake wrote: > On 03/29/2016 11:34 AM, Alex Bligh wrote: > > I would agree. I think if it supports the structured reply semantics, > > it should also support 'DF'. So if you know the server supports > > structured replies, you know you can set DF on

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/8] tcg: Clean up direct block chaining data fields

On 29/03/16 19:26, Peter Maydell wrote: > On 29 March 2016 at 09:31, Sergey Fedorov wrote: >> On 29/03/16 01:12, Richard Henderson wrote: >>> On 03/24/2016 08:11 AM, Paolo Bonzini wrote: There is also a case where a TB jumps to itself; it then appears twice in the

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

Hi Eric, Having read this in more detail now: On Mon, Mar 28, 2016 at 09:56:36PM -0600, Eric Blake wrote: > + The server MUST ensure that each read chunk lies within the original > + offset and length of the original client request, MUST NOT send read > + chunks that would cover the same

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On 03/29/2016 11:34 AM, Alex Bligh wrote: > > On 29 Mar 2016, at 16:12, Eric Blake wrote: >>> >>> More a way of guaranteeing avoiding a fragmentation on 'simple' reads. >>> Perhaps a 'DF' bit (don't fragment)! If the server doesn't like it, it >>> can always error the command.

Re: [Qemu-devel] [PATCH 2/9] block: User BdrvChild callback for device name

On 22.03.2016 20:36, Kevin Wolf wrote: > In order to get rid of bs->blk for bdrv_get_device_name() and > bdrv_get_device_or_node_name(), ask all parents for their name and > simply pick the first one. > > Signed-off-by: Kevin Wolf > --- > block.c | 22

Re: [Qemu-devel] [PATCH 1/9] block: Use BdrvChild callbacks for change_media/resize

On 22.03.2016 20:36, Kevin Wolf wrote: > We want to get rid of BlockDriverState.blk in order to allow multiple > BlockBackends per BDS. Converting the device callbacks in block.c (which > assume a single BlockBackend) to per-child callbacks gets us rid of the > first few instances. > >

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On 29 Mar 2016, at 16:12, Eric Blake wrote: >> >> More a way of guaranteeing avoiding a fragmentation on 'simple' reads. >> Perhaps a 'DF' bit (don't fragment)! If the server doesn't like it, it >> can always error the command. > > Okay, that makes sense. Does reusing

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

* Max Reitz (mre...@redhat.com) wrote: > On 29.03.2016 18:03, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > >> On 29.03.2016 17:54, Dr. David Alan Gilbert wrote: > >>> * Max Reitz (mre...@redhat.com) wrote: > On 29.03.2016 17:50, Dr. David Alan Gilbert wrote: >

Re: [Qemu-devel] [PULL] VFIO updates 2016-03-28

On 28 March 2016 at 23:34, Alex Williamson wrote: > The following changes since commit b68a80139e37e806f004237e55311ebc42151434: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into > staging (2016-03-24 16:24:02 +) > > are available in the

Re: [Qemu-devel] [RFC v2 3/9] virtio: stop virtqueue processing if device is broken

On Tue, 29 Mar 2016 17:12:55 +0100 Stefan Hajnoczi wrote: > QEMU prints an error message and exits when the device enters an invalid > state. Terminating the process is heavy-handed. The guest may still be > able to function even if there is a bug in a virtio guest driver.

Re: [Qemu-devel] [PULL 0/7] Net patches

On 25 March 2016 at 07:42, Jason Wang wrote: > The following changes since commit b68a80139e37e806f004237e55311ebc42151434: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into > staging (2016-03-24 16:24:02 +) > > are available in the git

Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension

On Tue, Mar 29, 2016 at 09:12:02AM -0600, Eric Blake wrote: > On 03/29/2016 08:37 AM, Alex Bligh wrote: > > Eric, > > > >> I guess what I need to add is that in transmission phase, most commands > >> have exactly one response per request; but commands may document > >> scenarios where there will

Re: [Qemu-devel] [PULL v4 00/28] Misc patches for QEMU 2.6 hard freeze

On 24 March 2016 at 21:33, Paolo Bonzini wrote: > The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18' > into staging (2016-03-18 17:18:41 +) > > are available in the

Re: [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races

On 03/29/2016 03:42 PM, Michael S. Tsirkin wrote: > This works around races that data plane introduces > simply by exiting immediately if we detect > that dataplane is active. > > It's a small but ugly patch, it's only justification > is that it's minimally intrusive, and that it clearly > has no

Re: [Qemu-devel] [PATCH 0/6] virtio: refactor host notifiers

On 03/29/2016 03:50 PM, Paolo Bonzini wrote: > > > On 29/03/2016 13:45, Cornelia Huck wrote: Hi Tu Bo, please always include the assertion patch at https://lists.gnu.org/archive/html/qemu-block/2016-03/msg00546.html in your tests. Can you include the backtrace from all

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/8] tcg: Clean up direct block chaining data fields

On 29 March 2016 at 09:31, Sergey Fedorov wrote: > On 29/03/16 01:12, Richard Henderson wrote: >> On 03/24/2016 08:11 AM, Paolo Bonzini wrote: >>> There is also a case where a TB jumps to itself; it then appears twice >>> in the list with different values in the low bits,

[Qemu-devel] [PATCH] iotests: Make 150 use qemu-img map instead of du

The actual on-disk size of a file does not only depend on factors qemu can control. Thus, we should not depend on this to determine whether a file has indeed been fully allocated. Instead, use qemu-img map and hope that if an area is referenced, it is indeed allocated, too. Also, limit the

Re: [Qemu-devel] [PATCH v2 0/4] qemu-img: Fix preallocation with -S 0 for convert

Am 24.03.2016 um 23:33 hat Max Reitz geschrieben: > Using -S 0 is supposed to allocate everything in the output image; or at > least it is supposed to always explicitly write zeros even if the area > in question is known to only contain zeros. That doesn't always work > right now, so this series

[Qemu-devel] [RFC v2 7/9] virtio: handle virtqueue_read_next_desc() errors

Stop processing the vring if an avail ring index is invalid. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 45 - 1 file changed, 32 insertions(+), 13 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c

Re: [Qemu-devel] [PATCH 1/2] memory: Remove code for mr->may_overlap

On 25 March 2016 at 10:10, Fam Zheng wrote: > The collision check does nothing and hasn't been used. Remove the > variable together with related code. > > Signed-off-by: Fam Zheng I would prefer it if we enabled the collision check and fixed the things which

[Qemu-devel] [RFC v2 5/9] virtio: handle virtqueue_get_avail_bytes() errors

If the vring is invalid, tell the caller no bytes are available and mark the device broken. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c

[Qemu-devel] [RFC v2 3/9] virtio: stop virtqueue processing if device is broken

QEMU prints an error message and exits when the device enters an invalid state. Terminating the process is heavy-handed. The guest may still be able to function even if there is a bug in a virtio guest driver. Moreover, exiting is a bug in nested virtualization where a nested guest could DoS

  1   2   3   4   >