Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

2016-04-10 Thread Claudio Fontana
Clearly late to the party, On 08.04.2016 22:14, Paolo Bonzini wrote: > > On 08/04/2016 15:15, Markus Armbruster wrote: >>> On the other hand, minimal usage of templates instead of some of the >>> preprocessor gunk we have would be a very good thing IMNSHO. I am >>> referring to the multiply

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-10 Thread Changlong Xie
On 03/30/2016 11:07 PM, Max Reitz wrote: On 30.03.2016 13:39, Alberto Garcia wrote: On Tue 29 Mar 2016 05:51:22 PM CEST, Max Reitz wrote: It sounds like the argument here, and in Max's thread on query-block-node-tree, is that we DO have cases where order matters, and so we need a way for the

Re: [Qemu-devel] [PATCH] intel_iommu: fix incorrect mask for IOTLB invalidate desc

2016-04-10 Thread Peter Xu
On Mon, Apr 11, 2016 at 11:00:21AM +0800, Peter Xu wrote: > Address Mask (AM) should be 6 bits long, not 7. (vt-d spec 6.5.2.3) > OMG I was wrong... Sorry please ignore this one. -- peterx

Re: [Qemu-devel] [PATCH for-2.7 v6 2/2] spapr: implement query-hotpluggable-cpus callback

2016-04-10 Thread David Gibson
On Fri, 8 Apr 2016 13:29:56 +0200 Igor Mammedov wrote: > it returns a list of present/possible to hotplug CPU > objects with a list of properties to use with > device_add. > > in spapr case returned list would looks like: > -> { "execute": "query-hotpluggable-cpus" } >

Re: [Qemu-devel] [PATCH for-2.7 v6 1/2] QMP: add query-hotpluggable-cpus

2016-04-10 Thread David Gibson
On Fri, 8 Apr 2016 13:29:55 +0200 Igor Mammedov wrote: > it will allow mgmt to query present and hotpluggable > CPU objects, it is required from a target platform that > wish to support command to implement and set > MachineClass.query_hotpluggable_cpus > callback, which

[Qemu-devel] [PATCH v4 1/1] Introduce "xen-load-devices-state"

2016-04-10 Thread Changlong Xie
From: Wen Congyang Introduce a "xen-load-devices-state" QAPI command that can be used to load the state of all devices, but not the RAM or the block devices of the VM. We only have hmp commands savevm/loadvm, and qmp commands xen-save-devices-state. We use this new

[Qemu-devel] [PATCH v4 0/1] Introduce "xen-load-devices-state"

2016-04-10 Thread Changlong Xie
Changelog v4: 1. Rebased to the lastest code v3: 1. Addressed on David's commets, fix a bug v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1): Introduce "xen-load-devices-state" migration/savevm.c | 36

Re: [Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-04-10 Thread Peter Xu
Hi, Aviv, On Sat, Apr 09, 2016 at 09:03:38PM +0300, Aviv B.D. wrote: [...] > +static int vtd_get_did_dev(IntelIOMMUState *s, uint8_t bus_num, > uint8_t devfn, uint16_t * domain_id) It seems that there are two lines above, however what I feel is that this is a long line splitted by the email

[Qemu-devel] ping [PATCH 3/3] hid.c: Add debug support

2016-04-10 Thread Programmingkid
https://patchwork.ozlabs.org/patch/602037/ Add debug macros to the code for easier debugging. Signed-off-by: John Arbuckle --- hw/input/hid.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/input/hid.c b/hw/input/hid.c index 329a27b..42ca592

[Qemu-devel] ping [PATCH 2/3] hid.c: convert to QKeyCode

2016-04-10 Thread Programmingkid
https://patchwork.ozlabs.org/patch/602036/ Switches hid.c from PS/2 to QKeyCode support. Signed-off-by: John Arbuckle --- hw/input/hid.c | 270 ++--- 1 file changed, 179 insertions(+), 91 deletions(-) diff --git

[Qemu-devel] [PATCH] intel_iommu: fix incorrect mask for IOTLB invalidate desc

2016-04-10 Thread Peter Xu
Address Mask (AM) should be 6 bits long, not 7. (vt-d spec 6.5.2.3) Signed-off-by: Peter Xu --- hw/i386/intel_iommu_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index

[Qemu-devel] ping [PATCH 1/3] usb-keys.h: initial commit

2016-04-10 Thread Programmingkid
https://patchwork.ozlabs.org/patch/602035/ Create an emum of all the USB HID keyboard values. Signed-off-by: John Arbuckle --- include/hw/input/usb-keys.h | 154 1 file changed, 154 insertions(+) create mode 100644

[Qemu-devel] ping [PATCH 0/3] Switch USB HID to QKeyCode

2016-04-10 Thread Programmingkid
https://patchwork.ozlabs.org/patch/602035/ This patchset switches from the PS/2 keycode to QKeyCode support in the hid.c file. John Arbuckle (3): usb-keys.h: initial commit hid.c: convert to QKeyCode hid.c: Add debug support hw/input/hid.c | 279

[Qemu-devel] [PATCH v3 09/10] tcg: Clean up direct block chaining safety checks

2016-04-10 Thread Sergey Fedorov
From: Sergey Fedorov We don't take care of direct jumps when address mapping changes. Thus we must be sure to generate direct jumps so that they always keep valid even if address mapping changes. However we only allow to execute a TB if it was generated from the pages which

[Qemu-devel] [PATCH v3 08/10] tcg: Clean up tb_jmp_unlink()

2016-04-10 Thread Sergey Fedorov
From: Sergey Fedorov Unify the code of this function with tb_jmp_remove_from_list(). Making these functions similar improves their readability. Also this could be a step towards making this function thread-safe. Signed-off-by: Sergey Fedorov

[Qemu-devel] [PATCH v3 00/10] tcg: Direct block chaining clean-up

2016-04-10 Thread Sergey Fedorov
From: Sergey Fedorov This series combines a set of patches which is meant to improve overall code structure and readability of direct block chaining mechanism. The other point is to make a step towards thread safety of TB chainig. The series' tree can be found in a public

[Qemu-devel] [PATCH v3 10/10] tcg: Moderate direct block chaining safety checks in user mode

2016-04-10 Thread Sergey Fedorov
From: Sergey Fedorov In user mode, there's only a static address translation, TBs are always invalidated properly and direct jumps are reset when mapping change. Thus the destination address is always valid for direct jumps and there's no need to restrict it to the pages

[Qemu-devel] [PATCH v3 07/10] tcg: Extract removing of jumps to TB from tb_phys_invalidate()

2016-04-10 Thread Sergey Fedorov
From: Sergey Fedorov Move the code for removing jumps to a TB out of tb_phys_invalidate() to a separate static inline function tb_jmp_unlink(). This simplifies tb_phys_invalidate() and improves code structure. Signed-off-by: Sergey Fedorov

[Qemu-devel] [PATCH v3 06/10] tcg: Rename tb_jmp_remove() to tb_remove_from_jmp_list()

2016-04-10 Thread Sergey Fedorov
From: Sergey Fedorov tb_jmp_remove() was only used to remove the TB from a list of all TBs jumping to the same TB which is n-th jump destination of the given TB. Put a comment briefly describing the function behavior and rename it to better reflect its purpose.

[Qemu-devel] [PATCH v3 04/10] tcg: Init TB's direct jumps before making it visible

2016-04-10 Thread Sergey Fedorov
From: Sergey Fedorov Initialize TB's direct jump list data fields and reset the jumps before tb_link_page() puts it into the physical hash table and the physical page list. So TB is completely initialized before it becomes visible. Signed-off-by: Sergey Fedorov

[Qemu-devel] [PATCH v3 03/10] tcg: Rearrange tb_link_page() to avoid forward declaration

2016-04-10 Thread Sergey Fedorov
From: Sergey Fedorov Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée --- translate-all.c | 204 1 file

[Qemu-devel] [PATCH v3 05/10] tcg: Clarify thread safety check in tb_add_jump()

2016-04-10 Thread Sergey Fedorov
From: Sergey Fedorov The check is to make sure that another thread hasn't already done the same while we were outside of tb_lock. Mention this in a comment. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov ---

[Qemu-devel] [PATCH v3 02/10] tcg: Use uintptr_t type for jmp_list_{next|first} fields of TB

2016-04-10 Thread Sergey Fedorov
From: Sergey Fedorov These fields do not contain pure pointers to a TranslationBlock structure. So uintptr_t is the most appropriate type for them. Also put an assert to assure that the two least significant bits of the pointer are zero before assigning it to

[Qemu-devel] [PATCH v3 01/10] tcg: Clean up direct block chaining data fields

2016-04-10 Thread Sergey Fedorov
From: Sergey Fedorov Briefly describe in a comment how direct block chaining is done. It should help in understanding of the following data fields. Rename some fields in TranslationBlock and TCGContext structures to better reflect their purpose (dropping excessive 'tb_'

[Qemu-devel] [Bug 1568589] Re: Compile for os x host failed

2016-04-10 Thread iQQator
fix: http://patchwork.ozlabs.org/patch/603499/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1568589 Title: Compile for os x host failed Status in QEMU: New Bug description: Hello QEMU, I

[Qemu-devel] [Bug 1568589] Re: Compile for os x host failed

2016-04-10 Thread iQQator
Also for i386 LINK i386-softmmu/qemu-system-i386 Undefined symbols for architecture x86_64: "_event_notifier_init_fd", referenced from: _process_msg in ivshmem.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see

[Qemu-devel] [Bug 1568589] Re: Compile for os x host failed

2016-04-10 Thread iQQator
Host: # uname -a Darwin MacBook-Pro 15.4.0 Darwin Kernel Version 15.4.0: Fri Feb 26 22:08:05 PST 2016; root:xnu-3248.40.184~3/RELEASE_X86_64 x86_64 # ./configure Configure: http://pastebin.com/L9ytLFDE # make -v GNU Make 3.81 Copyright (C) 2006 Free Software Foundation, Inc. This is free

[Qemu-devel] [Bug 1568589] [NEW] Compile for os x host failed

2016-04-10 Thread iQQator
Public bug reported: Hello QEMU, I try compile qemu from git pulled by me today and have a troubles: GEN trace/generated-helpers.c CCaarch64-softmmu/trace/generated-helpers.o LINK aarch64-softmmu/qemu-system-aarch64 Undefined symbols for architecture x86_64:

Re: [Qemu-devel] configure qemu and compile it on windows

2016-04-10 Thread Marwa Hamza
and how can i add a package to cygwin after the installation ? there is any command line ? , i didn't find a way to add the python package so i downloaded from internet like the traditional way , then an other error msg dispalyed ERROR: "cc" either does not exist or does not work so i add this

Re: [Qemu-devel] [PATCH v2] migration: skip sending ram pages released by virtio-balloon driver.

2016-04-10 Thread Michael S. Tsirkin
On Fri, Apr 01, 2016 at 04:38:28PM +0530, Jitendra Kolhe wrote: > On 3/29/2016 5:58 PM, Michael S. Tsirkin wrote: > > On Mon, Mar 28, 2016 at 09:46:05AM +0530, Jitendra Kolhe wrote: > >> While measuring live migration performance for qemu/kvm guest, it > >> was observed that the qemu doesn’t

Re: [Qemu-devel] [PATCH v4 00/16] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-04-10 Thread Dmitry Fleytman
> On 10 Apr 2016, at 18:35, Michael S. Tsirkin wrote: > >> On Sun, Apr 10, 2016 at 06:14:49PM +0300, Dmitry Fleytman wrote: >> From: Dmitry Fleytman >> >> Hello All, >> >> This is v4 of e1000e series. >> >> For convenience, the same

Re: [Qemu-devel] [PATCH v4 00/16] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-04-10 Thread Michael S. Tsirkin
On Sun, Apr 10, 2016 at 06:14:49PM +0300, Dmitry Fleytman wrote: > From: Dmitry Fleytman > > Hello All, > > This is v4 of e1000e series. > > For convenience, the same patches are available at: > https://github.com/daynix/qemu-e1000e/tree/e1000e-submit-v4 >

Re: [Qemu-devel] [ RFC Patch v4 1/3] virtio-net rsc: add a new host offload(rsc) feature bit

2016-04-10 Thread Wei Xu
On 2016年04月05日 16:17, Michael S. Tsirkin wrote: On Tue, Apr 05, 2016 at 10:05:17AM +0800, Jason Wang wrote: On 04/04/2016 03:25 AM, w...@redhat.com wrote: From: Wei Xu A new feature bit 'VIRTIO_NET_F_GUEST_RSC' is introduced to support WHQL Receive-Segment-Offload test,

[Qemu-devel] [PATCH v4 11/16] net_pkt: Extend packet abstraction as required by e1000e functionality

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman This patch extends the TX/RX packet abstractions with features that will be used by the e1000e device implementation. Changes are: 1. Support iovec lists for RX buffers 2. Deeper RX packets parsing 3. Loopback option for TX

[Qemu-devel] [PATCH v4 09/16] net_pkt: Name vmxnet3 packet abstractions more generic

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman This patch drops "vmx" prefix from packet abstrations names to emphasize the fact they are generic and not tied to any specific network device. These abstrations will be reused by e1000e emulation implementation introduced by following

[Qemu-devel] [PATCH v4 12/16] vmxnet3: Use pci_dma_* API instead of cpu_physical_memory_*

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman To make this device and network packets abstractions ready for IOMMU. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/net_tx_pkt.c | 16

[Qemu-devel] [PATCH v4 10/16] rtl8139: Move more TCP definitions to common header

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/rtl8139.c | 5 - include/net/eth.h | 8 2 files changed, 8 insertions(+), 5

[Qemu-devel] [PATCH v4 13/16] e1000_regs: Add definitions for Intel 82574-specific bits

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/e1000_regs.h | 345 +++- 1 file changed, 342

[Qemu-devel] [PATCH v4 07/16] net: Add macros for MAC address tracing

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman These macros will be used by future commits introducing e1000e device emulation and by vmxnet3 tracing code. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch

[Qemu-devel] [PATCH v4 08/16] vmxnet3: Use common MAC address tracing macros

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/vmxnet3.c | 8 hw/net/vmxnet_debug.h | 3 --- 2 files changed, 4 insertions(+), 7

[Qemu-devel] [PATCH v4 04/16] pcie: Introduce function for DSN capability creation

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/pcie.c | 10 ++ include/hw/pci/pcie.h | 1 + 2 files changed, 11 insertions(+)

[Qemu-devel] [PATCH v4 16/16] e1000e: Introduce qtest for e1000e device

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- tests/Makefile | 3 + tests/e1000e-test.c | 480

[Qemu-devel] [PATCH v4 03/16] pcie: Add support for PCIe CAP v1

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman Added support for PCIe CAP v1, while reusing some of the existing v2 infrastructure. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/pcie.c

[Qemu-devel] [PATCH v4 06/16] net: Introduce Toeplitz hash calculator

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- include/net/checksum.h | 45 + 1 file changed, 45

[Qemu-devel] [PATCH v4 00/16] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman Hello All, This is v4 of e1000e series. For convenience, the same patches are available at: https://github.com/daynix/qemu-e1000e/tree/e1000e-submit-v4 Best regards, Dmitry. Changes since v3: 1. Various code fixes as suggested by

[Qemu-devel] [PATCH v4 14/16] e1000: Move out code that will be reused in e1000e

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman Code that will be shared moved to a separate files. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- MAINTAINERS| 5 +

[Qemu-devel] [PATCH v4 05/16] vmxnet3: Use generic function for DSN capability definition

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/vmxnet3.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH v4 02/16] pci: Introduce define for PM capability version 1.1

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- include/hw/pci/pci_regs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Qemu-devel] [PATCH v4 01/16] msix: make msix_clr_pending() visible for clients

2016-04-10 Thread Dmitry Fleytman
From: Dmitry Fleytman This function will be used by e1000e device code. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/msix.c | 2 +- include/hw/pci/msix.h

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

2016-04-10 Thread Dmitry Fleytman
Hi Jason, See below... > On 7 Apr 2016, at 10:24 AM, Jason Wang wrote: […] > +Device properties: + ++-++-+ +| Propery name | Description| Type | Default |

Re: [Qemu-devel] configure qemu and compile it on windows

2016-04-10 Thread Marwa Hamza
thanks stefan for your answer , i just download cygwin , mingw64 and msys2 and packages u mentioned , all in c:/ , and i download qemu from source in c:/msys2/ , but when i run ./configure i got this error ERROR: Python not found. Use --python=/path/to/python [image: Images intégrées 1]

[Qemu-devel] [PATCH] [PATCH] [WIP] [RFC] Add initial 9pfs support for Windows hosts

2016-04-10 Thread Michael Fritscher
It was tested on Windows & Linux hosts, on the later no obvious regressions could be found. The guest was a Knoppix 7.6.0 live cd. This is WIP and a RFC - it isn't meant to be upstreamed yet. The error_printf are only for debugging and will be deleted in the final patch. There are some

[Qemu-devel] [PATCH] [PATCH] [WIP] [RFC] [RESEND] Add initial 9pfs support for Windows hosts

2016-04-10 Thread Michael Fritscher
It was tested on Windows & Linux hosts, on the later no obvious regressions could be found. The guest was a Knoppix 7.6.0 live cd. This is WIP and a RFC - it isn't meant to be upstreamed yet. The error_printf are only for debugging and will be deleted in the final patch. There are some

[Qemu-devel] [PATCHv8] Improve documentation for TLS

2016-04-10 Thread Alex Bligh
* Call out TLS into a separate section * Add details of the TLS protocol itself * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can be initiated from either side (as required by the TLS standard I believe and as actually works in practice) * Clarify what is a

Re: [Qemu-devel] configure qemu and compile it on windows

2016-04-10 Thread Stefan Weil
Am 10.04.2016 um 11:27 schrieb Marwa Hamza: > hello > i'm trying to configure qemu on windows so i'm using MinGW and msys > every time i run the script configure (./configure) an error message > show about missing packages , i fixed those errors i installed > pkg-config , zlib packages but the

Re: [Qemu-devel] [PATCH v4 5/5] Add param Error ** for msi_init()

2016-04-10 Thread Cao jin
On 04/10/2016 04:20 PM, Marcel Apfelbaum wrote: Hi, I'll let Markus to continue the review, it brings very valuable information, I will only try to answer the questions below. Several questions on this topic: 1. How to confirm whether a device model has non-MSI variant? AFAICT, it is these

[Qemu-devel] configure qemu and compile it on windows

2016-04-10 Thread Marwa Hamza
hello i'm trying to configure qemu on windows so i'm using MinGW and msys every time i run the script configure (./configure) an error message show about missing packages , i fixed those errors i installed pkg-config , zlib packages but the last error i couldn't fix it ERROR: glib-2.12

Re: [Qemu-devel] [PATCHv6] Improve documentation for TLS

2016-04-10 Thread Alex Bligh
Eric, Thanks. In v7 I've taken all of these, save where indicated (or as described) below. >> +If the server receives `NBD_OPT_STARTTLS` it MUST reply with > > Worth mentioning 'prior to initiating TLS', since... > ...the behavior after initiating TLS is required to be different? As you point

[Qemu-devel] [PATCHv7] Improve documentation for TLS

2016-04-10 Thread Alex Bligh
* Call out TLS into a separate section * Add details of the TLS protocol itself * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can be initiated from either side (as required by the TLS standard I believe and as actually works in practice) * Clarify what is a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci: fix identation

2016-04-10 Thread Marcel Apfelbaum
On 03/28/2016 10:32 AM, Marcel Apfelbaum wrote: Signed-off-by: Marcel Apfelbaum Ping. Thanks, Marcel --- hw/pci/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index a1d41aa..da8b0b6 100644 --- a/hw/pci/pci.c

Re: [Qemu-devel] [PATCH] pci: fix compilation warnings

2016-04-10 Thread Marcel Apfelbaum
On 03/28/2016 10:23 AM, Marcel Apfelbaum wrote: Fix 'error: shift exponent -1 is negative' warning by adding a corresponding assert. Ping. Thanks, Marcel Reported-by: Peter Maydell Signed-off-by: Markus Armbruster Signed-off-by: Marcel

Re: [Qemu-devel] [PATCH v4 5/5] Add param Error ** for msi_init()

2016-04-10 Thread Marcel Apfelbaum
On 04/09/2016 03:19 PM, Cao jin wrote: Hi On 04/08/2016 04:44 PM, Markus Armbruster wrote: diff --git a/hw/ide/ich.c b/hw/ide/ich.c index 0a13334..db4fdb5 100644 --- a/hw/ide/ich.c +++ b/hw/ide/ich.c @@ -146,7 +146,7 @@ static void pci_ich9_ahci_realize(PCIDevice *dev, Error **errp) /*

Re: [Qemu-devel] [PATCH v4 4/5] mptsas: change .realize function name

2016-04-10 Thread Marcel Apfelbaum
On 04/05/2016 02:26 PM, Cao jin wrote: All the other devices` .realize function name are xxx_realize, except this one Signed-off-by: Cao jin CC: Paolo Bonzini --- hw/scsi/mptsas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH v4 2/5] change pvscsi_init_msi() type to void

2016-04-10 Thread Marcel Apfelbaum
On 04/05/2016 02:26 PM, Cao jin wrote: Nobody use its return value, so change the type to void Signed-off-by: Cao jin CC: Paolo Bonzini CC: Dmitry Fleytman --- hw/scsi/vmw_pvscsi.c | 4 +--- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH v4 3/5] megasas: bugfix

2016-04-10 Thread Marcel Apfelbaum
On 04/08/2016 10:16 AM, Markus Armbruster wrote: Please use a more descriptive title. Suggest "megasas: Fix Cao jin writes: msi_init returns non-zero value on both failure and success This is a sentence, should end with a period. Bug's impact? Here's my guess.

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-10 Thread Jevon Qiao
Hi Greg, Thank you for spending time reviewing this patch. On 7/4/16 23:50, Greg Kurz wrote: On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack users deploying