Re: [Qemu-devel] [V11 2/4] hw/i386: ACPI IVRS table

2016-05-23 Thread Peter Xu
On Sun, May 22, 2016 at 01:21:52PM +0300, David Kiarie wrote: [...] > +static void > +build_amd_iommu(GArray *table_data, GArray *linker) > +{ > +int iommu_start = table_data->len; > +bool iommu_ambig; > + > +/* IVRS definition - table header has an extra 2-byte field */ > +acpi_da

Re: [Qemu-devel] [V11 3/4] hw/core: provision for overriding emulated IOMMU

2016-05-23 Thread Peter Xu
On Sun, May 22, 2016 at 01:21:53PM +0300, David Kiarie wrote: [...] > static void machine_set_suppress_vmdesc(Object *obj, bool value, Error > **errp) > { > MachineState *ms = MACHINE(obj); > @@ -473,10 +492,14 @@ static void machine_initfn(Object *obj) >

Re: [Qemu-devel] [PATCH v2 03/28] linux-user: Reindent signal handling

2016-05-23 Thread Riku Voipio
On tiistaina 24. toukokuuta 2016 3.21.34 EEST, Laurent Vivier wrote: Le 12/05/2016 à 19:47, Peter Maydell a écrit : From: Timothy E Baldwin Some of the signal handling was a mess with a mixture of tabs and 8 space indents. And adds some braces, but not everywhere. [and fails on checkpatch.p

Re: [Qemu-devel] [PATCH v6 for-2.7 09/28] migration: add helpers for creating QEMUFile from a QIOChannel

2016-05-23 Thread Amit Shah
On (Wed) 04 May 2016 [13:02:52], Juan Quintela wrote: > "Daniel P. Berrange" wrote: > > Currently creating a QEMUFile instance from a QIOChannel is > > quite simple only requiring a single call to > > qemu_fopen_channel_input or qemu_fopen_channel_output > > depending on the end of migration conn

Re: [Qemu-devel] [PATCH] scsi: pvscsi: check command descriptor ring buffer size

2016-05-23 Thread P J P
+-- On Mon, 23 May 2016, Paolo Bonzini wrote --+ | Is there a CVE number? Yes, CVE-2016-4952: -> https://bugzilla.redhat.com/show_bug.cgi?id=1334384 Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

Re: [Qemu-devel] [PATCH 1/1] migration: fix ram decompression race deadlock

2016-05-23 Thread Denis V. Lunev
On 05/24/2016 05:07 AM, Li, Liang Z wrote: Adding Liang Li to CC for his comments as the author of the feature. On (Fri) 13 May 2016 [10:27:01], Denis V. Lunev wrote: From: Maxim Nestratov There is a race in between do_data_decompress and start_decompression. do_data_decompress() while

Re: [Qemu-devel] [PULL 00/20] Net patches

2016-05-23 Thread Jason Wang
On 2016年05月23日 19:09, Peter Maydell wrote: On 23 May 2016 at 03:13, Jason Wang wrote: The following changes since commit 65603e2fc18b48e6e55a3dd693669413141694ec: tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100) are available in the git repository at: https://github.co

Re: [Qemu-devel] [Qemu-stable] [PATCH v2 0/2] backup: Fail early if cannot determine cluster size

2016-05-23 Thread Fam Zheng
On Thu, 05/19 09:25, Fam Zheng wrote: > v2: More accurately, s:hang:trigger assertion failure: in the bug fix patch > commit message. > Add John's and Jeff's R-b. > Add a test. [Eric] Jeff, will you take this series in your tree? Fam

Re: [Qemu-devel] [PATCH v7] block: Move BlockRequest type to io.c

2016-05-23 Thread Fam Zheng
On Thu, 05/19 17:05, Eric Blake wrote: > I was thrown by the fact that the public type BlockRequest had > an anonymous union, but no obvious discriminator. Turns out > that the only client of the second branch of the union was code > internal to io.c, now that commit 91c6e4b killed public > multiw

Re: [Qemu-devel] [GSOC 2016] Student Introduction

2016-05-23 Thread haris iqbal
On Mon, May 23, 2016 at 9:51 PM, Amit Shah wrote: > Hi Haris, > > On (Sun) 22 May 2016 [18:54:04], haris iqbal wrote: >> Hello everyone.. My name is Md Haris Iqbal. I am one of the students >> who has been selected to work with Qemu as part of GSoC 2016. I'll be >> working on recovering a postcopy

Re: [Qemu-devel] [PATCH V2] block/iscsi: allow caching of the allocation map

2016-05-23 Thread Fam Zheng
On Fri, 05/20 12:10, Peter Lieven wrote: > until now the allocation map was used only as a hint if a cluster > is allocated or not. If a block was not allocated (or Qemu had > no info about the allocation status) a get_block_status call was > issued to check the allocation status and possibly avoid

[Qemu-devel] [PATCH v6 06/11] usb xhci: change msi/msix property type

2016-05-23 Thread Cao jin
>From bit to enum OnOffAuto cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/usb/hcd-xhci.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 43ba6

[Qemu-devel] [PATCH v6 05/11] mptsas: change .realize function name

2016-05-23 Thread Cao jin
All the other devices` .realize function name are xxx_realize, except this one. cc: Paolo Bonzini Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/mptsas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index 499c146

[Qemu-devel] [PATCH v6 04/11] megasas: Fix

2016-05-23 Thread Cao jin
msi_init returns non-zero value on both failure and success. cc: Hannes Reinecke cc: Paolo Bonzini cc: Marcel Apfelbaum Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/

[Qemu-devel] [PATCH v6 09/11] megasas: change msi/msix property type

2016-05-23 Thread Cao jin
>From bit to enum OnOffAuto. cc: Hannes Reinecke cc: Paolo Bonzini cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/megasas.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/scsi/megas

[Qemu-devel] [PATCH v6 10/11] pci bridge dev: change msi property type

2016-05-23 Thread Cao jin
>From bit to enum OnOffAuto. cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/pci-bridge/pci_bridge_dev.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridg

[Qemu-devel] [PATCH v6 11/11] pci: Convert msi_init() to Error and fix callers to check it

2016-05-23 Thread Cao jin
msi_init() reports errors with error_report(), which is wrong when it's used in realize(). Fix by converting it to Error. Fix its callers to handle failure instead of ignoring it. For those callers who don`t handle the failure, it might happen: when user want msi on, but he doesn`t get what he w

[Qemu-devel] [PATCH v6 00/11] Add param Error ** for msi_init()

2016-05-23 Thread Cao jin
v6 changelog: 1. make "assert ENOSPC" the 1st one in the series, and remove ENOSPC line of comments of msi_init(). also fix to other minor comments. 2. Because semantics changes, add hint message for devices who have msi/msix property, to help old machine user to know what should do 3. update

[Qemu-devel] [PATCH v6 07/11] intel-hda: change msi property type

2016-05-23 Thread Cao jin
>From uint32 to enum OnOffAuto. cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/audio/intel-hda.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index d3

[Qemu-devel] [PATCH v6 08/11] mptsas: change msi property type

2016-05-23 Thread Cao jin
>From uint32 to enum OnOffAuto, and give it a shorter name. cc: Paolo Bonzini cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/mptsas.c | 4 ++-- hw/scsi/mptsas.h | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/s

[Qemu-devel] [PATCH v6 02/11] fix some coding style problems

2016-05-23 Thread Cao jin
It has: 1. More newlines make the code block well separated. 2. Add more comments for msi_init. 3. Fix a indentation in vmxnet3.c. 4. ioh3420 & xio3130_downstream: put PCI Express capability init function together, make it more readable. cc: Dmitry Fleytman cc: Jason Wang cc: Michael S. Tsirk

[Qemu-devel] [PATCH v6 01/11] pci core: assert ENOSPC when add capability

2016-05-23 Thread Cao jin
ENOSPC is programming error, assert it for debugging. cc: Michael S. Tsirkin cc: Marcel Apfelbaum cc: Markus Armbruster Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/pci/pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c

[Qemu-devel] [PATCH v6 03/11] change pvscsi_init_msi() type to void

2016-05-23 Thread Cao jin
Nobody use its return value, so change the type to void. cc: Paolo Bonzini cc: Markus Armbruster cc: Marcel Apfelbaum Acked-by: Dmitry Fleytman Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/vmw_pvscsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 5/7] scsi-disk: add need_fua_emulation to SCSIDiskClass

2016-05-23 Thread Fam Zheng
On Mon, 05/23 14:54, Paolo Bonzini wrote: > scsi-block will be able to do FUA just by passing the request through > to the LUN (which is also more efficient); there is no need to emulate > it like we do for scsi-disk. Even for scsi-disk, shall we just use the block layer FUA fallback already by pa

Re: [Qemu-devel] [PATCH 2/7] dma-helpers: change BlockBackend to opaque value in DMAIOFunc

2016-05-23 Thread Fam Zheng
On Mon, 05/23 14:54, Paolo Bonzini wrote: > Callers of dma_blk_io have no way to pass extra data to the DMAIOFunc, > because the original callback and opaque are gone by the time DMAIOFunc > is called. On the other hand, the BlockBackend is usually derived > from those extra data that you could pa

Re: [Qemu-devel] [GSoC 2016] Introduction

2016-05-23 Thread Fam Zheng
On Mon, 05/23 18:33, Reda Sallahi wrote: > It will be an exciting summer and hopefully it will only be the > beginning of my involvement on QEMU. Welcome to the community, Reda! Fam

Re: [Qemu-devel] [PULL 0/1] rng: rename RndRandom to RngRandom

2016-05-23 Thread Amit Shah
On (Mon) 23 May 2016 [17:36:13], Peter Maydell wrote: > On 23 May 2016 at 16:50, Amit Shah wrote: > > The following changes since commit 65603e2fc18b48e6e55a3dd693669413141694ec: > > > > tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100) > > > > are available in the git repository a

Re: [Qemu-devel] [PATCH v4 7/8] Add ENET/Gbps Ethernet support to FEC device

2016-05-23 Thread Jason Wang
On 2016年05月21日 05:23, Jean-Christophe DUBOIS wrote: Le 20/05/2016 04:34, Jason Wang a écrit : On 2016年05月20日 02:14, Jean-Christophe DUBOIS wrote: Le 19/05/2016 05:48, Jason Wang a écrit : On 2016年05月19日 06:23, Jean-Christophe Dubois wrote: The ENET device (present in i.MX6) is "derived"

Re: [Qemu-devel] coroutines: block: Co-routine re-entered recursively when migrating disk with iothreads

2016-05-23 Thread Fam Zheng
On Mon, 05/23 14:54, Jason J. Herne wrote: > Using libvirt to migrate a guest and one guest disk that is using iothreads > causes Qemu to crash with the message: > Co-routine re-entered recursively > > I've looked into this one a bit but I have not seen anything that > immediately stands out. > He

Re: [Qemu-devel] [PATCH 1/1] migration: fix ram decompression race deadlock

2016-05-23 Thread Li, Liang Z
> Adding Liang Li to CC for his comments as the author of the feature. > > On (Fri) 13 May 2016 [10:27:01], Denis V. Lunev wrote: > > From: Maxim Nestratov > > > > There is a race in between do_data_decompress and start_decompression. > > > > do_data_decompress() > > while (!quit_decomp_threa

Re: [Qemu-devel] [PATCH] docs/multi-thread-compression: Fix wrong command string

2016-05-23 Thread Li, Liang Z
> Subject: [Qemu-devel][PATCH] docs/multi-thread-compression: Fix wrong > command string > > s/info_migrate_capabilities/info migrate_capabilities > > Signed-off-by: Wei Jiangang > --- > docs/multi-thread-compression.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [Qemu-devel] [PATCH v3] block: Fix bdrv_next() memory leak

2016-05-23 Thread Fam Zheng
On Fri, 05/20 19:17, Kevin Wolf wrote: > The bdrv_next() users all leaked the BdrvNextIterator after completing > the iteration. Simply changing bdrv_next() to free the iterator before > returning NULL at the end of list doesn't work because some callers exit > the loop before looking at all BDSes.

Re: [Qemu-devel] [PATCH 0/4] block: BdrvChildRole.drained_begin/end fixes

2016-05-23 Thread Fam Zheng
On Mon, 05/23 18:55, Kevin Wolf wrote: > While working on the series that converts block jobs to using a separate > BlockBackend, I noticed that I need to do some drain fixes first. So here they > are. > > Patches 1 and 2 are just preparation, patches 3 and 4 are the actual fixes. > > Kevin Wolf

Re: [Qemu-devel] [PATCH v2 05/28] linux-user: Renumber TARGET_QEMU_ESIGRETURN, make it not arch-specific

2016-05-23 Thread Laurent Vivier
Le 12/05/2016 à 19:47, Peter Maydell a écrit : > From: Timothy E Baldwin > > Currently we define a QEMU-internal errno TARGET_QEMU_ESIGRETURN > only on the MIPS and PPC targets; move this to errno_defs.h > so it is available for all architectures, and renumber it to 513. > We pick 513 because t

Re: [Qemu-devel] [PATCH] tests: avoid coroutine pool test crash

2016-05-23 Thread Fam Zheng
On Fri, 05/20 11:00, Stefan Hajnoczi wrote: > Skip the test_co_queue test case if the coroutine pool is not enabled. > The test case does not work without the pool because it touches memory > belonging to a freed coroutine (on purpose). > > Reported-by: Eduardo Habkost > Signed-off-by: Stefan Haj

Re: [Qemu-devel] [PATCH v2 03/28] linux-user: Reindent signal handling

2016-05-23 Thread Laurent Vivier
Le 12/05/2016 à 19:47, Peter Maydell a écrit : > From: Timothy E Baldwin > > Some of the signal handling was a mess with a mixture of tabs and 8 space > indents. And adds some braces, but not everywhere. [and fails on checkpatch.pl] If we don't add braces everywhere, perhaps it's better to ad

Re: [Qemu-devel] [PATCH v2 02/28] linux-user: Consistently return host errnos from do_openat()

2016-05-23 Thread Laurent Vivier
Le 12/05/2016 à 19:47, Peter Maydell a écrit : > The function do_openat() is not consistent about whether it is > returning a host errno or a guest errno in case of failure. > Standardise on returning -1 with errno set (ie caller has > to call get_errno()). > > Signed-off-by: Peter Maydell > Re

Re: [Qemu-devel] [PATCH v2 01/28] linux-user: Check array bounds in errno conversion

2016-05-23 Thread Laurent Vivier
Le 12/05/2016 à 19:47, Peter Maydell a écrit : > From: Timothy E Baldwin > > Check array bounds in host_to_target_errno() and target_to_host_errno(). > > Signed-off-by: Timothy Edward Baldwin > Message-id: > 1441497448-32489-2-git-send-email-t.e.baldwi...@members.leeds.ac.uk > [PMM: Add a lo

Re: [Qemu-devel] [PULL 00/15] X86 queue, 2016-05-23

2016-05-23 Thread Eduardo Habkost
x86-pull-request tag was updated to fix a typo in commit message of patch 06/15. The following changes since commit c9158547617584bb9d19db7fb139998fbef80133: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-05-23 16:15:52 +0100) are available in the git repo

Re: [Qemu-devel] [PULL 06/15] target-i386: Set constant model_id for qemu63/qemu32/athlon

2016-05-23 Thread Eduardo Habkost
On Mon, May 23, 2016 at 10:49:13PM +0200, Andreas Färber wrote: > qemu64 Fixed, thanks. x86-pull-request tag updated: The following changes since commit c9158547617584bb9d19db7fb139998fbef80133: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-05-23 16:15:52

Re: [Qemu-devel] [PATCH v5 00/18] tb hash improvements

2016-05-23 Thread Sergey Fedorov
I think I'm done reviewing v5. (Though I haven't reviewed tests and statistics patches.) Kind regards, Sergey On 14/05/16 06:34, Emilio G. Cota wrote: > This patchset applies on top of tcg-next (8b1fe3f4 "cpu-exec: > Clean up 'interrupt_request' reloading", tagged "pull-tcg-20160512"). > > For re

Re: [Qemu-devel] [PATCH v7 08/25] x86-iommu: introduce parent class

2016-05-23 Thread Marcel Apfelbaum
On 05/23/2016 08:06 PM, David Kiarie wrote: On Tue, May 17, 2016 at 10:15 AM, Peter Xu wrote: Introducing parent class for intel-iommu devices named "x86-iommu". This is preparation work to abstract shared functionalities out from Intel and AMD IOMMUs. Currently, only the parent class is introd

Re: [Qemu-devel] [PATCH v6 0/3] Add a generic loader

2016-05-23 Thread Alistair Francis
On Fri, May 13, 2016 at 1:37 PM, Alistair Francis wrote: > This work is based on the original work by Li Guang with extra > features added by Peter C and myself. > > The idea of this loader is to allow the user to load multiple images > or values into QEMU at startup. > > Memory values can be load

Re: [Qemu-devel] [PATCH] vga: add sr_vbe register set

2016-05-23 Thread Thomas Lamprecht
Hi, sorry for the delay. On 20.05.2016 12:06, Gerd Hoffmann wrote: Hi, ./x86_64-softmmu/qemu-system-x86_64 -boot d -cdrom W7SP1_PROFESSIONAL.iso -m 1024 -smp 2 -enable-kvm -cpu host -drive if=pflash,format=raw,unit=0,readonly,file=OVMF_CODE-pure-efi.fd -drive if=pflash,format=raw,unit=1,fi

Re: [Qemu-devel] [PATCH 4/4] block: Propagate .drained_begin/end callbacks

2016-05-23 Thread Eric Blake
On 05/23/2016 10:55 AM, Kevin Wolf wrote: > When draining intermediate nodes (i.e. nodes that aren't the root node > for at least one of their parents; with node references, the user can > always configure the graph to create this situation), we need to > propagate the .drained_begin/end callbacks

Re: [Qemu-devel] [PATCH 3/4] block: Fix reconfiguring graph with drained nodes

2016-05-23 Thread Eric Blake
On 05/23/2016 10:55 AM, Kevin Wolf wrote: > When changing the BlockDriverState that a BdrvChild points to while the > node is currently drained, we must call the .drained_end() parent > callback. Conversely, when this means attaching a new node that is > already drained, we need to call .drained_be

Re: [Qemu-devel] [PATCH 2/4] block: Make bdrv_drain() use bdrv_drained_begin/end()

2016-05-23 Thread Eric Blake
On 05/23/2016 10:55 AM, Kevin Wolf wrote: > Until now, bdrv_drained_begin() used bdrv_drain() internally to drain > the queue. This is kind of backwards and caused quiescing code to be > duplicated because bdrv_drained_begin() had to ensure that no new > requests come in even after bdrv_drain() ret

Re: [Qemu-devel] [PULL 06/15] target-i386: Set constant model_id for qemu63/qemu32/athlon

2016-05-23 Thread Andreas Färber
qemu64 Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH v5 13/18] qht: support parallel writes

2016-05-23 Thread Sergey Fedorov
On 14/05/16 06:34, Emilio G. Cota wrote: > +/* > + * Get a head bucket and lock it, making sure its parent map is not stale. > + * @pmap is filled with a pointer to the bucket's parent map. > + * > + * Unlock with qemu_spin_unlock(&b->lock). > + */ > +static inline > +struct qht_bucket *qht_bucket_

[Qemu-devel] [ RFC Patch v5 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic

2016-05-23 Thread wexu
From: Wei Xu All the data packets in a tcp connection will be cached to a big buffer in every receive interval, and will be sent out via a timer, the 'virtio_net_rsc_timeout' controls the interval, the value will influent the performance and response of tcp connection extremely, 5(50us) is a

[Qemu-devel] [ RFC Patch v5 2/2] virtio-net rsc: support coalescing ipv6 tcp traffic

2016-05-23 Thread wexu
From: Wei Xu Most stuffs are like ipv4 2 differences between ipv4 and ipv6. 1. Fragment length in ipv4 header includes itself, while it's not included for ipv6, thus means ipv6 can carry a real '65535' payload. 2. IPv6 header does not need calculate header checksum. Signed-off-

[Qemu-devel] [ RFC Patch v5 0/2] Support Receive-Segment-Offload(RSC) for WHQL

2016-05-23 Thread wexu
From: Wei Xu Changes in V5: - Passed all IPv4/6 test cases - Add new fields in 'virtio_net_hdr' - Set 'gso_type' & 'coalesced packets' in new field. - Bypass all 'tcp option' packet - Bypass all 'pure ack' packet - Bypass all 'duplicate ack' packet - Change 'guest_rsc' feature bit to 'false' by d

[Qemu-devel] [Bug 1052857] Re: qemu-user compiled static for ppc fails on 64bit hosts

2016-05-23 Thread thh
As far as I can see, the fix has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=beb526b12134a6b674 ... so closing this ticket now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 1283519] Re: PowerPC altivec rounding instructions vrfi(m|n|z)not correctly mapped

2016-05-23 Thread thh
This problem should have been fixed by the following commit: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=abe60a439b760c749201 ... so closing this ticket now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml

Re: [Qemu-devel] [PATCH 1/4] block: Introduce bdrv_replace_child()

2016-05-23 Thread Eric Blake
On 05/23/2016 10:55 AM, Kevin Wolf wrote: > This adds a common function that is called when attaching a new child to > a parent, removing a child from a parent and when reconfiguring the > graph so that an existing child points to a different node now. > > Signed-off-by: Kevin Wolf > --- > block

[Qemu-devel] [Bug 788697] Re: [PowerPC] [patch] mtmsr does not preserve high bits of MSR

2016-05-23 Thread thh
As far as I can see, the issue has been fixed here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=8018dc63aab936f1a5 ... so closing this ticket now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH 7/7] scsi-block: always use SG_IO

2016-05-23 Thread Eric Blake
On 05/23/2016 06:54 AM, Paolo Bonzini wrote: > Using pread/pwrite or io_submit has the advantage of eliminating the > bounce buffer, but drops the SCSI status. This keeps the guest from > seeing unit attention codes, as well as statuses such as RESERVATION > CONFLICT. Because we know scsi-block o

Re: [Qemu-devel] [PATCH v2 0/7] dma-helpers, scsi-block: use SG_IO for all I/O on scsi-block

2016-05-23 Thread Mark Cave-Ayland
On 23/05/16 13:54, Paolo Bonzini wrote: > scsi-block uses the block layer for reads and writes in order to avoid > allocating bounce buffers as big as the transferred data. We know how > to split a large transfer to multiple reads and writes, and thus we can > use scsi-disk.c's existing code to d

Re: [Qemu-devel] [PATCH v5 5/6] acpi: Add IPMI table entries

2016-05-23 Thread Corey Minyard
On 05/23/2016 01:06 PM, Paolo Bonzini wrote: On 20/05/2016 11:53, Igor Mammedov wrote: diff --git a/hw/acpi/noipmi.c b/hw/acpi/noipmi.c new file mode 100644 index 000..dd7590d --- /dev/null +++ b/hw/acpi/noipmi.c move this to .a/stubs/ Don't overuse stubs. The stubs library is mostly to

[Qemu-devel] [PULL 14/15] target-i386: kvm: Simplify MSR setting functions

2016-05-23 Thread Eduardo Habkost
Simplify kvm_put_tscdeadline_msr() and kvm_put_msr_feature_control() using kvm_msr_buf and the kvm_msr_entry_add() helper. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --g

[Qemu-devel] [PULL 12/15] target-i386: kvm: Increase MSR_BUF_SIZE

2016-05-23 Thread Eduardo Habkost
We are dangerously close to the array limits in kvm_put_msrs() and kvm_get_msrs(): with the default mcg_cap configuration, we can set up to 148 MSRs in kvm_put_msrs(), and if we allow mcg_cap to be changed, we can write up to 236 MSRs. Use 4096 bytes for the buffer, that can hold 255 kvm_msr_entry

[Qemu-devel] [PULL 11/15] target-i386: kvm: Allocate kvm_msrs struct once per VCPU

2016-05-23 Thread Eduardo Habkost
Instead of using 2400 bytes in the stack for 150 MSR entries in kvm_get_msrs() and kvm_put_msrs(), allocate a buffer once for each VCPU. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- target-i386/cpu.h | 4 target-i386/kvm.c | 37 +++-- 2 fil

[Qemu-devel] [PULL 10/15] target-i386: Call cpu_exec_init() on realize

2016-05-23 Thread Eduardo Habkost
QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Calling cpu_exec_init() also affects QEMU's ability to handle errors during CPU creation, as some actions done by

[Qemu-devel] [PULL 06/15] target-i386: Set constant model_id for qemu63/qemu32/athlon

2016-05-23 Thread Eduardo Habkost
Newer PC machines don't set hw_version, and older machines set model-id on compat_props explicitly, so we don't need the x86_cpudef_setup() code that sets model_id using qemu_hw_version() anymore. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 23 +++ 1 file changed,

[Qemu-devel] [PULL 15/15] target-i386: kvm: Eliminate kvm_msr_entry_set()

2016-05-23 Thread Eduardo Habkost
Inline the function inside kvm_msr_entry_add(). Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 0b56b38..7b3667a 100644 --- a/target-i386/

[Qemu-devel] [PULL 05/15] pc: Set CPU model-id on compat_props for pc <= 2.4

2016-05-23 Thread Eduardo Habkost
Instead of relying on x86_cpudef_setup() calling qemu_hw_version(), just make old machines set model-id explicitly on compat_props for qemu64, qemu32, and athlon. This will allow us to eliminate x86_cpudef_setup() later. Reviewed-by: Michael S. Tsirkin Signed-off-by: Eduardo Habkost --- hw/i386

[Qemu-devel] [PULL 07/15] cpu: Eliminate cpudef_init(), cpudef_setup()

2016-05-23 Thread Eduardo Habkost
x86_cpudef_init() doesn't do anything anymore, cpudef_init(), cpudef_setup(), and x86_cpudef_init() can be finally removed. Signed-off-by: Eduardo Habkost --- arch_init.c| 7 --- bsd-user/main.c| 3 --- include/sysemu/arch_init.h | 1 - linux-user/main.c

[Qemu-devel] [PULL 13/15] target-i386: kvm: Simplify MSR array construction

2016-05-23 Thread Eduardo Habkost
Add a helper function that appends new entries to the MSR buffer and checks for the buffer size limit. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 291 ++ 1 file changed, 140 insertions(+), 151 deletions(-

Re: [Qemu-devel] [PATCH v5 12/18] qht: QEMU's fast, resizable and scalable Hash Table

2016-05-23 Thread Sergey Fedorov
On 21/05/16 05:48, Emilio G. Cota wrote: > On Sat, May 21, 2016 at 01:13:20 +0300, Sergey Fedorov wrote: >> Although the API is mostly intuitive some kernel-doc-style comments >> wouldn’t hurt, I think. ;-) > The nit that bothered me is the "external lock needed" bit, but it's > removed by the subs

[Qemu-devel] [PULL 03/15] target-i386: kvm: Use X86XSaveArea struct for xsave save/load

2016-05-23 Thread Eduardo Habkost
Instead of using offset macros and bit operations in a uint32_t array, use the X86XSaveArea struct to perform the loading/saving operations in kvm_put_xsave() and kvm_get_xsave(). Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 78 +++ 1

[Qemu-devel] [PULL 01/15] target-i386: Define structs for layout of xsave area

2016-05-23 Thread Eduardo Habkost
Add structs that define the layout of the xsave areas used by Intel processors. Add some QEMU_BUILD_BUG_ON lines to ensure the structs match the XSAVE_* macros in target-i386/kvm.c and the offsets and sizes at target-i386/cpu.c:ext_save_areas. Signed-off-by: Eduardo Habkost --- target-i386/cpu.h

[Qemu-devel] [PULL 09/15] target-i386: Move TCG initialization to realize time

2016-05-23 Thread Eduardo Habkost
QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Move TCG initialization to realize time so it won't be called when just doing object_new() on a X86CPU subclass.

[Qemu-devel] [PULL 04/15] osdep: Move default qemu_hw_version() value to a macro

2016-05-23 Thread Eduardo Habkost
The macro will be used by code that will stop calling qemu_hw_version() at runtime and just need a constant value. Signed-off-by: Eduardo Habkost --- include/qemu/osdep.h | 9 + util/osdep.c | 9 + 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/include/qe

[Qemu-devel] [PULL 08/15] target-i386: Move TCG initialization check to tcg_x86_init()

2016-05-23 Thread Eduardo Habkost
Instead of requiring cpu.c to check if TCG was already initialized, simply let the function be called multiple times. Suggested-by: Igor Mammedov Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 +--- target-i386/translate.c | 6 ++ 2 files changed,

[Qemu-devel] [PULL 00/15] X86 queue, 2016-05-23

2016-05-23 Thread Eduardo Habkost
The following changes since commit c9158547617584bb9d19db7fb139998fbef80133: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-05-23 16:15:52 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/x86-pull-request for you to

[Qemu-devel] [PULL 02/15] target-i386: Use xsave structs for ext_save_area

2016-05-23 Thread Eduardo Habkost
This doesn't introduce any change in the code, as the offsets and struct sizes match what was present in the table. This can be validated by the QEMU_BUILD_BUG_ON lines on target-i386/cpu.h, which ensures the struct sizes and offsets match the existing values in ext_save_area. Signed-off-by: Eduar

[Qemu-devel] [PULL 0/2] hw/net/opencores_eth cleanups

2016-05-23 Thread Max Filippov
ble in the git repository at: git://github.com/OSLL/qemu-xtensa.git tags/20160523-opencores_eth for you to fetch changes up to ea4d824168ce2a309ccf26fa20c6e4f9e3d47c82: hw/net/opencores_eth: Allocating Large sized arrays to heap (2016-05-23 22:1

Re: [Qemu-devel] [PATCH 6/7] scsi-disk: introduce scsi_disk_req_check_error

2016-05-23 Thread Eric Blake
On 05/23/2016 06:54 AM, Paolo Bonzini wrote: > Commonize all the checks for canceled requests and errors. The next patch > will add another case to check for, in order to handle passthrough commands. > > There is no semantic change here; the only nontrivial modification is in > scsi_write_do_fua,

Re: [Qemu-devel] [PATCH v2 00/28] linux-user: fix race between signals and syscalls

2016-05-23 Thread Peter Maydell
Ping? I have a second series based on top of this which is shaping up nicely and it would be good to get this lot into master before posting the second set... thanks -- PMM On 12 May 2016 at 18:47, Peter Maydell wrote: > This patch series is an updated version of the original series > sent by T

[Qemu-devel] coroutines: block: Co-routine re-entered recursively when migrating disk with iothreads

2016-05-23 Thread Jason J. Herne
Using libvirt to migrate a guest and one guest disk that is using iothreads causes Qemu to crash with the message: Co-routine re-entered recursively I've looked into this one a bit but I have not seen anything that immediately stands out. Here is what I have found: In qemu_coroutine_enter:

[Qemu-devel] [PATCH v9] Add optionrom compatible with fw_cfg DMA version

2016-05-23 Thread Richard W.M. Jones
From: Marc Marí This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí Signed-off-by: Richard W.M. Jones --- .gitignore| 4 + Makefile | 2 +- configure | 20 +++ hw/i386/pc.c | 10 +-

[Qemu-devel] [PATCH v9] Add optionrom compatible with fw_cfg DMA version

2016-05-23 Thread Richard W.M. Jones
v8 -> v9: - Add a workaround for GCC < 4.9. - Add linuxbios_dma.bin to Makefile. - Change Marc Mari's email address to new one. - Tested on RHEL 7.2 (gcc-4.8.5-4.el7.x86_64). Rich.

Re: [Qemu-devel] [PATCH v5 5/6] acpi: Add IPMI table entries

2016-05-23 Thread Paolo Bonzini
On 20/05/2016 11:53, Igor Mammedov wrote: >> > diff --git a/hw/acpi/noipmi.c b/hw/acpi/noipmi.c >> > new file mode 100644 >> > index 000..dd7590d >> > --- /dev/null >> > +++ b/hw/acpi/noipmi.c > move this to .a/stubs/ > Don't overuse stubs. The stubs library is mostly to share code between

[Qemu-devel] [PATCH v6 2/6] pc: Postpone SMBIOS table installation to post machine init

2016-05-23 Thread minyard
From: Corey Minyard This is the same place that the ACPI SSDT table gets added, so that devices can add themselves to the SMBIOS table. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 99437

Re: [Qemu-devel] [PATCH v3 3/3] IOMMU: Integrate between VFIO and vIOMMU to support device assignment

2016-05-23 Thread Alex Williamson
On Sat, 21 May 2016 19:19:50 +0300 "Aviv B.D" wrote: > From: "Aviv Ben-David" > Some commentary about the changes necessary to achieve $SUBJECT would be nice here. > Signed-off-by: Aviv Ben-David > --- > hw/i386/intel_iommu.c | 69 > -- > hw

[Qemu-devel] [PATCH v6 4/6] ipmi: Add SMBIOS table entry

2016-05-23 Thread minyard
From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin --- Makefile.objs | 2 +- hw/Makefile.objs | 2 + hw/smbios/Makefile.objs| 1 + hw/smbios/smbios.c | 2 + hw/smbios/smbios_type_38.c

[Qemu-devel] [PATCH v6 3/6] smbios: Move table build tools into an include file.

2016-05-23 Thread minyard
From: Corey Minyard This will let things in other files (like IPMI) build SMBIOS tables. Signed-off-by: Corey Minyard --- hw/smbios/smbios.c | 70 --- hw/smbios/smbios_build.h | 77 2 files changed,

[Qemu-devel] [PATCH v6 1/6] ipmi: rework the fwinfo to be fetched from the interface

2016-05-23 Thread minyard
From: Corey Minyard Instead of scanning IPMI devices from a fwinfo list, allow the fwinfo to be fetched from the IPMI interface class. Then the code looking for IPMI fwinfo can scan devices on a bus and look for ones that implement the IPMI class. This will let the ACPI scope be defined by the c

[Qemu-devel] [PATCH v6 0/6] Add IPMI to firmware tables

2016-05-23 Thread minyard
This patch has changes to address all comments. The isa_bus is no longer stored, it is searched for. Methods entries are changed to named constants for the _SRV and _IFT entries in the IPMI table. Minor function renames to make the names more consistent. Switched to using stubs for when ACPI is

[Qemu-devel] [PATCH v6 5/6] acpi: Add IPMI table entries

2016-05-23 Thread minyard
From: Corey Minyard Use the new ACPI table construction tools to create an ACPI entry for IPMI. This adds a function called from build_dsdt to add an DSDT entry for IPMI if IPMI is compiled in and has registered firmware. It also adds a dummy function if IPMI is not compiled in. This conforms

[Qemu-devel] [PATCH v6 6/6] bios: Add tests for the IPMI ACPI and SMBIOS entries

2016-05-23 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard --- tests/acpi-test-data/pc/DSDT.ipmikcs | Bin 0 -> 5659 bytes tests/acpi-test-data/q35/DSDT.ipmibt | Bin 0 -> 8432 bytes tests/bios-tables-test.c | 60 --- 3 files changed, 56 insertions(+), 4 delet

[Qemu-devel] [PULL 4/5] savevm: fail if migration blockers are present

2016-05-23 Thread Amit Shah
From: Greg Kurz QEMU has currently two ways to prevent migration to occur: - migration blocker when it depends on runtime state - VMStateDescription.unmigratable when migration is not supported at all This patch gathers all the logic into a single function to be called from both the savevm and t

[Qemu-devel] [Bug 1581308] Re: ohci doesn't check the 'num-ports' property

2016-05-23 Thread thh
The fix has been included in the repository: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=d400fc018b326104d26 Thanks for reporting the issue! ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subs

[Qemu-devel] [PULL 3/5] migration: Promote improved autoconverge commands out of experimental state

2016-05-23 Thread Amit Shah
From: "Jason J. Herne" The new autoconverge throttling commands have been tested for a release now. It is time to move them out of the experimental state. Signed-off-by: Jason J. Herne Message-Id: <1461262038-8197-1-git-send-email-jjhe...@linux.vnet.ibm.com> Signed-off-by: Amit Shah --- hmp.c

[Qemu-devel] [PULL 5/5] migration: regain control of images when migration fails to complete

2016-05-23 Thread Amit Shah
From: Greg Kurz We currently have an error path during migration that can cause the source QEMU to abort: migration_thread() migration_completion() runstate_is_running() > true if guest is running bdrv_inactivate_all() > inactivate images qemu_savevm

[Qemu-devel] [PULL 2/5] migration/qjson: Drop gratuitous use of QOM

2016-05-23 Thread Amit Shah
From: Markus Armbruster All the use of QOM buys us here is the ability to destroy the thing with object_unref(OBJECT(vmdesc)). Not worth the notational overhead. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Dr. David Alan Gilbert Message-Id: <1462380558-2030-3-git-se

[Qemu-devel] [PULL 1/5] migration: Move qjson.[ch] to migration/

2016-05-23 Thread Amit Shah
From: Markus Armbruster Type QJSON lets you build JSON text. Its interface mirrors (a subset of) abstract JSON syntax. QAPI output visitors also produce JSON text. They assert their preconditions and invariants, and therefore abort on incorrect use. Contrastingly, QJSON does *not* detect inco

[Qemu-devel] [PULL 0/5] migration fixes

2016-05-23 Thread Amit Shah
The following changes since commit 65603e2fc18b48e6e55a3dd693669413141694ec: tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/migration.git tags/migration-2.7-1 for you to fetch changes up

Re: [Qemu-devel] [PATCH 1/2] atomics: do not use __atomic primitives for RCU atomics

2016-05-23 Thread Emilio G. Cota
On Mon, May 23, 2016 at 09:53:00 -0700, Richard Henderson wrote: > On 05/21/2016 01:42 PM, Emilio G. Cota wrote: > >In the process, the atomic_rcu_read/set were converted to implement > >consume/release semantics, respectively. This is inefficient; for > >correctness and maximum performance we only

Re: [Qemu-devel] [PATCH] migration: introduce migrate_is_blocked()

2016-05-23 Thread Greg Kurz
On Mon, 23 May 2016 21:42:23 +0530 Amit Shah wrote: > On (Wed) 11 May 2016 [14:10:34], Greg Kurz wrote: > > On Wed, 11 May 2016 13:59:19 +0200 > > Paolo Bonzini wrote: > > > > > On 04/05/2016 21:44, Greg Kurz wrote: > > > > QEMU has currently two ways to prevent migration to occur: > > > >

  1   2   3   >