Re: [Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

2016-07-31 Thread Fam Zheng
On Mon, 08/01 10:53, Fam Zheng wrote: > This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to > drain IO requests), remove it. > > Suggested-by: Laszlo Ersek > Signed-off-by: Fam Zheng > --- Forgot to say, this applies on top of [Qemu-devel]

[Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF

2016-07-31 Thread Fam Zheng
Currently "make docker-test-mingw@fedora" has a warning like: /tmp/qemu-test/src/block/curl.c: In function 'curl_sock_cb': /tmp/qemu-test/src/block/curl.c:172:6: warning: format '%d' expects argument of type 'int', but argument 4 has type 'curl_socket_t {aka long long unsigned

Re: [Qemu-devel] [PATCH] ppc: Add MacOS VGA driver ROM

2016-07-31 Thread Jeff Cody
On Thu, Jul 28, 2016 at 10:44:31PM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2016-07-28 at 09:28 +0100, Stefan Hajnoczi wrote: > > > > Jeff, please create a mirror git repo for > > https://github.com/ozbenh/QemuMacDrivers at > > git://git.qemu-project.org/QemuMacDrivers.git with nightly

Re: [Qemu-devel] target-ppc: SPR_BOOKE_ESR not set on FP exceptions

2016-07-31 Thread David Gibson
On Fri, Jul 29, 2016 at 08:04:04AM -0500, alar...@ddci.com wrote: > David Gibson wrote on 07/29/2016 12:40:15 > AM: > > > From: David Gibson > > To: alar...@ddci.com > > Cc: qemu-devel@nongnu.org, qemu-...@nongnu.org, ag...@suse.de > >

[Qemu-devel] [PATCH] qemu-options.hx: correct spice options streaming-video default document value to 'off'

2016-07-31 Thread Li Zhijian
since f1d3e58, the code had changed the default value to 'off', so this patch make document and code are consistent. Signed-off-by: Li Zhijian --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx

Re: [Qemu-devel] [PATCH v3] ppc: Rename #include'd .c files to .inc.c

2016-07-31 Thread David Gibson
On Fri, Jul 29, 2016 at 06:35:17PM +1000, Benjamin Herrenschmidt wrote: > Also while at it, group the #include statements in translate.c > > Signed-off-by: Benjamin Herrenschmidt Urgh.. now I'm getting a: fatal: corrupt patch at line 35 > --- > > v3. Stupid typo

[Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

2016-07-31 Thread Fam Zheng
This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to drain IO requests), remove it. Suggested-by: Laszlo Ersek Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/block/virtio-blk.c

Re: [Qemu-devel] [PATCH] virtio-blk: Release s->rq queue at system_reset

2016-07-31 Thread Fam Zheng
On Fri, 07/29 12:41, Laszlo Ersek wrote: > So how about turning this patch into a two part series: the first patch > should drop the comment, and reference > 6e40b3bfc7e82823cf4df5f0bf668f56db41e53a, while the second patch should be > this patch? Good idea, I'm sending a separate patch to remove

Re: [Qemu-devel] ext4 error when testing virtio-scsi & vhost-scsi

2016-07-31 Thread Zhangfei Gao
Hi, Jan On Thu, Jul 28, 2016 at 9:29 AM, Zhangfei Gao wrote: > Hi, Jan > > On Wed, Jul 27, 2016 at 11:56 PM, Jan Kara wrote: >> Hi! >> >> On Wed 27-07-16 15:58:55, Zhangfei Gao wrote: >>> Hi, Michael >>> >>> I have met ext4 error when using vhost_scsi on

Re: [Qemu-devel] [PATCH v5 5/8] irq: Add a new irq device that allows the ORing of lines

2016-07-31 Thread Alistair Francis
On Tue, Jul 26, 2016 at 8:00 AM, Peter Maydell wrote: > On 26 July 2016 at 15:37, Alistair Francis wrote: >> Signed-off-by: Alistair Francis >> --- >> >> hw/core/irq.c| 44

Re: [Qemu-devel] [PATCH v2 2/2] vfio : add aer process

2016-07-31 Thread Zhou Jie
Hi, Alex On 2016/7/30 1:12, Alex Williamson wrote: On Tue, 19 Jul 2016 15:32:43 +0800 Zhou Jie wrote: From: Chen Fan During aer err occurs and resume do following to protect device from being accessed. 1. Make config space read

Re: [Qemu-devel] [PATCH v2 1/2] vfio : resume notifier

2016-07-31 Thread Zhou Jie
Hi, Alex On 2016/7/30 1:11, Alex Williamson wrote: On Tue, 19 Jul 2016 15:52:45 +0800 Zhou Jie wrote: From: Chen Fan An empty commit log is unacceptable for all but the most trivial patches. There's also no sign-off on this patch.

Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification

2016-07-31 Thread Gonglei (Arei)
Hi, Xin > From: virtio-...@lists.oasis-open.org [mailto:virtio-...@lists.oasis-open.org] > On Behalf Of Zeng, Xin > Sent: Sunday, July 31, 2016 9:27 PM > To: Gonglei (Arei); Michael S. Tsirkin > Cc: qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org; Ola Liljedahl; > Keating, Brian A;

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-07-31 Thread kwangwoo....@sk.com
Hi Peter, Thanks a lot for your comments! I answered in line below. > -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Saturday, July 30, 2016 3:10 AM > To: 이광우(LEE KWANGWOO) MS SW > Cc: Xiao Guangrong; Michael S. Tsirkin; Igor Mammedov; Paolo Bonzini;

Re: [Qemu-devel] [PATCH 1/6] palmetto-bmc: add a "silicon-rev" property at the soc level

2016-07-31 Thread Andrew Jeffery
On Sat, 2016-07-30 at 10:35 +0200, Cédric Le Goater wrote: > On 07/29/2016 03:16 AM, Andrew Jeffery wrote: > > > > On Thu, 2016-07-28 at 09:51 +0200, Cédric Le Goater wrote: > > > > > > On 07/28/2016 04:14 AM, Andrew Jeffery wrote: > > > > > > > > > > > > On Wed, 2016-07-27 at 18:46 +0200,

Re: [Qemu-devel] [Qemu-ppc] TCG and branches

2016-07-31 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > Benjamin Herrenschmidt writes: > >> Hi Richard ! >> >> So in my discovery of TCG, one thing I noticed is the horrendous amount >> of code generated for branches, especially conditional ones. >> > > static inline

Re: [Qemu-devel] [Qemu-ppc] TCG and branches

2016-07-31 Thread Nikunj A Dadhania
Benjamin Herrenschmidt writes: > Hi Richard ! > > So in my discovery of TCG, one thing I noticed is the horrendous amount > of code generated for branches, especially conditional ones. > static inline void gen_bcond(DisasContext *ctx, int type) { [...] if ((bo &

[Qemu-devel] (no subject)

2016-07-31 Thread Kumud Bhat
*Kumud Bhat* Department of Computer and Information science Purdue School of Science,IUPUI Indianapolis-IN, United States

[Qemu-devel] [PATCH for 2.8?] x86: ioapic: ignore level irq during processing

2016-07-31 Thread Peter Xu
For level triggered interrupts, we will get Remote IRR bit cleared after guest kernel finished processing specific request. Before that, we should ignore the same interrupt from triggering again. Signed-off-by: Peter Xu --- I discovered this during debugging some IR issues.

Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification

2016-07-31 Thread Zeng, Xin
On Friday, July 29, 2016 12:10 PM Gonglei (Arei) Wrote: > > I think version field is useful in some cases. > > Considering a case, if virtio crypto device implementation has defects, > > and a new version fixes this defect, how can the driver know whether the > > behavior of the device is

Re: [Qemu-devel] [PULL v5 26/57] x86-iommu: introduce IEC notifiers

2016-07-31 Thread Peter Xu
On Sun, Jul 31, 2016 at 02:01:26PM +0200, Jan Kiszka wrote: [...] > Yes, there has to be a generic handle for each translation result an > IOMMU generated. This handle can be stored on the consumer side along > with the translation request. How a handle is generated should be > completely up to

Re: [Qemu-devel] [PULL v5 26/57] x86-iommu: introduce IEC notifiers

2016-07-31 Thread Jan Kiszka
On 2016-07-31 05:59, Peter Xu wrote: > On Sat, Jul 30, 2016 at 09:52:48AM +0200, Jan Kiszka wrote: > > [...] > >>> +/** >>> + * x86_iommu_iec_notify_all - Notify IEC invalidations >>> + * @iommu: IOMMU device that sends the notification >>> + * @global: whether this is a global invalidation. If

Re: [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part)

2016-07-31 Thread Emil Condrea
Thanks Anthony for the feedback. I will send v10 containing fixes for patches 1 to 12 + additional patches for fixing code style issues for moved code. On Mon, Jul 25, 2016 at 5:09 PM, Anthony PERARD wrote: > On Sun, Jul 10, 2016 at 02:47:31PM +0300, Emil Condrea

Re: [Qemu-devel] [Xen-devel] [PATCH 04/19] xen: Move evtchn functions to xen_pvdev.c

2016-07-31 Thread Emil Condrea
On Mon, Jul 25, 2016 at 4:53 PM, Anthony PERARD wrote: > On Sun, Jul 10, 2016 at 02:47:35PM +0300, Emil Condrea wrote: > > The name of the functions moved: > > * xen_be_evtchn_event > > * xen_be_unbind_evtchn > > * xen_be_send_notify > > > > Signed-off-by: Emil