Re: [Qemu-devel] [PATCH 00/15] tcg field extract primitives

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/15] tcg field extract primitives Type: series Message-id: 1476589070-5792-1-git-send-email-...@twiddle.net === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH 13/15] target-mips: Use tcg_gen_extract_*

Use the new primitives for EXT and DEXT. Cc: Yongbok Kim Signed-off-by: Richard Henderson --- target-mips/translate.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c

[Qemu-devel] [PATCH 11/15] target-arm: Use tcg_gen_*extract

Use the new primitives for UBFX and SBFX. Cc: Peter Maydell Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 48 ++ target-arm/translate.c | 37 --- 2

[Qemu-devel] [PATCH 07/15] tcg/mips: Implement field extraction opcodes

Cc: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/mips/tcg-target.h | 2 +- tcg/mips/tcg-target.inc.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h index

[Qemu-devel] [PATCH 05/15] tcg/arm: Implement field extraction opcodes

Cc: Andrzej Zaborowski Cc: Peter Maydell Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.h | 4 ++-- tcg/arm/tcg-target.inc.c | 22 ++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 10/15] target-alpha: Use deposit and extract ops

Signed-off-by: Richard Henderson --- target-alpha/translate.c | 67 ++-- 1 file changed, 42 insertions(+), 25 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index af717ca..a341729 100644 ---

[Qemu-devel] [PATCH 04/15] tcg/arm: Move isa detection to tcg-target.h

Cc: Andrzej Zaborowski Cc: Peter Maydell Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.h | 36 tcg/arm/tcg-target.inc.c | 41 + 2 files

[Qemu-devel] [PATCH 09/15] tcg/s390: Implement field extraction opcodes

Cc: Alexander Graf Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.h | 12 +++- tcg/s390/tcg-target.inc.c | 13 - 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/tcg/s390/tcg-target.h b/tcg/s390/tcg-target.h index

[Qemu-devel] [PATCH 08/15] tcg/ppc: Implement field extraction opcodes

Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.h | 4 ++-- tcg/ppc/tcg-target.inc.c | 10 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/tcg/ppc/tcg-target.h b/tcg/ppc/tcg-target.h index c765d3e..b42c57a 100644 ---

[Qemu-devel] [PATCH 01/15] tcg: Add field extraction primitives

Adds tcg_gen_extract_* and tcg_gen_sextract_* for extraction of fixed position bitfields, much like we already have for deposit. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 4 + tcg/arm/tcg-target.h | 2 + tcg/i386/tcg-target.h| 4 +

[Qemu-devel] [PATCH 06/15] tcg/i386: Implement field extraction opcodes

Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 9 ++--- tcg/i386/tcg-target.inc.c | 30 ++ 2 files changed, 36 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h index 7625188..302ca96

[Qemu-devel] [PATCH 14/15] target-ppc: Use tcg_gen_extract_*

Use the new primitives for RDWINM and RLDICL. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- target-ppc/translate.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index bfc1301..724d95c

[Qemu-devel] [PATCH 02/15] tcg: Minor adjustments to deposit expanders

Assert that len is not 0. Since we have asserted that ofs + len <= N, a later check for len == N implies that ofs == 0. Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c

[Qemu-devel] [PATCH 15/15] target-s390: Use tcg_gen_extract_i64

Use the new primitive for RISBG. Cc: Alexander Graf Signed-off-by: Richard Henderson --- target-s390x/translate.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c

[Qemu-devel] [PATCH 12/15] target-i386: Use tcg_gen_extract_tl

Three places where it was easy to identify a right-shift followed by an extract or and-with-immediate. Signed-off-by: Richard Henderson --- target-i386/translate.c | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git

[Qemu-devel] [PATCH 03/15] tcg/aarch64: Implement field extraction opcodes

Cc: Claudio Fontana Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 8 tcg/aarch64/tcg-target.inc.c | 14 ++ 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/tcg/aarch64/tcg-target.h

[Qemu-devel] [PATCH 00/15] tcg field extract primitives

I was fooling around with a new target last weekend, and got myself all turned around with its field extract instruction. How much more handy would it be, I told myself, if we had such a thing generically? In addition, many hosts have this natively. So it seems a shame to not take advantage of

Re: [Qemu-devel] [PATCH 05/15] util: add a helper to mmap private anonymous memory

On Tue, Jun 28, 2016 at 11:01:29AM +0200, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > include/qemu/mmap-alloc.h | 6 ++ > util/mmap-alloc.c | 17 + > 2 files changed, 23 insertions(+) > > diff --git a/include/qemu/mmap-alloc.h

Re: [Qemu-devel] [PATCHv3 7/7] spapr: Improved placement of PCI host bridges in guest memory map

On Fri, Oct 14, 2016 at 09:25:58AM +0200, Laurent Vivier wrote: > On 14/10/2016 01:29, David Gibson wrote: > > From 98f07c09c6d72218800d6cfbf44b973a88ece2aa Mon Sep 17 00:00:00 2001 > > From: David Gibson > > Date: Fri, 14 Oct 2016 10:21:00 +1100 > > Subject: [PATCH]

[Qemu-devel] [PATCH 4/4] Added error checking for msix_init.

Add checks for negative return value to uses of msix_init. Signed-off-by: Shreya Shrivastava --- hw/usb/hcd-xhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 4acf0c6..cb854aa 100644 ---

[Qemu-devel] [PATCH 3/4] Add error checking for event_notifier_init.

Add checks for negative return value to uses of event_notifier_init. Signed-off-by: Shreya Shrivastava --- tests/test-aio.c | 59 1 file changed, 30 insertions(+), 29 deletions(-) diff --git a/tests/test-aio.c

[Qemu-devel] [PATCH 2/4] Add error checking for load_image_targphys.

Add checks for negative return value to uses of load_image_targphys. Signed-off-by: Shreya Shrivastava --- hw/arm/nseries.c | 9 +++-- hw/lm32/milkymist.c | 19 +++ hw/ppc/virtex_ml507.c | 5 + 3 files changed, 27 insertions(+), 6

[Qemu-devel] [PATCH 1/4] Add error checking for qemu_find_file.

This patch adds check for NULL return value to uses of qemu_find_file. Signed-off-by: Shreya Shrivastava --- hw/microblaze/boot.c | 5 + hw/ppc/e500.c | 5 - hw/ppc/mac_newworld.c | 5 + hw/ppc/mac_oldworld.c | 4 4 files changed, 18 insertions(+),

[Qemu-devel] [PATCH 0/4] Error checking for NULL or negative return value.

Hello, This series adds basic error checking for negative and null value return. Shreya. Shreya Shrivastava (4): Add error checking for qemu_find_file. Add error checking for load_image_targphys. Add error checking for event_notifier_init. Add error checking for msix_init.

Re: [Qemu-devel] [v2 5/5] qapi: allow blockdev-add for ssh

On 15.10.2016 11:04, Ashijeet Acharya wrote: > Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to > support blockdev-add for SSH network protocol driver. Use only 'struct > InetSocketAddress' since SSH only supports connection over TCP. > > Signed-off-by: Ashijeet Acharya

Re: [Qemu-devel] [v2 4/5] block/ssh: Use InetSocketAddress options

On 15.10.2016 11:04, Ashijeet Acharya wrote: > Drop the use of legacy options in favour of the InetSocketAddress > options. > > Signed-off-by: Ashijeet Acharya > --- > block/ssh.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git

Re: [Qemu-devel] [v2 3/5] block/ssh: Use inet_connect_saddr() to establish socket connection

On 15.10.2016 11:04, Ashijeet Acharya wrote: > Make inet_connect_saddr() in util/qemu-socktets.c public and use it *util/qemu-sockets.c > instead of inet_connect() because this directly takes the > InetSocketAddress to establish a socket connection for the SSH > block driver. > > Signed-off-by:

Re: [Qemu-devel] [v2 2/5] block/ssh: Add InetSocketAddress and accept it

On 15.10.2016 11:04, Ashijeet Acharya wrote: > Add InetSocketAddress compatibility to SSH driver. > > Add a new option "server" to the SSH block driver which then accepts > a InetSocketAddress. > > "host" and "port" are supported as legacy options and are mapped to > their InetSocketAddress

Re: [Qemu-devel] [PATCH v2] tap-bsd: OpenBSD uses tap(4) now

On 10/06/16 21:28, Brad Smith wrote: Update the tap-bsd code now that OpenBSD uses tap(4). Signed-off-by: Brad Smith --- v2: Allow the code to deal with newer vs older OpenBSD releases ping. diff --git a/net/tap-bsd.c b/net/tap-bsd.c index c506ac3..6c96922 100644 ---

Re: [Qemu-devel] [libvirt] inconsistent handling of "qemu64" CPU model

> In your case, you should be able to use > > > qemu64 > > > > to get the same CPU model you'd get by default (if not, you may need to > also add ). > > Alternatively > > > qemu64 > > > > should work too (and it would be better in case you use

Re: [Qemu-devel] [v2 1/5] block/ssh: Add ssh_has_filename_options_conflict()

On 15.10.2016 11:04, Ashijeet Acharya wrote: > We have 5 options plus ("server") option which is added in the next > patch that conflict with specifying a SSH filename. We need to iterate > over all the options to check whether its key has an "server." prefix. > > This iteration will help us

Re: [Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding

> +#ifdef CONFIG_ICONV > +if (font_charset) { > +unsigned char ch; > +wchar_t wch; > +char *pch, *pwch; > +size_t sch, swch; > +iconv_t conv; > + > +conv = iconv_open("WCHAR_T", font_charset); Is this portable? It seems safer to convert to

[Qemu-devel] [PATCH 0/5] curses: wide character support

Hello, This patch series adds wide character support to the curses frontend of qemu, thus allowing to fix a lot of input and output issues with e.g. accented letters and semi-graphic glyphs. Since qemu can't know the encoding of the VGA font, the user has to specify it (just like he has to

[Qemu-devel] [PATCH 5/5] curses: support wide input

This makes use of wide curses functions instead of 8bit functions. This allows to type e.g. accented letters. Unfortunately, key codes are then returned with values that could be confused with wide characters by ncurses, so we need to add a maybe_keycode variable to know whether the returned

[Qemu-devel] [PATCH 3/5] curses: use wide output functions

This makes use of cchar_t instead of chtype when using ncursesw, which allows to store a wide char as well as the WACS values. This also allows to complete the printable glyphs list beyond ascii and the ACS values. Signed-off-by: Samuel Thibault --- configure

[Qemu-devel] [PATCH 2/5] curses: Use cursesw instead of curses

Use ncursesw package instead of curses on non-mingw, and check a few functions. Also take cflags from pkg-config, since cursesw headers may be in a separate, non-default directory. Signed-off-by: Samuel Thibault --- configure | 29 - 1

[Qemu-devel] [PATCH 1/5] curses: fix left/right arrow translation

In default VGA font, left/right arrow are glyphs 0x1a and 0x1b, not 0x0a and 0x0b. Signed-off-by: Samuel Thibault --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index c8be4b7..3599295 100644 ---

[Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding

This detects and uses iconv to convert glyphs from the specified VGA font encoding to unicode. Signed-off-by: Samuel Thibault --- configure | 37 + include/sysemu/sysemu.h | 1 + qemu-options.hx | 5 -

Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162

On 13.10.2016 07:20, Hao QingFeng wrote: > > > 在 2016-10-13 3:46, Max Reitz 写道: >> On 12.10.2016 10:55, Hao QingFeng wrote: >>> Max, >>> >>> Just a common question for this case, if sshx block driver wasn't built >>> into qemu-img, this case would fail as below: >> Good point, and thanks for

Re: [Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

Hello, Peter Maydell, on Wed 22 Jun 2016 21:49:04 +0100, wrote: > On 22 June 2016 at 16:44, Samuel Thibault > wrote: > > By default, curses will only report single ESC key event after 1s delay, > > since ESC is also used for keypad escape sequences. This however

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

On 15.10.2016 20:03, Max Reitz wrote: On 14.10.2016 20:44, Vladimir Sementsov-Ogievskiy wrote: On 01.10.2016 19:26, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are ... +goto fail; +

Re: [Qemu-devel] [PATCH v4 12/12] iotests: Add test for NBD's blockdev-add interface

On 13.10.2016 15:26, Kevin Wolf wrote: > Am 28.09.2016 um 22:56 hat Max Reitz geschrieben: >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/147 | 201 >> + >> tests/qemu-iotests/147.out | 5 ++ >>

Re: [Qemu-devel] [PATCH v4 09/12] iotests.py: Add qemu_nbd function

On 13.10.2016 15:11, Kevin Wolf wrote: > Am 28.09.2016 um 22:55 hat Max Reitz geschrieben: >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/iotests.py | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/tests/qemu-iotests/iotests.py

Re: [Qemu-devel] [PATCH v4 06/12] block/nbd: Accept SocketAddress

On 13.10.2016 13:42, Kevin Wolf wrote: > Am 28.09.2016 um 22:55 hat Max Reitz geschrieben: >> Add a new option "address" to the NBD block driver which accepts a >> SocketAddress. >> >> "path", "host" and "port" are still supported as legacy options and are >> mapped to their corresponding

Re: [Qemu-devel] [PATCH v3] block: Remove "options" indirection from blockdev-add

On 11.10.2016 15:27, Kevin Wolf wrote: > Now that QAPI supports boxed types, we can have unions at the top level > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains the > real arguments. > > blockdev-add is still

Re: [Qemu-devel] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

On 14.10.2016 20:44, Vladimir Sementsov-Ogievskiy wrote: > On 01.10.2016 19:26, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are > > ... > >> +goto fail; >> +} >> + >> +/* loop

Re: [Qemu-devel] [PATCH 1/1] slirp: VMState conversion; tcpcb

Dr. David Alan Gilbert (git), on Thu 13 Oct 2016 18:37:46 +0100, wrote: > Convert the migration of the struct tcpcb to use a VMStateDescription, > the rest of it will come later. > > Mostly mechanical, except for conversion of some 'char' to uint8_t > to ensure portability. > > Tested with >

Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

On 13.10.2016 18:48, Vladimir Sementsov-Ogievskiy wrote: > On 07.10.2016 22:24, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Realize block bitmap stroing interface, to allow qcow2 images store > > [snip] > >>> +uint64_t end = MIN(bm_size, sector +

Re: [Qemu-devel] [PATCH] linux-user: Fix do_store_exclusive for shared memory of interprocess.

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] linux-user: Fix do_store_exclusive for shared memory of interprocess. Type: series Message-id: 20161015155348.26834-...@hev.cc === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH] linux-user: Fix do_store_exclusive for shared memory of interprocess.

From: Heiher test case: http://pastebin.com/raw/x2GW4xNW Signed-off-by: Heiher --- linux-user/main.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 0e31dad..81b0a49

Re: [Qemu-devel] [PULL 4/4] tests/docker/Makefile.include: add a generic docker-run target

Paolo Bonzini writes: > On 14/10/2016 17:29, Fam Zheng wrote: >> From: Alex Bennée >> >> This re-factors the docker makefile to include a docker-run target which >> can be controlled entirely from environment variables specified on the >> make

Re: [Qemu-devel] [PULL 4/4] tests/docker/Makefile.include: add a generic docker-run target

On 14/10/2016 17:29, Fam Zheng wrote: > From: Alex Bennée > > This re-factors the docker makefile to include a docker-run target which > can be controlled entirely from environment variables specified on the > make command line. This allows us to run against any given

Re: [Qemu-devel] [V2,1/7] nios2: Add disas entries

Hi Marek, Le 28/09/2016 à 01:30, Marek Vasut a écrit : > Add nios2 disassembler support. This patch is composed from binutils files > from commit "Opcodes and assembler support for Nios II R2". The files from > binutils used in this patch are: > > include/opcode/nios2.h >

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: qemu-trivial information

08.10.2016 13:00, Laurent Vivier wrote: Information about "qemu-trivial" ML can be found in the wiki: http://wiki.qemu.org/Contribute/TrivialPatches But the first place where a developer looks is the file MAINTAINERS. This also allows the get_maintainer.pl script to display the

Re: [Qemu-devel] [PATCH] colo-compare: remove unused struct CompareChardevProps and 'props' variable

13.10.2016 09:57, zhanghailiang wrote: After commit 0a73336d, 'props' variable in find_and_check_chardev() is unused. Remove it, togther with struct CompareChardevProps. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] milkymist-pfpu: fix potential integer overflow

14.10.2016 12:51, Michael Walle wrote: Since the lm32 is a 32 bit architecture, just return a 32 bit value which is then converted to a 64 bit value. Spotted by coverity, CID 1005506. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v6 2/2] migration: migrate QTAILQ

On 10/14/2016 07:18 PM, Jianjun Duan wrote: > +/* > + * Offsets of layout of a tail queue head. > + */ > +#define QTAILQ_FIRST_OFFSET 0 > +#define QTAILQ_LAST_OFFSET (sizeof(void *)) > + > +/* > + * Offsets of layout of a tail

Re: [Qemu-devel] [PATCH] hw/block/nvme: Simplify if-statements a little bit

12.10.2016 18:18, Thomas Huth wrote: The condition '!A || (A && B)' is equivalent to '!A || B'. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] char.h: misc doc fix

Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 1/4] target-lm32: swap operand of wcsr in LOG_DIS()

Applied all 4 to -trivial. With some digging around :) Thanks, /mjt

Re: [Qemu-devel] [PATCH] target-lm32: fix LOG_DIS operand order

12.10.2016 20:15, Michael Walle wrote: The order of most opcodes with immediates was wrong (according to the reference manual) in the (debug) logging. Additionally, one operand for the andhi instruction was completly wrong. Fix these. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] target-lm32: fix style issue

12.10.2016 19:23, Michael Walle wrote: Both branches of the ternary operator have the same expressions. Drop the operator. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] hw/tpm/tpm_passthrough: Simplify if-statements a little bit

Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] filter-dump: add missing "["

Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] trace: fix group name generation

On 14 October 2016 at 23:06, Greg Kurz wrote: > On Fri, 14 Oct 2016 16:31:01 -0500 > Eric Blake wrote: > >> On 10/14/2016 04:26 PM, Greg Kurz wrote: >> > Since commit "80dd5c4918ab trace: introduce a formal group name for trace >> > events", tracetool generates

Re: [Qemu-devel] how to get the default cpu for a softmmu

Am 15.10.2016 um 12:29 schrieb Alex Bennée: >i can get a list of all supported CPUs by using the -cpu ? commandline > >but which CPU is selected if i don't give the -cpu parameter on normal >qemu start of a softmmu? IIRC it is dependant on the machine model you select and which cpu is seletec

Re: [Qemu-devel] how to get the default cpu for a softmmu

Dennis Luehring writes: > i can get a list of all supported CPUs by using the -cpu ? commandline > > but which CPU is selected if i don't give the -cpu parameter on normal > qemu start of a softmmu? IIRC it is dependant on the machine model you select. -- Alex Bennée

Re: [Qemu-devel] [PATCH v4 0/3] IOMMU: intel_iommu support map and unmap notifications

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1476526326-32363-1-git-send-email-bd.a...@gmail.com Subject: [Qemu-devel] [PATCH v4 0/3] IOMMU: intel_iommu support map and unmap notifications === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH v4 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

From: "Aviv Ben-David" Supports translation trials without reporting error to guest on translation failure. Signed-off-by: Aviv Ben-David --- exec.c| 2 +- hw/i386/amd_iommu.c | 4 ++-- hw/i386/intel_iommu.c | 65

[Qemu-devel] [PATCH v4 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

From: "Aviv Ben-David" This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. This capability only enabled when cache-mode property of the device is true. Signed-off-by: Aviv

[Qemu-devel] [PATCH v4 0/3] IOMMU: intel_iommu support map and unmap notifications

From: "Aviv Ben-David" * Advertize Cache Mode capability in iommu cap register. This capability is controlled by "cache-mode" property of intel-iommu device. To enable this option call QEMU with "-device intel-iommu,cache-mode=true". * On page cache invalidation in intel

[Qemu-devel] [PATCH v4 3/3] IOMMU: enable intel_iommu map and unmap notifiers

From: "Aviv Ben-David" * register notifiers when vtd_iommu_notify_flag_changed is called. * Notify on IOTLB page invalidation about unmap and map operations. Adds a list of registered vtd_as's to intel iommu state to save iterations over each PCI device in a search of the

Re: [Qemu-devel] [PATCH] target-arm/translate.c: fix movs pc, lr exception return on ARMv7

Peter Maydell writes: > On 14 October 2016 at 16:13, Alex Bennée wrote: >> This was broken by the fix for 9b6a3ea7a699594162ed3d11e4e04b98568dc5c0. >> Specifically a movs pc,lr in the kernels ret_fast_syscall returning to >> some thumb mode

Re: [Qemu-devel] [v2 0/5] Allow blockdev-add for SSH

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [v2 0/5] Allow blockdev-add for SSH Type: series Message-id:

[Qemu-devel] [v2 4/5] block/ssh: Use InetSocketAddress options

Drop the use of legacy options in favour of the InetSocketAddress options. Signed-off-by: Ashijeet Acharya --- block/ssh.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 6420359..7fec0e1 100644 ---

[Qemu-devel] [v2 3/5] block/ssh: Use inet_connect_saddr() to establish socket connection

Make inet_connect_saddr() in util/qemu-socktets.c public and use it instead of inet_connect() because this directly takes the InetSocketAddress to establish a socket connection for the SSH block driver. Signed-off-by: Ashijeet Acharya --- block/ssh.c| 5

[Qemu-devel] [v2 1/5] block/ssh: Add ssh_has_filename_options_conflict()

We have 5 options plus ("server") option which is added in the next patch that conflict with specifying a SSH filename. We need to iterate over all the options to check whether its key has an "server." prefix. This iteration will help us adding the new option "server" easily. Signed-off-by:

[Qemu-devel] [v2 2/5] block/ssh: Add InetSocketAddress and accept it

Add InetSocketAddress compatibility to SSH driver. Add a new option "server" to the SSH block driver which then accepts a InetSocketAddress. "host" and "port" are supported as legacy options and are mapped to their InetSocketAddress representation. Signed-off-by: Ashijeet Acharya

[Qemu-devel] [v2 5/5] qapi: allow blockdev-add for ssh

Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to support blockdev-add for SSH network protocol driver. Use only 'struct InetSocketAddress' since SSH only supports connection over TCP. Signed-off-by: Ashijeet Acharya --- qapi/block-core.json | 24

[Qemu-devel] [v2 0/5] Allow blockdev-add for SSH

Previously posted series patches: v1: http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg02137.html This series adds blockdev-add support for SSH block driver. This patch series has an additional patch 'Patch 3'. Patch 1 prepares the code for the addition of a new option prefix, which

[Qemu-devel] [Bug 1593605] Re: windows2008r2 boot failed with uefi

@alex3kov -- I think you mean the question as """ Since this behaviour will not change in future versions of Windows 7 / Windows Server 2008 R2, ... """ because, again, the problem is not in OVMF but in the Windows guest. QEMU cannot be expected to recognize (guest OS, guest firmware, hw

[Qemu-devel] [PATCH v2] rbd: make the code more readable

Make it a bit clearer and more readable. Signed-off-by: Xiubo Li CC: John Snow --- V2: - Advice from John Snow. Thanks. block/rbd.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/block/rbd.c

Re: [Qemu-devel] [PATCH 00/16] target-sparc improvements

On 12/10/16 02:42, Richard Henderson wrote: > On 10/11/2016 04:42 PM, Mark Cave-Ayland wrote: >> I'm fairly sure that I've tested an earlier version of this patchset, >> however just to confirm is it just that you want a Tested-by from me of >> this branch based upon the v6 atomics patch? If so I

Re: [Qemu-devel] [PATCH v11 01/19] block: Add bdrv_drain_all_{begin, end}()

On 14/10/2016 15:08, Alberto Garcia wrote: > bdrv_drain_all() doesn't allow the caller to do anything after all > pending requests have been completed but before block jobs are > resumed. > > This patch splits bdrv_drain_all() into _begin() and _end() for that > purpose. It also adds

Re: [Qemu-devel] [PATCH v11 02/19] block: Pause all jobs during bdrv_reopen_multiple()

On 14/10/2016 15:08, Alberto Garcia wrote: > When a BlockDriverState is about to be reopened it can trigger certain > operations that need to write to disk. During this process a different > block job can be woken up. If that block job completes and also needs > to call bdrv_reopen() it can