Re: [Qemu-devel] [PATCH] crypto: add virtio-crypto driver

2016-11-19 Thread gong lei
on 2016/11/17 23:55, Benedetto, Salvatore wrote: > Hi Gonglei, > > ... >> + >> +static int virtio_crypto_alg_ablkcipher_init_session( >> +struct virtio_crypto_ablkcipher_ctx *ctx, >> +int alg, const uint8_t *key, >> +unsigned int keylen, >> +int

Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

2016-11-19 Thread Samuel Thibault
Vincent Bernat, on Sat 19 Nov 2016 09:03:08 +0100, wrote: > ❦ 19 novembre 2016 08:32 +0100, Thomas Huth  : > > >> Some network equipments are requesting a file using the netascii > >> protocol and this is not configurable. Currently, qemu's tftpd only > >> supports the octet

Re: [Qemu-devel] [PATCH v2 9/9] tests: Add coverage for recent block geometry fixes

2016-11-19 Thread Max Reitz
On 19.11.2016 22:45, Max Reitz wrote: > On 18.11.2016 02:28, Eric Blake wrote: >> On 11/17/2016 05:42 PM, Max Reitz wrote: >>> On 17.11.2016 21:14, Eric Blake wrote: Use blkdebug's new geometry constraints to emulate setups that have caused recent regression fixes: write zeroes asserting

Re: [Qemu-devel] [PATCH v2 5/9] block: Pass unaligned discard requests to drivers

2016-11-19 Thread Max Reitz
On 18.11.2016 02:13, Eric Blake wrote: > On 11/17/2016 05:44 PM, Max Reitz wrote: >>> >>> Since the SCSI specification says nothing about a minimum >>> discard granularity, and only documents the preferred >>> alignment, it is best if the block layer gives the driver >>> every bit of information

Re: [Qemu-devel] [PATCH v2 9/9] tests: Add coverage for recent block geometry fixes

2016-11-19 Thread Max Reitz
On 18.11.2016 02:28, Eric Blake wrote: > On 11/17/2016 05:42 PM, Max Reitz wrote: >> On 17.11.2016 21:14, Eric Blake wrote: >>> Use blkdebug's new geometry constraints to emulate setups that >>> have caused recent regression fixes: write zeroes asserting >>> when running through a loopback block

[Qemu-devel] Suggested command-line for ARM

2016-11-19 Thread G 3
I tried making a suggested command-line section in your ARM wiki page, but my lack of experience with ARM prevents me from testing it. What do you think of this as the suggested command-line for qemu- system-aarch64: qemu-system-aarch64 -m -M -drive if=none,file=,id=hd0 -device

Re: [Qemu-devel] [PATCH for-2.8] curses: Fix compiler warnings (Mingw-w64 redefinition of macro KEY_EVENT)

2016-11-19 Thread Samuel Thibault
Stefan Weil, on Sat 19 Nov 2016 19:53:18 +0100, wrote: > For builds with Mingw-w64 as it is included in Cygwin, there are two > header files which define KEY_EVENT with different values. > > This results in lots of compiler warnings like this one: > > CC vl.o > In file included from

[Qemu-devel] [PATCH for-2.8] target-*: Fix typos found by codespell

2016-11-19 Thread Stefan Weil
Signed-off-by: Stefan Weil --- target-i386/translate.c | 2 +- target-m68k/translate.c | 6 +++--- target-ppc/cpu.h | 2 +- target-ppc/excp_helper.c | 2 +- target-ppc/int_helper.c | 2 +- target-ppc/mmu-hash64.c | 2 +- target-s390x/cpu_models.c | 2 +-

[Qemu-devel] [PATCH for-2.8] include: Fix typos found by codespell

2016-11-19 Thread Stefan Weil
Add also a missing parenthesis in a comment. Signed-off-by: Stefan Weil --- include/hw/dma/xlnx_dpdma.h| 3 ++- include/hw/pci-host/q35.h | 2 +- include/hw/register.h | 2 +- include/io/task.h | 2 +- include/qapi/dealloc-visitor.h | 2 +-

[Qemu-devel] [PATCH for-2.8] hw: Fix typos found by codespell

2016-11-19 Thread Stefan Weil
Signed-off-by: Stefan Weil --- hw/block/m25p80.c | 4 ++-- hw/core/generic-loader.c | 4 ++-- hw/core/qdev-properties.c | 2 +- hw/display/xlnx_dp.c | 4 ++-- hw/i386/pc.c | 2 +- hw/net/cadence_gem.c | 2 +- hw/net/spapr_llan.c | 4 ++--

[Qemu-devel] [PATCH for-2.8] disas/ppc: Fix indefinite articles in comments

2016-11-19 Thread Stefan Weil
Signed-off-by: Stefan Weil --- disas/ppc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/disas/ppc.c b/disas/ppc.c index bd05623..9b5a0e7 100644 --- a/disas/ppc.c +++ b/disas/ppc.c @@ -1653,11 +1653,11 @@ extract_tbr (unsigned long insn,

[Qemu-devel] [PATCH for-2.8] Fix documentation and some comments (article, grammar)

2016-11-19 Thread Stefan Weil
Signed-off-by: Stefan Weil --- arch_init.c | 2 +- qemu-doc.texi | 2 +- qemu-options.hx | 2 +- util/uri.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5cc58b2..b35deb8 100644 --- a/arch_init.c +++

[Qemu-devel] [PATCH for-2.8] curses: Fix compiler warnings (Mingw-w64 redefinition of macro KEY_EVENT)

2016-11-19 Thread Stefan Weil
For builds with Mingw-w64 as it is included in Cygwin, there are two header files which define KEY_EVENT with different values. This results in lots of compiler warnings like this one: CC vl.o In file included from /qemu/include/ui/console.h:340:0, from /qemu/vl.c:76:

[Qemu-devel] [Bug 1399943] Re: qemu-system-sparc loses serial console data on EAGAIN

2016-11-19 Thread Andreas Gustafsson
I have now run some more tests, and I'm still seeing occasional failures in the scripted NetBSD installs that look like console data loss when using qemu 2.7.0, with maybe one in ten installs failing. I have seen no failures so far using the git master. So it looks like the bug is fixed in git,

Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

2016-11-19 Thread Vincent Bernat
❦ 19 novembre 2016 08:32 +0100, Thomas Huth  : >> Some network equipments are requesting a file using the netascii >> protocol and this is not configurable. Currently, qemu's tftpd only >> supports the octet protocol. This commit makes it accept the netascii >> protocol as well

[Qemu-devel] [PATCH] migration: re-active images when migration fails to complete

2016-11-19 Thread zhanghailiang
commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case which migration aborted QEMU because it didn't regain the control of images while some errors happened. Actually, we have another case in that error path to abort QEMU because of the same reason: migration_thread()

[Qemu-devel] [PATCH] qapi: add explicit null to string input and output visitors

2016-11-19 Thread Greg Kurz
This may be used for deprecated object properties that are kept for backwards compatibility. Signed-off-by: Greg Kurz --- This is enough to fix David's patch: [RFCv2 10/12] pseries: Move CPU compatibility property to machine Messag-Id:

Re: [Qemu-devel] [RFCv2 10/12] pseries: Move CPU compatibility property to machine

2016-11-19 Thread Greg Kurz
Hi David, I've started to go through the testing you suggest in the cover letter. QEMU crashes when trying to use the deprecated "compat" CPU property. On Wed, 16 Nov 2016 09:17:53 +1100 David Gibson wrote: > Server class POWER CPUs have a "compat" property, which