Re: [Qemu-devel] [PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites

On Mon 21 Nov 2016 06:31:26 PM CET, Kevin Wolf wrote: > Replacing it with bdrv_co_pwritev() prepares us for byte granularity > requests and gets us rid of the last bdrv_aio_*() user in quorum. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia

Re: [Qemu-devel] [PATCH 5/8] quorum: Inline quorum_aio_cb()

On Mon 21 Nov 2016 06:31:25 PM CET, Kevin Wolf wrote: > This is a conversion to a more natural coroutine style and improves the > readability of the driver. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH 3/8] quorum: Implement .bdrv_co_readv/writev

On Mon 21 Nov 2016 06:31:23 PM CET, Kevin Wolf wrote: > This converts the quorum block driver from implementing callback-based > interfaces for read/write to coroutine-based ones. This is the first > step that will allow us further simplification of the code. > > Signed-off-by:

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

On 11/22/2016 05:07 AM, Jason Wang wrote: On 2016年11月22日 00:23, Michael S. Tsirkin wrote: On Fri, Nov 18, 2016 at 02:21:54PM -0500, Aaron Conole wrote: Maxime Coquelin writes: On 11/18/2016 07:15 PM, Aaron Conole wrote: Maxime Coquelin

Re: [Qemu-devel] [PATCH v14 1/2] virtio-crypto: Add virtio crypto device specification

Hi, > > Subject: Re: [Qemu-devel] [PATCH v14 1/2] virtio-crypto: Add virtio crypto > device specification > > On Sun, 20 Nov 2016 08:45:57 + > gong lei wrote: > > > On 2016/11/17 2:11, Halil Pasic wrote: > > > On 11/11/2016 10:23 AM, Gonglei wrote: > > > >> +The

Re: [Qemu-devel] [PATCH v3 1/1] hw/net/spapr_llan: 6 byte mac address device tree entry

On 22.11.2016 00:19, Sam Bobroff wrote: > The spapr-vlan device in QEMU has always presented it's MAC address in > the device tree as an 8 byte value, even though PAPR requires it to be > 6 bytes. This is because, at the time, AIX required the value to be 8 > bytes. However, modern versions of

Re: [Qemu-devel] [PATCH] ui/vnc: Fix problem with sending too many bytes as server name

On 21.11.2016 18:51, Gerd Hoffmann wrote: > On Mo, 2016-11-21 at 18:25 +0100, Thomas Huth wrote: >> If the buffer is not big enough, snprintf() does not return the number >> of bytes that have been written to the buffer, but the number of bytes >> that would be needed for writing the whole string.

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

> On Nov 21, 2016, at 3:46 PM, Eric Blake wrote: > > On 11/21/2016 02:36 PM, Eric Blake wrote: > > > but I'd argue that using qobject_from_jsonf() is already less-than- > > > useful. > > > > In fact, we are down to only a handful of users of our modified > > 'jsonf' > > format (that is, strings

[Qemu-devel] [PATCH v3 2/4] qdev: add function qdev_set_id()

In order to have an easy way to add a new qdev with a specific id carve out the needed functionality from qdev_device_add() into a new function qdev_set_id(). Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini --- include/monitor/qdev.h | 1 +

[Qemu-devel] [PATCH v3 0/4] xen: add qdevs for each backend, correct pvUSB

Trying to use pvUSB in a Xen guest with a qemu emulated USB controller will crash qemu as it tries to attach a pvUSB device to the emulated controller. This can be avoided by adding a unique id to each pvUSB controller which can be used when attaching the pvUSB device. In order to make this

[Qemu-devel] [PATCH v3 1/4] xen: add an own bus for xen backend devices

Add a bus for Xen backend devices in order to be able to establish a dedicated device path for pluggable devices. Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini --- hw/xen/xen_backend.c | 19 ---

[Qemu-devel] [PATCH v3 4/4] xen: attach pvusb usb bus to backend qdev

Attach the usb bus of a new pvusb controller to the qdev associated with the Xen backend. Any device connected to that controller can now specify the bus and port directly via its properties. Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini

[Qemu-devel] [PATCH v3 3/4] xen: create qdev for each backend device

Create a qdev plugged to the xen-sysbus for each new backend device. This device can be used as a parent for all needed devices of that backend. The id of the new device will be "xen--" with being the xen backend type (e.g. "qdisk") and the xen backend number of the type under which it is to be

Re: [Qemu-devel] [PATCH for-2.9] numa: make -numa parser dynamically allocate CPUs masks

On 18/11/16 22:02, Igor Mammedov wrote: > so it won't impose an additional limits on max_cpus limits > supported by different targets. > > It removes global MAX_CPUMASK_BITS constant and need to > bump it up whenever max_cpus is being increased for > a target above MAX_CPUMASK_BITS value. > >

Re: [Qemu-devel] [PATCH v6 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

On 2016年11月21日 21:35, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 12:15:48PM +0800, Jason Wang wrote: > > >On 2016年11月11日 11:39, Michael S. Tsirkin wrote: > >On Fri, Nov 11, 2016 at 10:32:42AM +0800, Jason Wang wrote: > > > > > >On 2016年11月10日 06:00, Michael S. Tsirkin wrote: > > >

Re: [Qemu-devel] [RFC v2 0/3] virtio-net: Add support to MTU feature

On 2016年11月22日 00:23, Michael S. Tsirkin wrote: On Fri, Nov 18, 2016 at 02:21:54PM -0500, Aaron Conole wrote: Maxime Coquelin writes: On 11/18/2016 07:15 PM, Aaron Conole wrote: Maxime Coquelin writes: This series implements

Re: [Qemu-devel] [PATCH v6 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

On 2016年11月21日 20:41, Aviv B.D. wrote: On Fri, Nov 11, 2016 at 6:15 AM, Jason Wang > wrote: On 2016年11月11日 11:39, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 10:32:42AM +0800, Jason Wang wrote: On

Re: [Qemu-devel] [Qemu-block] [PATCH] block/mirror: enable detect zeroes when driving mirror

On 2016年11月21日 19:34, Kevin Wolf wrote: Am 21.11.2016 um 02:24 hat Yang Wei geschrieben: In order to preserve sparse disk image, detect_zeroes should also be enabled when bdrv_get_block_status_above() returns BDRV_BLOCK_DATA Signed-off-by: Yang Wei Just preserving

Re: [Qemu-devel] [PATCH RFC 0/2] numa: allocate CPUs masks dynamically

On 22/11/16 05:46, Greg Kurz wrote: > On Thu, 17 Nov 2016 17:27:20 +1100 > Alexey Kardashevskiy wrote: > >> On 17/11/16 03:02, Igor Mammedov wrote: >>> This series removes global MAX_CPUMASK_BITS constant >>> so that it won't inderectly influence maximum CPUs count >>> supported

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Make uninorth interrupt swizzling identical to Grackle

On Tue, 2016-11-22 at 02:34 +0100, BALATON Zoltan wrote: > > Is this going in for 2.8? If so, I'll need to apply the corresponding > > patch to OpenBIOS to match and also do a PPC testing cycle to make sure > > that there are no regressions on other OSs. Plus it would be useful to > > get both

Re: [Qemu-devel] [PATCH] block/mirror: enable detect zeroes when driving mirror

On 2016年11月21日 14:51, Vasiliy Tolstov wrote: 21 Ноя 2016 г. 4:27 пользователь "Yang Wei" > написал: > > In order to preserve sparse disk image, detect_zeroes > should also be enabled when bdrv_get_block_status_above() > returns BDRV_BLOCK_DATA > >

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

On 22/11/16 00:08, Andrea Bolognani wrote: > On Mon, 2016-11-21 at 13:12 +1100, Alexey Kardashevskiy wrote: > 1) switch to PCI Express on newer machine types, and >expose some sort of capability through QMP so that >libvirt can know about the switch > >

[Qemu-devel] [PATCH] Fix FreeBSD (10.x) build after 7dc9ae43

Include sys/user.h for declaration of 'struct kinfo_proc'. Add -lutil to qemu-ga link for kinfo_getproc. Signed-off-by: Ed Maste --- configure | 2 ++ util/oslib-posix.c | 1 + 2 files changed, 3 insertions(+) diff --git a/configure b/configure index

Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines' Type: series Message-id:

Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines' Type: series Message-id: 1479777133-23567-1-git-send-email-ehabk...@redhat.com === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Make uninorth interrupt swizzling identical to Grackle

On Tue, 22 Nov 2016, Mark Cave-Ayland wrote: On 21/11/16 23:05, David Gibson wrote: On Mon, Nov 21, 2016 at 12:12:31AM +1000, BALATON Zoltan wrote: From: Benjamin Herrenschmidt It's currently broken as it uses an incorrect shift, it tries to use the slot number but

[Qemu-devel] [RFC 12/15] arm: Initialize default bus lists

Populate default_bus_types for some machines. Work in progress, I didn't check if all machines were converted (so we could enable strict mode for arm in qmp-machine-info.py). Cc: Peter Maydell Cc: Beniamino Galvani Cc: Igor Mitsyanko

[Qemu-devel] [RFC 13/15] mips: Initialize default bus lists

Populate default_bus_types for some machines. Work in progress, I didn't check if all machines were converted (so we could enable strict mode for mips in qmp-machine-info.py). Cc: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Eduardo Habkost

[Qemu-devel] [RFC 11/15] s390x: Initialize default bus lists

Populate the default_bus_types list for the s390x machines. This will allow qmp-machine-info.py to run in strict mode for s390x. Signed-off-by: Eduardo Habkost --- hw/s390x/s390-virtio-ccw.c | 6 ++ tests/qmp-machine-info.py | 2 +- 2 files changed, 7 insertions(+), 1

[Qemu-devel] [RFC 14/15] ppc: Initialize default bus lists

Populate default_bus_types for some machines. Work in progress, I didn't check if all machines were converted (so we could enable strict mode for ppci in qmp-machine-info.py). Cc: Alexander Graf Cc: Scott Wood Cc: David Gibson

[Qemu-devel] [RFC 10/15] pc: Initialize default bus lists

Populate the default_bus_types list for the PC machines. This will allow qmp-machine-info.py to run in strict mode for x86. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 13 + hw/i386/pc_q35.c | 4 tests/qmp-machine-info.py | 2

[Qemu-devel] [RFC 07/15] machine: Add MachineClass::default_buses field

The new field can be populated by class_init functions with the list of bus types that are created by default when the machine is initialized. It will be used to build the device type compatibility list on 'query-machines' output. As a TYPE_SYSTEM_BUS bus is always created, add it to the default

[Qemu-devel] [RFC 04/15] qtest.py: Make 'binary' parameter optional

If the 'binary' parameter is omitted, use the $QTEST_QEMU_BINARY environment variable. Signed-off-by: Eduardo Habkost --- scripts/qtest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/qtest.py b/scripts/qtest.py index 0496490..5a37b48

[Qemu-devel] [RFC 15/15] qdev: Add device_class_set_bus_type() function

Add a function set BusClass::bus_type, so we can perform extra validation of the field, to ensure the corresponding bus class has supported_device_types set propertly. Signed-off-by: Eduardo Habkost --- hw/audio/intel-hda.c | 2 +- hw/block/fdc.c| 2

[Qemu-devel] [RFC 08/15] qmp: Add 'supported-device-types' field to 'query-machines'

The new field will return a list of device type names that are compatible with the default bus configuration of the machine-type. The list can be easily built using the MachineClass::default_bus_types and BusClass::supported_device_type fields. The returned types can be used as the 'implements'

[Qemu-devel] [RFC 09/15] pci: Introduce INTERFACE_PCIE_DEVICE interface name

The new interface name will be used by TYPE_PCIE_BUS to allow only PCIe devices to be plugged, by setting BusClass::supported_device_type = INTERFACE_PCIE_DEVICE. This patch changes all devices that set is_express=1 or set QEMU_PCI_CAP_EXPRESS directly to implement INTERFACE_PCIE_DEVICE. There

[Qemu-devel] [RFC 05/15] tests: Add rules to non-gtester qtest test cases

Today, simple non-gtester binaries can be run easily by a single Makefile rule (e.g. check-tests/qemu-iotest-quick.sh), but we don't have anything to help us automatically run the same test binary for multiple architectures. This add check-simpleqtest-* rules that will help us run binaries

[Qemu-devel] [RFC 03/15] qtest.py: make logging optional

Support the 'logging' parameter on QEMUQtestMachine, for test cases that don't require logging. Signed-off-by: Eduardo Habkost --- scripts/qtest.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/qtest.py b/scripts/qtest.py index

[Qemu-devel] [RFC 02/15] qtest.py: Support QTEST_LOG environment variable

qtest logs everything to stderr by default, but we don't want it to be the default behavior on test cases. Implement the same behavior of libqtest.c, and redirect the qtest log to /dev/null by default unless the QTEST_LOG environment variable is set. Signed-off-by: Eduardo Habkost

[Qemu-devel] [RFC 06/15] qdev: Add device_type field to BusClass

Each bus class will now be aware of the specific device type that can be plugged on it. Also add a read-only 'device-type' property to the class, that will be useful for: * Runtime check for which devices types can be plugged to the machine; * Validation of query-machines output by automated

[Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

The Problem === Currently management software has no way to find out which device types can be plugged in a machine, unless the machine is already initialized. Even after the machine is initialized, there's no way to map existing bus types to supported device types unless management

[Qemu-devel] [RFC 01/15] qemu.py: Make logging optional

If a test case doesn't make QEMU generate any output, there's no need to redirect stdout and stderr to a file. On those cases, logging can be disabled so any errors are included on the test case output. Signed-off-by: Eduardo Habkost --- scripts/qemu.py | 25

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Make uninorth interrupt swizzling identical to Grackle

On 21/11/16 23:05, David Gibson wrote: > On Mon, Nov 21, 2016 at 12:12:31AM +1000, BALATON Zoltan wrote: >> From: Benjamin Herrenschmidt >> >> It's currently broken as it uses an incorrect shift, it tries >> to use the slot number but uses the top bits of the bus number

Re: [Qemu-devel] [PATCH v2] docs: add document to explain the usage of vNVDIMM

On 11/21/16 18:38 +0200, Michael S. Tsirkin wrote: On Mon, Nov 21, 2016 at 02:00:23PM +0800, Haozhong Zhang wrote: On 11/09/16 12:35 +, Stefan Hajnoczi wrote: > On Wed, Nov 09, 2016 at 09:04:48AM +0800, Haozhong Zhang wrote: > > Signed-off-by: Haozhong Zhang > >

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 5/5] spapr: Fix 2.7<->2.8 migration of PCI host bridge

On Mon, Nov 21, 2016 at 05:02:20PM +0100, Greg Kurz wrote: > On Mon, 21 Nov 2016 13:02:53 +0100 > Thomas Huth wrote: > > > On 21.11.2016 06:31, David Gibson wrote: > > > daa2369 "spapr_pci: Add a 64-bit MMIO window" subtly broke migration > > > from qemu-2.7 to the current

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 3/5] target-ppc: Allow eventual removal of old migration mistakes

On Mon, Nov 21, 2016 at 04:26:10PM +0100, Greg Kurz wrote: > On Mon, 21 Nov 2016 16:31:40 +1100 > David Gibson wrote: > > > Until very recently, the vmstate for ppc cpus included some poorly > > thought out VMSTATE_EQUAL() components, that can easily break > >

Re: [Qemu-devel] [PATCH] target-ppc: fix index array of national digits

On Mon, Nov 21, 2016 at 12:55:13PM -0200, Jose Ricardo Ziviani wrote: > Fixes the big endian array access of national digits, from commits > b815587 and e2106d7. > > Signed-off-by: Jose Ricardo Ziviani Applied to ppc-for-2.8, thanks. > --- > target-ppc/int_helper.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Make uninorth interrupt swizzling identical to Grackle

On Mon, Nov 21, 2016 at 12:12:31AM +1000, BALATON Zoltan wrote: > From: Benjamin Herrenschmidt > > It's currently broken as it uses an incorrect shift, it tries > to use the slot number but uses the top bits of the bus number > instead. > > Note: Neither implementation

[Qemu-devel] [PATCH v3 1/1] hw/net/spapr_llan: 6 byte mac address device tree entry

The spapr-vlan device in QEMU has always presented it's MAC address in the device tree as an 8 byte value, even though PAPR requires it to be 6 bytes. This is because, at the time, AIX required the value to be 8 bytes. However, modern versions of AIX support the (correct) 6 byte value so they no

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/1] hw/net/spapr_llan: 6 byte mac address device tree entry

On Mon, Nov 21, 2016 at 11:14:26AM +0100, Thomas Huth wrote: > On 21.11.2016 06:04, Sam Bobroff wrote: > > The spapr-vlan device in QEMU has always presented it's MAC address in > > the device tree as an 8 byte value, even though PAPR requires it to be > > 6 bytes. This is because, at the time,

[Qemu-devel] [PULL for-2.8 1/1] gluster: Fix use after free in glfs_clear_preopened()

From: Kevin Wolf This fixes a use-after-free bug introduced in commit 6349c154. We need to use QLIST_FOREACH_SAFE() when freeing elements in the loop. Spotted by Coverity. Signed-off-by: Kevin Wolf Message-id:

[Qemu-devel] [PULL for-2.8 0/1] Block patches for 2.8

The following changes since commit c36ed06e9159fa484b711dfdd27ec64d7ac3d17a: Merge remote-tracking branch 'mst/tags/for_upstream' into staging (2016-11-21 11:09:58 +) are available in the git repository at: https://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request for you

[Qemu-devel] [PATCH 4/4] 9pfs: add a size parameter to init_iov_from_pdu

Not all 9pfs transports share memory between request and response. For those who don't, it is necessary to know how much memory is required in the response. Signed-off-by: Stefano Stabellini --- hw/9pfs/9p.c | 2 +- hw/9pfs/9p.h | 2 +-

[Qemu-devel] [PATCH 1/4] 9pfs: move pdus to V9fsState

pdus are initialized and used in 9pfs common code. Move the array from V9fsVirtioState to V9fsState. Signed-off-by: Stefano Stabellini --- hw/9pfs/9p.c| 7 +++ hw/9pfs/9p.h| 1 + hw/9pfs/virtio-9p.h | 1 - 3 files changed, 4 insertions(+), 5

[Qemu-devel] [PATCH 2/4] 9pfs: introduce transport specific callbacks

Don't call virtio functions from 9pfs generic code, use generic function callbacks instead. Signed-off-by: Stefano Stabellini --- hw/9pfs/9p.c | 8 hw/9pfs/9p.h | 18 ++ hw/9pfs/virtio-9p-device.c | 18

[Qemu-devel] [PATCH 3/4] 9pfs: use v9fs_init_qiov_from_pdu instead of v9fs_pack

v9fs_xattr_read should not access VirtQueueElement elems directly. Move v9fs_init_qiov_from_pdu up in the file and call v9fs_init_qiov_from_pdu instead of v9fs_pack. Signed-off-by: Stefano Stabellini --- hw/9pfs/9p.c | 58

[Qemu-devel] [PATCH 0/4] 9pfs: clean-up for multiple transports

Hi all, this small patch series provides a few fixes and clean-ups in preparation for the introduction of a 9pfs Xen transport. Stefano Stabellini (4): 9pfs: move pdus to V9fsState 9pfs: introduce transport specific callbacks 9pfs: use v9fs_init_qiov_from_pdu instead of

Re: [Qemu-devel] [PATCH v2 8/9] blkdebug: Add ability to override unmap geometries

On 11/21/2016 03:11 PM, Eric Blake wrote: >>> @@ -398,6 +429,53 @@ static int blkdebug_open(BlockDriverState *bs, QDict >>> *options, int flags, >>> ret = -EINVAL; >>> goto fail_unref; >>> } >>> +max_transfer = qemu_opt_get_size(opts, "max-transfer", 0); >>> +if

Re: [Qemu-devel] [PATCH v2 8/9] blkdebug: Add ability to override unmap geometries

On 11/17/2016 05:02 PM, Max Reitz wrote: > On 17.11.2016 21:14, Eric Blake wrote: >> Make it easier to simulate the Dell Equallogic iSCSI with its > > Somehow I feel bad putting company and product names into commit messages... Not the first time I've done it - see commit b8d0a980. Keeping it

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

On Nov 21, 2016, at 3:46 PM, Eric Blake wrote: On 11/21/2016 02:36 PM, Eric Blake wrote: but I'd argue that using qobject_from_jsonf() is already less-than- useful. In fact, we are down to only a handful of users of our modified 'jsonf' format (that is, strings that mix JSON with %

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

On 11/21/2016 02:36 PM, Eric Blake wrote: > but I'd argue that using qobject_from_jsonf() is already less-than-useful. In fact, we are down to only a handful of users of our modified 'jsonf' format (that is, strings that mix JSON with % modifiers): hw/pci/pcie_aer.c: build a 5-element QDict

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

On 11/21/2016 02:12 PM, G 3 wrote: > > On Nov 21, 2016, at 5:02 AM, Paolo Bonzini wrote: > >> >> >> On 21/11/2016 07:30, G 3 wrote: >>> When I try to use qemu-system-i386, I see this error message: >>> >>> qobject/qjson.c:69: failed assertion `obj != NULL'. >>> >>> The string argument is this:

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

On Nov 21, 2016, at 5:02 AM, Paolo Bonzini wrote: On 21/11/2016 07:30, G 3 wrote: When I try to use qemu-system-i386, I see this error message: qobject/qjson.c:69: failed assertion `obj != NULL'. This is the function where the assertion fails: /* * IMPORTANT: This function aborts on

Re: [Qemu-devel] [PATCH 8/8] quorum: Inline quorum_fifo_aio_cb()

On 11/21/2016 11:31 AM, Kevin Wolf wrote: > Inlining the function removes some boilerplace code and replaces > recursion by a simple loop, so the code becomes somewhat easier to > understand. > > Signed-off-by: Kevin Wolf > Reviewed-by: Alberto Garcia > --- >

Re: [Qemu-devel] [PATCH 7/8] quorum: Implement .bdrv_co_preadv/pwritev()

On 11/21/2016 11:31 AM, Kevin Wolf wrote: > This enables byte granularity requests on quorum nodes. > > Note that the QMP events emitted by the driver are an external API that > we were careless enough to define as sector based. The offset and length > of requests reported in events are rounded

Re: [Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers

On 11/21/16 11:45, Hervé Poussineau wrote: > The blocksize option is defined in RFC 1783. > We now support block sizes between 1 and 1432 bytes, instead of 512 only. It ought to be 1476: Ethernet MTU = 1500, minus a minimum of 20 bytes for an IPv4 header and 4 for a TFTP header. Some bootloaders

Re: [Qemu-devel] [PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites

On 11/21/2016 11:31 AM, Kevin Wolf wrote: > Replacing it with bdrv_co_pwritev() prepares us for byte granularity > requests and gets us rid of the last bdrv_aio_*() user in quorum. > > Signed-off-by: Kevin Wolf > --- > block/quorum.c | 46

Re: [Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers Type: series Message-id: 1479757549-18672-1-git-send-email-hpous...@reactos.org === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers

The blocksize option is defined in RFC 1783. We now support block sizes between 1 and 1432 bytes, instead of 512 only. Signed-off-by: Hervé Poussineau --- slirp/tftp.c | 26 ++ slirp/tftp.h | 8 +--- 2 files changed, 19 insertions(+), 15

Re: [Qemu-devel] [PULL for-2.8 0/2] target-alpha update

Fetched in submodule path 'roms/qemu-palcode', but it did not contain f3c7e44c70254975df2a00af39701eafbac4d471. Direct fetching of that commit failed. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for

Re: [Qemu-devel] RfC: MAINTAINERS update for qemu drm drivers.

Hi, > Also I think one shared git repo for all of them would be > good. Yep, I'm doing that (see today's drm-qemu pull req @ dri-devel). But, yes, I can place the git repo link in MAINTAINERS too. cheers, Gerd

Re: [Qemu-devel] [PATCH 5/8] quorum: Inline quorum_aio_cb()

On 11/21/2016 11:31 AM, Kevin Wolf wrote: > This is a conversion to a more natural coroutine style and improves the > readability of the driver. > > Signed-off-by: Kevin Wolf > --- > block/quorum.c | 118 > - > 1 file

Re: [Qemu-devel] [kvm-unit-tests PATCH] configure: honour $ARCH and $CROSS_COMPILE

2016-11-21 18:22+, Andre Przywara: > Both environment variables seem to be standard in cross-compilation > environments, especially with Linux. > Let the configure script take those into account when setting the default > values for --arch and --cross-prefix. Explicitly specifying the latter >

Re: [Qemu-devel] RfC: MAINTAINERS update for qemu drm drivers.

On Mon, Nov 21, 2016 at 07:24:34PM +0100, Gerd Hoffmann wrote: > Hi, > > I'm busy updating the MAINTAINERS file for the linux kernel, making sure > I'm listed for all qemu drm drivers (cirrus, bochs, qxl, virtio), so > patches land in my inbox. > > While being at it: I'm wondering whenever it

Re: [Qemu-devel] [PATCH 4/8] quorum: Do cleanup in caller coroutine

On 11/21/2016 11:31 AM, Kevin Wolf wrote: > Instead of calling quorum_aio_finalize() deeply nested in what used > to be an AIO callback, do it in the same functions that allocated the > AIOCB. > > Signed-off-by: Kevin Wolf > Reviewed-by: Alberto Garcia > ---

Re: [Qemu-devel] [PATCH RFC 0/2] numa: allocate CPUs masks dynamically

On Thu, 17 Nov 2016 17:27:20 +1100 Alexey Kardashevskiy wrote: > On 17/11/16 03:02, Igor Mammedov wrote: > > This series removes global MAX_CPUMASK_BITS constant > > so that it won't inderectly influence maximum CPUs count > > supported by different targets. > > > > It replaces

[Qemu-devel] RfC: MAINTAINERS update for qemu drm drivers.

Hi, I'm busy updating the MAINTAINERS file for the linux kernel, making sure I'm listed for all qemu drm drivers (cirrus, bochs, qxl, virtio), so patches land in my inbox. While being at it: I'm wondering whenever it makes sense to also include the qemu-devel list there. I think it would be

[Qemu-devel] [Bug 1643342] Re: not able to passthrough mouse / keyboard

** Description changed: After upgrading from qemu version 2.6.2 to 2.7.9 I can't boot my vm anymore. I get this error: qemu-system-x86_64: -usbdevice host:046d:c227: could not add USB device 'host:046d:c227' This happens with every usb-device I tried. Works in 2.6.2 without any

[Qemu-devel] [kvm-unit-tests PATCH] configure: honour $ARCH and $CROSS_COMPILE

Both environment variables seem to be standard in cross-compilation environments, especially with Linux. Let the configure script take those into account when setting the default values for --arch and --cross-prefix. Explicitly specifying the latter on the configure command line still works as

Re: [Qemu-devel] [PATCH 3/8] quorum: Implement .bdrv_co_readv/writev

On 11/21/2016 11:31 AM, Kevin Wolf wrote: > This converts the quorum block driver from implementing callback-based > interfaces for read/write to coroutine-based ones. This is the first > step that will allow us further simplification of the code. > > Signed-off-by: Kevin Wolf

[Qemu-devel] [Bug 1643619] [NEW] netlink broken on big-endian mips

Public bug reported: Debian QEMU version 2.7.0, but the bug also appears in current git master (commit c36ed06e9159) As the summary says, netlink is completely broken on big-endian mips running qemu-user. Running 'ip route' from within a Debian chroot with QEMU simply hangs. Running amd64

[Qemu-devel] [Bug 1643619] Re: netlink broken on big-endian mips

I also notice fd_trans_unregister does not appear in the socketcall implementation which seems like an oversight. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1643619 Title: netlink broken on

Re: [Qemu-devel] [PATCH] ui/vnc: Fix problem with sending too many bytes as server name

On Mo, 2016-11-21 at 18:25 +0100, Thomas Huth wrote: > If the buffer is not big enough, snprintf() does not return the number > of bytes that have been written to the buffer, but the number of bytes > that would be needed for writing the whole string. By using this value > for the following

Re: [Qemu-devel] [PATCH v2 0/4] xed: add qdevs for each backend, correct pvUSB

Hi Juergen, it would be helpful if you could resend this series with the small changes I requested. But if it is a problem for you, I can do that myself while committing. Cheers, Stefano On Wed, 2 Nov 2016, Juergen Gross wrote: > Trying to use pvUSB in a Xen guest with a qemu emulated USB

[Qemu-devel] [PATCH 8/8] quorum: Inline quorum_fifo_aio_cb()

Inlining the function removes some boilerplace code and replaces recursion by a simple loop, so the code becomes somewhat easier to understand. Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia --- block/quorum.c | 42

[Qemu-devel] [PATCH 5/8] quorum: Inline quorum_aio_cb()

This is a conversion to a more natural coroutine style and improves the readability of the driver. Signed-off-by: Kevin Wolf --- block/quorum.c | 118 - 1 file changed, 57 insertions(+), 61 deletions(-) diff --git

[Qemu-devel] [PATCH 7/8] quorum: Implement .bdrv_co_preadv/pwritev()

This enables byte granularity requests on quorum nodes. Note that the QMP events emitted by the driver are an external API that we were careless enough to define as sector based. The offset and length of requests reported in events are rounded therefore. Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH for-2.8] ui/vnc: Fix problem with sending too many bytes as server name

On 11/21/2016 11:25 AM, Thomas Huth wrote: > If the buffer is not big enough, snprintf() does not return the number > of bytes that have been written to the buffer, but the number of bytes > that would be needed for writing the whole string. By using this value > for the following vnc_write()

[Qemu-devel] [PATCH 3/8] quorum: Implement .bdrv_co_readv/writev

This converts the quorum block driver from implementing callback-based interfaces for read/write to coroutine-based ones. This is the first step that will allow us further simplification of the code. Signed-off-by: Kevin Wolf --- block/quorum.c | 192

[Qemu-devel] [PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites

Replacing it with bdrv_co_pwritev() prepares us for byte granularity requests and gets us rid of the last bdrv_aio_*() user in quorum. Signed-off-by: Kevin Wolf --- block/quorum.c | 46 +++--- 1 file changed, 31 insertions(+), 15

[Qemu-devel] [PATCH 1/8] coroutine: Introduce qemu_coroutine_enter_if_inactive()

In the context of asynchronous work, if we have a worker coroutine that didn't yield, the parent coroutine cannot be reentered because it hasn't yielded yet. In this case we don't even have to reenter the parent because it will see that the work is already done and won't even yield.

[Qemu-devel] [PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev()

This is part of my work that aims to remove the bdrv_aio_*() emulation in io.c. After the series, quorum doesn't only use the preferred interfaces, but the code becomes a little easier to follow and byte granularity requests are supported. There is probably still some potential for additional

[Qemu-devel] [PATCH 2/8] quorum: Remove s from quorum_aio_get() arguments

There is no point in passing the value of bs->opaque in order to overwrite it with itself. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Paolo Bonzini Reviewed-by: Alberto Garcia --- block/quorum.c |

[Qemu-devel] [PATCH 4/8] quorum: Do cleanup in caller coroutine

Instead of calling quorum_aio_finalize() deeply nested in what used to be an AIO callback, do it in the same functions that allocated the AIOCB. Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia --- block/quorum.c | 15 +-- 1 file changed, 9

[Qemu-devel] [PATCH] ui/vnc: Fix problem with sending too many bytes as server name

If the buffer is not big enough, snprintf() does not return the number of bytes that have been written to the buffer, but the number of bytes that would be needed for writing the whole string. By using this value for the following vnc_write() calls, we send some junk at the end of the name in case

Re: [Qemu-devel] [PATCH] qapi: add explicit null to string input and output visitors

On Mon, 21 Nov 2016 10:32:50 -0600 Eric Blake wrote: > On 11/19/2016 02:28 AM, Greg Kurz wrote: > > This may be used for deprecated object properties that are kept for > > backwards compatibility. > > > > Signed-off-by: Greg Kurz > > --- > > > > This is

Re: [Qemu-devel] [RFC v2 3/3] virtio-net: Add MTU feature support

On Mon, Nov 21, 2016 at 01:34:32PM +0100, Maxime Coquelin wrote: > > > On 11/17/2016 11:38 PM, Michael S. Tsirkin wrote: > > On Thu, Nov 17, 2016 at 10:58:07PM +0100, Maxime Coquelin wrote: > > > If negotiated, virtio-net gets the advised MTU from vhost-net, > > > and provides it to the guest

Re: [Qemu-devel] [PATCH 14/17] qmp: add x-debug-block-dirty-bitmap-sha256

On 11/21/2016 09:29 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/dirty-bitmap.c | 5 + > blockdev.c | 33 + > include/block/dirty-bitmap.h | 2 ++ >

Re: [Qemu-devel] [PATCH 07/17] qapi: add dirty-bitmaps migration capability

On 11/21/2016 09:29 AM, Vladimir Sementsov-Ogievskiy wrote: > Reviewed-by: John Snow > Reviewed-by: Eric Blake > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > +++ b/qapi-schema.json > @@ -584,11 +584,13 @@ > #side,

Re: [Qemu-devel] [PATCH v2] docs: add document to explain the usage of vNVDIMM

On Mon, Nov 21, 2016 at 02:00:23PM +0800, Haozhong Zhang wrote: > On 11/09/16 12:35 +, Stefan Hajnoczi wrote: > > On Wed, Nov 09, 2016 at 09:04:48AM +0800, Haozhong Zhang wrote: > > > Signed-off-by: Haozhong Zhang > > > Reviewed-by: Xiao Guangrong

  1   2   >