Re: [Qemu-devel] vhost-user breaks after 96a3d98.

2017-01-03 Thread Jason Wang
On 2017年01月04日 11:26, Jason Wang wrote: On 2017年01月04日 00:27, Michael S. Tsirkin wrote: On Tue, Jan 03, 2017 at 06:28:18PM +0800, Jason Wang wrote: On 2017年01月03日 11:09, Jason Wang wrote: On 2016年12月30日 20:41, Flavio Leitner wrote: Hi, While I was testing vhost-user using OVS 2.5 and

[Qemu-devel] [PATCH RFC v3 2/2] block/qapi: reduce the execution time of qmp_query_blockstats

2017-01-03 Thread Dou Liyang
In order to reduce the execution time, this patch optimize the qmp_query_blockstats(): Remove the next_query_bds function. Remove the bdrv_query_stats function. Remove some judgement sentence. The original qmp_query_blockstats calls next_query_bds to get the next objects in each loops. In the

[Qemu-devel] [PATCH RFC v3 1/2] block/qapi: reduce the coupling between the bdrv_query_stats and bdrv_query_bds_stats

2017-01-03 Thread Dou Liyang
the bdrv_query_stats and bdrv_query_bds_stats functions need to call each other, that increases the coupling. it also makes the program complicated and makes some unnecessary judgements. remove the call from bdrv_query_bds_stats to bdrv_query_stats, just take some recursion to make it clearly.

[Qemu-devel] [PATCH RFC v3 0/2] block/qapi: refactor and optimize the qmp_query_blockstats()

2017-01-03 Thread Dou Liyang
Change log v2 -> v3: 1. Remove the unnecessary code for the bdrv_next_node(). 2. Remove the change of the locking rules. Even if this change can improve the performance, but it may effect the consistency. For the multi-disks guest, we can use the dataplane feature to hold performance

Re: [Qemu-devel] New Year's starting over ... bsd-user

2017-01-03 Thread Thomas Huth
On 03.01.2017 18:11, Sean Bruno wrote: > > > On 01/03/17 09:18, Sean Bruno wrote: >> >> I'm pondering where to start with getting FreeBSD's bsd-user code into >> shape so it could actually be reviewed and accepted now that its sort of >> working again (signal handling fixed finally). >> >> I

Re: [Qemu-devel] [PATCH v2 3/4] migration: disallow migrate_add_blocker during migration

2017-01-03 Thread Ashijeet Acharya
On Fri, Dec 16, 2016 at 4:07 PM, Greg Kurz wrote: > On Fri, 16 Dec 2016 15:23:43 +0530 > Ashijeet Acharya wrote: > >> If a migration is already in progress and somebody attempts >> to add a migration blocker, this should rightly fail. >> >> Add an errp

Re: [Qemu-devel] [PATCH v4 8/8] arm: Add an RX8900 RTC to the ASpeed board

2017-01-03 Thread Andrew Jeffery
On Thu, 2016-12-15 at 16:48 +1100, Alastair D'Silva wrote: > > From: Alastair D'Silva > > Connect an RX8900 RTC to i2c12 of the AST2500 SOC at address 0x32 > > > Signed-off-by: Alastair D'Silva > Signed-off-by: Chris Smart

Re: [Qemu-devel] [PATCH v4 7/8] tests: Test all implemented RX8900 functionality

2017-01-03 Thread Andrew Jeffery
Hi Alastair, Again, small comments below. On Thu, 2016-12-15 at 16:48 +1100, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > Signed-off-by: Alastair D'Silva > --- >  tests/Makefile.include |   2 + >  tests/rx8900-test.c| 882 >

Re: [Qemu-devel] [PATCH v4 6/8] hw/timer: Add Epson RX8900 RTC support

2017-01-03 Thread Alastair D'Silva
On Wed, 2017-01-04 at 15:29 +1030, Andrew Jeffery wrote: > Hi Alastair, > > I have some mostly minor comments below. Ok, I'm removing Chris from the CC list since he's left the team. > > On Thu, 2016-12-15 at 16:48 +1100, Alastair D'Silva wrote: > > > From: Alastair D'Silva

Re: [Qemu-devel] [PATCH v4 6/8] hw/timer: Add Epson RX8900 RTC support

2017-01-03 Thread Andrew Jeffery
Hi Alastair, I have some mostly minor comments below. On Thu, 2016-12-15 at 16:48 +1100, Alastair D'Silva wrote: > > From: Alastair D'Silva > > This patch adds support for the Epson RX8900 I2C RTC. > > The following chip features are implemented: >  - RTC (wallclock

[Qemu-devel] [PATCH] Crypto: fix leak in ivgen essiv init

2017-01-03 Thread Li Qiang
From: Li Qiang On error path, the 'salt' doesn't been freed thus leading a memory leak. This patch avoid this. Signed-off-by: Li Qiang --- crypto/ivgen-essiv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto/ivgen-essiv.c b/crypto/ivgen-essiv.c

[Qemu-devel] [Bug 1317603] Re: qemu-system-ppc does not terminate on VM exit

2017-01-03 Thread Launchpad Bug Tracker
[Expired for qemu (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1317603

[Qemu-devel] [Bug 1119686] Re: Incorrect handling of icebp

2017-01-03 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1119686 Title: Incorrect

[Qemu-devel] [Bug 809912] Re: qemu-kvm -m bigger 4096 aborts with 'Bad ram offset'

2017-01-03 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/809912 Title: qemu-kvm -m

[Qemu-devel] [Bug 322602] Re: Snapshot usage makes qcow2 image unusable due to large tables

2017-01-03 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/322602 Title: Snapshot

[Qemu-devel] [Bug 441672] Re: Windos XP BSOD with HP Photosmart usb device attached

2017-01-03 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/441672 Title: Windos XP

[Qemu-devel] [Bug 612297] Re: qemu-kvm fails to detect mouse while Windows 95 setup

2017-01-03 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/612297 Title: qemu-kvm

[Qemu-devel] [Bug 590552] Re: New default network card doesn't work with tap networking

2017-01-03 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/590552 Title: New default

[Qemu-devel] [Bug 1102027] Re: QED Time travel

2017-01-03 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1102027 Title: QED Time

[Qemu-devel] [Bug 1639225] Re: qcow2 - filesize 8.1Petabyte

2017-01-03 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1639225 Title: qcow2 -

Re: [Qemu-devel] [PATCH 0/4] QOM'ify work for ppc

2017-01-03 Thread David Gibson
On Tue, Jan 03, 2017 at 10:02:21PM +0800, 赵小强 wrote: > Hi,david: > >To my understanding,what must be put in the realize function is >code which depends on property values. What's the benefit of >moving memory region initialization into realize function? I can >not figure out,

Re: [Qemu-devel] [PATCH for-2.9 v3 0/5] Sheepdog cleanups

2017-01-03 Thread Jeff Cody
On Wed, Dec 21, 2016 at 03:07:07PM +0100, Paolo Bonzini wrote: > > > On 29/11/2016 12:32, Paolo Bonzini wrote: > > Cleaning up the code and removing duplication makes it simpler to > > later adapt it for the multiqueue work. > > > > Tested against sheepdog 1.0. I also tested taking snapshots

Re: [Qemu-devel] vhost-user breaks after 96a3d98.

2017-01-03 Thread Jason Wang
On 2017年01月04日 00:27, Michael S. Tsirkin wrote: On Tue, Jan 03, 2017 at 06:28:18PM +0800, Jason Wang wrote: On 2017年01月03日 11:09, Jason Wang wrote: On 2016年12月30日 20:41, Flavio Leitner wrote: Hi, While I was testing vhost-user using OVS 2.5 and DPDK 2.2.0 in the host and testpmd dpdk

[Qemu-devel] [PATCH v2] qemu-thread: fix qemu_thread_set_name() race in qemu_thread_create()

2017-01-03 Thread zhanghailiang
From: Caoxinhua QEMU will crash with the follow backtrace if the new created thread exited before we call qemu_thread_set_name() for it. (gdb) bt #0 0x7f9a68b095d7 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1

Re: [Qemu-devel] [Resend PATCH] The QEMU crashes since invoking qemu_thread_set_name(), the backtrace is:

2017-01-03 Thread Hailiang Zhang
Oops, I deleted the original title carelessly, will send V2. Thanks. On 2017/1/4 0:06, Stefan Hajnoczi wrote: Please follow the conventions for commit messages. QEMU commit messages start with a prefix that identifies the affected component. (Use git-log(1) to check what prefix other people

Re: [Qemu-devel] [PATCH v14 0/2] virtio-crypto: virtio crypto device specification

2017-01-03 Thread Gonglei (Arei)
Hi Stefan, > > Subject: Re: [Qemu-devel] [PATCH v14 0/2] virtio-crypto: virtio crypto device > specification > > On Mon, Dec 26, 2016 at 02:38:29AM +, Gonglei (Arei) wrote: > > Both Alex and Stefan mentioned that the process of create/close a session > > makes we have a least one full

Re: [Qemu-devel] [PATCH V5 1/2] Add a new qmp command to start/stop replication

2017-01-03 Thread Stefano Stabellini
On Tue, 27 Dec 2016, Zhang Chen wrote: > We can call this qmp command to start/stop replication outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 2/6] vga: increase priority of 0xa0000 memory region

2017-01-03 Thread David Gibson
On Tue, Jan 03, 2017 at 11:37:20PM +0100, Hervé Poussineau wrote: > Le 03/01/2017 à 00:02, David Gibson a écrit : > > On Thu, Dec 29, 2016 at 11:12:12PM +0100, Hervé Poussineau wrote: > > > VGA device registers vram as BAR 0. If this BAR is activated as a very > > > low address which > > >

Re: [Qemu-devel] [PATCH 4/6] prep: QOM'ify System I/O

2017-01-03 Thread David Gibson
On Tue, Jan 03, 2017 at 11:51:27PM +0100, Hervé Poussineau wrote: > Le 03/01/2017 à 00:03, David Gibson a écrit : > > On Thu, Dec 29, 2016 at 11:12:14PM +0100, Hervé Poussineau wrote: > > > Part of the functionality is copied from hw/ppc/prep.c. > > > Also add support for board

Re: [Qemu-devel] [PATCH 5/6] prep: add IBM RS/6000 7020 (40p) memory controller

2017-01-03 Thread David Gibson
On Tue, Jan 03, 2017 at 11:55:10PM +0100, Hervé Poussineau wrote: > Le 03/01/2017 à 05:57, David Gibson a écrit : > > On Thu, Dec 29, 2016 at 11:12:15PM +0100, Hervé Poussineau wrote: > > > Signed-off-by: Hervé Poussineau > > > --- > > > default-configs/ppc-softmmu.mak |

Re: [Qemu-devel] [PATCH 5/6] prep: add IBM RS/6000 7020 (40p) memory controller

2017-01-03 Thread Hervé Poussineau
Le 03/01/2017 à 05:57, David Gibson a écrit : On Thu, Dec 29, 2016 at 11:12:15PM +0100, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau --- default-configs/ppc-softmmu.mak | 1 + hw/ppc/Makefile.objs| 1 + hw/ppc/rs6000_mc.c | 232

Re: [Qemu-devel] [PATCH 4/6] prep: QOM'ify System I/O

2017-01-03 Thread Hervé Poussineau
Le 03/01/2017 à 00:03, David Gibson a écrit : On Thu, Dec 29, 2016 at 11:12:14PM +0100, Hervé Poussineau wrote: Part of the functionality is copied from hw/ppc/prep.c. Also add support for board identification/equipment registers. Needs more detail in the commit message. What is system I/O?

Re: [Qemu-devel] [PATCH 2/6] vga: increase priority of 0xa0000 memory region

2017-01-03 Thread Hervé Poussineau
Le 03/01/2017 à 00:02, David Gibson a écrit : On Thu, Dec 29, 2016 at 11:12:12PM +0100, Hervé Poussineau wrote: VGA device registers vram as BAR 0. If this BAR is activated as a very low address which crosses 0xa-0xb, low memory region is not accessible anymore. This fixes display on

Re: [Qemu-devel] vhost-user breaks after 96a3d98.

2017-01-03 Thread Michael S. Tsirkin
On Tue, Jan 03, 2017 at 03:33:12PM -0200, Flavio Leitner wrote: > On Tue, 3 Jan 2017 18:28:18 +0800 > Jason Wang wrote: > > > On 2017年01月03日 11:09, Jason Wang wrote: > > > > > > > > > On 2016年12月30日 20:41, Flavio Leitner wrote: > > >> Hi, > > >> > > >> While I was testing

Re: [Qemu-devel] [PATCH v3] intel_iommu: allow dynamic switch of IOMMU region

2017-01-03 Thread Alex Williamson
On Mon, 26 Dec 2016 10:45:55 +0800 Jason Wang wrote: > On 2016年12月23日 11:26, Peter Xu wrote: > > On Thu, Dec 22, 2016 at 07:34:10PM +0800, Jason Wang wrote: > >> > >> On 2016年12月22日 19:04, Peter Xu wrote: > >>> On Thu, Dec 22, 2016 at 05:52:58PM +0800, Jason Wang wrote:

[Qemu-devel] [PATCH] [m25p80] Abort in case we overrun the internal data buffer

2017-01-03 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- hw/block/m25p80.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index d29ff4c..6c374cf 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -28,6

[Qemu-devel] [PATCH v3] [i.MX] fix CS handling during SPI access.

2017-01-03 Thread Jean-Christophe Dubois
The i.MX SPI device was not de-asserting the CS line at the end of memory access. This triggered a SIGSEGV in Qemu when the sabrelite emulator was acessing a SPI flash memory. Whit this path the CS signal is correctly asserted and deasserted arround memory access. Assertion level is now based

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2017-01-03 Thread Jean-Christophe DUBOIS
Le 03/01/2017 à 18:08, mar.krzeminski a écrit : You may still want to harden the m25p80 code to make sure it doesn't overrun its internal buffer. Yeap, for me it is a bug. I understand you will not finish this patch, won't you ?:) I could give it a shot. JC

Re: [Qemu-devel] [PATCH v1 01/15] block: expose crypto option names / defs to other drivers

2017-01-03 Thread Eric Blake
On 01/03/2017 12:27 PM, Daniel P. Berrange wrote: > The block/crypto.c defines a set of QemuOpts that provide > parameters for encryption. This will also be needed by > the qcow/qcow2 integration, so expose the relevant pieces > in a new block/crypto.h header. > > Signed-off-by: Daniel P.

Re: [Qemu-devel] [PATCH] win32: use glib gpoll if glib >= 2.50

2017-01-03 Thread Stefan Weil
On 01/03/17 20:19, Marc-André Lureau wrote: A fix has been committed in upstream glib commit 210a9796f78eb90f76f1bd6a304e9fea05e97617. (See also related bug https://bugzilla.gnome.org/show_bug.cgi?id=764415) It is desirable to use the glib version instead of qemu copy, since it provides more

Re: [Qemu-devel] [PATCH 2/2] vmxnet3: VMStatify rx/tx q_descr and int_state

2017-01-03 Thread Dr. David Alan Gilbert
* Dmitry Fleytman (dmi...@daynix.com) wrote: > > > > On 16 Dec 2016, at 14:19 PM, Dr. David Alan Gilbert > > wrote: > > > > * Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > >> From: "Dr. David Alan Gilbert" > >> > >> Fairly simple

Re: [Qemu-devel] [PATCH v2 5/5] iotests: chown LUKS device before qemu-io launches

2017-01-03 Thread Eric Blake
On 01/03/2017 11:04 AM, Daniel P. Berrange wrote: > On some distros, whenever you close a block device file > descriptor there is a udev rule that resets the file > permissions. This can race with the test script when > we run qemu-io multiple times against the same block > device. Occassionally

[Qemu-devel] [PATCH] win32: use glib gpoll if glib >= 2.50

2017-01-03 Thread Marc-André Lureau
A fix has been committed in upstream glib commit 210a9796f78eb90f76f1bd6a304e9fea05e97617. (See also related bug https://bugzilla.gnome.org/show_bug.cgi?id=764415) It is desirable to use the glib version instead of qemu copy, since it provides more debugging facilities (G_MAIN_POLL_DEBUG etc),

Re: [Qemu-devel] [PATCH v2 4/5] iotests: add more LUKS hash combination tests

2017-01-03 Thread Eric Blake
On 01/03/2017 11:04 AM, Daniel P. Berrange wrote: > Add tests for sha224, sha512, sha384 and ripemd160 hash > algorithms. > > Signed-off-by: Daniel P. Berrange > --- > tests/qemu-iotests/149 | 10 +- > tests/qemu-iotests/149.out | 482 >

Re: [Qemu-devel] [PATCH v2 3/5] iotests: reduce PBKDF iterations when testing LUKS

2017-01-03 Thread Eric Blake
On 01/03/2017 11:04 AM, Daniel P. Berrange wrote: > By default the PBKDF algorithm used with LUKS is tuned > based on the number of iterations to produce 1 second > of running time. This makes running the I/O test with > the LUKS format orders of magnitude slower than with > qcow2/raw formats. >

Re: [Qemu-devel] [PATCH v2 3/5] iotests: reduce PBKDF iterations when testing LUKS

2017-01-03 Thread Eric Blake
On 01/03/2017 11:04 AM, Daniel P. Berrange wrote: > By default the PBKDF algorithm used with LUKS is tuned > based on the number of iterations to produce 1 second > of running time. This makes running the I/O test with > the LUKS format orders of magnitude slower than with > qcow2/raw formats. >

Re: [Qemu-devel] [PATCH v2 2/5] iotests: fix remainining tests to work with LUKS

2017-01-03 Thread Eric Blake
On 01/03/2017 11:04 AM, Daniel P. Berrange wrote: > The tests 033, 120, 140, 145 and 157 were all broken > when run with LUKS, since they did not correctly use > the required image opts args syntax to specify the > decryption secret. > > Signed-off-by: Daniel P. Berrange >

Re: [Qemu-devel] [PATCH] win32: don't run subprocess tests on Mingw32 platform

2017-01-03 Thread Marc-André Lureau
Hi On Tue, Jun 14, 2016 at 6:34 PM Daniel P. Berrange wrote: > The g_test_trap_subprocess() method does not work on the > Mingw32 platform, causing the test-qdev-global-props > test case to abort > > (test-logging.exe:230): GLib-ERROR **: g_test_trap_subprocess() > failed:

[Qemu-devel] [PATCH v1 13/15] iotests: enable tests 134 and 158 to work with qcow (v1)

2017-01-03 Thread Daniel P. Berrange
The 138 and 158 iotests exercise the legacy qcow2 aes encryption code path. With a few simple tweaks they can exercise the same feature in qcow (v1). Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/134 | 10 +- tests/qemu-iotests/158 | 2 +- 2 files

[Qemu-devel] [PATCH v1 07/15] iotests: fix 097 when run with qcow

2017-01-03 Thread Daniel P. Berrange
The previous commit: commit a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd Author: Eric Blake Date: Mon Dec 5 09:49:34 2016 -0600 qcow2: Don't strand clusters near 2G intervals during commit extended the 097 test case so that it did two passes, once with an internal

[Qemu-devel] [PATCH v1 15/15] block: remove all encryption handling APIs

2017-01-03 Thread Daniel P. Berrange
Now that all encryption keys must be provided upfront via the QCryptoSecret API and associated block driver properties there is no need for any explicit encryption handling APIs in the block layer. Encryption can be handled transparently within the block driver. We only retain an API for querying

[Qemu-devel] [PATCH v1 06/15] iotests: skip 048 with qcow which doesn't support resize

2017-01-03 Thread Daniel P. Berrange
Test 048 is designed to verify data preservation during an image resize. The qcow (v1) format impl has never supported resize so always fails. Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/048 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v1 08/15] qcow: make encrypt_sectors encrypt in place

2017-01-03 Thread Daniel P. Berrange
Instead of requiring separate input/output buffers for encrypting data, change encrypt_sectors() to assume use of a single buffer, encrypting in place. One current caller all uses the same buffer for input/output already and the other two callers are easily converted todo so. Signed-off-by:

[Qemu-devel] [PATCH v1 14/15] block: rip out all traces of password prompting

2017-01-03 Thread Daniel P. Berrange
Now that qcow & qcow2 are wired up to get encryption keys via the QCryptoSecret object, nothing is relying on the interactive prompting for passwords. All the code related to password prompting can thus be ripped out. Signed-off-by: Daniel P. Berrange --- hmp.c

[Qemu-devel] [PATCH v1 12/15] qcow2: add support for LUKS encryption format

2017-01-03 Thread Daniel P. Berrange
This adds support for using LUKS as an encryption format with the qcow2 file. The use of the existing 'encryption=on' parameter is replaced by a new parameter 'encryption-format' which takes the values 'aes' or 'luks'. e.g. # qemu-img create --object secret,data=123456,id=sec0 \ -f qcow2

[Qemu-devel] [PATCH v1 10/15] qcow2: make qcow2_encrypt_sectors encrypt in place

2017-01-03 Thread Daniel P. Berrange
Instead of requiring separate input/output buffers for encrypting data, change qcow2_encrypt_sectors() to assume use of a single buffer, encrypting in place. The current callers all used the same buffer for input/output already. Reviewed-by: Eric Blake Reviewed-by: Fam Zheng

[Qemu-devel] [PATCH v1 11/15] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-01-03 Thread Daniel P. Berrange
This converts the qcow2 driver to make use of the QCryptoBlock APIs for encrypting image content, using the legacyy QCow2 AES scheme. With this change it is now required to use the QCryptoSecret object for providing passwords, instead of the current block password APIs / interactive prompting.

[Qemu-devel] [PATCH v1 09/15] qcow: convert QCow to use QCryptoBlock for encryption

2017-01-03 Thread Daniel P. Berrange
This converts the qcow2 driver to make use of the QCryptoBlock APIs for encrypting image content. This is only wired up to permit use of the legacy QCow encryption format. Users who wish to have the strong LUKS format should switch to qcow2 instead. With this change it is now required to use the

[Qemu-devel] [PATCH v1 05/15] iotests: skip 042 with qcow which dosn't support zero sized images

2017-01-03 Thread Daniel P. Berrange
Test 042 is designed to verify operation with zero sized images. Such images are not supported with qcow (v1), so this test has always failed. Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/042 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v1 03/15] qcow: document another weakness of qcow AES encryption

2017-01-03 Thread Daniel P. Berrange
Document that use of guest virtual sector numbers as the basis for the initialization vectors is a potential weakness, when combined with internal snapshots or multiple images using the same passphrase. Signed-off-by: Daniel P. Berrange --- qemu-img.texi | 9 + 1

[Qemu-devel] [PATCH v1 04/15] qcow: require image size to be > 1 for new images

2017-01-03 Thread Daniel P. Berrange
The qcow driver refuses to open images which are less than 2 bytes in size, but will happily create such images. Add a check in the create path to avoid this discrepancy. Signed-off-by: Daniel P. Berrange --- block/qcow.c | 6 ++ 1 file changed, 6 insertions(+) diff

[Qemu-devel] [PATCH v1 00/15] Convert QCow[2] to QCryptoBlock & add LUKS support

2017-01-03 Thread Daniel P. Berrange
This series is a continuation of previous work to support LUKS in QEMU. The existing merged code supports LUKS as a standalone driver which can be layered over/under any other QEMU block device driver. This works well when using LUKS over protocol drivers (file, rbd, iscsi, etc, etc), but has some

[Qemu-devel] [PATCH v1 02/15] block: add ability to set a prefix for opt names

2017-01-03 Thread Daniel P. Berrange
When integrating the crypto support with qcow/qcow2, we don't want to use the bare LUKS option names "hash-alg", "key-secret", etc. We want to namespace them "luks-hash-alg", "luks-key-secret" so that they don't clash with any general qcow options at a later date. Signed-off-by: Daniel P.

[Qemu-devel] [PATCH v1 01/15] block: expose crypto option names / defs to other drivers

2017-01-03 Thread Daniel P. Berrange
The block/crypto.c defines a set of QemuOpts that provide parameters for encryption. This will also be needed by the qcow/qcow2 integration, so expose the relevant pieces in a new block/crypto.h header. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 61

[Qemu-devel] [PATCH v2 1/2] Do endian swapping.

2017-01-03 Thread Michal Suchanek
This allows running big endian and little endian guest side by side using cut & paste between them. There is a general design idea that swapping should come as close to virtio_read/virtio_write as possible. In particular, the protocol between vdagent and vdagentd is guest-specific and in native

[Qemu-devel] [PATCH v2 2/2] Quiet uninitialized variable warning.

2017-01-03 Thread Michal Suchanek
Signed-off-by: Michal Suchanek --- src/vdagentd/vdagentd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c index 991514e..60a866e 100644 --- a/src/vdagentd/vdagentd.c +++ b/src/vdagentd/vdagentd.c @@ -334,6 +334,7 @@ static

Re: [Qemu-devel] New Year's starting over ... bsd-user

2017-01-03 Thread Sean Bruno
On 01/03/17 09:18, Sean Bruno wrote: > > I'm pondering where to start with getting FreeBSD's bsd-user code into > shape so it could actually be reviewed and accepted now that its sort of > working again (signal handling fixed finally). > > I almost feel like the existing code should be purged,

Re: [Qemu-devel] vhost-user breaks after 96a3d98.

2017-01-03 Thread Flavio Leitner
On Tue, 3 Jan 2017 18:28:18 +0800 Jason Wang wrote: > On 2017年01月03日 11:09, Jason Wang wrote: > > > > > > On 2016年12月30日 20:41, Flavio Leitner wrote: > >> Hi, > >> > >> While I was testing vhost-user using OVS 2.5 and DPDK 2.2.0 in the > >> host and testpmd dpdk 2.2.0 in

Re: [Qemu-devel] [PATCH v2 1/5] iotests: skip 159 & 170 with luks format

2017-01-03 Thread Eric Blake
On 01/03/2017 11:04 AM, Daniel P. Berrange wrote: > While the qemu-img dd command does accept --image-opts > this is not sufficient to make it work with the LUKS > image yet. This is because bdrv_create() still always > requires the non-image-opts syntax. > > Thus we must skip 159/170 with luks

Re: [Qemu-devel] [PATCH v2] iotests: record separate timings per format, protocol pair

2017-01-03 Thread Eric Blake
On 01/03/2017 10:05 AM, Daniel P. Berrange wrote: > The 'check' program records timings for each test that > is run. These timings are only valid, however, for a > particular format/protocol combination. So if frequently > running 'check' with a variety of different formats or > protocols, the

[Qemu-devel] [PATCH v2 3/5] iotests: reduce PBKDF iterations when testing LUKS

2017-01-03 Thread Daniel P. Berrange
By default the PBKDF algorithm used with LUKS is tuned based on the number of iterations to produce 1 second of running time. This makes running the I/O test with the LUKS format orders of magnitude slower than with qcow2/raw formats. When creating LUKS images, set the iteration time to a 10ms to

Re: [Qemu-devel] [PATCH 3/3] fix qmp/hmp query-memdev not repporting IDs of memory backends

2017-01-03 Thread Igor Mammedov
On Tue, 3 Jan 2017 09:34:40 -0600 Eric Blake wrote: > On 01/02/2017 09:44 AM, Igor Mammedov wrote: > > s/repporting/reporting/ in the subject > > > Do it by adding 'id' property to hostmem backends and fetch it > > in query-memdev from object directly. > > > >

[Qemu-devel] [PATCH] scsi-block: fix direction of BYTCHK test for VERIFY commands

2017-01-03 Thread Paolo Bonzini
The direction is wrong; scsi_block_is_passthrough returns false for commands that *can* use sglists. Reported-by: Zhang Qian Fixes: 8fdc7839e40f43a426bc7e858cf1dbfe315a3804 Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PATCH v2 4/5] iotests: add more LUKS hash combination tests

2017-01-03 Thread Daniel P. Berrange
Add tests for sha224, sha512, sha384 and ripemd160 hash algorithms. Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/149 | 10 +- tests/qemu-iotests/149.out | 482 - 2 files changed, 484 insertions(+), 8 deletions(-)

Re: [Qemu-devel] [PATCH v2] [i.MX] fix CS handling during SPI access.

2017-01-03 Thread mar.krzeminski
Hello JC, W dniu 02.01.2017 o 22:11, Jean-Christophe Dubois pisze: The i.MX SPI device was not de-asserting the CS line at the end of memory access. This triggered a SIGSEGV in Qemu when the sabrelite emulator was acessing a SPI flash memory. Whit this path the CS signal is correctly asserted

Re: [Qemu-devel] [PATCH] scsi-disk: fix crash on VERIFY command

2017-01-03 Thread Paolo Bonzini
On 03/01/2017 10:58, Zhang Qian wrote: > > At 2017-01-03 17:38:49, Paolo Bonzini wrote: >> >> >>On 03/01/2017 09:12, Zhang Qian wrote: >>> yes, you are right. >>> The scenarios of problem is >>> a scsi-disk object receives VERIFY command with BYTCHK bit being zero, >>>

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2017-01-03 Thread mar.krzeminski
W dniu 02.01.2017 o 22:24, Jean-Christophe DUBOIS pisze: Le 30/12/2016 à 19:09, mar.krzeminski a écrit : Can you check spi controller model code? I'll double check. But why is the SPI memory/device even responding if CS is not set ? Looking at ssi code it should not. Flash (so the m25p80)

[Qemu-devel] [PATCH v2 2/5] iotests: fix remainining tests to work with LUKS

2017-01-03 Thread Daniel P. Berrange
The tests 033, 120, 140, 145 and 157 were all broken when run with LUKS, since they did not correctly use the required image opts args syntax to specify the decryption secret. Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/033 | 16

Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2017-01-03 Thread Eduardo Habkost
(CCing libvir-list and Laine) On Tue, Jan 03, 2017 at 05:53:27PM +0100, Igor Mammedov wrote: > On Tue, 3 Jan 2017 17:10:15 +0100 > Paolo Bonzini wrote: > > > > > > > On 03/01/2017 15:22, Eduardo Habkost wrote: > > >> I didn't know that. Is this documented somewhere? > >

[Qemu-devel] [PATCH v2 0/5] Improve I/O tests coverage of LUKS

2017-01-03 Thread Daniel P. Berrange
The main goal of this series is to get the I/O tests passing 100% with LUKS when run with './check -luks'. It also adds a few more combinations to the LUKS/dmcrypt interoperability test. To make LUKS testing not quite as slow, we drop the PBKDF iteration count down to a very small value. This

Re: [Qemu-devel] [PATCH] qemu-img: add support for --object with 'dd' command

2017-01-03 Thread Eric Blake
On 01/03/2017 11:00 AM, Daniel P. Berrange wrote: > The qemu-img dd command added --image-opts support, but missed > the corresponding --object support. This prevented passing > secrets (eg auth passwords) needed by certain disk images. > > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] Performance about x-data-plane

2017-01-03 Thread Weiwei Jia
Hi Stefan, Thanks for your reply. On Tue, Jan 3, 2017 at 10:50 AM, Stefan Hajnoczi wrote: > On Thu, Dec 22, 2016 at 01:34:47AM -0500, Weiwei Jia wrote: >> With QEMU x-data-plane, I find the performance has not been improved >> very much. Please see following two settings. >

[Qemu-devel] [PATCH v2 5/5] iotests: chown LUKS device before qemu-io launches

2017-01-03 Thread Daniel P. Berrange
On some distros, whenever you close a block device file descriptor there is a udev rule that resets the file permissions. This can race with the test script when we run qemu-io multiple times against the same block device. Occassionally the second qemu-io invokation will find udev has reset the

[Qemu-devel] [PATCH v2 1/5] iotests: skip 159 & 170 with luks format

2017-01-03 Thread Daniel P. Berrange
While the qemu-img dd command does accept --image-opts this is not sufficient to make it work with the LUKS image yet. This is because bdrv_create() still always requires the non-image-opts syntax. Thus we must skip 159/170 with luks for now Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH] qemu-img: add support for --object with 'dd' command

2017-01-03 Thread Daniel P. Berrange
The qemu-img dd command added --image-opts support, but missed the corresponding --object support. This prevented passing secrets (eg auth passwords) needed by certain disk images. Signed-off-by: Daniel P. Berrange --- qemu-img.c | 16 1 file changed, 16

Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2017-01-03 Thread Igor Mammedov
On Tue, 3 Jan 2017 17:10:15 +0100 Paolo Bonzini wrote: > > > On 03/01/2017 15:22, Eduardo Habkost wrote: > >> I didn't know that. Is this documented somewhere? > >> Is it actually used by any existing software? > > not that I know of. But users should be fixed if they are

Re: [Qemu-devel] [PATCH 1/3] cleanup: remove not used header

2017-01-03 Thread Igor Mammedov
On Tue, 3 Jan 2017 16:26:16 +0100 Andreas Färber wrote: > Am 03.01.2017 um 16:25 schrieb Eric Blake: > > On 01/02/2017 09:44 AM, Igor Mammedov wrote: > > > > perhaps s/not used/unused/ in the subject > > ... and qom: instead of cleanup: if this gets re-spun. sure > >

Re: [Qemu-devel] [RFC]virtio-blk: add disk-name device property

2017-01-03 Thread Eric Blake
On 12/29/2016 08:41 PM, Junkang Fu wrote: >>From 74e913fc41ea98d1dde692175f1e3fb6729342aa Mon Sep 17 00:00:00 2001 > From: "junkang.fjk" > Date: Wed, 24 Aug 2016 19:36:53 +0800 > Subject: [PATCH] virtio-blk: add disk-name device property > > Current virtio-blk disk

Re: [Qemu-devel] (no subject)

2017-01-03 Thread Stefan Hajnoczi
On Mon, Jan 02, 2017 at 09:03:55PM +0900, morgenlette madeBy wrote: > I got problem using QEMU. > > when i turn on virtual machine, > > this message was shown, > > > virsh: error while loading shared libraries: libapparmor.so.1: cannot open > shared object file: No such file or directory > >

Re: [Qemu-devel] Speed menu for GTK interfaace

2017-01-03 Thread Programmingkid
On Jan 3, 2017, at 3:59 AM, Gerd Hoffmann wrote: > On So, 2017-01-01 at 13:15 -0500, Programmingkid wrote: >> Hello, I was wondering if you would accept a patch that added a Speed >> menu to the GTK interface. This would allow the user to change how >> much CPU time the emulated CPU would see.

Re: [Qemu-devel] [PATCH] ui/gtk: fix crash at startup when no console is available

2017-01-03 Thread Stefan Hajnoczi
On Sun, Jan 01, 2017 at 10:39:45AM +0100, Hervé Poussineau wrote: > This patch fixes a segfault at QEMU startup, introduced in > a08156321ab9a7d2fed9ee77dbfeea2a61ffd153. > gd_vc_find_current() return NULL, which is dereferenced without checking it. > > While at it, disable the whole 'View' menu

Re: [Qemu-devel] [RFC]virtio-blk: add disk-name device property

2017-01-03 Thread Stefan Hajnoczi
On Fri, Dec 30, 2016 at 10:41:35AM +0800, Junkang Fu wrote: > From 74e913fc41ea98d1dde692175f1e3fb6729342aa Mon Sep 17 00:00:00 2001 > From: "junkang.fjk" > Date: Wed, 24 Aug 2016 19:36:53 +0800 > Subject: [PATCH] virtio-blk: add disk-name device property > > Current

Re: [Qemu-devel] vhost-user breaks after 96a3d98.

2017-01-03 Thread Michael S. Tsirkin
On Tue, Jan 03, 2017 at 06:28:18PM +0800, Jason Wang wrote: > > > On 2017年01月03日 11:09, Jason Wang wrote: > > > > > > On 2016年12月30日 20:41, Flavio Leitner wrote: > > > Hi, > > > > > > While I was testing vhost-user using OVS 2.5 and DPDK 2.2.0 in the > > > host and testpmd dpdk 2.2.0 in the

[Qemu-devel] New Year's starting over ... bsd-user

2017-01-03 Thread Sean Bruno
I'm pondering where to start with getting FreeBSD's bsd-user code into shape so it could actually be reviewed and accepted now that its sort of working again (signal handling fixed finally). I almost feel like the existing code should be purged, except that it gives a good history (and this

Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2017-01-03 Thread Paolo Bonzini
On 03/01/2017 15:22, Eduardo Habkost wrote: >> I didn't know that. Is this documented somewhere? >> Is it actually used by any existing software? > not that I know of. But users should be fixed if they are not using it. > > I see. The problem is that the mechanism is undocumented, > untested,

Re: [Qemu-devel] [Resend PATCH] The QEMU crashes since invoking qemu_thread_set_name(), the backtrace is:

2017-01-03 Thread Stefan Hajnoczi
Please follow the conventions for commit messages. QEMU commit messages start with a prefix that identifies the affected component. (Use git-log(1) to check what prefix other people have used for the file(s) you touched.) The commit message should be brief and doesn't need to be a full

[Qemu-devel] [PATCH v2] iotests: record separate timings per format, protocol pair

2017-01-03 Thread Daniel P. Berrange
The 'check' program records timings for each test that is run. These timings are only valid, however, for a particular format/protocol combination. So if frequently running 'check' with a variety of different formats or protocols, the times printed can be very misleading. Instead of having a

Re: [Qemu-devel] Proposal for 2.9 release schedule

2017-01-03 Thread Paolo Bonzini
On 03/01/2017 16:53, Stefan Hajnoczi wrote: > On Fri, Dec 23, 2016 at 03:15:58PM +0100, Paolo Bonzini wrote: >> Considering that Easter is on April 16th, we'd probably want to have the >> release before that date even in case of a slip. >> >> On the other hand, the Christmas / New Year break

Re: [Qemu-devel] Qemu NVME ubuntu 16.04 setup problems

2017-01-03 Thread Stefan Hajnoczi
On Mon, Dec 26, 2016 at 01:59:13PM +0530, Gadre Nayan wrote: > I am trying to test SPDK on a Virtual Machine with NVME support. I do not > have NVME cards on the Host hence wanted to simulate the Hardware, I have > install nvmeqemu (https://github.com/nvmeqemu/nvmeqemu) for that purpose. That

Re: [Qemu-devel] Proposal for 2.9 release schedule

2017-01-03 Thread Stefan Hajnoczi
On Fri, Dec 23, 2016 at 03:15:58PM +0100, Paolo Bonzini wrote: > Considering that Easter is on April 16th, we'd probably want to have the > release before that date even in case of a slip. > > On the other hand, the Christmas / New Year break here means that we'll > have to make the development

  1   2   >