[Qemu-devel] [Bug 1656710] Re: Please support Ctrl-Alt-= to zoom in

2017-01-15 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1656710 Title: Please support Ctrl-Alt-= to zoom in Status in QEMU: New Bug description:

Re: [Qemu-devel] [PATCH RFC v3 12/14] intel_iommu: do replay when context invalidate

2017-01-15 Thread Jason Wang
On 2017年01月16日 15:43, Peter Xu wrote: On Mon, Jan 16, 2017 at 01:53:54PM +0800, Jason Wang wrote: On 2017年01月13日 11:06, Peter Xu wrote: Before this one we only invalidate context cache when we receive context entry invalidations. However it's possible that the invalidation also contains a

Re: [Qemu-devel] [PATCH RFC v3 13/14] intel_iommu: allow dynamic switch of IOMMU region

2017-01-15 Thread Peter Xu
On Mon, Jan 16, 2017 at 02:20:31PM +0800, Jason Wang wrote: [...] > >diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > >index fd75112..2596f11 100644 > >--- a/hw/i386/intel_iommu.c > >+++ b/hw/i386/intel_iommu.c > >@@ -1343,9 +1343,49 @@ static void

Re: [Qemu-devel] [PATCH] ahci: advertise HOST_CAP_64

2017-01-15 Thread Ladi Prosek
On Fri, Jan 13, 2017 at 8:15 PM, John Snow wrote: > > > On 01/13/2017 02:01 PM, Ladi Prosek wrote: >> On Fri, Jan 13, 2017 at 7:31 PM, John Snow wrote: >>> >>> >>> On 01/13/2017 01:12 PM, Ladi Prosek wrote: On Fri, Jan 13, 2017 at 6:23 PM, John Snow

Re: [Qemu-devel] [PATCH RFC v3 11/14] intel_iommu: provide its own replay() callback

2017-01-15 Thread Jason Wang
On 2017年01月16日 15:31, Peter Xu wrote: On Fri, Jan 13, 2017 at 05:26:06PM +0800, Jason Wang wrote: On 2017年01月13日 11:06, Peter Xu wrote: The default replay() don't work for VT-d since vt-d will have a huge default memory region which covers address range 0-(2^64-1). This will normally bring

Re: [Qemu-devel] [PATCH RFC v3 12/14] intel_iommu: do replay when context invalidate

2017-01-15 Thread Peter Xu
On Mon, Jan 16, 2017 at 01:53:54PM +0800, Jason Wang wrote: > > > On 2017年01月13日 11:06, Peter Xu wrote: > >Before this one we only invalidate context cache when we receive context > >entry invalidations. However it's possible that the invalidation also > >contains a domain switch (only if

Re: [Qemu-devel] [PATCH RFC v3 09/14] memory: introduce memory_region_notify_one()

2017-01-15 Thread Jason Wang
On 2017年01月16日 15:08, Peter Xu wrote: On Fri, Jan 13, 2017 at 03:58:59PM +0800, Jason Wang wrote: On 2017年01月13日 11:06, Peter Xu wrote: Generalizing the notify logic in memory_region_notify_iommu() into a single function. This can be further used in customized replay() functions for IOMMUs.

Re: [Qemu-devel] [PATCH RFC v3 11/14] intel_iommu: provide its own replay() callback

2017-01-15 Thread Peter Xu
On Fri, Jan 13, 2017 at 05:26:06PM +0800, Jason Wang wrote: > > > On 2017年01月13日 11:06, Peter Xu wrote: > >The default replay() don't work for VT-d since vt-d will have a huge > >default memory region which covers address range 0-(2^64-1). This will > >normally bring a dead loop when guest

Re: [Qemu-devel] [PATCH RFC v3 09/14] memory: introduce memory_region_notify_one()

2017-01-15 Thread Peter Xu
On Fri, Jan 13, 2017 at 03:58:59PM +0800, Jason Wang wrote: > > > On 2017年01月13日 11:06, Peter Xu wrote: > >Generalizing the notify logic in memory_region_notify_iommu() into a > >single function. This can be further used in customized replay() > >functions for IOMMUs. > > > >Signed-off-by: Peter

Re: [Qemu-devel] [PATCH v3 2/2] memory: hmp: add "-f" for "info mtree"

2017-01-15 Thread Peter Xu
On Fri, Jan 13, 2017 at 06:19:10PM +, Dr. David Alan Gilbert wrote: [...] > > -void mtree_info(fprintf_function mon_printf, void *f) > > +static void mtree_print_flatview(fprintf_function p, void *f, > > + AddressSpace *as) > > +{ > > +FlatView *view =

Re: [Qemu-devel] [PATCH] cryptodev: setiv only when really need

2017-01-15 Thread Gonglei (Arei)
> > From: longpeng > Sent: Saturday, January 14, 2017 2:28 PM > To: Gonglei (Arei) > Cc: Wubin (H); Zhoujian (jay, Euler); qemu-devel@nongnu.org; longpeng > Subject: [PATCH] cryptodev: setiv only when really need > > ECB mode cipher doesn't need IV, if we setiv for it then qemu > crypto API would

Re: [Qemu-devel] [PATCH RFC v3 14/14] intel_iommu: enable vfio devices

2017-01-15 Thread Jason Wang
On 2017年01月13日 11:06, Peter Xu wrote: This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some content, and added my

Re: [Qemu-devel] [PATCH RFC v3 13/14] intel_iommu: allow dynamic switch of IOMMU region

2017-01-15 Thread Jason Wang
On 2017年01月13日 11:06, Peter Xu wrote: This is preparation work to finally enabled dynamic switching ON/OFF for VT-d protection. The old VT-d codes is using static IOMMU address space, and that won't satisfy vfio-pci device listeners. Let me explain. vfio-pci devices depend on the memory

Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

2017-01-15 Thread Xiao Guangrong
On 01/14/2017 02:02 AM, Eduardo Habkost wrote: On Fri, Jan 13, 2017 at 01:17:27PM +, Stefan Hajnoczi wrote: On Fri, Jan 13, 2017 at 07:56:51PM +0800, Haozhong Zhang wrote: The missing of 'nvdimm' in the machine type option '-M' means NVDIMM is disabled. QEMU should refuse to plug any

Re: [Qemu-devel] [PATCH RFC v3 12/14] intel_iommu: do replay when context invalidate

2017-01-15 Thread Jason Wang
On 2017年01月13日 11:06, Peter Xu wrote: Before this one we only invalidate context cache when we receive context entry invalidations. However it's possible that the invalidation also contains a domain switch (only if cache-mode is enabled for vIOMMU). So let's check for CM before replaying?

Re: [Qemu-devel] [PATCH] Makefile: Fix owner and group for qemu-version.h.tmp

2017-01-15 Thread Fam Zheng
On Sun, 01/15 18:03, Lin Ma wrote: > By commit 67a1de0d, When we perform 'git pull && make && sudo make install', > In 'make' stage a qemu-version.h.tmp will be generated. If the content of > qemu-version.h.tmp and qemu-version.h aren't consistent, The > qemu-version.h.tmp > will be renamed to

Re: [Qemu-devel] [PATCH v3 1/1] block/vmdk: Fix the endian problem of buf_len and lba

2017-01-15 Thread Fam Zheng
On Mon, 01/16 10:38, liujing wrote: > Dears, > > We would like to know if this patch will be pulled > > into upstream or what else we need to do for it? > > Because for upstream, the qemu-iotests case 055 still failed. Kevin, would you like to take this or should I do it? Fam > > Thanks. >

Re: [Qemu-devel] about post copy recovery

2017-01-15 Thread Li, Liang Z
> * Li, Liang Z (liang.z...@intel.com) wrote: > > > > Hi David, > > > > I remembered some guys wanted to solve the issue of post copy recovery > when network broken down, do you know latest status? > > Hi Liang, > Yes, Haris looked at it as part of GSoC, the latest version is what was >

Re: [Qemu-devel] [RFC PATCH 01/17] powerpc/cpu-models: rename ISAv3.00 logical PVR definition

2017-01-15 Thread David Gibson
On Fri, Jan 13, 2017 at 05:28:07PM +1100, Suraj Jitindar Singh wrote: > This logical PVR value now corresponds to ISA version 3.00 so rename it > accordingly. > > Signed-off-by: Suraj Jitindar Singh This one stands on its own, so I've applied it to ppc-for-2.9 already.

Re: [Qemu-devel] [PATCH V4 net-next] vhost_net: device IOTLB support

2017-01-15 Thread Jason Wang
On 2017年01月14日 00:30, Michael S. Tsirkin wrote: On Fri, Jan 13, 2017 at 10:45:09AM +0800, Jason Wang wrote: On 2017年01月12日 22:17, Michael S. Tsirkin wrote: On Wed, Jan 11, 2017 at 12:32:12PM +0800, Jason Wang wrote: This patches implements Device IOTLB support for vhost kernel. This is

Re: [Qemu-devel] [PATCH v3 1/1] block/vmdk: Fix the endian problem of buf_len and lba

2017-01-15 Thread liujing
Dears, We would like to know if this patch will be pulled into upstream or what else we need to do for it? Because for upstream, the qemu-iotests case 055 still failed. Thanks. Jing On 12/16/2016 01:20 PM, QingFeng Hao wrote: The problem was triggered by qemu-iotests case 055. It failed

Re: [Qemu-devel] [PATCH v4] monitor: Fix crashes when using HMP commands without CPU

2017-01-15 Thread David Gibson
On Fri, Jan 13, 2017 at 01:12:35PM +0100, Thomas Huth wrote: > When running certain HMP commands ("info registers", "info cpustats", > "info tlb", "nmi", "memsave" or dumping virtual memory) with the "none" > machine, QEMU crashes with a segmentation fault. This happens because the > "none"

[Qemu-devel] [Bug 1656711] [NEW] GTK3 interface doesn't zoom-to-fit by default

2017-01-15 Thread Josh Triplett
Public bug reported: The SDL interface automatically scales the video output to match the window size. The GTK3 interface has an off-by-default option "Zoom To Fit" for that. As far as I can tell, no command-line option exists to turn that option on. That makes it harder to quickly zoom a

[Qemu-devel] [Bug 1656710] [NEW] Please support Ctrl-Alt-= to zoom in

2017-01-15 Thread Josh Triplett
Public bug reported: With the GTK3 interface, qemu-system supports pressing Ctrl-Alt-plus to zoom in and Ctrl-Alt-minus to zoom out. However, unlike many programs that support similar zoom hotkeys, qemu-system actually requires using '+', making the hotkey Ctrl-Alt-Shift-= . Most programs with

Re: [Qemu-devel] implementing architectural timers using QEMU timers

2017-01-15 Thread Max Filippov
On Thu, Jan 12, 2017 at 3:28 AM, Pavel Dovgalyuk wrote: >> From: Max Filippov [mailto:jcmvb...@gmail.com] >> On Tue, Jan 10, 2017 at 12:31 AM, Pavel Dovgalyuk wrote: >> >> From: Max Filippov [mailto:jcmvb...@gmail.com] >> > >> >> I'm trying to reimplement

[Qemu-devel] [PATCH] target/xtensa: tests: clean up interrupt tests

2017-01-15 Thread Max Filippov
Don't use hardcoded software interrupt masks, use XCHAL macros. Mask off timer interrupt bits that are not checked for. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_interrupt.S | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH 1/2] target/xtensa: implement MEMCTL SR

2017-01-15 Thread Max Filippov
MEMCTL SR controls zero overhead loop buffer and number of ways enabled in L1 caches. Signed-off-by: Max Filippov --- target/xtensa/cpu.c | 1 + target/xtensa/cpu.h | 19 +++ target/xtensa/helper.h | 1 + target/xtensa/op_helper.c

[Qemu-devel] [PATCH 2/2] target/xtensa: tests: add memctl test

2017-01-15 Thread Max Filippov
Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_sr.S | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/xtensa/test_sr.S b/tests/tcg/xtensa/test_sr.S index 4fac46e..42e3e5e 100644 --- a/tests/tcg/xtensa/test_sr.S +++ b/tests/tcg/xtensa/test_sr.S @@ -44,6

[Qemu-devel] [PATCH] target/xtensa: fix ICACHE/DCACHE options detection

2017-01-15 Thread Max Filippov
Configuration overlay does not explicitly say whether there are ICACHE and DCACHE in the core. Current code uses XCHAL_[ID]CACHE_WAYS to detect if corresponding cache option is enabled, but that's not correct: on cores without cache these macros are defined as 1, not as 0. Check

[Qemu-devel] [PATCH 2/7] target/xtensa: support icount

2017-01-15 Thread Max Filippov
Delimit each instruction that may access timers or IRQ state with qemu_io_start/qemu_io_end, so that qemu-system-xtensa could be run with -icount option. Raise EXCP_YIELD after CCOMPARE reprogramming to let tcg_cpu_exec recalculate how long this CPU is allowed to run. RSR now may need to

[Qemu-devel] [PATCH 5/7] target/xtensa: tests: fix timer tests

2017-01-15 Thread Max Filippov
Don't expect that CCOUNT increments are equal to the number of executed instructions. Verify that timer interrupt does not fire before the programmed CCOMPARE value and does fire after. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_timer.S | 61

[Qemu-devel] [PATCH 7/7] target/xtensa: tests: add ccount write tests

2017-01-15 Thread Max Filippov
Check that CCOUNT SR is writable and that CCOMPARE timers are updated when CCOUNT is written to. Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_timer.S | 34 ++ 1 file changed, 34 insertions(+) diff --git

[Qemu-devel] [PATCH 0/2] target/xtensa: implement MEMCTL SR

2017-01-15 Thread Max Filippov
Hello, this series implements MEMCTL special register and adds a test for it. Max Filippov (2): target/xtensa: implement MEMCTL SR target/xtensa: tests: add memctl test target/xtensa/cpu.c | 1 + target/xtensa/cpu.h | 19 +++ target/xtensa/helper.h

[Qemu-devel] [PATCH 4/7] target/xtensa: tests: run tests with icount

2017-01-15 Thread Max Filippov
Timer tests expect certain determinism in CCOUNT updates and timer interrupts firing. Run QEMU with -icount to get deterministic results. Signed-off-by: Max Filippov --- tests/tcg/xtensa/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 1/7] target/xtensa: refactor CCOUNT/CCOMPARE

2017-01-15 Thread Max Filippov
Xtensa cores may have a register (CCOUNT) that counts core clock cycles. It may also have a number of registers (CCOMPAREx); when CCOUNT value passes the value of CCOMPAREx, timer interrupt x is raised. Currently xtensa target counts a number of completed instructions and assumes that for CCOUNT

[Qemu-devel] [PATCH 0/7] target/xtensa: refactor timers

2017-01-15 Thread Max Filippov
Hello, this series reimplements xtensa CCOUNT/CCOMPARE features using QEMU timers, enables support for running with -icount option and updates timer tests. Max Filippov (7): target/xtensa: refactor CCOUNT/CCOMPARE target/xtensa: support icount target/xtensa: don't continue translation

[Qemu-devel] [PATCH 3/7] target/xtensa: don't continue translation after exception

2017-01-15 Thread Max Filippov
There's no point in continuing translating guest instructions once an unconditional exception is thrown. There's also no point in updating pc before any instruction is translated, don't do it. Signed-off-by: Max Filippov --- target/xtensa/translate.c | 5 - 1 file

[Qemu-devel] [PATCH 6/7] target/xtensa: tests: replace hardcoded interrupt masks

2017-01-15 Thread Max Filippov
Signed-off-by: Max Filippov --- tests/tcg/xtensa/test_timer.S | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/tcg/xtensa/test_timer.S b/tests/tcg/xtensa/test_timer.S index 9e6012d..844c032 100644 --- a/tests/tcg/xtensa/test_timer.S +++

[Qemu-devel] [PATCH] target/xtensa: implement RUNSTALL

2017-01-15 Thread Max Filippov
RUNSTALL signal stalls core execution while it's applied. It is widely used in multicore configurations to control activity of additional cores. Signed-off-by: Max Filippov --- target/xtensa/cpu.c| 3 ++- target/xtensa/cpu.h| 3 ++- target/xtensa/helper.c | 13

[Qemu-devel] [PATCH] target/xtensa: add static vectors selection

2017-01-15 Thread Max Filippov
Xtensa cores may have two distinct addresses for the static vectors group. Provide a function to select one of them. Signed-off-by: Max Filippov --- target/xtensa/cpu.c | 2 +- target/xtensa/cpu.h | 10 +- target/xtensa/overlay_tool.h | 11

[Qemu-devel] [PATCH] Drop duplicate display option documentation

2017-01-15 Thread Samuel Thibault
The curses and none possibilities are already documented on a separate line, so documenting it on the sdl line was both unneeded and confusing. Signed-off-by: Samuel Thibault diff --git a/qemu-options.hx b/qemu-options.hx index c534a2f7f9..9c81d3752d 100644 ---

Re: [Qemu-devel] [PATCH v5 3/4] migration: disallow migrate_add_blocker during migration

2017-01-15 Thread Greg Kurz
On Thu, 12 Jan 2017 21:22:33 +0530 Ashijeet Acharya wrote: > If a migration is already in progress and somebody attempts > to add a migration blocker, this should rightly fail. > > Add an errp parameter and a retcode return value to migrate_add_blocker. > >

[Qemu-devel] [Bug 1656676] [NEW] nvram/fw_cfg.c ‘read’ may be used uninitialized

2017-01-15 Thread Medicine Yeh
Public bug reported: Commit Number: b6af8ea60282df514f87d32e36afd1c9aeee28c8 The gcc version version 6.3.1 catches a new uninitialized variable in the master branch of QEMU on the Github. After looking through the function, it is really not properly assigned to a value in a certain path (the

Re: [Qemu-devel] [PATCH V2 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-15 Thread Marcel Apfelbaum
On 01/13/2017 10:35 AM, Gerd Hoffmann wrote: Hi, Sure, thanks for the pointers! I suppose I can change later to msi-x in a follow up patch to avoid introducing new bugs from the beginning :) I'd use msi-x right from start to avoid any backward compatibility issues. Hi Gerd, Michael

[Qemu-devel] [PATCH] arm: virt: Fix the segmentation fault when specifying an unsupported CPU

2017-01-15 Thread Shannon Zhao
From: Shannon Zhao For example, using -cpu generic will cause qemu segmentation fault. Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index

[Qemu-devel] [PATCH] Makefile: Fix owner and group for qemu-version.h.tmp

2017-01-15 Thread Lin Ma
By commit 67a1de0d, When we perform 'git pull && make && sudo make install', In 'make' stage a qemu-version.h.tmp will be generated. If the content of qemu-version.h.tmp and qemu-version.h aren't consistent, The qemu-version.h.tmp will be renamed to qemu-version.h. Because of the target FORCE, The

[Qemu-devel] [PATCH v4 2/2] block/qapi: reduce the execution time of qmp_query_blockstats

2017-01-15 Thread Dou Liyang
In order to reduce the execution time, this patch optimize the qmp_query_blockstats(): Remove the next_query_bds function. Remove the bdrv_query_stats function. Remove some judgement sentence. The original qmp_query_blockstats calls next_query_bds to get the next objects in each loops. In the

[Qemu-devel] [PATCH v4 1/2] block/qapi: reduce the coupling between the bdrv_query_stats and bdrv_query_bds_stats

2017-01-15 Thread Dou Liyang
The bdrv_query_stats and bdrv_query_bds_stats functions need to call each other, that increases the coupling. it also makes the program complicated and makes some unnecessary tests. Remove the call from bdrv_query_bds_stats to bdrv_query_stats, just take some recursion to make it clearly. Avoid

[Qemu-devel] [PATCH v4 0/2] block/qapi: refactor and optimize the qmp_query_blockstats()

2017-01-15 Thread Dou Liyang
Change log v3 -> v4: 1. Develop these into the non-RFC patches. 2. Fix some comments. 3. do declarations first. Change log v2 -> v3: 1. Remove the unnecessary code for the bdrv_next_node(). 2. Remove the change of the locking rules. Even if this change can improve the performance, but it