Re: [Qemu-devel] [PATCH v3 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread Marc-André Lureau
Hi - Original Message - > We can call qemu_chr_fe_set_handlers() to add/remove fd been watched > in 'context' which can be either default main context or other explicit > context. But the original logic is not correct, we didn't remove > the right fd because we call

Re: [Qemu-devel] [PATCH] iotests: Fix another race in 030

2017-02-16 Thread Fam Zheng
On Thu, 02/16 17:00, John Snow wrote: > We can't rely on a non-paused job to be present and running for us. > Assume that if the job is not present that it completed already. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/030 | 5 - > 1 file changed, 4

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-02-16 Thread Peter Xu
On Fri, Feb 17, 2017 at 06:36:41AM +, Liu, Yi L wrote: > > -Original Message- > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Friday, February 17, 2017 11:26 AM > > To: Liu, Yi L > > Cc: Michael S. Tsirkin ; qemu-devel@nongnu.org; Peter > >

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:47, Chad Joan wrote: > I am glad others are chiming in and might provide better solutions. > > Honestly, following the instructions at > http://wiki.qemu-project.org/Contribute/SubmitAPatch to-the-letter is quite > daunting to me, just to get one line of code changed. It might

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-02-16 Thread Jason Wang
On 2017年02月17日 14:18, Liu, Yi L wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Thursday, February 16, 2017 1:44 PM To: Liu, Yi L ; Michael S. Tsirkin ; qemu- de...@nongnu.org Cc: Peter Maydell

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-02-16 Thread Liu, Yi L
> -Original Message- > From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, February 17, 2017 11:26 AM > To: Liu, Yi L > Cc: Michael S. Tsirkin ; qemu-devel@nongnu.org; Peter > Maydell ; Eduardo Habkost >

[Qemu-devel] [PATCH v8 3/5] hw/intc/arm_gicv3_kvm: Implement get/put functions

2017-02-16 Thread vijay . kilari
From: Vijaya Kumar K This actually implements pre_save and post_load methods for in-kernel vGICv3. Signed-off-by: Pavel Fedin Signed-off-by: Peter Maydell [PMM: * use decimal, not 0bnnn * fixed typo in names of

[Qemu-devel] [PATCH v8 4/5] target-arm: Add GICv3CPUState in CPUARMState struct

2017-02-16 Thread vijay . kilari
From: Vijaya Kumar K Add gicv3state void pointer to CPUARMState struct to store GICv3CPUState. In case of usecase like CPU reset, we need to reset GICv3CPUState of the CPU. In such scenario, this pointer becomes handy. This patch take care of only GICv3.

[Qemu-devel] [PATCH v8 1/5] kernel: Add definitions for GICv3 attributes

2017-02-16 Thread vijay . kilari
From: Vijaya Kumar K This temporary patch adds kernel API definitions. Use proper header update procedure after these features are released. Signed-off-by: Pavel Fedin Signed-off-by: Vijaya Kumar K ---

[Qemu-devel] [PATCH v8 5/5] hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers

2017-02-16 Thread vijay . kilari
From: Vijaya Kumar K Reset CPU interface registers of GICv3 when CPU is reset. For this, ARMCPRegInfo struct is registered with one ICC register whose resetfn is called when cpu is reset. All the ICC registers are reset under one single register reset function instead

[Qemu-devel] [PATCH v8 2/5] hw/intc/arm_gicv3_kvm: Add ICC_SRE_EL1 register to vmstate

2017-02-16 Thread vijay . kilari
From: Vijaya Kumar K To Save and Restore ICC_SRE_EL1 register introduce vmstate subsection and load only if non-zero. Also initialize icc_sre_el1 with to 0x7 in pre_load function. Signed-off-by: Vijaya Kumar K --- hw/intc/arm_gicv3_common.c

[Qemu-devel] [PATCH v8 0/5] GICv3 live migration support

2017-02-16 Thread vijay . kilari
From: Vijaya Kumar K This series introduces support for GICv3 live migration with new VGIC implementation in 4.7-rc3 kernel. In this series, patch 1 of the previous implementation are ported. https://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg05284.html Patch

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-02-16 Thread Liu, Yi L
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, February 16, 2017 1:44 PM > To: Liu, Yi L ; Michael S. Tsirkin ; > qemu- > de...@nongnu.org > Cc: Peter Maydell ; Eduardo Habkost >

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

2017-02-16 Thread Dmitry Fleytman
> On 17 Feb 2017, at 5:05, Jason Wang wrote: > > > >> On 2017年02月16日 20:39, Peter Maydell wrote: >>> On 16 February 2017 at 12:29, Dmitry Fleytman wrote: >>> This series fix a few issues related >>> to processing of RX packets with VLAN headers. >>>

Re: [Qemu-devel] [PATCH 5/6] target-ppc: support for 32-bit carry and overflow

2017-02-16 Thread Nikunj A Dadhania
Richard Henderson writes: > On 02/16/2017 04:08 PM, Nikunj A Dadhania wrote: >> Richard Henderson writes: >> >>> On 02/14/2017 02:05 PM, Nikunj A Dadhania wrote: Yes, you are right. I had a discussion with Paul Mackerras yesterday, he explained to

Re: [Qemu-devel] [PATCH v3 4/4] colo-compare: Fix removing fds been watched incorrectly in finalization

2017-02-16 Thread Zhang Chen
On 02/17/2017 10:53 AM, zhanghailiang wrote: We will catch the bellow error report while try to delete compare object by qmp command: chardev/char-io.c:91: io_watch_poll_finalize: Assertion `iwp->src == ((void *)0)' failed. This is caused by failing to remove the right fd been watched while

Re: [Qemu-devel] [PATCH v3 2/4] colo-compare: kick compare thread to exit after some cleanup in finalization

2017-02-16 Thread Zhang Chen
On 02/17/2017 10:53 AM, zhanghailiang wrote: We should call g_main_loop_quit() to notify colo compare thread to exit, Or it will run in g_main_loop_run() forever. Besides, the finalizing process can't happen in context of colo thread, it is reasonable to remove the 'if

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-02-16 Thread Peter Xu
On Thu, Feb 16, 2017 at 05:36:06AM +, Liu, Yi L wrote: > > -Original Message- > > From: Qemu-devel [mailto:qemu-devel-bounces+yi.l.liu=intel@nongnu.org] > > On Behalf Of Michael S. Tsirkin > > Sent: Tuesday, January 10, 2017 1:40 PM > > To: qemu-devel@nongnu.org > > Cc: Peter

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

2017-02-16 Thread Jason Wang
On 2017年02月16日 20:39, Peter Maydell wrote: On 16 February 2017 at 12:29, Dmitry Fleytman wrote: This series fix a few issues related to processing of RX packets with VLAN headers. See commit messages of specific patches for information regarding affected devices. I think

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

2017-02-16 Thread Jason Wang
On 2017年02月16日 20:29, Dmitry Fleytman wrote: This series fix a few issues related to processing of RX packets with VLAN headers. See commit messages of specific patches for information regarding affected devices. Dmitry Fleytman (5): eth: Extend vlan stripping functions NetRxPkt: Fix

[Qemu-devel] [PATCH v3 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread zhanghailiang
We can call qemu_chr_fe_set_handlers() to add/remove fd been watched in 'context' which can be either default main context or other explicit context. But the original logic is not correct, we didn't remove the right fd because we call g_main_context_find_source_by_id(NULL, tag) which always try to

[Qemu-devel] [PATCH v3 1/4] colo-compare: use g_timeout_source_new() to process the stale packets

2017-02-16 Thread zhanghailiang
Instead of using qemu timer to process the stale packets, We re-use the colo compare thread to process these packets by creating a new timeout coroutine. Besides, since we process all the same vNIC's net connection/packets in one thread, it is safe to remove the timer_check_lock. Signed-off-by:

[Qemu-devel] [PATCH v3 0/4] colo-compare: fix some bugs

2017-02-16 Thread zhanghailiang
This series includes two parts: codes optimization and bug fix. patch 1 tries to move timer process into colo compare thread as a new coroutine. patch 2 ~ 4 fixe some bugs of colo compare. v2->v3: - change the definition of remove_fd_in_watch() instead of introducing a function (Marc-Andr??

[Qemu-devel] [PATCH v3 4/4] colo-compare: Fix removing fds been watched incorrectly in finalization

2017-02-16 Thread zhanghailiang
We will catch the bellow error report while try to delete compare object by qmp command: chardev/char-io.c:91: io_watch_poll_finalize: Assertion `iwp->src == ((void *)0)' failed. This is caused by failing to remove the right fd been watched while call qemu_chr_fe_set_handlers(); Fix it by pass

[Qemu-devel] [PATCH v3 2/4] colo-compare: kick compare thread to exit after some cleanup in finalization

2017-02-16 Thread zhanghailiang
We should call g_main_loop_quit() to notify colo compare thread to exit, Or it will run in g_main_loop_run() forever. Besides, the finalizing process can't happen in context of colo thread, it is reasonable to remove the 'if (qemu_thread_is_self(>thread))' branch. Before compare thead exits,

Re: [Qemu-devel] [PATCH] net: Remove useless local var pkt

2017-02-16 Thread Jason Wang
On 2017年02月15日 16:58, Dmitry Fleytman wrote: Reviewed-by: Dmitry Fleytman This patch also fixes compilation with NET_RX_PKT_DEBUG defined. On 15 Feb 2017, at 10:31 AM, Fam Zheng wrote: This has been pointless since commit 605d52e62, which was a

Re: [Qemu-devel] [PATCH RFC v2 03/12] s390x/css: add s390-map-css machine option

2017-02-16 Thread Dong Jia Shi
* Dong Jia Shi [2017-01-12 08:25:04 +0100]: > From: Xiao Feng Ren > > We want to support real (i.e. not virtual) channel devices > even for guests that do not support MCSS-E (where guests may > see devices from any channel subsystem

Re: [Qemu-devel] [PATCH 1/2] Update README to accomodate markdown format

2017-02-16 Thread Nir Soffer
On Fri, Feb 17, 2017 at 2:54 AM, Pranith Kumar wrote: > Signed-off-by: Pranith Kumar > --- > README | 44 +--- > 1 file changed, 21 insertions(+), 23 deletions(-) > > diff --git a/README b/README > index

[Qemu-devel] [PATCH 2/2] Create README.md as a symlink to README

2017-02-16 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- README.md | 1 + 1 file changed, 1 insertion(+) create mode 12 README.md diff --git a/README.md b/README.md new file mode 12 index 00..100b93820a --- /dev/null +++ b/README.md @@ -0,0 +1 @@ +README \ No newline at end of

[Qemu-devel] [PATCH 1/3] qemu-img: Add tests for raw image preallocation

2017-02-16 Thread Nir Soffer
Add tests for creating raw image with and without the preallocation option. Signed-off-by: Nir Soffer --- tests/qemu-iotests/175 | 61 ++ tests/qemu-iotests/175.out | 18 ++ tests/qemu-iotests/group | 1 + 3 files

[Qemu-devel] [PATCH 1/2] Update README to accomodate markdown format

2017-02-16 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- README | 44 +--- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/README b/README index cb60d05bee..225afd6be7 100644 --- a/README +++ b/README @@ -1,5 +1,5 @@ - QEMU README -

[Qemu-devel] [PATCH 3/3] qemu-img: Improve documentation for PREALLOC_MODE_FALLOC

2017-02-16 Thread Nir Soffer
Now that we are truncating the file in both PREALLOC_MODE_FULL and PREALLOC_MODE_OFF, not truncating in PREALLOC_MODE_FALLOC looks odd. Add a comment explaining why we do not truncate in this case. Signed-off-by: Nir Soffer --- block/file-posix.c | 7 ++- 1 file changed, 6

[Qemu-devel] [PATCH 0/2] Add mardown formatting to README

2017-02-16 Thread Pranith Kumar
Also create README.md as a symlink to README so that github displays markdown. Update the README file to markdown so that it makes the github page look prettier. I know that github repo is a mirror and not the official repo, but I think it doesn't hurt to have it in markdown format. The last

[Qemu-devel] [PATCH 0/3] qemu-img raw preallocation

2017-02-16 Thread Nir Soffer
This series add missing tests for raw image preallocation, refine preallocation=full and improve documentation. Create on top of the commit 10ddfe7b6044 (qemu-img: Do not truncate before preallocation) from Kevin block branch. Nir Soffer (3): qemu-img: Add tests for raw image preallocation

[Qemu-devel] [PATCH 2/3] qemu-img: Truncate before full preallocation

2017-02-16 Thread Nir Soffer
In commit 10ddfe7b6044 (qemu-img: Do not truncate before preallocation) we moved truncate to the PREALLOC_MODE_OFF branch to avoid slowdown in posix_fallocate(). However this change is not optimal when using PREALLOC_MODE_FULL, since knowing the final size from the beginning could allow the file

Re: [Qemu-devel] [PATCH] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-16 Thread Fam Zheng
On Thu, 02/16 08:58, Franklin Snaipe Mathieu wrote: > +p = lock_user_string(arg3) > +if (!p) { Please compile test at least, even if it is a trivial patch. Fam

Re: [Qemu-devel] Fix build break during configuration on musl-libc based system

2017-02-16 Thread Felix Janda
Defining _GNU_SOURCE causes musl to define everything including everything protected by _XOPEN_SOURCE. However it does not cause musl to define _XOPEN_SOURCE. On the other hand, the ncurses header specifically checks for _XOPEN_SOURCE or _XOPEN_SOURCE_EXTENDED. So it is not completely clear

[Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-16 Thread ben
From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, an ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must

[Qemu-devel] [PATCH v8 0/8] Add support for VM Generation ID

2017-02-16 Thread ben
From: Ben Warren This patch set adds support for passing a GUID to Windows guests. It is a re-implementation of previous patch sets written by Igor Mammedov et al, but this time passing the GUID data as a fw_cfg blob. This patch set has dependencies on new guest

[Qemu-devel] [PATCH v8 7/8] tests: Add unit tests for the VM Generation ID feature

2017-02-16 Thread ben
From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. Read the GUID from guest memory * test that the "auto" argument to the GUID generates a valid GUID, as seen by the guest. * test that a GUID

[Qemu-devel] [PATCH v8 6/8] tests: Move reusable ACPI code into a utility file

2017-02-16 Thread ben
From: Ben Warren Also usable by upcoming VM Generation ID tests Signed-off-by: Ben Warren --- MAINTAINERS | 2 + tests/Makefile.include | 2 +- tests/acpi-utils.c | 65 +++ tests/acpi-utils.h

[Qemu-devel] [PATCH v8 1/8] linker-loader: Add new 'write pointer' command

2017-02-16 Thread ben
From: Ben Warren This is similar to the existing 'add pointer' functionality, but instead of instructing the guest (BIOS or UEFI) to patch memory, it instructs the guest to write the pointer back to QEMU via a writeable fw_cfg file. Signed-off-by: Ben Warren

[Qemu-devel] [PATCH v8 5/8] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

2017-02-16 Thread ben
From: Igor Mammedov Add commands to query Virtual Machine Generation ID counter. QMP command example: { "execute": "query-vm-generation-id" } HMP command example: info vm-generation-id Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v8 8/8] MAINTAINERS: Add VM Generation ID entries

2017-02-16 Thread ben
From: Ben Warren Signed-off-by: Ben Warren Reviewed-by: Laszlo Ersek --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 81d4baf..8f5dd35 100644 --- a/MAINTAINERS +++

[Qemu-devel] [PATCH v8 3/8] ACPI: Add vmgenid blob storage to the build tables

2017-02-16 Thread ben
From: Ben Warren This allows them to be centrally initialized and destroyed The "AcpiBuildTables.vmgenid" array will be used to construct the "etc/vmgenid_guid" fw_cfg blob. Its contents will be linked into fw_cfg after being built on the pc_machine_done() ->

[Qemu-devel] [PATCH v8 2/8] docs: VM Generation ID device description

2017-02-16 Thread ben
From: Ben Warren This patch is based off an earlier version by Gal Hammer (gham...@redhat.com) Requirements section, ASCII diagrams and overall help provided by Laszlo Ersek (ler...@redhat.com) Signed-off-by: Gal Hammer Signed-off-by: Ben Warren

[Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-16 Thread Anton Nefedov
also remove a useless NULL check in the event reporting code Signed-off-by: Anton Nefedov --- qapi/event.json | 4 ++-- vl.c| 22 ++ 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/qapi/event.json b/qapi/event.json

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-16 Thread ashish mittal
Hi, I am getting the following error with checkpatch.pl ERROR: externs should be avoided in .c files #78: FILE: block/vxhs.c:28: +QemuUUID qemu_uuid __attribute__ ((weak)); Is there any way to get around this, or does it mean that I would have to add a vxhs.h just for this one entry? Thanks,

[Qemu-devel] [Bug 1665389] Re: Nested kvm guest fails to start on a emulated Westmere CPU guest under a Broadwell CPU host

2017-02-16 Thread Nadav Goldin
Hi Dave, thanks for looking into this. > Can you clarify what the host and L1 kernels are please? Host - 4.8.15-200.fc24.x86_64 Guest - 3.10.0-514.2.2.el7.x86_64 Results of adding the debug messages and running a simpler command(with master again - 5dae13): [root@vm-el73 ~]#

[Qemu-devel] [PATCH] iotests: Fix another race in 030

2017-02-16 Thread John Snow
We can't rely on a non-paused job to be present and running for us. Assume that if the job is not present that it completed already. Signed-off-by: John Snow --- tests/qemu-iotests/030 | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [Qemu-block] [PATCH v3 7/8] blockdev: Make orphaned -drive fatal

2017-02-16 Thread John Snow
On 02/15/2017 05:05 AM, Markus Armbruster wrote: > Block backends defined with "-drive if=T" with T other than "none" are > meant to be picked up by machine initialization code: a suitable > frontend gets created and wired up automatically. > > If machine initialization code doesn't comply, the

Re: [Qemu-devel] [PATCH v3 15/16] target-m68k: add more FPU instructions

2017-02-16 Thread Richard Henderson
On 02/16/2017 09:18 PM, Andreas Schwab wrote: There is no guarantee that the host long double has the same range and precision as floatx80. Indeed not. However, do you have another plan for implementing the trancendentals? I'm quite happy using the host long double libm as an estimate.

Re: [Qemu-devel] [PATCH v7 0/8] Add support for VM Generation ID

2017-02-16 Thread Laszlo Ersek
On 02/16/17 07:18, b...@skyportsystems.com wrote: > From: Ben Warren > > This patch set adds support for passing a GUID to Windows guests. It is a > re-implementation of previous patch sets written by Igor Mammedov et al, but > this time passing the GUID data as a

Re: [Qemu-devel] [PATCH] target-ppc: Add quad precision muladd instructions

2017-02-16 Thread Richard Henderson
On 02/16/2017 01:41 PM, Bharata B Rao wrote: For some reason float128_mul implements multipliction via multiplication and addition (mul128To256 & add128). There is no equivalent to this in float64_muladd. Yes, I don't understand that myself. It really appears to be a bug. r~

Re: [Qemu-devel] [PATCH 5/6] target-ppc: support for 32-bit carry and overflow

2017-02-16 Thread Richard Henderson
On 02/16/2017 04:08 PM, Nikunj A Dadhania wrote: Richard Henderson writes: On 02/14/2017 02:05 PM, Nikunj A Dadhania wrote: Yes, you are right. I had a discussion with Paul Mackerras yesterday, he explained to me in detail about the bits. I am working on the revised

Re: [Qemu-devel] [Qemu-block] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-02-16 Thread John Snow
On 02/16/2017 07:47 AM, Kevin Wolf wrote: > Can we make the whole thing a little less confusing by entirely removing > sectors from the block dirty bitmap interfaces? I find it challenging > enough to deal with just bytes, qcow2 clusters and bitmap clusters. I'll take a look to see how easy

Re: [Qemu-devel] [PATCH v4 3/4] .shippable.yml: new CI provider

2017-02-16 Thread Alex Bennée
Fam Zheng writes: > On Thu, 02/16 12:34, Alex Bennée wrote: >> Ostensibly Shippable offers a similar set of services as Travis. >> However they are focused on Docker container based work-flows so we >> can use our existing containers to run a few extra builds - in this >> case

Re: [Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-16 Thread Eric Blake
On 02/16/2017 11:39 AM, Anton Nefedov wrote: > also remove a useless NULL check in the event reporting code > > Signed-off-by: Anton Nefedov > --- > qapi/event.json | 4 ++-- > vl.c| 22 ++ > 2 files changed, 12 insertions(+), 14

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 00/13] Rewrite NVIC to not depend on the GIC

2017-02-16 Thread Peter Maydell
On 16 February 2017 at 16:35, Peter Maydell wrote: > This patchset is the revamp of the NVIC code from Michael > Davidsaver's patchset of a year ago. > > Despite some superficial similarities of register layout, the > M-profile NVIC is really very different from the

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-16 Thread Marcel Apfelbaum
On 02/16/2017 05:28 AM, David Gibson wrote: On Thu, Feb 16, 2017 at 01:48:42PM +1100, David Gibson wrote: On Wed, Feb 15, 2017 at 04:59:33PM +0200, Marcel Apfelbaum wrote: On 02/15/2017 03:45 AM, David Gibson wrote: On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: On

[Qemu-devel] [Bug 1665389] Re: Nested kvm guest fails to start on a emulated Westmere CPU guest under a Broadwell CPU host

2017-02-16 Thread Dr. David Alan Gilbert
Hi Nadav, Can you clarify what the host and L1 kernels are please? This error means that qemu tried to write some msrs but one of the msr writes failed; we need to figure out which one to understand what's going on. 1) Edit kvm_msr_entry_add in target/i386/kvm.c to something like:

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-16 Thread Marcel Apfelbaum
On 02/16/2017 04:48 AM, David Gibson wrote: On Wed, Feb 15, 2017 at 04:59:33PM +0200, Marcel Apfelbaum wrote: [...] I did float the idea of having the pseries PCI bus remain plain PCI but with a special flag to allow PCIe devices to be attached to it anyway. It wasn't greeted with much

Re: [Qemu-devel] [PULL v2 00/23] Misc patches for 2017-02-16

2017-02-16 Thread Peter Maydell
On 16 February 2017 at 17:38, Paolo Bonzini wrote: > The following changes since commit 5dae13cd71f0755a1395b5a4cde635b8a6ee3f58: > > Merge remote-tracking branch 'remotes/rth/tags/pull-or-20170214' into > staging (2017-02-14 09:55:48 +) > > are available in the git

Re: [Qemu-devel] [PATCH v7 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-16 Thread Ben Warren
> On Feb 16, 2017, at 11:03 AM, Laszlo Ersek wrote: > > On 02/16/17 19:32, Ben Warren wrote: >> >>> On Feb 16, 2017, at 1:56 AM, Igor Mammedov wrote: >>> >>> On Wed, 15 Feb 2017 22:18:14 -0800 >>> b...@skyportsystems.com wrote: >>> From: Ben

Re: [Qemu-devel] [PATCH v7 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-16 Thread Laszlo Ersek
On 02/16/17 19:32, Ben Warren wrote: > >> On Feb 16, 2017, at 1:56 AM, Igor Mammedov wrote: >> >> On Wed, 15 Feb 2017 22:18:14 -0800 >> b...@skyportsystems.com wrote: >> >>> From: Ben Warren >>> >>> This implements the VM Generation ID feature by

Re: [Qemu-devel] [PATCH] qemu-img: Do not truncate before preallocation

2017-02-16 Thread Kevin Wolf
Am 16.02.2017 um 19:23 hat Nir Soffer geschrieben: > On Thu, Feb 16, 2017 at 7:52 PM, Kevin Wolf wrote: > > Am 03.02.2017 um 20:50 hat Nir Soffer geschrieben: > >> When using file system that does not support fallocate() (e.g. NFS < > >> 4.2), truncating the file only when

Re: [Qemu-devel] [PATCH 11/18] nbd: BLOCK_STATUS for bitmap export: server part

2017-02-16 Thread Denis V. Lunev
On 02/03/2017 06:47 PM, Vladimir Sementsov-Ogievskiy wrote: > Only one meta context type is defined: qemu-bitmap:. > Maximum one query is allowed for NBD_OPT_{SET,LIST}_META_CONTEXT, > NBD_REP_ERR_TOO_BIG is returned otherwise. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v7 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-16 Thread Ben Warren
> On Feb 16, 2017, at 1:56 AM, Igor Mammedov wrote: > > On Wed, 15 Feb 2017 22:18:14 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren >> >> This implements the VM Generation ID feature by passing a 128-bit >> GUID to the guest via a

Re: [Qemu-devel] [PATCH v2 03/13] armv7m: Rewrite NVIC to not use any GIC code

2017-02-16 Thread Peter Maydell
On 16 February 2017 at 16:35, Peter Maydell wrote: > From: Michael Davidsaver > > Despite some superficial similarities of register layout, the > M-profile NVIC is really very different from the A-profile GIC. > Our current attempt to reuse the

Re: [Qemu-devel] [PATCH] qemu-img: Do not truncate before preallocation

2017-02-16 Thread Nir Soffer
On Thu, Feb 16, 2017 at 7:52 PM, Kevin Wolf wrote: > Am 03.02.2017 um 20:50 hat Nir Soffer geschrieben: >> When using file system that does not support fallocate() (e.g. NFS < >> 4.2), truncating the file only when preallocation=OFF speeds up creating >> raw file. >> >> Here is

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-16 Thread Chad Joan
I am glad others are chiming in and might provide better solutions. Honestly, following the instructions at http://wiki.qemu-project.org/Contribute/SubmitAPatch to-the-letter is quite daunting to me, just to get one line of code changed. It might help if that page had some kind of dead-simple

Re: [Qemu-devel] [PULL 00/23] Misc patches for 2017-02-16

2017-02-16 Thread Peter Maydell
On 16 February 2017 at 14:31, Paolo Bonzini wrote: > The following changes since commit 5dae13cd71f0755a1395b5a4cde635b8a6ee3f58: > > Merge remote-tracking branch 'remotes/rth/tags/pull-or-20170214' into > staging (2017-02-14 09:55:48 +) > > are available in the git

[Qemu-devel] [PATCH] lm32: milkymist-tmu2: fix a third integer overflow

2017-02-16 Thread Peter Maydell
Don't truncate the multiplication and do a 64 bit one instead because the result is stored in a 64 bit variable. This fixes a similar coverity warning to commits 237a8650d640 and 4382fa655498, in a similar way, and is the final third of the fix for coverity CID 1167561 (hopefully!).

[Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-16 Thread Anton Nefedov
Signed-off-by: Anton Nefedov --- qapi/event.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/event.json b/qapi/event.json index 970ff02..e02852c 100644 --- a/qapi/event.json +++ b/qapi/event.json @@ -488,9 +488,9 @@ # # @action:

Re: [Qemu-devel] [PATCH v7 3/8] ACPI: Add vmgenid blob storage to the build tables

2017-02-16 Thread Laszlo Ersek
On 02/16/17 07:18, b...@skyportsystems.com wrote: > From: Ben Warren > > This allows them to be centrally initialized and destroyed > > The "AcpiBuildTables.vmgenid" array will be used to construct the > "etc/vmgenid_guid" fw_cfg blob. > > Its contents will be linked

[Qemu-devel] [PATCH v2 05/13] arm: gic: Remove references to NVIC

2017-02-16 Thread Peter Maydell
From: Michael Davidsaver Now that the NVIC is its own separate implementation, we can clean up the GIC code by removing REV_NVIC and conditionals which use it. Signed-off-by: Michael Davidsaver Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH] qemu-img: Do not truncate before preallocation

2017-02-16 Thread Kevin Wolf
Am 03.02.2017 um 20:50 hat Nir Soffer geschrieben: > When using file system that does not support fallocate() (e.g. NFS < > 4.2), truncating the file only when preallocation=OFF speeds up creating > raw file. > > Here is example run, tested on Fedora 24 machine, creating raw file on > NFS version

[Qemu-devel] [PULL 23/23] target-i386: correctly propagate retaddr into SVM helpers

2017-02-16 Thread Paolo Bonzini
Commit 2afbdf8 ("target-i386: exception handling for memory helpers", 2015-09-15) changed tlb_fill's cpu_restore_state+raise_exception_err to raise_exception_err_ra. After this change, the cpu_restore_state and raise_exception_err's cpu_loop_exit are merged into raise_exception_err_ra's

[Qemu-devel] [PATCH v2 07/13] armv7m: Remove unused armv7m_nvic_acknowledge_irq() return value

2017-02-16 Thread Peter Maydell
Having armv7m_nvic_acknowledge_irq() return the new value of env->v7m.exception and its one caller assign the return value back to env->v7m.exception is pointless. Just make the return type void instead. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée

[Qemu-devel] [PATCH v2 09/13] armv7m: VECTCLRACTIVE and VECTRESET are UNPREDICTABLE

2017-02-16 Thread Peter Maydell
From: Michael Davidsaver The VECTCLRACTIVE and VECTRESET bits in the AIRCR are both documented as UNPREDICTABLE if you write a 1 to them when the processor is not halted in Debug state (ie stopped and under the control of an external JTAG debugger). Since we don't

Re: [Qemu-devel] [PULL 00/23] Misc patches for 2017-02-16

2017-02-16 Thread Paolo Bonzini
> The problem is in the bit of the prototype the error message > doesn't quote: > > Prototype in cpu.h: > void cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, uint64_t > exit_info_1, > uintptr_t retaddr); > > svm_helper.c stub version; > void cpu_vmexit(CPUX86State

[Qemu-devel] [PATCH v2 12/13] armv7m: Raise correct kind of UsageFault for attempts to execute ARM code

2017-02-16 Thread Peter Maydell
M profile doesn't implement ARM, and the architecturally required behaviour for attempts to execute with the Thumb bit clear is to generate a UsageFault with the CFSR INVSTATE bit set. We were incorrectly implementing this as generating an UNDEFINSTR UsageFault; fix this. Signed-off-by: Peter

Re: [Qemu-devel] [PATCH] linux-user: fix fork()

2017-02-16 Thread Peter Maydell
On 16 February 2017 at 17:37, Laurent Vivier wrote: > Since commit 5ea2fc8 ("linux-user: Sanity check clone flags"), > trying to run fork() fails with old distro on some architectures. > > This is the case with HP-PA and Debian 5 (Lenny). > > It fails on: > > if

Re: [Qemu-devel] [PATCH] qemu-img: Do not truncate before preallocation

2017-02-16 Thread Nir Soffer
Ping On Fri, Feb 3, 2017 at 9:50 PM, Nir Soffer wrote: > When using file system that does not support fallocate() (e.g. NFS < > 4.2), truncating the file only when preallocation=OFF speeds up creating > raw file. > > Here is example run, tested on Fedora 24 machine, creating

Re: [Qemu-devel] [PATCH 0/6] Make CoMutex/CoQueue/CoRwlock thread-safe

2017-02-16 Thread Stefan Hajnoczi
On Mon, Feb 13, 2017 at 07:12:38PM +0100, Paolo Bonzini wrote: > This is yet another tiny bit of the multiqueue work, this time affecting > the synchronization infrastructure for coroutines. Currently, coroutines > synchronize between the main I/O thread and the dataplane iothread through > the

[Qemu-devel] [PATCH v2 13/13] armv7m: Allow SHCSR writes to change pending and active bits

2017-02-16 Thread Peter Maydell
Implement the NVIC SHCSR write behaviour which allows pending and active status of some exceptions to be changed. Signed-off-by: Peter Maydell --- hw/intc/armv7m_nvic.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL v2 00/23] Misc patches for 2017-02-16

2017-02-16 Thread Paolo Bonzini
The following changes since commit 5dae13cd71f0755a1395b5a4cde635b8a6ee3f58: Merge remote-tracking branch 'remotes/rth/tags/pull-or-20170214' into staging (2017-02-14 09:55:48 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to

[Qemu-devel] [PATCH] linux-user: fix fork()

2017-02-16 Thread Laurent Vivier
Since commit 5ea2fc8 ("linux-user: Sanity check clone flags"), trying to run fork() fails with old distro on some architectures. This is the case with HP-PA and Debian 5 (Lenny). It fails on: if ((flags & CSIGNAL) != TARGET_SIGCHLD) { return -TARGET_EINVAL; }

Re: [Qemu-devel] Missing rewrite rule for qemu.org/images/ links

2017-02-16 Thread Jeff Cody
On Thu, Feb 16, 2017 at 10:47:07AM -0500, Jeff Cody wrote: > On Thu, Feb 16, 2017 at 03:30:25PM +, Stefan Hajnoczi wrote: > > Hi Jeff, > > The old qemu.org/images/ links are not being rewritten to > > wiki.qemu-project.org/images/. > > > > For example,

Re: [Qemu-devel] [PATCH 3/9] armv7m: Rewrite NVIC to not use any GIC code

2017-02-16 Thread Peter Maydell
On 15 February 2017 at 13:34, Peter Maydell wrote: > On 15 February 2017 at 12:46, Alex Bennée wrote: >> Can we not calculate a vector index rather than abusing the meaning of >> offset while switching on it? > > Yeah, we could. (This is just a

Re: [Qemu-devel] [PATCH v7 1/8] linker-loader: Add new 'write pointer' command

2017-02-16 Thread Laszlo Ersek
On 02/16/17 07:18, b...@skyportsystems.com wrote: > From: Ben Warren > > This is similar to the existing 'add pointer' functionality, but instead > of instructing the guest (BIOS or UEFI) to patch memory, it instructs > the guest to write the pointer back to QEMU via a

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-16 Thread Laszlo Ersek
On 02/16/17 17:58, Paolo Bonzini wrote: > > > On 16/02/2017 17:30, Chad Joan wrote: >> Hello, >> >> This is a one-line patch to the configure script that will allow QEMU to be >> built on musl-libc based Linux systems. This problem is only noticeable >> when QEMU is built with --enable-curses.

Re: [Qemu-devel] [PATCH v7 5/8] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

2017-02-16 Thread Laszlo Ersek
On 02/16/17 07:18, b...@skyportsystems.com wrote: > From: Igor Mammedov > > Add commands to query Virtual Machine Generation ID counter. > > QMP command example: > { "execute": "query-vm-generation-id" } > > HMP command example: > info vm-generation-id > >

Re: [Qemu-devel] [PATCH 1/2] qmp/hmp: add writeconfig

2017-02-16 Thread Eric Blake
On 02/15/2017 04:14 AM, Eduardo Otubo wrote: > This patch adds support for the command `writeconfig' on the QMP and HMP > consoles. This is a simple way to keep track of current state of VM > after series of hotplugs and/or hotunplugs of different devices: > > (qemu) writeconfig qemu.conf > >

Re: [Qemu-devel] [PATCH 2/6] coroutine-lock: add limited spinning to CoMutex

2017-02-16 Thread Stefan Hajnoczi
On Mon, Feb 13, 2017 at 07:12:40PM +0100, Paolo Bonzini wrote: > Running a very small critical section on pthread_mutex_t and CoMutex > shows that pthread_mutex_t is much faster because it doesn't actually > go to sleep. What happens is that the critical section is shorter > than the latency of

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/4] cpu: Implement cpu_generic_new()

2017-02-16 Thread Peter Maydell
On 13 February 2017 at 14:28, Peter Maydell wrote: > This patchset adds a new function cpu_generic_new() > which is similar to cpu_generic_init() except that it > does not realize the created CPU object. This means that > board code can do a "new cpu; set QOM properties;

Re: [Qemu-devel] Missing rewrite rule for qemu.org/images/ links

2017-02-16 Thread Paolo Bonzini
On 16/02/2017 16:30, Stefan Hajnoczi wrote: > Hi Jeff, > The old qemu.org/images/ links are not being rewritten to > wiki.qemu-project.org/images/. > > For example, http://www.qemu-project.org/images/4/4e/Q35.pdf no longer works: > https://bugs.launchpad.net/qemu/+bug/1665344 > > I do notice

Re: [Qemu-devel] [PATCH v7 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-16 Thread Laszlo Ersek
On 02/16/17 07:18, b...@skyportsystems.com wrote: > From: Ben Warren > > This implements the VM Generation ID feature by passing a 128-bit > GUID to the guest via a fw_cfg blob. > Any time the GUID changes, an ACPI notify event is sent to the guest > > The user

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-16 Thread Peter Maydell
On 16 February 2017 at 16:30, Chad Joan wrote: > Hello, > > This is a one-line patch to the configure script that will allow QEMU to be > built on musl-libc based Linux systems. This problem is only noticeable > when QEMU is built with --enable-curses. > > Detailed reading

[Qemu-devel] [PATCH v2 08/13] armv7m: Simpler and faster exception start

2017-02-16 Thread Peter Maydell
From: Michael Davidsaver All the places in armv7m_cpu_do_interrupt() which pend an exception in the NVIC are doing so for synchronous exceptions. We know that we will always take some exception in this case, so we can just acknowledge it immediately, rather than returning

  1   2   3   >