[Qemu-devel] [PATCH] COLO-compare: Fix trace_event print bug

Because of inet_ntoa() return a statically allocated buffer, subsequent calls will overwrite, So we fix this bug. Signed-off-by: Zhang Chen --- net/colo-compare.c | 33 + 1 file changed, 25 insertions(+), 8 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v7 kernel 2/5] virtio-balloon: VIRTIO_BALLOON_F_CHUNK_TRANSFER

On 03/08/2017 12:01 PM, Michael S. Tsirkin wrote: On Fri, Mar 03, 2017 at 01:40:27PM +0800, Wei Wang wrote: From: Liang Li Add a new feature bit, VIRTIO_BALLOON_F_CHUNK_TRANSFER. Please check the implementation patch commit for details about this feature. better squash

Re: [Qemu-devel] [PATCH v7 kernel 5/5] This patch contains two parts:

On 03/06/2017 09:23 PM, David Hildenbrand wrote:Am 03.03.2017 um 06:40 schrieb Wei Wang: From: Liang Li Sorry, I just saw the message due to an email issue. I'd prefer to split this into two parts then and to create proper subjects. Agree, will do. If I remember

Re: [Qemu-devel] [RFC PATCH qemu] dtc: Allow compiling with old gcc

On 9 March 2017 at 02:31, David Gibson wrote: > Yes. I've now fixed this in upstream libfdt, at Paolo's suggestion. > Unfortunately, it came just after the 1.4.3 release. I was just leery > about making a new release and qemu pull so soon after the last one. >

Re: [Qemu-devel] [PATCH] ohci: relax link check

On Mar 7, 2017, at 3:40 AM, Gerd Hoffmann wrote: > The strict td link limit added by commit "95ed569 usb: ohci: limit the > number of link eds" causes problems with macos guests. Lets raise the > limit. > > Reported-by: Programmingkid > Reported-by: Howard Spoelstra

Re: [Qemu-devel] [PATCH for-2.9] block: Drop unmaintained 'archipelago' driver

On Wed, 03/08 21:18, Max Reitz wrote: > On 08.03.2017 21:09, Eric Blake wrote: > > On 03/08/2017 02:05 PM, Max Reitz wrote: > >> On 08.03.2017 21:02, Eric Blake wrote: > >>> The driver has failed to build since commit da34e65, in qemu 2.6, > >>> due to a missing include of qapi/error.h for

Re: [Qemu-devel] [RFC PATCH qemu] dtc: Allow compiling with old gcc

On 09/03/17 12:31, David Gibson wrote: > On Thu, Mar 09, 2017 at 11:52:17AM +1100, Alexey Kardashevskiy wrote: >> On 09/03/17 01:21, Peter Maydell wrote: >>> On 8 March 2017 at 13:49, Alexey Kardashevskiy wrote: After 6e85fce0225f "dtc: Update requirement to v1.4.2" QEMU

Re: [Qemu-devel] [RFC PATCH qemu] dtc: Allow compiling with old gcc

On Thu, Mar 09, 2017 at 11:52:17AM +1100, Alexey Kardashevskiy wrote: > On 09/03/17 01:21, Peter Maydell wrote: > > On 8 March 2017 at 13:49, Alexey Kardashevskiy wrote: > >> After 6e85fce0225f "dtc: Update requirement to v1.4.2" QEMU stopped > >> compiling in CentOS7: > >> > >>

Re: [Qemu-devel] [PATCH 2/2] vl: Print CPU help after we've registered the CPU accelerators

On Wed, Mar 08, 2017 at 09:08:50AM -0300, Eduardo Habkost wrote: > On Wed, Mar 08, 2017 at 01:33:45PM +1100, David Gibson wrote: > > On Tue, Mar 07, 2017 at 09:02:37AM -0300, Eduardo Habkost wrote: > > > On Tue, Mar 07, 2017 at 02:31:05PM +1100, David Gibson wrote: > > > > On Mon, Mar 06, 2017 at

Re: [Qemu-devel] [PATCH] target/ppc: Fix wrong number of UAMR register

On Wed, Mar 08, 2017 at 08:58:43PM +0100, Thomas Huth wrote: > The SPR UAMR has the number 13, and not 12. (Fortunately it seems like > Linux is not using this register yet - only the privileged version with > number 29 ... that's why nobody noticed this problem yet) > > Signed-off-by: Thomas

Re: [Qemu-devel] [PATCH RFC 1/1] vmstate: draft fix for failed iotests case 68 and 91

在 2017/3/8 19:33, Halil Pasic 写道: On 03/08/2017 08:05 AM, QingFeng Hao wrote: 在 2017/3/7 18:19, Halil Pasic 写道: On 03/07/2017 11:05 AM, Kevin Wolf wrote: Am 07.03.2017 um 10:54 hat Halil Pasic geschrieben: On 03/07/2017 10:29 AM, Kevin Wolf wrote: Am 07.03.2017 um 03:53 hat QingFeng Hao

Re: [Qemu-devel] [PATCH V3] virtio: do not require IOMMU to be created in advance

On 2017年03月09日 00:40, Igor Mammedov wrote: On Tue, 7 Mar 2017 14:47:30 +0200 Marcel Apfelbaum wrote: On 03/07/2017 11:09 AM, Jason Wang wrote: After commit 96a8821d2141 ("virtio: unbreak virtio-pci with IOMMU after caching ring translations"), IOMMU was required to be

Re: [Qemu-devel] What's the next QEMU version after 2.9 ? (or: when is a good point in time to get rid of old interfaces)

On 2017年03月08日 19:22, Thomas Huth wrote: On 08.03.2017 11:03, Peter Maydell wrote: On 8 March 2017 at 09:26, Thomas Huth wrote: But anyway, the more important thing that keeps me concerned is: Someone once told me that we should get rid of old parameters and interfaces

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

On 2017年03月08日 18:12, Cornelia Huck wrote: On Wed, 8 Mar 2017 17:51:22 +0800 Jason Wang wrote: On 2017年03月08日 17:19, Cornelia Huck wrote: On Wed, 8 Mar 2017 11:18:27 +0800 Jason Wang wrote: On 2017年03月07日 18:16, Cornelia Huck wrote: On Tue, 7

Re: [Qemu-devel] [RFC PATCH qemu] dtc: Allow compiling with old gcc

On 09/03/17 01:21, Peter Maydell wrote: > On 8 March 2017 at 13:49, Alexey Kardashevskiy wrote: >> After 6e85fce0225f "dtc: Update requirement to v1.4.2" QEMU stopped >> compiling in CentOS7: >> >> In file included from /home/aik/p/qemu/dtc/libfdt/libfdt.h:54:0, >>

[Qemu-devel] [Bug 1670509] Re: sgabios outputs incorrect video modes

The attachment "0001-SGABIOS-fix-wrong-video-attrs-for-int-10h-ah- 13h.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message

[Qemu-devel] [PATCH RFC] qdev: add init order filter

Allow forcing a specific order of initialization on devices created with -device. Helpful e.g. for built-in devices such as IOMMUs which must exist before all other devices. Signed-off-by: Michael S. Tsirkin --- Looks like we have a ton of problems because devices are

[Qemu-devel] [Bug 1670509] Re: sgabios outputs incorrect video modes

I don't think my e-mailed patch got through... I'm going to keep trying, but in case anyone needs the patch in the interim... ** Patch added: "0001-SGABIOS-fix-wrong-video-attrs-for-int-10h-ah-13h.patch"

[Qemu-devel] [Bug 1670509] Re: sgabios outputs incorrect video modes

** Also affects: qemu Importance: Undecided Status: New ** Changed in: qemu Assignee: (unassigned) => Herbie Robinson (hrob) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1670509

Re: [Qemu-devel] Performance difference between QEMU 2.2.0 and 2.6.0

Hi Peter, Thanks for your suggestions! Will test some newer versions. Best, Wenwen On Wed, Mar 8, 2017 at 2:42 PM, Peter Maydell wrote: > On 8 March 2017 at 18:17, Wenwen Wang wrote: > > I just found that there is a significant performance

Re: [Qemu-devel] [RFC PATCH v4 00/20] x86: Secure Encrypted Virtualization (AMD)

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 148900626714.27090.1616990932333159904.stgit@brijesh-build-machine Subject: [Qemu-devel] [RFC PATCH v4 00/20]

[Qemu-devel] [RFC PATCH v4 00/20] x86: Secure Encrypted Virtualization (AMD)

This RFC series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. This RFC is based KVM RFC [1]. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. The SEV feature allows the memory contents of a

Re: [Qemu-devel] [RFC PATCH v4 20/20] migration: disable save/restore and migration when SEV is active

On 03/08/2017 03:32 PM, Eduardo Habkost wrote: On Wed, Mar 08, 2017 at 03:54:43PM -0500, Brijesh Singh wrote: Snapshot, Restore and Migration is not implemented yet. Return error when user tries to perform any of these operations. Signed-off-by: Brijesh Singh ---

Re: [Qemu-devel] [RFC PATCH v4 09/20] hmp: display memory encryption support in 'info kvm'

On 03/08/2017 02:52 PM, Brijesh Singh wrote: > update 'info kvm' to display the memory encryption support. > > (qemu) info kvm > kvm support: enabled > memory encryption: disabled > > Signed-off-by: Brijesh Singh > --- > +++ b/qapi-schema.json > @@ -185,9 +185,12 @@ > #

Re: [Qemu-devel] [RFC PATCH v4 11/20] sev: add LAUNCH_START command

On 03/08/2017 03:13 PM, Eduardo Habkost wrote: On Wed, Mar 08, 2017 at 03:53:03PM -0500, Brijesh Singh wrote: The command is used to bootstrap SEV guest from unencrypted boot images. The command creates a new VM encryption key (VEK) using guest owner's public DH certificate, and security

[Qemu-devel] [PATCH 1/3] backup: React to bdrv_is_allocated() errors

If bdrv_is_allocated() fails, we should immediately do the backup error action, rather than attempting backup_do_cow() (although that will likely fail too). Signed-off-by: Eric Blake --- block/backup.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [RFC PATCH v4 18/20] target/i386: add cpuid Fn8000_001f

On Wed, Mar 08, 2017 at 03:54:20PM -0500, Brijesh Singh wrote: > Fn8000_001f cpuid provides the memory encryption (aka C-bit) location > in a page table for the SEV-enabled guest. > > Signed-off-by: Brijesh Singh > --- > target/i386/cpu.c |6 ++ > 1 file changed,

[Qemu-devel] [RFC PATCH v4 17/20] target/i386: encrypt bios rom when memory encryption is enabled

If guest is launched with memory encryption enabled then we encrypt the data copied into pflash device also set the debug ops for PC.BIOS, PC.RAM and PLFASH memory regions. This will ensure that any debug access to these memory region will go through the memory encryption APIs. It cover both

[Qemu-devel] [RFC PATCH v4 19/20] target/i386: clear memory encryption bit when walking SEV guest page table

In SEV-enabled guest the pte entry will have C-bit set, we need to clear the C-bit when walking the page table. The C-bit position should be available in cpuid Fn8000_001f[EBX] Signed-off-by: Brijesh Singh --- target/i386/helper.c | 39 ++-

Re: [Qemu-devel] [RFC PATCH v4 20/20] migration: disable save/restore and migration when SEV is active

On Wed, Mar 08, 2017 at 03:54:43PM -0500, Brijesh Singh wrote: > Snapshot, Restore and Migration is not implemented yet. Return error when > user tries to perform any of these operations. > > Signed-off-by: Brijesh Singh > --- > migration/migration.c |7 +++ >

[Qemu-devel] [RFC PATCH v4 15/20] sev: add DEBUG_DECRYPT command

The command is used to decrypt a page of guest memory for debug. The command will be used by qemu monitor dump and gdbserver to access the guest memory for debug purposes. A typical usage look like: cpu_physical_memory_rw_debug cpu_physical_memory_rw_debug_internal sev_debug_decrypt

[Qemu-devel] [RFC PATCH v4 20/20] migration: disable save/restore and migration when SEV is active

Snapshot, Restore and Migration is not implemented yet. Return error when user tries to perform any of these operations. Signed-off-by: Brijesh Singh --- migration/migration.c |7 +++ migration/savevm.c| 11 +++ 2 files changed, 18 insertions(+)

Re: [Qemu-devel] [RFC PATCH v4 00/20] x86: Secure Encrypted Virtualization (AMD)

On 03/08/2017 03:27 PM, Eduardo Habkost wrote: On Wed, Mar 08, 2017 at 03:51:07PM -0500, Brijesh Singh wrote: This RFC series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. This RFC is based KVM RFC [1]. SEV is an extension to the AMD-V architecture which

[Qemu-devel] [PATCH 2/3] vvfat: React to bdrv_is_allocated() errors

If bdrv_is_allocated() fails, we should react to that failure. For 2 of the 3 callers, reporting the error was easy. But in cluster_was_modified() and its lone caller get_cluster_count_for_direntry(), it's rather invasive to update the logic to pass the error back; so there, I went with merely

[Qemu-devel] [RFC PATCH v4 07/20] kvm: add memory encryption api support

Add high level API's to provide guest memory encryption support. Signed-off-by: Brijesh Singh --- include/sysemu/kvm.h |7 +++ kvm-all.c| 52 ++ kvm-stub.c | 31

Re: [Qemu-devel] [RFC PATCH v4 00/20] x86: Secure Encrypted Virtualization (AMD)

On Wed, Mar 08, 2017 at 03:51:07PM -0500, Brijesh Singh wrote: > This RFC series provides support for AMD's new Secure Encrypted > Virtualization (SEV) feature. This RFC is based KVM RFC [1]. > > SEV is an extension to the AMD-V architecture which supports running > multiple VMs under the

[Qemu-devel] [PATCH for-2.9 0/3] Fix bdrv_is_allocated usage bugs

bdrv_is_allocated() returns tri-state, not just bool, although there were several callers using it as a bool. Fix them to either propagate the error or to document why treatment of failure like allocation is okay. [Found during a larger effort to convert bdrv_get_block_status to be byte-based

[Qemu-devel] [PATCH 3/3] migration: Document handling of bdrv_is_allocated() errors

Migration is the only code left in the tree that does not react to bdrv_is_allocated() failures. But as there is no useful way to react to the failure, and we are merely skipping unallocated sectors on success, just document that our choice of handling is intended. Signed-off-by: Eric Blake

[Qemu-devel] [RFC PATCH v4 18/20] target/i386: add cpuid Fn8000_001f

Fn8000_001f cpuid provides the memory encryption (aka C-bit) location in a page table for the SEV-enabled guest. Signed-off-by: Brijesh Singh --- target/i386/cpu.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index

[Qemu-devel] [RFC PATCH v4 14/20] sev: add LAUNCH_FINISH command

The command is used to finalize the SEV guest launch process. The command returns a measurement value of the data encrypted through the LAUNCH_UPDATE command. This measurement can be handed to the guest owner to verify that the guest was launched into SEV-enabled mode. Signed-off-by: Brijesh

[Qemu-devel] [RFC PATCH v4 05/20] monitor/i386: use debug apis when accessing guest memory

updates hmp monitor to use debug version of memory access apis when reading the guest memory. Signed-off-by: Brijesh Singh --- cpus.c|2 - disas.c |2 - monitor.c |2 - target/i386/helper.c | 16 +++

[Qemu-devel] [RFC PATCH v4 12/20] SEV: add GUEST_STATUS command

The command is used to retrieve status information about an SEV-enabled guest. Signed-off-by: Brijesh Singh --- include/sysemu/sev.h |9 + sev.c| 28 2 files changed, 37 insertions(+) diff --git

[Qemu-devel] [RFC PATCH v4 03/20] exec: add guest RAM read and write ops

In current implementation, read and write of the guest RAM is performed using using memcpy(). The patch adds support to register a callback which can override the memcpy() with something else. This feature will be used in Secure Encrypted Virtualization (SEV) guests in which read and write of

[Qemu-devel] [RFC PATCH v4 16/20] sev: add DEBUG_ENCRYPT command

The command is used to encrypt a region of guest memory for debug. The command will be used by gdbserver when writing the data into guest memory for debug purposes (e.g setting breakpoint) A typical usage looks like: cpu_memory_rw_debug cpu_physical_memory_rw_debug_internal

[Qemu-devel] [RFC PATCH v4 09/20] hmp: display memory encryption support in 'info kvm'

update 'info kvm' to display the memory encryption support. (qemu) info kvm kvm support: enabled memory encryption: disabled Signed-off-by: Brijesh Singh --- hmp.c|2 ++ qapi-schema.json |5 - qmp.c|1 + 3 files changed, 7

[Qemu-devel] [RFC PATCH v4 11/20] sev: add LAUNCH_START command

The command is used to bootstrap SEV guest from unencrypted boot images. The command creates a new VM encryption key (VEK) using guest owner's public DH certificate, and security policy and session parameters. The encryption key created during launch start process will be used for encryption the

[Qemu-devel] [RFC PATCH v4 10/20] vl: add memory encryption support

If memory encryption is enabled then create memory encryption launch context to ensure that bootstrap data (bios images) get encrypted. Also release the encryption context after machine is succesfully created. Signed-off-by: Brijesh Singh --- vl.c | 15 +++

[Qemu-devel] [RFC PATCH v4 01/20] kvm: update kvm.h header file

Updates kmv.h to include memory encryption ioctls and SEV command structure introduced in KVM RFC [1] [1] http://marc.info/?l=linux-mm=148846752931115=2 Signed-off-by: Brijesh Singh --- linux-headers/linux/kvm.h | 100 + 1

[Qemu-devel] [RFC PATCH v4 13/20] sev: add LAUNCH_UPDATE_DATA command

The command is used to encrypt a guest memory region using the VM Encryption Key (VEK) created by LAUNCH_START command. The firmware will also update the measurement with the contents of the memory region for attestation. Signed-off-by: Brijesh Singh ---

[Qemu-devel] [RFC PATCH v4 08/20] sev: add Secure Encrypted Virtulization (SEV) support

Adds initial support required to integrate Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the existing AMD-V technology found on AMD processors. The SEV feature allows the memory contents of a virtual machine to be transparently encrypted with a key unique to the guest VM.

[Qemu-devel] [RFC PATCH v4 06/20] core: add new security-policy object

The object can be used to define global security policy for the guest. object provides two properties: 1) debug: can be used to disable guest memory access from hypervisor. e.g to disable guest memory debug accesses # $QEMU \ -object security-policy,debug=false,id=mypolicy \

[Qemu-devel] [RFC PATCH v4 04/20] exec: add debug version of physical memory read and write api

The patch adds the following new APIs - cpu_physical_memory_read_debug - cpu_physical_memory_write_debug - cpu_physical_memory_rw_debug - ldl_phys_debug - ldq_phys_debug The idea behind this patch is that if all the qemu monitor memory dumps and gdbserver accesses are done through these common

[Qemu-devel] [RFC PATCH v4 02/20] memattrs: add debug attribute

Add a new debug attribute, the attribute should be set when guest memory accesses are performed for debug purposes. The attribute will be used in SEV guest, where we need to distinguish normal vs debug access to guest memory. In debug mode, we need to use SEV commands to access the guest memory.

Re: [Qemu-devel] [RFC PATCH v4 11/20] sev: add LAUNCH_START command

On Wed, Mar 08, 2017 at 03:53:03PM -0500, Brijesh Singh wrote: > The command is used to bootstrap SEV guest from unencrypted boot images. > The command creates a new VM encryption key (VEK) using guest owner's public > DH certificate, and security policy and session parameters. The encryption >

Re: [Qemu-devel] [RFC PATCH v4 07/20] kvm: add memory encryption api support

On Wed, Mar 08, 2017 at 03:52:26PM -0500, Brijesh Singh wrote: > Add high level API's to provide guest memory encryption support. > > Signed-off-by: Brijesh Singh > --- > include/sysemu/kvm.h |7 +++ > kvm-all.c| 52 >

Re: [Qemu-devel] Performance difference between QEMU 2.2.0 and 2.6.0

On 8 March 2017 at 18:17, Wenwen Wang wrote: > I just found that there is a significant performance difference between QEMU > version 2.2.0 and 2.6.0. > > Here are the execution times of the benchmark 458.sjeng from SPEC CINT2006 > with test workload using user only emulation

Re: [Qemu-devel] [PATCH for-2.9] block: Drop unmaintained 'archipelago' driver

On 08.03.2017 21:09, Eric Blake wrote: > On 03/08/2017 02:05 PM, Max Reitz wrote: >> On 08.03.2017 21:02, Eric Blake wrote: >>> The driver has failed to build since commit da34e65, in qemu 2.6, >>> due to a missing include of qapi/error.h for error_setg(). >>> Since no one has complained in three

Re: [Qemu-devel] [PATCH for-2.9] block: Drop unmaintained 'archipelago' driver

On 03/08/2017 02:05 PM, Max Reitz wrote: > On 08.03.2017 21:02, Eric Blake wrote: >> The driver has failed to build since commit da34e65, in qemu 2.6, >> due to a missing include of qapi/error.h for error_setg(). >> Since no one has complained in three releases, it is easier to >> remove the dead

Re: [Qemu-devel] [PATCH for-2.9] block: Drop unmaintained 'archipelago' driver

On 08.03.2017 21:02, Eric Blake wrote: > The driver has failed to build since commit da34e65, in qemu 2.6, > due to a missing include of qapi/error.h for error_setg(). > Since no one has complained in three releases, it is easier to > remove the dead code than to keep it around, especially since

Re: [Qemu-devel] [PATCH] target/ppc: Avoid printing wrong aliases in CPU help text

On Wed, Mar 08, 2017 at 08:05:36PM +0100, Thomas Huth wrote: > When running with KVM, we update the "family" CPU alias to point > to the right host CPU type, so that it is for example possible to > use "-cpu POWER8" on a POWER8NVL host. However, the function for > printing the list of available

[Qemu-devel] [PATCH for-2.9] block: Drop unmaintained 'archipelago' driver

The driver has failed to build since commit da34e65, in qemu 2.6, due to a missing include of qapi/error.h for error_setg(). Since no one has complained in three releases, it is easier to remove the dead code than to keep it around, especially since it is not being built by default and therefore

[Qemu-devel] [PATCH] target/ppc: Fix wrong number of UAMR register

The SPR UAMR has the number 13, and not 12. (Fortunately it seems like Linux is not using this register yet - only the privileged version with number 29 ... that's why nobody noticed this problem yet) Signed-off-by: Thomas Huth --- target/ppc/cpu.h | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH] qdev: Constify data pointed by few arguments and local variables

On Wed, Mar 08, 2017 at 09:34:19PM +0200, Krzysztof Kozlowski wrote: > On Wed, Mar 08, 2017 at 04:22:01PM -0300, Eduardo Habkost wrote: > > On Wed, Mar 08, 2017 at 09:06:06PM +0200, Krzysztof Kozlowski wrote: > > > > > The object_property_set_str() takes data as pointer to const. If data > > > > >

Re: [Qemu-devel] [PATCH] qdev: Constify data pointed by few arguments and local variables

On Wed, Mar 08, 2017 at 04:22:01PM -0300, Eduardo Habkost wrote: > On Wed, Mar 08, 2017 at 09:06:06PM +0200, Krzysztof Kozlowski wrote: > > > > The object_property_set_str() takes data as pointer to const. If data > > > > ends up as being non-const, then this is the mistake - > > > >

Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

On 03/08/2017 12:46 PM, Kevin Wolf wrote: >>> Oh, I meant to add: >>> >>> Should probably mention that it was commit da34e65 that introduced the >>> problem (if I'm right?). Does that mean we have not been compiling >>> archipelago.c since Mar 2016? >> >> At least here on my machine it does

Re: [Qemu-devel] [PATCH] qdev: Constify data pointed by few arguments and local variables

On Wed, Mar 08, 2017 at 09:06:06PM +0200, Krzysztof Kozlowski wrote: > On Wed, Mar 08, 2017 at 03:57:26PM -0300, Eduardo Habkost wrote: > > On Wed, Mar 08, 2017 at 06:22:13PM +0200, Krzysztof Kozlowski wrote: > > > On Mon, Mar 06, 2017 at 09:09:48AM -0300, Eduardo Habkost wrote: > > > > Hi, > > >

[Qemu-devel] [PATCH v2 for-2.10 4/4] block: Add some bdrv_truncate() error messages

Add missing error messages for the drivers I am comfortable to do this in. Since one of these changes touches a mis-indented block in block/file-posix.c, this patch fixes that coding style issue along the way. Signed-off-by: Max Reitz --- block/file-posix.c | 17

[Qemu-devel] [PATCH v2 for-2.10 3/4] block: Add errp to BD.bdrv_truncate()

Add an Error parameter to the block drivers' bdrv_truncate() interface. If a block driver does not set this in case of an error, the generic bdrv_truncate() implementation will do so. Where it is obvious, this patch also makes some block drivers set this value. Signed-off-by: Max Reitz

[Qemu-devel] [PATCH v2 for-2.10 1/4] block/vhdx: Make vhdx_create() always set errp

This patch makes vhdx_create() always set errp in case of an error. It also adds errp parameters to vhdx_create_bat() and vhdx_create_new_region_table() so we can pass on the error object generated by blk_truncate() as of a future commit. Signed-off-by: Max Reitz ---

[Qemu-devel] [PATCH v2 for-2.10 0/4] block: Add errp to b{lk, drv}_truncate()

Having an Error parameter for these functions makes sense because we sometimes want a bit more information than just "Something failed". Some drivers already use error_report() and the like to emit this additional information, so it's rather obvious that we do want a real error object here. v2:

[Qemu-devel] [PATCH v2 for-2.10 2/4] block: Add errp to b{lk, drv}_truncate()

For one thing, this allows us to drop the error message generation from qemu-img.c and blockdev.c and instead have it unified in bdrv_truncate(). Signed-off-by: Max Reitz --- include/block/block.h | 2 +- include/sysemu/block-backend.h | 2 +- block.c

Re: [Qemu-devel] [PATCH] qdev: Constify data pointed by few arguments and local variables

On Wed, Mar 08, 2017 at 03:57:26PM -0300, Eduardo Habkost wrote: > On Wed, Mar 08, 2017 at 06:22:13PM +0200, Krzysztof Kozlowski wrote: > > On Mon, Mar 06, 2017 at 09:09:48AM -0300, Eduardo Habkost wrote: > > > Hi, > > > > > > > > > On Sun, Mar 05, 2017 at 11:46:33PM +0200, Krzysztof Kozlowski

[Qemu-devel] [PATCH] target/ppc: Avoid printing wrong aliases in CPU help text

When running with KVM, we update the "family" CPU alias to point to the right host CPU type, so that it is for example possible to use "-cpu POWER8" on a POWER8NVL host. However, the function for printing the list of available CPU models is called earlier than the KVM setup code, so the output of

Re: [Qemu-devel] [PULL v2 07/24] nbd: convert to use qio_channel_yield

On 06.03.2017 22:04, Max Reitz wrote: > On 21.02.2017 12:56, Stefan Hajnoczi wrote: >> From: Paolo Bonzini >> >> In the client, read the reply headers from a coroutine, switching the >> read side between the "read header" coroutine and the I/O coroutine that >> reads the body

Re: [Qemu-devel] [PATCH] qdev: Constify data pointed by few arguments and local variables

On Wed, Mar 08, 2017 at 06:22:13PM +0200, Krzysztof Kozlowski wrote: > On Mon, Mar 06, 2017 at 09:09:48AM -0300, Eduardo Habkost wrote: > > Hi, > > > > > > On Sun, Mar 05, 2017 at 11:46:33PM +0200, Krzysztof Kozlowski wrote: > > > In few places the function arguments and local variables are not

Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

Am 08.03.2017 um 19:32 hat Max Reitz geschrieben: > On 08.03.2017 19:28, Eric Blake wrote: > > On 03/08/2017 12:25 PM, Eric Blake wrote: > >> On 03/08/2017 12:18 PM, Max Reitz wrote: > >>> In order to use error_setg() and similar functions, we need to include > >>> qapi/error.h. > >>> > >>>

Re: [Qemu-devel] [PATCH] X86/HMP: Expose x86 model specific registers via human monitor

On Wed, Mar 08, 2017 at 05:08:42PM +0100, Julian Kirsch wrote: > On 08.03.2017 14:57, Eduardo Habkost wrote: > > >> > >> This should be abstracted some how so that we don't need > >> x86 specifics in cpus.c; perhaps just an architecture call > >> back on the CPU. > > > > If it's only supported

Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

On 03/08/2017 03:25 PM, Eric Blake wrote: On 03/08/2017 12:18 PM, Max Reitz wrote: In order to use error_setg() and similar functions, we need to include qapi/error.h. Signed-off-by: Max Reitz --- block/archipelago.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by:

Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

On 08.03.2017 19:28, Eric Blake wrote: > On 03/08/2017 12:25 PM, Eric Blake wrote: >> On 03/08/2017 12:18 PM, Max Reitz wrote: >>> In order to use error_setg() and similar functions, we need to include >>> qapi/error.h. >>> >>> Signed-off-by: Max Reitz >>> --- >>>

Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

On 03/08/2017 12:25 PM, Eric Blake wrote: > On 03/08/2017 12:18 PM, Max Reitz wrote: >> In order to use error_setg() and similar functions, we need to include >> qapi/error.h. >> >> Signed-off-by: Max Reitz >> --- >> block/archipelago.c | 1 + >> 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

On 08.03.2017 19:25, Eric Blake wrote: > On 03/08/2017 12:18 PM, Max Reitz wrote: >> In order to use error_setg() and similar functions, we need to include >> qapi/error.h. >> >> Signed-off-by: Max Reitz >> --- >> block/archipelago.c | 1 + >> 1 file changed, 1 insertion(+) >

Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

On 03/08/2017 12:18 PM, Max Reitz wrote: > In order to use error_setg() and similar functions, we need to include > qapi/error.h. > > Signed-off-by: Max Reitz > --- > block/archipelago.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake

[Qemu-devel] [Bug 1274170] Re: qemu window hides in the background on osx

This seems to only affect fullscreen mode, so if that's the case, I don't see it as resolved. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1274170 Title: qemu window hides in the background on

[Qemu-devel] Performance difference between QEMU 2.2.0 and 2.6.0

Hello all, I just found that there is a significant performance difference between QEMU version 2.2.0 and 2.6.0. Here are the execution times of the benchmark 458.sjeng from SPEC CINT2006 with test workload using user only emulation from ARM guest to x86-32 host: qemu-2.2.0: 29 seconds

[Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

In order to use error_setg() and similar functions, we need to include qapi/error.h. Signed-off-by: Max Reitz --- block/archipelago.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/archipelago.c b/block/archipelago.c index 2449cfc702..01c4ff2f7d 100644 ---

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Mar 08, 2017 at 09:59:32AM -0800, ashish mittal wrote: > On Wed, Mar 8, 2017 at 5:04 AM, Ketan Nilangekar > wrote: > > > > > >> On Mar 8, 2017, at 1:13 AM, Daniel P. Berrange wrote: > >> > >>> On Tue, Mar 07, 2017 at 05:27:55PM -0800,

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Mar 8, 2017 at 5:04 AM, Ketan Nilangekar wrote: > > >> On Mar 8, 2017, at 1:13 AM, Daniel P. Berrange wrote: >> >>> On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: >>> Thanks! There is one more input I need some help with!

Re: [Qemu-devel] [PATCH v2 0/9] SMMUv3 Emulation support

Hi, On 22/08/2016 18:17, Prem Mallappa wrote: > v1 -> v2: > - Adopted review comments from Eric Auger > - Make SMMU_DPRINTF to internally call qemu_log > (since translation requests are too many, we need control >on the type of log we want)

Re: [Qemu-devel] [PATCH 1/2] RAMBlocks: qemu_ram_is_shared

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 03/07/2017 07:36 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Provide a helper to say whether a RAMBlock was created as a > > shared mapping. > > > > Signed-off-by: Dr. David

Re: [Qemu-devel] [PATCH 1/2] RAMBlocks: qemu_ram_is_shared

On 03/07/2017 07:36 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Provide a helper to say whether a RAMBlock was created as a > shared mapping. > > Signed-off-by: Dr. David Alan Gilbert > --- > exec.c

[Qemu-devel] [Bug 1671173] [NEW] OS started to crash with a message: "Trying to execute code outside RAM or ROM"

Public bug reported: There is a project (https://github.com/narke/colorForth ) wich always worked with qemu up to version 2.5.1.1 but doesn't works from version 2.6 onwards. It continues to work with bochs. Downlaod: git clone https://github.com/narke/colorForth.git Build: make Test:

Re: [Qemu-devel] [PATCH for-2.10 1/3] block: Add errp to b{lk, drv}_truncate()

On 07.03.2017 11:47, Kevin Wolf wrote: > Am 06.03.2017 um 20:54 hat Max Reitz geschrieben: >> For one thing, this allows us to drop the error message generation from >> qemu-img.c and blockdev.c and instead have it unified in >> bdrv_truncate(). >> >> Signed-off-by: Max Reitz >

Re: [Qemu-devel] [PATCH V3] virtio: do not require IOMMU to be created in advance

On Tue, 7 Mar 2017 14:47:30 +0200 Marcel Apfelbaum wrote: > On 03/07/2017 11:09 AM, Jason Wang wrote: > > After commit 96a8821d2141 ("virtio: unbreak virtio-pci with IOMMU > > after caching ring translations"), IOMMU was required to be created in > > advance. This is because

Re: [Qemu-devel] [PATCH] qdev: Constify data pointed by few arguments and local variables

On Mon, Mar 06, 2017 at 09:09:48AM -0300, Eduardo Habkost wrote: > Hi, > > > On Sun, Mar 05, 2017 at 11:46:33PM +0200, Krzysztof Kozlowski wrote: > > In few places the function arguments and local variables are not > > modifying data passed through pointers so this can be made const for > > code

Re: [Qemu-devel] [PATCH] X86/HMP: Expose x86 model specific registers via human monitor

On 08.03.2017 14:57, Eduardo Habkost wrote: >> >> This should be abstracted some how so that we don't need >> x86 specifics in cpus.c; perhaps just an architecture call >> back on the CPU. > > If it's only supported by x86, I would just move the > implementation to a x86-specific file, and add a

Re: [Qemu-devel] [PATCH v2] qmp-shell: add persistent command history

On Wed, Mar 8, 2017 at 8:29 AM, Markus Armbruster wrote: > John Snow writes: > >> On 03/07/2017 03:16 AM, Markus Armbruster wrote: >>> John Snow writes: >>> On 03/06/2017 03:18 AM, Markus Armbruster wrote: > Nir Soffer

Re: [Qemu-devel] [PATCH for-2.10 1/3] block: Add errp to b{lk, drv}_truncate()

On 07.03.2017 11:47, Kevin Wolf wrote: > Am 06.03.2017 um 20:54 hat Max Reitz geschrieben: >> For one thing, this allows us to drop the error message generation from >> qemu-img.c and blockdev.c and instead have it unified in >> bdrv_truncate(). >> >> Signed-off-by: Max Reitz >

Re: [Qemu-devel] [PATCH 2/2] vl: Print CPU help after we've registered the CPU accelerators

On 08.03.2017 15:50, Eduardo Habkost wrote: > On Wed, Mar 08, 2017 at 03:31:01PM +0100, Peter Maydell wrote: >> On 3 March 2017 at 15:58, Eduardo Habkost wrote: >>> On Tue, Jan 31, 2017 at 02:11:59PM +0100, Thomas Huth wrote: When running with KVM on POWER, we register

Re: [Qemu-devel] [PATCH] X86/HMP: Expose x86 model specific registers via human monitor

On 08.03.2017 12:59, Dr. David Alan Gilbert wrote: > * Julian Kirsch (g...@kirschju.re) wrote: > > I'll leave those who know more about gdb to answer whether that's the best way > of doing it; but I can see them being useful to those just trying to debug > stuff from the monitor. > Just want to

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.9? v2] tests: Ignore more test executables

On 08/03/2017 16:15, Eric Blake wrote: > Ignore test executables when building in-tree: > test-arm-mptimer introduced in commit 882fac3 > test-crypto-hmac introduced in commit 4fd460b > test-aio-multithread introduced in commit 0c330a7 > > Signed-off-by: Eric Blake

  1   2   >