[Qemu-devel]   [PATCHV2] COLO: COLO-FT.txt err

2017-03-17 Thread wang.guang55
This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: Guang Wang<wang.guan...@zte.com.cn> diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index e289be2..754efda 100644 --- a/docs/COLO-FT.txt +++ b/docs/COLO-FT.txt @@ -139,7 +139,7 @@ Secondary:

[Qemu-devel] [PATCH] COLO: COLO-FT.txt err

2017-03-17 Thread wang.guang55
This is an error in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by: Guang Wang<wang.guan...@zte.com.cn> diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index e289be2..754efda 100644 --- a/docs/COLO-FT.txt +++ b/docs/COLO-FT.txt @@ -139,7 +139,7 @@ Secondary: {

[Qemu-devel] [Bug 1194954] Re: Windows 95 guest reboots itself on qemu 1.5.0 & 1.5.50 (GIT)

2017-03-17 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1194954 Title: Windows 95

Re: [Qemu-devel] [PATCH v2 0/3] qemu-img: improve qemu-img getopt error messages

2017-03-17 Thread Max Reitz
On 17.03.2017 11:45, Stefan Hajnoczi wrote: > v2: > * Print short help to avoid obscuring error messages [Max] > > This series improves getopt error messages. Unrecognized global options were > skipped rather than causing qemu-img to exit as expected. Also avoid printing > the full help text

Re: [Qemu-devel] [PATCH v2 3/3] qemu-img: print short help on getopt failure

2017-03-17 Thread Max Reitz
On 17.03.2017 11:45, Stefan Hajnoczi wrote: > Printing the full help output obscures the error message for an invalid > command-line option or missing argument. > > Before this patch: > > $ ./qemu-img --foo > ...pages of output... > > After this patch: > > $ ./qemu-img --foo >

Re: [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO

2017-03-17 Thread Max Reitz
On 08.02.2017 00:57, Max Reitz wrote: > Currently we only print progress information on retrieval of SIGUSR1. > Some systems have a dedicated SIGINFO for this, however, so it should be > handled appropriately if it is available. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1662468 >

Re: [Qemu-devel] [Qemu-block] [PATCH] curl: fix compilation on OpenBSD

2017-03-17 Thread Max Reitz
On 17.03.2017 16:24, Paolo Bonzini wrote: > EPROTO is not found in OpenBSD. We usually use EIO when no better > errno is available, do that here too. > > Reported-by: Peter Maydell > Signed-off-by: Paolo Bonzini > --- > block/curl.c | 2 +- > 1

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-17 Thread ashish mittal
On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal wrote: > On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange > wrote: >> On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: >>> Thanks! There is one more input I need some help with! >>> >>>

Re: [Qemu-devel] [RFC v2 1/8] block: add bdrv_measure() API

2017-03-17 Thread Nir Soffer
On Wed, Mar 15, 2017 at 11:29 AM Stefan Hajnoczi wrote: > bdrv_measure() provides a conservative maximum for the size of a new > image. This information is handy if storage needs to be allocated (e.g. > a SAN or an LVM volume) ahead of time. > > Signed-off-by: Stefan

Re: [Qemu-devel] [RFC v2 2/8] raw-format: add bdrv_measure() support

2017-03-17 Thread Nir Soffer
On Wed, Mar 15, 2017 at 11:29 AM Stefan Hajnoczi wrote: > Maximum size calculation is trivial for the raw format: it's just the > requested image size (because there is no metadata). > > Signed-off-by: Stefan Hajnoczi > --- > block/raw-format.c | 22

Re: [Qemu-devel] [RFC v2 1/8] block: add bdrv_measure() API

2017-03-17 Thread Nir Soffer
On Wed, Mar 15, 2017 at 11:29 AM Stefan Hajnoczi wrote: > bdrv_measure() provides a conservative maximum for the size of a new > image. This information is handy if storage needs to be allocated (e.g. > a SAN or an LVM volume) ahead of time. > > Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH v3] 9pfs: proxy: assert if unmarshal fails

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 08:20 PM, Greg Kurz wrote: Replies from the virtfs proxy are made up of a fixed-size header (8 bytes) and a payload of variable size (maximum 64kb). When receiving a reply, the proxy backend first reads the whole header and then unmarshals it. If the header is okay, it then does

Re: [Qemu-devel] [RFC v2 0/8] qemu-img: add measure sub-command

2017-03-17 Thread Nir Soffer
On Wed, Mar 15, 2017 at 11:29 AM Stefan Hajnoczi wrote: > RFCv2: > * Publishing RFC again to discuss the new user-visible interfaces. Code > has >changed quite a bit, I have not kept any Reviewed-by tags. > * Rename qemu-img sub-command "measure" and API

Re: [Qemu-devel] Dual userfaultfd behavior

2017-03-17 Thread Mike Kravetz
On 03/15/2017 06:47 AM, Alexey Perevalov wrote: > Hi Andrea, > > thank you for so perfect design description, > > the main question who will do RFC patches, > you or Mike or if you not against I could try. Sorry for not replying sooner, I have been away from e-mail. I have some other projects

[Qemu-devel] [PATCH v3] 9pfs: proxy: assert if unmarshal fails

2017-03-17 Thread Greg Kurz
Replies from the virtfs proxy are made up of a fixed-size header (8 bytes) and a payload of variable size (maximum 64kb). When receiving a reply, the proxy backend first reads the whole header and then unmarshals it. If the header is okay, it then does the same operation with the payload. Since

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Richard Henderson
On 03/17/2017 09:52 PM, Peter Maydell wrote: On 17 March 2017 at 11:49, Daniel P. Berrange wrote: On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell wrote: We plan to drop support in a future QEMU release for host OSes and host architectures for which we have no test

Re: [Qemu-devel] [Qemu-ppc] [PATCH 48/77] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge

2017-03-17 Thread Benjamin Herrenschmidt
On Fri, 2017-03-17 at 09:24 +0100, Cédric Le Goater wrote: > I changed that to : > >     pnv_phb3_msi_update_config(phb->msis, comp, count - PHB_NUM_LSI); > > else the IRQ numbers overlap with the LSI and I think this why we > were  > uselessly looping on the EOI. > > Correct ?  Quite possibly

Re: [Qemu-devel] [LSF/MM TOPIC][LSF/MM, ATTEND] shared TLB, hugetlb reservations

2017-03-17 Thread Mike Kravetz
On 03/14/2017 11:37 AM, Andrea Arcangeli wrote: > Hello, > > On Wed, Mar 08, 2017 at 05:30:55PM -0800, Mike Kravetz wrote: >> On 01/10/2017 03:02 PM, Mike Kravetz wrote: >>> Another more concrete topic is hugetlb reservations. Michal Hocko >>> proposed the topic "mm patches review bandwidth",

[Qemu-devel] [BUG] virtio-net linux driver fails to probe on MIPS Malta since 'hw/virtio-pci: fix virtio behaviour'

2017-03-17 Thread James Hogan
Hi, I've bisected the following failure of the virtio_net linux v4.10 driver to probe in QEMU v2.9.0-rc1 emulating a MIPS Malta machine: virtio_net virtio0: virtio: device uses modern interface but does not have VIRTIO_F_VERSION_1 virtio_net: probe of virtio0 failed with error -22 To QEMU

[Qemu-devel] [PATCH] Add 'none' as type for drive's if option

2017-03-17 Thread Craig Jellick
Signed-off-by: Craig Jellick --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 99af8ed..8291e64 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -591,7 +591,7 @@ Special files such as iSCSI

Re: [Qemu-devel] [PATCH] xen: use libxendevice model to restrict operations

2017-03-17 Thread Philippe Mathieu-Daudé
Hi Paul, On 03/17/2017 10:30 AM, Paul Durrant wrote: This patch adds a command-line option (-xen-domid-restrict) which will use the new libxendevicemodel API to restrict devicemodel operations to the specified domid. This patch also adds a tracepoint to allow successful enabling of the

Re: [Qemu-devel] [PATCH v6] nios2: Add Altera JTAG UART emulation

2017-03-17 Thread Marek Vasut
On 03/14/2017 02:56 PM, Tobias Klauser wrote: > On 2017-02-13 at 01:56:43 +0100, Juro Bystricky > wrote: >> Add the Altera JTAG UART model. >> >> Hardware emulation based on: >> https://www.altera.com/en_US/pdfs/literature/ug/ug_embedded_ip.pdf >> (Please see "Register

Re: [Qemu-devel] [PATCH V2] nios2: iic: Convert CPU prop to qom link

2017-03-17 Thread Marek Vasut
On 03/17/2017 05:51 PM, Peter Maydell wrote: > On 27 February 2017 at 19:38, Marek Vasut wrote: >> Add a const qom link between the CPU and the IIC instead >> of passing the CPU link through a qom property. >> >> Signed-off-by: Marek Vasut >> Cc: Alexander Graf

Re: [Qemu-devel] [PATCH V2] nios2: iic: Convert CPU prop to qom link

2017-03-17 Thread Marek Vasut
On 03/17/2017 06:09 PM, Markus Armbruster wrote: > Marek Vasut writes: > >> Add a const qom link between the CPU and the IIC instead >> of passing the CPU link through a qom property. >> >> Signed-off-by: Marek Vasut >> Cc: Alexander Graf >> Cc:

[Qemu-devel] [PATCH V3] nios2: iic: Convert CPU prop to qom link

2017-03-17 Thread Marek Vasut
Add a const qom link between the CPU and the IIC instead of passing the CPU link through a qom property. Signed-off-by: Marek Vasut Cc: Alexander Graf Cc: Chris Wulff Cc: Igor Mammedov Cc: Jeff Da Silva

Re: [Qemu-devel] [PATCH v3 3/9] 9p: introduce a type for the 9p header

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 08:16 AM, Greg Kurz wrote: On Thu, 16 Mar 2017 13:01:52 -0700 Stefano Stabellini wrote: Use the new type in virtio-9p-device. Signed-off-by: Stefano Stabellini CC: anthony.per...@citrix.com CC: jgr...@suse.com CC: Aneesh Kumar K.V

Re: [Qemu-devel] [RFC PATCH 0/4] Qemu: Add Xen vIOMMU support

2017-03-17 Thread Stefano Stabellini
On Fri, 17 Mar 2017, Paolo Bonzini wrote: > On 17/03/2017 12:29, Lan Tianyu wrote: > > This patchset is to add Xen vIOMMU device model and handle > > irq remapping stuffs. Xen vIOMMU emulation is in the Xen hypervisor > > and the new device module in Qemu works as hypercall wrappers to > > create

Re: [Qemu-devel] [PULL 11/24] tcg: enable thread-per-vCPU

2017-03-17 Thread Alex Bennée
Laurent Vivier writes: > Le 27/02/2017 à 15:38, Alex Bennée a écrit : >> >> Laurent Vivier writes: >> >>> Le 24/02/2017 à 12:20, Alex Bennée a écrit : There are a couple of changes that occur at the same time here: - introduce a single

Re: [Qemu-devel] [PATCH 13/16] migration: Create thread infrastructure for multifd recv side

2017-03-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 17/03/2017 14:02, Dr. David Alan Gilbert wrote: > >>> case RAM_SAVE_FLAG_MULTIFD_PAGE: > >>> fd_num = qemu_get_be16(f); > >>> -if (fd_num != 0) { > >>> -/* this is yet an unused variable,

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 18:32, Ed Swierk wrote: > On Fri, Mar 17, 2017 at 10:15 AM, Paolo Bonzini wrote: >> >> >> On 17/03/2017 18:11, Paolo Bonzini wrote: >>> >>> >>> On 17/03/2017 17:55, Ed Swierk wrote: I'm running into the same problem taking an external snapshot with a

Re: [Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-17 Thread Stefano Stabellini
On Fri, 17 Mar 2017, Juergen Gross wrote: > On 16/03/17 21:20, Stefano Stabellini wrote: > > On Thu, 16 Mar 2017, Juergen Gross wrote: > >> Instead of trying to guess the Xen version to use by compiling various > >> test programs first just ask the system via pkg-config. Only if it > >> can't

Re: [Qemu-devel] [PATCH for-2.9 v2] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 09:32 AM, Fam Zheng wrote: For one thing we shouldn't continue if an error happened, for the other two steps failing can cause an abort() in error_setg because we reuse the same errp blindly. Add error handling checks to fix both issues. Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH] oslib-posix: fix compilation on OpenBSD

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 12:22 PM, Paolo Bonzini wrote: si_band is not found in OpenBSD. It is marked as obsolescent in POSIX, so we can delete it without any remorse. Reported-by: Peter Maydell Signed-off-by: Paolo Bonzini Reviewed-by: Philippe

[Qemu-devel] [PULL for 2.9 0/2] target/xtensa fixes

2017-03-17 Thread Max Filippov
repository at: git://github.com/OSLL/qemu-xtensa.git tags/20170317-xtensa for you to fetch changes up to f289bb091e6876df2e0e3481cb414c277695a405: target/xtensa: fix semihosting argc/argv implementation (2017-03-11 14:59:03 -0800

Re: [Qemu-devel] [PATCH v3 7/9] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal

2017-03-17 Thread Stefano Stabellini
On Fri, 17 Mar 2017, Greg Kurz wrote: > On Thu, 16 Mar 2017 13:01:56 -0700 > Stefano Stabellini wrote: > > > Implement xen_9pfs_init_in/out_iov_from_pdu and > > xen_9pfs_pdu_vmarshal/vunmarshall by creating new sg pointing to the > > data on the ring. > > > > This is

Re: [Qemu-devel] [PATCH] curl: fix compilation on OpenBSD

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 12:24 PM, Paolo Bonzini wrote: EPROTO is not found in OpenBSD. We usually use EIO when no better errno is available, do that here too. Reported-by: Peter Maydell Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 18:32, Ed Swierk wrote: > On Fri, Mar 17, 2017 at 10:15 AM, Paolo Bonzini wrote: >> >> >> On 17/03/2017 18:11, Paolo Bonzini wrote: >>> >>> >>> On 17/03/2017 17:55, Ed Swierk wrote: I'm running into the same problem taking an external snapshot with a

Re: [Qemu-devel] [PATCH for 2.9 v2] configure: remove Cygwin

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 17:52, Stefan Weil wrote: > Am 17.03.2017 um 17:08 schrieb Paolo Bonzini: >> >> The Cygwin target is really compiling for native Win32 with -mno-cygwin. >> Except, GCC 4.7.0 has finally removed the long deprecated -mno-cygwin >> option, and that happened

Re: [Qemu-devel] [PATCH for 2.9 v2] configure: remove Cygwin

2017-03-17 Thread Stefan Weil
Am 17.03.2017 um 17:08 schrieb Paolo Bonzini: The Cygwin target is really compiling for native Win32 with -mno-cygwin. Except, GCC 4.7.0 has finally removed the long deprecated -mno-cygwin option, and that happened about five years ago. Let it rest in peace. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v3 5/9] xen/9pfs: connect to the frontend

2017-03-17 Thread Stefano Stabellini
On Fri, 17 Mar 2017, Greg Kurz wrote: > On Thu, 16 Mar 2017 13:01:54 -0700 > Stefano Stabellini wrote: > > > Write the limits of the backend to xenstore. Connect to the frontend. > > Upon connection, allocate the rings according to the protocol > > specification. > > > >

Re: [Qemu-devel] [PATCH v3 1/9] xen: do not build backends for targets that do not support xen

2017-03-17 Thread Stefano Stabellini
On Fri, 17 Mar 2017, Paolo Bonzini wrote: > On 16/03/2017 21:01, Stefano Stabellini wrote: > > Change Makefile.objs to use CONFIG_XEN instead of CONFIG_XEN_BACKEND, so > > that the Xen backends are only built for targets that support Xen. > > > > Set CONFIG_XEN in the toplevel Makefile to ensure

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Ed Swierk
On Fri, Mar 17, 2017 at 10:15 AM, Paolo Bonzini wrote: > > > On 17/03/2017 18:11, Paolo Bonzini wrote: >> >> >> On 17/03/2017 17:55, Ed Swierk wrote: >>> I'm running into the same problem taking an external snapshot with a >>> virtio-blk drive with iothread, so it's not

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 18:11, Paolo Bonzini wrote: > > > On 17/03/2017 17:55, Ed Swierk wrote: >> I'm running into the same problem taking an external snapshot with a >> virtio-blk drive with iothread, so it's not specific to virtio-scsi. >> Run a Linux guest on qemu master >> >> qemu-system-x86_64

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 17:55, Ed Swierk wrote: > I'm running into the same problem taking an external snapshot with a > virtio-blk drive with iothread, so it's not specific to virtio-scsi. > Run a Linux guest on qemu master > > qemu-system-x86_64 -nographic -enable-kvm -monitor >

Re: [Qemu-devel] [PATCH V2] nios2: iic: Convert CPU prop to qom link

2017-03-17 Thread Markus Armbruster
Marek Vasut writes: > Add a const qom link between the CPU and the IIC instead > of passing the CPU link through a qom property. > > Signed-off-by: Marek Vasut > Cc: Alexander Graf > Cc: Chris Wulff > Cc: Igor Mammedov

[Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Ed Swierk
I'm running into the same problem taking an external snapshot with a virtio-blk drive with iothread, so it's not specific to virtio-scsi. Run a Linux guest on qemu master qemu-system-x86_64 -nographic -enable-kvm -monitor telnet:0.0.0.0:1234,server,nowait -m 1024 -object iothread,id=iothread1

Re: [Qemu-devel] [PATCH V2] nios2: iic: Convert CPU prop to qom link

2017-03-17 Thread Peter Maydell
On 27 February 2017 at 19:38, Marek Vasut wrote: > Add a const qom link between the CPU and the IIC instead > of passing the CPU link through a qom property. > > Signed-off-by: Marek Vasut > Cc: Alexander Graf > Cc: Chris Wulff >

Re: [Qemu-devel] [PATCH v2] 9pfs: proxy: assert if unmarshal fails

2017-03-17 Thread Greg Kurz
On Fri, 17 Mar 2017 12:06:39 -0300 Philippe Mathieu-Daudé wrote: > On 03/17/2017 11:43 AM, Daniel P. Berrange wrote: > > On Fri, Mar 17, 2017 at 03:39:10PM +0100, Greg Kurz wrote: > >> Replies from the virtfs proxy are made up of a fixed-size header (8 bytes) > >> and a

[Qemu-devel] [PATCH for 2.9 v2] configure: remove Cygwin

2017-03-17 Thread Paolo Bonzini
The Cygwin target is really compiling for native Win32 with -mno-cygwin. Except, GCC 4.7.0 has finally removed the long deprecated -mno-cygwin option, and that happened about five years ago. Let it rest in peace. Signed-off-by: Paolo Bonzini --- bsd-user/mmap.c | 5 -

Re: [Qemu-devel] [PATCH 13/16] migration: Create thread infrastructure for multifd recv side

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 14:02, Dr. David Alan Gilbert wrote: >>> case RAM_SAVE_FLAG_MULTIFD_PAGE: >>> fd_num = qemu_get_be16(f); >>> -if (fd_num != 0) { >>> -/* this is yet an unused variable, changed later */ >>> -fd_num = fd_num; >>> -

Re: [Qemu-devel] [PATCH v2] 9pfs: proxy: assert if unmarshal fails

2017-03-17 Thread Greg Kurz
On Fri, 17 Mar 2017 14:43:00 + "Daniel P. Berrange" wrote: > On Fri, Mar 17, 2017 at 03:39:10PM +0100, Greg Kurz wrote: > > Replies from the virtfs proxy are made up of a fixed-size header (8 bytes) > > and a payload of variable size (maximum 64kb). When receiving a

[Qemu-devel] [PATCH for 2.9] configure: remove Cygwin

2017-03-17 Thread Paolo Bonzini
The Cygwin target is really compiling for native Win32 with -mno-cygwin. Except, GCC 4.7.0 has finally removed the long deprecated -mno-cygwin option, and that happened about five years ago. Let it rest in peace. Signed-off-by: Paolo Bonzini --- bsd-user/mmap.c | 5 -

[Qemu-devel] ui/console.h does #include but it is used from files which don't build with OPENGL_CFLAGS

2017-03-17 Thread Peter Maydell
Our header include/ui/console.h will #include . Unfortunately that header isn't guaranteed to be on the include path, because configure puts the CFLAGS that ensure it is (ie the output of pkg-config --cflags epoxy) into OPENGL_CFLAGS, and we only build certain object files with it. So a file like

[Qemu-devel] [PATCH] curl: fix compilation on OpenBSD

2017-03-17 Thread Paolo Bonzini
EPROTO is not found in OpenBSD. We usually use EIO when no better errno is available, do that here too. Reported-by: Peter Maydell Signed-off-by: Paolo Bonzini --- block/curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH] oslib-posix: fix compilation on OpenBSD

2017-03-17 Thread Paolo Bonzini
si_band is not found in OpenBSD. It is marked as obsolescent in POSIX, so we can delete it without any remorse. Reported-by: Peter Maydell Signed-off-by: Paolo Bonzini --- util/oslib-posix.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [Qemu-devel] [PULL 06/17] cpus: remove ugly cast on sigbus_handler

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 16:08, Peter Maydell wrote: > On 27 February 2017 at 16:49, Paolo Bonzini wrote: >> The cast is there because sigbus_handler is invoked via sigfd_handler. >> But it feels just wrong to use struct qemu_signalfd_siginfo in the >> prototype of a function that is

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 11:08, Peter Maydell wrote: > This commit flags up as deprecated the CPU architectures: > * ia64 > * sparc > * anything which we don't have a TCG port for >(and which was presumably using TCI) > and the OSes: > * Cygwin > * GNU/kFreeBSD > *

Re: [Qemu-devel] [PULL 06/17] cpus: remove ugly cast on sigbus_handler

2017-03-17 Thread Peter Maydell
On 27 February 2017 at 16:49, Paolo Bonzini wrote: > The cast is there because sigbus_handler is invoked via sigfd_handler. > But it feels just wrong to use struct qemu_signalfd_siginfo in the > prototype of a function that is passed to sigaction. > > Instead, do a

Re: [Qemu-devel] [PATCH v2] 9pfs: proxy: assert if unmarshal fails

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 11:43 AM, Daniel P. Berrange wrote: On Fri, Mar 17, 2017 at 03:39:10PM +0100, Greg Kurz wrote: Replies from the virtfs proxy are made up of a fixed-size header (8 bytes) and a payload of variable size (maximum 64kb). When receiving a reply, the proxy backend first reads the whole

[Qemu-devel] make fails with confusing message if sdl audio enabled but sdl graphics not

2017-03-17 Thread Peter Maydell
If you configure like this: configure --disable-sdl --audio-drv-list=sdl then configure will succeed but attempting to make fails with a confusing message: $ make Makefile:259: *** ui/sdl.mo added in common-obj-y but ui/sdl.mo-objs is not set. Stop. (I actually encountered this on an OpenBSD

Re: [Qemu-devel] callout to *file in bdrv_co_get_block_status

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 12:24, Fam Zheng wrote: > On Fri, 03/17 12:16, Paolo Bonzini wrote: >> >> >> On 17/03/2017 12:11, Peter Lieven wrote: > like VMDK or QCOW2 shouldn't we trust the information from the l2 tables > in the VMDK or QCOW2? It provides additional information, for example it

Re: [Qemu-devel] [RFC PATCH 0/4] Qemu: Add Xen vIOMMU support

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 12:29, Lan Tianyu wrote: > This patchset is to add Xen vIOMMU device model and handle > irq remapping stuffs. Xen vIOMMU emulation is in the Xen hypervisor > and the new device module in Qemu works as hypercall wrappers to > create and destroy vIOMMU in hypervisor. > > Xen only

Re: [Qemu-devel] [PATCH] ui/egl-helpers: fix egl 1.5 display init

2017-03-17 Thread Marc-André Lureau
On Fri, Mar 17, 2017 at 12:12 PM Gerd Hoffmann wrote: > Unfortunaly switching to getPlatformDisplayEXT isn't as easy as > implemented by 0ea1523fb6703aa0dcd65e66b59e96fec028e60a. See the > longish comment for the complete story. > > Cc: Frediano Ziglio >

Re: [Qemu-devel] [PATCH] ui/egl-helpers: fix egl 1.5 display init

2017-03-17 Thread Frediano Ziglio
> > On 03/17/2017 05:53 AM, Marc-André Lureau wrote: > > On Fri, Mar 17, 2017 at 12:12 PM Gerd Hoffmann wrote: > > > >> Unfortunaly switching to getPlatformDisplayEXT isn't as easy as > >> implemented by 0ea1523fb6703aa0dcd65e66b59e96fec028e60a. See the > >> longish comment

Re: [Qemu-devel] [PATCH v2] 9pfs: proxy: assert if unmarshal fails

2017-03-17 Thread Daniel P. Berrange
On Fri, Mar 17, 2017 at 03:39:10PM +0100, Greg Kurz wrote: > Replies from the virtfs proxy are made up of a fixed-size header (8 bytes) > and a payload of variable size (maximum 64kb). When receiving a reply, > the proxy backend first reads the whole header and then unmarshals it. > If the header

[Qemu-devel] [PATCH v2] 9pfs: proxy: assert if unmarshal fails

2017-03-17 Thread Greg Kurz
Replies from the virtfs proxy are made up of a fixed-size header (8 bytes) and a payload of variable size (maximum 64kb). When receiving a reply, the proxy backend first reads the whole header and then unmarshals it. If the header is okay, it then does the same operation with the payload. Since

Re: [Qemu-devel] [PATCH] qemu: Fix -version with configure --with-pkgversion

2017-03-17 Thread Peter Maydell
On 16 March 2017 at 09:00, Jordan Justen wrote: > This appears to have regressed in 67a1de0d19. > > When the configure --with-pkgversion=foo option is used, the output > from -version will look like: > > QEMU emulator version 2.8.90(foo) > Copyright (c) 2003-2017

Re: [Qemu-devel] [PATCH] ui/egl-helpers: fix egl 1.5 display init

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 05:53 AM, Marc-André Lureau wrote: On Fri, Mar 17, 2017 at 12:12 PM Gerd Hoffmann wrote: Unfortunaly switching to getPlatformDisplayEXT isn't as easy as implemented by 0ea1523fb6703aa0dcd65e66b59e96fec028e60a. See the longish comment for the complete story.

Re: [Qemu-devel] [PATCH] vnc: fix a qio-channel leak

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 07:14 AM, Daniel P. Berrange wrote: On Fri, Mar 17, 2017 at 01:28:02PM +0400, Marc-André Lureau wrote: Spotted by ASAN. Signed-off-by: Marc-André Lureau --- ui/vnc.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH] qemu: Fix -version with configure --with-pkgversion

2017-03-17 Thread Thomas Huth
On 16.03.2017 10:00, Jordan Justen wrote: > This appears to have regressed in 67a1de0d19. > > When the configure --with-pkgversion=foo option is used, the output > from -version will look like: > > QEMU emulator version 2.8.90(foo) > Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project

[Qemu-devel] [Bug 1673722] [NEW] Reading register at offset. It is not fully implemented warning make VM impossible to use

2017-03-17 Thread Julien Duponchelle
Public bug reported: Hi, Since this commit: https://github.com/qemu/qemu/commit/bc0f0674f037a01f2ce0870ad6270a356a7a8347 We can no longer use the IOSvL2 image from Cisco. The problem is we got a lot of warning message saying: e1000: Reading register at offset: 0x2410. It is not fully

Re: [Qemu-devel] [PULL 0/8] Block layer fixes for 2.9.0-rc1

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 13:15, Kevin Wolf wrote: > The following changes since commit 272d7dee5951f926fad1911f2f072e5915cdcba0: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-cirrus-20170316-1' > into staging (2017-03-16 16:40:44 +) > > are available in the git

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Thomas Huth
On 17.03.2017 14:22, Peter Maydell wrote: > On 17 March 2017 at 13:19, Thomas Huth wrote: >> On 17.03.2017 12:52, Peter Maydell wrote: >>> On 17 March 2017 at 11:49, Daniel P. Berrange wrote: On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell

[Qemu-devel] [PATCH] xen: use libxendevice model to restrict operations

2017-03-17 Thread Paul Durrant
This patch adds a command-line option (-xen-domid-restrict) which will use the new libxendevicemodel API to restrict devicemodel operations to the specified domid. This patch also adds a tracepoint to allow successful enabling of the restriction to be monitored. Signed-off-by: Paul Durrant

Re: [Qemu-devel] [PATCH v3 7/9] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal

2017-03-17 Thread Greg Kurz
On Thu, 16 Mar 2017 13:01:56 -0700 Stefano Stabellini wrote: > Implement xen_9pfs_init_in/out_iov_from_pdu and > xen_9pfs_pdu_vmarshal/vunmarshall by creating new sg pointing to the > data on the ring. > > This is safe as we only handle one request per ring at any given

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 13:19, Thomas Huth wrote: > So could you maybe change your patch that it does not warn when the user > has run configure with the "--enable-tcg-interpreter" option? Nope. I specifically don't want to enable support for TCI on random who-knows-what-this-is

Re: [Qemu-devel] [PULL 0/2] submodule-update queue 20170303

2017-03-17 Thread Jeff Cody
On Fri, Mar 17, 2017 at 09:06:20AM -0400, James Hanley wrote: >Thanks - that seemed to resolve the issue.  Will the synchronization >scripts be updated for all repositories? I was also seeing the same issue >when references for submodules roms/SLOF and roms/seabios were updated. >

[Qemu-devel] [PULL 8/8] block: quiesce AioContext when detaching from it

2017-03-17 Thread Kevin Wolf
From: Paolo Bonzini While it is true that bdrv_set_aio_context only works on a single BlockDriverState subtree (see commit message for 53ec73e, "block: Use bdrv_drain to replace uncessary bdrv_drain_all", 2015-07-07), it works at the AioContext level rather than the

[Qemu-devel] [PULL 5/8] blockdev: fix bitmap clear undo

2017-03-17 Thread Kevin Wolf
From: John Snow Only undo the action if we actually prepared the action. Signed-off-by: John Snow Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- blockdev.c | 4 +++- 1 file changed, 3 insertions(+), 1

[Qemu-devel] [PULL 0/8] Block layer fixes for 2.9.0-rc1

2017-03-17 Thread Kevin Wolf
The following changes since commit 272d7dee5951f926fad1911f2f072e5915cdcba0: Merge remote-tracking branch 'remotes/kraxel/tags/pull-cirrus-20170316-1' into staging (2017-03-16 16:40:44 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for

Re: [Qemu-devel] [PATCH v2 2/3] qemu-img: fix switch indentation in img_amend()

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 07:45 AM, Stefan Hajnoczi wrote: QEMU coding style indents 'case' to the same level as the 'switch' statement: switch (foo) { case 1: Fix this coding style violation so checkpatch.pl doesn't complain about the next patch. Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 13:19, Thomas Huth wrote: > On 17.03.2017 12:52, Peter Maydell wrote: >> On 17 March 2017 at 11:49, Daniel P. Berrange wrote: >>> On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell wrote: We plan to drop support in a future

[Qemu-devel] [PULL 2/8] replication: clarify permissions

2017-03-17 Thread Kevin Wolf
From: Changlong Xie Even if hidden_disk, secondary_disk are backing files, they all need write permissions in replication scenario. Otherwise we will encouter below exceptions on secondary side during adding nbd server: {'execute': 'nbd-server-add', 'arguments':

[Qemu-devel] [PULL 1/8] file-posix: clean up max_segments buffer termination

2017-03-17 Thread Kevin Wolf
From: Stefan Hajnoczi The following pattern is unsafe: char buf[32]; ret = read(fd, buf, sizeof(buf)); ... buf[ret] = 0; If read(2) returns 32 then a byte beyond the end of the buffer is zeroed. In practice this buffer overflow does not occur because the sysfs

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Thomas Huth
On 17.03.2017 12:52, Peter Maydell wrote: > On 17 March 2017 at 11:49, Daniel P. Berrange wrote: >> On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell wrote: >>> We plan to drop support in a future QEMU release for host OSes >>> and host architectures for which we have

Re: [Qemu-devel] [PATCH v3 5/9] xen/9pfs: connect to the frontend

2017-03-17 Thread Greg Kurz
On Thu, 16 Mar 2017 13:01:54 -0700 Stefano Stabellini wrote: > Write the limits of the backend to xenstore. Connect to the frontend. > Upon connection, allocate the rings according to the protocol > specification. > > Initialize a QEMUBH to schedule work upon receiving

[Qemu-devel] [PULL 7/8] thread-pool: add missing qemu_bh_cancel in completion function

2017-03-17 Thread Kevin Wolf
From: Peter Lieven commit 3c80ca15 fixed a deadlock scenarion with nested aio_poll invocations. However, the rescheduling of the completion BH introcuded unnecessary spinning in the main-loop. On very fast file backends this can even lead to the "WARNING: I/O thread spun for 1000

[Qemu-devel] [PULL 6/8] block: Propagate error in bdrv_open_backing_file

2017-03-17 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Alberto Garcia Signed-off-by: Kevin Wolf --- block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block.c b/block.c index a77e8a0..e538084 100644 --- a/block.c

[Qemu-devel] [PULL 4/8] block: Always call bdrv_child_check_perm first

2017-03-17 Thread Kevin Wolf
From: Fam Zheng bdrv_child_set_perm alone is not very usable because the caller must call bdrv_child_check_perm first. This is already encapsulated conveniently in bdrv_child_try_set_perm, so remove the other prototypes from the header and fix the one wrong caller,

[Qemu-devel] [PULL 3/8] file-posix: Don't leak fd in hdev_get_max_segments

2017-03-17 Thread Kevin Wolf
From: Fam Zheng This fixes a leaked fd introduced in commit 9103f1ce. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/file-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Andrea Bolognani
On Fri, 2017-03-17 at 11:56 +, Daniel P. Berrange wrote: > > Yeah. I'm just struggling with setting up a FreeBSD VM so we > > can compile test that. Interesting that GNU/kFreeBSD has users. >  > I wouldn't go so far as to say GNU/kFreeBSD has users. It had a few people > who have noticed bits

Re: [Qemu-devel] [PULL 0/2] submodule-update queue 20170303

2017-03-17 Thread James Hanley
Thanks - that seemed to resolve the issue. Will the synchronization scripts be updated for all repositories? I was also seeing the same issue when references for submodules roms/SLOF and roms/seabios were updated. -Jim On Wed, Mar 15, 2017 at 1:02 PM, Jeff Cody wrote: > On

Re: [Qemu-devel] [PATCH 13/16] migration: Create thread infrastructure for multifd recv side

2017-03-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 13/03/2017 13:44, Juan Quintela wrote: > > case RAM_SAVE_FLAG_MULTIFD_PAGE: > > fd_num = qemu_get_be16(f); > > -if (fd_num != 0) { > > -/* this is yet an unused variable, changed later */ > >

Re: [Qemu-devel] [PATCH for-2.9 v2] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Andrew Jones
On Fri, Mar 17, 2017 at 08:32:42PM +0800, Fam Zheng wrote: > For one thing we shouldn't continue if an error happened, for the other > two steps failing can cause an abort() in error_setg because we reuse > the same errp blindly. > > Add error handling checks to fix both issues. > >

Re: [Qemu-devel] [PATCH for-2.9 v2] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Cornelia Huck
On Fri, 17 Mar 2017 20:32:42 +0800 Fam Zheng wrote: > For one thing we shouldn't continue if an error happened, for the other > two steps failing can cause an abort() in error_setg because we reuse > the same errp blindly. > > Add error handling checks to fix both issues. > >

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Andrew Jones
On Fri, Mar 17, 2017 at 11:49:53AM +, Daniel P. Berrange wrote: > On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell wrote: > > This list is definitely too all-encompassing, and we should > > move at least some of the BSDs into "not-deprecated". > > I'm posting the patch for the moment

[Qemu-devel] [PATCH for-2.9 v2] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Fam Zheng
For one thing we shouldn't continue if an error happened, for the other two steps failing can cause an abort() in error_setg because we reuse the same errp blindly. Add error handling checks to fix both issues. Signed-off-by: Fam Zheng --- v2: Don't forget the last errp ->

Re: [Qemu-devel] [PATCH for-2.9] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Fam Zheng
On Fri, 03/17 13:18, Andrew Jones wrote: > On Fri, Mar 17, 2017 at 07:33:53PM +0800, Fam Zheng wrote: > > For one thing we shouldn't continue if an error happened, for the other > > two steps failing can cause an abort() in error_setg because we reuse > > the same errp blindly. > > > > Add error

Re: [Qemu-devel] [PATCH for-2.9] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Cornelia Huck
On Fri, 17 Mar 2017 13:18:16 +0100 Andrew Jones wrote: > On Fri, Mar 17, 2017 at 07:33:53PM +0800, Fam Zheng wrote: > > For one thing we shouldn't continue if an error happened, for the other > > two steps failing can cause an abort() in error_setg because we reuse > > the

Re: [Qemu-devel] [PATCH for-2.9] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Andrew Jones
On Fri, Mar 17, 2017 at 07:33:53PM +0800, Fam Zheng wrote: > For one thing we shouldn't continue if an error happened, for the other > two steps failing can cause an abort() in error_setg because we reuse > the same errp blindly. > > Add error handling checks to fix both issues. > >

  1   2   >