Re: [Qemu-devel] [PATCH 5/6] migration: send postcopy downtime back to source

2017-04-24 Thread Alexey
On Mon, Apr 24, 2017 at 06:26:31PM +0100, Dr. David Alan Gilbert wrote: > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > Right now to initiate postcopy live migration need to > > send request to source machine and specify destination. > > > > User could request migration status by

Re: [Qemu-devel] DMG chunk size independence

2017-04-24 Thread Ashijeet Acharya
>> For testing I am first converting the images to raw format and then >> comparing the resulting image with the one converted using v2.9.0 DMG >> driver and after battling for 2 days with my code, it finally prints >> "Images are identical." According to John, that should be pretty >> conclusive

[Qemu-devel] [PATCH v3 3/3] tests: Add a tester for HMP commands

2017-04-24 Thread Thomas Huth
HMP commands do not get any automatic testing yet, so on certain QEMU machines, some HMP commands were causing crashes in the past. Thus we should test HMP commands in our test suite, too, to avoid that such problems creep in again in the future. Signed-off-by: Thomas Huth ---

Re: [Qemu-devel] [PATCH v5 07/13] vfio/ccw: vfio based subchannel passthrough driver

2017-04-24 Thread Dong Jia Shi
* Alex Williamson [2017-04-24 16:56:28 -0600]: [...] > > > diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c > > > new file mode 100644 > > > index 000..c491bee > > > --- /dev/null > > > +++ b/hw/vfio/ccw.c > > > @@ -0,0 +1,207 @@ > > > +/* > > > + * vfio based

Re: [Qemu-devel] [PATCH] pci: deassert intx when pci device unrealize

2017-04-24 Thread Marcel Apfelbaum
On 04/25/2017 05:29 AM, Herongguang (Stephen) wrote: If a pci device is not reset by VM (by writing into config space) and unplugged by VM, after that when VM reboots, qemu may assert: pcibus_reset: Assertion `bus->irq_count[i] == 0' failed Signed-off-by: herongguang

Re: [Qemu-devel] [PATCH RFC 1/1] vfio/pci: Fix incorrect error message

2017-04-24 Thread Dong Jia Shi
* Dong Jia Shi [2017-04-25 06:52:01 +0200]: Hey Alex, Please ignore the "RFC" tag in the subject. Sorry for the mistake. > When the "No host device provided" error occurs, the hint message > that starts with "Use -vfio-pci," makes no sense, since "-vfio-pci" > is

[Qemu-devel] [PATCH RFC 1/1] vfio/pci: Fix incorrect error message

2017-04-24 Thread Dong Jia Shi
When the "No host device provided" error occurs, the hint message that starts with "Use -vfio-pci," makes no sense, since "-vfio-pci" is not a valid command line parameter. Correct this by replacing "-vfio-pci" with "-device vfio-pci". Signed-off-by: Dong Jia Shi

Re: [Qemu-devel] [PULL 0/8] Net patches

2017-04-24 Thread Jason Wang
On 2017年04月25日 00:02, Cédric Le Goater wrote: On 04/24/2017 03:49 PM, Peter Maydell wrote: On 24 April 2017 at 06:15, Jason Wang wrote: The following changes since commit 32c7e0ab755745e961f1772e95cac381cc68769d: Merge remote-tracking branch

Re: [Qemu-devel] [PATCH V2 0/6] Add COLO-proxy virtio-net support

2017-04-24 Thread Jason Wang
On 2017年04月24日 20:02, Zhang Chen wrote: On 04/24/2017 11:48 AM, Jason Wang wrote: On 2017年04月20日 14:39, Zhang Chen wrote: If user use -device virtio-net-pci, virtio-net driver will add a header to raw net packet that colo-proxy can't handle it. COLO-proxy just focus on the packet

Re: [Qemu-devel] [PULL 0/4] hmp queue

2017-04-24 Thread Thomas Huth
gt; >>> >>> The following changes since commit 4c55b1d0bad8a703f0499fe62e3761a0cd288da3: >>> >>> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2017-04-24' >>> into staging (2017-04-24 14:49:48 +0100) >>> >>> are availab

Re: [Qemu-devel] [PATCH v5 06/13] s390x/css: device support for s390-ccw passthrough

2017-04-24 Thread Dong Jia Shi
* Alex Williamson [2017-04-24 20:16:18 -0600]: > On Tue, 25 Apr 2017 10:10:22 +0800 > Dong Jia Shi wrote: > > > * Alex Williamson [2017-04-24 16:52:58 -0600]: > > > > > On Wed, 12 Apr 2017 07:21:08 +0200 > >

[Qemu-devel] [PATCH 9/9] Add more descriptive comment for mismatch or end of test condition

2017-04-24 Thread G 3
Replace the comment "mismatch, or end of test" with "called for a mismatch, or for the end of a test". This describes what happens better. Signed-off-by: John Arbuckle --- risu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/risu.c b/risu.c

[Qemu-devel] [PATCH 7/9] Add verbose option

2017-04-24 Thread G 3
Add an option that prints each instruction that is currently being tested. To use this option, just add "--v" to risu's command-line. Signed-off-by: John Arbuckle --- risu.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/risu.c

[Qemu-devel] [PATCH 8/9] Add end of test message

2017-04-24 Thread G 3
Print the message "End of test" on the risu host end. Signed-off-by: John Arbuckle --- risu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/risu.c b/risu.c index ed5b605..e7cbd57 100644 --- a/risu.c +++ b/risu.c @@ -63,6 +63,7 @@ void apprentice_sigill(int sig,

[Qemu-devel] [PATCH 6/9] Add ppc support to configure

2017-04-24 Thread G 3
Add ppc support to the configure script. Signed-off-by: John Arbuckle --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 055e6d6..7881b18 100755 --- a/configure +++ b/configure @@ -56,6 +56,8 @@

[Qemu-devel] [PATCH 5/9] Add risugen_ppc.pm file

2017-04-24 Thread G 3
Add the risugen_ppc.pm file. It is used to generate the instructions that risu runs. Signed-off-by: John Arbuckle --- risugen_ppc.pm | 744 +++ ++ 1 file changed, 744 insertions(+) create mode 100644

[Qemu-devel] [PATCH 4/9] Add risu_reginfo_ppc.h file

2017-04-24 Thread G 3
Add the risu_reginfo_ppc.h file. It defines the reginfo structure. Signed-off-by: John Arbuckle --- risu_reginfo_ppc.h | 32 1 file changed, 32 insertions(+) create mode 100644 risu_reginfo_ppc.h diff --git a/risu_reginfo_ppc.h

[Qemu-devel] [PATCH 3/9] Add risu_reginfo_ppc.c file

2017-04-24 Thread G 3
Add the risu_reginfo_ppc.c file. It handles operations involving the reginfo structure. Signed-off-by: John Arbuckle --- risu_reginfo_ppc.c | 273 +++ ++ 1 file changed, 273 insertions(+) create mode 100644

[Qemu-devel] [PATCH 2/9] Add risu_ppc.c file

2017-04-24 Thread G 3
Add the risu_ppc.c file. It defines several functions used by risu. Signed-off-by: John Arbuckle --- risu_ppc.c | 41 + 1 file changed, 41 insertions(+) create mode 100644 risu_ppc.c diff --git a/risu_ppc.c b/risu_ppc.c new

[Qemu-devel] [PATCH 1/9] Add ppc.risu file

2017-04-24 Thread G 3
Add the ppc.risu file. It defines the format for various PowerPC instructions. Signed-off-by: John Arbuckle --- ppc.risu | 527 + ++ 1 file changed, 527 insertions(+) create mode 100644 ppc.risu diff

[Qemu-devel] [PATCH 0/9] Add PowerPC support to risu

2017-04-24 Thread G 3
Makes risu usable on a PowerPC Macintosh running Mac OS X. John Arbuckle (9): Add ppc.risu file. Add risu_ppc.c file. Add risu_reginfo_ppc.c file. Add risu_reginfo_ppc.h file Add risugen_ppc.pm file. Add ppc support to configure Add verbose option. Add end of test message Add

[Qemu-devel] [PATCH] pci: deassert intx when pci device unrealize

2017-04-24 Thread Herongguang (Stephen)
If a pci device is not reset by VM (by writing into config space) and unplugged by VM, after that when VM reboots, qemu may assert: pcibus_reset: Assertion `bus->irq_count[i] == 0' failed Signed-off-by: herongguang --- hw/pci/pci.c | 1 + 1 file changed, 1

Re: [Qemu-devel] [RFC PATCH] pci: deassert intx when pci device unrealize

2017-04-24 Thread Herongguang (Stephen)
On 2017/4/25 7:45, Michael S. Tsirkin wrote: On Mon, Apr 24, 2017 at 09:12:29PM +0800, Herongguang (Stephen) wrote: If a pci device is not reset by VM (by writing into config space) and unplugged by VM, after that when VM reboots, qemu may assert: pcibus_reset: Assertion `bus->irq_count[i] ==

Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors

2017-04-24 Thread 858585 jemmy
On Mon, Apr 24, 2017 at 11:53 PM, Eric Blake wrote: > On 04/24/2017 10:47 AM, Eric Blake wrote: >> On 04/24/2017 10:37 AM, Philippe Mathieu-Daudé wrote: >> > /* > - * Returns true iff the first sector pointed to by 'buf' contains at > least > - * a non-NUL

Re: [Qemu-devel] [PATCH] crypto: move 'opaque' parameter to (nearly) the end of parameter list

2017-04-24 Thread Fam Zheng
On Mon, 04/24 16:36, Daniel P. Berrange wrote: > Previous commit moved 'opaque' to be the 2nd parameter in the list: > > commit 375092332eeaa6e47561ce47fd36144cdaf964d0 > Author: Fam Zheng > Date: Fri Apr 21 20:27:02 2017 +0800 > > crypto: Make errp the last

[Qemu-devel] [PATCH v8] Allow setting NUMA distance for different NUMA nodes

2017-04-24 Thread He Chen
This patch is going to add SLIT table support in QEMU, and provides additional option `dist` for command `-numa` to allow user set vNUMA distance by QEMU command. With this patch, when a user wants to create a guest that contains several vNUMA nodes and also wants to set distance among those

Re: [Qemu-devel] [PATCH 1/2] qemu-img: make sure contain the consecutive number of zero bytes

2017-04-24 Thread 858585 jemmy
On Mon, Apr 24, 2017 at 10:43 PM, Eric Blake wrote: > On 04/23/2017 09:33 AM, jemmy858...@gmail.com wrote: >> From: Lidong Chen >> >> is_allocated_sectors_min don't guarantee to contain the >> consecutive number of zero bytes. this patch fixes this bug.

Re: [Qemu-devel] [PATCH v2] trace: add qemu mutex lock and unlock trace events

2017-04-24 Thread Fam Zheng
On Mon, 04/24 14:19, Jose Ricardo Ziviani wrote: > These trace events were very useful to help me to understand and find a > reordering issue in vfio, for example: > > qemu_mutex_lock locked mutex 0x10905ad8 > vfio_region_write (0001:03:00.0:region1+0xc0, 0x2020c, 4) > qemu_mutex_unlock

Re: [Qemu-devel] [Qemu-block] [PATCH 17/17] block: Make bdrv_is_allocated_above() byte-based

2017-04-24 Thread Eric Blake
On 04/24/2017 06:06 PM, John Snow wrote: > > > On 04/11/2017 06:29 PM, Eric Blake wrote: >> We are gradually moving away from sector-based interfaces, towards >> byte-based. In the common case, allocation is unlikely to ever use >> values that are not naturally sector-aligned, but it is

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-04-24 Thread FONNEMANN Mark
-Original Message- From: Thomas Huth [mailto:th...@redhat.com] Sent: Monday, April 24, 2017 04:00 To: FONNEMANN Mark ; qemu-devel@nongnu.org Cc: Samuel Thibault Subject: Re: [Qemu-devel] dns server not working in QEMU using

Re: [Qemu-devel] ARM virt machine boots fail with 14 ioh3420

2017-04-24 Thread Shannon Zhao
On 2017/4/24 18:16, Marcel Apfelbaum wrote: > On 04/24/2017 01:02 PM, Laszlo Ersek wrote: >> On 04/14/17 04:41, Shannon Zhao wrote: >>> Hi Laszlo, >>> >>> Thanks a lot for your reply:) >>> >>> On 2017/4/14 1:09, Laszlo Ersek wrote: Adding Andrea, Ard, Drew and Marcel; and the main qemu list

[Qemu-devel] [PATCH v4] qga: Add support network interface statistics in

2017-04-24 Thread ZhiPeng Lu
we can get the network interface statistics inside a virtual machine by guest-network-get-interfaces command. it is very useful for us to monitor and analyze network traffic. Signed-off-by: ZhiPeng Lu Signed-off-by: Daniel P. Berrange ---

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-04-24 Thread John Snow
On 04/24/2017 03:10 PM, Markus Armbruster wrote: > With 2.9 out of the way, how can we make progress on this one? > Throw rocks at my window late at night. Refuse to stop until there is consensus. > I can see two ways to get asynchronous QMP commands accepted: > > 1. We break QMP

Re: [Qemu-devel] [PATCH 08/11] blockjob: group BlockJob transaction functions together

2017-04-24 Thread John Snow
On 04/19/2017 10:42 AM, Paolo Bonzini wrote: > Yet another pure code movement patch, preparing for the next change. > > Signed-off-by: Paolo Bonzini Reviewed-by: John Snow > --- > v1->v2: split out of block_job_completed_txn_abort patch [John]

Re: [Qemu-devel] [RFC PATCH] pci: deassert intx when pci device unrealize

2017-04-24 Thread Michael S. Tsirkin
On Mon, Apr 24, 2017 at 09:12:29PM +0800, Herongguang (Stephen) wrote: > If a pci device is not reset by VM (by writing into config space) > and unplugged by VM, after that when VM reboots, qemu may assert: > pcibus_reset: Assertion `bus->irq_count[i] == 0' failed > > Signed-off-by: herongguang

Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10

2017-04-24 Thread Stefano Stabellini
On Mon, 24 Apr 2017, Peter Maydell wrote: > On 24 April 2017 at 22:25, Stefano Stabellini wrote: > > diff --git a/hw/9pfs/xen-9pfs.h b/hw/9pfs/xen-9pfs.h > > new file mode 100644 > > index 000..18f0ec0 > > --- /dev/null > > +++ b/hw/9pfs/xen-9pfs.h > > @@ -0,0 +1,14 @@

Re: [Qemu-devel] [PATCH 05/11] blockjob: separate monitor and blockjob APIs

2017-04-24 Thread John Snow
On 04/19/2017 10:42 AM, Paolo Bonzini wrote: > We have two different headers for block job operations, blockjob.h > and blockjob_int.h. The former contains APIs called by the monitor, > the latter contains APIs called by the block job drivers and the > block layer itself. > > Keep the two APIs

Re: [Qemu-devel] [PATCH 01/11] blockjob: remove unnecessary check

2017-04-24 Thread John Snow
Worth a resend to CC qemu-block, include a cover letter, and all the usual amenities? On 04/19/2017 10:42 AM, Paolo Bonzini wrote: > !job is always checked prior to the call, drop it from here. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [Qemu-block] [PATCH 17/17] block: Make bdrv_is_allocated_above() byte-based

2017-04-24 Thread John Snow
On 04/11/2017 06:29 PM, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. In the common case, allocation is unlikely to ever use > values that are not naturally sector-aligned, but it is possible > that byte-based values will let us be more

Re: [Qemu-devel] [PATCH v5 07/13] vfio/ccw: vfio based subchannel passthrough driver

2017-04-24 Thread Alex Williamson
On Mon, 24 Apr 2017 16:43:38 -0600 Alex Williamson wrote: > On Wed, 12 Apr 2017 07:21:09 +0200 > Dong Jia Shi wrote: > > > From: Xiao Feng Ren > > > > We use the IOMMU_TYPE1 of VFIO to realize the

Re: [Qemu-devel] [PATCH v5 06/13] s390x/css: device support for s390-ccw passthrough

2017-04-24 Thread Alex Williamson
On Wed, 12 Apr 2017 07:21:08 +0200 Dong Jia Shi wrote: > In order to support subchannels pass-through, we introduce a s390 > subchannel device called "s390-ccw" to hold the real subchannel info. > The s390-ccw devices inherit from the abstract CcwDevice which connect

Re: [Qemu-devel] [Qemu-stable] [PATCH v2 1/1] qemu-img: wait for convert coroutines to complete

2017-04-24 Thread Anton Nefedov
On 24/04/2017 21:16, Peter Lieven wrote: Am 24.04.2017 um 18:27 schrieb Anton Nefedov : On 04/21/2017 03:37 PM, Peter Lieven wrote: Am 21.04.2017 um 14:19 schrieb Anton Nefedov: On 04/21/2017 01:44 PM, Peter Lieven wrote: Am 21.04.2017 um 12:04 schrieb Anton

Re: [Qemu-devel] [PATCH v5 07/13] vfio/ccw: vfio based subchannel passthrough driver

2017-04-24 Thread Alex Williamson
On Wed, 12 Apr 2017 07:21:09 +0200 Dong Jia Shi wrote: > From: Xiao Feng Ren > > We use the IOMMU_TYPE1 of VFIO to realize the subchannels > passthrough, implement a vfio based subchannels passthrough > driver called "vfio-ccw". > >

[Qemu-devel] [PATCH 4/4] migration: spapr: migrate pending_events of spapr state

2017-04-24 Thread Daniel Henrique Barboza
From: Jianjun Duan In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration is started. In this case the pending_events of spapr state need be transmitted to the target

[Qemu-devel] [PATCH 3/4] migration: spapr: migrate ccs_list in spapr state

2017-04-24 Thread Daniel Henrique Barboza
From: Jianjun Duan ccs_list in spapr state maintains the device tree related information on the rtas side for hotplugged devices. In racing situations between hotplug events and migration operation, a rtas hotplug event could be migrated from the source guest to target

[Qemu-devel] [PATCH 2/4] hw/ppc: migrating the DRC state of hotplugged devices

2017-04-24 Thread Daniel Henrique Barboza
In pseries, a firmware abstraction called Dynamic Reconfiguration Connector (DRC) is used to assign a particular dynamic resource to the guest and provide an interface to manage configuration/removal of the resource associated with it. In other words, DRC is the 'plugged state' of a device.

[Qemu-devel] [PATCH 1/4] migration: alternative way to set instance_id in SaveStateEntry

2017-04-24 Thread Daniel Henrique Barboza
From: Jianjun Duan In QOM (QEMU Object Model) migrated objects are identified with instance_id which is calculated automatically using their path in the QOM composition tree. For some objects, this path could change from source to target in migration. To migrate such

[Qemu-devel] [PATCH 0/4 v6] migration/ppc: migrating DRC, ccs_list and pending_events

2017-04-24 Thread Daniel Henrique Barboza
Hi, This is the version 6 of the pseries patches that was last sent in the mailing list more than 6 months ago. The original v5 patchset was authored by Jianjun Duan (see link below): http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg00270.html The specific pseries patches were

Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10

2017-04-24 Thread Peter Maydell
On 24 April 2017 at 22:25, Stefano Stabellini wrote: > diff --git a/hw/9pfs/xen-9pfs.h b/hw/9pfs/xen-9pfs.h > new file mode 100644 > index 000..18f0ec0 > --- /dev/null > +++ b/hw/9pfs/xen-9pfs.h > @@ -0,0 +1,14 @@ > +/* > + * Xen 9p backend > + * > + * Copyright

Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10

2017-04-24 Thread Stefano Stabellini
On Mon, 24 Apr 2017, Peter Maydell wrote: > On 21 April 2017 at 21:14, Stefano Stabellini wrote: > > The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: > > > > Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) > > > > are

Re: [Qemu-devel] DMG chunk size independence

2017-04-24 Thread John Snow
On 04/23/2017 05:03 AM, Ashijeet Acharya wrote: > Hi, > > Great news! > I have almost completed this task and the results are looking > promising. I have not yet attended to the DMG files having bz2 > compressed chunks but that should be easy and pretty similar to my > approach for zlib

[Qemu-devel] [PATCH v2] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

2017-04-24 Thread Igor Mammedov
Since 2.7 commit (b2a575a Add optionrom compatible with fw_cfg DMA version) regressed migration during firmware exection time by abusing fwcfg.dma_enabled property to decide loading dma version of option rom AND by mistake disabling DMA for 2.6 and earlier globally instead of only for option rom.

Re: [Qemu-devel] [PATCH RESEND v4 4/4] HMP: Introduce msr_get and msr_set HMP commands

2017-04-24 Thread Julian Kirsch
Good catch, thanks! -Julian On 24.04.2017 18:32, Dr. David Alan Gilbert wrote: > Shouldn't the use of '-' be '_' in those to match the .name (and in the -set > variant > below) ? > > Dave

Re: [Qemu-devel] [PATCH] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

2017-04-24 Thread Eduardo Habkost
On Mon, Apr 24, 2017 at 09:56:04PM +0200, Igor Mammedov wrote: > On Mon, 24 Apr 2017 16:37:31 -0300 > Eduardo Habkost wrote: > > > On Mon, Apr 24, 2017 at 09:32:33PM +0200, Igor Mammedov wrote: > > > On Mon, 24 Apr 2017 16:13:17 -0300 > > > Eduardo Habkost

Re: [Qemu-devel] [PATCH] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

2017-04-24 Thread Igor Mammedov
On Mon, 24 Apr 2017 16:37:31 -0300 Eduardo Habkost wrote: > On Mon, Apr 24, 2017 at 09:32:33PM +0200, Igor Mammedov wrote: > > On Mon, 24 Apr 2017 16:13:17 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Apr 24, 2017 at 08:58:17PM +0200, Igor

Re: [Qemu-devel] [PATCH] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

2017-04-24 Thread Eduardo Habkost
On Mon, Apr 24, 2017 at 09:32:33PM +0200, Igor Mammedov wrote: > On Mon, 24 Apr 2017 16:13:17 -0300 > Eduardo Habkost wrote: > > > On Mon, Apr 24, 2017 at 08:58:17PM +0200, Igor Mammedov wrote: > > [...] > > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > > > index

Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

2017-04-24 Thread Eduardo Habkost
On Mon, Apr 24, 2017 at 12:40:07PM +0200, Thomas Huth wrote: > On 20.12.2016 18:43, Eduardo Habkost wrote: > > This moves the KVM and Xen files to the an accel/ subdir. > > > > Instead of moving the *-stubs.c file to accel/ as-is, I tried to > > move most of the stub code to libqemustub.a. This

Re: [Qemu-devel] [PATCH] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

2017-04-24 Thread Igor Mammedov
On Mon, 24 Apr 2017 16:13:17 -0300 Eduardo Habkost wrote: > On Mon, Apr 24, 2017 at 08:58:17PM +0200, Igor Mammedov wrote: > [...] > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > > index f3b372a18f..3f2d96da64 100644 > > --- a/hw/i386/pc.c > > +++ b/hw/i386/pc.c > > @@

[Qemu-devel] [PULL v2 12/12] qemu-iotests: _cleanup_qemu must be called on exit

2017-04-24 Thread Jeff Cody
For the tests that use the common.qemu functions for running a QEMU process, _cleanup_qemu must be called in the exit function. If it is not, if the qemu process aborts, then not all of the droppings are cleaned up (e.g. pidfile, fifos). This updates those tests that did not have a cleanup in

[Qemu-devel] [PULL v2 10/12] block/rbd - update variable names to more apt names

2017-04-24 Thread Jeff Cody
Update 'clientname' to be 'user', which tracks better with both the QAPI and rados variable naming. Update 'name' to be 'image_name', as it indicates the rbd image. Naming it 'image' would have been ideal, but we are using that for the rados_image_t value returned by rbd_open(). Reviewed-by:

[Qemu-devel] [PULL v2 11/12] block/rbd: Add support for reopen()

2017-04-24 Thread Jeff Cody
This adds support for reopen in rbd, for changing between r/w and r/o. Note, that this is only a flag change, but we will block a change from r/o to r/w if we are using an RBD internal snapshot. Reviewed-by: Stefan Hajnoczi Signed-off-by: Jeff Cody

[Qemu-devel] [PULL v2 08/12] block: introduce bdrv_can_set_read_only()

2017-04-24 Thread Jeff Cody
Introduce check function for setting read_only flags. Will return < 0 on error, with appropriate Error value set. Does not alter any flags. Signed-off-by: Jeff Cody Reviewed-by: Stefan Hajnoczi Reviewed-by: John Snow Message-id:

[Qemu-devel] [PULL v2 07/12] block: code movement

2017-04-24 Thread Jeff Cody
Move bdrv_is_read_only() up with its friends. Reviewed-by: Stefan Hajnoczi Reviewed-by: John Snow Signed-off-by: Jeff Cody Message-id: 73b2399459760c32506f9407efb9dddb3a2789de.1491597120.git.jc...@redhat.com --- block.c | 10 +-

[Qemu-devel] [PULL v2 09/12] block: use bdrv_can_set_read_only() during reopen

2017-04-24 Thread Jeff Cody
Signed-off-by: Jeff Cody Reviewed-by: Stefan Hajnoczi Reviewed-by: John Snow Message-id: 00aed7ffdd7be4b9ed9ce1007d50028a72b34ebe.1491597120.git.jc...@redhat.com --- block.c | 14 -- 1 file changed, 8 insertions(+), 6

[Qemu-devel] [PULL v2 02/12] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2017-04-24 Thread Jeff Cody
From: Ashish Mittal These changes use a vxhs test server that is a part of the following repository: https://github.com/VeritasHyperScale/libqnio.git Signed-off-by: Ashish Mittal Reviewed-by: Stefan Hajnoczi Reviewed-by:

[Qemu-devel] [PULL v2 04/12] block: add bdrv_set_read_only() helper function

2017-04-24 Thread Jeff Cody
We have a helper wrapper for checking for the BDS read_only flag, add a helper wrapper to set the read_only flag as well. Reviewed-by: Stefan Hajnoczi Signed-off-by: Jeff Cody Reviewed-by: John Snow Message-id:

[Qemu-devel] [PULL v2 05/12] block: do not set BDS read_only if copy_on_read enabled

2017-04-24 Thread Jeff Cody
A few block drivers will set the BDS read_only flag from their .bdrv_open() function. This means the bs->read_only flag could be set after we enable copy_on_read, as the BDRV_O_COPY_ON_READ flag check occurs prior to the call to bdrv->bdrv_open(). This adds an error return to

[Qemu-devel] [PULL v2 03/12] qemu-iotests: exclude vxhs from image creation via protocol

2017-04-24 Thread Jeff Cody
The protocol VXHS does not support image creation. Some tests expect to be able to create images through the protocol. Exclude VXHS from these tests. Signed-off-by: Jeff Cody --- tests/qemu-iotests/017 | 1 + tests/qemu-iotests/020 | 1 + tests/qemu-iotests/029 | 1 +

[Qemu-devel] [PULL v2 06/12] block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only

2017-04-24 Thread Jeff Cody
The BDRV_O_ALLOW_RDWR flag allows / prohibits the changing of the BDS 'read_only' state, but there are a few places where it is ignored. In the bdrv_set_read_only() helper, make sure to honor the flag. Signed-off-by: Jeff Cody Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL v2 00/12] Block patches

2017-04-24 Thread Jeff Cody
The following changes since commit 4c55b1d0bad8a703f0499fe62e3761a0cd288da3: Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2017-04-24' into staging (2017-04-24 14:49:48 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git

[Qemu-devel] [PULL v2 01/12] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-04-24 Thread Jeff Cody
From: Ashish Mittal Source code for the qnio library that this code loads can be downloaded from: https://github.com/VeritasHyperScale/libqnio.git Sample command line using JSON syntax: ./x86_64-softmmu/qemu-system-x86_64 -name instance-0008 -S -vnc 0.0.0.0:0 -k en-us

Re: [Qemu-devel] [PATCH] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

2017-04-24 Thread Eduardo Habkost
On Mon, Apr 24, 2017 at 08:58:17PM +0200, Igor Mammedov wrote: [...] > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index f3b372a18f..3f2d96da64 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1047,7 +1047,7 @@ static void load_linux(PCMachineState *pcms, > fw_cfg_add_i32(fw_cfg,

Re: [Qemu-devel] postcopy migration hangs while loading virtio state

2017-04-24 Thread Dr. David Alan Gilbert
* Christian Borntraeger (borntrae...@de.ibm.com) wrote: > On 04/24/2017 04:35 PM, Dr. David Alan Gilbert wrote: > > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > >> On 04/24/2017 12:53 PM, Dr. David Alan Gilbert wrote: > >>> * Christian Borntraeger (borntrae...@de.ibm.com) wrote: >

Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

2017-04-24 Thread Stefano Stabellini
On Mon, 24 Apr 2017, Thomas Huth wrote: > On 20.12.2016 18:43, Eduardo Habkost wrote: > > This moves the KVM and Xen files to the an accel/ subdir. > > > > Instead of moving the *-stubs.c file to accel/ as-is, I tried to > > move most of the stub code to libqemustub.a. This way the obj-y > >

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-04-24 Thread Markus Armbruster
With 2.9 out of the way, how can we make progress on this one? I can see two ways to get asynchronous QMP commands accepted: 1. We break QMP compatibility in QEMU 3.0 and convert all long-running tasks from "synchronous command + event" to "asynchronous command". This is design option 1

[Qemu-devel] [PATCH] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

2017-04-24 Thread Igor Mammedov
Since 2.7 commit (b2a575a Add optionrom compatible with fw_cfg DMA version) regressed migration during firmware exection time by abusing fwcfg.dma_enabled property to decide loading dma version of option rom AND by mistake disabling DMA for 2.6 and earlier globally instead of only for option rom.

Re: [Qemu-devel] [PATCH RESEND v2 08/18] ram/COLO: Record the dirty pages that SVM received

2017-04-24 Thread Juan Quintela
zhanghailiang wrote: > We record the address of the dirty pages that received, > it will help flushing pages that cached into SVM. > > Here, it is a trick, we record dirty pages by re-using migration > dirty bitmap. In the later patch, we will start the dirty log >

Re: [Qemu-devel] [PATCH RESEND v2 07/18] COLO: Load dirty pages into SVM's RAM cache firstly

2017-04-24 Thread Juan Quintela
zhanghailiang wrote: > We should not load PVM's state directly into SVM, because there maybe some > errors happen when SVM is receving data, which will break SVM. > > We need to ensure receving all data before load the state into SVM. We use > an extra memory to

Re: [Qemu-devel] [PATCH RESEND v2 04/18] COLO: integrate colo compare with colo frame

2017-04-24 Thread Juan Quintela
zhanghailiang wrote: > For COLO FT, both the PVM and SVM run at the same time, > only sync the state while it needs. > > So here, let SVM runs while not doing checkpoint, change > DEFAULT_MIGRATE_X_CHECKPOINT_DELAY to 200*100. > > Besides, we forgot to release

Re: [Qemu-devel] postcopy migration hangs while loading virtio state

2017-04-24 Thread Christian Borntraeger
On 04/24/2017 04:35 PM, Dr. David Alan Gilbert wrote: > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: >> On 04/24/2017 12:53 PM, Dr. David Alan Gilbert wrote: >>> * Christian Borntraeger (borntrae...@de.ibm.com) wrote: David, Juan, I can trigger a hang of postcopy

Re: [Qemu-devel] [Qemu-stable] [PATCH v2 1/1] qemu-img: wait for convert coroutines to complete

2017-04-24 Thread Peter Lieven
> Am 24.04.2017 um 18:27 schrieb Anton Nefedov : > >> On 04/21/2017 03:37 PM, Peter Lieven wrote: >>> Am 21.04.2017 um 14:19 schrieb Anton Nefedov: On 04/21/2017 01:44 PM, Peter Lieven wrote: > Am 21.04.2017 um 12:04 schrieb Anton Nefedov: > On error

Re: [Qemu-devel] [Qemu-arm] [RFC 0/3] split core mmu_idx from ARMMMUIdx values

2017-04-24 Thread Peter Maydell
On 24 April 2017 at 17:33, Peter Maydell wrote: > For M profile, we're eventually going to want some > new MMU index values: > non secure User > non secure Privileged > non secure Privileged, execution priority < 0 > secure User > secure

Re: [Qemu-devel] [PATCH 6/6] migration: detailed traces for postcopy

2017-04-24 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > It could help to track down vCPU state during page fault and > page fault sources. > > This patch showes proc's status/stack/syscall file at the moment of pagefault, > it's very interesting to know who was page fault initiator. This is a LOT

Re: [Qemu-devel] [Qemu-devel RFC v2 1/4] msf2: Add Smartfusion2 System timer

2017-04-24 Thread Peter Maydell
On 24 April 2017 at 18:44, Alistair Francis wrote: > Basically the simple explanation is that init is called when the > object is created and realize is called when the object is realized. > > Generally for devices it will go something like this: > 1. init > 2. Set

Re: [Qemu-devel] [Qemu-devel RFC v2 4/4] msf2: Add Emcraft's Smartfusion2 SOM kit.

2017-04-24 Thread Alistair Francis
>> >> Instead of calling all of these in the init function you should split >> it up over the machines init and realize function. >> >> Look at the stm32f205_soc or xlnx-zynqmp files for examples of how to do >> this. >> >> It also moves away from calling qdev_create() and qdev_init_nofail() >>

[Qemu-devel] [PATCH v2] crypto_gen_random() now also works on windows

2017-04-24 Thread Geert Martin Ijewski
If no crypto library is included in the build QEMU uses qcrypto_random_bytes() to generate random data. That function tried to open /dev/urandom or /dev/random and if openeing neither file worked it errored out. Those files obviously do not exist on windows, so there the code now uses

Re: [Qemu-devel] [Qemu-devel RFC v2 1/4] msf2: Add Smartfusion2 System timer

2017-04-24 Thread Alistair Francis
>>> + >>> +isr = !!(st->regs[R_RIS] & TIMER_RIS_ACK); >>> +ier = !!(st->regs[R_CTRL] & TIMER_CTRL_INTR); >>> + >>> +qemu_set_irq(st->irq, (ier && isr)); >>> +} >>> + >>> +static uint64_t >>> +timer_read(void *opaque, hwaddr addr, unsigned int size) >>> +{ >>> +struct timerblock *t

Re: [Qemu-devel] [PATCH v2] ipmi: add SET_SENSOR_READING command

2017-04-24 Thread Michael S. Tsirkin
On Wed, Apr 12, 2017 at 09:08:50AM +0200, Cédric Le Goater wrote: > SET_SENSOR_READING is a complex IPMI command (see IPMI spec 35.17) > which enables the host software to set the reading value and the event > status of sensors supporting it. > > Below is a proposal for all the operations

Re: [Qemu-devel] [PATCH 5/6] migration: send postcopy downtime back to source

2017-04-24 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Right now to initiate postcopy live migration need to > send request to source machine and specify destination. > > User could request migration status by query-migrate qmp command on > source machine, but postcopy downtime is being evaluated

[Qemu-devel] [PATCH v2] trace: add qemu mutex lock and unlock trace events

2017-04-24 Thread Jose Ricardo Ziviani
These trace events were very useful to help me to understand and find a reordering issue in vfio, for example: qemu_mutex_lock locked mutex 0x10905ad8 vfio_region_write (0001:03:00.0:region1+0xc0, 0x2020c, 4) qemu_mutex_unlock unlocked mutex 0x10905ad8 qemu_mutex_lock locked mutex 0x10905ad8

Re: [Qemu-devel] [PATCH 4/6] migration: calculate downtime on dst side (CPUMASK)

2017-04-24 Thread Dr. David Alan Gilbert
* Alexey (a.pereva...@samsung.com) wrote: > Hello David, > this mail just for CPUMASK discussion. > > On Fri, Apr 21, 2017 at 01:00:32PM +0100, Dr. David Alan Gilbert wrote: > > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > > This patch provides downtime calculation per vCPU, > > > as a

Re: [Qemu-devel] [PATCH 4/6] migration: calculate downtime on dst side

2017-04-24 Thread Dr. David Alan Gilbert
* Alexey (a.pereva...@samsung.com) wrote: > Hello, David! > > > I apologize, forgot to check patches with checkpatch.pl script, but now I > checked, > and I fixed code styles in patches, however I checked also files, > migration.c has code style errors and glib-compat.h too. > I could send that

Re: [Qemu-devel] [PATCH 3/6] migration: add UFFD_FEATURE_THREAD_ID feature support

2017-04-24 Thread Dr. David Alan Gilbert
* Alexey (a.pereva...@samsung.com) wrote: > On Mon, Apr 24, 2017 at 04:12:29PM +0800, Peter Xu wrote: > > On Fri, Apr 21, 2017 at 06:22:12PM +0300, Alexey wrote: > > > On Fri, Apr 21, 2017 at 11:24:54AM +0100, Dr. David Alan Gilbert wrote: > > > > * Alexey Perevalov (a.pereva...@samsung.com)

Re: [Qemu-devel] [PATCH] trace: add qemu mutex lock and unlock trace events

2017-04-24 Thread joserz
On Mon, Apr 24, 2017 at 10:45:52PM +0800, Fam Zheng wrote: > On Mon, 04/24 11:28, Jose Ricardo Ziviani wrote: > > These trace events were very useful to help me to understand and find a > > reordering issue in vfio, for example: > > > > qemu_mutex_lock locked mutex 0x10905ad8 > >

Re: [Qemu-devel] [PULL 0/4] hmp queue

2017-04-24 Thread Dr. David Alan Gilbert
8a703f0499fe62e3761a0cd288da3: > > > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2017-04-24' > > into staging (2017-04-24 14:49:48 +0100) > > > > are available in the git repository at: > > > > gi

Re: [Qemu-devel] [PATCH v5 13/18] qcow2: add support for LUKS encryption format

2017-04-24 Thread Daniel P. Berrange
On Tue, Feb 21, 2017 at 03:13:03PM +0100, Alberto Garcia wrote: > On Tue 21 Feb 2017 12:55:07 PM CET, Daniel P. Berrange wrote: > > static int qcow2_set_up_encryption(BlockDriverState *bs, QemuOpts *opts, > > - Error **errp) > > +

Re: [Qemu-devel] [PULL 0/4] hmp queue

2017-04-24 Thread Peter Maydell
tes/armbru/tags/pull-error-2017-04-24' > into staging (2017-04-24 14:49:48 +0100) > > are available in the git repository at: > > git://github.com/dagrh/qemu.git tags/pull-hmp-20170424 > > for you to fetch changes up to e4e3992e626c4cc7514b271807c90f587771c646: > >

Re: [Qemu-devel] [PATCH v5 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-04-24 Thread Daniel P. Berrange
On Tue, Feb 21, 2017 at 02:30:10PM +0100, Alberto Garcia wrote: > On Tue 21 Feb 2017 12:55:05 PM CET, Daniel P. Berrange wrote: > > +switch (s->crypt_method_header) { > > +case QCOW_CRYPT_NONE: > > +break; > > + > > +case QCOW_CRYPT_AES: > > +r->crypto_opts =

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-04-24 Thread Dr. David Alan Gilbert
* Yang Hongyang (yanghongy...@huawei.com) wrote: > > > On 2017/4/24 20:06, Juan Quintela wrote: > > Yang Hongyang wrote: > >> Hi all, > >> > >> We found dirty log switch costs more then 13 seconds while migrating > >> a 4T memory guest, and dirty log switch is currently

Re: [Qemu-devel] error: qcrypto_random_bytes() tried to read from /dev/[u]random, even on windows

2017-04-24 Thread Daniel P. Berrange
On Mon, Apr 24, 2017 at 06:33:26PM +0200, Geert Martin Ijewski wrote: > > We can have the existing qcrypto_init() call a qcrypto_random_init() > > method to do the one-time initialization task, since that's already > > required to run early in order to initialize gnutls when we use it. > >

  1   2   3   >