[Qemu-devel] [PATCH v3 2/4] target-arm: kvm64: detect guest RAS EXTENSION feature

2017-04-29 Thread Dongjiu Geng
check if kvm supports guest RAS EXTENSION. if so, set corresponding feature bit for vcpu. Signed-off-by: Dongjiu Geng --- linux-headers/asm-arm64/kvm.h | 1 + linux-headers/linux/kvm.h | 1 + target/arm/cpu.h | 3 +++ target/arm/kvm64.c| 8

[Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

2017-04-29 Thread Dongjiu Geng
This implements APEI GHES Table by passing the error cper info to the guest via a fw_cfg_blob. After a CPER info is added, an SEA/SEI exception will be injected into the guest OS. Below is the table layout, the max number of error soure is 11, which is classified by notification type.

[Qemu-devel] [PATCH v3 3/4] target-arm: kvm64: handle SIGBUS signal for synchronous External Abort

2017-04-29 Thread Dongjiu Geng
If RAS extension feature exists, when guest OS happen synchronous External Abort, a SIGBUS signal will be delivered from the kvm. so handle this signal, generate GHES record and inject this abort to notify guest. then guest can handle this abort The Synchronous External Abort mainly includes

[Qemu-devel] [PATCH v3 4/4] target-arm: kvm64: handle SError interrupt for RAS extension

2017-04-29 Thread Dongjiu Geng
Record this CPER to GHES, and raise a virtual SError interrupt with specified syndrome information, the virtual syndrome is delivered by vsesr_el2. the reason that record the error to HEST table and inject the SError to guest is due to guest can handle some errores to avoid directly panic, such as

[Qemu-devel] [PATCH v3 3/3] arm/arm64: signal SIBGUS and inject SEA Error

2017-04-29 Thread Dongjiu Geng
when happen SEA, deliver signal bus and handle the ioctl that inject SEA abort to guest, so that guest can handle the SEA error. Signed-off-by: Dongjiu Geng --- arch/arm/include/asm/kvm_host.h | 1 + arch/arm/kvm/arm.c| 3 +++ arch/arm/kvm/guest.c

[Qemu-devel] [PATCH v3 1/3] arm64: kvm: support kvmtool to detect RAS extension feature

2017-04-29 Thread Dongjiu Geng
Handle kvmtool's detection for RAS extension, because sometimes the APP needs to know the CPU's capacity Signed-off-by: Dongjiu Geng --- arch/arm64/kvm/reset.c | 11 +++ include/uapi/linux/kvm.h | 1 + 2 files changed, 12 insertions(+) diff --git

[Qemu-devel] [PATCH v3 2/3] arm64: kvm: inject SError with virtual syndrome

2017-04-29 Thread Dongjiu Geng
when SError happen, kvm notifies kvmtool to generate GHES table to record the error, then kvmtools inject the SError with specified virtual syndrome. when switch to guest, a virtual SError will happen with this specified syndrome. Signed-off-by: Dongjiu Geng ---

[Qemu-devel] [Bug 1200212] Re: qemu-system-arm aborts in lsi_soft_reset

2017-04-29 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1200212 Title:

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-04-29 Thread FONNEMANN Mark
>Ah, you are using curses... I've been putting logs onto stderr for simplicity, >not the proper qemu logs. Here is a fixed patch to get output in the log. OK, I have an interesting development that I hope will shed some light on the problem. This configuration works using a different image

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-04-29 Thread FONNEMANN Mark
Hello- >One first thing to note: the DNS or SMB servers can not be pinged, since that >was never implemented (I'll post a patch for that), so there is no surprise on >that end. OK >When running with a Linux host (since that's what I'm most familiar with), >what do you have in

Re: [Qemu-devel] [PATCH v11 1/9] qemu-io: Improve alignment checks

2017-04-29 Thread Philippe Mathieu-Daudé
On 04/29/2017 04:14 PM, Eric Blake wrote: Several copy-and-pasted alignment checks exist in qemu-io, which could use some minor improvements: - Manual comparison against 0x1ff is not as clean as using our alignment macros (QEMU_IS_ALIGNED) from osdep.h. - The error messages aren't quite

Re: [Qemu-devel] [PATCH] slirp: fix pinging the virtual ipv4 DNS server

2017-04-29 Thread Philippe Mathieu-Daudé
On 04/29/2017 09:47 AM, Samuel Thibault wrote: so that people do not think it is not working at least basically. Signed-off-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c index

Re: [Qemu-devel] [PATCH v2 9/9] hw/sparc64: QOM'ify sun4u.c

2017-04-29 Thread Philippe Mathieu-Daudé
On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: Drop the old SysBusDeviceClass::init and use instance_init or DeviceClass::realize instead Signed-off-by: xiaoqiang zhao Reviewed-by: Philippe Mathieu-Daudé --- hw/sparc64/sun4u.c | 20 +---

Re: [Qemu-devel] [PATCH v2 3/9] hw/dma: QOM'ify sun4m_iommu.c

2017-04-29 Thread Philippe Mathieu-Daudé
On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao Reviewed-by: Philippe Mathieu-Daudé --- hw/dma/sun4m_iommu.c | 12 +--- 1 file changed, 5 insertions(+), 7

Re: [Qemu-devel] [PATCH v2 8/9] hw/sparc: QOM'ify sun4m.c

2017-04-29 Thread Philippe Mathieu-Daudé
On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: Drop the old SysBusDeviceClass::init and use instance_init or DeviceClass::realize instead Signed-off-by: xiaoqiang zhao Reviewed-by: Philippe Mathieu-Daudé --- hw/sparc/sun4m.c | 54

Re: [Qemu-devel] [PATCH v2 7/9] hw/timer: QOM'ify slavio_timer

2017-04-29 Thread Philippe Mathieu-Daudé
On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: rename slavio_timer_init1 to slavio_timer_init and assign it to slavio_timer_info.instance_init, then we drop the SysBusDeviceClass::init Signed-off-by: xiaoqiang zhao Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v2 2/9] hw/dma: QOM'ify sparc32_dma.c

2017-04-29 Thread Philippe Mathieu-Daudé
On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: Drop the old SysBus init function and use instance_init and an realize function Signed-off-by: xiaoqiang zhao Reviewed-by: Philippe Mathieu-Daudé --- hw/dma/sparc32_dma.c | 25 +++-- 1

Re: [Qemu-devel] [PATCH v2 4/9] hw/misc: QOM'ify slavio_misc.c

2017-04-29 Thread Philippe Mathieu-Daudé
On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao Reviewed-by: Philippe Mathieu-Daudé --- hw/misc/slavio_misc.c | 43 +-- 1 file

Re: [Qemu-devel] [PATCH v2 1/9] hw/misc: QOM'ify eccmemctl.c

2017-04-29 Thread Philippe Mathieu-Daudé
On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: * Split the old SysBus init into an instance_init and a DeviceClass::realize function * Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-04-29 Thread Samuel Thibault
FONNEMANN Mark, on sam. 29 avril 2017 20:06:09 +, wrote: > [mfonnemann@localhost qemu]$ /usr/local/bin/qemu-system-i386 -display curses > -readconfig qemu.cfg -D logfile Ah, you are using curses... I've been putting logs onto stderr for simplicity, not the proper qemu logs. Here is a fixed

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-04-29 Thread FONNEMANN Mark
>Ok, so nothing going out from qemu. Could you try to apply the attached patch >to qemu-2.9 and see what it makes qemu print when you resolve a domain from >the guest? After applying patch, compiling, installing and then doing a nslookup request in the guest, I still receive no output in

[Qemu-devel] [PATCH v11 6/9] blkdebug: Add pass-through write_zero and discard support

2017-04-29 Thread Eric Blake
In order to test the effects of artificial geometry constraints on operations like write zero or discard, we first need blkdebug to manage these actions. It also allows us to inject errors on those operations, just like we can for read/write/flush. We can also test the contract promised by the

[Qemu-devel] [PATCH v11 8/9] blkdebug: Add ability to override unmap geometries

2017-04-29 Thread Eric Blake
Make it easier to simulate various unusual hardware setups (for example, recent commits 3482b9b and b8d0a98 affect the Dell Equallogic iSCSI with its 15M preferred and maximum unmap and write zero sizing, or b2f95fe deals with the Linux loopback block device having a max_transfer of 64k), by

[Qemu-devel] [PATCH v11 2/9] qemu-io: Switch 'alloc' command to byte-based length

2017-04-29 Thread Eric Blake
For the 'alloc' command, accepting an offset in bytes but a length in sectors, and reporting output in sectors, is confusing. Do everything in bytes, and adjust the expected output accordingly. Signed-off-by: Eric Blake --- v11: s/bytes/count/ for the parameter name, drop

[Qemu-devel] [PATCH v11 3/9] qemu-io: Switch 'map' output to byte-based reporting

2017-04-29 Thread Eric Blake
Mixing byte offset and sector allocation counts is a bit confusing. Also, reporting n/m sectors, where m decreases according to the remaining size of the file, isn't really adding any useful information; and reporting an offset at both the front and end of the line, with large amounts of

[Qemu-devel] [PATCH v11 7/9] blkdebug: Simplify override logic

2017-04-29 Thread Eric Blake
Rather than store into a local variable, then copy to the struct if the value is valid, then reporting errors otherwise, it is simpler to just store into the struct and report errors if the value is invalid. This however requires that the struct store a 64-bit number, rather than a narrower type.

[Qemu-devel] [PATCH v11 5/9] blkdebug: Refactor error injection

2017-04-29 Thread Eric Blake
Rather than repeat the logic at each caller of checking if a Rule exists that warrants an error injection, fold that logic into inject_error(); and rename it to rule_check() for legibility. This will help the next patch, which adds two more callers that need to check rules for the potential of

[Qemu-devel] [PATCH v11 4/9] blkdebug: Sanity check block layer guarantees

2017-04-29 Thread Eric Blake
Commits 04ed95f4 and 1a62d0ac updated the block layer to auto-fragment any I/O to fit within device boundaries. Additionally, when using a minimum alignment of 4k, we want to ensure the block layer does proper read-modify-write rather than requesting I/O on a slice of a sector. Let's enforce that

[Qemu-devel] [PATCH v11 9/9] tests: Add coverage for recent block geometry fixes

2017-04-29 Thread Eric Blake
Use blkdebug's new geometry constraints to emulate setups that have needed past regression fixes: write zeroes asserting when running through a loopback block device with max-transfer smaller than cluster size, and discard rounding away portions of requests not aligned to preferred boundaries.

[Qemu-devel] [PATCH v11 0/9] add blkdebug tests

2017-04-29 Thread Eric Blake
Available as a tag at: git fetch git://repo.or.cz/qemu/ericb.git nbd-blkdebug-v11 Prerequisites: Kevin's block pull request: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg05799.html v10 was: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg05227.html Since then: - Rebase to

[Qemu-devel] [PATCH v11 1/9] qemu-io: Improve alignment checks

2017-04-29 Thread Eric Blake
Several copy-and-pasted alignment checks exist in qemu-io, which could use some minor improvements: - Manual comparison against 0x1ff is not as clean as using our alignment macros (QEMU_IS_ALIGNED) from osdep.h. - The error messages aren't quite grammatically correct. Suggested-by: Philippe

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-04-29 Thread Samuel Thibault
FONNEMANN Mark, on sam. 29 avril 2017 18:25:26 +, wrote: > 0 packets received by filter Ok, so nothing going out from qemu. Could you try to apply the attached patch to qemu-2.9 and see what it makes qemu print when you resolve a domain from the guest? Samuel --- a/slirp/socket.c +++

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-04-29 Thread FONNEMANN Mark
Hello- >And I guess these do work fine on the host. Yes: [mfonnemann@localhost ~]$ nslookup www.google.com Server: 4.2.2.1 Address:4.2.2.1#53 Non-authoritative answer: Name: www.google.com Address: 172.217.11.4 >Perhaps you should make sure that qemu does emit the DNS lookup

[Qemu-devel] [Bug 1687214] [NEW] Rapid tremendous memory hog when using -net nic, vlan=0 -net user, vlan=0

2017-04-29 Thread Alamot
Public bug reported: A rapid tremendous memory hog is occuring when I use -net nic,vlan=0 -net user,vlan=0. Tested with QEMU 2.8.0 & 2.9.0 in Gentoo. All available memory (8GB) + swap (over 20GB) is exhausted very rapidly. This bug is possibly related to

Re: [Qemu-devel] [PULL 0/9] slirp updates

2017-04-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 0/9] slirp updates Message-id: 20170429164750.17414-1-samuel.thiba...@ens-lyon.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-04-29 Thread Samuel Thibault
FONNEMANN Mark, on sam. 29 avril 2017 15:32:35 +, wrote: > >When running with a Linux host (since that's what I'm most familiar with), > >what do you have in /etc/resolv.conf? > > [mfonnemann@localhost ~]$ cat /etc/resolv.conf > # Generated by NetworkManager > nameserver 4.2.2.1 > nameserver

[Qemu-devel] [PULL 8/9] slirp: VMStatify socket level

2017-04-29 Thread Samuel Thibault
From: "Dr. David Alan Gilbert" Working up the stack, this replaces the slirp_socket_load/save with VMState definitions. A place holder for IPv6 support is added as a comment; it needs testing once the rest of the IPv6 code is there. Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 9/9] slirp: VMStatify remaining except for loop

2017-04-29 Thread Samuel Thibault
From: "Dr. David Alan Gilbert" This converts the remaining components, except for the top level loop, to VMState. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Samuel Thibault

[Qemu-devel] [PULL 5/9] slirp: VMState conversion; tcpcb

2017-04-29 Thread Samuel Thibault
From: "Dr. David Alan Gilbert" Convert the migration of the struct tcpcb to use a VMStateDescription, the rest of it will come later. Mostly mechanical, except for conversion of some 'char' to uint8_t to ensure portability. Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 6/9] slirp: VMStatify sbuf

2017-04-29 Thread Samuel Thibault
From: "Dr. David Alan Gilbert" Convert the sbuf structure to a VMStateDescription. Note this uses the VMSTATE_WITH_TMP mechanism to calculate and reload the offsets based on the pointers. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson

[Qemu-devel] [PULL 7/9] slirp: Common lhost/fhost union

2017-04-29 Thread Samuel Thibault
From: "Dr. David Alan Gilbert" The socket structure has a pair of unions for lhost and fhost addresses; the unions are identical so split them out into a separate union declaration. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Philippe

[Qemu-devel] [PULL 4/9] slirp: fix pinging the virtual ipv4 DNS server

2017-04-29 Thread Samuel Thibault
so that people do not think it is not working at least basically. Signed-off-by: Samuel Thibault --- slirp/ip_icmp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c index 5ffc7a683d..0b667a429a 100644 ---

[Qemu-devel] [PULL 2/9] slirp/smb: Replace constant strings by glib string

2017-04-29 Thread Samuel Thibault
From: "Dr. David Alan Gilbert" gcc 7 (on fedora 26) objects to many of the snprintf's in the smb path and command creation because it can't figure out that the smb_dir (i.e. the /tmp dir for the configuration) is known to be short. Replace all these fixed length buffers by

[Qemu-devel] [PULL 3/9] slirp: tftp, copy sockaddr_size

2017-04-29 Thread Samuel Thibault
From: Marc-André Lureau ASAN detects an "unknown-crash" when running pxe-test: /ppc64/pxe/spapr-vlan: = ==7143==ERROR: AddressSanitizer: unknown-crash on address 0x7f6dcd298d30 at pc 0x55e22218830d bp

[Qemu-devel] [PULL 1/9] slirp: allow host port 0 for hostfwd

2017-04-29 Thread Samuel Thibault
From: Vincent Bernat The OS will allocate automatically a free port. This is useful if you want to be sure to not get any port conflict. You still have to figure out which port you got, for example with "lsof" (this could be exposed in the monitor if needed). Example of use:

[Qemu-devel] [PULL 0/9] slirp updates

2017-04-29 Thread Samuel Thibault
The following changes since commit 81b2d5ceb0cfb4cdc2163492e3169ed714b0cda9: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20170426' into staging (2017-04-26 20:50:49 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault

Re: [Qemu-devel] [PATCH RESEND V3 4/6] migration: add postcopy downtime into MigrationIncommingState

2017-04-29 Thread Eric Blake
On 04/29/2017 04:16 AM, Alexey wrote: > There seem to be two parts to this: > a) Adding the mis parameter to ufd_version_check > b) Asking for the feature > Please split it into two patches. Also, fix the typo in the subject line: s/Incomming/Incoming/ -- Eric

Re: [Qemu-devel] [PATCH qemu v5] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH qemu v5] memory/iommu: QOM'fy IOMMU MemoryRegion Message-id: 20170429123707.16675-1-...@ozlabs.ru Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH] slirp: fix pinging the virtual ipv4 DNS server

2017-04-29 Thread Samuel Thibault
so that people do not think it is not working at least basically. Signed-off-by: Samuel Thibault diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c index 5ffc7a683d..0b667a429a 100644 --- a/slirp/ip_icmp.c +++ b/slirp/ip_icmp.c @@ -152,8 +152,9 @@ icmp_input(struct

Re: [Qemu-devel] dns server not working in QEMU using usermode networking (SLIRP)

2017-04-29 Thread Samuel Thibault
Hello, FONNEMANN Mark, on mer. 19 avril 2017 18:11:59 +, wrote: > I have tested 2.9-rc4 and the problem still exists there as well. FONNEMANN Mark, on lun. 24 avril 2017 23:43:02 +, wrote: > I just confirmed that the problem exists in 2.9 release using > qemu-system-i386.exe as well.

Re: [Qemu-devel] [PULL 04/34] Revert "block/io: Comment out permission assertions"

2017-04-29 Thread Paolo Bonzini
On 28/04/2017 22:33, Kevin Wolf wrote: > From: Max Reitz > > This reverts commit e3e0003a8f6570aba1421ef99a0b383a43371a74. > > This commit was necessary for the 2.9 release because we were unable to > fix the underlying issue(s) in time. However, we will be for 2.10. > >

[Qemu-devel] [PATCH qemu v5] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-29 Thread Alexey Kardashevskiy
This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion as a parent. This moves IOMMU-related fields from MR to IOMMU MR. However to avoid dymanic QOM casting in fast path (address_space_translate, etc), this adds an @is_iommu boolean flag to MR and provides new helper to do simple

Re: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-29 Thread Alexey Kardashevskiy
On 29/04/17 22:28, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion > Message-id: 20170429115509.27551-1-...@ozlabs.ru > Type:

Re: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion Message-id: 20170429115509.27551-1-...@ozlabs.ru Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-29 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20170429115509.27551-1-...@ozlabs.ru Subject: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked

[Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-29 Thread Alexey Kardashevskiy
This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion as a parent. This moves IOMMU-related fields from MR to IOMMU MR. However to avoid dymanic QOM casting in fast path (address_space_translate, etc), this adds an @is_iommu boolean flag to MR and provides new helper to do simple

[Qemu-devel] [PATCH v2 9/9] hw/sparc64: QOM'ify sun4u.c

2017-04-29 Thread xiaoqiang zhao
Drop the old SysBusDeviceClass::init and use instance_init or DeviceClass::realize instead Signed-off-by: xiaoqiang zhao --- hw/sparc64/sun4u.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c

[Qemu-devel] [PATCH v2 2/9] hw/dma: QOM'ify sparc32_dma.c

2017-04-29 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init and an realize function Signed-off-by: xiaoqiang zhao --- hw/dma/sparc32_dma.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/hw/dma/sparc32_dma.c b/hw/dma/sparc32_dma.c

[Qemu-devel] [PATCH v2 4/9] hw/misc: QOM'ify slavio_misc.c

2017-04-29 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/misc/slavio_misc.c | 43 +-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/hw/misc/slavio_misc.c b/hw/misc/slavio_misc.c

[Qemu-devel] [PATCH v2 7/9] hw/timer: QOM'ify slavio_timer

2017-04-29 Thread xiaoqiang zhao
rename slavio_timer_init1 to slavio_timer_init and assign it to slavio_timer_info.instance_init, then we drop the SysBusDeviceClass::init Signed-off-by: xiaoqiang zhao --- hw/timer/slavio_timer.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH v2 8/9] hw/sparc: QOM'ify sun4m.c

2017-04-29 Thread xiaoqiang zhao
Drop the old SysBusDeviceClass::init and use instance_init or DeviceClass::realize instead Signed-off-by: xiaoqiang zhao --- hw/sparc/sun4m.c | 54 +++--- 1 file changed, 19 insertions(+), 35 deletions(-) diff --git

[Qemu-devel] [PATCH v2 1/9] hw/misc: QOM'ify eccmemctl.c

2017-04-29 Thread xiaoqiang zhao
* Split the old SysBus init into an instance_init and a DeviceClass::realize function * Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/misc/eccmemctl.c | 25 - 1 file changed, 16 insertions(+), 9

[Qemu-devel] [PATCH v2 6/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2017-04-29 Thread xiaoqiang zhao
assign DeviceClass::vmsd instead of using vmstate_register function Signed-off-by: xiaoqiang zhao --- hw/timer/m48t59.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/timer/m48t59.c b/hw/timer/m48t59.c index eff259ef96..3a9f541c9b 100644 ---

[Qemu-devel] [PATCH v2 0/9] QOM'ify work for sparc

2017-04-29 Thread xiaoqiang zhao
This patch set aims for QOM'ifying code relate with sparc. It is part of my QOM'ify work of qemu code base. changes since v1: * rebased on the latest master xiaoqiang zhao (9): hw/misc: QOM'ify eccmemctl.c hw/dma: QOM'ify sparc32_dma.c hw/dma: QOM'ify sun4m_iommu.c hw/misc: QOM'ify

[Qemu-devel] [PATCH v2 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 1)

2017-04-29 Thread xiaoqiang zhao
* split the old SysBus init function into an instance_init and a Device realize function * use DeviceClass::realize instead of SysBusDeviceClass::init Signed-off-by: xiaoqiang zhao --- hw/timer/m48t59.c | 35 ++- 1 file changed, 18

[Qemu-devel] [PATCH v2 3/9] hw/dma: QOM'ify sun4m_iommu.c

2017-04-29 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/dma/sun4m_iommu.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/dma/sun4m_iommu.c b/hw/dma/sun4m_iommu.c index b3cbc54c23..335ef63cbc 100644 ---

Re: [Qemu-devel] [PATCH v5 + 1/2] target/aarch64: optimize cross-page direct jumps in softmmu

2017-04-29 Thread Richard Henderson
On 04/28/2017 09:22 PM, Emilio G. Cota wrote: On Fri, Apr 28, 2017 at 15:17:24 -0400, Emilio G. Cota wrote: Perf numbers in next commit's log. Signed-off-by: Emilio G. Cota --- target/arm/translate-a64.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] target/openrisc: Support non-busy idle state using PMR SPR

2017-04-29 Thread Stafford Horne
On Sat, Apr 29, 2017 at 11:32:52AM +0200, Richard Henderson wrote: > On 04/28/2017 11:10 PM, Stafford Horne wrote: > > +raise_exception(cpu, EXCP_HLT); > > One minor tweak -- EXCP_HALTED. > > HLT is, in theory, i386 specific. Not that you'd have noticed a difference. > FWIW, I've

Re: [Qemu-devel] [PATCH] target/openrisc: Support non-busy idle state using PMR SPR

2017-04-29 Thread Richard Henderson
On 04/28/2017 11:10 PM, Stafford Horne wrote: +raise_exception(cpu, EXCP_HLT); One minor tweak -- EXCP_HALTED. HLT is, in theory, i386 specific. Not that you'd have noticed a difference. FWIW, I've just found the same error in target/alpha. Otherwise, Reviewed-by: Richard

Re: [Qemu-devel] [PATCH] (RFC) remove the GThread coroutine implementation

2017-04-29 Thread Richard Henderson
On 04/28/2017 02:24 PM, Daniel P. Berrange wrote: At the 2016 summit it was suggested that we delete the GThread coroutine impl since it is not fully functional, and you can debug the ucontext impl with our GDB helper script. I don't recall the subject being raised again since the summit so

Re: [Qemu-devel] [PATCH RESEND V3 4/6] migration: add postcopy downtime into MigrationIncommingState

2017-04-29 Thread Alexey
On Fri, Apr 28, 2017 at 05:22:05PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Fri, Apr 28, 2017 at 01:03:45PM +0300, Alexey Perevalov wrote: > > > > [...] > > > > > >>diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c > > > >>index

Re: [Qemu-devel] [PATCH v5 11/19] target/i386: optimize cross-page direct jumps in softmmu

2017-04-29 Thread Richard Henderson
On 04/28/2017 06:56 PM, Alex Bennée wrote: Richard Henderson writes: From: "Emilio G. Cota" Instead of unconditionally exiting to the exec loop, use the gen_jr helper to jump to the target if it is valid. Perf impact: see next commit's log. Reviewed-by: