Re: [Qemu-devel] [PATCH v3 2/3] qemu.py: Add QEMUMachine.exitcode() method

Eduardo Habkost writes: > On Mon, May 29, 2017 at 06:53:47PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > Allow the exit code of QEMU to be queried by scripts. >> > >> > Signed-off-by: Eduardo Habkost >> >

Re: [Qemu-devel] [PATCH v2] blockdev: Print a warning for legacy drive options that belong to -device

Thomas Huth writes: > We likely do not want to carry these legacy -drive options along forever. > Let's emit a deprecation warning for the -drive options that have a > replacement with the -device option, so that the (hopefully few) remaining > users are aware of this and can

Re: [Qemu-devel] [PATCH 0/3] arm/virt: refine virt.c code and implement hot_add_cpu interface

> 在 2017年5月29日，下午6:43，Igor Mammedov 写道： > > On Sat, 27 May 2017 10:32:33 +0800 > Li Zhang wrote: > >>> On Fri, May 26, 2017 at 7:21 PM, Igor Mammedov wrote: >>> On Fri, 26 May 2017 17:21:05 +0800 >>> Li Zhang

Re: [Qemu-devel] [PATCH 03/17] tests: remove alt num-int cases

I noticed you were wondering what happend to this message in the patchew thread: http://patchew.org/QEMU/20170509173559.31598-1-marcandre.lur...@redhat.com/ Markus, apparently this is because of the unusual "In-Reply-To" header of your message, which confuses patchew: In-Reply-To:

Re: [Qemu-devel] [PATCHv4 0/5] Clean up compatibility mode handling

On Fri, 26 May 2017 15:23:14 +1000 David Gibson wrote: [...] > > > Changes since v3: > * Backwards compatible -cpu handling now removes compat= option from > options passed on to the cpu, so it doesn't trigger further warnings This seems to also have another

Re: [Qemu-devel] [PATCH v2 14/14] char: move char devices to chardev/

On 05/29/2017 05:45 AM, Marc-André Lureau wrote: Suggested by Paolo Bonizini during series review. Bonzini ;) "serie" singular Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- {backends => chardev}/baum.c |

Re: [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit

Hi Marc-André, Reviewed-by: Philippe Mathieu-Daudé On 05/29/2017 05:45 AM, Marc-André Lureau wrote: Move all the fronted struct and methods to a seperate unit. This avoids "frontend, separate" accidentally mixing backend and frontend calls, and helps with readibilty.

Re: [Qemu-devel] [Qemu-ppc] [PULL 11/18] pseries: Split CAS PVR negotiation out into a separate function

On Thu, 25 May 2017 13:51:25 +1000 David Gibson wrote: > Guests of the qemu machine type go through a feature negotiation process > known as "client architecture support" (CAS) during early boot. This does > a number of things, one of which is finding a CPU

Re: [Qemu-devel] [PATCH v2 10/14] char: generalize qemu_chr_write_all()

Hi Marc-André, On 05/29/2017 05:45 AM, Marc-André Lureau wrote: qemu_chr_fe_write() is similar to qemu_chr_write_all(): the later write all with a chardev backend. Make qemu_chr_write() and qemu_chr_fe_write_buffer() take an 'all' argument. If false, handle 'partial' write the way

Re: [Qemu-devel] [PATCH v2 08/14] chardev: serial & parallel declaration to own headers

On 05/29/2017 05:45 AM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- include/chardev/char-parallel.h | 20 +++- include/chardev/char-serial.h | 22 ++

Re: [Qemu-devel] [PATCH v2 07/14] chardev: move headers to include/chardev

On 05/29/2017 05:45 AM, Marc-André Lureau wrote: So they are all in one place. The following patch will move serial & parallel declarations to the respective headers. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé ---

Re: [Qemu-devel] Throttling groups vs filter nodes

On Mon, May 29, 2017 at 05:05:17PM +0200, Alberto Garcia wrote: On Sat 27 May 2017 09:56:03 AM CEST, Stefan Hajnoczi wrote: A quirk in the current implementation is that the throttling limits for the group are overwritten by each -drive throttling.group=group0. Limits for all but the last

Re: [Qemu-devel] [PATCH v2 06/14] Remove/replace sysemu/char.h inclusion

On 05/29/2017 05:45 AM, Marc-André Lureau wrote: Those are apparently unnecessary includes. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/bcm2835_peripherals.c | 1 - hw/char/imx_serial.c | 1 -

Re: [Qemu-devel] [PATCH] simpletrace: Improve the error message if event is not declared

On 05/29/2017 01:30 PM, Jose Ricardo Ziviani wrote: Today, if we use a trace-event file which does not declare an event existing in the log file we'll get the following error: $ scripts/simpletrace.py trace-events trace-68508 Traceback (most recent call last): File "scripts/simpletrace.py",

Re: [Qemu-devel] [PATCH v2 01/29] target/s390x: remove dead code in translate.c

On 05/29/2017 04:24 PM, Aurelien Jarno wrote: Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Reviewed-by: Philippe Mathieu-Daudé --- target/s390x/translate.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)

Re: [Qemu-devel] [PATCHv4 2/5] migration: Mark CPU states dirty before incoming migration/loadvm

On Fri, 26 May 2017 15:23:16 +1000 David Gibson wrote: > As a rule, CPU internal state should never be updated when > !cpu->kvm_vcpu_dirty (or the HAX equivalent). If that is done, then > subsequent calls to cpu_synchronize_state() - usually safe and idempotent - >

[Qemu-devel] [PULL 4/5] target/sh4: ignore interrupts in a delay slot

Delay slots are indivisible, therefore avoid scheduling an interrupt in the delay slot. However exceptions are possible. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno ---

[Qemu-devel] [PULL 3/5] target/sh4: introduce DELAY_SLOT_MASK

This will make easier the introduction of a new flag in the next patches. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/sh4/cpu.h | 3 ++- target/sh4/helper.c| 4

[Qemu-devel] [PATCH v2 13/29] target/s390x: implement MOVE ZONES

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 13 + target/s390x/translate.c | 8 4 files changed, 24

[Qemu-devel] [PULL 2/5] target/sh4: fix reset when using a kernel and an initrd

When a masked exception happens, the SH4 CPU generates a non-masked reset exception, which then jumps to the reset vector at address 0xA000. While this is emulated correctly in QEMU, this does not work when using a kernel and initrd as this address then contain an illegal instruction (and

[Qemu-devel] [PATCH v2 24/29] target/s390x: implement PACK UNICODE

Use a common helper with PACK ASCII as the differences are limited to the stride of the source operand. Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 30 +-

[Qemu-devel] [PATCH v2 25/29] target/s390x: implement UNPACK ASCII

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 51 ++ target/s390x/translate.c | 17

[Qemu-devel] [PATCH v2 29/29] target/s390x: update maximum TCG model to z800

At the same time fix the TCG version of get_max_cpu_model to return the maximum model like on KVM. Remove the long-displacement facility from the additional features as it is included in the z800. Signed-off-by: Aurelien Jarno --- target/s390x/cpu_models.c | 12

[Qemu-devel] [PULL 5/5] target/sh4: fix RTE instruction delay slot

The ReTurn from Exception (RTE) instruction loads the system register (SR) with the saved system register (SSR). It has a delay slot, and behaves specially according to the SH4 manual: The SR value accessed by the instruction in the RTE delay slot is the value restored from SSR by the RTE

[Qemu-devel] [PATCH v2 11/29] target/s390x: implement MOVE NUMERICS

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 13 + target/s390x/translate.c | 8 4 files changed, 24

[Qemu-devel] [PATCH v2 12/29] target/s390x: implement MOVE WITH OFFSET

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 4 target/s390x/mem_helper.c | 31 +++ target/s390x/translate.c | 8 4 files

[Qemu-devel] [PULL 1/5] target/sh4: log unauthorized accesses using qemu_log_mask

qemu_log_mask() is preferred over fprintf() for logging errors. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/sh4/helper.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH v2 27/29] target/s390x: implement TEST DECIMAL

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 3 +++ target/s390x/mem_helper.c | 23 +++ target/s390x/translate.c | 9 + 4 files changed,

[Qemu-devel] [PATCH v2 21/29] target/s390x: implement COMPARE LOGICAL LONG UNICODE

For that we need to make program_interrupt available to qemu-user. Fortunately there is almost nothing to change as both kvm_enabled and CONFIG_KVM evaluate to false in that case. Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 +

[Qemu-devel] [PATCH v2 26/29] target/s390x: implement UNPACK UNICODE

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 49 -- target/s390x/translate.c | 18

[Qemu-devel] [PATCH v2 02/29] target/s390x: remove some Linux assumptions from IPTE

Signed-off-by: Aurelien Jarno --- target/s390x/cpu.h| 2 ++ target/s390x/mem_helper.c | 17 ++--- target/s390x/mmu_helper.c | 4 +--- 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h index

[Qemu-devel] [PATCH v2 04/29] target/s390x: implement TEST AND SET

Signed-off-by: Aurelien Jarno --- target/s390x/insn-data.def | 3 +++ target/s390x/translate.c | 10 ++ 2 files changed, 13 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index f818437069..0f70acea5c 100644 ---

[Qemu-devel] [PATCH v2 28/29] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO

Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 9 + target/s390x/mem_helper.c | 46 ++ target/s390x/translate.c | 13 + 4 files changed, 69 insertions(+)

[Qemu-devel] [PATCH v2 22/29] target/s390x: implement MOVE LONG UNICODE

Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 47 -- target/s390x/translate.c | 21 + 4 files changed, 65 insertions(+),

[Qemu-devel] [PATCH v2 03/29] target/s390x: implement local-TLB-clearing in IPTE

And at the same time make IPTE SMP aware. Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 2 +- target/s390x/mem_helper.c | 19 --- target/s390x/translate.c | 6 +- 3 files changed, 18 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH v2 23/29] target/s390x: implement PACK ASCII

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 35 +++ target/s390x/translate.c | 16

[Qemu-devel] [PATCH v2 08/29] target/s390x: implement STORE PAIR TO QUADWORD

Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 12 target/s390x/translate.c | 6 ++ 4 files changed, 21 insertions(+) diff --git a/target/s390x/helper.h

[Qemu-devel] [PATCH v2 18/29] target/s390x: implement COMPARE LOGICAL LONG

As CLCL and CLCLE mostly differ by their operands, use a common do_clcl helper. Another difference is that CLCL is not interruptible. Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 84

[Qemu-devel] [PATCH v2 14/29] target/s390x: improve 24-bit and 31-bit addresses read

Improve fix_address to also handle the 24-bit mode. Rename fix_address to wrap_address to better explain what is changed. Replace the calls to get_address with x2 = 0 and b2 = 0 by call to wrap_address, leading to the removal of this function. Rename get_address_31fix into get_address.

[Qemu-devel] [PATCH v2 16/29] target/s390x: improve 24-bit and 31-bit lengths read/write

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 47 +-- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/target/s390x/mem_helper.c

[Qemu-devel] [PATCH v2 06/29] target/s390x: implement PACK

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 5 + target/s390x/mem_helper.c | 37 + target/s390x/translate.c | 8 4

[Qemu-devel] [PATCH v2 20/29] target/s390x: improve MOVE LONG and MOVE LONG EXTENDED

As MVCL and MVCLE only differ by their operands, use a common do_mvcl helper. Optimize it calling fast_memmove and fast_memset. Correctly write back addresses. Check that r1 and r2/r3 registers are even. Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 90

[Qemu-devel] [PATCH v2 15/29] target/s390x: improve 24-bit and 31-bit addresses write

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c

[Qemu-devel] [PATCH v2 00/29] target/s390x: fix, improve and implement some more instructions

This patchset tries to improve the s390x emulation by fixing and improving some instructions. It implement some more instructions, from the zArchitecture base and from the Extended-Translation Facility 2. The last patch updates the maximum TCG CPU to z800, as the ETF2 and Long-Displacement

[Qemu-devel] [PATCH v2 09/29] target/s390x: implement COMPARE AND SIGNAL

These functions differ from COMPARE by generating an exception for a QNaN input. Use the non quiet version of floatXX_compare. Signed-off-by: Aurelien Jarno --- target/s390x/fpu_helper.c | 27 +++ target/s390x/helper.h | 3 +++

[Qemu-devel] [PATCH v2 10/29] target/s390x: implement MOVE INVERSE

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 12 target/s390x/translate.c | 8 4 files changed, 23

[Qemu-devel] [PATCH v2 05/29] target/s390x: implement TEST ADDRESSING MODE

Signed-off-by: Aurelien Jarno --- target/s390x/insn-data.def | 3 +++ target/s390x/translate.c | 10 ++ 2 files changed, 13 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index 0f70acea5c..170b50ef2e 100644 ---

[Qemu-devel] [PATCH v2 19/29] target/s390x: fix adj_len_to_page

adj_len_to_page doesn't return the correct result when the address is already page aligned and the length is bigger than a page. Fix that. Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 07/29] target/s390x: implement LOAD PAIR FROM QUADWORD

Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 13 + target/s390x/translate.c | 7 +++ 4 files changed, 23 insertions(+) diff --git a/target/s390x/helper.h

[Qemu-devel] [PATCH v2 01/29] target/s390x: remove dead code in translate.c

Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target/s390x/translate.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 97ca639a34..f7598184a6 100644 ---

[Qemu-devel] [RFC] Making 'block-stream', and 'block-commit' accept node-name

Observe the following ('qmp-shell', for brevity) invocation of the four major types (stream, commit, mirror, backup) of live block operations: (QEMU) block-stream device=node-D base=a.qcow2 job-id=job-block-stream (QEMU) block-commit device=node-D base=a.qcow2 top=b.qcow2

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > It will be needed in following commits for persistent bitmaps. > If bitmap is loaded from read-only storage (and we can't mark it > "in use" in this storage) corresponding BdrvDirtyBitmap should be > read-only. > > Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH 25/25] block: release persistent bitmaps on inactivate

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > We should release them here to reload on invalidate cache. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 4 > block/dirty-bitmap.c | 29

Re: [Qemu-devel] [PATCH 24/25] qmp: block-dirty-bitmap-remove: remove persistent

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Remove persistent bitmap from the storage on block-dirty-bitmap-remove. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > Reviewed-by: John Snow >

[Qemu-devel] [PATCH 2/2] hw/arm/virt: fdt: generate distance-map when needed

This is based on patch Shannon Zhao originally posted. Cc: Shannon Zhao Signed-off-by: Andrew Jones --- hw/arm/virt.c | 21 + 1 file changed, 21 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index

[Qemu-devel] [PATCH 0/2] hw/arm/virt: numa: provide distance info when needed

Andrew Jones (2): hw/arm/virt-acpi-build: build SLIT when needed hw/arm/virt: fdt: generate distance-map when needed hw/arm/virt-acpi-build.c | 4 hw/arm/virt.c| 21 + 2 files changed, 25 insertions(+) -- 2.9.4

[Qemu-devel] [PATCH 1/2] hw/arm/virt-acpi-build: build SLIT when needed

Cc: Shannon Zhao Signed-off-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index e5852067f5bd..2079828c22a4 100644 ---

Re: [Qemu-devel] [PATCH 21/25] iotests: test qcow2 persistent dirty bitmap

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/165 | 105 > + > tests/qemu-iotests/165.out | 5 +++ > tests/qemu-iotests/group | 1 +

Re: [Qemu-devel] [PATCH 15/25] qcow2: add persistent dirty bitmaps support

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Store persistent dirty bitmaps in qcow2 image. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 475 > +++ > block/qcow2.c|

Re: [Qemu-devel] [PATCH v3 2/3] qemu.py: Add QEMUMachine.exitcode() method

On Mon, May 29, 2017 at 06:53:47PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Allow the exit code of QEMU to be queried by scripts. > > > > Signed-off-by: Eduardo Habkost > > --- > > scripts/qemu.py | 4 > > 1 file changed, 4

Re: [Qemu-devel] [PATCH v3 2/3] qemu.py: Add QEMUMachine.exitcode() method

Eduardo Habkost writes: > Allow the exit code of QEMU to be queried by scripts. > > Signed-off-by: Eduardo Habkost > --- > scripts/qemu.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index

Re: [Qemu-devel] [PATCH 0/7] KVM: MMU: fast write protect

On 23/05/2017 04:23, Xiao Guangrong wrote: > > Ping... > > Sorry to disturb, just make this patchset not be missed. :) It won't. :) I'm going to look at it and the dirty page ring buffer this week. Paolo

Re: [Qemu-devel] [PATCH 13/25] block: introduce persistent dirty bitmaps

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > New field BdrvDirtyBitmap.persistent means, that bitmap should be saved > by format driver in .bdrv_close and .bdrv_inactivate. No format driver > supports it for now. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v3 1/3] qemu.py: Don't set _popen=None on error/shutdown

Eduardo Habkost writes: > Keep the Popen object around to we can query its exit code later. > > To keep the existing 'self._popen is None' checks working, add a > is_running() method, that will check if the process is still running. > > Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH 12/25] block: bdrv_close: release bitmaps after drv->bdrv_close

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Release bitmaps after 'if (bs->drv) { ... }' block. This will allow > format driver to save persistent bitmaps, which will appear in following > commits. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

[Qemu-devel] [PATCH] simpletrace: Improve the error message if event is not declared

Today, if we use a trace-event file which does not declare an event existing in the log file we'll get the following error: $ scripts/simpletrace.py trace-events trace-68508 Traceback (most recent call last): File "scripts/simpletrace.py", line 242, in run(Formatter()) File

Re: [Qemu-devel] [PATCH 10/25] qcow2: autoloading dirty bitmaps

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They > are loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Extra data in bitmaps is not supported for now. > >

Re: [Qemu-devel] [PATCH v2] blockdev: Print a warning for legacy drive options that belong to -device

On 12.05.2017 12:33, Thomas Huth wrote: > We likely do not want to carry these legacy -drive options along forever. > Let's emit a deprecation warning for the -drive options that have a > replacement with the -device option, so that the (hopefully few) remaining > users are aware of this and can

Re: [Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

Hi, did you remove me from the To: / Cc: list intentionally, or was that an oversight? I caught your message in my list folders only by luck. Some followup below: On 05/29/17 17:27, gengdongjiu wrote: >> (46) What is "physical_addr" good for? Below I can only see an >> assignment to it, in

Re: [Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables

On 2017-05-29 17:55, Eric Blake wrote: > On 05/29/2017 10:46 AM, Max Reitz wrote: > >>> If you switch all of these to $(realpath -- "$(type -p "$QEMU_...")"), >>> you can add: >> >> I'd love to, but this is what type -p outputs for me: >> >> $ type -p qemu-img >> qemu-img is /usr/bin/qemu-img >

Re: [Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables

On 05/29/2017 10:46 AM, Max Reitz wrote: >> If you switch all of these to $(realpath -- "$(type -p "$QEMU_...")"), >> you can add: > > I'd love to, but this is what type -p outputs for me: > > $ type -p qemu-img > qemu-img is /usr/bin/qemu-img Huh? That's plain 'type' output. Are you sure

Re: [Qemu-devel] Throttling groups vs filter nodes

Am 27.05.2017 um 09:56 hat Stefan Hajnoczi geschrieben: > Throttling groups allow multiple drives to share the same throttling > state (i.e. budget) between them. Manos is working on moving the > throttling code into a block filter driver so it is no longer > hardcoded into the I/O code path. >

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > It will be needed in following commits for persistent bitmaps. > If bitmap is loaded from read-only storage (and we can't mark it > "in use" in this storage) corresponding BdrvDirtyBitmap should be > read-only. > > Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables

On 2017-05-29 17:42, Eric Blake wrote: > On 05/29/2017 10:23 AM, Max Reitz wrote: >> A user may specify a relative path for accessing qemu, qemu-img, etc. >> through environment variables ($QEMU_PROG and friends) or a symlink. >> >> If a test decides to change its working directory, relative paths

Re: [Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables

On 05/29/2017 10:23 AM, Max Reitz wrote: > A user may specify a relative path for accessing qemu, qemu-img, etc. > through environment variables ($QEMU_PROG and friends) or a symlink. > > If a test decides to change its working directory, relative paths will > cease to work, however. Work around

Re: [Qemu-devel] [PATCH 08/25] qcow2: add bitmaps extension

On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote: > Add bitmap extension as specified in docs/specs/qcow2.txt. > For now, just mirror extension header into Qcow2 state and check > constraints. Also, calculate refcounts for qcow2 bitmaps, to not break > qemu-img check. > > For now, disable

Re: [Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

Dear Laszlo, Thank your very much for your review and detailed comment. and very sorry for the late response due to recently debug the wholes RAS solution. On 2017/5/22 22:23, Laszlo Ersek wrote: > Keeping some context: > > On 05/12/17 23:00, Laszlo Ersek wrote: >> On 04/30/17 07:35, Dongjiu

[Qemu-devel] [PATCH v3 2/2] iotests: Add test for colon handling

Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- tests/qemu-iotests/126 | 105 + tests/qemu-iotests/126.out | 23 ++ tests/qemu-iotests/group | 1 + 3 files changed, 129 insertions(+) create

[Qemu-devel] [PATCH v3 0/2] iotests: Add test for colon handling

This is a v3 for "block: Fix backing paths for filenames with colons". Kevin reported that the test added there does not work if the test programs are specified with relative paths (because the new test changes its working directory), so we/I dropped the test from the queue and here it is again.

[Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables

A user may specify a relative path for accessing qemu, qemu-img, etc. through environment variables ($QEMU_PROG and friends) or a symlink. If a test decides to change its working directory, relative paths will cease to work, however. Work around this by making all of the paths to programs that

[Qemu-devel] [PATCH] tests: Add unit tests for the VM Generation ID feature

From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. Read the GUID from guest memory * test that the "auto" argument to the GUID generates a valid GUID, as seen by the guest. * test that a GUID

[Qemu-devel] [PULL 14/15] block: Fix backing paths for filenames with colons

From: Max Reitz path_combine() naturally tries to preserve a protocol prefix. However, it recognizes such a prefix by scanning for the first colon; which is different from what path_has_protocol() does: There only is a protocol prefix if there is a colon before the first

[Qemu-devel] [PULL 15/15] block/file-*: *_parse_filename() and colons

From: Max Reitz The file drivers' *_parse_filename() implementations just strip the optional protocol prefix off the filename. However, for e.g. "file:foo:bar", this would lead to "foo:bar" being stored as the BDS's filename which looks like it should be managed using the

[Qemu-devel] [PULL 12/15] qemu-img: Fix leakage of options on error

From: Fam Zheng Reported by Coverity. Signed-off-by: Fam Zheng Message-id: 20170515141014.25793-1-f...@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- qemu-img.c | 1 + 1 file changed, 1 insertion(+)

[Qemu-devel] [PULL 06/15] qcow2: remove extra local_error variable

From: Alberto Garcia Commit d7086422b1c1e75e320519cfe26176db6ec97a37 added a local_err variable global to the qcow2_amend_options() function, so there's no need to have this other one. Signed-off-by: Alberto Garcia Message-id:

[Qemu-devel] [PULL 11/15] qemu-img: copy *key-secret opts when opening newly created files

From: "Daniel P. Berrange" The qemu-img dd/convert commands will create an image file and then try to open it. Historically it has been possible to open new files without passing any options. With encrypted files though, the *key-secret options are mandatory, so we need to

[Qemu-devel] [PULL 07/15] qemu-img: Fix documentation of convert

From: Fam Zheng It got lost in commit a8d16f9ca "qemu-img: Update documentation for -U". Reported-by: Max Reitz Signed-off-by: Fam Zheng Message-id: 20170515103551.31313-1-f...@redhat.com Reviewed-by: Eric Blake

[Qemu-devel] [PULL 13/15] block: Tweak error message related to qemu-img amend

From: Eric Blake When converting a 1.1 image down to 0.10, qemu-iotests 060 forces a contrived failure where allocating a cluster used to replace a zero cluster reads unaligned data. Since it is a zero cluster rather than a data cluster being converted, changing the error

[Qemu-devel] [PULL 10/15] qemu-img: introduce --target-image-opts for 'convert' command

From: "Daniel P. Berrange" The '--image-opts' flag indicates whether the source filename includes options. The target filename has to remain in the plain filename format though, since it needs to be passed to bdrv_create(). When using --skip-create though, it would be

[Qemu-devel] [PULL 04/15] nvme: Add support for Controller Memory Buffers

From: Stephen Bates Implement NVMe Controller Memory Buffers (CMBs) which were added in version 1.2 of the NVMe Specification. This patch adds an optional argument (cmb_size_mb) which indicates the size of the CMB (in MB). Currently only the Submission Queue Support (SQS) is

[Qemu-devel] [PULL 09/15] qemu-img: fix --image-opts usage with dd command

From: "Daniel P. Berrange" The --image-opts flag can only be used to affect the parsing of the source image. The target image has to be specified in the traditional style regardless, since it needs to be passed to the bdrv_create() API which does not support the new style

[Qemu-devel] [PULL 03/15] iotests: 147: Don't test inet6 if not available

From: Fam Zheng This is the case in our docker tests, as we use --net=none there. Skip this method. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/147 | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Qemu-devel] [PULL 08/15] qemu-img: add support for --object with 'dd' command

From: "Daniel P. Berrange" The qemu-img dd command added --image-opts support, but missed the corresponding --object support. This prevented passing secrets (eg auth passwords) needed by certain disk images. Reviewed-by: Fam Zheng Reviewed-by: Max Reitz

[Qemu-devel] [PULL 05/15] mirror: Drop permissions on s->target on completion

This fixes an assertion failure that was triggered by qemu-iotests 129 on some CI host, while the same test case didn't seem to fail on other hosts. Essentially the problem is that the blk_unref(s->target) in mirror_exit() doesn't necessarily mean that the BlockBackend goes away immediately. It

[Qemu-devel] [PULL 01/15] stream: fix crash in stream_start() when block_job_create() fails

From: Alberto Garcia The code that tries to reopen a BlockDriverState in stream_start() when the creation of a new block job fails crashes because it attempts to dereference a pointer that is known to be NULL. This is a regression introduced in

[Qemu-devel] [PULL 00/15] Block layer patches

The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging (2017-05-23 15:01:31 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch

[Qemu-devel] [PULL 02/15] qemu-iotests: Test streaming with missing job ID

This adds a small test for the image streaming error path for failing block_job_create(), which would have found the null pointer dereference in commit a170a91f. Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Reviewed-by: Kashyap Chamarthy

Re: [Qemu-devel] Throttling groups vs filter nodes

On Sat 27 May 2017 09:56:03 AM CEST, Stefan Hajnoczi wrote: > A quirk in the current implementation is that the throttling limits > for the group are overwritten by each -drive throttling.group=group0. > Limits for all but the last -drive in a group are ignored. > > There is no way to associate

Re: [Qemu-devel] [PATCH v1] target/s390x: addressing exceptions are suppressing

On 29.05.2017 14:12, David Hildenbrand wrote: > We have to make the address in the old PSW point at the next > instruction, as addressing exceptions are suppressing and not > nullifying. According to "Figure 6-1. Interruption Action" in the PoP, they could also be terminating ... but anyway, not

Re: [Qemu-devel] [Qemu-block] [PATCH 09/18] throttle-groups: protect throttled requests with a CoMutex

On Thu 25 May 2017 06:32:16 PM CEST, Paolo Bonzini wrote: > Another possibility is to use tg->lock, which we're holding anyway in > both schedule_next_request and throttle_group_co_io_limits_intercept. > This would require open-coding the CoQueue however, so I've chosen this > alternative. > >

  1   2   3   >