[Qemu-devel] [PATCH 1/2] audio/fmopl: modify timer callback to give opaque and channel parameters in two arguments

Signed-off-by: Hervé Poussineau --- hw/audio/adlib.c | 2 +- hw/audio/fmopl.c | 18 +- hw/audio/fmopl.h | 7 --- 3 files changed, 18 insertions(+), 9 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index c6e0f10c16..be4203476a 100644 ---

[Qemu-devel] [PATCH 0/2] Support multiple adlib sound cards

Hi, This patchset removes a global variable in adlib emulation, and allows to have multiple adlib sound cards. Note that indentation seem off because I have replaced some tabulations by spaces. Before: qemu-system-i386 -device adlib,iobase=0x220 -device adlib,iobase=0x240 qemu-system-i386:

[Qemu-devel] [PATCH 2/2] audio/adlib: remove limitation of one adlib card

Signed-off-by: Hervé Poussineau --- hw/audio/adlib.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index be4203476a..6a5d39a8c8 100644 --- a/hw/audio/adlib.c +++ b/hw/audio/adlib.c @@ -74,8 +74,6 @@

Re: [Qemu-devel] [PATCH] KVM: Add async pf flag to KVM_GET/SET_VCPU_EVENTS interface

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] KVM: Add async pf flag to KVM_GET/SET_VCPU_EVENTS interface Type: series Message-id: 1498014889-52658-1-git-send-email-wanpeng...@hotmail.com === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end Type: series Message-id: 20170621024831.26019-1-...@twiddle.net === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] Will huge page have negative effect on guest vm in qemu enviroment?

BTW, we also think about use ovs-dpdk in docker enviroment, but test result said it's not good idea, we don't know why. 2017-06-21 11:32 GMT+08:00 Sam : > Hi all, > > We plan to use DPDK on HP host machine with several core and big memory. > We plan to use qemu-kvm

Re: [Qemu-devel] [PATCH v3 12/13] migration: move skip_configuration out

On Mon, Jun 19, 2017 at 05:56:29PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > It was in SaveState but now moved to MigrationState altogether, reverted > > its meaning, then renamed to "send_configuration". Again, using > > HW_COMPAT_2_3 for old PC/SPAPR machines, and

[Qemu-devel] Will huge page have negative effect on guest vm in qemu enviroment?

Hi all, We plan to use DPDK on HP host machine with several core and big memory. We plan to use qemu-kvm enviroment. The host will carry 4 or more guest vm and 1 ovs. Ovs-dpdk is much faster then normal ovs, but to use ovs-dpdk, we have to enable huge page globally. My question is, will huge

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ

On 06/21/2017 12:18 AM, Michael S. Tsirkin wrote: On Fri, Jun 09, 2017 at 06:41:41PM +0800, Wei Wang wrote: - if (!virtqueue_indirect_desc_table_add(vq, desc, num)) { + if (!virtqueue_indirect_desc_table_add(vq, desc, *num)) { virtqueue_kick(vq); -

[Qemu-devel] [PATCH] KVM: Add async pf flag to KVM_GET/SET_VCPU_EVENTS interface

From: Wanpeng Li This patch adds async pf flag to KVM_GET/SET_VCPU_EVENTS interface. Signed-off-by: Wanpeng Li --- linux-headers/asm-x86/kvm.h | 2 ++ target/i386/cpu.h | 1 + target/i386/kvm.c | 6 +- 3 files changed, 8

Re: [Qemu-devel] [PATCH v3 11/13] migration: move only_migratable to MigrationState

On Mon, Jun 19, 2017 at 05:50:50PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > One less global variable, and it does only matter with migration. > > > > We keep the old "--only-migratable" option, but also now we support: > > > > -global migration.only-migratable=true >

Re: [Qemu-devel] [PATCH v3 06/13] kvm: let kvm use AccelState.global_props

On Tue, Jun 20, 2017 at 11:07:34AM -0300, Eduardo Habkost wrote: > On Tue, Jun 20, 2017 at 09:55:03PM +0800, Peter Xu wrote: > > On Mon, Jun 19, 2017 at 01:14:03PM -0300, Eduardo Habkost wrote: [...] > > > This is where things get tricky and fragile: the translation from > > > -cpu to global

[Qemu-devel] [PATCH 11/16] tcg: Change temp_allocate_frame arg to TCGTemp

Signed-off-by: Richard Henderson --- tcg/tcg.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index c228f1e..f8d96fa 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1869,10 +1869,8 @@ static void check_regs(TCGContext *s) } #endif

[Qemu-devel] [PATCH 08/16] tcg: Introduce temp_arg

Signed-off-by: Richard Henderson --- tcg/tcg.c | 4 ++-- tcg/tcg.h | 7 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 0bb88b1..0d758e4 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1718,7 +1718,7 @@ static bool

[Qemu-devel] [PATCH 14/16] tcg: Use per-temp state data in optimize

While we're touching many of the lines anyway, adjust the naming of the functions to better distinguish when "TCGArg" vs "TCGTemp" should be used. Signed-off-by: Richard Henderson --- tcg/optimize.c | 424 + tcg/tcg.h

[Qemu-devel] [PATCH 07/16] tcg: Return NULL temp for TCG_CALL_DUMMY_ARG

Signed-off-by: Richard Henderson --- tcg/tcg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 3b35344..6c357e7 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -730,7 +730,7 @@ extern bool parallel_cpus; static inline TCGTemp

[Qemu-devel] [PATCH 13/16] tcg: Export temp_idx

At the same time, drop the TCGContext argument and use tcg_ctx instead. Signed-off-by: Richard Henderson --- tcg/tcg.c | 15 --- tcg/tcg.h | 7 ++- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index f8d96fa..26931a7

[Qemu-devel] [PATCH 06/16] tcg: Add temp_global bit to TCGTemp

This avoids needing to test the index of a temp against nb_globals. Signed-off-by: Richard Henderson --- tcg/optimize.c | 15 --- tcg/tcg.c | 11 --- tcg/tcg.h | 12 3 files changed, 24 insertions(+), 14 deletions(-) diff --git

[Qemu-devel] [PATCH 10/16] tcg: Avoid loops against variable bounds

Copy s->nb_globals or s->nb_temps to a local variable for the purposes of iteration. This should allow the compiler to use low-overhead looping constructs on some hosts. Signed-off-by: Richard Henderson --- tcg/tcg.c | 27 ++- 1 file changed, 10

[Qemu-devel] [PATCH 05/16] tcg: Introduce arg_temp

Signed-off-by: Richard Henderson --- tcg/optimize.c | 4 ++-- tcg/tcg.c | 51 +-- tcg/tcg.h | 5 + 3 files changed, 32 insertions(+), 28 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index

[Qemu-devel] [PATCH 16/16] tcg: Store pointers to temporaries directly in TCGArg

Signed-off-by: Richard Henderson --- tcg/tcg.c | 8 tcg/tcg.h | 14 -- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 1ca1192..c25f455 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -810,11 +810,11 @@ void

[Qemu-devel] [PATCH 03/16] tcg: Propagate args to op->args in tcg.c

Signed-off-by: Richard Henderson --- tcg/tcg.c | 121 ++ 1 file changed, 58 insertions(+), 63 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 298aa0c..be5b69c 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1054,14

[Qemu-devel] [PATCH 02/16] tcg: Propagate args to op->args in optimizer

Signed-off-by: Richard Henderson --- tcg/optimize.c | 430 ++--- 1 file changed, 227 insertions(+), 203 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 002aad6..1a1c6fb 100644 --- a/tcg/optimize.c +++

[Qemu-devel] [PATCH 04/16] tcg: Propagate TCGOp down to allocators

Signed-off-by: Richard Henderson --- tcg/tcg.c | 82 +++ 1 file changed, 40 insertions(+), 42 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index be5b69c..e2248a6 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2111,25

[Qemu-devel] [PATCH 12/16] tcg: Remove unused TCG_CALL_DUMMY_TCGV

Signed-off-by: Richard Henderson --- tcg/tcg.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 1eeeca5..4f69d0c 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -503,7 +503,6 @@ static inline intptr_t QEMU_ARTIFICIAL GET_TCGV_PTR(TCGv_ptr t) #define

[Qemu-devel] [PATCH 15/16] tcg: Define separate structures for TCGv_*

Pointers that devolve to TCGTemp will tidy things up. At present, we continue to store indicies in TCGArg. Signed-off-by: Richard Henderson --- tcg/tcg.c | 67 +- tcg/tcg.h | 237 +- 2 files changed,

[Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end

There are two conceptually unrelated cleanups in here, though the second touches many of the same lines as the first, so separating the two would be ugly. The first is to split gen_opparam_buf and move the pieces into TCGOp. This has two effects: the operands for an op is in the same cacheline

[Qemu-devel] [PATCH 09/16] tcg: Use per-temp state data in liveness

This avoids having to allocate external memory for each temporary. Signed-off-by: Richard Henderson --- tcg/tcg.c | 232 ++ tcg/tcg.h | 6 ++ 2 files changed, 120 insertions(+), 118 deletions(-) diff --git

[Qemu-devel] [PATCH 01/16] tcg: Merge opcode arguments into TCGOp

Rather than have a separate buffer of 10*max_ops entries, give each opcode 10 entries. The result is actually a bit smaller and should have slightly more cache locality. Signed-off-by: Richard Henderson --- tcg/optimize.c | 6 ++-- tcg/tcg-op.c | 99

Re: [Qemu-devel] [PATCH qemu v8 2/2] memory/iommu: introduce IOMMUMemoryRegionClass

On 14/06/17 16:36, Alexey Kardashevskiy wrote: > This finishes QOM'fication of IOMMUMemoryRegion by introducing > a IOMMUMemoryRegionClass. This also provides a fastpath analog for > IOMMU_MEMORY_REGION_GET_CLASS(). Ping? > > Signed-off-by: Alexey Kardashevskiy > --- >

Re: [Qemu-devel] [PATCH v3 8/8] hw/misc/edu: Compile the edu device as common object

On 20.06.2017 20:14, Richard Henderson wrote: > On 06/19/2017 10:52 PM, Thomas Huth wrote: >> edu.c does not contain any target-specific code, so we can put >> it into common-obj-y to compile it only once for all targets. >> >> Signed-off-by: Thomas Huth > > Isn't CONFIG_EDU

Re: [Qemu-devel] pci_nic_init_nofail() only works on root PCI buses?

On Wed, Jun 21, 2017 at 03:00:31AM +0200, Thomas Huth wrote: > On 11.06.2017 17:08, Mark Cave-Ayland wrote: > > Hi all, > > > > Playing around with trying to set up PCI bridges for sun4u, I noticed > > that I get an assert with the following diff which simply moves the > > default NIC behind a

Re: [Qemu-devel] pci_nic_init_nofail() only works on root PCI buses?

On 11.06.2017 17:08, Mark Cave-Ayland wrote: > Hi all, > > Playing around with trying to set up PCI bridges for sun4u, I noticed > that I get an assert with the following diff which simply moves the > default NIC behind a PCI bridge rather than being directly on the root > PCI bus: > > diff

[Qemu-devel] [Bug 1699277] Re: qemu-system-s390x: asserts while booting Debian Stretch installer

Thanks for the bug report! If you've got a chance to use the latest development version of QEMU from the git repository instead, could you please try whether you could also reproduce the problem there? I think we've already got the fix for this problem in there:

Re: [Qemu-devel] [PATCH v5 6/6] target-m68k, linux-user: manage FP registers in ucontext

On 06/20/2017 01:51 PM, Laurent Vivier wrote: +__get_user(env->fpcr, >f_fpcntl[0]); cpu_m68k_set_fpcr r~

Re: [Qemu-devel] [PATCH v5 5/6] target-m68k: add FPCR and FPSR

On 06/20/2017 01:51 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 2 +- target/m68k/cpu.h| 43 +- target/m68k/fpu_helper.c | 117 +--- target/m68k/helper.c | 22 ++- target/m68k/helper.h | 5

Re: [Qemu-devel] [PATCH 2/3] xen-disk: add support for multi-page shared rings

On Tue, 20 Jun 2017, Paul Durrant wrote: > The blkif protocol has had provision for negotiation of multi-page shared > rings for some time now and many guest OS have support in their frontend > drivers. > > This patch makes the necessary modifications to xen-disk support a shared > ring up to

Re: [Qemu-devel] [PATCH v5 2/6] target-m68k: initialize FPU registers

On 06/20/2017 01:51 PM, Laurent Vivier wrote: on reset, set FP registers to NaN and control registers to 0 Signed-off-by: Laurent Vivier --- target/m68k/cpu.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) Nevermind the last... it's in 5/6. Reviewed-by:

Re: [Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

On 06/20/2017 01:51 PM, Laurent Vivier wrote: Coldfire uses float64, but 680x0 use floatx80. This patch introduces the use of floatx80 internally and enables 680x0 80bits FPU. Signed-off-by: Laurent Vivier --- Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v5 1/6] target-m68k: move fmove CR to a function

On 06/20/2017 01:51 PM, Laurent Vivier wrote: Move code of fmove to/from control register to a function Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 56 +++-- 1 file changed, 31 insertions(+), 25 deletions(-)

Re: [Qemu-devel] [PATCH v5 2/6] target-m68k: initialize FPU registers

On 06/20/2017 01:51 PM, Laurent Vivier wrote: +env->fpcr = 0; You probably want to use cpu_m68k_set_fpcr here too, so that fp_status matches. r~

Re: [Qemu-devel] Tracing guest virtual addresses

Lluis, My modifications were almost the same as those done by Emilio. There were no memory trace events in the trace file. -J On Tue, Jun 20, 2017 at 10:20 AM, Emilio G. Cota wrote: > On Tue, Jun 20, 2017 at 14:02:02 +0300, Lluís Vilanova wrote: > > Jayanto Minocha writes: > >

Re: [Qemu-devel] [PATCH 1/3] xen-disk: only advertize feature-persistent if grant copy is not available

On Tue, 20 Jun 2017, Paul Durrant wrote: > If grant copy is available then it will always be used in preference to > persistent maps. In this case feature-persistent should not be advertized > to the frontend, otherwise it may needlessly copy data into persistently > granted buffers. > >

Re: [Qemu-devel] [PATCH v3 1/2] tests: Add test-listen - a stress test for QEMU socket listen

On Tue, Jun 20, 2017 at 10:58:43PM +0200, Knut Omang wrote: > On Fri, 2017-06-16 at 15:41 +0100, Daniel P. Berrange wrote: > > On Wed, Jun 14, 2017 at 06:53:51PM +0200, Knut Omang wrote: > > > +static void listen_compete(void) > > > +{ > > > +listen_compete_nthr(true, 200, 5920, 300); > > > +}

Re: [Qemu-devel] [PATCH v1 8/8] target-microblaze: Introduce a use-pcmp-instr property

On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce a use-pcmp-instr property making pcmp instructions > optional. > > Signed-off-by: Edgar E. Iglesias Reviewed-by:

Re: [Qemu-devel] [PATCH] xen/disk: don't leak stack data via response ring

On Tue, 20 Jun 2017, Jan Beulich wrote: > Rather than constructing a local structure instance on the stack, fill > the fields directly on the shared ring, just like other (Linux) > backends do. Build on the fact that all response structure flavors are > actually identical (the old code did make

Re: [Qemu-devel] [PATCH v1 7/8] target-microblaze: Introduce a use-msr-instr property

On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce a use-msr-instr property making msr instructions > optional. > > Signed-off-by: Edgar E. Iglesias Reviewed-by:

Re: [Qemu-devel] [PATCH v1 6/8] target-microblaze: Introduce a use-hw-mul property

On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce a use-div property making multiplication instructions > optional. > > Signed-off-by: Edgar E. Iglesias

Re: [Qemu-devel] [PATCH v1 5/8] target-microblaze: Introduce a use-div property

On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce a use-div property making division instructions > optional. > > Signed-off-by: Edgar E. Iglesias Reviewed-by:

Re: [Qemu-devel] [PATCH v1 4/8] target-microblaze: Introduce a use-barrel property

On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce a use-barrel property making barrel shifter instructions > optional. > > Signed-off-by: Edgar E. Iglesias

Re: [Qemu-devel] [PATCH v1 3/8] target-microblaze: Add CPU versions 9.4, 9.5 and 9.6

On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add CPU versions 9.4, 9.5 and 9.6. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis

Re: [Qemu-devel] [PATCH v1 2/8] target-microblaze: Don't hard code 0xb as initial MB version

On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Don't hard code 0xb as initial MB version. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis

Re: [Qemu-devel] [PATCH v1 1/8] target-microblaze: Correct bit shift for the PVR0 version field

On Tue, Jun 20, 2017 at 2:09 PM, Alistair Francis wrote: > On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias > wrote: >> From: "Edgar E. Iglesias" >> >> Correct bit shift for the PVR0 version field. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH v1 1/8] target-microblaze: Correct bit shift for the PVR0 version field

On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Correct bit shift for the PVR0 version field. > > Signed-off-by: Edgar E. Iglesias > --- > target/microblaze/cpu.c | 2 +- >

Re: [Qemu-devel] [PATCH v3 2/2] sockets: Handle race condition between binds to the same port

On Fri, 2017-06-16 at 15:45 +0100, Daniel P. Berrange wrote: > On Wed, Jun 14, 2017 at 06:53:52PM +0200, Knut Omang wrote: > > If an offset of ports is specified to the inet_listen_saddr function(), > > and two or more processes tries to bind from these ports at the same time, > > occasionally

Re: [Qemu-devel] [PATCH v3 1/2] tests: Add test-listen - a stress test for QEMU socket listen

On Fri, 2017-06-16 at 15:41 +0100, Daniel P. Berrange wrote: > On Wed, Jun 14, 2017 at 06:53:51PM +0200, Knut Omang wrote: > > There's a potential race condition between multiple bind()'s > > attempting to bind to the same port, which occasionally > > allows more than one bind to succeed against

[Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

Coldfire uses float64, but 680x0 use floatx80. This patch introduces the use of floatx80 internally and enables 680x0 80bits FPU. Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 4 +- target/m68k/cpu.h| 15 +- target/m68k/fpu_helper.c | 85 ---

[Qemu-devel] [PATCH v5 6/6] target-m68k, linux-user: manage FP registers in ucontext

Signed-off-by: Laurent Vivier --- linux-user/signal.c | 41 + 1 file changed, 41 insertions(+) diff --git a/linux-user/signal.c b/linux-user/signal.c index 3d18d1b..d3753e4 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@

[Qemu-devel] [PATCH v5 5/6] target-m68k: add FPCR and FPSR

Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 2 +- target/m68k/cpu.h| 43 +- target/m68k/fpu_helper.c | 117 +--- target/m68k/helper.c | 22 ++- target/m68k/helper.h | 5 +- target/m68k/translate.c | 351

[Qemu-devel] [PATCH v5 4/6] target-m68k: define 96bit FP registers for gdb on 680x0

Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- configure| 2 +- gdb-xml/m68k-fp.xml | 21 + target/m68k/helper.c | 45 + 3 files changed, 67 insertions(+), 1

[Qemu-devel] [PATCH v5 1/6] target-m68k: move fmove CR to a function

Move code of fmove to/from control register to a function Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 56 +++-- 1 file changed, 31 insertions(+), 25 deletions(-) diff --git a/target/m68k/translate.c

[Qemu-devel] [PATCH v5 2/6] target-m68k: initialize FPU registers

on reset, set FP registers to NaN and control registers to 0 Signed-off-by: Laurent Vivier --- target/m68k/cpu.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index f068922..f2e031f 100644 ---

[Qemu-devel] [PATCH v5 0/6] target-m68k: implement 680x0 FPU

This series modifies the original ColdFire FPU implementation to use floatx80 instead of float64 internally as this is the native datatype for 680x0. I didn't keep the float64 type for ColdFire, but if someone thinks it's required I can update this series in this way. The series also adds the FPU

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On Tue, 2017-06-20 at 21:26 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 20, 2017 at 01:29:00PM -0400, Rik van Riel wrote: > > I agree with that.  Let me go into some more detail of > > what Nitesh is implementing: > > > > 1) In arch_free_page, the being-freed page is added > >    to a per-cpu

Re: [Qemu-devel] [PATCH] MAINTAINERS: seccomp: change email contact for Eduardo Otubo

On 06/12/2017 06:03 PM, Thomas Huth wrote: On 12.06.2017 14:18, Eduardo Otubo wrote: Signed-off-by: Eduardo Otubo --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 120788d..0d065a0 100644 --- a/MAINTAINERS

Re: [Qemu-devel] [PATCH 3/5] spapr: Add DRC release method

Quoting Greg Kurz (2017-06-20 11:51:45) > On Tue, 20 Jun 2017 09:53:30 +0800 > David Gibson wrote: > > > At the moment, spapr_drc_release() has an ugly switch on the DRC type to > > call the right, device-specific release function. This cleans it up by > > doing

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/5] spapr: Use unplug_request for PCI hot unplug

On 20/06/2017 03:53, David Gibson wrote: > AIUI, ->unplug_request in the HotplugHandler is used for "soft" > unplug, where acknowledgement from the guest is required before > completing the unplug, whereas ->unplug is used for "hard" unplug > where qemu unilaterally removes the device, and the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] spapr: Remove unnecessary differences between hotplug and coldplug paths

On 20/06/2017 03:53, David Gibson wrote: > spapr_drc_attach() has a 'coldplug' parameter which sets the DRC into > configured state initially, instead of the usual ISOLATED/UNUSABLE state. > It turns out this is unnecessary: although coldplugged devices do need to > be in CONFIGURED state once the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] spapr: Add DRC release method

On 20/06/2017 03:53, David Gibson wrote: > At the moment, spapr_drc_release() has an ugly switch on the DRC type to > call the right, device-specific release function. This cleans it up by > doing that via a proper QOM method. > > It's still arguably an abstraction violation for the DRC code to

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/5] spapr: Uniform DRC reset paths

On 20/06/2017 03:53, David Gibson wrote: > DRC objects have a regular device reset method. However, it only gets > called in the usual way for PCI DRCs. Because of where CPU and LMB DRCs > are in the QOM tree, their device reset method isn't automatically called. > So, the machine manually

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

>> IMHO even simply writing all-zeros to all free pages before starting >> migration (or even when freeing a page) would be a cleaner interface >> than this (because it atomically works with the entity the host cares >> about for migration). But yes, performance is horrible that's why I am >> not

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On Tue, Jun 20, 2017 at 08:54:29PM +0200, David Hildenbrand wrote: > On 20.06.2017 20:17, Michael S. Tsirkin wrote: > > On Tue, Jun 20, 2017 at 06:49:33PM +0200, David Hildenbrand wrote: > >> On 20.06.2017 18:44, Rik van Riel wrote: > >>> On Mon, 2017-06-12 at 07:10 -0700, Dave Hansen wrote: > >>>

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On 20.06.2017 20:17, Michael S. Tsirkin wrote: > On Tue, Jun 20, 2017 at 06:49:33PM +0200, David Hildenbrand wrote: >> On 20.06.2017 18:44, Rik van Riel wrote: >>> On Mon, 2017-06-12 at 07:10 -0700, Dave Hansen wrote: >>> The hypervisor is going to throw away the contents of these pages,

Re: [Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build

On 20 June 2017 at 17:30, Philippe Mathieu-Daudé wrote: > fix regression from commit 244f144134: > > $ make subdir-arm-softmmu > make[1]: *** No rule to make target 'tci.o', needed by 'qemu-system-arm'. > Stop. > Makefile:328: recipe for target 'subdir-arm-softmmu'

[Qemu-devel] [PATCH v14] migration: spapr: migrate pending_events of spapr state

In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration is started. In this case the pending_events of spapr state need be transmitted to the target so that the hotplug event can be finished on the

[Qemu-devel] [PATCH v14] migration: spapr: migrate pending_events of spapr state

v14: - several changes made in spapr_events.c to allow for a minimal VMSD to be migrated. Please check the commit message of the patch for more information. This is the next version of the v13 that was sent a month ago. You can check out the v13 discussions here:

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On Tue, Jun 20, 2017 at 01:29:00PM -0400, Rik van Riel wrote: > On Tue, 2017-06-20 at 18:49 +0200, David Hildenbrand wrote: > > On 20.06.2017 18:44, Rik van Riel wrote: > > > > Nitesh Lal (on the CC list) is working on a way > > > to efficiently batch recently freed pages for > > > free page

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On Tue, Jun 20, 2017 at 06:49:33PM +0200, David Hildenbrand wrote: > On 20.06.2017 18:44, Rik van Riel wrote: > > On Mon, 2017-06-12 at 07:10 -0700, Dave Hansen wrote: > > > >> The hypervisor is going to throw away the contents of these pages, > >> right? As soon as the spinlock is released,

Re: [Qemu-devel] [PATCH v3 8/8] hw/misc/edu: Compile the edu device as common object

On 06/19/2017 10:52 PM, Thomas Huth wrote: edu.c does not contain any target-specific code, so we can put it into common-obj-y to compile it only once for all targets. Signed-off-by: Thomas Huth Isn't CONFIG_EDU defined by the target, via pci.conf? Would it ever be set

Re: [Qemu-devel] [PATCH v3 6/8] include/exec/poison: Mark CONFIG_SOFTMMU as poisoned

On 06/19/2017 10:52 PM, Thomas Huth wrote: CONFIG_SOFTMMU should never be used in common code, so mark it as poisoned, too. Signed-off-by: Thomas Huth --- include/exec/poison.h | 1 + include/qom/cpu.h | 8 2 files changed, 9 insertions(+) Reviewed-by:

Re: [Qemu-devel] [PATCH v3 5/8] cpu: Introduce a wrapper for tlb_flush() that can be used in common code

On 06/19/2017 10:52 PM, Thomas Huth wrote: Commit 1f5c00cfdb8114c ("qom/cpu: move tlb_flush to cpu_common_reset") moved the call to tlb_flush() from the target-specific reset handlers into the common code qom/cpu.c file, and protected the call with "#ifdef CONFIG_SOFTMMU" to avoid that it is

Re: [Qemu-devel] [PATCH v3 2/8] include/exec/poison: Mark some CONFIG defines as poisoned, too

On 06/19/2017 10:52 PM, Thomas Huth wrote: These are defined in config-target.h and thus should never be used in common code. Signed-off-by: Thomas Huth --- include/exec/poison.h | 21 + 1 file changed, 21 insertions(+) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v3 1/8] include/exec/poison: Add missing TARGET defines

On 06/19/2017 10:52 PM, Thomas Huth wrote: Since we've got some new CPU targets in QEMU during the last months and years, we've got some new TARGET_xxx defines now which should be marked as poisoned for common code. Signed-off-by: Thomas Huth --- include/exec/poison.h | 16

Re: [Qemu-devel] [PATCH v1 7/7] target-microblaze: Add CPU version 10.0

On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add CPU version 10.0. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v1 6/7] target-microblaze: dec_barrel: Add BSIFI

On Tue, Jun 20, 2017 at 10:48:22AM -0700, Richard Henderson wrote: > On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: > >+int width = imm_w - imm_s + 1; > >+ > >+if (width == 0 || imm_w <= imm_s) { > > The width == 0 check is redundant; the imm_w <= imm_s check is wrong. It >

Re: [Qemu-devel] [PATCH v1 6/7] target-microblaze: dec_barrel: Add BSIFI

On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: +int width = imm_w - imm_s + 1; + +if (width == 0 || imm_w <= imm_s) { The width == 0 check is redundant; the imm_w <= imm_s check is wrong. It should be <. If imm_w >= imm_s, as per the proper check, then width must be >= 1.

Re: [Qemu-devel] [PATCH v1 4/7] target-microblaze: dec_barrel: Plug TCG temp leak

On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Plug TCG temp leak. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v1 3/7] target-microblaze: dec_barrel: Add braces around if-statements

On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add braces around if-statements. No functional change. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 9 + 1 file changed, 5

Re: [Qemu-devel] [PATCH v1 2/7] target-microblaze: dec_barrel: Use extract32

On 06/20/2017 09:08 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Use extract32 instead of opencoding the shifting and masking. No functional change. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 4 ++-- 1

Re: [Qemu-devel] [PATCH v1 1/7] target-microblaze: dec_barrel: Use bool instead of unsigned int

On 06/20/2017 09:08 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Use bool instead of unsigned int to represent flags. No functional change. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file

Re: [Qemu-devel] [PATCH v1 5/7] target-microblaze: dec_barrel: Add BSEFI

On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: +if (e) { +tcg_gen_extract_i32(cpu_R[dc->rd], cpu_R[dc->ra], imm_s, imm_w); You'll want to validate imm_s and imm_w lest you trigger the asserts in tcg_gen_extract_i32. r~

Re: [Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build

On 06/20/2017 02:17 PM, no-re...@patchew.org wrote: === OUTPUT BEGIN === [...] CC aarch64-softmmu/target/arm/cpu64.o cc: Internal error: Killed (program cc1) This is odd... Please submit a full bug report. See for instructions. make[1]: ***

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On Tue, 2017-06-20 at 18:49 +0200, David Hildenbrand wrote: > On 20.06.2017 18:44, Rik van Riel wrote: > > Nitesh Lal (on the CC list) is working on a way > > to efficiently batch recently freed pages for > > free page hinting to the hypervisor. > > > > If that is done efficiently enough (eg.

Re: [Qemu-devel] [PATCH v1 1/3] target/s390x: Indicate and check for local tlb clearing

On 06/20/2017 05:35 AM, David Hildenbrand wrote: +if (s390_has_feat(S390_FEAT_LOCAL_TLB_CLEARING) && (m4 & 1)) { Surely better to let m4 == 0 without local-tlb-clearing during translate. r~

Re: [Qemu-devel] [PATCH v3 15/18] target/s390x: Implement SRSTU

On 06/20/2017 01:27 AM, David Hildenbrand wrote: 2. We must not overwrite bit 0-31 in 24/31 bit mode: (PoP page 3-6) Unless specifically stated to the contrary, the follow- ing definition applies in this publication: whenever the machine generates and provides to the program a 24-bit or 31-bit

Re: [Qemu-devel] Tracing guest virtual addresses

On Tue, Jun 20, 2017 at 14:02:02 +0300, Lluís Vilanova wrote: > Jayanto Minocha writes: > > > Hi, > > I think there have been a few threads on the mailing list regarding tracing > > guest virtual addresses for load and store instructions, but I have been > > unable to get it to work. I am trying

Re: [Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build Message-id: 20170620163009.21764-1-f4...@amsat.org Type:

[Qemu-devel] [Bug 1699277] [NEW] qemu-system-s390x: asserts while booting Debian Stretch installer

Public bug reported: QEMU 2.9.0 (Arch Linux) asserts when I try to install Debian Stretch. Steps to reproduce: wget http://ftp.debian.org/debian/dists/stretch/main/installer-s390x/current/images/generic/initrd.debian wget

Re: [Qemu-devel] [PATCH 03/11] travis: use yes/no variable to enable/disable tests

On 06/17/2017 05:06 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: having the command to run in the variable make scripts harder to manage. I'm not sure this adds much over the TEST_CMD not set == don't run we had before. I don't like it neither but had trouble

Re: [Qemu-devel] [PATCH 3/5] spapr: Add DRC release method

On Tue, 20 Jun 2017 09:53:30 +0800 David Gibson wrote: > At the moment, spapr_drc_release() has an ugly switch on the DRC type to > call the right, device-specific release function. This cleans it up by > doing that via a proper QOM method. > > It's still arguably

  1   2   3   >