Re: [Qemu-devel] [PATCH 0/2] Support multiple adlib sound cards

Ping ? Le 21/06/2017 à 06:33, Hervé Poussineau a écrit : Hi, This patchset removes a global variable in adlib emulation, and allows to have multiple adlib sound cards. Note that indentation seem off because I have replaced some tabulations by spaces. Before: qemu-system-i386 -device

[Qemu-devel] [PATCH V2 3/4] net/colo-compare.c: Optimize unpredictable tcp options comparison

When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same, but the two packet's payload is identical. colo just care about packet payload, so we skip the option field. Signed-off-by: Zhang Chen

[Qemu-devel] [PATCH V2 4/4] net/colo-compare.c: Adjust net queue pop order for performance

The packet_enqueue() use g_queue_push_tail() to enqueue net packet, so it is more efficent way use g_queue_pop_head() to get packet for compare. That will improve the success rate of comparison. In my test the performance of ftp put 1000M file will increase 10% Signed-off-by: Zhang Chen

[Qemu-devel] [PATCH V2 1/4] net/colo-compare.c: Add checkpoint min period to optimize performance

If colo-compare find out the first different packet that means the following packet almost is different. we needn't do a lot of checkpoint in this time, so we set the no-need-checkpoint peroid, default just set 3 second. Signed-off-by: Zhang Chen ---

[Qemu-devel] [PATCH V2 2/4] net/colo-compare.c: Compare the tcp packets that has the same sequence number

If primary packet's sequence number not same with secondary packet's sequence number, no need to compare the packet other field. Signed-off-by: Zhang Chen --- net/colo-compare.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/colo-compare.c

[Qemu-devel] [PATCH V2 0/4] Optimize COLO-compare performance

In this serise, we do a lot of job to optimize COLO net performance. Mainly focus on TCP protocol. V2: - Rename p2's subject. Zhang Chen (4): net/colo-compare.c: Add checkpoint min period to optimize performance net/colo-compare.c: Compare the tcp packets that has the same sequence

Re: [Qemu-devel] [PATCH 01/11] s390x/kvm: Rework cmma management

On 12.07.2017 15:49, Cornelia Huck wrote: > On Wed, 12 Jul 2017 14:57:35 +0200 > Christian Borntraeger wrote: > >> From: Janosch Frank >> >> Let's keep track of cmma enablement and move the mem_path check into >> the actual enablement. This

Re: [Qemu-devel] [PATCH RFC] spapr: ignore interrupts during reset state

David Gibson writes: > On Fri, Jun 09, 2017 at 10:32:25AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Thu, Jun 08, 2017 at 12:06:08PM +0530, Nikunj A Dadhania wrote: >> >> Rebooting a SMP TCG guest is broken for

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

Hi Wei, [auto build test ERROR on linus/master] [also build test ERROR on v4.12 next-20170712] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Wei-Wang/Virtio-balloon-Enhancement/20170713-074956

Re: [Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

On Thu, Jul 13, 2017 at 08:54:58AM +0530, Bharata B Rao wrote: > On Wed, Jul 12, 2017 at 01:11:30PM +0200, Greg Kurz wrote: > > On Wed, 12 Jul 2017 15:52:37 +0530 > > Bharata B Rao wrote: > > > > > On Wed, Jul 12, 2017 at 11:48:39AM +0200, Greg Kurz wrote: > > > >

Re: [Qemu-devel] [PATCH v4 12/18] crypto: introduce some common functions for af_alg backend

2017-07-11 20:28 GMT+08:00 Daniel P. Berrange : > On Tue, Jul 04, 2017 at 04:57:04PM +0800, Longpeng(Mike) wrote: >> The AF_ALG socket family is the userspace interface for linux >> crypto API, this patch adds af_alg family support and some common >> functions for af_alg

Re: [Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

On Wed, Jul 12, 2017 at 01:11:30PM +0200, Greg Kurz wrote: > On Wed, 12 Jul 2017 15:52:37 +0530 > Bharata B Rao wrote: > > > On Wed, Jul 12, 2017 at 11:48:39AM +0200, Greg Kurz wrote: > > > Since commit 5c1da81215c7 ("spapr: Remove unnecessary differences between > >

[Qemu-devel] [PATCH for qemu-2.9] spapr: fix migration to pseries machine < 2.8

From: Laurent Vivier since commit 5c4537bd ("spapr: Fix 2.7<->2.8 migration of PCI host bridge"), some migration fields are forged from the new ones in spapr_pci_pre_save(). It works well, except when the number of MSI devices is 0, because in this case the function exits

[Qemu-devel] 答复: Re: [PATCH] target-i386:kvm_get/put_vcpu_events don't handlesipi_vector

发件人： 收件人：彭浩10096742 抄送人： 日 期 ：2017年07月13日 01:01 主 题 ：Re: [PATCH] target-i386:kvm_get/put_vcpu_events don't handlesipi_vector On

[Qemu-devel] [Bug 1696353] Re: golang binaries fail to start under linux-user

The go team have applied the above patch and I can confirm that it is now working properly using go-tip. This means it will be fixed in go 1.10. So if you recompile your go binary with go-tip or go 1.10 when it is released, it will run fine under qemu-system-arm. -- You received this bug

Re: [Qemu-devel] [Qemu devel v6 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block.

Hi Phiiippe, Gentle reminder. Thanks, Sundeep On Mon, Jul 10, 2017 at 1:55 PM, sundeep subbaraya wrote: > Hi Alistair, > > On Fri, Jul 7, 2017 at 10:03 PM, Alistair Francis > wrote: > >> On Fri, Jul 7, 2017 at 12:08 AM, sundeep subbaraya >>

Re: [Qemu-devel] [PATCH] virtio-gpu: skip update cursor in post_load if we don't have one

On 2017/7/10 15:04, Gerd Hoffmann wrote: > If the cursor resource id isn't set the guest didn't define a cursor. > Skip the cursor update in post_load in that that case. > > Reported-by: wanghaibin > Signed-off-by: Gerd Hoffmann It's work!!

Re: [Qemu-devel] [PATCH] target/ppc: Only set PCR in kvm if actually in a compat mode

On Wed, Jul 12, 2017 at 04:45:17PM +1000, Suraj Jitindar Singh wrote: > On Mon, 2017-07-03 at 19:20 +1000, David Gibson wrote: > > On Mon, Jul 03, 2017 at 01:18:38PM +1000, Suraj Jitindar Singh wrote: > > > On Fri, 2017-06-30 at 14:03 +1000, David Gibson wrote: > > > > On Thu, Jun 29, 2017 at

Re: [Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

On Wed, Jul 12, 2017 at 11:48:39AM +0200, Greg Kurz wrote: > Since commit 5c1da81215c7 ("spapr: Remove unnecessary differences between > hotplug and coldplug paths"), the CPU DT for the DRC is always allocated. > This causes a memory leak for pseries-2.6 and older machine types, that > don't

Re: [Qemu-devel] [PATCH v4 1/4] block: pass bdrv_* methods to bs->file by default in block filters

On 07/11/2017 11:37 AM, Manos Pitsidianakis wrote: > The following functions fail if bs->drv is a filter and does not > implement them: > > bdrv_probe_blocksizes > bdrv_probe_geometry > bdrv_truncate > bdrv_has_zero_init > bdrv_get_info > > Instead, the call should be passed to bs->file if it

Re: [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed

On 07/11/2017 11:37 AM, Manos Pitsidianakis wrote: > This function is not used anywhere, so remove it. > > Signed-off-by: Manos Pitsidianakis > --- > block.c | 14 -- > block/raw-format.c| 6 -- > include/block/block.h | 1 -

Re: [Qemu-devel] [PATCHv2 0/8] spapr: DRC cleanups (part VI)

On Wed, Jul 12, 2017 at 03:53:09PM +1000, David Gibson wrote: > This sixth set of DRC cleanup patches is a complete rework of DRC > state management. We stop tracking some unnecessary things, and > change the basic state representation to a simpler and more robust > model. > > Many of the

[Qemu-devel] [PATCH v5 13/18] mirror: Switch mirror_dirty_init() to byte-based iteration

Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake --- v5: rebase to earlier changes v2-v4: no change ---

[Qemu-devel] [PATCH v5 17/18] dirty-bitmap: Switch bdrv_set_dirty() to bytes

Both callers already had bytes available, but were scaling to sectors. Move the scaling to internal code. In the case of bdrv_aligned_pwritev(), we are now passing the exact offset rather than a rounded sector-aligned value, but that's okay as long as dirty bitmap widens start/bytes to

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

Hi Wei, [auto build test WARNING on linus/master] [also build test WARNING on v4.12 next-20170712] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Wei-Wang/Virtio-balloon-Enhancement/20170713

[Qemu-devel] [PATCH v5 11/18] dirty-bitmap: Change bdrv_get_dirty_locked() to take bytes

Half the callers were already scaling bytes to sectors; the other half can eventually be simplified to use byte iteration. Both callers were already using the result as a bool, so make that explicit. Making the change also makes it easier for a future dirty-bitmap patch to offload scaling over

[Qemu-devel] [PATCH v5 15/18] qcow2: Switch load_bitmap_data() to byte-based iteration

Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake Reviewed-by: John Snow --- v5: no change v4:

[Qemu-devel] [PATCH v5 18/18] dirty-bitmap: Convert internal hbitmap size/granularity

Now that all callers are using byte-based interfaces, there's no reason for our internal hbitmap to remain with sector-based granularity. It also simplifies our internal scaling, since we already know that hbitmap widens requests out to granularity boundaries. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v5 14/18] qcow2: Switch qcow2_measure() to byte-based iteration

This is new code, but it is easier to read if it makes passes over the image using bytes rather than sectors (and will get easier in the future when bdrv_get_block_status is converted to byte-based). While at it, fix a bug in the computation of nb_sectors using MAX rather than MIN and thus always

[Qemu-devel] [PATCH v5 08/18] dirty-bitmap: Set iterator start by offset, not sector

All callers to bdrv_dirty_iter_new() passed 0 for their initial starting point, drop that parameter. Most callers to bdrv_set_dirty_iter() were scaling a byte offset to a sector number; the exception qcow2-bitmap will be converted later to use byte rather than sector iteration. Move the scaling

[Qemu-devel] [PATCH v5 16/18] qcow2: Switch store_bitmap_data() to byte-based iteration

Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake Reviewed-by: John Snow --- v5: no change v4:

[Qemu-devel] [PATCH v5 12/18] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes

Some of the callers were already scaling bytes to sectors; others can be easily converted to pass byte offsets, all in our shift towards a consistent byte interface everywhere. Making the change will also make it easier to write the hold-out callers to use byte rather than sectors for their

[Qemu-devel] [PATCH v5 09/18] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset

Thanks to recent cleanups, most callers were scaling a return value of sectors into bytes (the exception, in qcow2-bitmap, will be converted to byte-based iteration later - in particular, there will be a few commits where we are temporarily relying on not-strict-C right-shift of -1 still resulting

[Qemu-devel] [PATCH v5 06/18] dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytes

Right now, the dirty-bitmap code exposes the fact that we use a scale of sector granularity in the underlying hbitmap to anything that wants to serialize a dirty bitmap. It's nicer to uniformly expose bytes as our dirty-bitmap interface, matching the previous change to bitmap size. The only

[Qemu-devel] [PATCH v5 05/18] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes

We are still using an internal hbitmap that tracks a size in sectors, with the granularity scaled down accordingly, because it lets us use a shortcut for our iterators which are currently sector-based. But there's no reason we can't track the dirty bitmap size in bytes, since it is (mostly) an

[Qemu-devel] [PATCH v5 10/18] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes

Thanks to recent cleanups, all callers were scaling a return value of sectors into bytes; do the scaling internally instead. Signed-off-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Juan Quintela --- v4: no change v3: no change,

[Qemu-devel] [PATCH v5 00/18] make dirty-bitmap byte-based

There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte granularity (even if the reporting will probably be naturally aligned to sectors or even much higher levels). I've therefore started the task of converting our block status code to report at a

[Qemu-devel] [PATCH v5 04/18] dirty-bitmap: Drop unused functions

We had several functions that no one is currently using, and which use sector-based interfaces. I'm trying to convert towards byte-based interfaces, so it's easier to just drop the unused functions: bdrv_dirty_bitmap_get_meta bdrv_dirty_bitmap_get_meta_locked bdrv_dirty_bitmap_reset_meta

[Qemu-devel] [PATCH v5 07/18] qcow2: Switch sectors_covered_by_bitmap_cluster() to byte-based

We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Change the qcow2 bitmap helper function sectors_covered_by_bitmap_cluster(), renaming it to bytes_covered_by_bitmap_cluster() in the process. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v5 01/18] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented

We've been documenting the value in bytes since its introduction in commit b9a9b3a4 (v1.3), where it was actually reported in bytes. Commit e4654d2 (v2.0) then removed things from block/qapi.c, in preparation for a rewrite to a list of dirty sectors in the next commit 21b5683 in block.c, but the

[Qemu-devel] [PATCH v5 03/18] qcow2: Ensure bitmap serialization is aligned

When subdividing a bitmap serialization, the code in hbitmap.c enforces that start/count parameters are aligned (except that count can end early at end-of-bitmap). We exposed this required alignment through bdrv_dirty_bitmap_serialization_align(), but forgot to actually check that we comply with

[Qemu-devel] [PATCH v5 02/18] hbitmap: Rename serialization_granularity to serialization_align

The only client of hbitmap_serialization_granularity() is dirty-bitmap's bdrv_dirty_bitmap_serialization_align(). Keeping the two names consistent is worthwhile, and the shorter name is more representative of what the function returns (the required alignment to be used for start/count of other

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On 07/13/17 02:47, Michael S. Tsirkin wrote: > On Thu, Jul 13, 2017 at 02:30:06AM +0200, Laszlo Ersek wrote: >> On 07/12/17 10:22, Thomas Huth wrote: >>> We don't want to carry along old machine types forever. If we are able to >>> remove the pc machines up to 0.13 one day for example, this would

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On Wed, Jul 12, 2017 at 10:22:33AM +0200, Thomas Huth wrote: > We don't want to carry along old machine types forever. If we are able to > remove the pc machines up to 0.13 one day for example, this would allow > us to eventually kill the code for rombar=0 (i.e. where QEMU copies ROM > BARs

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 0/8] spapr: DRC cleanups (part VI)

On Wed, Jul 12, 2017 at 10:48:38AM -0300, Daniel Henrique Barboza wrote: > The dreaded Libvirt hotplug-migrate-hotunplug scenario is working nicely. Good to hear. > device_add when the machine is in RUN_STATE_PRELAUNCH (-S) still doesn't > work but it is expected - as discussed in "[RFC drcVI

Re: [Qemu-devel] [PATCHv2 4/8] spapr: Refactor spapr_drc_detach()

On Wed, Jul 12, 2017 at 01:47:15PM +0200, Greg Kurz wrote: > On Wed, 12 Jul 2017 15:53:13 +1000 > David Gibson wrote: > > > This function has two unused parameters - remove them. > > > > It also sets awaiting_release on all paths, except one. On that path > >

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On Thu, Jul 13, 2017 at 02:23:39AM +0200, Laszlo Ersek wrote: > On 07/13/17 00:27, Michael S. Tsirkin wrote: > > On Wed, Jul 12, 2017 at 05:56:46PM -0300, Eduardo Habkost wrote: > >> On Wed, Jul 12, 2017 at 11:31:59PM +0300, Michael S. Tsirkin wrote: > >>> On Wed, Jul 12, 2017 at 05:15:50PM -0300,

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On Thu, Jul 13, 2017 at 02:30:06AM +0200, Laszlo Ersek wrote: > On 07/12/17 10:22, Thomas Huth wrote: > > We don't want to carry along old machine types forever. If we are able to > > remove the pc machines up to 0.13 one day for example, this would allow > > us to eventually kill the code for

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On Thu, Jul 13, 2017 at 02:23:39AM +0200, Laszlo Ersek wrote: > On 07/13/17 00:27, Michael S. Tsirkin wrote: > > On Wed, Jul 12, 2017 at 05:56:46PM -0300, Eduardo Habkost wrote: > >> On Wed, Jul 12, 2017 at 11:31:59PM +0300, Michael S. Tsirkin wrote: > >>> On Wed, Jul 12, 2017 at 05:15:50PM -0300,

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

On Wed, Jul 12, 2017 at 08:40:18PM +0800, Wei Wang wrote: > Add a new feature, VIRTIO_BALLOON_F_SG, which enables to > transfer a chunk of ballooned (i.e. inflated/deflated) pages using > scatter-gather lists to the host. > > The implementation of the previous virtio-balloon is not very >

Re: [Qemu-devel] [PATCHv2 3/8] spapr: Simplify unplug path

On Wed, Jul 12, 2017 at 12:31:48PM +0200, Greg Kurz wrote: > On Wed, 12 Jul 2017 12:04:51 +0200 > Greg Kurz wrote: > > > On Wed, 12 Jul 2017 15:53:12 +1000 > > David Gibson wrote: > > > > > spapr_lmb_release() and spapr_core_release() call

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

On Wed, Jul 12, 2017 at 08:40:19PM +0800, Wei Wang wrote: > This patch adds support for reporting blocks of pages on the free list > specified by the caller. > > As pages can leave the free list during this call or immediately > afterwards, they are not guaranteed to be free after the function >

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On 07/12/17 10:22, Thomas Huth wrote: > We don't want to carry along old machine types forever. If we are able to > remove the pc machines up to 0.13 one day for example, this would allow > us to eventually kill the code for rombar=0 (i.e. where QEMU copies ROM > BARs directly to low memory).

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On 07/13/17 00:27, Michael S. Tsirkin wrote: > On Wed, Jul 12, 2017 at 05:56:46PM -0300, Eduardo Habkost wrote: >> On Wed, Jul 12, 2017 at 11:31:59PM +0300, Michael S. Tsirkin wrote: >>> On Wed, Jul 12, 2017 at 05:15:50PM -0300, Eduardo Habkost wrote: On Wed, Jul 12, 2017 at 06:17:55PM +0300,

Re: [Qemu-devel] [PATCH v12 8/8] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ

On Wed, Jul 12, 2017 at 08:40:21PM +0800, Wei Wang wrote: > Add a new vq, cmdq, to handle requests between the device and driver. > > This patch implements two commands sent from the device and handled in > the driver. > 1) VIRTIO_BALLOON_CMDQ_REPORT_STATS: this command is used to report > the

Re: [Qemu-devel] [PATCH v12 7/8] mm: export symbol of next_zone and first_online_pgdat

On Wed, Jul 12, 2017 at 08:40:20PM +0800, Wei Wang wrote: > This patch enables for_each_zone()/for_each_populated_zone() to be > invoked by a kernel module. ... for use by virtio balloon. > Signed-off-by: Wei Wang balloon seems to only use +

Re: [Qemu-devel] [PATCH] tcg/aarch64: Use ADR for shorter jumps

On Wed, Jul 12, 2017 at 7:08 PM, Richard Henderson wrote: > On 07/12/2017 12:14 PM, Pranith Kumar wrote: >> >> Use ADR instruction for shorter jumps. >> >> I was going through rth's email and realized that I should have done >> this the first time. >> >> Signed-off-by: Pranith

Re: [Qemu-devel] [PATCH v12 0/8] Virtio-balloon Enhancement

On Wed, Jul 12, 2017 at 08:40:13PM +0800, Wei Wang wrote: > This patch series enhances the existing virtio-balloon with the following new > features: > 1) fast ballooning: transfer ballooned pages between the guest and host in > chunks using sgs, instead of one by one; and > 2) cmdq: a new

Re: [Qemu-devel] [PATCH] tcg/aarch64: Use ADR for shorter jumps

On 07/12/2017 12:14 PM, Pranith Kumar wrote: Use ADR instruction for shorter jumps. I was going through rth's email and realized that I should have done this the first time. Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 14 +- 1 file

Re: [Qemu-devel] [PATCH 09/22] exec-all: shrink tb->invalid to uint8_t

On 07/12/2017 10:48 AM, Emilio G. Cota wrote: Would it be OK for this series to just start with CF_PARALLEL? I'm not too familiar with how icount mode recompiles code, and I'm now on patch 27 of v2 and still have quite a few patches to go through. Certainly. diff --git a/accel/tcg/cpu-exec.c

Re: [Qemu-devel] [PATCH RFC 0/3] tests/pxe-testt: add testcase using vhost-user-bridge

On Wed, Jul 12, 2017 at 11:13:05PM +0200, Jens Freimann wrote: > On Wed, Jul 12, 2017 at 06:10:05PM +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 12, 2017 at 11:41:46AM +0200, Jens Freimann wrote: > > > This implements a testcase for pxe-test using the vhost-user interface. > > > Spawn a > > >

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On Wed, Jul 12, 2017 at 05:56:46PM -0300, Eduardo Habkost wrote: > On Wed, Jul 12, 2017 at 11:31:59PM +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 12, 2017 at 05:15:50PM -0300, Eduardo Habkost wrote: > > > On Wed, Jul 12, 2017 at 06:17:55PM +0300, Michael S. Tsirkin wrote: > > > > On Wed, Jul

[Qemu-devel] [PATCH] tcg/aarch64: Use ADR for shorter jumps

Use ADR instruction for shorter jumps. I was going through rth's email and realized that I should have done this the first time. Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] Don't enable networking as a side-effect of DEBUG=1

On 07/12/2017 06:46 PM, Philippe Mathieu-Daudé wrote: now trying old debian release: $ docker run --rm -it debian:wheezy sh -c "cat /etc/debian_version"; echo $? 7.11 0 $ docker run --rm -it debian:wheezy bash -c "cat /etc/debian_version"; echo $? 139 Indeed using debian:wheezy based

Re: [Qemu-devel] [PATCH v12 02/27] cpu-exec: Avoid global variables in icount-related functions

On Wed, Jul 12, 2017 at 11:42:57 +0300, Lluís Vilanova wrote: > Alex Bennée writes: > > > Lluís Vilanova writes: > > >> Signed-off-by: Lluís Vilanova > > > I guess. I assume this is also something Emilio is targeting with his > > multi-threaded

Re: [Qemu-devel] [PATCH] Don't enable networking as a side-effect of DEBUG=1

Hi Daniel, On 07/12/2017 01:25 PM, Daniel P. Berrange wrote: When trying to debug problems with tests it is natural to set DEBUG=1 when starting the docker environment. Unfortunately this has a side-effect of enabling an eth0 network interface in the container, which changes the operating

[Qemu-devel] [PATCH v4 2/2] mttcg/i386: Patch instruction using async_safe_* framework

In mttcg, calling pause_all_vcpus() during execution from the generated TBs causes a deadlock if some vCPU is waiting for exclusive execution in start_exclusive(). Fix this by using the aync_safe_* framework instead of pausing vcpus for patching instructions. CC: Paolo Bonzini

[Qemu-devel] [PATCH v4 1/2] Revert "exec.c: Fix breakpoint invalidation race"

Now that we have proper locking after MTTCG patches have landed, we can revert the commit. This reverts commit a9353fe897ca2687e5b3385ed39e3db3927a90e0. CC: Peter Maydell CC: Alex Bennée Signed-off-by: Pranith Kumar ---

Re: [Qemu-devel] [PATCH] Don't enable networking as a side-effect of DEBUG=1

Hi Alex, Fam, I wanted to try this patch but got: $ make docker-test-quick@centos6 NETWORK=1 BUILD centos6 The command '/bin/sh -c yum install -y epel-release' returned a non-zero code: 139 Traceback (most recent call last): File "./tests/docker/docker.py", line 382, in

Re: [Qemu-devel] [PULL v2 0/5] Merge sockets 2017/07/11

Hi Daniel, On 07/12/2017 01:18 PM, Daniel P. Berrange wrote: The following changes since commit 3d0bf8dfdfebd7f2ae41b6f220444b8047d6b1ee: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20170710a' into staging (2017-07-10 18:13:03 +0100) are available in the git

Re: [Qemu-devel] [PATCH v4 17/17] dirty-bitmap: Convert internal hbitmap size/granularity

On 07/12/2017 04:00 PM, John Snow wrote: > > > On 07/03/2017 11:10 AM, Eric Blake wrote: >> Now that all callers are using byte-based interfaces, there's no >> reason for our internal hbitmap to remain with sector-based >> granularity. It also simplifies our internal scaling, since we >>

Re: [Qemu-devel] [PATCH RFC 0/3] tests/pxe-testt: add testcase using vhost-user-bridge

On Wed, Jul 12, 2017 at 06:10:05PM +0300, Michael S. Tsirkin wrote: On Wed, Jul 12, 2017 at 11:41:46AM +0200, Jens Freimann wrote: This implements a testcase for pxe-test using the vhost-user interface. Spawn a vhost-user-bridge process and connect it to the qemu process. It is send as an RFC

Re: [Qemu-devel] [PATCH v4 17/17] dirty-bitmap: Convert internal hbitmap size/granularity

On 07/03/2017 11:10 AM, Eric Blake wrote: > Now that all callers are using byte-based interfaces, there's no > reason for our internal hbitmap to remain with sector-based > granularity. It also simplifies our internal scaling, since we > already know that hbitmap widens requests out to

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On Wed, Jul 12, 2017 at 11:31:59PM +0300, Michael S. Tsirkin wrote: > On Wed, Jul 12, 2017 at 05:15:50PM -0300, Eduardo Habkost wrote: > > On Wed, Jul 12, 2017 at 06:17:55PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Jul 12, 2017 at 11:51:21AM -0300, Eduardo Habkost wrote: > > > > On Wed, Jul

Re: [Qemu-devel] [PATCH 09/22] exec-all: shrink tb->invalid to uint8_t

On Tue, Jul 11, 2017 at 14:53:00 -1000, Richard Henderson wrote: > On 07/10/2017 01:57 PM, Emilio G. Cota wrote: > >>What I would prefer to do is generalize tb->cflags. Those values *do* > >>affect how we compile the TB, and yet we don't take them into account. So I > >>think it would be a good

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On Wed, Jul 12, 2017 at 05:29:01PM +0100, Daniel P. Berrange wrote: > On Wed, Jul 12, 2017 at 06:23:51PM +0200, Paolo Bonzini wrote: > > On 12/07/2017 18:12, Daniel P. Berrange wrote: > > >> I'm still not 100% sure whether that auto-deprecation of machine types > > >> is such a good idea ... since

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On Wed, Jul 12, 2017 at 05:15:50PM -0300, Eduardo Habkost wrote: > On Wed, Jul 12, 2017 at 06:17:55PM +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 12, 2017 at 11:51:21AM -0300, Eduardo Habkost wrote: > > > On Wed, Jul 12, 2017 at 10:22:33AM +0200, Thomas Huth wrote: > > > > We don't want to

Re: [Qemu-devel] [PATCH v4 15/17] qcow2: Switch store_bitmap_data() to byte-based iteration

On 07/03/2017 11:10 AM, Eric Blake wrote: > Now that we have adjusted the majority of the calls this function > makes to be byte-based, it is easier to read the code if it makes > passes over the image using bytes rather than sectors. > > Signed-off-by: Eric Blake >

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On Wed, Jul 12, 2017 at 04:04:00PM +0100, Daniel P. Berrange wrote: > On Wed, Jul 12, 2017 at 10:22:33AM +0200, Thomas Huth wrote: > > We don't want to carry along old machine types forever. If we are able to > > remove the pc machines up to 0.13 one day for example, this would allow > > us to

Re: [Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

On Wed, Jul 12, 2017 at 06:17:55PM +0300, Michael S. Tsirkin wrote: > On Wed, Jul 12, 2017 at 11:51:21AM -0300, Eduardo Habkost wrote: > > On Wed, Jul 12, 2017 at 10:22:33AM +0200, Thomas Huth wrote: > > > We don't want to carry along old machine types forever. If we are able to > > > remove the

Re: [Qemu-devel] [PATCH v4 14/17] qcow2: Switch load_bitmap_data() to byte-based iteration

On 07/03/2017 11:10 AM, Eric Blake wrote: > Now that we have adjusted the majority of the calls this function > makes to be byte-based, it is easier to read the code if it makes > passes over the image using bytes rather than sectors. > > Signed-off-by: Eric Blake >

Re: [Qemu-devel] [PATCH 1/1] tcg/tci: Remove unnecessary TODO() for INDEX_op_bswap16_i64

On 07/12/2017 03:49 AM, Jaroslaw Pelczar wrote: @@ -1046,7 +1046,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr) break; #if TCG_TARGET_HAS_bswap16_i64 case INDEX_op_bswap16_i64: -TODO(); t0 = *tb_ptr++; t1

Re: [Qemu-devel] [PATCH v3.5 2/8] target/s390x: Implement CONVERT UNICODE insns

On 07/11/2017 08:46 PM, Thomas Huth wrote: +s1 = cpu_ldub_data_ra(env, addr + 1, ra); +s2 = cpu_ldub_data_ra(env, addr + 2, ra); +c = s0 & 0x0f; +c = (c << 6) | (s1 & 0x3f); +c = (c << 6) | (s2 & 0x3f); +/* Fold the byte-by-byte range descriptions

Re: [Qemu-devel] [PATCH v3 4/8] hw/i386: Improve some of the warning messages

On Wed, Jul 12, 2017 at 11:39:59AM +0200, Markus Armbruster wrote: > Alistair Francis writes: > > > Signed-off-by: Alistair Francis > > Suggested-by: Eduardo Habkost > > You forgot to cc: Eduardo. Fixed. > > >

[Qemu-devel] [PATCH v2] target/i386: Fix BLSR and BLSI

The implementation of these two instructions was swapped. At the same time, unify the setup of eflags for the insn group. Reported-by: Ricardo Ribalda Delgado Signed-off-by: Richard Henderson --- target/i386/translate.c | 26

Re: [Qemu-devel] [PATCH v4 12/17] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes

On 07/03/2017 11:10 AM, Eric Blake wrote: > Some of the callers were already scaling bytes to sectors; others > can be easily converted to pass byte offsets, all in our shift > towards a consistent byte interface everywhere. Making the change > will also make it easier to write the hold-out

Re: [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI

This seems to work fine with the example. But my app still throughs sigsegv :( diff --git a/target/i386/translate.c b/target/i386/translate.c index 2c64d2b71ec4..564b9c6057c2 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -4033,32 +4033,23 @@ static void gen_sse(CPUX86State

Re: [Qemu-devel] [PATCH 3/3] Revert "machine: Convert abstract typename on compat_props to subclass names"

On Wed, Jul 12, 2017 at 07:49:22PM +0200, Halil Pasic wrote: > On 07/11/2017 02:43 AM, Eduardo Habkost wrote: > > This reverts commit 0bcba41fe379e4c6834adcf1456d9099db31a5b2. > > > > The bug addressed by that commit is now fixed in a better way by the > > commit "qdev: fix the order compat and

Re: [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI

On 07/12/2017 08:58 AM, Ricardo Ribalda Delgado wrote: Hi Richard Thanks again!, When I apply this patch I get the following error: /tmp/qemu/tcg/tcg.c:2042: tcg fatal error Bah. I misremembered that OR_TMP1 is unusable in this context. r~

Re: [Qemu-devel] [PATCH v4] qemu-img: Check for backing image if specified during create

On 07/12/2017 01:00 PM, Max Reitz wrote: > On 2017-07-12 16:56, Kevin Wolf wrote: >> Am 12.07.2017 um 16:42 hat Eric Blake geschrieben: >>> On 05/17/2017 07:38 AM, Max Reitz wrote: >>> >>> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1213786 >>> >>> Or, rather,

Re: [Qemu-devel] [PATCH 0/3] migration: export cap/params to qdev props

On Wed, Jul 12, 2017 at 02:53:40PM +0800, Peter Xu wrote: [...] > These properties should only be used for debugging/testing purpose, > and we should not guarantee any interface compatibility for them (just > like HMP). If we don't guarantee compatibility, the property names need to be prefixed

Re: [Qemu-devel] [PATCH 0/3] migration: export cap/params to qdev props

* Peter Xu (pet...@redhat.com) wrote: > We have the MigrationState as QDev now (which seems crazy). Let's > continue to benefit. > > This series is exporting all migration capabilities/params as global > parameters. Then we can do something like this: > > qemu -global

Re: [Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI

Hi Richard Thanks again!, When I apply this patch I get the following error: /tmp/qemu/tcg/tcg.c:2042: tcg fatal error Regards! On Wed, Jul 12, 2017 at 8:45 PM, Richard Henderson wrote: > The implementation of these two instructions was swapped. > At the same time, unify the

Re: [Qemu-devel] [PATCH 3/3] migration: export capabilities to props

* Peter Xu (pet...@redhat.com) wrote: > Do the same thing to migration capabilities, just like what we did in > previous patch for migration parameters. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 17

Re: [Qemu-devel] [PATCH 2/3] migration: export parameters to props

* Peter Xu (pet...@redhat.com) wrote: > Export migration parameters to qdev properties. Then we can use, for > example: > > -global migration.cpu-throttle-initial=xxx > > To specify migration parameters during init. > > One thing to mention is that, this usage should only be used for >

Re: [Qemu-devel] [PATCH 1/1] tcg/tci: Remove unnecessary TODO() for INDEX_op_bswap16_i64

Hi Jaroslaw, Thank for reporting this, however this fix has been reviewed: http://patchwork.ozlabs.org/patch/781982/ On 07/12/2017 10:52 AM, Jaroslaw Pelczar wrote: Running Ubuntu with systemd on AArch64 Cortex-A53 and qemu is compiled with ./configure --target-list=aarch64-softmmu

Re: [Qemu-devel] [PATCH 2/3] test-qdev-global-props: Test global property ordering

On Wed, Jul 12, 2017 at 08:06:14PM +0200, Halil Pasic wrote: > > > On 07/11/2017 02:43 AM, Eduardo Habkost wrote: > > Test case to detect the bug fixed by commit > > "qdev: fix the order compat and global properties are applied". > > > > Signed-off-by: Eduardo Habkost > >

[Qemu-devel] [PATCH] target/i386: Fix BLSR and BLSI

The implementation of these two instructions was swapped. At the same time, unify the setup of eflags for the insn group. Reported-by: Ricardo Ribalda Delgado Signed-off-by: Richard Henderson --- target/i386/translate.c | 25

Re: [Qemu-devel] [PATCH 12/22] translate-all: report correct avg host TB size

On Wed, Jul 12, 2017 at 16:25:45 +0100, Alex Bennée wrote: > Emilio G. Cota writes: (snip) > I think having the __attribute__ stuff is confusing. Why don't we just > do what the newer debug stuff does: > > modified accel/tcg/translate-all.c > @@ -66,6 +66,12 @@ > /* make

Re: [Qemu-devel] [PATCH 0/2] target/i386: Implement all TBM instructions

On 07/12/2017 03:28 AM, Ricardo Ribalda Delgado wrote: Hi Richard Thanks for your patch! I have applied it to my tree, but i still get SIGSEGV. I think that I might have found the problem. It seems to be related to the bmi instruction blsr, which seems to be not properly implemented. You're

  1   2   3   4   5   >