Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

On Sunday, July 30, 2017 12:23 PM, Michael S. Tsirkin wrote: > On Sat, Jul 29, 2017 at 08:47:08PM +0800, Wei Wang wrote: > > On 07/29/2017 07:08 AM, Michael S. Tsirkin wrote: > > > On Thu, Jul 27, 2017 at 10:50:11AM +0800, Wei Wang wrote: > > > > > > > OK I thought this over. While we might need

[Qemu-devel] [Bug 1473451] Re: Please support the native bios format for dec alpha

QEMU does not really implement a "true" ev67. We cheat and implement something that is significantly faster to emulate. E.g. doing all TLB refill within qemu, rather than in the PALcode. So, no, there's no chance of running true SRM or ARC firmware. -- You received this bug notification

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

On Sat, Jul 29, 2017 at 08:47:08PM +0800, Wei Wang wrote: > On 07/29/2017 07:08 AM, Michael S. Tsirkin wrote: > > On Thu, Jul 27, 2017 at 10:50:11AM +0800, Wei Wang wrote: > > > > > > OK I thought this over. While we might need these new APIs in > > > > > > the future, I think that at the moment,

[Qemu-devel] [PATCH for 2.10] hw/mps2_scc: fix incorrect properties

Signed-off-by: Philippe Mathieu-Daudé --- sorry, I missed them in my review :( hw/misc/mps2-scc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/mps2-scc.c b/hw/misc/mps2-scc.c index cc58d26f29..32be2a9df1 100644 --- a/hw/misc/mps2-scc.c +++

[Qemu-devel] [PATCH v6 2/4] sockets: factor out a new try_bind() function

A refactoring step to prepare for the problem exposed by the test-listen test in the previous commit. Simplify and reorganize the IPv6 specific extra measures and move it out of the for loop to increase code readability. No semantic changes. Signed-off-by: Knut Omang

[Qemu-devel] [PATCH v6 3/4] sockets: factor out create_fast_reuse_socket

Another refactoring step to prepare for fixing the problem exposed with the test-listen test in the previous commit Signed-off-by: Knut Omang --- util/qemu-sockets.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/util/qemu-sockets.c

[Qemu-devel] [PATCH v6 4/4] sockets: Handle race condition between binds to the same port

If an offset of ports is specified to the inet_listen_saddr function(), and two or more processes tries to bind from these ports at the same time, occasionally more than one process may be able to bind to the same port. The condition is detected by listen() but too late to avoid a failure. This

[Qemu-devel] [PATCH v6 0/4] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port

This series contains: * a unit test that exposes a race condition which causes QEMU to fail to find a port even when there is plenty of available ports. * a refactor of the qemu-sockets inet_listen_saddr() function to better handle this situation. Changes from v5: * Also move setting of error

[Qemu-devel] [PATCH v6 1/4] tests: Add test-listen - a stress test for QEMU socket listen

There's a potential race condition between multiple bind()'s attempting to bind to the same port, which occasionally allows more than one bind to succeed against the same port. When a subsequent listen() call is made with the same socket only one will succeed. The current QEMU code does however

Re: [Qemu-devel] [PATCH v5 2/4] sockets: factor out create_fast_reuse_socket

On Tue, 2017-07-25 at 10:38 +0100, Daniel P. Berrange wrote: > On Sat, Jul 22, 2017 at 09:49:31AM +0200, Knut Omang wrote: > > First refactoring step to prepare for fixing the problem > > exposed with the test-listen test in the previous commit > >  > > Signed-off-by: Knut Omang

Re: [Qemu-devel] [PATCH v5 4/4] sockets: Handle race condition between binds to the same port

On Tue, 2017-07-25 at 10:54 +0100, Daniel P. Berrange wrote: > On Sat, Jul 22, 2017 at 09:49:33AM +0200, Knut Omang wrote: > > If an offset of ports is specified to the inet_listen_saddr function(), > > and two or more processes tries to bind from these ports at the same time, > > occasionally

Re: [Qemu-devel] [PATCH] 9pfs: include for XATTR_SIZE_MAX

On 29 July 2017 at 14:50, Patrick Steinhardt wrote: > On Fri, Jul 28, 2017 at 02:20:49PM -0300, Philippe Mathieu-Daudé wrote: >> This is likely to break on BSD, but now than patchew has a NetBSD job >> you can trigger a build RESENDing this patch. > Thanks for the feedback! Is this

[Qemu-devel] [PATCH v4 1/3] block: add bdrv_get_format_alloc_stat format interface

The function should collect statistics, about used/unused by top-level format driver space (in its .file) and allocation status (data/zero/discarded/after-eof) of corresponding areas in this .file. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c

[Qemu-devel] [PATCH v4 0/3] qemu-img check: format allocation info

Hi all. See 01 patch for the doc. Question to discuss. If I understand correctly get_block_status flags allocated, zero, and data actually provide 5 possible combinations, which I combine into three. allocated data zero 1 11\__ data 1 10/ 1 01\__

[Qemu-devel] [PATCH v4 3/3] qemu-img check: add format allocation info

Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 6 +- qemu-img.c | 42 ++ 2 files changed, 47 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index

[Qemu-devel] [PATCH v4 2/3] qcow2: add .bdrv_get_format_alloc_stat

Realize .bdrv_get_format_alloc_stat interface. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 152 + block/qcow2.c | 2 + block/qcow2.h | 2 + 3 files changed, 156

Re: [Qemu-devel] [PATCH] 9pfs: include for XATTR_SIZE_MAX

On Fri, Jul 28, 2017 at 02:20:49PM -0300, Philippe Mathieu-Daudé wrote: > > On Mon, Jun 26, 2017 at 12:20 PM, Patrick Steinhardt wrote: > >> The function `v9fs_xattrcreate` makes use of the define `XATTR_SIZE_MAX` > >> to reject attempts of creating xattrs with an invalid size, which

Re: [Qemu-devel] [PATCH v2 0/4] trace-events: print 0x before hex numbers

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 0/4] trace-events: print 0x before hex numbers Message-id: 20170729131159.24949-1-vsement...@virtuozzo.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH v2 4/4] trace-events: fix code style: print 0x before hex numbers

The only exception are groups of numers separated by symbols '.', ' ', ':', '/', like 'ab.09.7d'. This patch is made by the following: > find . -name trace-events | xargs python script.py where script.py is the following python script: = #!/usr/bin/env python import

[Qemu-devel] [PATCH v2 3/4] checkpatch: check trace-events code style

Accordingly to CODING_STYLE, check that in trace-events: 1. hex numbers are prefixed with '0x' 2. '#' flag of printf is not used 3. The exclusion from 1. are period-separated groups of numbers Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/checkpatch.pl | 19

[Qemu-devel] [PATCH v2 0/4] trace-events: print 0x before hex numbers

Hi all! It is hard to read logs, when there are hex and dec numbers in one line, when hex number doesn't contain any letters and don't have '0x' prefix. So, here is a complete solution for the problem: - add information into CODING_STYLE - add a check into checkpatch.pl - fix current state The

[Qemu-devel] [PATCH v2 1/4] coding_style: add point about 0x in trace-events

Signed-off-by: Vladimir Sementsov-Ogievskiy --- CODING_STYLE | 23 +++ 1 file changed, 23 insertions(+) diff --git a/CODING_STYLE b/CODING_STYLE index 2fa0c0b65b..2e6a0507be 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -123,3 +123,26 @@ We use

[Qemu-devel] [PATCH v2 2/4] trace-events: fix code style: %# -> 0x%

In trace format '#' flag of printf is forbidden. Fix it to '0x%'. This patch is created by the following: check that we have a problem > find . -name trace-events | xargs grep '%#' | wc -l 56 check that there are no cases with additional printf flags > find . -name trace-events | xargs grep

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

On 07/29/2017 07:08 AM, Michael S. Tsirkin wrote: On Thu, Jul 27, 2017 at 10:50:11AM +0800, Wei Wang wrote: OK I thought this over. While we might need these new APIs in the future, I think that at the moment, there's a way to implement this feature that is significantly simpler. Just add each

Re: [Qemu-devel] QEMU NVDIMM as type 7 in e820 table

On 07/28/17 13:45 -0600, Ross Zwisler wrote: > On Fri, Jul 28, 2017 at 11:11:10AM -0700, Dan Williams wrote: > > On Fri, Jul 28, 2017 at 11:04 AM, Ross Zwisler > > wrote: > > > I've been using the virtualized NVDIMM support in QEMU for testing, and I > > > noticed

Re: [Qemu-devel] 'make help' generate unrelated files

On 29 July 2017 at 02:55, Philippe Mathieu-Daudé wrote: > Is it necessary to generate this files to run 'make help'? > > $ ./configure > [...] > $ make help > CHK version_gen.h > UPD version_gen.h > DEP util.c > CHK version_gen.h This happens

Re: [Qemu-devel] tb_invalidate_phys_range and tb_invalidate_phys_page_range

On 29 July 2017 at 01:33, Emilio G. Cota wrote: > While working on the removal of tb_lock, I stumbled upon the following. > > Commit 77a8f1a51 ("linux-user: Fix stale tbs after mmap") introduced > tb_invalidate_phys_range(), which we now have in accel/tcg/translate-all.c > [

Re: [Qemu-devel] [PATCH 2/3] COLO: Define COLOMode without QAPI

On 2017/7/29 1:17, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: COLOMode is defined in the QAPI schema, but not used there. Of the stuff QAPI generates for it only the typedef is actually used. Use of QAPI is pointless and only complicates things, so don't.