Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

On Tue, 1 Aug 2017 13:04:46 +0800 Bob Chen wrote: > Hi, > > This is a sketch of my hardware topology. > > CPU0 <- QPI ->CPU1 >| | > Root Port(at PCIe.0)Root Port(at PCIe.1) >/\

Re: [Qemu-devel] [RFC 07/29] migration: better error handling with QEMUFile

On Mon, Jul 31, 2017 at 07:39:24PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: [...] > > @@ -2425,6 +2425,16 @@ static int ram_load_postcopy(QEMUFile *f) > > uint8_t ch; > > > > addr = qemu_get_be64(f); > > + > > +/* > > + * If

Re: [Qemu-devel] [RFC 01/29] migration: fix incorrect postcopy recved_bitmap

On 08/01/2017 05:11 AM, Peter Xu wrote: On Mon, Jul 31, 2017 at 05:34:14PM +0100, Dr. David Alan Gilbert wrote: * Peter Xu (pet...@redhat.com) wrote: The bitmap setup during postcopy is incorrectly when the pgaes are huge pages. Fix it. Signed-off-by: Peter Xu ---

Re: [Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and friends

Eric Blake writes: > On 07/31/2017 07:34 AM, Eric Blake wrote: >> On 07/31/2017 03:16 AM, Markus Armbruster wrote: >> >> qtest_qmp(s, "%p", QOBJECT(dict)) takes ownership of dict? > >> So given the clean bill of health from valgrind, we definitely DO turn

Re: [Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean up string interpolation into QMP input

Eric Blake writes: > On 07/31/2017 02:29 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 07/28/2017 11:35 AM, Eric Blake wrote: >> +QObject *extra_args = qobject_from_jsonf("{ 'shm': '%s', 'size': >> '1M' }", >> +

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

Hi, This is a sketch of my hardware topology. CPU0 <- QPI ->CPU1 | | Root Port(at PCIe.0)Root Port(at PCIe.1) /\ / \ SwitchSwitch SwitchSwitch / \

Re: [Qemu-devel] [Qemu-arm] [PATCH] watchdog: wdt_aspeed: Add support for the reset width register

Hi Phil, On Tue, 2017-08-01 at 00:23 -0300, Philippe Mathieu-Daudé wrote: > Hi Andrew, > > On 07/31/2017 10:04 PM, Andrew Jeffery wrote: > > The reset width register controls how the pulse on the SoC's WDTRST{1,2} > > pins behaves. A pulse is emitted if the external reset bit is set in > >

Re: [Qemu-devel] [Qemu-arm] [PATCH] watchdog: wdt_aspeed: Add support for the reset width register

Hi Andrew, On 07/31/2017 10:04 PM, Andrew Jeffery wrote: The reset width register controls how the pulse on the SoC's WDTRST{1,2} pins behaves. A pulse is emitted if the external reset bit is set in WDT_CTRL. WDT_RESET_WIDTH requires magic bit patterns to configure both push-pull/open-drain and

Re: [Qemu-devel] [RFC 10/29] migration: new property "x-postcopy-fast"

On Mon, Jul 31, 2017 at 07:52:24PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > This provides a way to start postcopy ASAP when migration starts. To do > > this, we need both: > > > > -global migration.x-postcopy-ram=on \ > > -global

Re: [Qemu-devel] [RFC 09/29] migration: provide postcopy_fault_thread_notify()

On Mon, Jul 31, 2017 at 07:45:38PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > A general helper to notify the fault thread. > > > > Signed-off-by: Peter Xu > > --- > > migration/postcopy-ram.c | 35 --- > >

[Qemu-devel] xhci: move command stop and command abort flag check to the case when the crcr_low register is set

Hello, I'd like to submit a patch to the xhci subsystem of QEMU. Currently, when the command stop or command abort flags in the crcr_low register are set, nothing happens. This is because the part of the code that tests those two flags (and performs command ring abort/stop) is in the crcr_high

Re: [Qemu-devel] [RFC 04/29] bitmap: introduce bitmap_invert()

On Mon, Jul 31, 2017 at 06:11:56PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > It is used to invert the whole bitmap. > > Would it be easier to change bitmap_complement to use ^ > in it's macro and slow_bitmap_complement, and then you could call it > with

Re: [Qemu-devel] [PATCH 3/3] s390x/css: generate channel path initialized CRW for channel path hotplug

* Cornelia Huck [2017-07-31 13:13:02 +0200]: > On Mon, 31 Jul 2017 11:51:37 +0800 > Dong Jia Shi wrote: > > > * Cornelia Huck [2017-07-27 13:59:10 +0200]: > > > > > On Thu, 27 Jul 2017 03:54:18 +0200 > > > Dong Jia Shi

Re: [Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling

On Mon, Jul 31, 2017 at 05:53:39PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > When accept failed, we should setup errp with the reason. More > > importantly, the caller may assume errp be non-NULL when error happens, > > and not setting the errp may crash

Re: [Qemu-devel] [for-2.11 PATCH 24/26] spapr: allow guest to update the XICS phandle

On 31/07/17 14:58, David Gibson wrote: > On Fri, Jul 28, 2017 at 08:20:57AM +0200, Thomas Huth wrote: >> On 28.07.2017 06:02, David Gibson wrote: >>> On Tue, Jul 25, 2017 at 08:03:06PM +0200, Greg Kurz wrote: The "phandle" property of the XICS node is referenced by the "interrupt-map"

Re: [Qemu-devel] [PATCH 0/3] Channel Path realted CRW generation

* Cornelia Huck [2017-07-31 10:54:47 +0200]: > On Fri, 28 Jul 2017 23:50:48 +0800 > Dong Jia Shi wrote: > > > * Cornelia Huck [2017-07-28 13:53:01 +0200]: > > > > > > You're bound to get different kinds of notifications: via

Re: [Qemu-devel] [RFC 01/29] migration: fix incorrect postcopy recved_bitmap

On Mon, Jul 31, 2017 at 05:34:14PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > The bitmap setup during postcopy is incorrectly when the pgaes are huge > > pages. Fix it. > > > > Signed-off-by: Peter Xu > > --- > > migration/postcopy-ram.c

Re: [Qemu-devel] [PATCH v2 0/2] Add global device ID in virt machine

On Mon, Jul 31, 2017 at 03:13:09PM +, Diana Madalina Craciun wrote: > On 07/31/2017 05:06 PM, Michael S. Tsirkin wrote: > > On Mon, Jul 31, 2017 at 01:22:45PM +, Diana Madalina Craciun wrote: > If we are to use a value of 0 for the constant in case of PCI devices, > what happens

Re: [Qemu-devel] [PATCH 3/3] s390x/css: generate channel path initialized CRW for channel path hotplug

* Halil Pasic [2017-07-31 14:30:32 +0200]: > > > On 07/31/2017 01:13 PM, Cornelia Huck wrote: > > On Mon, 31 Jul 2017 11:51:37 +0800 > > Dong Jia Shi wrote: > > > >> * Cornelia Huck [2017-07-27 13:59:10 +0200]: > >> >

Re: [Qemu-devel] [PATCH 3/3] s390x/css: generate channel path initialized CRW for channel path hotplug

* Cornelia Huck [2017-07-31 10:41:47 +0200]: > On Mon, 31 Jul 2017 09:46:17 +0800 > Dong Jia Shi wrote: > > > * Cornelia Huck [2017-07-28 14:58:19 +0200]: > > > > Exposing real channel paths to the guest means that the guest

[Qemu-devel] [PATCH] watchdog: wdt_aspeed: Add support for the reset width register

The reset width register controls how the pulse on the SoC's WDTRST{1,2} pins behaves. A pulse is emitted if the external reset bit is set in WDT_CTRL. WDT_RESET_WIDTH requires magic bit patterns to configure both push-pull/open-drain and active-high/active-low behaviours and thus needs some

Re: [Qemu-devel] [Qemu-block] [PATCH] block: check BlockDriverState object before dereference

On 07/23/2017 10:36 AM, Paolo Bonzini wrote: > On 21/07/2017 17:47, Stefan Hajnoczi wrote: >> Hmm...BlockDriverState still has bdrv_is_inserted() even though >> BlockBackend->root can be NULL? CCing Markus in case he has thoughts on >> the BB/BDS split. >> >> I find it weird that

Re: [Qemu-devel] [PATCH 1/2] vhost-user-blk: introduce a new vhost-user-blk host device

> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Monday, July 31, 2017 11:41 PM > To: Stefan Hajnoczi ; Liu, Changpeng > > Cc: qemu-devel@nongnu.org; fel...@nutanix.com; m...@redhat.com; Marc- > André Lureau

[Qemu-devel] [PATCH for 2.10] mips/malta: leave space for the bootmap after the initrd

Since commit 9768e2abf7 the initrd is loaded at the end of the low memory to avoid clash for the kernel relocation when kaslr is used. However this in turn conflicts with the bootmap memory that the kernel tries to place after initrd, but in low memory. The bootmap spans the whole usable physical

Re: [Qemu-devel] [PATCH 2/2] mips: Add KVM T segment support for TCG

On Mon, Jul 31, 2017 at 01:47:48PM -0700, Richard Henderson wrote: > On 07/31/2017 06:09 AM, James Hogan wrote: > > +static int mips_um_ksegs; > > + > > uint64_t cpu_mips_kseg0_to_phys(void *opaque, uint64_t addr) > > { > > return addr & 0x1fffll; > > @@ -38,3 +40,13 @@ uint64_t

Re: [Qemu-devel] [PATCH 2/2] mips: Add KVM T segment support for TCG

On 07/31/2017 06:09 AM, James Hogan wrote: +static int mips_um_ksegs; + uint64_t cpu_mips_kseg0_to_phys(void *opaque, uint64_t addr) { return addr & 0x1fffll; @@ -38,3 +40,13 @@ uint64_t cpu_mips_kvm_um_phys_to_kseg0(void *opaque, uint64_t addr) { return addr |

[Qemu-devel] [Bug 1706296] Re: Booting NT 4 disk causes /home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion failed: (!qemu_mutex_iothread_locked())

There are three possibilities: 1) push qemu_mutex_lock_iothread down to cc->do_interrupt 2) change the condition in io_readx/io_writex to mr->global_locking && !qemu_mutex_iothread_locked() 3) both We can do (2) for 2.10 and later ponder on doing the first. -- You received this bug

[Qemu-devel] [PATCH v3 2/2] Add more function keys to cocoa.m

Signed-off-by: John Arbuckle Reviewed-by: Daniel P. Berrange --- ui/cocoa.m | 5 + 1 file changed, 5 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index 93e56d0518..edc7a65f7c 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -225,6 +225,11 @@

[Qemu-devel] [PATCH v3 1/2] Add more function keys to QEMU

There are now keyboards that have 19 function keys. This patch extends QEMU so these function keys can be used. Signed-off-by: John Arbuckle --- qapi-schema.json | 16 +++- ui/input-keymap.c | 12 2 files changed, 27 insertions(+), 1

[Qemu-devel] [PATCH v3 0/2] Add more function keys support

QEMU can only handle up to function key F15. These patches extend QEMU to F24. John Arbuckle (2): Add more function keys to QEMU Add more function keys to cocoa.m qapi-schema.json | 16 +++- ui/cocoa.m| 5 + ui/input-keymap.c | 12 3 files changed, 32

Re: [Qemu-devel] [PATCH v3 09/13] qcow2: move is_zero_sectors() up

On 07/31/2017 11:22 AM, Anton Nefedov wrote: > To be used in the following commit without a forward declaration. > > Signed-off-by: Anton Nefedov > --- > block/qcow2.c | 39 +++ > 1 file changed, 19 insertions(+), 20 deletions(-)

Re: [Qemu-devel] [PATCH v3 04/13] block: support BDRV_REQ_ALLOCATE in passthrough drivers

On 07/31/2017 11:21 AM, Anton Nefedov wrote: > Support the flag if the underlying BDS supports it > > Signed-off-by: Anton Nefedov > --- > block/blkdebug.c | 3 ++- > block/raw-format.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) What about

Re: [Qemu-devel] [RFC 11/29] migration: new postcopy-pause state

* Peter Xu (pet...@redhat.com) wrote: > Introducing a new state "postcopy-paused", which can be used to pause a > postcopy migration. It is targeted to support network failures during > postcopy migration. Now when network down for postcopy, the source side > will not fail the migration. Instead

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2 4/6] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

On 07/31/17 20:55, Michael S. Tsirkin wrote: > On Mon, Jul 31, 2017 at 08:16:49PM +0200, Laszlo Ersek wrote: >> OK. If the proposed solution with the r/o mem base/limit registers is >> rooted in the spec (and I think it indeed must be; apparently this would >> be the same as what we're already

Re: [Qemu-devel] [PATCH v3] qemu-iotests: add a "how to" to ./README

On 07/31/2017 12:26 PM, Stefan Hajnoczi wrote: > There is not much getting started documentation for qemu-iotests. This > patch explains how to create a new test and covers the overall testing > approach. > > Cc: Ishani Chugh > Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v3 2/3] pci: add QEMU-specific PCI capability structure

2017-07-31 21:57 GMT+03:00 Michael S. Tsirkin : > On Mon, Jul 31, 2017 at 09:54:55PM +0300, Alexander Bezzubikov wrote: >> 2017-07-31 17:09 GMT+03:00 Marcel Apfelbaum : >> > On 31/07/2017 17:00, Michael S. Tsirkin wrote: >> >> >> >> On Sat, Jul 29, 2017 at

Re: [Qemu-devel] [PATCH v3 2/3] pci: add QEMU-specific PCI capability structure

On Mon, Jul 31, 2017 at 09:54:55PM +0300, Alexander Bezzubikov wrote: > 2017-07-31 17:09 GMT+03:00 Marcel Apfelbaum : > > On 31/07/2017 17:00, Michael S. Tsirkin wrote: > >> > >> On Sat, Jul 29, 2017 at 02:34:31AM +0300, Aleksandr Bezzubikov wrote: > >>> > >>> On PCI init PCI

Re: [Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and friends

On 07/31/2017 07:34 AM, Eric Blake wrote: > On 07/31/2017 03:16 AM, Markus Armbruster wrote: > > qtest_qmp(s, "%p", QOBJECT(dict)) takes ownership of dict? > >>> So given the clean bill of health from valgrind, we definitely DO turn >>> over responsibility for freeing on object to its

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2 4/6] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

On Mon, Jul 31, 2017 at 08:16:49PM +0200, Laszlo Ersek wrote: > OK. If the proposed solution with the r/o mem base/limit registers is > rooted in the spec (and I think it indeed must be; apparently this would > be the same as what we're already planning for IO disablement), then > that's a strong

Re: [Qemu-devel] [PATCH v3 2/3] pci: add QEMU-specific PCI capability structure

2017-07-31 17:09 GMT+03:00 Marcel Apfelbaum : > On 31/07/2017 17:00, Michael S. Tsirkin wrote: >> >> On Sat, Jul 29, 2017 at 02:34:31AM +0300, Aleksandr Bezzubikov wrote: >>> >>> On PCI init PCI bridge devices may need some >>> extra info about bus number to reserve, IO, memory

Re: [Qemu-devel] Call for testers for various versions of Windows

On 07/31/2017 02:05 PM, Programmingkid wrote: > >> On Jul 31, 2017, at 2:03 PM, John Snow wrote: >> >> >> >> On 07/28/2017 03:45 PM, Programmingkid wrote: >>> I have made a page that keeps track of anyone who wishes to be a tester for >>> a particular version of Windows.

Re: [Qemu-devel] [RFC 10/29] migration: new property "x-postcopy-fast"

* Peter Xu (pet...@redhat.com) wrote: > This provides a way to start postcopy ASAP when migration starts. To do > this, we need both: > > -global migration.x-postcopy-ram=on \ > -global migration.x-postcopy-fast=on Can you explain why this is necessary? Both sides already know they're doing

Re: [Qemu-devel] [RFC 09/29] migration: provide postcopy_fault_thread_notify()

* Peter Xu (pet...@redhat.com) wrote: > A general helper to notify the fault thread. > > Signed-off-by: Peter Xu > --- > migration/postcopy-ram.c | 35 --- > migration/postcopy-ram.h | 2 ++ > 2 files changed, 22 insertions(+), 15 deletions(-)

Re: [Qemu-devel] [PATCH v3 4/5] hw/pci: add QEMU-specific PCI capability to Generic PCI Express Root Port

2017-07-31 14:43 GMT+03:00 Marcel Apfelbaum : > On 29/07/2017 2:37, Aleksandr Bezzubikov wrote: >> >> From: Aleksandr Bezzubikov >> >> To enable hotplugging of a newly created pcie-pci-bridge, >> we need to tell firmware (SeaBIOS in this case) > > > Not

Re: [Qemu-devel] [PATCH v3 3/5] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

2017-07-31 14:29 GMT+03:00 Marcel Apfelbaum : > On 29/07/2017 2:37, Aleksandr Bezzubikov wrote: >> >> On PCI init PCI bridges may need some >> extra info about bus number to reserve, IO, memory and >> prefetchable memory limits. QEMU can provide this >> with a special

Re: [Qemu-devel] [RFC 08/29] migration: reuse mis->userfault_quit_fd

* Peter Xu (pet...@redhat.com) wrote: > It was only used for quitting the page fault thread before. Let it be > something more useful - now we can use it to notify a "wake" for the > page fault thread (for any reason), and it only means "quit" if the > fault_thread_quit is set. > > Since we

Re: [Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-07-31 14:23 GMT+03:00 Marcel Apfelbaum : > On 29/07/2017 2:37, Aleksandr Bezzubikov wrote: >> >> Introduce a new PCIExpress-to-PCI Bridge device, >> which is a hot-pluggable PCI Express device and >> supports devices hot-plug with SHPC. >> >> This device is intended to

Re: [Qemu-devel] [RFC 07/29] migration: better error handling with QEMUFile

* Peter Xu (pet...@redhat.com) wrote: > If the postcopy down due to some reason, we can always see this on dst: > > qemu-system-x86_64: RP: Received invalid message 0x length 0x > > However in most cases that's not the real issue. The problem is that > qemu_get_be16() has no way to

Re: [Qemu-devel] [RFC PATCH v2 4/6] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

On Mon, Jul 31, 2017 at 01:06:23PM +0300, Marcel Apfelbaum wrote: > On 29/07/2017 2:12, Michael S. Tsirkin wrote: > > On Thu, Jul 27, 2017 at 12:39:54PM +0300, Marcel Apfelbaum wrote: > > > On 27/07/2017 2:28, Michael S. Tsirkin wrote: > > > > On Thu, Jul 27, 2017 at 12:54:07AM +0300, Alexander

Re: [Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean up string interpolation into QMP input

On 07/31/2017 02:29 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 07/28/2017 11:35 AM, Eric Blake wrote: > +QObject *extra_args = qobject_from_jsonf("{ 'shm': '%s', 'size': > '1M' }", > + tmpshm); >>

Re: [Qemu-devel] [RFC 06/29] migration: dump str in migrate_set_state trace

* Peter Xu (pet...@redhat.com) wrote: > Strings are more readable for debugging. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 3 ++- > migration/trace-events | 2 +- > 2 files changed, 3

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2 4/6] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

On 07/29/17 01:15, Michael S. Tsirkin wrote: > On Thu, Jul 27, 2017 at 03:58:58PM +0200, Laszlo Ersek wrote: >> On 07/27/17 11:39, Marcel Apfelbaum wrote: >>> On 27/07/2017 2:28, Michael S. Tsirkin wrote: On Thu, Jul 27, 2017 at 12:54:07AM +0300, Alexander Bezzubikov wrote: > 2017-07-26

Re: [Qemu-devel] How to make ELF headers/symbol sections available for multiboot?

On 07/31/2017 10:21 AM, Anatol Pomozov wrote: > ELF sections info is needed for an OS to map address space properly. No, ELF *program header* info is needed for an OS to map the address space properly. For example: $ readelf -hl vmlinux-4.9.0-3-5kc-malta Using a mips kernel binary I happend to

Re: [Qemu-devel] [PATCH 1/2] mips: Improve segment defs for KVM T guests

On 07/31/2017 10:09 AM, James Hogan wrote: Improve the segment definitions used by get_physical_address() to yield target_ulong types, e.g. 0x8000 instead of 0x8000. This is in preparation for enabling emulation of MIPS KVM T segments in TCG MIPS targets, which unlike KVM could

Re: [Qemu-devel] Call for testers for various versions of Windows

On 07/28/2017 03:45 PM, Programmingkid wrote: > I have made a page that keeps track of anyone who wishes to be a tester for a > particular version of Windows. Here is the page: > http://wiki.qemu.org/Testing/Windows > I think for this to be successful, you'd have to define exactly what the

Re: [Qemu-devel] Call for testers for various versions of Windows

> On Jul 31, 2017, at 2:03 PM, John Snow wrote: > > > > On 07/28/2017 03:45 PM, Programmingkid wrote: >> I have made a page that keeps track of anyone who wishes to be a tester for >> a particular version of Windows. Here is the page: >>

Re: [Qemu-devel] [RFC 05/29] bitmap: introduce bitmap_count_one()

* Peter Xu (pet...@redhat.com) wrote: > Count how many bits set in the bitmap. > > Signed-off-by: Peter Xu > --- > include/qemu/bitmap.h | 10 ++ > util/bitmap.c | 15 +++ > 2 files changed, 25 insertions(+) > > diff --git a/include/qemu/bitmap.h

Re: [Qemu-devel] [PATCH v2 2/2] trace: add trace_event_get_state_backends()

Stefan Hajnoczi writes: > On Mon, Jul 31, 2017 at 06:09:56PM +0300, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >> > Code that checks dstate is unaware of SystemTap and LTTng UST dstate, so >> > the following trace event will not fire when solely enabled by SystemTap >> > or LTTng UST:

Re: [Qemu-devel] [RFC] block-insert-node and block-job-delete

On Fri, Jul 28, 2017 at 02:08:43PM +0200, Kevin Wolf wrote: Am 27.07.2017 um 12:07 hat Stefan Hajnoczi geschrieben: On Wed, Jul 26, 2017 at 09:23:20PM +0300, Manos Pitsidianakis wrote: > On Wed, Jul 26, 2017 at 04:12:21PM +0100, Stefan Hajnoczi wrote: > > On Wed, Jul 26, 2017 at 05:19:24PM

Re: [Qemu-devel] [PATCH v3] qemu-iotests: add a "how to" to ./README

On 07/31/2017 11:26 AM, Stefan Hajnoczi wrote: > There is not much getting started documentation for qemu-iotests. This > patch explains how to create a new test and covers the overall testing > approach. > > Cc: Ishani Chugh > Reviewed-by: Eric Blake

Re: [Qemu-devel] How to make ELF headers/symbol sections available for multiboot?

Hi On Sun, Jul 30, 2017 at 2:42 PM, Eduardo Habkost wrote: > > CCing Alex, the original author of load_multiboot(), and Kevin, > who touched multiboot code recently. > > > On Fri, Jul 28, 2017 at 02:28:34PM -0700, Anatol Pomozov wrote: >> Hi >> >> I am looking at x86

Re: [Qemu-devel] [PATCH v3] qemu-iotests: add a "how to" to ./README

On Mon, Jul 31, 2017 at 05:26:41PM +0100, Stefan Hajnoczi wrote: > There is not much getting started documentation for qemu-iotests. This > patch explains how to create a new test and covers the overall testing > approach. > > Cc: Ishani Chugh > Reviewed-by:

Re: [Qemu-devel] [RFC 04/29] bitmap: introduce bitmap_invert()

* Peter Xu (pet...@redhat.com) wrote: > It is used to invert the whole bitmap. Would it be easier to change bitmap_complement to use ^ in it's macro and slow_bitmap_complement, and then you could call it with src==dst to do the same thing with just that small change? Dave > Signed-off-by:

Re: [Qemu-devel] [PATCH for-2.10 3/3] qdev: defer DEVICE_DEL event until instance_finalize()

On Wed, 26 Jul 2017 20:30:55 -0500 Michael Roth wrote: > DEVICE_DEL is currently emitted when a Device is unparented, as > opposed to when it is finalized. The main design motivation for this > seems to be that after unparent()/unrealize(), the Device is no > longer

Re: [Qemu-devel] [PATCH for-2.10 2/3] Revert "qdev: Free QemuOpts when the QOM path goes away"

On Mon, 31 Jul 2017 11:39:13 -0500 Michael Roth wrote: > Quoting Greg Kurz (2017-07-31 10:51:39) > > On Wed, 26 Jul 2017 20:30:54 -0500 > > Michael Roth wrote: > > > > > This reverts commit abed886ec60cf239a03515cf0b30fb11fa964c44. > > >

Re: [Qemu-devel] [RFC 03/29] io: fix qio_channel_socket_accept err handling

* Peter Xu (pet...@redhat.com) wrote: > When accept failed, we should setup errp with the reason. More > importantly, the caller may assume errp be non-NULL when error happens, > and not setting the errp may crash QEMU. > > Signed-off-by: Peter Xu > --- > io/channel-socket.c

Re: [Qemu-devel] [RFC 02/29] migration: fix comment disorder in RAMState

* Peter Xu (pet...@redhat.com) wrote: > Comments for "migration_dirty_pages" and "bitmap_mutex" are switched. > Fix it. > > Signed-off-by: Peter Xu Split this out, it can go in a trivial patch probably sooner. Reviewed-by: Dr. David Alan Gilbert > ---

Re: [Qemu-devel] [PATCH for-2.10 2/3] Revert "qdev: Free QemuOpts when the QOM path goes away"

Quoting Greg Kurz (2017-07-31 10:51:39) > On Wed, 26 Jul 2017 20:30:54 -0500 > Michael Roth wrote: > > > This reverts commit abed886ec60cf239a03515cf0b30fb11fa964c44. > > > > This patch originally addressed an issue where a DEVICE_DELETED > > event could be emitted

Re: [Qemu-devel] [PATCH v3 2/4] trace-events: fix code style: %# -> 0x%

31.07.2017 19:15, Eric Blake wrote: On 07/31/2017 11:01 AM, Vladimir Sementsov-Ogievskiy wrote: In trace format '#' flag of printf is forbidden. Fix it to '0x%'. This patch is created by the following: check that we have a problem find . -name trace-events | xargs grep '%#' | wc -l 56

Re: [Qemu-devel] [PATCH v3 00/13] qcow2: space preallocation and COW improvements

Hi, This series failed build test on FreeBSD host. Please find the details below. Message-id: 1501518125-29851-1-git-send-email-anton.nefe...@virtuozzo.com Subject: [Qemu-devel] [PATCH v3 00/13] qcow2: space preallocation and COW improvements Type: series === TEST SCRIPT BEGIN === #!/bin/sh #

Re: [Qemu-devel] [RFC 01/29] migration: fix incorrect postcopy recved_bitmap

* Peter Xu (pet...@redhat.com) wrote: > The bitmap setup during postcopy is incorrectly when the pgaes are huge > pages. Fix it. > > Signed-off-by: Peter Xu > --- > migration/postcopy-ram.c | 2 +- > migration/ram.c | 8 > migration/ram.h | 2 ++ >

Re: [Qemu-devel] [PATCH v2 1/2] trace: add TRACE__BACKEND_DSTATE()

On Mon, Jul 31, 2017 at 04:16:39PM +0100, Daniel P. Berrange wrote: > On Mon, Jul 31, 2017 at 03:07:17PM +0100, Stefan Hajnoczi wrote: > > diff --git a/scripts/tracetool/backend/dtrace.py > > b/scripts/tracetool/backend/dtrace.py > > index c6812b70a2..17f902cc62 100644 > > ---

Re: [Qemu-devel] [PATCH v2 2/2] trace: add trace_event_get_state_backends()

On Mon, Jul 31, 2017 at 06:09:56PM +0300, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > Code that checks dstate is unaware of SystemTap and LTTng UST dstate, so > > the following trace event will not fire when solely enabled by SystemTap > > or LTTng UST: > > > if

Re: [Qemu-devel] [PATCH v2] qemu-iotests: add a "how to" to ./README

On Thu, Jul 27, 2017 at 02:28:02PM +0200, Kevin Wolf wrote: > Am 25.07.2017 um 17:36 hat Stefan Hajnoczi geschrieben: > > There is not much getting started documentation for qemu-iotests. This > > patch explains how to create a new test and covers the overall testing > > approach. > > > > Cc:

[Qemu-devel] [PATCH v3] qemu-iotests: add a "how to" to ./README

There is not much getting started documentation for qemu-iotests. This patch explains how to create a new test and covers the overall testing approach. Cc: Ishani Chugh Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v3 0/4] trace-events: print 0x before hex numbers

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3 0/4] trace-events: print 0x before hex numbers Message-id: 20170731160135.12101-1-vsement...@virtuozzo.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH v3 13/13] iotest 134: test cluster-misaligned encrypted write

COW (even empty/zero) areas require encryption too Signed-off-by: Anton Nefedov --- tests/qemu-iotests/134 | 9 + tests/qemu-iotests/134.out | 10 ++ 2 files changed, 19 insertions(+) diff --git a/tests/qemu-iotests/134 b/tests/qemu-iotests/134

[Qemu-devel] [PATCH v3 12/13] iotest 190: test BDRV_REQ_ALLOCATE

Signed-off-by: Anton Nefedov --- tests/qemu-iotests/190 | 146 + tests/qemu-iotests/190.out | 50 tests/qemu-iotests/group | 1 + 3 files changed, 197 insertions(+) create mode 100755

[Qemu-devel] [PATCH v3 09/13] qcow2: move is_zero_sectors() up

To be used in the following commit without a forward declaration. Signed-off-by: Anton Nefedov --- block/qcow2.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index

[Qemu-devel] [PATCH v3 11/13] qcow2: allocate image space by-cluster

If COW areas of the newly allocated clusters are zeroes on the backing image: (even if preallocation feature is not used or it cannot detect if the image already reads as zeroes, e.g. writing to a hole / preallocated zero cluster) efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on

[Qemu-devel] [PATCH v3 08/13] qcow2: check space leak at the end of the image

From: Pavel Butsykin Preallocated space in the image may remain unused; the patch adds the functionality to identify and fix it in the qcow2_check to avoid wasting storage space on the host. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V.

[Qemu-devel] [PATCH v3 04/13] block: support BDRV_REQ_ALLOCATE in passthrough drivers

Support the flag if the underlying BDS supports it Signed-off-by: Anton Nefedov --- block/blkdebug.c | 3 ++- block/raw-format.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index c19ab28..ef2d764

[Qemu-devel] [PATCH v3 10/13] qcow2: skip writing zero buffers to empty COW areas

It can be detected that 1. COW alignment of a write request is zeroes 2. Respective areas on the underlying BDS already read as zeroes after being preallocated previously If both of these true, COW may be skipped Signed-off-by: Anton Nefedov ---

[Qemu-devel] [PATCH v3 06/13] qcow2: set inactive flag

Qcow2State and BlockDriverState flags have to be in sync Signed-off-by: Anton Nefedov --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 1939d9b..b11dc48 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2135,6

[Qemu-devel] [PATCH v3 07/13] qcow2: truncate preallocated space

From: "Denis V. Lunev" This could be done after calculation of the end of data and metadata in the qcow2 image. Signed-off-by: Denis V. Lunev Signed-off-by: Anton Nefedov --- block/qcow2.h | 3 +++ block/qcow2-cluster.c

[Qemu-devel] [PATCH v3 01/13] block: introduce BDRV_REQ_ALLOCATE flag

The flag is supposed to indicate that the region of the disk image has to be sufficiently allocated so it reads as zeroes. The call with the flag set has to return -ENOTSUP if allocation cannot be done efficiently (i.e. without falling back to writing actual buffers) Signed-off-by: Anton Nefedov

[Qemu-devel] [PATCH v3 05/13] qcow2: preallocation at image expand

From: "Denis V. Lunev" This patch adds image preallocation at expand to provide better locality of QCOW2 image file and optimize this procedure for some distributed storage where this procedure is slow. Preallocation is not issued upon writing metadata clusters. Possible

[Qemu-devel] [PATCH v3 00/13] qcow2: space preallocation and COW improvements

Here goes a revisited series on qcow2 preallocation. It's probably a bit better integrated this time and the amount of code is reduced significantly. Changes in v3: - requests intersection detection from the previous versions is removed from qcow2 driver. Instead, tracked request

[Qemu-devel] [PATCH v3 03/13] file-posix: support BDRV_REQ_ALLOCATE

Current write_zeroes implementation is good enough to satisfy this flag too Signed-off-by: Anton Nefedov --- block/file-posix.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index cfbb236..bd52b31

[Qemu-devel] [PATCH v3 02/13] block: treat BDRV_REQ_ALLOCATE as serialising

The idea is that ALLOCATE requests may overlap with other requests. Reuse the existing block layer infrastructure for serialising requests. Use the following approach: - mark ALLOCATE serialising, so subsequent requests to the area wait - ALLOCATE request itself must never wait if another

Re: [Qemu-devel] [PATCH v3 2/4] trace-events: fix code style: %# -> 0x%

On 07/31/2017 11:01 AM, Vladimir Sementsov-Ogievskiy wrote: > In trace format '#' flag of printf is forbidden. Fix it to '0x%'. > > This patch is created by the following: > > check that we have a problem >> find . -name trace-events | xargs grep '%#' | wc -l > 56 > > check that there are no

[Qemu-devel] [PATCH v3 2/4] trace-events: fix code style: %# -> 0x%

In trace format '#' flag of printf is forbidden. Fix it to '0x%'. This patch is created by the following: check that we have a problem > find . -name trace-events | xargs grep '%#' | wc -l 56 check that there are no cases with additional printf flags before '#' > find . -name trace-events |

Re: [Qemu-devel] [PATCH v3 1/4] coding_style: add point about 0x in trace-events

On 07/31/2017 11:01 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > CODING_STYLE | 35 +++ > 1 file changed, 35 insertions(+) > Reviewed-by: Eric Blake -- Eric Blake,

Re: [Qemu-devel] QEMU NVDIMM as type 7 in e820 table

On Mon, 31 Jul 2017 09:48:08 -0600 Ross Zwisler wrote: > On Sat, Jul 29, 2017 at 06:49:33PM +0800, Haozhong Zhang wrote: > > On 07/28/17 13:45 -0600, Ross Zwisler wrote: > > > On Fri, Jul 28, 2017 at 11:11:10AM -0700, Dan Williams wrote: > > > > On Fri, Jul 28,

Re: [Qemu-devel] [PATCH v3] docs: add qemu-block-drivers(7) man page

Am 31.07.2017 um 17:56 hat Eric Blake geschrieben: > On 07/26/2017 08:03 AM, Stefan Hajnoczi wrote: > > Block driver documentation is available in qemu-doc.html. It would be > > convenient to have documentation for formats, protocols, and filter > > drivers in a man page. > > > > Extract the

[Qemu-devel] [PATCH v3 4/4] trace-events: fix code style: print 0x before hex numbers

The only exception are groups of numers separated by symbols '.', ' ', ':', '/', like 'ab.09.7d'. This patch is made by the following: > find . -name trace-events | xargs python script.py where script.py is the following python script: = #!/usr/bin/env python import

[Qemu-devel] [PATCH v3 1/4] coding_style: add point about 0x in trace-events

Signed-off-by: Vladimir Sementsov-Ogievskiy --- CODING_STYLE | 35 +++ 1 file changed, 35 insertions(+) diff --git a/CODING_STYLE b/CODING_STYLE index 2fa0c0b65b..12ba58ee29 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -123,3 +123,38

[Qemu-devel] [PATCH v3 0/4] trace-events: print 0x before hex numbers

Hi all! It is hard to read logs, when there are hex and dec numbers in one line, when hex number doesn't contain any letters and don't have '0x' prefix. So, here is a complete solution for the problem: - add information into CODING_STYLE - add a check into checkpatch.pl - fix current state The

[Qemu-devel] [PATCH v3 3/4] checkpatch: check trace-events code style

According to CODING_STYLE, check that in trace-events: 1. hex numbers are prefixed with '0x' 2. '#' flag of printf is not used 3. The exclusion from 1. are period-separated groups of numbers Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v3] docs: add qemu-block-drivers(7) man page

On 07/26/2017 08:03 AM, Stefan Hajnoczi wrote: > Block driver documentation is available in qemu-doc.html. It would be > convenient to have documentation for formats, protocols, and filter > drivers in a man page. > > Extract the relevant part of qemu-doc.html into a new file called >

  1   2   3   >