[Qemu-devel] [PATCH 5/5] openrisc: Only kick cpu on timeout, not on update

2017-08-22 Thread Stafford Horne
Previously we were kicking the cpu on every update. This caused problems noticeable in SMP configurations where one CPU got pinned continuously servicing timer exceptions. Signed-off-by: Stafford Horne --- hw/openrisc/cputimer.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH 1/5] openrisc/ompic: Add OpenRISC Multicore PIC (OMPIC)

2017-08-22 Thread Stafford Horne
Add OpenRISC Multicore PIC which handles inter processor interrupts (IPI) between cores. In OpenRISC all device interrupts are routed to each core enabling this device to be simple. Signed-off-by: Stafford Horne --- default-configs/or1k-softmmu.mak | 1 +

[Qemu-devel] [PATCH 0/5] OpenRISC SMP Support

2017-08-22 Thread Stafford Horne
Hello, This series adds SMP support for OpenRISC. The platform is based on the work that Stefan Kristiansson did around 2012 implemented in Verilog and run on FPGAs. I have been working to upstream this work, these are my QEMU patches I have been used to help with testing. I have documented

Re: [Qemu-devel] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

2017-08-22 Thread Thomas Huth
On 23.08.2017 02:10, Philippe Mathieu-Daudé wrote: > On 08/22/2017 07:42 PM, Michael S. Tsirkin wrote: >> On Tue, Aug 22, 2017 at 06:43:43PM -0300, Philippe Mathieu-Daudé wrote: >>> 9e047b982452 "piix4: add acpi pci hotplug support" introduced a new >>> property >>> 'use_acpi_pci_hotplug' for

Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-22 Thread Thomas Huth
On 22.08.2017 20:15, KONRAD Frederic wrote: > Hi Thomas, > > Looking to this seems there is a second issue: > The aux-to-i2c-bridge device should connect on a TYPE_AUX_BUS. > > I don't think there isn't any on integratorcp.. > > Anyway the patch you sent fix this issue indirectly and as far as

Re: [Qemu-devel] [PATCH 07/10] io: add qio_channel_read/write_all

2017-08-22 Thread Fam Zheng
On Tue, 08/22 15:18, Paolo Bonzini wrote: > It is pretty common to read a fixed-size buffer from a socket. Add a > function that does this, either with multiple reads (on blocking sockets) > or by yielding if called from a coroutine. > > Cc: Daniel P. Berrange >

Re: [Qemu-devel] [PATCH 09/10] scsi: add multipath support to qemu-pr-helper

2017-08-22 Thread Fam Zheng
On Tue, 08/22 15:18, Paolo Bonzini wrote: > Proper support of persistent reservation for multipath devices requires > communication with the multipath daemon, so that the reservation is > registered and applied when a path comes up. The device mapper > utilities provide a library to do so; this

Re: [Qemu-devel] [PATCH 10/10] scsi: add persistent reservation manager using qemu-pr-helper

2017-08-22 Thread Fam Zheng
On Tue, 08/22 15:18, Paolo Bonzini wrote: > This adds a concrete subclass of pr-manager that talks to qemu-pr-helper. > > Signed-off-by: Paolo Bonzini > --- > scsi/Makefile.objs | 2 +- > scsi/pr-manager-helper.c | 288 >

Re: [Qemu-devel] [Qemu-arm] [RFC v6 8/9] hw/arm/smmuv3: VFIO integration

2017-08-22 Thread Linu Cherian
Hi Eric, On Fri Aug 11, 2017 at 04:22:33PM +0200, Eric Auger wrote: > This patch allows doing PCIe passthrough with a guest exposed > with a vSMMUv3. It implements the replay and notify_flag_changed > iommu ops. Also on TLB and data structure invalidation commands, > we replay the mappings so

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-22 Thread David Gibson
On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. > This is not a full implementation yet with a lot of components still > missing but enough to start a Linux kernel and the U-Boot firmware. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management

2017-08-22 Thread Fam Zheng
On Tue, 08/22 15:18, Paolo Bonzini wrote: > diff --git a/docs/pr-manager.rst b/docs/pr-manager.rst Is docs/interop/persistent-reservation-manager.rst better? (Move to interop/ and de-abbreviate) ... > new file mode 100644 > index 00..b6089fb57c > --- /dev/null > +++ b/docs/pr-manager.rst

Re: [Qemu-devel] [PATCH v4 0/2] hw/acpi-build: Fix ACPI SRAT Memory Affinity building

2017-08-22 Thread Dou Liyang
Hi Michael, At 08/23/2017 10:48 AM, Michael S. Tsirkin wrote: On Tue, Aug 22, 2017 at 11:24:08AM +0800, Dou Liyang wrote: V3 --> v4: -add a new testcase. This patchset fixs an ACPI building bug which caused by no RAM in the first NUAM node. and also add a new testcase for the bug. thanks!

Re: [Qemu-devel] [PATCH 13/15] ppc4xx: Add more PLB registers

2017-08-22 Thread David Gibson
On Sun, Aug 20, 2017 at 06:58:52PM -0300, Philippe Mathieu-Daudé wrote: > Hi Zoltan, > > On 08/20/2017 02:23 PM, BALATON Zoltan wrote: > > These registers are present in 440 SoCs (and maybe in others too) and > > U-Boot accesses them when printing register info. We don't emulate > > these but add

Re: [Qemu-devel] [PATCH 14/15] ppc4xx: Add device models found in PPC440 core SoCs

2017-08-22 Thread David Gibson
On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > These devices are found in newer SoCs based on 440 core e.g. the 460EX > (http://www.embeddeddeveloper.com/assets/processors/amcc/datasheets/ > PP460EX_DS2063.pdf) As usual, I can't review in depth, but there's not much obviously

Re: [Qemu-devel] [PATCH 11/15] ppc: Add 460EX embedded CPU

2017-08-22 Thread David Gibson
On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > Despite its name it is a 440 core CPU As I recall 460 was supposed to be a 440 with SMP support. Except they screwed up the cache coherence, so it's basically unusable for SMP (at least with Linux). They finally got 440 SMP right

Re: [Qemu-devel] [PATCH 13/15] ppc4xx: Add more PLB registers

2017-08-22 Thread David Gibson
On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > These registers are present in 440 SoCs (and maybe in others too) and > U-Boot accesses them when printing register info. We don't emulate > these but add them to avoid crashing when they are read or written. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 12/15] ppc4xx: Export ECB and PLB emulation

2017-08-22 Thread David Gibson
On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > Make these device models available outside ppc405_uc.c for reuse in > 460EX emulation. They are left in their current place for now because > they are used mostly unchanged and I'm not sure these correctly model > the components in

Re: [Qemu-devel] [PATCH v4 0/2] hw/acpi-build: Fix ACPI SRAT Memory Affinity building

2017-08-22 Thread Michael S. Tsirkin
On Tue, Aug 22, 2017 at 11:24:08AM +0800, Dou Liyang wrote: > V3 --> v4: > -add a new testcase. > > This patchset fixs an ACPI building bug which caused by no RAM > in the first NUAM node. and also add a new testcase for the bug. thanks! Pls remember to ping or repost after release is out. >

Re: [Qemu-devel] [PATCH v7 0/4] Generic PCIE-PCI Bridge

2017-08-22 Thread Michael S. Tsirkin
On Tue, Aug 22, 2017 at 02:43:39PM +0300, Marcel Apfelbaum wrote: > On 18/08/2017 2:36, Aleksandr Bezzubikov wrote: > > This series introduces a new device - Generic PCI Express to PCI bridge, > > and also makes all necessary changes to enable hotplug of the bridge itself > > and any device into

Re: [Qemu-devel] Why I got "timeout" while using qga socket to connect VM?

2017-08-22 Thread Sam
Hi all, I start VM using command like this: -chardev socket,path=/home/gangyewei-3/kvm/qga.sock,server,nowait,id=qga0 > -device virtio-serial -device virtserialport,chardev=qga0, > name=org.qemu.guest_agent.0 But When I use socat to send command (https://wiki.qemu.org/ Features/GuestAgent), it

Re: [Qemu-devel] [PATCH] migration: Report when bdrv_inactivate_all fails

2017-08-22 Thread Peter Xu
On Tue, Aug 22, 2017 at 06:02:12PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > If the bdrv_inactivate_all fails near the end of the migration, > the migration will fail and often the only diagnostics in the log > are an I/O error which you

Re: [Qemu-devel] [PATCH for-2.11 01/27] sparc: convert cpu models to SPARC cpu subclasses

2017-08-22 Thread Philippe Mathieu-Daudé
On 08/18/2017 07:08 AM, Igor Mammedov wrote: QOMfy cpu models handling introducing propper cpu types for each cpu model. Signed-off-by: Igor Mammedov --- with this and conversion of features to properties, it would be possible to replace cpu_sparc_init() with

Re: [Qemu-devel] [PATCH 10/15] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

2017-08-22 Thread David Gibson
On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > This is the PCIX controller found in newer 440 core SoCs e.g. the AMMC > 460EX. The device tree refers to this as plb-pcix compared to the > plb-pci controller in older 440 SoCs. > > Signed-off-by: BALATON Zoltan

Re: [Qemu-devel] [PATCH 09/15] hw/ide: Emulate SiI3112 SATA controller

2017-08-22 Thread David Gibson
On Tue, Aug 22, 2017 at 03:01:18PM -0400, John Snow wrote: > > > On 08/22/2017 07:08 AM, BALATON Zoltan wrote: > > Hello, > > > > Thanks for the review. > > > > On Mon, 21 Aug 2017, John Snow wrote: > >> On 08/20/2017 01:23 PM, BALATON Zoltan wrote: > >>> This is a common generic PCI SATA

Re: [Qemu-devel] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board

2017-08-22 Thread BALATON Zoltan
On Wed, 23 Aug 2017, David Gibson wrote: On Tue, Aug 22, 2017 at 01:18:02PM +0200, BALATON Zoltan wrote: On Tue, 22 Aug 2017, David Gibson wrote: On Fri, Aug 18, 2017 at 02:46:42PM +0200, BALATON Zoltan wrote: On Fri, 18 Aug 2017, David Gibson wrote: On Sun, Aug 13, 2017 at 07:04:38PM +0200,

Re: [Qemu-devel] [PATCH v3 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2017-08-22 Thread David Gibson
On Mon, Aug 21, 2017 at 02:40:17PM +0530, Aravinda Prasad wrote: > > > On Thursday 17 August 2017 09:05 AM, Sam Bobroff wrote: > > On Wed, Aug 16, 2017 at 02:41:59PM +0530, Aravinda Prasad wrote: > >> This series of patches adds support for FWNMI in PowerKVM guests. > >> > >> Memory error such

Re: [Qemu-devel] [PATCH v2] target/ppc: 'PVR != host PVR' in KVM_SET_SREGS workaround

2017-08-22 Thread David Gibson
On Tue, Aug 22, 2017 at 09:23:26AM -0300, Daniel Henrique Barboza wrote: > v2: > - added Laurent's fix in 'kvmppc_pvr_workaround_required' to avoid > returning true when running with TCG. Thanks, but I already altered this inline. I made a slight change, so that we check for kvm enabled before

[Qemu-devel] [PULL 5/7] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

2017-08-22 Thread David Gibson
From: Thomas Huth QEMU currently crashes when trying to use a 'pc-dimm' on the pseries machine without specifying its 'memdev' property. This happens because pc_dimm_get_memory_region() does not check whether the 'memdev' property has properly been set by the user. Looking

Re: [Qemu-devel] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board

2017-08-22 Thread David Gibson
On Tue, Aug 22, 2017 at 01:18:02PM +0200, BALATON Zoltan wrote: > On Tue, 22 Aug 2017, David Gibson wrote: > > On Fri, Aug 18, 2017 at 02:46:42PM +0200, BALATON Zoltan wrote: > > > On Fri, 18 Aug 2017, David Gibson wrote: > > > > On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: > >

[Qemu-devel] [PULL 1/7] boot-serial-test: prefer tcg accelerator

2017-08-22 Thread David Gibson
From: Cornelia Huck Prefer to use the tcg accelarator if it is available: This is our only real smoke test for tcg, and fast enough to use it for that. Fixes: 480bc11e6 ("boot-serial-test: fallback to kvm accelerator") Reported-by: Richard Henderson

[Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170823

2017-08-22 Thread David Gibson
The following changes since commit 1f296733876434118fd766cfef5eb6f29ecab6a8: Update version for v2.10.0-rc3 release (2017-08-15 18:53:31 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.10-20170823 for you to fetch changes up to

Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822

2017-08-22 Thread David Gibson
On Tue, Aug 22, 2017 at 11:52:00AM +0100, Peter Maydell wrote: > On 22 August 2017 at 11:41, Laurent Vivier wrote: > > On 22/08/2017 11:53, Peter Maydell wrote: > >> On 22 August 2017 at 10:43, Laurent Vivier wrote: > >>> On 22/08/2017 11:34, Peter Maydell

[Qemu-devel] [PULL 3/7] ppc: fix ppc_set_compat() with KVM PR

2017-08-22 Thread David Gibson
From: Greg Kurz When running in KVM PR mode, kvmppc_set_compat() always fail because the current PR implementation doesn't handle KVM_REG_PPC_ARCH_COMPAT. Now that the machine code inconditionally calls ppc_set_compat_all() at reset time to restore the compat mode default value

Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator

2017-08-22 Thread David Gibson
On Tue, Aug 22, 2017 at 01:48:15PM +0200, Cornelia Huck wrote: > On Tue, 22 Aug 2017 21:20:46 +1000 > David Gibson wrote: > > > Obviously it's not a thing to fix right now, but I've really been > > thinking that none of the tests should use this "TCG or KVM" stuff. >

[Qemu-devel] [PULL 7/7] hw/ppc/spapr_iommu: Fix crash when removing the "spapr-tce-table" device

2017-08-22 Thread David Gibson
From: Thomas Huth QEMU currently aborts unexpectedly when the user tries to add and remove a "spapr-tce-table" device: $ qemu-system-ppc64 -nographic -S -nodefaults -monitor stdio QEMU 2.9.92 monitor - type 'help' for more information (qemu) device_add spapr-tce-table,id=x

[Qemu-devel] [PULL 6/7] hw/ppc/spapr_rtc: Mark the RTC device with user_creatable = false

2017-08-22 Thread David Gibson
From: Thomas Huth QEMU currently aborts unexpectedly when a user tries to do something like this: $ qemu-system-ppc64 -nographic -S -nodefaults -monitor stdio QEMU 2.9.92 monitor - type 'help' for more information (qemu) device_add spapr-rtc,id=spapr-rtc (qemu) device_del

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-22 Thread David Gibson
On Tue, Aug 22, 2017 at 08:50:44PM -0300, Daniel Henrique Barboza wrote: > > > On 08/18/2017 01:14 AM, David Gibson wrote: > > On Thu, Aug 17, 2017 at 06:31:28PM -0300, Daniel Henrique Barboza wrote: > > > > > > On 08/17/2017 04:52 AM, David Gibson wrote: > > > > On Tue, Aug 15, 2017 at

[Qemu-devel] [PULL 2/7] target/ppc: 'PVR != host PVR' in KVM_SET_SREGS workaround

2017-08-22 Thread David Gibson
From: Daniel Henrique Barboza Commit d5fc133eed ("ppc: Rework CPU compatibility testing across migration") changed the way cpu_post_load behaves with the PVR setting, causing an unexpected bug in KVM-HV migrations between hosts that are compatible (POWER8 and

[Qemu-devel] [PULL 4/7] spapr: Allow configure-connector to be called multiple times

2017-08-22 Thread David Gibson
From: Bharata B Rao In case of in-kernel memory hot unplug, when the guest is not able to remove all the LMBs that are requested for removal, it will add back any LMBs that have been successfully removed. The DR Connectors of these LMBs wouldn't have been unconfigured

Re: [Qemu-devel] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

2017-08-22 Thread Philippe Mathieu-Daudé
On 08/22/2017 07:42 PM, Michael S. Tsirkin wrote: On Tue, Aug 22, 2017 at 06:43:43PM -0300, Philippe Mathieu-Daudé wrote: 9e047b982452 "piix4: add acpi pci hotplug support" introduced a new property 'use_acpi_pci_hotplug' for pc-1.7 and older machines. c24d5e0b91d1 "convert ACPI PCI hotplug to

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-22 Thread Daniel Henrique Barboza
On 08/18/2017 01:14 AM, David Gibson wrote: On Thu, Aug 17, 2017 at 06:31:28PM -0300, Daniel Henrique Barboza wrote: On 08/17/2017 04:52 AM, David Gibson wrote: On Tue, Aug 15, 2017 at 05:28:46PM -0300, Daniel Henrique Barboza wrote: This patch is a follow up on the discussions that

Re: [Qemu-devel] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

2017-08-22 Thread Michael S. Tsirkin
On Tue, Aug 22, 2017 at 06:43:43PM -0300, Philippe Mathieu-Daudé wrote: > 9e047b982452 "piix4: add acpi pci hotplug support" introduced a new property > 'use_acpi_pci_hotplug' for pc-1.7 and older machines. > c24d5e0b91d1 "convert ACPI PCI hotplug to use hotplug-handler API" added the > qbus

[Qemu-devel] Generic PCIE-PCI Bridge GSoC Project Report

2017-08-22 Thread Aleksandr Bezzubikov
Hi, I'm a GSoC student and I have completed my project "Generic PCIE-PCI Bridge". Its aim was to create a new device to replace existing DMI-PCI bridge as it isn't cross-platform and doesn't support hotplugging. By completing this project next goals were achieved: 1. Introduce a brand new

Re: [Qemu-devel] Use after free problem somewhere in ahci.c or ich.c code

2017-08-22 Thread John Snow
On 08/22/2017 05:02 PM, Philippe Mathieu-Daudé wrote: > On 08/22/2017 03:39 PM, John Snow wrote: >> On 08/22/2017 02:15 PM, Thomas Huth wrote: >>> >>> Looks like there is a use-after-free problem somewhere in >>> the ahci.c or ich.c code when trying to add the ich9-ahci >>> on a old PC machine.

Re: [Qemu-devel] [PATCH 09/15] hw/ide: Emulate SiI3112 SATA controller

2017-08-22 Thread BALATON Zoltan
On Tue, 22 Aug 2017, John Snow wrote: On 08/22/2017 04:15 PM, BALATON Zoltan wrote: On Tue, 22 Aug 2017, John Snow wrote: On 08/22/2017 07:08 AM, BALATON Zoltan wrote: On Mon, 21 Aug 2017, John Snow wrote: Sure, but be advised that if the device causes problems outside of this use case and

[Qemu-devel] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

2017-08-22 Thread Philippe Mathieu-Daudé
9e047b982452 "piix4: add acpi pci hotplug support" introduced a new property 'use_acpi_pci_hotplug' for pc-1.7 and older machines. c24d5e0b91d1 "convert ACPI PCI hotplug to use hotplug-handler API" added the qbus hotplug handlers but forgot to check for the 'use_acpi_pci_hotplug' property. Check

Re: [Qemu-devel] Use after free problem somewhere in ahci.c or ich.c code

2017-08-22 Thread Philippe Mathieu-Daudé
On 08/22/2017 03:39 PM, John Snow wrote: On 08/22/2017 02:15 PM, Thomas Huth wrote: Looks like there is a use-after-free problem somewhere in the ahci.c or ich.c code when trying to add the ich9-ahci on a old PC machine. Using valgrind, I get: those old PC don't support AHCI hotplug, so

Re: [Qemu-devel] [PATCH 09/15] hw/ide: Emulate SiI3112 SATA controller

2017-08-22 Thread John Snow
On 08/22/2017 04:15 PM, BALATON Zoltan wrote: > On Tue, 22 Aug 2017, John Snow wrote: >> On 08/22/2017 07:08 AM, BALATON Zoltan wrote: >>> On Mon, 21 Aug 2017, John Snow wrote: >> >> Sure, but be advised that if the device causes problems outside of this >> use case and there's nobody willing or

Re: [Qemu-devel] [PATCH 09/15] hw/ide: Emulate SiI3112 SATA controller

2017-08-22 Thread BALATON Zoltan
On Tue, 22 Aug 2017, John Snow wrote: On 08/22/2017 07:08 AM, BALATON Zoltan wrote: Hello, Thanks for the review. On Mon, 21 Aug 2017, John Snow wrote: On 08/20/2017 01:23 PM, BALATON Zoltan wrote: This is a common generic PCI SATA conroller that is also used in PCs but more importantly

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
With the patch from Stefan and your debug applied source and target I still run into the same issue I'd say. Id's are slightly off, but they are different on every try anyway. Still looks the same for me: bdrv_inactivate_recurse: entry for drive-virtio-disk0 bdrv_inactivate_recurse: entry for

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-22 Thread Eduardo Habkost
(CCing Cleber and Stefan) On Tue, Aug 22, 2017 at 07:19:45AM -0300, Philippe Mathieu-Daudé wrote: [...] > Can we predict how the python scripts will evolve? Only fast-testing? > I guess it depends on how you define "fast". Does "fast-testing" include a full device-crash-test run (that could

[Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-22 Thread John Snow
Well, we knew we'd want this sooner or later. I've got some pings downstream over whether or not we support persistent bitmaps for non-qcow2 formats. Currently: no, we don't. We tried two different ideas for storage agnostic bitmap persistence: (1) Using qcow2 as a storage container format

Re: [Qemu-devel] [PATCH v2 2/2] Add a unique ID in the virt machine to be used as device ID

2017-08-22 Thread Michael S. Tsirkin
On Tue, Aug 22, 2017 at 03:13:57PM +, Diana Madalina Craciun wrote: > On 08/11/2017 06:50 PM, Edgar E. Iglesias wrote: > > On Fri, Aug 11, 2017 at 02:35:28PM +, Diana Madalina Craciun wrote: > >> Hi Edgar, > >> > >> On 07/31/2017 06:16 PM, Edgar E. Iglesias wrote: > >>> On Wed, Jul 26,

Re: [Qemu-devel] [PATCH 1/9] IDE: replace DEBUG_IDE with tracing system

2017-08-22 Thread John Snow
On 08/08/2017 04:00 PM, Eric Blake wrote: > On 08/08/2017 01:32 PM, John Snow wrote: >> Out with the old, in with the new. >> >> Signed-off-by: John Snow >> --- > >> hw/ide/piix.c | 11 >> hw/ide/trace-events | 33 >>

Re: [Qemu-devel] [PATCH 09/15] hw/ide: Emulate SiI3112 SATA controller

2017-08-22 Thread John Snow
On 08/22/2017 07:08 AM, BALATON Zoltan wrote: > Hello, > > Thanks for the review. > > On Mon, 21 Aug 2017, John Snow wrote: >> On 08/20/2017 01:23 PM, BALATON Zoltan wrote: >>> This is a common generic PCI SATA conroller that is also used in PCs >>> but more importantly guests running on the

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-22 Thread Eduardo Habkost
On Tue, Aug 22, 2017 at 09:24:16AM +0200, Markus Armbruster wrote: > John Snow writes: > > > On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > >> Hello guys, > >> > >> I'm reading the available python modules to exercise qemu and while > >> reading them > >> I fixed some issues

Re: [Qemu-devel] [PATCH v2 53/54] qapi: make query-cpu-model-expansion depend on s390 or x86

2017-08-22 Thread Eduardo Habkost
On Tue, Aug 22, 2017 at 03:22:54PM +0200, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 4 +++- > include/sysemu/arch_init.h | 3 --- > monitor.c | 3 --- >

Re: [Qemu-devel] Use after free problem somewhere in ahci.c or ich.c code

2017-08-22 Thread John Snow
On 08/22/2017 02:15 PM, Thomas Huth wrote: > > Hi! > > Looks like there is a use-after-free problem somewhere in > the ahci.c or ich.c code when trying to add the ich9-ahci > on a old PC machine. Using valgrind, I get: > I'll look; it looks like it works okay for pc-i440fx-2.9 as well as

Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-22 Thread KONRAD Frederic
Hi Thomas, Looking to this seems there is a second issue: The aux-to-i2c-bridge device should connect on a TYPE_AUX_BUS. I don't think there isn't any on integratorcp.. Anyway the patch you sent fix this issue indirectly and as far as I remember I wasn't able to make this I2C bridge an

[Qemu-devel] Use after free problem somewhere in ahci.c or ich.c code

2017-08-22 Thread Thomas Huth
Hi! Looks like there is a use-after-free problem somewhere in the ahci.c or ich.c code when trying to add the ich9-ahci on a old PC machine. Using valgrind, I get: $ valgrind x86_64-softmmu/qemu-system-x86_64 -M pc-1.2 -nographic -S ==6604== Memcheck, a memory error detector ==6604== Copyright

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-22 Thread John Snow
On 08/22/2017 03:24 AM, Markus Armbruster wrote: > John Snow writes: > >> On 08/18/2017 10:26 AM, Lukáš Doktor wrote: >>> Hello guys, >>> >>> I'm reading the available python modules to exercise qemu and while reading >>> them >>> I fixed some issues that caught my

Re: [Qemu-devel] [PATCH v2 06/54] qapi: introduce qapi_enum_lookup()

2017-08-22 Thread John Snow
On 08/22/2017 09:22 AM, Marc-André Lureau wrote: > This will help with the introduction of a new structure to handle > enum lookup. > Procedurally for the sake of review, it's a little odd to introduce the function, deploy it, and then change it and update all callers. content-wise, I'm

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

2017-08-22 Thread Michael S. Tsirkin
On Tue, Aug 22, 2017 at 10:56:59AM -0600, Alex Williamson wrote: > On Tue, 22 Aug 2017 15:04:55 +0800 > Bob Chen wrote: > > > Hi, > > > > I got a spec from Nvidia which illustrates how to enable GPU p2p in > > virtualization environment. (See attached) > > Neat, looks

Re: [Qemu-devel] [PATCH v1 0/5] Expose the secure property to the machine

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 18:57, Alistair Francis wrote: > On Tue, Aug 22, 2017 at 10:24 AM, Edgar E. Iglesias > wrote: >> On Thu, Aug 17, 2017 at 11:51:59AM -0700, Alistair Francis wrote: >>> The EL2 and EL3 work is working well now and

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
I didn't add Stefans patch yet. Note: the Mentioned patch is at: Note: http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg04027.html With your debug patch applied I get: 2017-08-22 17:57:04.486+: initiating migration bdrv_inactivate_recurse: entry for drive-virtio-disk0

Re: [Qemu-devel] [PATCH] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

2017-08-22 Thread Stefano Stabellini
On Tue, 22 Aug 2017, Ross Lagerwall wrote: > On 08/21/2017 11:30 PM, Stefano Stabellini wrote: > > On Mon, 21 Aug 2017, Ross Lagerwall wrote: > > > When the guest writes to the RTC, Xen emulates it and broadcasts a > > > TIMEOFFSET ioreq. Emit an RTC_CHANGE QMP message when this happens > > >

Re: [Qemu-devel] [PATCH v1 0/5] Expose the secure property to the machine

2017-08-22 Thread Alistair Francis
On Tue, Aug 22, 2017 at 10:24 AM, Edgar E. Iglesias wrote: > On Thu, Aug 17, 2017 at 11:51:59AM -0700, Alistair Francis wrote: >> The EL2 and EL3 work is working well now and interanlly we now have >> tests that expect to start in EL3 and transition through EL2 to EL1.

Re: [Qemu-devel] [PATCH] qobject: Explain how QNum works, and why

2017-08-22 Thread Max Reitz
On 2017-08-22 08:52, Markus Armbruster wrote: > Suggested-by: Max Reitz > Signed-off-by: Markus Armbruster > --- > include/qapi/qmp/qnum.h | 21 + > 1 file changed, 21 insertions(+) Thanks again! Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH] hw/arm/aspeed_soc: Mark devices as user_creatable = false

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 13:47, Thomas Huth wrote: > QEMU currently aborts if the user is accidentially trying to > do something like this: > > $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic > QEMU 2.9.93 monitor - type 'help' for more information > (qemu)

Re: [Qemu-devel] [PATCH v2] hw/arm/digic: Mark device with user_creatable = false

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 15:30, Thomas Huth wrote: > QEMU currently shows some unexpected behavior when the user trys to > do a "device_add digic" on an unrelated ARM machine like integratorcp > in "-nographic" mode (the device_add command does not immediately > return to the

Re: [Qemu-devel] [PATCH v1 2/5] xlnx-zcu102: Manually create the machines

2017-08-22 Thread Edgar E. Iglesias
On Thu, Aug 17, 2017 at 11:52:04AM -0700, Alistair Francis wrote: > In preperation for future work let's manually create the Xilnx machines. > This will allow us to set properties for the machines in the future. > > Signed-off-by: Alistair Francis > --- > >

Re: [Qemu-devel] [PATCH v1 0/5] Expose the secure property to the machine

2017-08-22 Thread Edgar E. Iglesias
On Thu, Aug 17, 2017 at 11:51:59AM -0700, Alistair Francis wrote: > The EL2 and EL3 work is working well now and interanlly we now have > tests that expect to start in EL3 and transition through EL2 to EL1. To > make this easy to run let's expose the secure property to the machine > and then use

Re: [Qemu-devel] QEMU -> Github Exporter down?

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 18:04, Sean Bruno wrote: > > > On 08/22/17 10:57, Peter Maydell wrote: >> On 22 August 2017 at 17:52, Sean Bruno wrote: >>> I note that there hasn't been any updates to the github copy of the main >>> project repo. Just curious if I

Re: [Qemu-devel] [PATCH v7 0/4] Add shrink image for qcow2

2017-08-22 Thread Max Reitz
On 2017-08-22 01:31, John Snow wrote: > > > On 08/17/2017 05:15 AM, Pavel Butsykin wrote: >> This patch add shrinking of the image file for qcow2. As a result, this >> allows >> us to reduce the virtual image size and free up space on the disk without >> copying the image. Image can be

Re: [Qemu-devel] QEMU -> Github Exporter down?

2017-08-22 Thread Sean Bruno
On 08/22/17 10:57, Peter Maydell wrote: > On 22 August 2017 at 17:52, Sean Bruno wrote: >> I note that there hasn't been any updates to the github copy of the main >> project repo. Just curious if I missed a thing or if someone can go >> look to see what's up. > > Hmm?

[Qemu-devel] [PATCH] migration: Report when bdrv_inactivate_all fails

2017-08-22 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" If the bdrv_inactivate_all fails near the end of the migration, the migration will fail and often the only diagnostics in the log are an I/O error which you can't distinguish from an error on the socket connection. Add an error so we know when

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

2017-08-22 Thread Alex Williamson
On Tue, 22 Aug 2017 15:04:55 +0800 Bob Chen wrote: > Hi, > > I got a spec from Nvidia which illustrates how to enable GPU p2p in > virtualization environment. (See attached) Neat, looks like we should implement a new QEMU vfio-pci option, something like

Re: [Qemu-devel] [PATCH 1/3] backup: QEMU Backup Tool

2017-08-22 Thread Ishani
- On Aug 22, 2017, at 7:43 PM, stefanha stefa...@redhat.com wrote: > On Mon, Aug 21, 2017 at 04:40:37PM +0530, Ishani Chugh wrote: >> qemu-backup will be a command-line tool for performing full and >> incremental disk backups on running VMs. It is intended as a >> reference implementation

Re: [Qemu-devel] [PATCH 00/26] qapi: add #if pre-processor conditions to generated code

2017-08-22 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Aug 17, 2017 at 3:55 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Hi, >>> >>> In order to clean-up some hacks in qapi (having to unregister commands >>> at

Re: [Qemu-devel] QEMU -> Github Exporter down?

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 17:52, Sean Bruno wrote: > I note that there hasn't been any updates to the github copy of the main > project repo. Just curious if I missed a thing or if someone can go > look to see what's up. Hmm? https://github.com/qemu/qemu has 1f29673 as its head,

Re: [Qemu-devel] [PATCH 07/26] qapi: add 'if' condition on top-level schema elements

2017-08-22 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Wed, Aug 16, 2017 at 5:43 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Add 'if' c-preprocessor condition on top-level schema elements: >>> struct, enum, union,

Re: [Qemu-devel] [RFC PATCH 12/56] pc-dimm: Make size and address unsigned in QAPI/QMP

2017-08-22 Thread Markus Armbruster
Igor Mammedov writes: > On Tue, 22 Aug 2017 15:50:14 +0200 > Markus Armbruster wrote: > >> Igor Mammedov writes: >> >> > On Mon, 7 Aug 2017 16:45:16 +0200 >> > Markus Armbruster wrote: >> > >> >> Sizes and

[Qemu-devel] QEMU -> Github Exporter down?

2017-08-22 Thread Sean Bruno
I note that there hasn't been any updates to the github copy of the main project repo. Just curious if I missed a thing or if someone can go look to see what's up. sean signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc3 is now available

2017-08-22 Thread Michael Roth
Quoting Peter Maydell (2017-08-22 11:20:18) > On 15 August 2017 at 22:04, Michael Roth wrote: > > Hello, > > > > On behalf of the QEMU Team, I'd like to announce the availability of the > > fourth release candidate for the QEMU 2.10 release. This release is meant > >

Re: [Qemu-devel] [PATCH v2 03/54] qobject: add literal qobject type

2017-08-22 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > Promote LiteralQObject from tests/check-qjson.c to qobject/qlit.c, >> > allowing to statically declare complex qobjects. >> > >> >

Re: [Qemu-devel] [PATCH] MAINTAINERS: update mail address for NVDIMM

2017-08-22 Thread Paolo Bonzini
On 22/08/2017 16:38, Xiao Guangrong wrote: > > [ CC Thomas. ] > > Ping. > > Thomas complained that the mail address does not work and the failed > notification is really annoyed. Could Paolo or Michael or anyone else > merge this patch please? I queued this. Paolo

Re: [Qemu-devel] [PATCH] nbd-client: avoid spurious qio_channel_yield() re-entry

2017-08-22 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > The following scenario leads to an assertion failure in > qio_channel_yield(): > > 1. Request coroutine calls qio_channel_yield() successfully when sending >would block on the socket. It is now yielded. > 2. nbd_read_reply_entry() calls

Re: [Qemu-devel] [PATCH v2 05/54] qapi: generate a literal qobject for introspection

2017-08-22 Thread Markus Armbruster
Marc-André Lureau writes: > Replace the generated json string with a literal qobject. The later is > easier to deal with, at run time as well as compile time: adding #if > conditionals will be easier than in a json string. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v2 01/54] qapi: fix type_seen key error

2017-08-22 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > The type_seen member can be of a different type than the 'qtype' being >> > checked, since a string create several conflicts. Lookup

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-22 Thread ChristianEhrhardt
Building with the attached debug patch ... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1711602 Title: --copy-storage-all failing with qemu 2.10 Status in QEMU: New Status in libvirt package

Re: [Qemu-devel] [PATCH v2 51/54] qapi: make s390 commands depend on TARGET_S390X

2017-08-22 Thread Markus Armbruster
David Hildenbrand writes: > On 22.08.2017 16:24, Cornelia Huck wrote: >> On Tue, 22 Aug 2017 15:22:52 +0200 >> Marc-André Lureau wrote: >> >>> Signed-off-by: Marc-André Lureau >>> --- >>> qapi-schema.json

Re: [Qemu-devel] [PATCH v2 01/54] qapi: fix type_seen key error

2017-08-22 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > The type_seen member can be of a different type than the 'qtype' being > > checked, since a string create several conflicts. Lookup the real > > conflicting type in the conflict set, that one must be

Re: [Qemu-devel] [PATCH 08/10] scsi: build qemu-pr-helper

2017-08-22 Thread Paolo Bonzini
On 22/08/2017 16:34, Marc-André Lureau wrote: > Could this be handled by udisk? It seems at first the problem is not > specific to qemu. Yes, possibly. In practice, everybody else who uses persistent reservations seems to run as root. :) >> +static void usage(const char *name) >> +{ >> +

Re: [Qemu-devel] [PATCH v2 51/54] qapi: make s390 commands depend on TARGET_S390X

2017-08-22 Thread Markus Armbruster
David Hildenbrand writes: >> Yes, but Marc-André's patch makes the "not supported yet" information >> available in query-qmp-schema. Carrying such information is pretty much >> the point of schema introspection. >> >> We could add a comment explaining this command isn't

Re: [Qemu-devel] [PATCH v2 04/54] qlit: add qobject_form_qlit()

2017-08-22 Thread Markus Armbruster
Typo in the subject: s/form/from/ Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 2 ++ > qobject/qlit.c | 37 + > tests/check-qlit.c |

Re: [Qemu-devel] [RFC PATCH 04/56] char: Make ringbuf-read size unsigned in QAPI/QMP

2017-08-22 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Aug 22, 2017 at 3:00 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Hi >>> >>> On Mon, Aug 7, 2017 at 4:45 PM, Markus Armbruster wrote:

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc3 is now available

2017-08-22 Thread Peter Maydell
On 15 August 2017 at 22:04, Michael Roth wrote: > Hello, > > On behalf of the QEMU Team, I'd like to announce the availability of the > fourth release candidate for the QEMU 2.10 release. This release is meant > for testing purposes and should not be used in a

Re: [Qemu-devel] [PATCH 3/3] Add manpage for QEMU Backup Tool

2017-08-22 Thread Stefan Hajnoczi
On Mon, Aug 21, 2017 at 04:40:39PM +0530, Ishani Chugh wrote: > +@node List of Commands > +@chapter List of Commands > +@itemize > +@item qemu-backup guest add --guest guestname --qmp socketpath > +@item qemu-backup guest list > +@item qemu-backup drive add --id driveid --guest guestname

Re: [Qemu-devel] [PATCH v3] target-i386/cpu: Add new EPYC CPU model

2017-08-22 Thread Paolo Bonzini
On 22/08/2017 16:44, Brijesh Singh wrote: > Hi Eduardo and Paolo, > > Please let me know if want me to address something else in this patch. > > After this patch is accepted, I am planning to submit similar patch to > to libvirt to create EPYC CPU. It looks good to me, but Eduardo is the

Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 16:06, Thomas Huth wrote: > QEMU currently aborts if the user tries to do something like this: > > $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic > QEMU 2.9.93 monitor - type 'help' for more information > (qemu) device_add

  1   2   3   4   >