Re: [Qemu-devel] [PATCH v11 2/6] ACPI: Add APEI GHES Table Generation support

Hi Shannon, On 2017/8/26 9:08, Shannon Zhao wrote: > > > On 2017/8/25 19:20, gengdongjiu wrote: diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c >> index 3d78ff6..def1ec1 100644 >> --- a/hw/arm/virt-acpi-build.c >> +++ b/hw/arm/virt-acpi-build.c >> @@ -45,6

Re: [Qemu-devel] [PATCH v11 1/6] ACPI: add APEI/HEST/CPER structures and macros

On 2017/8/26 9:00, Shannon Zhao wrote: > > > On 2017/8/25 18:37, gengdongjiu wrote: + >> +/* From the ACPI 6.1 spec, "18.3.2.9 Hardware Error Notification" */ >> + It's better to refer to the first spec version of this structure and same with others you define. >> do

Re: [Qemu-devel] [PATCH v11 2/6] ACPI: Add APEI GHES Table Generation support

On 2017/8/25 19:20, gengdongjiu wrote: >>> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c >>> >> index 3d78ff6..def1ec1 100644 >>> >> --- a/hw/arm/virt-acpi-build.c >>> >> +++ b/hw/arm/virt-acpi-build.c >>> >> @@ -45,6 +45,7 @@ >>> >> #include "hw/arm/virt.h" >>> >> #include

Re: [Qemu-devel] [PATCH v11 1/6] ACPI: add APEI/HEST/CPER structures and macros

On 2017/8/25 18:37, gengdongjiu wrote: >>> + >>> >> +/* From the ACPI 6.1 spec, "18.3.2.9 Hardware Error Notification" */ >>> >> + >> > It's better to refer to the first spec version of this structure and >> > same with others you define. > do you mean which spec version? the definition is

Re: [Qemu-devel] [PATCH v8 0/5] hypertrace: Lightweight guest-to-QEMU trace channel

On Sun, Jul 30, 2017 at 17:08:18 +0300, Lluís Vilanova wrote: > The hypertrace channel allows guest code to emit events in QEMU (the host) > using > its tracing infrastructure (see "docs/trace.txt"). This works in both 'system' > and 'user' modes, is architecture-agnostic and introduces minimal

Re: [Qemu-devel] [PATCH 2/3] docker.py: Python 2.6 argparse compatibility

On Fri, 08/25 16:57, Stefan Hajnoczi wrote: > Add the scripts/ directory to sys.path so Python 2.6 will be able to > import argparse. > > Cc: Fam Zheng > Signed-off-by: Stefan Hajnoczi > --- > tests/docker/docker.py | 4 +++- > 1 file changed, 3

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

On Thu, Aug 03, 2017 at 12:54:57 +0100, Stefan Hajnoczi wrote: > > > Please post an example of the API you'd like. > > > > In my opinion, the instrumentation support in this series provides an API > > that > > works in the opposite way you're suggesting (let's ignore the fact that it's > > built

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

On Fri, Jul 28, 2017 at 19:05:43 +0300, Lluís Vilanova wrote: > As for the (minimum) requirements I've collected: > > * Peek at register values and guest memory. > * Enumerate guest cpus. > * Control when events are raised to minimize overheads (e.g., avoid generating > TCG code to trace a

Re: [Qemu-devel] [PATCH 00/22] tcg: tb_lock removal

On Mon, Aug 07, 2017 at 19:52:16 -0400, Emilio G. Cota wrote: > This series applies on top of the "multiple TCG contexts" series, v4: > https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg06769.html > > Highlights: > > - First, fix a few typos I encountered while working on this (patches

Re: [Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

Samuel Thibault, on sam. 26 août 2017 01:05:04 +0200, wrote: > So Wjjzhang and PJP, can you confirm that this fixes your uses? PJP, can you forward it to Wjjzhang? I keep getting : host cloudmx.qq.com[113.108.11.188] said: 550 Mail content denied.

Re: [Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

Hello, So Wjjzhang and PJP, can you confirm that this fixes your uses? Samuel Samuel Thibault, on sam. 26 août 2017 00:37:21 +0200, wrote: > The if_fastq and if_batchq contain not only packets, but queues of packets > for the same socket. When sofree frees a socket, it thus has to clear ifq_so

[Qemu-devel] [PATCH] target/arm: Fix aa64 ldp register writeback

For "ldp x0, x1, [x0]", if the second load is on a second page and the second page is unmapped, the exception would be raised with x0 already modified. This means the instruction couldn't be restarted. Cc: qemu-...@nongnu.org Cc: qemu-sta...@nongnu.org Reported-by: Andrew

Re: [Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

Hi Sam, thanks for this patch :) On 08/25/2017 07:37 PM, Samuel Thibault wrote: The if_fastq and if_batchq contain not only packets, but queues of packets for the same socket. When sofree frees a socket, it thus has to clear ifq_so from all the packets from the queues, not only the first.

Re: [Qemu-devel] [PATCH 1/5] pci: INTERFACE_LEGACY_PCI_DEVICE and INTERFACE_PCIE_DEVICE interfaces

On Fri, Aug 25, 2017 at 02:19:00PM -0600, Alex Williamson wrote: > On Wed, 23 Aug 2017 19:14:41 -0300 > Eduardo Habkost wrote: > > > Those two interfaces will be used to indicate which device types > > support legacy PCI or PCI-express buses. Management software > > will be

[Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

The if_fastq and if_batchq contain not only packets, but queues of packets for the same socket. When sofree frees a socket, it thus has to clear ifq_so from all the packets from the queues, not only the first. Signed-off-by: Samuel Thibault Acked-by: Philippe

Re: [Qemu-devel] [PATCH 00/17] nbd client refactoring and fixing

On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: > A bit more refactoring and fixing before BLOCK_STATUS series. > I've tried to make individual patches simple enough, so there are > a lot of them. > > Vladimir Sementsov-Ogievskiy (17): > nbd/client: fix nbd_opt_go > nbd/client:

Re: [Qemu-devel] [PATCH 10/17] block/nbd-client: move nbd_coroutine_end content into nbd_co_request

On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: > Move code from nbd_coroutine_end into nbd_co_request. The function > nbd_coroutine_end is not needed separately, also it is better to > have in_flight-- in nbd_co_request as in_flight++ lives in nbd_co_request > too. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 08/17] block/nbd-client: rename nbd_recv_coroutines_enter_all

On 08/25/2017 01:43 PM, Eric Blake wrote: > On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: >> Rename nbd_recv_coroutines_enter_all to nbd_recv_coroutines_wake_all, >> as it most probably just add all recv coroutines into co_queue_wakeup, s/adds/ >> not directly enter them.

Re: [Qemu-devel] [PATCH 05/17] block/nbd-client: get rid of ssize_t

On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: > Use int variable for nbd_co_send_request return value (as > nbd_co_send_request returns int). > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd-client.c | 10 +- > 1 file changed, 5

Re: [Qemu-devel] [PATCH 04/17] nbd/client: fix nbd_send_request to return int

On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: > Fix nbd_send_request to return int, as it returns a return value > of nbd_write (which is int), and the only user of nbd_send_request's > return value (nbd_co_send_request) consider it as int too. > > Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH 03/17] nbd/client: refactor nbd_receive_reply

On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: > Refactor nbd_receive_reply to return 1 on success, 0 on eof, when no > data was read and <0 for other cases, because returned size of read > data is not actually used. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PATCH for-2.11 v2] hw/ppc: CAS reset on early device hotplug

This patch is a follow up on the discussions made in patch "hw/ppc: disable hotplug before CAS is completed" that can be found at [1]. At this moment, we do not support CPU/memory hotplug in early boot stages, before CAS. When a hotplug occurs, the event is logged in an internal RTAS event log

[Qemu-devel] [PATCH for-2.11 v2] hw/ppc: CAS reset on early device hotplug

v2: - rebased with ppc-for-2.11 - function 'spapr_cas_completed' dropped - function 'spapr_drc_needed' made public and it's now used inside 'spapr_hotplugged_dev_before_cas' - 'spapr_drc_needed' was changed to support the migration of logical DRCs with devs attached in UNUSED state - new

[Qemu-devel] [Bug 1711316] Re: fbsd strip(1) segfaults on aarch64

*** This bug is a duplicate of bug 1713066 *** https://bugs.launchpad.net/bugs/1713066 ** This bug has been marked a duplicate of bug 1713066 Incorrect handling of aarch64 ldp in some cases -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 1713066] Re: Incorrect handling of aarch64 ldp in some cases

This might be the cause for my bugreport: https://bugs.launchpad.net/qemu/+bug/1711316 Marked mine as a duplicate of this, please correct me if I'm wrong. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] nbd-client: enter read_reply_co during init to avoid crash

On 25/08/2017 17:08, Eric Blake wrote: > On 08/24/2017 11:05 AM, Stefan Hajnoczi wrote: >> On Thu, Aug 24, 2017 at 4:52 PM, Eric Blake wrote: >>> On 08/24/2017 10:33 AM, Stefan Hajnoczi wrote: See Patch 1 for the segfault fix. Patches 2 & 3 add qemu-iotests coverage.

Re: [Qemu-devel] [PATCH 1/5] pci: INTERFACE_LEGACY_PCI_DEVICE and INTERFACE_PCIE_DEVICE interfaces

On Wed, 23 Aug 2017 19:14:41 -0300 Eduardo Habkost wrote: > Those two interfaces will be used to indicate which device types > support legacy PCI or PCI-express buses. Management software > will be able to use the qom-list-types QMP command to query that > information.

[Qemu-devel] [PATCH] xio3130_downstream: Report error if pcie_chassis_add_slot() failed

On commit f8cd1b02 ("pci: Convert to realize"), no error_set*() call was added for the pcie_chassis_add_slot() error case. pcie_chassis_add_slot() errors get ignored, making QEMU crash later. e.g.: $ qemu-system-x86_64 -device ioh3420 -device xio3130-downstream qemu-system-x86_64:

Re: [Qemu-devel] [PATCH 4/5] pci: Add INTERFACE_LEGACY_PCI_DEVICE to legacy PCI devices

CCing maintainers of affected devices (sorry for not CCing you before). On Wed, Aug 23, 2017 at 07:14:44PM -0300, Eduardo Habkost wrote: > Add INTERFACE_LEGACY_PCI_DEVICE to all direct subtypes of > TYPE_PCI_DEVICE, except: > > 1) The ones that already have INTERFACE_PCIE_DEVICE set: > > *

Re: [Qemu-devel] [PATCH 3/5] pci: Add INTERFACE_PCIE_DEVICE to all PCIe devices

CCing maintainers of affected devices (sorry for not CCing you before). On Wed, Aug 23, 2017 at 07:14:43PM -0300, Eduardo Habkost wrote: > Change all devices that set is_express=1 to implement > INTERFACE_PCIE_DEVICE. > > Signed-off-by: Eduardo Habkost > --- >

Re: [Qemu-devel] [PATCH 2/5] pci: Add interface names to hybrid PCI devices

CCing maintainers of affected devices (sorry for not CCing you before) On Wed, Aug 23, 2017 at 07:14:42PM -0300, Eduardo Habkost wrote: > The following devices support both PCIe and legacy PCI, by > including special code to handle the QEMU_PCI_CAP_EXPRESS flag: > > * vfio-pci (is_express=1, but

Re: [Qemu-devel] [PATCH 02/17] nbd/client: refactor nbd_read_eof

On 08/07/2017 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: > 07.08.2017 14:42, Eric Blake wrote: >> On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Refactor nbd_read_eof to return 1 on success, 0 on eof, when no >>> data was read and <0 for other cases, because returned size of

Re: [Qemu-devel] [PATCH 2/5] pci: Add interface names to hybrid PCI devices

On Wed, Aug 23, 2017 at 07:14:42PM -0300, Eduardo Habkost wrote: > The following devices support both PCIe and legacy PCI, by > including special code to handle the QEMU_PCI_CAP_EXPRESS flag: > > * vfio-pci (is_express=1, but legacy PCI handled by > vfio_populate_device()) > * vmxnet3

Re: [Qemu-devel] [PATCH 07/17] block/nbd-client: refactor request send/receive

On 08/25/2017 01:49 PM, Eric Blake wrote: > On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: >> Move nbd_co_receive_reply and nbd_coroutine_end calls into >> nbd_co_send_request and rename the latter to just nbd_co_request. >> >> This removes code duplications in

Re: [Qemu-devel] [PATCH 09/17] block/nbd-client: move nbd_co_receive_reply content into nbd_co_request

On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: > Move code from nbd_co_receive_reply into nbd_co_request. This simplify s/simplify/simplifies/ > things, makes further refactoring possible. Also, a function starting s/makes/and makes/ > with qemu_coroutine_yield is weird. > >

Re: [Qemu-devel] [PATCH 07/17] block/nbd-client: refactor request send/receive

On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: > Move nbd_co_receive_reply and nbd_coroutine_end calls into > nbd_co_send_request and rename the latter to just nbd_co_request. > > This removes code duplications in nbd_client_co_{pwrite,pread,...} > functions. Also this is needed for

Re: [Qemu-devel] [PATCH 08/17] block/nbd-client: rename nbd_recv_coroutines_enter_all

On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: > Rename nbd_recv_coroutines_enter_all to nbd_recv_coroutines_wake_all, > as it most probably just add all recv coroutines into co_queue_wakeup, > not directly enter them. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH 5/5] pci: Validate interfaces on base_class_init

On Wed, Aug 23, 2017 at 3:14 PM, Eduardo Habkost wrote: > Make sure we don't forget to add the legacy-PCI or PCIe interface > names on PCI device classes in the future. > > Signed-off-by: Eduardo Habkost Reviewed-by: Alistair Francis

Re: [Qemu-devel] [PATCH 3/5] pci: Add INTERFACE_PCIE_DEVICE to all PCIe devices

On Wed, Aug 23, 2017 at 3:14 PM, Eduardo Habkost wrote: > Change all devices that set is_express=1 to implement > INTERFACE_PCIE_DEVICE. > > Signed-off-by: Eduardo Habkost > --- > hw/block/nvme.c| 4 > hw/net/e1000e.c

Re: [Qemu-devel] [PATCH 1/5] pci: INTERFACE_LEGACY_PCI_DEVICE and INTERFACE_PCIE_DEVICE interfaces

On Wed, Aug 23, 2017 at 3:14 PM, Eduardo Habkost wrote: > Those two interfaces will be used to indicate which device types > support legacy PCI or PCI-express buses. Management software > will be able to use the qom-list-types QMP command to query that > information. > >

Re: [Qemu-devel] [PATCH for-2.11 v4 06/25] sparc: make cpu feature parsing property based

On Fri, Aug 25, 2017 at 04:47:40PM +0200, Igor Mammedov wrote: > with features converted to properties we can use the same > approach as x86 for features parsing and drop legacy > approach that manipulated CPU instance directly. > New sparc_cpu_parse_features() will allow only +-feat > and

Re: [Qemu-devel] [PULL 09/21] pci: Convert to realize

On Fri, Aug 25, 2017 at 07:57:57PM +0300, Michael S. Tsirkin wrote: > On Fri, Aug 25, 2017 at 12:17:42PM -0300, Eduardo Habkost wrote: > > On Mon, Jul 03, 2017 at 10:45:16PM +0300, Michael S. Tsirkin wrote: > > > From: Mao Zhongyi > > > > > > Convert i82801b11,

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

On 08/25/2017 11:40 AM, Peter Maydell wrote: > Our choices about our dependencies are generally driven by "what > are the versions available on the oldest distros which we wish > to support building QEMU on", which typically is whatever the > long-term-support versions of Ubuntu, SUSE, Redhat, etc

Re: [Qemu-devel] [PATCH v2] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

On Wed, 23 Aug 2017, Ross Lagerwall wrote: > When the guest writes to the RTC, Xen emulates it and broadcasts a > TIMEOFFSET ioreq. Emit an RTC_CHANGE QMP event to all QMP monitors when > this happens rather than ignoring it so that something useful can be > done with the information. This is the

Re: [Qemu-devel] [Qemu-arm] [RFC v6 8/9] hw/arm/smmuv3: VFIO integration

On Wed, Aug 23, 2017 at 08:39:18AM +0200, Auger Eric wrote: > Hi Linu, > > On 23/08/2017 06:24, Linu Cherian wrote: > > Hi Eric, > > > > > > On Fri Aug 11, 2017 at 04:22:33PM +0200, Eric Auger wrote: > >> This patch allows doing PCIe passthrough with a guest exposed > >> with a vSMMUv3. It

Re: [Qemu-devel] [PULL 09/21] pci: Convert to realize

On Fri, Aug 25, 2017 at 12:17:42PM -0300, Eduardo Habkost wrote: > On Mon, Jul 03, 2017 at 10:45:16PM +0300, Michael S. Tsirkin wrote: > > From: Mao Zhongyi > > > > Convert i82801b11, io3130_upstream, io3130_downstream and > > pcie_root_port devices to realize. > > >

Re: [Qemu-devel] [PATCH for-2.11] tests/test-hmp: Remove puv3 and tricore_testboard from the blacklist

* Thomas Huth (th...@redhat.com) wrote: > The problem with puv3 has been fixed with 0ac241bcf9f9d99a252a352a162f > ('unicore32: abort when entering "x 0" on the monitor') and the problem > with tricore_testboard has been fixed with b190f477e29c7cd03a8fee49c96d > ('qemu-system-tricore: segfault

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

On 25 August 2017 at 17:35, Philippe Mathieu-Daudé wrote: > Hi Stefan, > > On 08/25/2017 12:57 PM, Stefan Hajnoczi wrote: >> >> Many scripts can benefit from the standard library argparse module, which >> has >> improvements over the older optparse module. Unfortunately argparse

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

Hi Stefan, On 08/25/2017 12:57 PM, Stefan Hajnoczi wrote: Many scripts can benefit from the standard library argparse module, which has improvements over the older optparse module. Unfortunately argparse was only shipped in Python 2.7 so we need a fallback for Python 2.6. I probably missed

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Fri, Aug 25, 2017 at 6:12 PM Dr. David Alan Gilbert > wrote: > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert < > >

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170825155732.15665-1-stefa...@redhat.com Subject: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Hi On Fri, Aug 25, 2017 at 6:12 PM Dr. David Alan Gilbert wrote: > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert < > dgilb...@redhat.com> > > wrote: > > > > > * Marc-André Lureau

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert > wrote: > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > Hi > > > > > > On Wed, Aug 23, 2017 at 8:52 AM Peter Xu wrote: >

Re: [Qemu-devel] [PATCH v2 09/16] qapi-schema: Collect migration stuff in qapi/migration.json

* Markus Armbruster (arm...@redhat.com) wrote: > Cc: Juan Quintela > Cc: Dr. David Alan Gilbert > Signed-off-by: Markus Armbruster Two thoughts: a) Do you actually want that as migration/migration.json? b) I'd prefer StrOrNull

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert wrote: > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > Hi > > > > On Wed, Aug 23, 2017 at 8:52 AM Peter Xu wrote: > > > > > Firstly, introduce Monitor.use_thread, and set it for monitors

[Qemu-devel] [PATCH 2/3] docker.py: Python 2.6 argparse compatibility

Add the scripts/ directory to sys.path so Python 2.6 will be able to import argparse. Cc: Fam Zheng Signed-off-by: Stefan Hajnoczi --- tests/docker/docker.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/docker/docker.py

[Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

Many scripts can benefit from the standard library argparse module, which has improvements over the older optparse module. Unfortunately argparse was only shipped in Python 2.7 so we need a fallback for Python 2.6. This patch series adds a copy of argparse.py and updates scripts as necessary to

[Qemu-devel] [PATCH 1/3] scripts: add argparse module for Python 2.6 compatibility

The minimum Python version supported by QEMU is 2.6. The argparse standard library module was only added in Python 2.7. Many scripts would like to use argparse because it supports command-line sub-commands. This patch adds argparse. See the top of argparse.py for details. Suggested-by: Daniel

[Qemu-devel] [PATCH 3/3] tests: migration/guestperf Python 2.6 argparse compatibility

Add the scripts/ directory to sys.path so Python 2.6 will be able to import argparse. Cc: Daniel P. Berrange Signed-off-by: Stefan Hajnoczi --- tests/migration/guestperf/shell.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/3] nbd-client: enter read_reply_co during init to avoid crash

24.08.2017 20:42, Paolo Bonzini wrote: On 24/08/2017 19:37, Eric Blake wrote: On 08/24/2017 11:21 AM, Paolo Bonzini wrote: On 24/08/2017 17:33, Stefan Hajnoczi wrote: This patch enters read_reply_co directly in nbd_client_attach_aio_context(). This is safe because new_context is acquired by

[Qemu-devel] [PATCH] block/curl: wake read completion coroutine only if necessary

When curl_co_preadv is called it sets up an ACB block which points to current coroutine. It will then call curl_setup_preadv and wait until request is completed by polling return status and yeilding: curl_setup_preadv(bs, ); while (acb.ret == -EINPROGRESS) {

Re: [Qemu-devel] [PATCH 1/2] migration: Reset rather than destroy main_thread_load_event

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 25 August 2017 at 15:19, Dr. David Alan Gilbert (git) > wrote: > > From: "Dr. David Alan Gilbert" > > > > migration_incoming_state_destroy doesn't really destroy, it cleans up. > > After a loadvm

Re: [Qemu-devel] [PATCH v2 02/54] qdict: add qdict_put_null() helper

On 08/22/2017 10:09 AM, Markus Armbruster wrote: >#define qdict_put_bool(qdict, key, value) \ >> qdict_put(qdict, key, qbool_from_bool(value)) >> #define qdict_put_str(qdict, key, value) \ >> qdict_put(qdict, key, qstring_from_str(value)) >> +#define qdict_put_null(qdict,

Re: [Qemu-devel] [Bug 1713066] [NEW] Incorrect handling of aarch64 ldp in some cases

On 25 August 2017 at 14:50, Andrew wrote: > Given the following instruction: > ldp x0, x1, [x0] > > This will load two 64 bit values from memory, however if each location > to load is on a different page and the second page is unmapped this will > raise an exception. When

Re: [Qemu-devel] [PATCH v2 13/14] qlit: add qobject_form_qlit()

On 08/25/2017 05:59 AM, Marc-André Lureau wrote: s/form/from/ in the subject > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 2 ++ > qobject/qlit.c | 37 + > tests/check-qlit.c | 26

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Wed, Aug 23, 2017 at 8:52 AM Peter Xu wrote: > > > Firstly, introduce Monitor.use_thread, and set it for monitors that are > > using non-mux typed backend chardev. We only do this for monitors, so > >

Re: [Qemu-devel] [PATCH v2 01/14] qdict: add qdict_put_null() helper

On 08/25/2017 05:59 AM, Marc-André Lureau wrote: > A step towards completeness. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Markus Armbruster > --- > include/qapi/qmp/qdict.h | 4 +++- > target/i386/cpu.c| 4 ++-- > 2 files

Re: [Qemu-devel] [PATCH 1/2] migration: Reset rather than destroy main_thread_load_event

On 25 August 2017 at 15:19, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > migration_incoming_state_destroy doesn't really destroy, it cleans up. > After a loadvm it's called, but the loadvm command can be run twice, > and so

Re: [Qemu-devel] [RFC v2 04/32] qemu_ram_block_host_offset

* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > Hi David, > > On 08/24/2017 04:27 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Utility to give the offset of a host pointer within a RAMBlock > > (assuming we already know it's in that

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Hi On Wed, Aug 23, 2017 at 8:52 AM Peter Xu wrote: > Firstly, introduce Monitor.use_thread, and set it for monitors that are > using non-mux typed backend chardev. We only do this for monitors, so > mux-typed chardevs are not suitable (when it connects to, e.g., serials >

[Qemu-devel] [Bug 1713066] [NEW] Incorrect handling of aarch64 ldp in some cases

Public bug reported: In some cases the ldp instruction (and presumably other multi-register loads and stores) can behave incorrectly. Given the following instruction: ldp x0, x1, [x0] This will load two 64 bit values from memory, however if each location to load is on a different page and the

Re: [Qemu-devel] [PATCH qemu] pci: Initialize pci_dev->name before use

On 08/24/2017 10:21 PM, Alexey Kardashevskiy wrote: > This moves pci_dev->name initialization earlier so > pci_dev->bus_master_as could get a name instead of empry string. s/empry/an empty/ > > Signed-off-by: Alexey Kardashevskiy > --- -- Eric Blake, Principal Software

Re: [Qemu-devel] [PULL 09/21] pci: Convert to realize

On Mon, Jul 03, 2017 at 10:45:16PM +0300, Michael S. Tsirkin wrote: > From: Mao Zhongyi > > Convert i82801b11, io3130_upstream, io3130_downstream and > pcie_root_port devices to realize. > > Cc: m...@redhat.com > Cc: mar...@redhat.com > Cc: arm...@redhat.com >

Re: [Qemu-devel] [PATCH 2/3] Test for full Backup

On 08/25/2017 10:36 AM, Peter Maydell wrote: > On 23 August 2017 at 14:04, Ishani Chugh > wrote: >> This patch is the test for full backup implementation in Backup tool. >> The test employs two basic substests: >> 1) Backing up an empty guest and comparing it

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] nbd-client: enter read_reply_co during init to avoid crash

On 08/24/2017 11:05 AM, Stefan Hajnoczi wrote: > On Thu, Aug 24, 2017 at 4:52 PM, Eric Blake wrote: >> On 08/24/2017 10:33 AM, Stefan Hajnoczi wrote: >>> See Patch 1 for the segfault fix. Patches 2 & 3 add qemu-iotests coverage. >>> >>> This is a rare crash that we'll probably

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

On 08/25/2017 10:04 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 09:24:46 -0400 Farhan Ali wrote: The commit 198c0d1f9df8c4 s390x/css: check ccw address validity exposes an alignment issue in ccw bios. According to PoP the CCW must be doubleword aligned. Let's fix

Re: [Qemu-devel] [PATCH v2 2/3] osdep: Define QEMU_MADV_REMOVE

* Eduardo Habkost (ehabk...@redhat.com) wrote: > Define QEMU_MADV_REMOVE, so we can use it with qemu_madvise(). > > Signed-off-by: Eduardo Habkost Reviewed-by: Dr. David Alan Gilbert > --- > Changes v1 -> v2: > * New patch added to series > --- >

Re: [Qemu-devel] [RFC v2 01/32] vhu: vu_queue_started

* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Thu, Aug 24, 2017 at 9:39 PM Dr. David Alan Gilbert (git) < > dgilb...@redhat.com> wrote: > > > From: "Dr. David Alan Gilbert" > > > > Add a vu_queue_started method to complement vu_queue_enabled. > > > >

[Qemu-devel] [PATCH for-2.11 v4 06/25] sparc: make cpu feature parsing property based

with features converted to properties we can use the same approach as x86 for features parsing and drop legacy approach that manipulated CPU instance directly. New sparc_cpu_parse_features() will allow only +-feat and explicitly disable feat=on|off syntax for now. With that in place and

Re: [Qemu-devel] [RFC v2 3/8] char-io: fix possible risk on IOWatchPoll

On Wed, Aug 23, 2017 at 8:54 AM Peter Xu wrote: > This is not a problem if we are only having one single loop thread like > before. However, after per-monitor thread is introduced, this is not > true any more, and the risk can happen. > > The risk can be triggered with "make

[Qemu-devel] [Bug 1712564] Re: loadvm fails twice in sequence

Posted: migration: Reset rather than destroy main_thread_load_event snapshot/tests: Try loadvm twice ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

Hi Farhan, On 08/25/2017 04:20 AM, Cornelia Huck wrote: On Thu, 24 Aug 2017 20:14:06 +0200 Christian Borntraeger wrote: On 08/24/2017 07:38 PM, Farhan Ali wrote: On 08/24/2017 12:07 PM, Peter Maydell wrote: On 24 August 2017 at 16:53, Farhan Ali

Re: [Qemu-devel] [PATCH 2/3] Test for full Backup

On 23 August 2017 at 14:04, Ishani Chugh wrote: > This patch is the test for full backup implementation in Backup tool. > The test employs two basic substests: > 1) Backing up an empty guest and comparing it with base image. > 2) Writing a pattern to the guest,

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

On Fri, 25 Aug 2017 23:28:00 +1000 David Gibson wrote: > On Fri, Aug 25, 2017 at 01:40:07PM +0200, Igor Mammedov wrote: > > On Fri, 25 Aug 2017 19:45:38 +1000 > > David Gibson wrote: > > > > > On Fri, Aug 25, 2017 at 09:27:40AM +0200,

Re: [Qemu-devel] [PATCH 2/3] Test for full Backup

On Wed, Aug 23, 2017 at 06:34:39PM +0530, Ishani Chugh wrote: > +CONFIG_FILE=$TEST_DIR/backup-config > +SOCKET=unix:$TEST_DIR/backup_socket > +size=128M > + > +_make_test_img $size > +export QEMU_BACKUP_CONFIG=$CONFIG_FILE > +qemu_comm_method="monitor" > +echo > +_launch_qemu -drive

[Qemu-devel] [PATCH 0/2] Fix double loadvm failure

From: "Dr. David Alan Gilbert" lp: https://bugs.launchpad.net/qemu/+bug/1712564 Reported-by: Stafford Horne Dr. David Alan Gilbert (2): migration: Reset rather than destroy main_thread_load_event snapshot/tests: Try loadvm twice

[Qemu-devel] [PATCH 2/2] snapshot/tests: Try loadvm twice

From: "Dr. David Alan Gilbert" It's legal to loadvm twice, modify the existing save/loadvm test to do it twice. Signed-off-by: Dr. David Alan Gilbert --- tests/qemu-iotests/068 | 2 +- tests/qemu-iotests/068.out | 4 2 files changed, 5

[Qemu-devel] [PATCH 1/2] migration: Reset rather than destroy main_thread_load_event

From: "Dr. David Alan Gilbert" migration_incoming_state_destroy doesn't really destroy, it cleans up. After a loadvm it's called, but the loadvm command can be run twice, and so destroying an init-once mutex breaks on the second loadvm. Reported-by: Stafford Horne

Re: [Qemu-devel] [PATCH v2 01/54] qapi: fix type_seen key error

On Fri, Aug 25, 2017 at 2:57 PM Eduardo Habkost wrote: > On Fri, Aug 25, 2017 at 08:02:26AM +0200, Markus Armbruster wrote: > > Conflicts with Eduardo's "[PATCH v2] qapi: Fix error handling code on > > alternate conflict". > > Message-Id:

Re: [Qemu-devel] [PATCH 1/3] backup: QEMU Backup Tool

On Wed, Aug 23, 2017 at 06:34:38PM +0530, Ishani Chugh wrote: > +def write_config(self): > +""" > +Writes configuration to ini file. > +""" > +config_file = open(self.config_file+".tmp", 'w') Please use whitespace around arithmetic operators:

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

On 25/08/2017 15:19, David Gibson wrote: > On Fri, Aug 25, 2017 at 11:57:26AM +0200, Paolo Bonzini wrote: >> On 25/08/2017 11:22, Peter Maydell wrote: >>> On 25 August 2017 at 09:53, Paolo Bonzini wrote: The solution is to: 1) share the FlatView structures if they refer

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

On Fri, 25 Aug 2017 09:24:46 -0400 Farhan Ali wrote: > The commit 198c0d1f9df8c4 s390x/css: check ccw address validity > exposes an alignment issue in ccw bios. > > According to PoP the CCW must be doubleword aligned. Let's fix > this in the bios. > > Cc:

Re: [Qemu-devel] [PATCH 7/9] AHCI: Rework IRQ constants

Hi John, On 08/08/2017 03:33 PM, John Snow wrote: Create a new enum so that we can name the IRQ bits, which will make debugging them a little nicer if we can print them out. Not handled in this patch, but this will make it possible to get a nice debug printf detailing exactly which status bits

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 3ed8b810b6592daee6a775037ce21f850e40647d.1503667215.git.al...@linux.vnet.ibm.com Subject:

Re: [Qemu-devel] [PATCH 9/9] AHCI: remove DPRINTF macro

On 08/08/2017 03:33 PM, John Snow wrote: Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- hw/ide/ahci.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 1a4d4db..ce2010c 100644 ---

Re: [Qemu-devel] [PATCH 5/9] IDE: replace DEBUG_AIO with trace events

Hi John, On 08/08/2017 03:33 PM, John Snow wrote: Signed-off-by: John Snow --- hw/ide/atapi.c| 5 + hw/ide/core.c | 17 ++--- hw/ide/trace-events | 3 +++ include/hw/ide/internal.h | 7 +-- 4 files changed, 19

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

On 25 August 2017 at 14:19, David Gibson wrote: > Hm. Why do we need to construct full ASes for virtio-blk, rather than > just MRs? It's the PCI layer that's doing it, but the overall reason is because virtio-blk needs to make memory transactions (DMA reads and

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

On 2017-08-25 02:55, John Snow wrote: > Sorry in advance for :words: ... > > On 08/23/2017 02:04 PM, Vladimir Sementsov-Ogievskiy wrote: >> 23.08.2017 11:59, Vladimir Sementsov-Ogievskiy wrote: >>> 22.08.2017 22:07, John Snow wrote: Well, we knew we'd want this sooner or later. I've got some

Re: [Qemu-devel] [PATCH 2/9] IDE: Add register hints to tracing

On 08/08/2017 03:32 PM, John Snow wrote: Name the registers for tracing purposes. Signed-off-by: John Snow --- hw/ide/core.c | 88 + hw/ide/trace-events | 4 +-- 2 files changed, 70 insertions(+), 22 deletions(-)

Re: [Qemu-devel] [RFC PATCH qemu] exec: Destroy dispatch immediately

On Fri, Aug 25, 2017 at 11:57:26AM +0200, Paolo Bonzini wrote: > On 25/08/2017 11:22, Peter Maydell wrote: > > On 25 August 2017 at 09:53, Paolo Bonzini wrote: > >> The solution is to: 1) share the FlatView structures if they refer to > >> the same root memory region; 2) have

  1   2   3   >