Re: [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by switching to ccw

2017-09-05 Thread QingFeng Hao
在 2017/9/5 23:16, Cornelia Huck 写道: Recent changes in s390x made pci support dependant on the zpci cpu feature, which is not provided on all models (and not on by default). This means we cannot instatiate pci devices on a standard qemu invocation for s390x. Moreover, the zpci instructions are n

Re: [Qemu-devel] [PATCH v2] watchdog: Allow setting action on the fly

2017-09-05 Thread Michal Privoznik
On 09/06/2017 07:59 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 09/05/2017 08:22 AM, Michal Privoznik wrote: >>> Currently, the only time that users can set watchdog action is at >>> the start as all we expose is this -watchdog-action command line >>> argument. This is suboptimal wh

Re: [Qemu-devel] 答复: [PATCH] intc: arm_gicv3: limit GICR ipriority index

2017-09-05 Thread P J P
+-- On Tue, 5 Sep 2017, Peter Maydell wrote --+ | The code cannot be reached with a non-aligned value, | because we register these functions via the gic_ops[] | MemoryRegionops in hw/intc/arm_gicv3.c, and since we | do not specify .valid.unaligned=true there, the memory.c | code will throw out atte

Re: [Qemu-devel] stack smash while using SDL 1.2.5 with QEMU 2.9

2017-09-05 Thread Markus Armbruster
Gerd, any ideas? Taimoor Mirza writes: > Hi Guys, > > I have been using QEMU 1.5 earlier with SDL version 1.2.5. Now we have > decided to move to new version of QEMU. I have built QEMU binaries with SDL > support using SDL 1.2.5 that we were using earlier. Windows binaries work > fine but I get

Re: [Qemu-devel] [PATCH] build-sys: generate tests/.gitignore

2017-09-05 Thread Markus Armbruster
Eric Blake writes: > On 09/05/2017 05:42 AM, Marc-André Lureau wrote: >> On Mon, Sep 4, 2017 at 12:21 PM Thomas Huth wrote: >> >>> On 04.09.2017 11 <04%2009%2020%2017%2011>:03, Marc-André Lureau wrote: >>> > tests/.gitignore is often out of date. Let's generate it based on the >>> > files and di

Re: [Qemu-devel] [Qemu devel v7 PATCH 3/5] msf2: Add Smartfusion2 SPI controller

2017-09-05 Thread sundeep subbaraya
Ping. Thanks, Sundeep On Mon, Aug 28, 2017 at 10:08 PM, Subbaraya Sundeep wrote: > Modelled Microsemi's Smartfusion2 SPI controller. > > Signed-off-by: Subbaraya Sundeep > --- > hw/ssi/Makefile.objs | 1 + > hw/ssi/mss-spi.c | 409 ++ > +++

Re: [Qemu-devel] [PATCH v2] watchdog: Allow setting action on the fly

2017-09-05 Thread Markus Armbruster
Michal Privoznik writes: > Currently, the only time that users can set watchdog action is at > the start as all we expose is this -watchdog-action command line > argument. This is suboptimal when users want to plug the device > later via monitor. Alternatively, they might want to change the > act

Re: [Qemu-devel] [PATCH v2] watchdog: Allow setting action on the fly

2017-09-05 Thread Michal Privoznik
On 09/05/2017 10:36 PM, Eric Blake wrote: > On 09/05/2017 08:22 AM, Michal Privoznik wrote: >> Currently, the only time that users can set watchdog action is at >> the start as all we expose is this -watchdog-action command line >> argument. This is suboptimal when users want to plug the device >>

Re: [Qemu-devel] [PATCH v2] watchdog: Allow setting action on the fly

2017-09-05 Thread Markus Armbruster
Eric Blake writes: > On 09/05/2017 08:22 AM, Michal Privoznik wrote: >> Currently, the only time that users can set watchdog action is at >> the start as all we expose is this -watchdog-action command line >> argument. This is suboptimal when users want to plug the device >> later via monitor. Al

Re: [Qemu-devel] [PATCH 1/1] block: add block device shared field

2017-09-05 Thread Fam Zheng
On Tue, 09/05 10:56, Stefan Hajnoczi wrote: > On Fri, Sep 01, 2017 at 08:10:54PM +, Brian Steffens wrote: > > This adds a boolean option called 'shared' to block devices. It defaults > > to off/false. When enabled for a particular block device, the 'shared' > > option > > causes the block migr

[Qemu-devel] [Bug 1407813] Re: QEMU wrongly translates newlines on serial output

2017-09-05 Thread Tomasz Rostanski
I think this bug relates to: https://bugs.launchpad.net/qemu/+bug/1715296 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1407813 Title: QEMU wrongly translates newlines on serial output Status in Q

[Qemu-devel] [Bug 1715296] Re: qemu: invalid serial port configuration

2017-09-05 Thread Tomasz Rostanski
I believe the following bug is related: https://bugs.launchpad.net/qemu/+bug/1407813 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1715296 Title: qemu: invalid serial port configuration Status in

[Qemu-devel] [Bug 1715296] [NEW] qemu: invalid serial port configuration

2017-09-05 Thread Tomasz Rostanski
Public bug reported: The tty_serial_init() function sets the port c_oflags as follows: tty.c_oflag |= OPOST not clearing ONLCR, ONLRET and others. The result is that the postprocess output is enabled and host translates 0xa (LF) to 0xd 0xa (CR LF) which breaks the binary transmissions on serial p

Re: [Qemu-devel] [PULL v2 13/47] tests/check-qlit: New, covering qobject/qlit.c

2017-09-05 Thread Markus Armbruster
Eric Blake writes: > On 09/01/2017 10:37 AM, Markus Armbruster wrote: >> From: Marc-André Lureau >> >> Signed-off-by: Marc-André Lureau >> Message-Id: <20170825105913.4060-11-marcandre.lur...@redhat.com> >> [Copyright notice correction squashed in, commit message tweaked] >> Signed-off-by: Mar

Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds

2017-09-05 Thread Thomas Huth
On 05.09.2017 21:50, Eric Blake wrote: > On 08/24/2017 02:51 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 08/22/2017 06:19 AM, Halil Pasic wrote: [...] >>> I'd prefer that if we are going to introduce our own construct that >>> always evaluates side effects, and only has a compile-

Re: [Qemu-devel] [PATCH 1/1] net: Add SunGEM device emulation as found on Apple UniNorth

2017-09-05 Thread Mark Cave-Ayland
On 06/09/17 04:16, David Gibson wrote: > On Tue, Sep 05, 2017 at 11:13:43AM +1000, David Gibson wrote: >> On Mon, Sep 04, 2017 at 07:39:38PM +0100, Mark Cave-Ayland wrote: >>> From: Benjamin Herrenschmidt >>> >>> This adds a simplistic emulation of the Sun GEM ethernet controller >>> found in Appl

Re: [Qemu-devel] [PATCH] build-sys: generate tests/.gitignore

2017-09-05 Thread Thomas Huth
On 05.09.2017 12:42, Marc-André Lureau wrote: > Hi > > On Mon, Sep 4, 2017 at 12:21 PM Thomas Huth > wrote: > > On 04.09.2017 11 :03, Marc-André Lureau > wrote: [...] > >  # Build the help program automatically > > > >  all: $(QEMU_IOTESTS_HELPERS-y)

Re: [Qemu-devel] [PATCH v3 0/3] three zpci patches

2017-09-05 Thread Yi Min Zhao
Thank you very much! 在 2017/9/5 下午7:58, Cornelia Huck 写道: On Tue, 5 Sep 2017 12:12:57 +0200 Yi Min Zhao wrote: This patch set contains three small zpci patches to fixup different issues. 1) remove zpci idx from msix message, instead we could use PCIDevice's id to find zpci device in kvm

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] tests: Add a device_add/del HMP test

2017-09-05 Thread Thomas Huth
On 05.09.2017 20:37, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: >> On 05.09.2017 18:48, Dr. David Alan Gilbert wrote: >>> * Markus Armbruster (arm...@redhat.com) wrote: Thomas Huth writes: > People tend to forget to mark internal devices with "user_creata

Re: [Qemu-devel] [PATCH 4/9] s390x: refactor error handling for SSCH and RSCH

2017-09-05 Thread Dong Jia Shi
* Halil Pasic [2017-09-06 00:30:58 +0200]: [...] > > > >> But I guess, I was afraid of somebody blaming me for this > >> comment (such TODOs in production code are a bit strange -- what > >> does it mean: we did not bother to figure it out?). > > > > For one, the TODO is preexisting... and we

Re: [Qemu-devel] [PATCH 1/1] net: Add SunGEM device emulation as found on Apple UniNorth

2017-09-05 Thread David Gibson
On Tue, Sep 05, 2017 at 11:13:43AM +1000, David Gibson wrote: > On Mon, Sep 04, 2017 at 07:39:38PM +0100, Mark Cave-Ayland wrote: > > From: Benjamin Herrenschmidt > > > > This adds a simplistic emulation of the Sun GEM ethernet controller > > found in Apple ASICs. > > > > Currently we only suppo

[Qemu-devel] [PATCH v2 3/3] buildsys: Move gcrypt cflags/libs to per object

2017-09-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- configure| 5 ++--- crypto/Makefile.objs | 7 +++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/configure b/configure index d24a7eab37..42622b98be 100755 --- a/configure +++ b/configure @@ -2566,9 +2566,6 @@ if test "$gcrypt" != "no";

[Qemu-devel] [PATCH v2 0/3] buildsys: Move crypto libraries to per object variables

2017-09-05 Thread Fam Zheng
v2: Add gcrypt as well. [Daniel] Not all targets need the flags and libs of gcrypt/nettle/gnutls, so move them out from global variables, as done with other libraries. There are still other libraries in ./configure that can be converted this way, which will be sent separatedly. Fam Zheng (3):

[Qemu-devel] [PATCH v2 1/3] buildsys: Move nettle cflags/libs to per object

2017-09-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- configure| 5 ++--- crypto/Makefile.objs | 6 ++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/configure b/configure index fb7e34a901..6a4cb3832b 100755 --- a/configure +++ b/configure @@ -2616,9 +2616,6 @@ if test "$nettle" != "no"; t

[Qemu-devel] [PATCH v2 2/3] buildsys: Move gnutls cflags/libs to per object

2017-09-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- configure | 4 ++-- crypto/Makefile.objs | 7 +++ tests/Makefile.include | 10 +- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 6a4cb3832b..d24a7eab37 100755 --- a/configure +++ b/configure @@

Re: [Qemu-devel] [PATCH v3 08/14] hvf: add compilation rules to Makefile.objs

2017-09-05 Thread Sergio Andrés Gómez del Real
Stefan, is this acceptable? I mean delaying the compiling; up until patch 7 no hvf code is compiled. Or should I just squash everything from patch 2 to 7? El 4/09/2017 23:03, "Sergio Andrés Gómez del Real" < sergio.g.delr...@gmail.com> escribió: Note that until this patch (8/14) there is no compi

Re: [Qemu-devel] [PATCHv5 02/03] colo-compare: Use IOThread to Check old packet regularly and Process pactkets of the primary

2017-09-05 Thread wang.yong155
>Remove the task which check old packet in the comparing thread, >then use IOthread context timer to handle it. > >Process pactkets in the IOThread which arrived over the socket. >we use iothread_get_g_main_context to create a new g_main_loop in >the IOThread.then the packets from the primary

Re: [Qemu-devel] [PATCH v7 0/4] Generic PCIE-PCI Bridge

2017-09-05 Thread Aleksandr Bezzubikov
ср, 23 авг. 2017 г. в 5:46, Michael S. Tsirkin : > On Tue, Aug 22, 2017 at 02:43:39PM +0300, Marcel Apfelbaum wrote: > > On 18/08/2017 2:36, Aleksandr Bezzubikov wrote: > > > This series introduces a new device - Generic PCI Express to PCI > bridge, > > > and also makes all necessary changes to en

Re: [Qemu-devel] [PATCH 1/5] target/arm: Remove stale comment

2017-09-05 Thread Pranith Kumar
Hi Alex, On Tue, Sep 5, 2017 at 8:02 AM, Alex Bennée wrote: > > Pranith Kumar writes: > >> Update the comment which is not true since MTTCG. > > What happened to the cover letter? We seem to have a mix of patches but > no summary of the overall outcome. > These are a bunch of unrelated patches,

Re: [Qemu-devel] [PATCH] tcg/softmmu: Increase size of TLB caches

2017-09-05 Thread Pranith Kumar
On Tue, Sep 5, 2017 at 5:50 PM, Richard Henderson wrote: > On 08/29/2017 10:23 AM, Pranith Kumar wrote: >> This patch increases the number of entries cached in the TLB. I went >> over a few architectures to see if increasing it is problematic. Only >> armv6 seems to have a limitation that only 8 b

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-05 Thread Alistair Francis
On Tue, Sep 5, 2017 at 3:46 PM, Alistair Francis wrote: > On Tue, Sep 5, 2017 at 3:12 PM, Eduardo Habkost wrote: >> On Tue, Sep 05, 2017 at 02:47:52PM -0700, Alistair Francis wrote: >>> On Tue, Sep 5, 2017 at 2:31 PM, Eduardo Habkost wrote: >> [...] >>> >> diff --git a/hw/arm/stm32f205_soc.c b/h

[Qemu-devel] [RFC v1 1/2] machine: Add a valid_cpu_types property

2017-09-05 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/core/machine.c | 27 +++ include/hw/boards.h | 1 + 2 files changed, 28 insertions(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 41b53a17ad..de0f127d27 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -758,

[Qemu-devel] [RFC v1 0/2] Add a valid_cpu_types property

2017-09-05 Thread Alistair Francis
There are numorous QEMU machines that only have a single or a handful of valid CPU options. To simplyfy the management of specificying which CPU is/isn't valid let's create a property that can be set in the machine init. We can then check to see if the user supplied CPU is in that list or not. Thi

[Qemu-devel] [RFC v1 2/2] netduino2: Specify the valid CPUs

2017-09-05 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/arm/netduino2.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c index 3cfe332dd1..accca344fd 100644 --- a/hw/arm/netduino2.c +++ b/hw/arm/netduino2.c @@ -43,8 +43,13 @@ static void netduino2_init(MachineState

Re: [Qemu-devel] [PATCH 03/20] target/arm: Add state field, feature bit and migration for v8M secure state

2017-09-05 Thread Philippe Mathieu-Daudé
On 08/29/2017 12:28 PM, Richard Henderson wrote: On 08/22/2017 08:08 AM, Peter Maydell wrote: As the first step in implementing ARM v8M's security extension: * add a new feature bit ARM_FEATURE_M_SECURITY * add the CPU state field that indicates whether the CPU is currently in the secure

Re: [Qemu-devel] [Qemu-arm] [PATCH 17/20] target/arm: Make MMFAR banked for v8M

2017-09-05 Thread Philippe Mathieu-Daudé
On 08/29/2017 01:10 PM, Richard Henderson wrote: On 08/22/2017 08:08 AM, Peter Maydell wrote: Make the MMFAR register banked if v8M security extensions are enabled. Signed-off-by: Peter Maydell --- target/arm/cpu.h | 2 +- hw/intc/armv7m_nvic.c | 4 ++-- target/arm/helper.c | 4 ++--

Re: [Qemu-devel] [Qemu-arm] [PATCH 13/20] target/arm: Make MPU_RBAR, MPU_RLAR banked for v8M

2017-09-05 Thread Philippe Mathieu-Daudé
On 08/22/2017 12:08 PM, Peter Maydell wrote: Make the MPU registers MPU_MAIR0 and MPU_MAIR1 banked if v8M security extensions are enabled. We can freely add more items to vmstate_m_security without breaking migration compatibility, because no CPU currently has the ARM_FEATURE_M_SECURITY bit enab

Re: [Qemu-devel] [PATCH 12/20] target/arm: Make MPU_MAIR0, MPU_MAIR1 registers banked for v8M

2017-09-05 Thread Philippe Mathieu-Daudé
On 08/22/2017 12:08 PM, Peter Maydell wrote: Make the MPU registers MPU_MAIR0 and MPU_MAIR1 banked if v8M security extensions are enabled. Signed-off-by: Peter Maydell --- target/arm/cpu.h | 4 ++-- hw/intc/armv7m_nvic.c | 8 target/arm/cpu.c | 4 ++-- target/arm/machine

Re: [Qemu-devel] [Qemu-arm] [PATCH 09/20] target/arm: Make CONTROL register banked for v8M

2017-09-05 Thread Philippe Mathieu-Daudé
On 08/29/2017 12:43 PM, Richard Henderson wrote: On 08/22/2017 08:08 AM, Peter Maydell wrote: Make the CONTROL register banked if v8M security extensions are enabled. Signed-off-by: Peter Maydell --- target/arm/cpu.h | 5 +++-- target/arm/helper.c| 21 +++-- targ

Re: [Qemu-devel] [Qemu-arm] [PATCH 07/20] target/arm: Make PRIMASK register banked for v8M

2017-09-05 Thread Philippe Mathieu-Daudé
On 08/22/2017 08:08 AM, Peter Maydell wrote: Make the PRIMASK register banked if v8M security extensions are enabled. Note that we do not yet implement the functionality of the new AIRCR.PRIS bit (which allows the effect of the NS copy of PRIMASK to be restricted). Signed-off-by: Peter Maydell

Re: [Qemu-devel] [Qemu-arm] [PATCH 06/20] target/arm: Make BASEPRI register banked for v8M

2017-09-05 Thread Philippe Mathieu-Daudé
On 08/22/2017 12:08 PM, Peter Maydell wrote: Make the BASEPRI register banked if v8M security extensions are enabled. Note that we do not yet implement the functionality of the new AIRCR.PRIS bit (which allows the effect of the NS copy of BASEPRI to be restricted). Signed-off-by: Peter Maydell

Re: [Qemu-devel] [Qemu-arm] [PATCH 19/20] target/arm: Move regime_is_secure() to target/arm/internals.h

2017-09-05 Thread Philippe Mathieu-Daudé
On 08/29/2017 01:12 PM, Richard Henderson wrote: On 08/22/2017 08:08 AM, Peter Maydell wrote: Move the regime_is_secure() utility function to internals.h; we are going to want to call it from translate.c. Signed-off-by: Peter Maydell --- target/arm/internals.h | 26 ++

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-05 Thread Alistair Francis
On Tue, Sep 5, 2017 at 3:12 PM, Eduardo Habkost wrote: > On Tue, Sep 05, 2017 at 02:47:52PM -0700, Alistair Francis wrote: >> On Tue, Sep 5, 2017 at 2:31 PM, Eduardo Habkost wrote: > [...] >> >> diff --git a/hw/arm/stm32f205_soc.c b/hw/arm/stm32f205_soc.c >> >> index f61e735..1cd6374 100644 >> >>

Re: [Qemu-devel] [Qemu-arm] [PATCH 06/20] target/arm: Make BASEPRI register banked for v8M

2017-09-05 Thread Philippe Mathieu-Daudé
Hi Peter, On 08/22/2017 12:08 PM, Peter Maydell wrote: Make the BASEPRI register banked if v8M security extensions are enabled. Note that we do not yet implement the functionality of the new AIRCR.PRIS bit (which allows the effect of the NS copy of BASEPRI to be restricted). Signed-off-by: Pet

Re: [Qemu-devel] [PATCH v3] vhost-user: disable the *broken* subprocess tests

2017-09-05 Thread Philippe Mathieu-Daudé
not vhost-user-test, but this still failed: ERROR:tests/rcutorture.c:388:gtest_stress: assertion failed (n_mberror == 0): (1 == 0) GTester: last random seed: R02S8905ef6a0d8ed82670297d559c40e919 make: *** [check-tests/rcutorture] Error 1 CONFIG="--enable-debug --enable-de

Re: [Qemu-devel] [PATCH 4/9] s390x: refactor error handling for SSCH and RSCH

2017-09-05 Thread Halil Pasic
On 09/05/2017 06:25 PM, Cornelia Huck wrote: > On Tue, 5 Sep 2017 17:55:17 +0200 > Halil Pasic wrote: > >> On 08/31/2017 11:55 AM, Cornelia Huck wrote: >>> On Wed, 30 Aug 2017 18:36:04 +0200 >>> Halil Pasic wrote: >>> Simplify the error handling of the SSCH and RSCH handler avoiding >>

Re: [Qemu-devel] [PATCH v6 08/29] libqtest: Let socket_send() compute length

2017-09-05 Thread Eric Blake
On 09/05/2017 04:54 AM, Markus Armbruster wrote: > Thomas Huth writes: > >> On 01.09.2017 20:03, Eric Blake wrote: >>> Rather than make multiple callers call strlen(), it's easier if >>> socket_send() itself can compute a length via strlen() if none >>> was provided (caller passes -1). Callers t

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-05 Thread Eduardo Habkost
On Tue, Sep 05, 2017 at 02:47:52PM -0700, Alistair Francis wrote: > On Tue, Sep 5, 2017 at 2:31 PM, Eduardo Habkost wrote: [...] > >> diff --git a/hw/arm/stm32f205_soc.c b/hw/arm/stm32f205_soc.c > >> index f61e735..1cd6374 100644 > >> --- a/hw/arm/stm32f205_soc.c > >> +++ b/hw/arm/stm32f205_soc.c

Re: [Qemu-devel] [PATCH v3] vhost-user: disable the *broken* subprocess tests

2017-09-05 Thread Marc-André Lureau
Hi On Tue, Sep 5, 2017 at 9:41 PM Philippe Mathieu-Daudé wrote: > not vhost-user-test, but this still failed: > > ERROR:tests/rcutorture.c:388:gtest_stress: assertion failed (n_mberror > == 0): (1 == 0) > GTester: last random seed: R02S8905ef6a0d8ed82670297d559c40e919 > make: *** [check-tests/rc

Re: [Qemu-devel] [PATCH] tcg/softmmu: Increase size of TLB caches

2017-09-05 Thread Richard Henderson
On 08/29/2017 10:23 AM, Pranith Kumar wrote: > This patch increases the number of entries cached in the TLB. I went > over a few architectures to see if increasing it is problematic. Only > armv6 seems to have a limitation that only 8 bits can be used for > indexing these entries. For other archite

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-05 Thread Alistair Francis
On Tue, Sep 5, 2017 at 2:31 PM, Eduardo Habkost wrote: > On Mon, Sep 04, 2017 at 04:01:02PM +0200, Igor Mammedov wrote: >> there are 2 use cases to deal with: >> 1: fixed CPU models per board/soc >> 2: boards with user configurable cpu_model and fallback to >> default cpu_model if user ha

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-05 Thread Eduardo Habkost
On Mon, Sep 04, 2017 at 04:01:02PM +0200, Igor Mammedov wrote: > there are 2 use cases to deal with: > 1: fixed CPU models per board/soc > 2: boards with user configurable cpu_model and fallback to > default cpu_model if user hasn't specified one explicitly > > For the 1st > drop interm

Re: [Qemu-devel] [Qemu-arm] [PATCH 01/20] target/arm: Implement ARMv8M's PMSAv8 registers

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 20:16, Philippe Mathieu-Daudé wrote: > Hi Peter, > > > On 08/22/2017 12:08 PM, Peter Maydell wrote: >> diff --git a/target/arm/machine.c b/target/arm/machine.c >> index 3193b00..05e2909 100644 >> --- a/target/arm/machine.c >> +++ b/target/arm/machine.c >> @@ -159,7 +159,8

Re: [Qemu-devel] [PATCH v10 0/6] fsdev: qmp interface for io throttling

2017-09-05 Thread Eric Blake
On 09/04/2017 11:07 AM, Pradeep Jagadeesh wrote: > These patches provide the qmp interface, to query the io throttle > status of the all fsdev devices that are present in a vm. > also, it provides an interface to set the io throttle parameters of a > fsdev to a required value. some of the patches

[Qemu-devel] [PATCH] target/arm: Add Jazelle feature

2017-09-05 Thread Portia Stephens
This adds the Jazelle execution state as a feature if ARM_FEATURE_V6 is set or if the processor is arm926 or arm1026. This fixes the issue that any BXJ instruction will result in an illegal_op. BXJ instructions will now check if the architecture supports ARM_FEATURE_JAZELLE. Signed-off-by: Portia

Re: [Qemu-devel] [Qemu-block] [PATCH v9 6/6] qemu-iotests: add 184 for throttle filter driver

2017-09-05 Thread Eric Blake
On 09/05/2017 02:06 PM, Kevin Wolf wrote: > Am 05.09.2017 um 18:16 hat Kevin Wolf geschrieben: >> Am 25.08.2017 um 15:20 hat Manos Pitsidianakis geschrieben: >>> Reviewed-by: Alberto Garcia >>> Signed-off-by: Manos Pitsidianakis >> >> Does this test actually (still) pass for you? I can't see that

Re: [Qemu-devel] [PATCH] build-sys: generate tests/.gitignore

2017-09-05 Thread Eric Blake
On 09/05/2017 05:42 AM, Marc-André Lureau wrote: > > I understand the feeling, I do also mostly out of tree build. However, I > don't think it makes much sense to generate .gitignore in the build dir. > It's git related, and in the git source dir, you have .git that is writable > already: it'd be

Re: [Qemu-devel] [PATCH] build-sys: generate tests/.gitignore

2017-09-05 Thread Eric Blake
On 09/04/2017 04:03 AM, Marc-André Lureau wrote: > tests/.gitignore is often out of date. Let's generate it based on the > files and directories to clean. In fact, it got out-of-date again with the recent cbb6540. > > Note: I didn't succeed yet at generalizing this approach for the rest > of qem

Re: [Qemu-devel] [PULL v2 13/47] tests/check-qlit: New, covering qobject/qlit.c

2017-09-05 Thread Eric Blake
On 09/01/2017 10:37 AM, Markus Armbruster wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Message-Id: <20170825105913.4060-11-marcandre.lur...@redhat.com> > [Copyright notice correction squashed in, commit message tweaked] > Signed-off-by: Markus Armbruster > --- > test

Re: [Qemu-devel] [PATCH v2] watchdog: Allow setting action on the fly

2017-09-05 Thread Eric Blake
On 09/05/2017 08:22 AM, Michal Privoznik wrote: > Currently, the only time that users can set watchdog action is at > the start as all we expose is this -watchdog-action command line > argument. This is suboptimal when users want to plug the device > later via monitor. Alternatively, they might wan

Re: [Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error

2017-09-05 Thread Eduardo Habkost
On Mon, Sep 04, 2017 at 04:00:58PM +0200, Igor Mammedov wrote: > Almost every user of cpu_generic_init() checks for > returned NULL and then reports failure in a custom way > and aborts process. > Some users assume that call can't fail and don't check > for failure, though they should have checked

Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds

2017-09-05 Thread Eric Blake
On 08/24/2017 02:51 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 08/22/2017 06:19 AM, Halil Pasic wrote: >> >>> OTOH I do think this is to some degree institutionalizing a bad practice >>> (you say we do not want to do that, but IMHO refusing to build with >>> NDEBUG makes only sense

Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds

2017-09-05 Thread Eric Blake
On 08/21/2017 05:08 AM, Peter Maydell wrote: > On 21 August 2017 at 10:31, Markus Armbruster wrote: >> I'm fine with project-wide, but does it have to be a hard error? Can we >> make it a warning? Same effect by default, but it lets people >> experiment more easily with --disable-werror. > > It

Re: [Qemu-devel] 答复: [PATCH] intc: arm_gicv3: limit GICR ipriority index

2017-09-05 Thread Eric Blake
On 09/05/2017 07:35 AM, Peter Maydell wrote: > On 5 September 2017 at 13:30, niuguoxiang wrote: >> I think only assert is not enough, because assert() depends on NDEBUG >> preprocessing > > Incidentally, QEMU can never be compiled with NDEBUG not > set -- we will #error in the compilation if it

Re: [Qemu-devel] [PATCH v3] vhost-user: disable the *broken* subprocess tests

2017-09-05 Thread Philippe Mathieu-Daudé
not vhost-user-test, but this still failed: ERROR:tests/rcutorture.c:388:gtest_stress: assertion failed (n_mberror == 0): (1 == 0) GTester: last random seed: R02S8905ef6a0d8ed82670297d559c40e919 make: *** [check-tests/rcutorture] Error 1 CONFIG="--enable-debug --enable-debug-tcg --enable-trace

Re: [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python

2017-09-05 Thread Eric Blake
On 09/04/2017 08:28 AM, Kashyap Chamarthy wrote: > On Mon, Sep 04, 2017 at 08:55:23PM +0800, Fam Zheng wrote: >> Hi Kashyap, >> >> On Mon, 09/04 13:16, Kashyap Chamarthy wrote: >>> The test 192 ("Test NBD export with '-incoming' (non-shared >>> storage migration use case from libvirt")) is current

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-09-05 Thread Greg Kurz
On Wed, 9 Aug 2017 15:08:42 +1000 David Gibson wrote: > On Tue, Aug 08, 2017 at 01:40:08PM -0600, Alex Williamson wrote: > > On Thu, 27 Jul 2017 12:50:42 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Thu, Jul 27, 2017 at 08:53:48PM +1000, David Gibson wrote: > > > > On Thu, Jul 27, 201

Re: [Qemu-devel] [PATCH] qcow2: move qcow2_store_persistent_dirty_bitmaps() before cache flushing

2017-09-05 Thread Eric Blake
On 09/04/2017 05:18 AM, Pavel Butsykin wrote: > After calling qcow2_inactivate(), all qcow2 caches must be flushed, but this > may not happen, because the last call qcow2_store_persistent_dirty_bitmaps() > can lead to marking l2/refcont cache as dirty. > > Let's move qcow2_store_persistent_dirty_b

Re: [Qemu-devel] [Qemu-arm] [PATCH 01/20] target/arm: Implement ARMv8M's PMSAv8 registers

2017-09-05 Thread Philippe Mathieu-Daudé
Hi Peter, On 08/22/2017 12:08 PM, Peter Maydell wrote: As part of ARMv8M, we need to add support for the PMSAv8 MPU architecture. PMSAv8 differs from PMSAv7 both in register/data layout (for instance using base and limit registers rather than base and size) and also in behaviour (for example it

[Qemu-devel] [PATCH 3/3] nbd: Use new qio_channel_*_all() functions

2017-09-05 Thread Eric Blake
Rather than open-coding our own read/write-all functions, we can make use of the recently-added qio code. It slightly changes the error message in one of the iotests. Signed-off-by: Eric Blake --- include/block/nbd.h| 2 -- nbd/nbd-internal.h | 41 +++---

[Qemu-devel] [PATCH 2/3] io: Add new qio_channel_read{, v}_all_eof functions

2017-09-05 Thread Eric Blake
Some callers want to distinguish between clean EOF (no bytes read) vs. a short read (at least one byte read, but EOF encountered before reaching the desired length), as it allows clients the ability to do a graceful shutdown when a server shuts down at defined safe points in the protocol, rather th

[Qemu-devel] [PATCH 0/3] nbd: Use common read/write-all qio functions

2017-09-05 Thread Eric Blake
Now that Daniel just added convenience qio channel looping functions, we might as well use it in NBD instead of open-coding our own. In doing so, fix a couple of short-falls noticed in the qio code. If Dan is happy with this, I can take the series through the NBD queue. [The diffstat is slightly

[Qemu-devel] [PATCH 1/3] io: Yield rather than wait when already in coroutine

2017-09-05 Thread Eric Blake
The new qio_channel_{read,write}{,v}_all functions are documented as yielding until data is available. When used on a blocking channel, this yield is done via qio_channel_wait() which spawns a new coroutine under the hood (so it is the new entry point that yields as needed); but if we are already

[Qemu-devel] [Bug 1715203] Re: Maintain Haiku support

2017-09-05 Thread kallisti5
Contacting our board of directors to see if I can get a VM deployed at Vultr. I'll keep this ticket updated. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1715203 Title: Maintain Haiku support Sta

Re: [Qemu-devel] [Qemu-block] [PATCH v9 6/6] qemu-iotests: add 184 for throttle filter driver

2017-09-05 Thread Kevin Wolf
Am 05.09.2017 um 18:16 hat Kevin Wolf geschrieben: > Am 25.08.2017 um 15:20 hat Manos Pitsidianakis geschrieben: > > Reviewed-by: Alberto Garcia > > Signed-off-by: Manos Pitsidianakis > > Does this test actually (still) pass for you? I can't see that it's > related to any recent change in master

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

2017-09-05 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Mon, Aug 28, 2017 at 12:11:38PM +0200, Marc-André Lureau wrote: > > Hi > > > > On Mon, Aug 28, 2017 at 5:05 AM, Peter Xu wrote: > > > On Fri, Aug 25, 2017 at 04:07:34PM +, Marc-André Lureau wrote: > > >> On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan

[Qemu-devel] [Bug 1714331] Re: Virtual machines not working anymore on 2.10

2017-09-05 Thread Chris Unsworth
I think my issue looks like the same. Sometimes I just get spinning dots, and sometimes there is the message about doing an automatic repair below the spinning dots before it stops and uses 100% cpu. I just did a git bisect: # git bisect log # bad: [1ab5eb4efb91a3d4569b0df6e824cc08ab4bd8ec] Upda

Re: [Qemu-devel] Questions regarding emulated UART in VersatilePB board

2017-09-05 Thread Ramy Sameh
Thank you very much Peter. I will check the documentation for VersatilePB and ARM926EJ-S for more understanding of interrupts handling. On Tue, Sep 5, 2017 at 8:06 PM, Peter Maydell wrote: > On 5 September 2017 at 18:56, Ramy Sameh wrote: > > Are there any documentation or source of informat

Re: [Qemu-devel] [PATCH] multiboot: validate multiboot header address values

2017-09-05 Thread Thomas Garnier via Qemu-devel
On Tue, Sep 5, 2017 at 10:49 AM, P J P wrote: > From: Prasad J Pandit > > While loading kernel via multiboot-v1 image, (flags & 0x0001) > indicates that multiboot header contains valid addresses to load > the kernel image. These addresses are used to compute kernel > size and kernel text offs

Re: [Qemu-devel] [PATCH] multiboot: validate multiboot header address values

2017-09-05 Thread Thomas Garnier via Qemu-devel
On Tue, Sep 5, 2017 at 11:12 AM, Thomas Garnier wrote: > On Tue, Sep 5, 2017 at 10:49 AM, P J P wrote: >> From: Prasad J Pandit >> >> While loading kernel via multiboot-v1 image, (flags & 0x0001) >> indicates that multiboot header contains valid addresses to load >> the kernel image. These a

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] tests: Add a device_add/del HMP test

2017-09-05 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > On 05.09.2017 18:48, Dr. David Alan Gilbert wrote: > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Thomas Huth writes: > >> > >>> People tend to forget to mark internal devices with "user_creatable = > >>> false > >>> or hotpluggable = false, and

Re: [Qemu-devel] [PATCH v2] io: add new qio_channel_{readv, writev, read, write}_all functions

2017-09-05 Thread Eric Blake
On 08/31/2017 04:46 AM, Daniel P. Berrange wrote: > These functions wait until they are able to read / write the full > requested data buffer(s). > > Signed-off-by: Daniel P. Berrange > --- > > Changed in v2: > > - Remove 'coroutine_fn' annotation (Stefan) > - Fix docs typos (Eric) > - Remov

Re: [Qemu-devel] [Bug 1715203] Re: Maintain Haiku support

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 19:14, kallisti5 <1715...@bugs.launchpad.net> wrote: > Haiku recently got a virtio driver, so running a Haiku system in cloud > infrastructure seems possible now. (I've personally run it on vultr.com) > Does QEMU have some infrastructure available so we can stand up a x86_64

[Qemu-devel] [Bug 1715203] Re: Maintain Haiku support

2017-09-05 Thread kallisti5
Haiku recently got a virtio driver, so running a Haiku system in cloud infrastructure seems possible now. (I've personally run it on vultr.com) Does QEMU have some infrastructure available so we can stand up a x86_64 system? -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] tests: Add a device_add/del HMP test

2017-09-05 Thread Thomas Huth
On 05.09.2017 18:48, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: >> Thomas Huth writes: >> >>> People tend to forget to mark internal devices with "user_creatable = false >>> or hotpluggable = false, and these devices can crash QEMU if added via the >>> HMP monit

Re: [Qemu-devel] [Bug 1715203] [NEW] Maintain Haiku support

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 18:55, kallisti5 <1715...@bugs.launchpad.net> wrote: > It was pointed out that the 2.10 release notes are pushing to drop Haiku > support. The qemu port is currently working as-is under Haiku. > > Was there a reason this was recommended? Is there anything Haiku can do > to k

Re: [Qemu-devel] Questions regarding emulated UART in VersatilePB board

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 18:56, Ramy Sameh wrote: > Are there any documentation or source of information, that can describe how > interrupts are implemented, and how to use them (where is the vector table > to put the ISR ... etc) ? The source code is it. Note that the pl011 is only a UART. It is

[Qemu-devel] [PATCH v3] vhost-user: disable the *broken* subprocess tests

2017-09-05 Thread Philippe Mathieu-Daudé
tests/vhost-user-test keeps failing on build-system since Aug 15: ERROR:tests/vhost-user-test.c:835:test_flags_mismatch: child process (/i386/vhost-user/flags-mismatch/subprocess [4836]) failed unexpectedly ... ERROR:tests/vhost-user-test.c:807:test_connect_fail: child process (/x86_64/vhost

[Qemu-devel] [Bug 1715203] [NEW] Maintain Haiku support

2017-09-05 Thread kallisti5
Public bug reported: It was pointed out that the 2.10 release notes are pushing to drop Haiku support. The qemu port is currently working as-is under Haiku. Was there a reason this was recommended? Is there anything Haiku can do to keep it from being dropped? We're working on a docker container

Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-05 Thread Dr. David Alan Gilbert
* Pradeep Jagadeesh (pradeepkiruv...@gmail.com) wrote: > This patch introduces hmp interfaces for the fsdev > devices. > > Signed-off-by: Pradeep Jagadeesh > --- > hmp-commands-info.hx | 18 > hmp-commands.hx | 19 + > hmp.c| 60 > ++

Re: [Qemu-devel] Questions regarding emulated UART in VersatilePB board

2017-09-05 Thread Ramy Sameh
Thanks Peter for your help. Are there any documentation or source of information, that can describe how interrupts are implemented, and how to use them (where is the vector table to put the ISR ... etc) ? In addition, any source of info that describes the code workflow when reading or writing to t

Re: [Qemu-devel] [PULL 24/29] kvm: use DIV_ROUND_UP

2017-09-05 Thread Peter Maydell
On 31 August 2017 at 11:34, Marc-André Lureau wrote: > I used the clang-tidy qemu-round check to generate the fix: > https://github.com/elmarco/clang-tools-extra > > Signed-off-by: Marc-André Lureau > Reviewed-by: Richard Henderson > --- > linux-headers/asm-x86/kvm.h | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [PATCH v11 6/6] target-arm: kvm64: Handle SError interrupt for the guest OS

2017-09-05 Thread Peter Maydell
On 18 August 2017 at 15:23, Dongjiu Geng wrote: > When guest OS happens SError interrupt(SEI), it will trap to host. > Host firstly calls memory failure to deal with this error and decide > whether it needs to deliver SIGBUS signal to userspace. The advantage > that using signal to notify is that

[Qemu-devel] [PATCH] multiboot: validate multiboot header address values

2017-09-05 Thread P J P
From: Prasad J Pandit While loading kernel via multiboot-v1 image, (flags & 0x0001) indicates that multiboot header contains valid addresses to load the kernel image. These addresses are used to compute kernel size and kernel text offset in the OS image. Validate these address values to avoid

Re: [Qemu-devel] [PATCH v3 3/7] Convert single line fprintf(.../n) to warn_report()

2017-09-05 Thread Alistair Francis
On Fri, Sep 1, 2017 at 1:52 PM, James Hogan wrote: > On Fri, Sep 01, 2017 at 09:51:15AM -0700, Alistair Francis wrote: >> diff --git a/target/mips/kvm.c b/target/mips/kvm.c >> index 3317905e71..a23aa438d2 100644 >> --- a/target/mips/kvm.c >> +++ b/target/mips/kvm.c >> @@ -95,11 +95,11 @@ void kvm_

Re: [Qemu-devel] [PATCH v11 5/6] target-arm: kvm64: handle SIGBUS signal for synchronous External Abort

2017-09-05 Thread Peter Maydell
On 18 August 2017 at 15:23, Dongjiu Geng wrote: > Add SIGBUS signal handler. In this handler, it checks > the exception type, translates the host VA which is > delivered by host or KVM to guest PA, then fills this > PA to CPER, finally injects a Error to guest OS through > KVM. > > Add synchronous

Re: [Qemu-devel] [PATCH v2 28/54] qapi: do not define enumeration value explicitely

2017-09-05 Thread Markus Armbruster
Marc-André Lureau writes: > The C standard has the initial value at 0 and the subsequent values > incremented by 1. No need to set this explicitely. > > This will prevent from artificial "gaps" when compiling out some enum > values and having unnecessarily large MAX values & enums arrays. Yes, b

Re: [Qemu-devel] [PATCH v2 2/6] xlnx-zynqmp-pmu: Add the CPU and memory

2017-09-05 Thread Alistair Francis
On Mon, Sep 4, 2017 at 12:32 AM, Igor Mammedov wrote: > On Fri, 1 Sep 2017 14:00:37 -0700 > Alistair Francis wrote: > >> Connect the MicroBlaze CPU and the ROM and RAM memory regions. >> >> Signed-off-by: Alistair Francis >> --- >> >> hw/microblaze/xlnx-zynqmp-pmu.c | 65 >> +++

Re: [Qemu-devel] [PATCH v3 1/7] hw/i386: Improve some of the warning messages

2017-09-05 Thread Alistair Francis
On Mon, Sep 4, 2017 at 7:17 AM, Eduardo Habkost wrote: > On Fri, Sep 01, 2017 at 09:51:05AM -0700, Alistair Francis wrote: > [...] >> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c >> index 169a214d50..435eb2c458 100644 >> --- a/hw/i386/pc_q35.c >> +++ b/hw/i386/pc_q35.c >> @@ -101,9 +101,11 @@

[Qemu-devel] [PATCH v2] vhost-user: disable broken test

2017-09-05 Thread Philippe Mathieu-Daudé
tests/vhost-user-test keeps failing on build-system since Aug 15: ERROR:tests/vhost-user-test.c:835:test_flags_mismatch: child process (/i386/vhost-user/flags-mismatch/subprocess [4836]) failed unexpectedly ... ERROR:tests/vhost-user-test.c:807:test_connect_fail: child process (/x86_64/vhost

  1   2   3   4   >