[Qemu-devel] [PULL] qemu-sparc updates

2017-10-18 Thread Mark Cave-Ayland
Hi Peter, Here are my sun4u patches for 2.11. Note that because of the machine changes there is an openbios-sparc64 binary update included in the first patch to maintain bisectability. There will be a follow-up patch for OpenBIOS which will update binaries for all architectures to the latest and

Re: [Qemu-devel] [PULL 00/11] Ui 20171016 patches

2017-10-18 Thread Thomas Huth
On 16.10.2017 15:16, Gerd Hoffmann wrote: > The following changes since commit f90ea7ba7c5ae7010ee0ce062207ae42530f57d6: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20171012' into staging (2017-10-12 > 17:06:50 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] [RFC v2 13/22] monitor: separate QMP parser and dispatcher

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 05:31:15PM +0200, Stefan Hajnoczi wrote: > On Mon, Oct 16, 2017 at 03:50:39PM +0800, Peter Xu wrote: > > On Thu, Oct 12, 2017 at 01:50:45PM +0100, Stefan Hajnoczi wrote: > > > On Fri, Sep 29, 2017 at 11:38:35AM +0800, Peter Xu wrote: > > > > +qdict = qobject_to_qdict(req

[Qemu-devel] [PATCH 3/4] migration: clean up xbzrle cache init/destroy

2017-10-18 Thread Peter Xu
Let's further simplify ram_init_all() and ram_save_cleanup() by abstract all the XBZRLE related codes into their own functions. When allocating xbzrle cache, we are always very careful on -ENOMEM; which makes sense. Replacing the last g_malloc0() with g_try_malloc0(), then refactor the logic a bi

[Qemu-devel] [PATCH 1/4] migration: provide ram_state_init()

2017-10-18 Thread Peter Xu
The old ram_state_init() is not really initializing the RAMState only, but including lots of other stuff that is RAM-related. Renaming it to ram_init_all(). Instead, provide a real ram_state_init(). Signed-off-by: Peter Xu --- migration/ram.c | 33 - 1 file chan

[Qemu-devel] [PATCH 4/4] migration: new ram_init_bitmaps()

2017-10-18 Thread Peter Xu
Rearrange the bitmap initialization and the first sync. Since at it, make sure the locks are taken/released in correct order (I moved RCU unlock upper - though it may not affect much). Signed-off-by: Peter Xu --- migration/ram.c | 51 ++- 1 file c

[Qemu-devel] [PATCH 0/4] migration: fixes and cleanups for ram state init

2017-10-18 Thread Peter Xu
I saw some leaks during ram setup, so trying to fix them. Since at it, I cleaned up the ram init phase a bit along with ram cleanup. Please review. Thanks, Peter Xu (4): migration: provide ram_state_init() migration: provide ram_state_cleanup migration: clean up xbzrle cache init/destroy

[Qemu-devel] [PATCH 2/4] migration: provide ram_state_cleanup

2017-10-18 Thread Peter Xu
There are two Mutexes that are created but not yet destroyed for RAMState. Fix that. Since we are at it, provide helper function to clean up RAMState. Signed-off-by: Peter Xu --- migration/ram.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-18 Thread Thomas Huth
Since the fix mentioned in the previous comments is already in upstream QEMU, I'm setting the upstream status to "Fix released". ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. h

Re: [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler

2017-10-18 Thread Dong Jia Shi
* Halil Pasic [2017-10-18 13:01:03 +0200]: > > > On 10/18/2017 12:02 PM, Cornelia Huck wrote: > > On Wed, 18 Oct 2017 12:00:05 +0200 > > Thomas Huth wrote: > > > >> On 17.10.2017 16:04, Halil Pasic wrote: > >>> Simplify the error handling of the MSCH. Let the code detecting the > >>> conditi

Re: [Qemu-devel] [PATCH v3 6/7] s390x: refactor error handling for HSCH handler

2017-10-18 Thread Dong Jia Shi
* Halil Pasic [2017-10-17 16:04:52 +0200]: > Simplify the error handling of the HSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 18 +- >

Re: [Qemu-devel] [PATCH v3 5/7] s390x: refactor error handling for CSCH handler

2017-10-18 Thread Dong Jia Shi
* Halil Pasic [2017-10-17 16:04:51 +0200]: > Simplify the error handling of the cSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- [...] > diff --git a/target/s390x/ioinst.c b/targe

Re: [Qemu-devel] [PATCH v3 4/7] s390x: refactor error handling for XSCH handler

2017-10-18 Thread Dong Jia Shi
* Halil Pasic [2017-10-17 16:04:50 +0200]: > Simplify the error handling of the XSCH. Let the code detecting the > condition tell (in a less ambiguous way) how it's to be handled. No > changes in behavior. > > Signed-off-by: Halil Pasic > --- > hw/s390x/css.c | 17 + >

Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH

2017-10-18 Thread Dong Jia Shi
* Halil Pasic [2017-10-17 16:04:49 +0200]: > Simplify the error handling of the SSCH and RSCH handler avoiding > arbitrary and cryptic error codes being used to tell how the instruction > is supposed to end. Let the code detecting the condition tell how it's > to be handled in a less ambiguous w

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-18 Thread ChristianEhrhardt
Since we wait for the zesty verification I'm setting the status to incomplete for now. ** Changed in: qemu (Ubuntu Zesty) Status: In Progress => Incomplete ** Changed in: libvirt (Ubuntu) Status: Incomplete => Invalid -- You received this bug notification because you are a member

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-18 Thread ChristianEhrhardt
Yeah, the offending patch in RH-BZ 1422413 appeared in qemu 2.8. So it would make sense to work with newtwon (2.6.1), and pike (2.10), but fail on Ocata (2.8). I checked the ppa, in general it seems to work for me, so I'm now waiting for your verification if that really addresses the issue you a

Re: [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr

2017-10-18 Thread Dong Jia Shi
* Cornelia Huck [2017-10-18 11:53:10 +0200]: > On Wed, 18 Oct 2017 16:23:47 +0800 > Dong Jia Shi wrote: > > > * Halil Pasic [2017-10-17 18:19:20 +0200]: > > > > [...] > > > > > >> Testing > > > >> === > > > >> > > > >> Nothing happened since v2 except for a quick smoke test. Dong Jia gav

[Qemu-devel] [PATCH v4 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-10-18 Thread Changpeng Liu
Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages which can be used for live migration of vhost user devices, also vhost user devices can benefit from the messages to get/set virtio config space from/to the I/O target. For the purpose to support virtio config space change, VHOST_USER_SET_CON

[Qemu-devel] [PATCH v4 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2017-10-18 Thread Changpeng Liu
This commit introduces a new vhost-user device for block, it uses a chardev to connect with the backend, same with Qemu virito-blk device, Guest OS still uses the virtio-blk frontend driver. To use it, start Qemu with command line like this: qemu-system-x86_64 \ -chardev socket,id=char0,path=

[Qemu-devel] [PATCH v4 0/4] *** Introduce a new vhost-user-blk host device to Qemu ***

2017-10-18 Thread Changpeng Liu
Although virtio scsi specification was designed as a replacement for virtio_blk, there are still many users using virtio_blk. Qemu 2.9 introduced a new device vhost user scsi which can process I/O in user space for virtio_scsi, this commit introduces a new vhost user block host device, which can su

[Qemu-devel] [PATCH v4 3/4] contrib/libvhost-user: enable virtio config space messages

2017-10-18 Thread Changpeng Liu
Enable VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG/VHOST_USER_SET_CONFIG_FD messages in libvhost-user library, users can implement their own I/O target based on the library. This enable the virtio config space delivered between Qemu host device and the I/O target, also event notifier is added in ca

[Qemu-devel] [PATCH v4 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application

2017-10-18 Thread Changpeng Liu
This commit introcudes a vhost-user-blk backend device, it uses UNIX domain socket to communicate with Qemu. The vhost-user-blk sample application should be used with Qemu vhost-user-blk-pci device. To use it, complie with: make vhost-user-blk and start like this: vhost-user-blk -b /dev/sdb -s /p

Re: [Qemu-devel] [PATCH v3 7/7] migration: pause-before-switchover for postcopy

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 06:40:13PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add pause-before-switchover support for postcopy. > After starting postcopy it will transition > active->pre-switchover->postcopy_active > > Signed-off-by: Dr. David Alan Gilber

Re: [Qemu-devel] [PATCHv3 13/13] sparc32_dma: add len to esp/le DMA memory tracing

2017-10-18 Thread Philippe Mathieu-Daudé
On 10/14/2017 03:39 PM, Mark Cave-Ayland wrote: > This is surprisingly useful when trying to debug DMA issues. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > --- > hw/dma/sparc32_dma.c |8 > hw/dma/trace-events |8 > 2 files changed, 8 ins

Re: [Qemu-devel] [PATCH v3 5/7] migrate: HMP migate_continue

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 06:40:11PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > HMP equivalent to the just added migrate-continue > Unpause a migrate paused at a given state. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [PATCH v3 6/7] migration: allow cancel to unpause

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 06:40:12PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > If a migration_cancel is issued during the new paused state, > kick the pause_sem to get to unpause so it can cancel. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter

Re: [Qemu-devel] [PATCH v3 4/7] migration: migrate-continue

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 06:40:10PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > A new qmp command allows the caller to continue from a given > paused state. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [PATCH] fdt_ro.c: implement strnlen

2017-10-18 Thread David Gibson
On Wed, Oct 18, 2017 at 10:39:57PM -0400, Programmingkid wrote: > > > On Oct 18, 2017, at 9:31 PM, David Gibson > > wrote: > > > > On Wed, Oct 18, 2017 at 06:31:16PM -0400, John Arbuckle wrote: > >> Implement the strnlen() function if it isn't implemented. > >> > >> Signed-off-by: John Arbuckl

Re: [Qemu-devel] [PATCH v3 3/7] migration: Wait for semaphore before completing migration

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 06:40:09PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Wait for a semaphore before completing the migration, > if the previously added capability was enabled. > > Signed-off-by: Dr. David Alan Gilbert > --- > migration/migration.c | 3

Re: [Qemu-devel] [PATCHv3 06/13] sparc32_dma: use object link instead of qdev property to pass IOMMU reference

2017-10-18 Thread Philippe Mathieu-Daudé
On 10/14/2017 03:38 PM, Mark Cave-Ayland wrote: > This enables us to remove the last remaining (opaque) qdev property. Whilst we > are here, also update iommu_init() to use TYPE_SUN4M_IOMMU instead of a > hardcoded string. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCHv3 05/13] sun4m_iommu: move TYPE_SUN4M_IOMMU declaration to sun4m.h

2017-10-18 Thread Philippe Mathieu-Daudé
On 10/14/2017 03:38 PM, Mark Cave-Ayland wrote: > This is in preparation to allow the type to be used elsewhere. > > Signed-off-by: Mark Cave-Ayland > --- > hw/dma/sun4m_iommu.c | 14 -- > include/hw/sparc/sun4m.h | 16 > 2 files changed, 16 insertions(+), 14

Re: [Qemu-devel] [PATCH v3 2/7] migration: Add 'pre-switchover' and 'device' statuses

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 06:40:08PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add two statuses for use when the 'pause-before-switchover' > capability is enabled. > > 'pre-switchover' is the state that we wait in for management > to allow us to continue. > 'd

Re: [Qemu-devel] [PATCHv3 02/13] sparc32_dma: split esp and le into separate DMA devices

2017-10-18 Thread Philippe Mathieu-Daudé
On 10/14/2017 03:38 PM, Mark Cave-Ayland wrote: > Due to slight differences in behaviour accessing the registers for the > esp and le devices, create two separate SPARC32_DMA_DEVICE types and > update the sun4m machine to use. > > Note that by using different device types we already know the size

Re: [Qemu-devel] [PATCH v3 0/7] migration: pause-before-switchover

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 06:40:06PM +0100, Dr. David Alan Gilbert (git) wrote: [...] > The precopy flow is: > active->pre-switchover->device->completed > > The postcopy flow is: > active->pre-switchover->postcopy-active->completed The naming is still slightly confusing to me: (1) we have a capa

Re: [Qemu-devel] [PATCHv3 01/13] sparc32_dma: rename SPARC32_DMA type to SPARC32_DMA_DEVICE

2017-10-18 Thread Philippe Mathieu-Daudé
Hi Mark, On 10/14/2017 03:38 PM, Mark Cave-Ayland wrote: > Also update the function names to match as appropriate. While we're > here rename the type from sparc32_dma to sparc32-dma in order to > match the current QOM convention. Where can I read on the QOM convention? > > Signed-off-by: Mark C

Re: [Qemu-devel] [PATCH v3 1/7] migration: Add 'pause-before-switchover' capability

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 06:40:07PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When 'pause-before-switchover' is enabled, the outgoing migration > will pause before invalidating the block devices and serializing > the device state. > At this point the managemen

Re: [Qemu-devel] host physical address width issues/questions for x86_64

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 10:19:31AM -0700, Prasad Singamsetty wrote: > > > On 10/16/2017 8:56 PM, Peter Xu wrote: > >On Mon, Oct 16, 2017 at 10:02:25AM -0700, Prasad Singamsetty wrote: > >> > >> > >>On 10/14/2017 8:53 PM, Peter Xu wrote: > >>>On Fri, Oct 13, 2017 at 11:14:03AM -0600, Alex Williams

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 01:10:38PM +0100, Daniel P. Berrange wrote: > On Wed, Oct 18, 2017 at 01:36:56PM +0200, Juan Quintela wrote: > > Peter Xu wrote: > > > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > > > > > > [...] > > > > > >> +/* A simple PC boot sector that modifies mem

Re: [Qemu-devel] [PATCH] fdt_ro.c: implement strnlen

2017-10-18 Thread Programmingkid
> On Oct 18, 2017, at 9:31 PM, David Gibson wrote: > > On Wed, Oct 18, 2017 at 06:31:16PM -0400, John Arbuckle wrote: >> Implement the strnlen() function if it isn't implemented. >> >> Signed-off-by: John Arbuckle > > Nice idea, but this won't work. > >> --- >> libfdt/fdt_ro.c | 24 +

[Qemu-devel] [PATCH qemu v3] pci: Initialize pci_dev->name before use

2017-10-18 Thread Alexey Kardashevskiy
This moves pci_dev->name initialization earlier so pci_dev->bus_master_as could get a name instead of an empty string. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu Signed-off-by: Alexey Kardashevskiy --- Changes: v3: * more "reviewed-by" * fixed spelling in commit log v2: * fixed

Re: [Qemu-devel] [PATCH] fdt_ro.c: implement strnlen

2017-10-18 Thread David Gibson
On Wed, Oct 18, 2017 at 06:31:16PM -0400, John Arbuckle wrote: > Implement the strnlen() function if it isn't implemented. > > Signed-off-by: John Arbuckle Nice idea, but this won't work. > --- > libfdt/fdt_ro.c | 24 > 1 file changed, 24 insertions(+) > > diff --git

Re: [Qemu-devel] libvirt/QEMU/SEV interaction

2017-10-18 Thread Michael S. Tsirkin
On Wed, Oct 18, 2017 at 08:18:48PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Fri, Sep 08, 2017 at 10:48:10AM -0500, Brijesh Singh wrote: > > > > > > 11. GO verifies the measurement and if measurement matches > > > > > then it may > > > > >

Re: [Qemu-devel] [PATCH v6 00/50] tcg tb_lock removal

2017-10-18 Thread Emilio G. Cota
On Mon, Oct 16, 2017 at 10:25:19 -0700, Richard Henderson wrote: > I've fixed two bugs within v5 of Emilio's patch set: > > - The step_next_tb patch fixes the "rep movsb" bug that appeared >when we included CF_COUNT_MASK into CF_HASH_MASK. We had been >relying on magic to single-step the

[Qemu-devel] [PATCH] don't hardcode EL1 in extended_addresses_enabled

2017-10-18 Thread Stefano Stabellini
extended_addresses_enabled calls arm_el_is_aa64, hardcoding exception level 1. Instead, retrieve the current el calling arm_current_el. Signed-off-by: Stefano Stabellini diff --git a/target/arm/internals.h b/target/arm/internals.h index 1f6efef..63507d9 100644 --- a/target/arm/internals.h +++ b/

[Qemu-devel] [PATCH] fdt_ro.c: implement strnlen

2017-10-18 Thread John Arbuckle
Implement the strnlen() function if it isn't implemented. Signed-off-by: John Arbuckle --- libfdt/fdt_ro.c | 24 1 file changed, 24 insertions(+) diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c index 3d00d2e..a7986fb 100644 --- a/libfdt/fdt_ro.c +++ b/libfdt/fdt_ro.c @@

[Qemu-devel] [PATCH] fix WFI/WFE length in syndrome register

2017-10-18 Thread Stefano Stabellini
WFI/E are 4 bytes long: set ARM_EL_IL_SHIFT in the syndrome. Signed-off-by: Stefano Stabellini diff --git a/target/arm/internals.h b/target/arm/internals.h index 1f6efef..cf8c966 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -398,6 +398,7 @@ static inline uint32_t syn_break

[Qemu-devel] [PATCH 3/4] translate-all: fix 'consisits' typo in comment

2017-10-18 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- accel/tcg/translate-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index c5ce99d..70942be 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -255,7 +255,7 @@ s

[Qemu-devel] [PATCH 1/4] disas/arm: fix 'instuction' typo in comment

2017-10-18 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- disas/arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/arm.c b/disas/arm.c index 27396dd..6f2079d 100644 --- a/disas/arm.c +++ b/disas/arm.c @@ -1651,7 +1651,7 @@ print_insn_coprocessor (bfd_vma pc, struct disassemble_info *info, l

[Qemu-devel] [PATCH 4/4] qht: fix kernel-doc markup in qht.h

2017-10-18 Thread Emilio G. Cota
While at it, s/stuct/struct/. Signed-off-by: Emilio G. Cota --- include/qemu/qht.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qemu/qht.h b/include/qemu/qht.h index 56c2c77..531aa95 100644 --- a/include/qemu/qht.h +++ b/include/qemu/qht.h @@ -166,7 +166,7 @@

[Qemu-devel] [PATCH 2/4] linux-user: fix 'finshed' typo in comment

2017-10-18 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 9d4cc4c..47b4a79 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6231,7 +6231,7 @@ static void *clone_func(

[Qemu-devel] [PATCH 0/4] Some trivial fixes, mostly comment typos

2017-10-18 Thread Emilio G. Cota
A few trivial fixes that I embedded in a previous (unrelated) patchset. Better to submit them separately as a standalone "trivial" patchset. Note that in patch 1 I went with space indentation instead of a hard tab just to appease checkpatch. However, the surrounding code uses hard tabs. Wasn't sur

Re: [Qemu-devel] [PATCH] tests: report errors when iasl exits with non-zero status

2017-10-18 Thread Philippe Mathieu-Daudé
On 10/18/2017 10:15 AM, Daniel P. Berrange wrote: > If iasl exits with non-zero status, the test unhelpfully just reports > that the AML did not match, because the data files it thought iasl > generated do not exist. This adds an explicit check for the exit status > of iasl and prints stderr if it

Re: [Qemu-devel] [PATCH v5 4/9] disas: Support the Capstone disassembler library

2017-10-18 Thread Philippe Mathieu-Daudé
On 10/17/2017 12:37 PM, Richard Henderson wrote: > If configured, prefer this over our rather dated copy of the > GPLv2-only binutils. This will be especially apparent with > the proposed vector extensions to TCG, as disas/i386.c does > not handle AVX. > > Signed-off-by: Richard Henderson Revie

Re: [Qemu-devel] [PATCH] build: Fix dtc-checkout race condition in Makefile

2017-10-18 Thread Philippe Mathieu-Daudé
On 10/18/2017 03:40 PM, Aaron Lindsay wrote: > This was introduced by: > commit aef45d51d1204f3335fb99de6658e0c5612c2b67 > Author: Daniel P. Berrange > Date: Fri Sep 29 11:11:56 2017 +0100 > > build: automatically handle GIT submodule checkout for dtc > > On my system, I see

Re: [Qemu-devel] [PATCH v6 20/50] qom: Introduce CPUClass.tcg_initialize

2017-10-18 Thread Philippe Mathieu-Daudé
On 10/16/2017 02:25 PM, Richard Henderson wrote: > Move target cpu tcg initialization to common code, > called from cpu_exec_realizefn. > > Cc: Andreas Färber > Signed-off-by: Richard Henderson much cleaner, esp. the CRIS part. Reviewed-by: Philippe Mathieu-Daudé > --- > include/qom/cpu.h

Re: [Qemu-devel] [PATCH] watch_mem_write: implement 8-byte accesses

2017-10-18 Thread Philippe Mathieu-Daudé
On 10/17/2017 09:17 AM, Paolo Bonzini wrote: > Aligned 8-byte memory writes by a 64-bit target on a 64-bit host should > always turn into atomic 8-byte writes on the host, however a write > write watchpoint would end up tearing the 8-byte write into two 4-byte > writes in access_with_adjusted_size(

Re: [Qemu-devel] [PATCH] watch_mem_write: implement 8-byte accesses

2017-10-18 Thread Emilio G. Cota
On Tue, Oct 17, 2017 at 14:17:14 +0200, Paolo Bonzini wrote: > Aligned 8-byte memory writes by a 64-bit target on a 64-bit host should > always turn into atomic 8-byte writes on the host, however a write > write watchpoint would end up tearing the 8-byte write into two 4-byte s/write\nwrite/write/

Re: [Qemu-devel] [PATCH v2 0/7] migration: pause-before-switchover

2017-10-18 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Message-id: 20171018170138.19078-1-dgilb...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/7] migration: pause-before-switchover Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under

Re: [Qemu-devel] [PATCH v6 46/50] tcg: allocate optimizer temps with tcg_malloc

2017-10-18 Thread Richard Henderson
On 10/17/2017 09:35 PM, Emilio G. Cota wrote: > On Mon, Oct 16, 2017 at 10:26:05 -0700, Richard Henderson wrote: >> From: "Emilio G. Cota" > > (snip) >> Suggested-by: Richard Henderson >> Signed-off-by: Emilio G. Cota >> >> Signed-off-by: Richard Henderson >> >> Signed-off-by: Richard Henderso

Re: [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP

2017-10-18 Thread Eduardo Habkost
On Wed, Oct 18, 2017 at 04:30:10PM +0100, Daniel P. Berrange wrote: > On Tue, Oct 17, 2017 at 06:06:35PM +0200, Igor Mammedov wrote: > > On Tue, 17 Oct 2017 16:07:59 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Tue, Oct 17, 2017 at 09:27:02AM +0200, Igor Mammedov wrote: > > > > On Mon, 16 O

Re: [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP

2017-10-18 Thread Eduardo Habkost
On Wed, Oct 18, 2017 at 04:27:47PM +0100, Daniel P. Berrange wrote: > On Wed, Oct 18, 2017 at 05:24:12PM +0200, Igor Mammedov wrote: > > On Wed, 18 Oct 2017 15:49:36 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Wed, Oct 18, 2017 at 04:44:35PM +0200, Igor Mammedov wrote: > > > > not sure I p

Re: [Qemu-devel] [PATCH v1 2/2] s390x/tcg: low-address protection support

2017-10-18 Thread David Hildenbrand
On 18.10.2017 20:21, Thomas Huth wrote: > On 16.10.2017 22:23, David Hildenbrand wrote: >> This is a neat way to implement low address protection, whereby >> only the first 512 bytes of the first two pages (each 4096 bytes) of >> every address space are protected. >> >> Store a tec of 0 for the acc

Re: [Qemu-devel] libvirt/QEMU/SEV interaction

2017-10-18 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, Sep 08, 2017 at 10:48:10AM -0500, Brijesh Singh wrote: > > > > > 11. GO verifies the measurement and if measurement matches then > > > > it may > > > > > give a secret blob -- which must be injected into the guest > > > > before >

Re: [Qemu-devel] [PATCH v6 20/50] qom: Introduce CPUClass.tcg_initialize

2017-10-18 Thread Andreas Färber
Am 18.10.2017 um 01:53 schrieb Emilio G. Cota: > On Mon, Oct 16, 2017 at 10:25:39 -0700, Richard Henderson wrote: >> Move target cpu tcg initialization to common code, >> called from cpu_exec_realizefn. >> >> Cc: Andreas Färber >> Signed-off-by: Richard Henderson > > Much cleaner! > > Reviewed-

Re: [Qemu-devel] [PATCH v11 5/6] migration: add blocktime calculation into postcopy-test

2017-10-18 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This patch just requests blocktime calculation, > and check it in case when UFFD_FEATURE_THREAD_ID feature is set > on the host. > > Signed-off-by: Alexey Perevalov Reviewed-by: Dr. David Alan Gilbert (I preferred the bool got_stop and expl

Re: [Qemu-devel] [PATCH v11 3/6] migration: calculate vCPU blocktime on dst side

2017-10-18 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This patch provides blocktime calculation per vCPU, > as a summary and as a overlapped value for all vCPUs. > > This approach was suggested by Peter Xu, as an improvements of > previous approch where QEMU kept tree with faulted page address and

[Qemu-devel] [PATCH] build: Fix dtc-checkout race condition in Makefile

2017-10-18 Thread Aaron Lindsay
This was introduced by: commit aef45d51d1204f3335fb99de6658e0c5612c2b67 Author: Daniel P. Berrange Date: Fri Sep 29 11:11:56 2017 +0100 build: automatically handle GIT submodule checkout for dtc On my system, I see the following with a fresh clone: % ./configure --disable-

Re: [Qemu-devel] [PATCH v1 2/2] s390x/tcg: low-address protection support

2017-10-18 Thread Thomas Huth
On 16.10.2017 22:23, David Hildenbrand wrote: > This is a neat way to implement low address protection, whereby > only the first 512 bytes of the first two pages (each 4096 bytes) of > every address space are protected. > > Store a tec of 0 for the access exception, this is what is defined by > En

Re: [Qemu-devel] [PATCH v6 38/50] translate-all: use a binary search tree to track TBs in TBContext

2017-10-18 Thread Emilio G. Cota
On Wed, Oct 18, 2017 at 09:41:43 +0200, Paolo Bonzini wrote: > On 16/10/2017 19:25, Richard Henderson wrote: > > * Translation Cache-related fields of a TB. > > + * This struct exists just for convenience; we keep track of TB's in a > > binary > > + * search tree, and the only fields needed to c

Re: [Qemu-devel] [PATCH v2 0/7] migration: pause-before-switchover

2017-10-18 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20171018170138.19078-1-dgilb...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/7] migration: pause-befo

[Qemu-devel] [PATCH v3 7/7] migration: pause-before-switchover for postcopy

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add pause-before-switchover support for postcopy. After starting postcopy it will transition active->pre-switchover->postcopy_active Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 29 ++--- 1 file changed, 22 inserti

[Qemu-devel] [PATCH v3 5/7] migrate: HMP migate_continue

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" HMP equivalent to the just added migrate-continue Unpause a migrate paused at a given state. Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.hx | 12 hmp.c | 13 + hmp.h | 1 + 3 files changed, 26 insertions(+)

[Qemu-devel] [PATCH v3 6/7] migration: allow cancel to unpause

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" If a migration_cancel is issued during the new paused state, kick the pause_sem to get to unpause so it can cancel. Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 4 1 file changed, 4 insertions(+) diff --git a/migration/migration.c b/mig

[Qemu-devel] [PATCH v3 3/7] migration: Wait for semaphore before completing migration

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Wait for a semaphore before completing the migration, if the previously added capability was enabled. Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 38 ++ migration/migration.h | 3 +++ 2 files changed, 41

[Qemu-devel] [PATCH v3 2/7] migration: Add 'pre-switchover' and 'device' statuses

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add two statuses for use when the 'pause-before-switchover' capability is enabled. 'pre-switchover' is the state that we wait in for management to allow us to continue. 'device' is the state we enter while serialising the devices after management gives us the OK.

Re: [Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use

2017-10-18 Thread Michael S. Tsirkin
On Tue, Oct 17, 2017 at 04:00:05PM +1100, Alexey Kardashevskiy wrote: > On 15/10/17 19:01, Peter Xu wrote: > > On Sun, Oct 15, 2017 at 03:24:52PM +1100, Alexey Kardashevskiy wrote: > >> This moves pci_dev->name initialization earlier so > >> pci_dev->bus_master_as could get a name instead of an emp

[Qemu-devel] [PATCH v3 0/7] migration: pause-before-switchover

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This set attempts to make a race condition between migration and drive-mirror (and other block users) soluble by allowing the migration to be paused after the source qemu releases the block devices but before the serialisation of the device state. The symptom

[Qemu-devel] [PATCH v3 1/7] migration: Add 'pause-before-switchover' capability

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When 'pause-before-switchover' is enabled, the outgoing migration will pause before invalidating the block devices and serializing the device state. At this point the management layer gets the chance to clean up any device jobs or other device users before the migra

[Qemu-devel] [PATCH v3 4/7] migration: migrate-continue

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" A new qmp command allows the caller to continue from a given paused state. Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 11 +++ qapi/migration.json | 17 + 2 files changed, 28 insertions(+) diff --git a/migration/mi

Re: [Qemu-devel] [PATCH RESEND 0/2] x86_iommu: Fix segfault when starting on non-PCI machines

2017-10-18 Thread Michael S. Tsirkin
On Mon, Oct 16, 2017 at 05:31:25PM +0800, Peter Xu wrote: > On Mon, Oct 16, 2017 at 11:06:21AM +0200, Mohammed Gamal wrote: > > Starting qemu with > > qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu > > leads to a segfault. The code assume PCI bus is present and > > tries to access the bus

Re: [Qemu-devel] [PATCH v4 00/10] qemu-iotests improvements

2017-10-18 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1508213452.git.jc...@redhat.com Subject: [Qemu-devel] [PATCH v4 00/10] qemu-iotests improvements === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --

Re: [Qemu-devel] [PATCH V2] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-10-18 Thread Michael S. Tsirkin
On Wed, Oct 18, 2017 at 02:16:12PM +0300, Marcel Apfelbaum wrote: > Currently there is no MMIO range over 4G > reserved for PCI hotplug. Since the 32bit PCI hole > depends on the number of cold-plugged PCI devices > and other factors, it is very possible is too small > to hotplug PCI devices with l

Re: [Qemu-devel] [PATCH v5 03/10] qemu-iotests: automatically clean up bash protocol servers

2017-10-18 Thread Jeff Cody
On Wed, Oct 18, 2017 at 06:39:26PM +0200, Paolo Bonzini wrote: > On 18/10/2017 18:19, Jeff Cody wrote: > >>> Here is what we need from common.rc for this series: > >>> > >>> _rm_test_img > >>> _cleanup_nbd > >>> _cleanup_vxhs > >>> _cleanup_rbd > >>> _cleanup_sheepdog > >>> _cleanup_protocols > >>>

Re: [Qemu-devel] [PATCH v2 0/7] migration: pause-before-switchover

2017-10-18 Thread Dr. David Alan Gilbert
Oops, a couple of fixups I hadn't merged down; v3 coming. Dave * no-re...@patchew.org (no-re...@patchew.org) wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. > > Message-id: 20171018170138.19078-1-dgilb...@redhat.com > Subject: [Qemu-devel] [PATCH v2

Re: [Qemu-devel] [PATCH 3/4] multiboot: load elf sections and section headers

2017-10-18 Thread Anatol Pomozov
Hello qemu-devs, This patchset has been posted a while ago. I would like to move forward with it and look at the next task (e.g. multiboot2 support in QEMU). Who is the multiboot code maintainer who can help to review this patchset and give go/no-go answer? On Thu, Oct 12, 2017 at 4:54 PM, Anatol

Re: [Qemu-devel] host physical address width issues/questions for x86_64

2017-10-18 Thread Prasad Singamsetty
On 10/16/2017 8:56 PM, Peter Xu wrote: On Mon, Oct 16, 2017 at 10:02:25AM -0700, Prasad Singamsetty wrote: On 10/14/2017 8:53 PM, Peter Xu wrote: On Fri, Oct 13, 2017 at 11:14:03AM -0600, Alex Williamson wrote: On Fri, 13 Oct 2017 18:01:44 +0100 "Dr. David Alan Gilbert" wrote: * Prasad

Re: [Qemu-devel] [PULL 00/29] Misc patches for 2017-10-18

2017-10-18 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1508343141-31835-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel] [PULL 00/29] Misc patches for 2017-10-18 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tota

[Qemu-devel] [PATCH v2 7/7] migration: pause-before-switchover for postcopy

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add pause-before-switchover support for postcopy. After starting postcopy it will transition active->pre-switchover->postcopy_active Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 29 ++--- 1 file changed, 22 inserti

[Qemu-devel] [PATCH v2 5/7] migrate: HMP migate_continue

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" HMP equivalent to the just added migrate-continue Unpause a migrate paused at a given state. Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.hx | 12 hmp.c | 13 + hmp.h | 1 + 3 files changed, 26 insertions(+)

[Qemu-devel] [PATCH v2 3/7] migration: Wait for semaphore before completing migration

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Wait for a semaphore before completing the migration, if the previously added capability was enabled. Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 38 ++ migration/migration.h | 3 +++ 2 files changed, 41

[Qemu-devel] [PATCH v2 4/7] migration: migrate-continue

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" A new qmp command allows the caller to continue from a given paused state. Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 11 +++ qapi/migration.json | 17 + 2 files changed, 28 insertions(+) diff --git a/migration/mi

[Qemu-devel] [PATCH v2 6/7] migration: allow cancel to unpause

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" If a migration_cancel is issued during the new paused state, kick the pause_sem to get to unpause so it can cancel. Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 4 1 file changed, 4 insertions(+) diff --git a/migration/migration.c b/mig

[Qemu-devel] [PATCH v2 2/7] migration: Add 'pre-switchover' and 'device' statuses

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add two statuses for use when the 'pause-before-switchover' capability is enabled. 'pre-switchover' is the state that we wait in for management to allow us to continue. 'device' is the state we enter while serialising the devices after management gives us the OK.

[Qemu-devel] [PATCH v2 1/7] migration: Add 'pause-before-switchover' capability

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When 'pause-before-switchover' is enabled, the outgoing migration will pause before invalidating the block devices and serializing the device state. At this point the management layer gets the chance to clean up any device jobs or other device users before the migra

[Qemu-devel] [PATCH v2 0/7] migration: pause-before-switchover

2017-10-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This set attempts to make a race condition between migration and drive-mirror (and other block users) soluble by allowing the migration to be paused after the source qemu releases the block devices but before the serialisation of the device state. The symptom

[Qemu-devel] [Bug 1724590] [NEW] Usermode networking hostfwd only listens on IPv4

2017-10-18 Thread Willem Mulder
Public bug reported: When forwarding ports in usermode networking (-net user,hostfwd=), QEMU binds to IPv4 only. Therefore, connecting to the port over IPv6 results in 'connection refused'. I experienced this in QEMU 2.10.1, but it looks to still be present in the current master (861cd431c99e56dd

Re: [Qemu-devel] [PATCH v5 03/10] qemu-iotests: automatically clean up bash protocol servers

2017-10-18 Thread Paolo Bonzini
On 18/10/2017 18:19, Jeff Cody wrote: >>> Here is what we need from common.rc for this series: >>> >>> _rm_test_img >>> _cleanup_nbd >>> _cleanup_vxhs >>> _cleanup_rbd >>> _cleanup_sheepdog >>> _cleanup_protocols >>> _cleanup_test_img >>> >>> They all have a common theme (cleanup), so I could move

Re: [Qemu-devel] [PATCH v3 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-18 Thread Peter Maydell
On 18 October 2017 at 17:10, Cédric Le Goater wrote: > On 10/17/2017 05:39 PM, Peter Maydell wrote: >> A "reads like RAM but writes are ignored" lump of memory is easy... > > yes. It seems but I haven't found my way through :/ memory_region_init_rom_device() creates a memory region which is backe

Re: [Qemu-devel] [PATCH v5 03/10] qemu-iotests: automatically clean up bash protocol servers

2017-10-18 Thread Jeff Cody
On Wed, Oct 18, 2017 at 05:51:53PM +0200, Paolo Bonzini wrote: > On 18/10/2017 17:50, Jeff Cody wrote: > > Here is what we need from common.rc for this series: > > > > _rm_test_img > > _cleanup_nbd > > _cleanup_vxhs > > _cleanup_rbd > > _cleanup_sheepdog > > _cleanup_protocols > > _cleanup_test_im

[Qemu-devel] [PULL 27/29] Revert "qdev: Free QemuOpts when the QOM path goes away"

2017-10-18 Thread Paolo Bonzini
From: Michael Roth This reverts commit abed886ec60cf239a03515cf0b30fb11fa964c44. This patch originally addressed an issue where a DEVICE_DELETED event could be emitted (in device_unparent()) before a Device's QemuOpts were cleaned up (in device_finalize()), leading to a "duplicate ID" error if m

  1   2   3   4   >