Re: [Qemu-devel] [PATCH v2 1/1] xilinx_spips: send dummy cycles only if cmd requires it

2018-04-18 Thread Sai Pavan Boddu
HI Franciso, From: francisco iglesias [mailto:frasse.igles...@gmail.com] Sent: Thursday, April 19, 2018 3:39 AM To: Sai Pavan Boddu Cc: alist...@alistair23.me; Peter Crosthwaite ; Peter Maydell ; Edde

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.13 0/4] pc-bios/s390-ccw: Network boot improvements

2018-04-18 Thread Thomas Huth
On 18.04.2018 20:21, Farhan Ali wrote: > On 04/18/2018 08:31 AM, Thomas Huth wrote: >> Some patches to improve the network boot experience on s390x: >> >> First, make sure that we shut down the virtio-net device before jumping >> into the kernel. Otherwise some incoming packets might destroy some

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.13 1/4] pc-bios/s390-ccw/net: Split up net_load() into init, load and uninit parts

2018-04-18 Thread Thomas Huth
On 18.04.2018 20:11, Farhan Ali wrote: > > > On 04/18/2018 08:31 AM, Thomas Huth wrote: >> When we want to support pxelinux-style network booting later, we've got >> to do several TFTP transfers - and we do not want to apply for a new IP >> address via DHCP each time. So split up net_load into

Re: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes

2018-04-18 Thread Thomas Huth
On 19.04.2018 04:06, Fam Zheng wrote: > On Mon, 04/16 16:09, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> On 12.03.2018 14:18, Stefan Hajnoczi wrote: Warn if files are added/renamed/deleted without MAINTAINERS file changes. This has helped me in Linux and we

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-18 Thread Balamuruhan S
On Wed, Apr 18, 2018 at 09:36:33AM +0100, Dr. David Alan Gilbert wrote: > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > On Wed, Apr 18, 2018 at 10:57:26AM +1000, David Gibson wrote: > > > On Wed, Apr 18, 2018 at 10:55:50AM +1000, David Gibson wrote: > > > > On Tue, Apr 17, 2018 at

Re: [Qemu-devel] [sw-dev] The problem of write misa on QEMU and BBL

2018-04-18 Thread Michael Clark
Hi Zong, > On 19/04/2018, at 2:40 PM, Zong Li wrote: > > Hi all, > > For BBL part, in fp_init at machine/minit.c, > it will clear the D and F bits of misa register, and assertion that > the bits is cleared. > But the misa is WARL register, so there is no effect for writing

[Qemu-devel] [Bug 1708077] Re: PPC interrupt exception!

2018-04-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1708077 Title: PPC

Re: [Qemu-devel] [PATCH for-2.13 v2 2/5] ppc: e500: switch E500 based machines to full machine definition

2018-04-18 Thread David Gibson
On Wed, Apr 18, 2018 at 04:28:02PM +0200, Igor Mammedov wrote: > Convert PPCE500Params to PCCE500MachineClass which it essentially is, > and introduce PCCE500MachineState to keep track of E500 specific > state instead of adding global variables or extra parameters to > functions when we need to

Re: [Qemu-devel] [PATCH] Show values and description when using "qom-list"

2018-04-18 Thread QingFeng Hao
在 2018/4/13 16:05, Perez Blanco, Ricardo (Nokia - BE/Antwerp) 写道: > Dear all, > > Here you can find my first contribution to qemu. Please, do not hesitate to > do any kind of remark. > > Based on ac4ba87ae0738d7a77708f8ce31ae2378ab99654 > > Kind regards, > > Ricardo Perez Blanco > >>From

Re: [Qemu-devel] Why is there no qom_get in hmp.c?

2018-04-18 Thread QingFeng Hao
在 2018/4/18 22:04, Dr. David Alan Gilbert 写道: > * QingFeng Hao (ha...@linux.vnet.ibm.com) wrote: >> Hi all, >> I did some investigation and found that "virsh qemu-monitor-command" >> supports qom-get, >> but qemu hmp doesn't. However, in hmp.c there are qom_list and qom_set. It >> confused me

Re: [Qemu-devel] [PATCH v2] QemuMutex: support --enable-debug-mutex

2018-04-18 Thread Peter Xu
On Thu, Apr 19, 2018 at 09:56:31AM +0800, Fam Zheng wrote: > On Wed, 04/18 17:06, Peter Xu wrote: > > We have had some tracing tools for mutex but it's not easy to use them > > for e.g. dead locks. Let's provide "--enable-debug-mutex" parameter > > when configure to allow QemuMutex to store the

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

2018-04-18 Thread Alexey Kardashevskiy
On 12/4/18 7:15 pm, Paolo Bonzini wrote: > On 29/03/2018 05:21, Alexey Kardashevskiy wrote: >> +DeviceState *dev = (DeviceState *) object_dynamic_cast(obj, >> TYPE_DEVICE); >> +const char *id = object_property_print(obj, "id", true, NULL); > > I learnt now about commit

Re: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes

2018-04-18 Thread Fam Zheng
On Mon, 04/16 16:09, Markus Armbruster wrote: > Thomas Huth writes: > > > On 12.03.2018 14:18, Stefan Hajnoczi wrote: > >> Warn if files are added/renamed/deleted without MAINTAINERS file > >> changes. This has helped me in Linux and we could benefit from this > >> check in

Re: [Qemu-devel] [PATCH v2] QemuMutex: support --enable-debug-mutex

2018-04-18 Thread Fam Zheng
On Wed, 04/18 17:06, Peter Xu wrote: > We have had some tracing tools for mutex but it's not easy to use them > for e.g. dead locks. Let's provide "--enable-debug-mutex" parameter > when configure to allow QemuMutex to store the last owner that took > specific lock. It might be extremely easy to

Re: [Qemu-devel] [PATCH] qemu-progress: redirct qemu progress message to another file stream

2018-04-18 Thread Zhenwei.Pi
On 04/18/2018 09:06 PM, Max Reitz wrote: On 2018-04-16 09:46, zhenwei pi wrote: currently qemu progress message only print into stdout, and other thread may print some log into stdout at the same time. add a new api qemu_progress_set_output to redirect progress message to another file stream.

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread David Gibson
On Wed, 18 Apr 2018 10:32:06 +0200 Laszlo Ersek wrote: > On 04/18/18 08:02, Gerd Hoffmann wrote: > [...] > [...] > > > > Looks good to me overall. > > > >> +{ 'enum' : 'FirmwareType', > >> + 'data' : [ 'bios', 'slof', 'uboot', 'uefi' ] } > > > > openbios missing. >

Re: [Qemu-devel] [PATCH v2 1/1] xilinx_spips: send dummy cycles only if cmd requires it

2018-04-18 Thread francisco iglesias
Hi Sai, About the subject, what do you think about changing it to below? xilinx_spips: Correct SNOOP_NONE state when flushing the txfifo On 18 April 2018 at 09:41, Sai Pavan Boddu wrote: > For all the commands, which do not have an entry in >

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180418123838.3511-1-o...@aepfle.de Subject: [Qemu-devel] [PATCH v1] configure:

[Qemu-devel] qemu 2.10 100% cpu with coreduo

2018-04-18 Thread J-F M.
Hi, FYI 100% cpu usage on kernel 4.15.8 coreduo 2 cores, address sizes 0 bits virtual. no problem with qemu cpu 2.5+. regards, jfm

Re: [Qemu-devel] [PATCH v1 for-2.13 0/4] pc-bios/s390-ccw: Network boot improvements

2018-04-18 Thread Farhan Ali
On 04/18/2018 08:31 AM, Thomas Huth wrote: Some patches to improve the network boot experience on s390x: First, make sure that we shut down the virtio-net device before jumping into the kernel. Otherwise some incoming packets might destroy some of the kernel's data if it has not taken over

Re: [Qemu-devel] [PATCH v1 for-2.13 1/4] pc-bios/s390-ccw/net: Split up net_load() into init, load and uninit parts

2018-04-18 Thread Farhan Ali
On 04/18/2018 08:31 AM, Thomas Huth wrote: When we want to support pxelinux-style network booting later, we've got to do several TFTP transfers - and we do not want to apply for a new IP address via DHCP each time. So split up net_load into three parts: 1. net_init(), which initializes

Re: [Qemu-devel] [PATCH v2] configure: add sanity check to catch builds from "git archive"

2018-04-18 Thread Cornelia Huck
On Wed, 18 Apr 2018 18:11:51 +0100 Daniel P. Berrangé wrote: > The "git archive" feature creates tarballs which are missing all > submodule content. GitHub unhelpfully provides users with "Download" > links that claim to give them valid source release tarballs. These >

Re: [Qemu-devel] [PATCH 1/4] update-linux-headers.sh: drop kvm_para.h hacks

2018-04-18 Thread Cornelia Huck
On Tue, 17 Apr 2018 21:58:21 +0300 "Michael S. Tsirkin" wrote: > It turns out (as will be clear from follow-up patches) > we do not really need any kvm para macros host side > for now, except on x86, and there we need it > unconditionally whether we run on kvm or we don't. > >

Re: [Qemu-devel] [PATCH v5 00/21] blockjobs: add explicit job management

2018-04-18 Thread Markus Armbruster
John Snow writes: > On 04/18/2018 03:25 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 04/17/2018 09:44 AM, Markus Armbruster wrote: John Snow writes: > This series seeks to address two distinct but closely

Re: [Qemu-devel] [PATCH 1/4] update-linux-headers.sh: drop kvm_para.h hacks

2018-04-18 Thread Cornelia Huck
On Wed, 18 Apr 2018 19:05:15 +0300 "Michael S. Tsirkin" wrote: > On Wed, Apr 18, 2018 at 09:54:26AM +0200, Cornelia Huck wrote: > > On Tue, 17 Apr 2018 21:58:21 +0300 > > "Michael S. Tsirkin" wrote: > > > > > It turns out (as will be clear from follow-up

[Qemu-devel] [PATCH v2] dump: add Windows dump format to dump-guest-memory

2018-04-18 Thread Viktor Prutyanov
This patch adds Windows crashdumping feature. Now QEMU can produce ELF-dump containing Windows crashdump header, which can help to convert to a valid WinDbg-understandable crashdump file, or immediately create such file. The crashdump will be obtained by joining physical memory dump and 8K header

Re: [Qemu-devel] [PATCH v5 00/21] blockjobs: add explicit job management

2018-04-18 Thread John Snow
On 04/18/2018 03:25 AM, Markus Armbruster wrote: > John Snow writes: > >> On 04/17/2018 09:44 AM, Markus Armbruster wrote: >>> John Snow writes: >>> This series seeks to address two distinct but closely related issues concerning the job management

[Qemu-devel] [PATCH v2] configure: add sanity check to catch builds from "git archive"

2018-04-18 Thread Daniel P . Berrangé
The "git archive" feature creates tarballs which are missing all submodule content. GitHub unhelpfully provides users with "Download" links that claim to give them valid source release tarballs. These GitHub archives will not be buildable as they are created by the "git archive" feature and so are

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 06:52:08PM +0200, Kevin Wolf wrote: > Am 18.04.2018 um 18:34 hat Daniel P. Berrangé geschrieben: > > On Wed, Apr 18, 2018 at 06:28:23PM +0200, Kevin Wolf wrote: > > > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > > > > > > Note that users can still

Re: [Qemu-devel] [PATCH v5 1/5] qobject: ensure base is at offset 0

2018-04-18 Thread Eric Blake
On 04/18/2018 11:45 AM, Markus Armbruster wrote: >> Might also be worth mentioning that this explicitly guarantees that >> existing casts work correctly (even though we'd prefer to get rid of >> such casts in any location except the qobject.h macros); Markus pointed out: >> Uh, there's

Re: [Qemu-devel] [PATCH v5 1/5] qobject: ensure base is at offset 0

2018-04-18 Thread Marc-André Lureau
Hi On Wed, Apr 18, 2018 at 6:45 PM, Markus Armbruster wrote: > Eric Blake writes: > >> On 04/17/2018 08:35 AM, Marc-André Lureau wrote: >>> All QObject types have the base QObject as first field. This allows to >> >> s/as/as their/ >> >>> simplify

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 18:34 hat Daniel P. Berrangé geschrieben: > On Wed, Apr 18, 2018 at 06:28:23PM +0200, Kevin Wolf wrote: > > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > > > > Note that users can still configure authentication methods with a > > > configuration file. They

Re: [Qemu-devel] [PATCH v5 1/5] qobject: ensure base is at offset 0

2018-04-18 Thread Markus Armbruster
Eric Blake writes: > On 04/17/2018 08:35 AM, Marc-André Lureau wrote: >> All QObject types have the base QObject as first field. This allows to > > s/as/as their/ > >> simplify qobject_to() and will allow further simplification in > > s/allows to simplify/allows the

Re: [Qemu-devel] [PATCH] nbd/server: introduce NBD_CMD_CACHE

2018-04-18 Thread Eric Blake
On 04/13/2018 09:31 AM, Vladimir Sementsov-Ogievskiy wrote: > Handle nbd CACHE command. Just do read, without sending read data back. > Cache mechanism should be done by exported node driver chain. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [Qemu-devel] [PATCH qemu v4 1/2] qmp: Merge ObjectPropertyInfo and DevicePropertyInfo

2018-04-18 Thread Eric Blake
On 03/02/2018 06:25 PM, Alexey Kardashevskiy wrote: > ObjectPropertyInfo is more generic and only missing @description. > This adds a description to ObjectPropertyInfo and removes > DevicePropertyInfo so the resulting ObjectPropertyInfo can be used > elsewhere. > > Signed-off-by: Alexey

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 06:28:23PM +0200, Kevin Wolf wrote: > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > > Note that users can still configure authentication methods with a > > configuration file. They probably do that anyway if they use Ceph > > outside QEMU as

Re: [Qemu-devel] [PATCH v3 6/6] vhost-user: support registering external host notifiers

2018-04-18 Thread Michael S. Tsirkin
On Thu, Apr 12, 2018 at 11:12:32PM +0800, Tiwei Bie wrote: > This patch introduces VHOST_USER_PROTOCOL_F_HOST_NOTIFIER. > With this feature negotiated, vhost-user backend can register > memory region based host notifiers. And it will allow the guest > driver in the VM to notify the hardware

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.13 v2 4/5] platform-bus-device: use device plug callback instead of machine_done notifier

2018-04-18 Thread Philippe Mathieu-Daudé
On 04/18/2018 11:28 AM, Igor Mammedov wrote: > platform-bus were using machine_done notifier to get and map > (assign irq/mmio resources) dynamically added sysbus devices > after all '-device' options had been processed. > That however creates non obvious dependencies on ordering of > machine_done

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > The legacy command line syntax supports a "password-secret" option that > > allows to pass an authentication key to Ceph. This was not supported in > > QMP so far. > > We tried during

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.13 v2 1/5] arm: always start from first_cpu when registering loader cpu reset callback

2018-04-18 Thread Philippe Mathieu-Daudé
On 04/18/2018 11:28 AM, Igor Mammedov wrote: > if arm_load_kernel() were passed non first_cpu, QEMU would end up > with partially set do_cpu_reset() callback leaving some CPUs without it. > > Make sure that do_cpu_reset() is registered for all CPUs by enumerating > CPUs from first_cpu. > >

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.13 v2 3/5] pc: simplify MachineClass::get_hotplug_handler handling

2018-04-18 Thread Philippe Mathieu-Daudé
On 04/18/2018 11:56 AM, Eduardo Habkost wrote: > On Wed, Apr 18, 2018 at 04:28:03PM +0200, Igor Mammedov wrote: >> By default MachineClass::get_hotplug_handler is NULL and concrete board >> should set it to it's own handler. >> Considering there isn't any default handler, drop saving empty >>

[Qemu-devel] [Bug 1254443] Re: Periodic mode of LAPIC doesn't fire interrupts when using kvm

2018-04-18 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 1222034] Re: QEMU + SPICE + AUDIO = FAILURE

2018-04-18 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU and a recent guest kernel? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 1228285] Re: e1000 nic TCP performances

2018-04-18 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 1386197] Re: keyboard suddenly stops working in VM and problem persists until host reboot. All super-standard setup no funny stuff

2018-04-18 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH 1/4] update-linux-headers.sh: drop kvm_para.h hacks

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 09:54:26AM +0200, Cornelia Huck wrote: > On Tue, 17 Apr 2018 21:58:21 +0300 > "Michael S. Tsirkin" wrote: > > > It turns out (as will be clear from follow-up patches) > > we do not really need any kvm para macros host side > > for now, except on x86, and

Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread Paolo Bonzini
On 18/04/2018 16:54, Olaf Hering wrote: > Since usage of g_realloc_n was introduced, glib-2.22 can not be used > anymore on Linux. Leave non-Linux unchanged because one developer system > still uses it. > Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > Signed-off-by: Olaf Hering

Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread Olaf Hering
Am Wed, 18 Apr 2018 10:04:03 -0500 schrieb Eric Blake : > avoid g_realloc_n()? I guess there is some global header for this, to prevent further accidents? extern void *g_realloc_n_can_not_be_used(void); #define g_realloc_n(a,b,c) g_realloc_n_can_not_be_used() Olaf

Re: [Qemu-devel] [RFC] Intermediate block mirroring

2018-04-18 Thread Alberto Garcia
On Mon 16 Apr 2018 05:15:21 PM CEST, Max Reitz wrote: > On 2018-04-16 16:59, Alberto Garcia wrote: >> On Fri 13 Apr 2018 04:23:07 PM CEST, Max Reitz wrote: >>> On 2018-04-12 19:07, Alberto Garcia wrote: Hello, I mentioned this some time ago, but I'd like to retake it now: I'm

Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread Olaf Hering
Am Wed, 18 Apr 2018 10:04:03 -0500 schrieb Eric Blake : > Rather than hacking configure, why not fix util/vfio-helpers.c to avoid > g_realloc_n()? We've done it before; see commit 071d405 I can not really test it, this variant may work: --- a/util/vfio-helpers.c +++

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 17:27, Laszlo Ersek wrote: > On 04/18/18 17:17, Eric Blake wrote: >> On 04/18/2018 07:40 AM, Laszlo Ersek wrote: >> >>> Is it guaranteed that lists in JSON keep the order of the elements? >>> Because, dictionaries definitely don't promise any ordering between the >>> keys. >> >> Yes,

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 05:27:32PM +0200, Laszlo Ersek wrote: > On 04/18/18 17:17, Eric Blake wrote: > > On 04/18/2018 07:40 AM, Laszlo Ersek wrote: > > > >> Is it guaranteed that lists in JSON keep the order of the elements? > >> Because, dictionaries definitely don't promise any ordering

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 17:17, Eric Blake wrote: > On 04/18/2018 07:40 AM, Laszlo Ersek wrote: > >> Is it guaranteed that lists in JSON keep the order of the elements? >> Because, dictionaries definitely don't promise any ordering between the >> keys. > > Yes, JSON lists preserve order (and we have to

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Eric Blake
On 04/18/2018 07:40 AM, Laszlo Ersek wrote: > Is it guaranteed that lists in JSON keep the order of the elements? > Because, dictionaries definitely don't promise any ordering between the > keys. Yes, JSON lists preserve order (and we have to explicitly document cases where order within a list

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Markus Armbruster
Kevin Wolf writes: > The legacy command line syntax supports a "password-secret" option that > allows to pass an authentication key to Ceph. This was not supported in > QMP so far. We tried during development of v2.9.0 (commit 0a55679b4a5), but reverted before the release:

Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180418145443.6332-1-o...@aepfle.de Subject: [Qemu-devel] [PATCH v2] configure:

Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread Eric Blake
On 04/18/2018 09:54 AM, Olaf Hering wrote: > Since usage of g_realloc_n was introduced, glib-2.22 can not be used > anymore on Linux. Leave non-Linux unchanged because one developer system > still uses it. > Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > Signed-off-by: Olaf Hering

Re: [Qemu-devel] [PATCH for-2.13 v2 3/5] pc: simplify MachineClass::get_hotplug_handler handling

2018-04-18 Thread Eduardo Habkost
On Wed, Apr 18, 2018 at 04:28:03PM +0200, Igor Mammedov wrote: > By default MachineClass::get_hotplug_handler is NULL and concrete board > should set it to it's own handler. > Considering there isn't any default handler, drop saving empty > MachineClass::get_hotplug_handler in child class and make

[Qemu-devel] [ANNOUNCE] QEMU 2.12.0-rc4 is now available

2018-04-18 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fifth release candidate for the QEMU 2.12 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-2.12.0-rc4.tar.xz

[Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

2018-04-18 Thread Olaf Hering
Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore on Linux. Leave non-Linux unchanged because one developer system still uses it. Fixes commit 418026ca43 ("util: Introduce vfio helpers") Signed-off-by: Olaf Hering --- configure | 6 +- 1 file

Re: [Qemu-devel] [PATCH v1] dump: add Windows dump format to dump-guest-memory

2018-04-18 Thread Eric Blake
On 04/17/2018 08:50 AM, Viktor Prutyanov wrote: > This patch adds Windows crashdumping feature. Now QEMU can produce ELF-dump > containing Windows crashdump header, which can help to convert to a valid > WinDbg-understandable crashdump file, or immediately create such file. > The crashdump will be

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Olaf Hering
Am Wed, 18 Apr 2018 14:45:38 +0200 schrieb Cornelia Huck : > Are we ready to give up support for whatever distro is still on 2.22? This is SLE11, in case it matters for this discussion. Olaf pgp5sY4ljZvqS.pgp Description: Digitale Signatur von OpenPGP

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 16:06, Daniel P. Berrangé wrote: > On Wed, Apr 18, 2018 at 04:03:03PM +0200, Laszlo Ersek wrote: >> - Would you like me to capture the directory paths in the firmware.json >> file, or in the commit message for the patch? > > Should be in whatever file ends up in the docs/specs

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 02:29:47PM +0100, Peter Maydell wrote: > On 18 April 2018 at 13:47, Daniel P. Berrangé wrote: > > On Wed, Apr 18, 2018 at 02:38:37PM +0200, Olaf Hering wrote: > >> Since usage of g_realloc_n was introduced, glib-2.22 can not be used > >> anymore. > >>

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 04:41:39PM +0200, Cornelia Huck wrote: > On Wed, 18 Apr 2018 13:55:45 +0100 > Daniel P. Berrangé wrote: > > > On Wed, Apr 18, 2018 at 02:45:38PM +0200, Cornelia Huck wrote: > > > On Wed, 18 Apr 2018 14:38:37 +0200 > > > Olaf Hering

Re: [Qemu-devel] semantics of FIEMAP without FIEMAP_FLAG_SYNC

2018-04-18 Thread Eric Blake
On 04/18/2018 09:25 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Do your code with >>> >>> /* Found an extent, and we're inside it.  */ >>> *next = f.fe.fe_logical + f.fe.fe_length; >>> if (f.fe.fe_flags & FIEMAP_EXTENT_UNWRITTEN) { >>> return

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Cornelia Huck
On Wed, 18 Apr 2018 13:55:45 +0100 Daniel P. Berrangé wrote: > On Wed, Apr 18, 2018 at 02:45:38PM +0200, Cornelia Huck wrote: > > On Wed, 18 Apr 2018 14:38:37 +0200 > > Olaf Hering wrote: > > > > > Since usage of g_realloc_n was introduced, glib-2.22 can

Re: [Qemu-devel] [PATCH RFC] s390x: refactor reset/reipl handling

2018-04-18 Thread David Hildenbrand
> static void s390_ipl_class_init(ObjectClass *klass, void *data) > diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h > index 0570d0ad75..102f1ea7af 100644 > --- a/hw/s390x/ipl.h > +++ b/hw/s390x/ipl.h > @@ -87,7 +87,17 @@ int s390_ipl_set_loadparm(uint8_t *loadparm); > void

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Philippe Mathieu-Daudé
On 04/18/2018 11:32 AM, Philippe Mathieu-Daudé wrote: > Hi Marc-André, > > On 04/18/2018 07:36 AM, Marc-André Lureau wrote: >> In commit cd9526ab7c04f2c32c63340b04401f6ed25682b9 >> Author: Philippe Mathieu-Daudé >> Date: Thu Mar 8 23:39:32 2018 +0100 >> >> hw/isa/superio:

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 04/18/2018 07:36 AM, Marc-André Lureau wrote: > In commit cd9526ab7c04f2c32c63340b04401f6ed25682b9 > Author: Philippe Mathieu-Daudé > Date: Thu Mar 8 23:39:32 2018 +0100 > > hw/isa/superio: Factor out the serial code from pc87312.c > > You changed

[Qemu-devel] [PATCH for-2.13 v2 5/5] arm/boot: split load_dtb() from arm_load_kernel()

2018-04-18 Thread Igor Mammedov
load_dtb() depends on arm_load_kernel() to figure out place in RAM where it should be loaded, but it's not required for arm_load_kernel() to work. Sometimes it's neccesary for devices added with -device/device_add to be enumerated in DTB as well, which's lead to [1] and surrounding commits to add

Re: [Qemu-devel] [PATCH v4 21/21] target/arm: Send interrupts on PMU counter overflow

2018-04-18 Thread Aaron Lindsay
On Apr 17 16:38, Aaron Lindsay wrote: > diff --git a/target/arm/helper.c b/target/arm/helper.c > index 046e37c..2efdc63 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -973,6 +986,11 @@ static uint64_t cycles_get_count(CPUARMState *env) > } > > #ifndef CONFIG_USER_ONLY >

[Qemu-devel] [PATCH for-2.13 v2 2/5] ppc: e500: switch E500 based machines to full machine definition

2018-04-18 Thread Igor Mammedov
Convert PPCE500Params to PCCE500MachineClass which it essentially is, and introduce PCCE500MachineState to keep track of E500 specific state instead of adding global variables or extra parameters to functions when we need to keep data beyond machine init (i.e. make it look like typical fully

[Qemu-devel] [PATCH for-2.13 v2 1/5] arm: always start from first_cpu when registering loader cpu reset callback

2018-04-18 Thread Igor Mammedov
if arm_load_kernel() were passed non first_cpu, QEMU would end up with partially set do_cpu_reset() callback leaving some CPUs without it. Make sure that do_cpu_reset() is registered for all CPUs by enumerating CPUs from first_cpu. Signed-off-by: Igor Mammedov Reviewed-by:

[Qemu-devel] [PATCH for-2.13 v2 4/5] platform-bus-device: use device plug callback instead of machine_done notifier

2018-04-18 Thread Igor Mammedov
platform-bus were using machine_done notifier to get and map (assign irq/mmio resources) dynamically added sysbus devices after all '-device' options had been processed. That however creates non obvious dependencies on ordering of machine_done notifiers and requires carefull line juggling to keep

[Qemu-devel] [PATCH for-2.13 v2 3/5] pc: simplify MachineClass::get_hotplug_handler handling

2018-04-18 Thread Igor Mammedov
By default MachineClass::get_hotplug_handler is NULL and concrete board should set it to it's own handler. Considering there isn't any default handler, drop saving empty MachineClass::get_hotplug_handler in child class and make PC code consistent with spapr/s390x boards. We can bring this back

[Qemu-devel] [PATCH for-2.13 v2 0/5] arm: isolate and clean up dtb generation

2018-04-18 Thread Igor Mammedov
Changelog v1->v2: * drop "arm: reuse arm_boot_address_space() in armv7m_load_kernel()" * move "arm: always start from first_cpu when registering loader cpu reset callback" at the begigning of series and rebase * add "ppc: e500: switch E500 based machines to full machine

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 16:16 hat Eric Blake geschrieben: > On 04/18/2018 08:50 AM, Kevin Wolf wrote: > > >>> @@ -3195,6 +3215,8 @@ > >>> '*conf': 'str', > >>> '*snapshot': 'str', > >>> '*user': 'str', > >>> +'*auth-none': 'bool', > >>> +

Re: [Qemu-devel] semantics of FIEMAP without FIEMAP_FLAG_SYNC (was Re: [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server)

2018-04-18 Thread Vladimir Sementsov-Ogievskiy
15.02.2018 19:42, Paolo Bonzini wrote: On 15/02/2018 17:40, Vladimir Sementsov-Ogievskiy wrote: Hi all. Two years later, is there are any news on the topic? I can't understand the following thing:  - FIEMAP without FLAG_SYNC is unsafe  - FIEMAP with FLAG_SYNC is safe but slow  - so, we've

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Eric Blake
On 04/18/2018 08:50 AM, Kevin Wolf wrote: >>> @@ -3195,6 +3215,8 @@ >>> '*conf': 'str', >>> '*snapshot': 'str', >>> '*user': 'str', >>> +'*auth-none': 'bool', >>> +'*auth-cephx': 'RbdAuthCephx', >>> '*server':

Re: [Qemu-devel] [PATCH RFC] s390x: refactor reset/reipl handling

2018-04-18 Thread David Hildenbrand
On 18.04.2018 16:08, Thomas Huth wrote: > On 12.04.2018 21:26, David Hildenbrand wrote: >> Calling pause_all_vcpus()/resume_all_vcpus() from a VCPU thread might >> not be the best idea. As pause_all_vcpus() temporarily drops the qemu >> mutex, two parallel calls to pause_all_vcpus() can be active

Re: [Qemu-devel] [PATCH RFC] s390x: refactor reset/reipl handling

2018-04-18 Thread Thomas Huth
On 12.04.2018 21:26, David Hildenbrand wrote: > Calling pause_all_vcpus()/resume_all_vcpus() from a VCPU thread might > not be the best idea. As pause_all_vcpus() temporarily drops the qemu > mutex, two parallel calls to pause_all_vcpus() can be active at a time, > resulting in a deadlock. (either

Re: [Qemu-devel] [PATCH v2 2/3] nbd/server: implement dirty bitmap export

2018-04-18 Thread Eric Blake
On 04/13/2018 01:14 PM, Vladimir Sementsov-Ogievskiy wrote: > Handle new NBD meta namespace: "qemu", and corresponding queries: > "qemu:dirty-bitmap:". > > With new metadata context negotiated, BLOCK_STATUS query will reply > with dirty-bitmap data, converted to extents. New public function >

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 04:03:03PM +0200, Laszlo Ersek wrote: > On 04/18/18 15:53, Daniel P. Berrangé wrote: > > On Wed, Apr 18, 2018 at 03:30:36PM +0200, Laszlo Ersek wrote: > >> On 04/18/18 15:06, Gerd Hoffmann wrote: > > Other question: Do we want allow to specify which certs/keys are >

Re: [Qemu-devel] Why is there no qom_get in hmp.c?

2018-04-18 Thread Dr. David Alan Gilbert
* QingFeng Hao (ha...@linux.vnet.ibm.com) wrote: > Hi all, > I did some investigation and found that "virsh qemu-monitor-command" supports > qom-get, > but qemu hmp doesn't. However, in hmp.c there are qom_list and qom_set. It > confused me > and my question is: why is this? And how can I get a

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 15:53, Daniel P. Berrangé wrote: > On Wed, Apr 18, 2018 at 03:30:36PM +0200, Laszlo Ersek wrote: >> On 04/18/18 15:06, Gerd Hoffmann wrote: > Other question: Do we want allow to specify which certs/keys are > enrolled? Which would probably mean to drop "enrolled-keys" from

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Marc-André Lureau
Hi On Wed, Apr 18, 2018 at 3:47 PM, Paolo Bonzini wrote: > On 18/04/2018 14:22, Marc-André Lureau wrote: - Chardev: stdio, mux, ringbuf, pty, file, null etc.. - CharBackend: the "user" end - frontend: the "user" >>> The frontend is the device, the monitor, etc. >>

[Qemu-devel] Restoring bitmaps after failed/cancelled migration

2018-04-18 Thread Vladimir Sementsov-Ogievskiy
Hi all. We now have the following problem: If dirty-bitmaps migration capability is enabled, persistance flag is dropped for all migrated bitmaps, to prevent their storing to the storage on inactivate. It works ok, persistence itself is migrated through the migration channel. But on source,

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 03:30:36PM +0200, Laszlo Ersek wrote: > On 04/18/18 15:06, Gerd Hoffmann wrote: > >>> Other question: Do we want allow to specify which certs/keys are > >>> enrolled? Which would probably mean to drop "enrolled-keys" from > >>> features and make it an optional string

Re: [Qemu-devel] [PATCH v4 2/5] qcow2: Document some maximum size constraints

2018-04-18 Thread Eric Blake
On 04/13/2018 12:08 PM, Max Reitz wrote: With 512 byte clusters and 64 bit refcount entries I still get 8 PB, way over what's limited by the L1/L2 tables (128 GB). >>> >>> Do I need to make any modifications to the sentence, then? >> >> I guess what surprised me the first time that I

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Paolo Bonzini
On 18/04/2018 14:06, Peter Maydell wrote: > >> In case of a mux chardev, it may already >> have an active frontend (yeah be is CharBackend which is the frontend, >> I still can't grasp that either, please Paolo change your mind! ;). > I agree with Marc-André that the terminology for our chardev >

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 15:26 hat Eric Blake geschrieben: > On 04/05/2018 12:06 PM, Kevin Wolf wrote: > > The legacy command line syntax supports a "password-secret" option that > > allows to pass an authentication key to Ceph. This was not supported in > > QMP so far. > > > > This patch introduces

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-18 Thread Paolo Bonzini
On 18/04/2018 14:22, Marc-André Lureau wrote: >>> - Chardev: stdio, mux, ringbuf, pty, file, null etc.. >>> - CharBackend: the "user" end >>> - frontend: the "user" >> The frontend is the device, the monitor, etc. > yes, I should have listed it for clarity > >> The backend is how the >> frontend

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-18 Thread Eric Blake
On 04/13/2018 11:59 AM, Halil Pasic wrote: > This ssize_t seems to be an rather interesting type. For instance POSIX says > """ > size_t > Used for sizes of objects. > ssize_t > Used for a count of bytes or an error indication. > """ > and > """ > The type ssize_t shall be capable of

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 15:21 hat Eric Blake geschrieben: > On 04/06/2018 03:04 AM, Kevin Wolf wrote: > > Am 05.04.2018 um 19:06 hat Kevin Wolf geschrieben: > >> The legacy command line syntax supports a "password-secret" option that > >> allows to pass an authentication key to Ceph. This was not

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Eric Blake
On 04/18/2018 07:47 AM, Daniel P. Berrangé wrote: > On Wed, Apr 18, 2018 at 02:38:37PM +0200, Olaf Hering wrote: >> Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore. >> Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > Normally we expect

Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24

2018-04-18 Thread Peter Maydell
On 18 April 2018 at 13:47, Daniel P. Berrangé wrote: > On Wed, Apr 18, 2018 at 02:38:37PM +0200, Olaf Hering wrote: >> Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore. >> Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > Normally we

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-18 Thread Laszlo Ersek
On 04/18/18 15:06, Gerd Hoffmann wrote: >>> Other question: Do we want allow to specify which certs/keys are >>> enrolled? Which would probably mean to drop "enrolled-keys" from >>> features and make it an optional string instead, >> >> Not an enum? "Microsoft" below should be an enum constant,

Re: [Qemu-devel] [PATCH v1 1/1] xilinx_spips: send dummy only if cmd requires it

2018-04-18 Thread Sai Pavan Boddu
Hi Francisco, From: francisco iglesias [mailto:frasse.igles...@gmail.com] Sent: Wednesday, April 18, 2018 4:13 AM To: Sai Pavan Boddu Cc: alist...@alistair23.me; crosthwaite.pe...@gmail.com; Peter Maydell ; Edde ;

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Eric Blake
On 04/05/2018 12:06 PM, Kevin Wolf wrote: > The legacy command line syntax supports a "password-secret" option that > allows to pass an authentication key to Ceph. This was not supported in > QMP so far. > > This patch introduces authentication options in the QAPI schema, makes > them do the

  1   2   >