Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

On 04/27/2018 07:29 PM, Dr. David Alan Gilbert wrote: Yes, can not agree with you more. :) The challenge is how to put something into the stream without breaking an old version of QEMU that's receiving the stream. Er, i did not think this case :(. The new parameter as this patch did is

[Qemu-devel] [PATCH] backends/cryptodev: fix coverity issue

This patch removes the dead code, which fixes Coverity (CID 1390600) issue. Signed-off-by: Jay Zhou --- backends/cryptodev-vhost-user.c | 5 - 1 file changed, 5 deletions(-) diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.c index 862d4f2..67e65c6 100644 --- a/ba

[Qemu-devel] [Bug 1429034] Re: qemu abort in qemu_coroutine_enter when multi-thread writing

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1429034 Title: qemu abort

[Qemu-devel] [Bug 1432103] Re: error in x86 executable segment permission check

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1432103 Title: error in x8

Re: [Qemu-devel] [PATCH v2 4/5] migration: implement bi-directional RDMA QIOChannel

On Fri, Apr 27, 2018 at 5:16 PM, Daniel P. Berrangé wrote: > On Fri, Apr 27, 2018 at 03:56:38PM +0800, 858585 jemmy wrote: >> On Fri, Apr 27, 2018 at 1:36 AM, Dr. David Alan Gilbert >> wrote: >> > * Lidong Chen (jemmy858...@gmail.com) wrote: >> >> This patch implements bi-directional RDMA QIOChan

Re: [Qemu-devel] [PATCH v6 05/11] qapi: introduce new cmd option "allowed-in-preconfig"

On Fri, Apr 27, 2018 at 05:05:30PM -0500, Eric Blake wrote: [...] > > diff --git a/monitor.c b/monitor.c > > index 0ffdf1d..e5e60dc 100644 > > --- a/monitor.c > > +++ b/monitor.c > > @@ -1183,7 +1183,7 @@ static void monitor_init_qmp_commands(void) > > > > qmp_register_command(&qmp_command

Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock

On 2018年04月28日 11:14, Peter Xu wrote: On Sat, Apr 28, 2018 at 10:42:11AM +0800, Jason Wang wrote: [...] Well, it's not about BQL specifically, it's about whether we have or need a generic thread safety solution for all IOMMUs. We have more IOMMUs than just AMD, s390 and ppc: # git grep imr

Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock

On Sat, Apr 28, 2018 at 10:42:11AM +0800, Jason Wang wrote: [...] > Well, it's not about BQL specifically, it's about whether we have or need a > generic thread safety solution for all IOMMUs. > > We have more IOMMUs than just AMD, s390 and ppc: > > # git grep imrc-\>translate\ = > hw/alpha/typ

Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock

On 2018年04月28日 11:06, Peter Xu wrote: On Sat, Apr 28, 2018 at 10:42:11AM +0800, Jason Wang wrote: On 2018年04月28日 10:24, Peter Xu wrote: On Sat, Apr 28, 2018 at 09:43:54AM +0800, Jason Wang wrote: On 2018年04月27日 14:26, Peter Xu wrote: On Fri, Apr 27, 2018 at 01:13:02PM +0800, Jason Wang wro

Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock

On Sat, Apr 28, 2018 at 10:42:11AM +0800, Jason Wang wrote: > > > On 2018年04月28日 10:24, Peter Xu wrote: > > On Sat, Apr 28, 2018 at 09:43:54AM +0800, Jason Wang wrote: > > > > > > On 2018年04月27日 14:26, Peter Xu wrote: > > > > On Fri, Apr 27, 2018 at 01:13:02PM +0800, Jason Wang wrote: > > > > >

Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock

On 2018年04月28日 10:24, Peter Xu wrote: On Sat, Apr 28, 2018 at 09:43:54AM +0800, Jason Wang wrote: On 2018年04月27日 14:26, Peter Xu wrote: On Fri, Apr 27, 2018 at 01:13:02PM +0800, Jason Wang wrote: On 2018年04月25日 12:51, Peter Xu wrote: Add a per-iommu big lock to protect IOMMU status. Curre

Re: [Qemu-devel] [PATCH v2] migration: update docs

On Fri, Apr 27, 2018 at 06:34:16PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Update the migration docs: > > Among other changes: > * Added a general list of advice for device authors > * Reordered the section on conditional state (subsections etc) >

Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock

On Sat, Apr 28, 2018 at 09:43:54AM +0800, Jason Wang wrote: > > > On 2018年04月27日 14:26, Peter Xu wrote: > > On Fri, Apr 27, 2018 at 01:13:02PM +0800, Jason Wang wrote: > > > > > > On 2018年04月25日 12:51, Peter Xu wrote: > > > > Add a per-iommu big lock to protect IOMMU status. Currently the only

Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock

> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, April 27, 2018 5:54 PM > > On Fri, Apr 27, 2018 at 07:19:25AM +, Tian, Kevin wrote: > > > From: Peter Xu > > > Sent: Friday, April 27, 2018 2:26 PM > > > > > > On Fri, Apr 27, 2018 at 01:13:02PM +0800, Jason Wang wrote: > > > > > > >

Re: [Qemu-devel] [PULL 7/9] net: Add a new convenience option "--nic" to configure default/on-board NICs

On 2018年04月27日 20:29, Peter Maydell wrote: On 5 March 2018 at 03:12, Jason Wang wrote: From: Thomas Huth Hi. Coverity (CID 1390615) points out that we leak memory in an error-exit codepath in this function. +/* For the convenience "--nic" parameter */ +static int net_param_nic(void *dummy

Re: [Qemu-devel] [PATCH 08/10] intel-iommu: maintain per-device iova ranges

On 2018年04月27日 19:40, Peter Xu wrote: On Fri, Apr 27, 2018 at 05:55:27PM +0800, Peter Xu wrote: On Fri, Apr 27, 2018 at 07:44:07AM +, Tian, Kevin wrote: From: Peter Xu [mailto:pet...@redhat.com] Sent: Friday, April 27, 2018 3:28 PM On Fri, Apr 27, 2018 at 07:02:14AM +, Tian, Kevin wr

Re: [Qemu-devel] [PATCH 03/10] intel-iommu: add iommu lock

On 2018年04月27日 14:26, Peter Xu wrote: On Fri, Apr 27, 2018 at 01:13:02PM +0800, Jason Wang wrote: On 2018年04月25日 12:51, Peter Xu wrote: Add a per-iommu big lock to protect IOMMU status. Currently the only thing to be protected is the IOTLB cache, since that can be accessed even without BQL,

Re: [Qemu-devel] [PULL 10/13] cryptodev: add vhost-user as a new cryptodev backend

Hi Peter, > -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Saturday, April 28, 2018 12:15 AM > To: Michael S. Tsirkin > Cc: QEMU Developers ; Gonglei (Arei) > ; longpeng ; Zhoujian (jay) > ; Paolo Bonzini > Subject: Re: [PULL 10/13] cryptodev: add vhos

Re: [Qemu-devel] [PATCH v2] checkpatch.pl: add common glib defines to typelist

On 25/04/2018 09:01, Peter Xu wrote: > Otherwise it can warn this: > > ERROR: space prohibited between function name and open parenthesis '(' > > When with things like this: > > typedef gboolean (*it_tree_iterator)(ITValue start, ITValue end); > > CC: Paolo Bonzini > CC: Stefan Hajnoczi >

Re: [Qemu-devel] [PATCH 08/10] intel-iommu: maintain per-device iova ranges

> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, April 27, 2018 7:40 PM > > On Fri, Apr 27, 2018 at 05:55:27PM +0800, Peter Xu wrote: > > On Fri, Apr 27, 2018 at 07:44:07AM +, Tian, Kevin wrote: > > > > From: Peter Xu [mailto:pet...@redhat.com] > > > > Sent: Friday, April 27, 2018 3

Re: [Qemu-devel] [PATCH v8 23/35] RISC-V: Simplify riscv_cpu_local_irqs_pending

On Wed, Apr 25, 2018 at 4:56 PM Michael Clark wrote: > This commit is intended to improve readability. > There is no change to the logic. > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Palmer Dabbelt > Cc: Alistair Francis > Signed-off-by: Michael Clark Reviewed-by: Alistair Francis

Re: [Qemu-devel] [RFC PATCH 0/1] s390x/pci: add common fmb

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180427100244.14258-1-zyi...@linux.ibm.com Subject: [Qemu-devel] [RFC PATCH 0/1] s390x/pci: add common fmb === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git l

Re: [Qemu-devel] [PATCH v6 07/11] tests: add allowed-in-preconfig-test for qapi-schema

On 04/27/2018 10:05 AM, Igor Mammedov wrote: > make sure the QAPISchema can parse allowed-in-preconfig correctly > > Signed-off-by: Igor Mammedov > --- > tests/Makefile.include | 1 + > tests/qapi-schema/allowed-in-preconfig-test.err | 1 + > tests/qapi-schema/allowed-

Re: [Qemu-devel] [PATCH v6 06/11] tests: let qapi-schema tests detect allowed-in-preconfig

On 04/27/2018 05:08 PM, Eric Blake wrote: > On 04/27/2018 10:05 AM, Igor Mammedov wrote: >> use new allowed-in-preconfig parameter in tests. >> > > Might also be worth adding a negative test, similar to oob-test.json, as > well as tweaking qapi-schema.json to have at least one command with the >

Re: [Qemu-devel] [PATCH v6 06/11] tests: let qapi-schema tests detect allowed-in-preconfig

On 04/27/2018 10:05 AM, Igor Mammedov wrote: > use new allowed-in-preconfig parameter in tests. > > Signed-off-by: Igor Mammedov > --- > tests/qapi-schema/doc-good.out | 4 ++-- > tests/qapi-schema/ident-with-escape.out | 2 +- > tests/qapi-schema/indented-expr.out | 4 ++-- > te

Re: [Qemu-devel] [PATCH v6 05/11] qapi: introduce new cmd option "allowed-in-preconfig"

On 04/27/2018 10:05 AM, Igor Mammedov wrote: > New option will be used to allow commands, which are prepared/need > to run, during preconfig state. Other commands that should be able > to run in preconfig state, should be ameded to not expect machine s/ameded/amended/ > in initialized state or de

[Qemu-devel] [PATCH 2/3] nvdimm, acpi: add NFIT platform capabilities

Add support for the NFIT Platform Capabilities Structure, newly added in ACPI 6.2 Errata A. Signed-off-by: Ross Zwisler --- hw/acpi/nvdimm.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 59d6e4254c..859b390e07 1006

[Qemu-devel] [PATCH 1/3] nvdimm: fix typo in label-size definition

Signed-off-by: Ross Zwisler Fixes: commit da6789c27c2e ("nvdimm: add a macro for property "label-size"") Cc: Haozhong Zhang Cc: Michael S. Tsirkin Cc: Stefan Hajnoczi --- hw/mem/nvdimm.c | 2 +- include/hw/mem/nvdimm.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --gi

[Qemu-devel] [PATCH 3/3] nvdimm: platform capabilities command line option

Add a device command line option to allow the user to control the Platform Capabilities Structure in the virtualized NFIT. Signed-off-by: Ross Zwisler --- docs/nvdimm.txt | 22 ++ hw/acpi/nvdimm.c| 29 + hw/mem/nvdimm.c | 28

Re: [Qemu-devel] [PULL 14/14] ppc4xx: Add device models found in PPC440 core SoCs

On Fri, 27 Apr 2018, Peter Maydell wrote: On 16 February 2018 at 10:06, David Gibson wrote: From: BALATON Zoltan These devices are found in newer SoCs based on 440 core e.g. the 460EX (http://www.embeddeddeveloper.com/assets/processors/amcc/datasheets/ PP460EX_DS2063.pdf) Signed-off-by: BALA

Re: [Qemu-devel] [PATCH v6 04/11] hmp: disable monitor in preconfig state

On 04/27/2018 10:05 AM, Igor Mammedov wrote: > Ban it for now, if someone would need it to work early, > one would have to implement checks if HMP command is valid > at preconfig state. > > Signed-off-by: Igor Mammedov > --- Reviewed-by: Eric Blake There's a bisection window between when RUN_S

Re: [Qemu-devel] [PATCH v6 03/11] cli: add --preconfig option

On 04/27/2018 10:05 AM, Igor Mammedov wrote: > This option allows pausing QEMU in the new RUN_STATE_PRECONFIG state, > allowing the configuration of QEMU from QMP before the machine jumps > into board initialization code of machine_run_board_init() > > The intent is to allow management to query ma

Re: [Qemu-devel] [PULL 03/30] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

On Fri, 27 Apr 2018, Peter Maydell wrote: On 6 March 2018 at 04:01, David Gibson wrote: From: BALATON Zoltan This is the PCIX controller found in newer 440 core SoCs e.g. the AMMC 460EX. The device tree refers to this as plb-pcix compared to the plb-pci controller in older 440 SoCs. Signed-o

[Qemu-devel] [PATCH] target/xtensa: check zero overhead loop alignment

ISA book documents that the first instruction of zero overhead loop must fit completely into naturally aligned region of an instruction fetch unit size. Check that condition and log a message if it's violated. Signed-off-by: Max Filippov --- target/xtensa/cpu.h | 1 + target/xtensa/over

Re: [Qemu-devel] [PATCH v3 5/5] qapi: deprecate CpuInfoFast.arch

On 04/27/2018 02:28 PM, Laszlo Ersek wrote: > The TARGET_BASE_ARCH values from "configure" don't all map to the > @CpuInfoArch enum constants; in particular "s390x" from the former does > not match @s390 in the latter. Clients are known to rely on the @s390 > constant specifically, so we can't chan

Re: [Qemu-devel] [PATCH v3 2/5] qapi: add SysEmuTarget to "common.json"

On 04/27/2018 02:28 PM, Laszlo Ersek wrote: > We'll soon need an enumeration type that lists all the softmmu targets > that QEMU (the project) supports. Introduce @SysEmuTarget to > "common.json". > > The enum constant @x86_64 doesn't match the QAPI convention of preferring > hyphen ("-") over und

Re: [Qemu-devel] [PATCH] arm/translate-a64: add FP16 FCMP operations

On 04/27/2018 02:19 PM, Alex Bennée wrote: > These where missed out from the rest of the half-precision work. > s/where missed out from/were missed during/ -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc

Re: [Qemu-devel] [PATCH 0/9] target/arm: Fixups for ARM_FEATURE_V8_FP16

Alex Bennée writes: > Alex Bennée writes: > >> Richard Henderson writes: >> If you take my patches from: https://github.com/stsquad/qemu/tree/review/rth-fp16-fixes 443a7c3d38 arm/translate-a64: fix-up FMOV FP16 immediate be4430e9c9 arm/translate-a64: add FP16 FCSEL 7badf508ab arm/transla

Re: [Qemu-devel] [PATCH PULL v2 09/10] hw/rdma: Implementation of PVRDMA device

On 27/04/2018 17:55, Peter Maydell wrote: > On 19 February 2018 at 11:43, Marcel Apfelbaum wrote: >> From: Yuval Shaia >> >> PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. >> It works with its Linux Kernel driver AS IS, no need for any special >> guest modifications. >

Re: [Qemu-devel] [PATCH PULL v2 09/10] hw/rdma: Implementation of PVRDMA device

On 27/04/2018 17:49, Peter Maydell wrote: > On 19 February 2018 at 11:43, Marcel Apfelbaum wrote: >> From: Yuval Shaia >> >> PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. >> It works with its Linux Kernel driver AS IS, no need for any special >> guest modifications. >

[Qemu-devel] [PATCH v3 2/5] qapi: add SysEmuTarget to "common.json"

We'll soon need an enumeration type that lists all the softmmu targets that QEMU (the project) supports. Introduce @SysEmuTarget to "common.json". The enum constant @x86_64 doesn't match the QAPI convention of preferring hyphen ("-") over underscore ("_"). This is intentional; the @SysEmuTarget co

[Qemu-devel] [PATCH v3 1/5] qapi: fill in CpuInfoFast.arch in query-cpus-fast

* Commit ca230ff33f89 added the @arch field to @CpuInfoFast, but it failed to set the new field in qmp_query_cpus_fast(), when TARGET_S390X was not defined. The updated @query-cpus-fast example in "qapi-schema.json" showed "arch":"x86" only because qmp_query_cpus_fast() calls g_malloc0() to

[Qemu-devel] [PATCH v3 0/5] qapi: introduce the SysEmuTarget enumeration

This is version 3 of the set posted earlier at 20180426183404.3756-1-lersek@redhat.com">http://mid.mail-archive.com/20180426183404.3756-1-lersek@redhat.com This version seeks to address the v2 feedback. Changes are noted per patch. The following firmware schema / interop docs patch remains dep

[Qemu-devel] [PATCH v3 5/5] qapi: deprecate CpuInfoFast.arch

The TARGET_BASE_ARCH values from "configure" don't all map to the @CpuInfoArch enum constants; in particular "s390x" from the former does not match @s390 in the latter. Clients are known to rely on the @s390 constant specifically, so we can't change it silently. Instead, deprecate the @CpuInfoFast.

[Qemu-devel] [PATCH v3 3/5] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget

Now that we have @SysEmuTarget, it makes sense to restrict @TargetInfo.@arch to valid sysemu targets at the schema level. Cc: "Daniel P. Berrange" Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: Laszlo Ersek Reviewed-by: Markus Armbruster Reviewed-by: Eric Blake --- Notes: PATCHv3:

[Qemu-devel] [PATCH v3 4/5] qapi: discriminate CpuInfoFast on SysEmuTarget, not CpuInfoArch

Add a new field @target (of type @SysEmuTarget) to the output of the @query-cpus-fast command, which provides more information about the emulation target than the field @arch (of type @CpuInfoArch). Make @target the new discriminator for the @CpuInfoFast return structure. Keep @arch for compatibili

Re: [Qemu-devel] Who is running QEMU automated tests, and when?

On Fri, Apr 27, 2018 at 11:10:54AM +0800, Fam Zheng wrote: > On Thu, 04/26 10:57, Eduardo Habkost wrote: > > So, for anybody that runs automated QEMU tests once in a while, > > can we know: > > > > * What test cases are you running? Where can we get more > > information about the tests you run?

[Qemu-devel] [PATCH] arm/translate-a64: add FP16 FCMP operations

These where missed out from the rest of the half-precision work. Signed-off-by: Alex Bennée Cc: qemu-sta...@nongnu.org --- target/arm/helper-a64.c| 10 +++ target/arm/helper-a64.h| 2 ++ target/arm/translate-a64.c | 60 -- 3 files changed, 63 inse

Re: [Qemu-devel] Who is running QEMU automated tests, and when?

Dne 26.4.2018 v 15:57 Eduardo Habkost napsal(a): > (Starting a new thread, for more visibility) > Hello guys, what a nice topic. My Jenkins runs following weekly/daily upstream checks using RHEL.7 as host: ppc64 = frequency: weekly host: - ppc64 - ppc64le tests: - make# bu

Re: [Qemu-devel] [PATCH v2] migration: update docs

* Eric Blake (ebl...@redhat.com) wrote: > On 04/27/2018 12:34 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Update the migration docs: > > > > Among other changes: > > * Added a general list of advice for device authors > > * Reordered the section on cond

Re: [Qemu-devel] release retrospective, next release timing, numbering

On Fri, 27 Apr 2018 17:24:38 +0100 Peter Maydell wrote: > On 27 April 2018 at 17:17, Thomas Huth wrote: > > On 27.04.2018 17:51, Peter Maydell wrote: > >> Hi; I usually let people forget about releases for a month or > >> so before bringing this topic up, but: > >> > >> (1) do we want to call

Re: [Qemu-devel] [PATCH 0/9] target/arm: Fixups for ARM_FEATURE_V8_FP16

Alex Bennée writes: > Richard Henderson writes: > >> When running the gcc testsuite with current aarch64-linux-user, >> the testsuite detects the presence of the fp16 extension and >> enables lots of extra tests for builtins. >> >> Quite a few of these new tests fail because we missed implement

Re: [Qemu-devel] [PATCH PULL v2 08/10] hw/rdma: PVRDMA commands and data-path ops

On 27/04/2018 18:01, Peter Maydell wrote: > On 19 February 2018 at 11:43, Marcel Apfelbaum wrote: >> From: Yuval Shaia >> >> First PVRDMA sub-module - implementation of the PVRDMA device. >> - PVRDMA commands such as create CQ and create MR. >> - Data path QP operations - post_send and post_recv.

Re: [Qemu-devel] [PATCH PULL v2 08/10] hw/rdma: PVRDMA commands and data-path ops

On 27/04/2018 17:58, Peter Maydell wrote: > On 19 February 2018 at 11:43, Marcel Apfelbaum wrote: >> From: Yuval Shaia >> >> First PVRDMA sub-module - implementation of the PVRDMA device. >> - PVRDMA commands such as create CQ and create MR. >> - Data path QP operations - post_send and post_recv.

Re: [Qemu-devel] [PATCH PULL v2 08/10] hw/rdma: PVRDMA commands and data-path ops

On 27/04/2018 17:43, Peter Maydell wrote: > On 19 February 2018 at 11:43, Marcel Apfelbaum wrote: >> From: Yuval Shaia >> >> First PVRDMA sub-module - implementation of the PVRDMA device. >> - PVRDMA commands such as create CQ and create MR. >> - Data path QP operations - post_send and post_recv.

Re: [Qemu-devel] [PATCH PULL v2 08/10] hw/rdma: PVRDMA commands and data-path ops

Hi Peter, On 27/04/2018 17:31, Peter Maydell wrote: > On 19 February 2018 at 11:43, Marcel Apfelbaum wrote: >> From: Yuval Shaia >> >> First PVRDMA sub-module - implementation of the PVRDMA device. >> - PVRDMA commands such as create CQ and create MR. >> - Data path QP operations - post_send and

Re: [Qemu-devel] [PATCH v2] migration: update docs

On 04/27/2018 12:34 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Update the migration docs: > > Among other changes: > * Added a general list of advice for device authors > * Reordered the section on conditional state (subsections etc) > into the order we

Re: [Qemu-devel] [PATCH 5/9] target/riscv: Use new atomic min/max expanders

On 04/26/2018 09:24 PM, Michael Clark wrote: > > > On Fri, Apr 27, 2018 at 12:26 PM, Richard Henderson > mailto:richard.hender...@linaro.org>> wrote: > > Cc: Michael Clark mailto:m...@sifive.com>> > Cc: Palmer Dabbelt mailto:pal...@sifive.com>> > Cc: Sagar Karandikar

Re: [Qemu-devel] [PATCH for-2.13 v2 5/5] arm/boot: split load_dtb() from arm_load_kernel()

On 27 April 2018 at 14:47, Andrew Jones wrote: > On Wed, Apr 18, 2018 at 04:28:05PM +0200, Igor Mammedov wrote: >> @@ -1173,15 +1141,6 @@ static void arm_load_kernel_notify(Notifier >> *notifier, void *data) >> for (cs = CPU(cpu); cs; cs = CPU_NEXT(cs)) { >> ARM_CPU(cs)->env.boot_in

[Qemu-devel] [PATCH 0/2] arm: convert a couple of devices away from old_mmio

We've had an API transition running for years for MemoryRegionOps away from the old_mmio function-per-width to the new-style single function each for read and write. This patchset converts a couple of devices used in Arm machines to the new style. This leaves us with: * hw/char/parallel * hw/blo

[Qemu-devel] [PATCH 1/2] hw/usb/tusb6010: Convert away from old_mmio

Convert the tusb6010 device away from using the old_mmio field of MemoryRegionOps. This device is used only in the n800 and n810 boards. Signed-off-by: Peter Maydell --- hw/usb/tusb6010.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH 2/2] hw/net/smc91c111: Convert away from old_mmio

Convert the smc91c111 device away from using the old_mmio field of MemoryRegionOps. This device is used by several Arm board models. Signed-off-by: Peter Maydell --- hw/net/smc91c111.c | 54 +- 1 file changed, 25 insertions(+), 29 deletions(-) diff --

[Qemu-devel] [PATCH v2] migration: update docs

From: "Dr. David Alan Gilbert" Update the migration docs: Among other changes: * Added a general list of advice for device authors * Reordered the section on conditional state (subsections etc) into the order we prefer. * Add a note about firmware Signed-off-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH] migration: update docs

* Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > On Fri, Apr 20, 2018 at 06:57:21PM +0100, Dr. David Alan Gilbert (git) wrote: > > +- Busses and devices should be able to explicitly specify addresses when > > + instantiated, and management tools should use those. For example, > > + when hot

Re: [Qemu-devel] [PATCH 0/9] target/arm: Fixups for ARM_FEATURE_V8_FP16

Richard Henderson writes: > When running the gcc testsuite with current aarch64-linux-user, > the testsuite detects the presence of the fp16 extension and > enables lots of extra tests for builtins. > > Quite a few of these new tests fail because we missed implementing > some instructions. We r

Re: [Qemu-devel] [PATCH] migration: update docs

* Peter Xu (pet...@redhat.com) wrote: > On Fri, Apr 20, 2018 at 06:57:21PM +0100, Dr. David Alan Gilbert (git) wrote: > > [...] > > > Saving the state of one device > > == > > > > -The state of a device is saved using intermediate buffers. There are > > -some help

Re: [Qemu-devel] release retrospective, next release timing, numbering

On 27.04.2018 18:24, Peter Maydell wrote: > On 27 April 2018 at 17:17, Thomas Huth wrote: >> On 27.04.2018 17:51, Peter Maydell wrote: >>> Hi; I usually let people forget about releases for a month or >>> so before bringing this topic up, but: >>> >>> (1) do we want to call the next release 2.13,

Re: [Qemu-devel] [Qemu-ppc] [Qemu-arm] qom-test

On 27.04.2018 18:30, Markus Armbruster wrote: > Thomas Huth writes: > >> On 27.04.2018 12:20, Peter Maydell wrote: >>> On 27 April 2018 at 07:06, Thomas Huth wrote: [...] Shall we change qom-test to also only test with the "none" machine in the normal "make check" mode and only do the

Re: [Qemu-devel] [Qemu-arm] qom-test

Thomas Huth writes: > On 27.04.2018 12:20, Peter Maydell wrote: >> On 27 April 2018 at 07:06, Thomas Huth wrote: >>> On 26.04.2018 13:54, Markus Armbruster wrote: >>> [...] Actually, a worse offender in the "waste everybody's time via redunancy" department could be qom-test. Supportin

[Qemu-devel] [PATCH v2 2/2] block/file-posix: add x-check-page-cache=on|off option

mincore(2) checks whether pages are resident. Use it to verify that page cache has been dropped. You can trigger a verification failure by mmapping the image file from another process that loads a byte from a page, forcing it to become resident. bdrv_co_invalidate_cache() will fail while that pr

Re: [Qemu-devel] release retrospective, next release timing, numbering

On 27 April 2018 at 17:17, Thomas Huth wrote: > On 27.04.2018 17:51, Peter Maydell wrote: >> Hi; I usually let people forget about releases for a month or >> so before bringing this topic up, but: >> >> (1) do we want to call the next release 2.13, or something else? >> There's no particular reaso

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] pc-dimm: fix error messages if no slots were defined

On 27.04.2018 14:05, David Hildenbrand wrote: > If no slots were defined we try to allocate an empty bitmap, which > fails. > > Signed-off-by: David Hildenbrand > --- > > v1 -> v2: more detailed error message > > hw/mem/pc-dimm.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v2 1/2] block/file-posix: implement bdrv_co_invalidate_cache() on Linux

On Linux posix_fadvise(POSIX_FADV_DONTNEED) invalidates pages*. Use this to drop page cache on the destination host during shared storage migration. This way the destination host will read the latest copy of the data and will not use stale data from the page cache. The flow is as follows: 1. So

[Qemu-devel] [PATCH v2 0/2] block/file-posix: allow -drive cache.direct=off live migration

v2: * Add comment on !__linux__ situation [Fam] * Add file-posix.c x-check-cache-dropped=on|off option [DaveG, Kevin] file-posix.c only supports shared storage live migration with -drive cache.direct=off due to cache consistency issues. There are two main shared storage configurations: files on

Re: [Qemu-devel] [PATCH v8 11/35] RISC-V: Mark ROM read-only after copying in code

On Thu, Apr 26, 2018 at 10:34 PM Michael Clark wrote: > On Fri, Apr 27, 2018 at 5:22 PM, Michael Clark wrote: >> On Fri, Apr 27, 2018 at 4:48 AM, Alistair Francis wrote: >>> On Wed, Apr 25, 2018 at 5:03 PM Michael Clark wrote: >>> > The sifive_u machine already marks its ROM readonly. T

Re: [Qemu-devel] release retrospective, next release timing, numbering

On 27.04.2018 17:51, Peter Maydell wrote: > Hi; I usually let people forget about releases for a month or > so before bringing this topic up, but: > > (1) do we want to call the next release 2.13, or something else? > There's no particular reason to bump to 3.0 except some combination of > * if w

Re: [Qemu-devel] [PULL 10/13] cryptodev: add vhost-user as a new cryptodev backend

On 1 March 2018 at 16:46, Michael S. Tsirkin wrote: > From: Gonglei > > Usage: > -chardev socket,id=charcrypto0,path=/path/to/your/socket > -object cryptodev-vhost-user,id=cryptodev0,chardev=charcrypto0 > -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 > > Signed-off-by: Gonglei > S

Re: [Qemu-devel] [PULL v2 31/50] vhost+postcopy: Register shared ufd with postcopy

On 20 March 2018 at 03:17, Michael S. Tsirkin wrote: > From: "Dr. David Alan Gilbert" > > Register the UFD that comes in as the response to the 'advise' method > with the postcopy code. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Marc-André Lureau > Reviewed-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 1/9] target/arm: Implement vector shifted SCVF/UCVF for fp16

Richard Henderson writes: > While we have some of the scalar paths for *CVF for fp16, > we failed to decode the fp16 version of these instructions. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 33 - > 1 file changed, 20 insertions(+)

[Qemu-devel] release retrospective, next release timing, numbering

Hi; I usually let people forget about releases for a month or so before bringing this topic up, but: (1) do we want to call the next release 2.13, or something else? There's no particular reason to bump to 3.0 except some combination of * if we keep going like this we'll get up to 2.42, which sta

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] block: Removed unused sector-based blocking I/O

On 04/27/2018 09:01 AM, Alberto Garcia wrote: > On Thu 26 Apr 2018 03:43:05 PM CEST, Eric Blake wrote: >> We are gradually moving away from sector-based interfaces, towards >> byte-based. Now that all callers of blocking I/O have been converted >> to use our preferred byte-based bdrv_p{read,write}

Re: [Qemu-devel] [PATCH v6 2/5] qobject: use a QObjectBase_ struct

On 04/27/2018 03:24 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> By moving the base fields to a QObjectBase_, QObject can be a type >> which also has a 'base' field. This allows writing a generic QOBJECT() >> macro that will work with any QObject type, including QObject >> itself

Re: [Qemu-devel] [PATCH 1/2] nbd/client: fix nbd_negotiate_simple_meta_context

On 04/27/2018 09:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Initialize received variable. Otherwise, is is possible for server to > answer without any contexts, but we will set context_id to something > random (received_id is not initialized too) and return 1, which is > wrong. > > To solve it,

Re: [Qemu-devel] [PULL 0/4] pc, pci, virtio: fixes, features

On 27 April 2018 at 16:21, Michael S. Tsirkin wrote: > On Fri, Apr 27, 2018 at 10:49:06AM +0100, Peter Maydell wrote: >> On 27 April 2018 at 04:29, Michael S. Tsirkin wrote: >> > The following changes since commit >> > 4743c23509a51bd4ee85cc272287a41917d1be35: >> > >> > Update version for v2.1

Re: [Qemu-devel] [PATCH] hw/arm/virt: Add linux, pci-domain property

On 24 April 2018 at 15:12, Andrew Jones wrote: > On Mon, Apr 23, 2018 at 02:11:40PM +0100, Peter Maydell wrote: >> On 23 April 2018 at 06:18, Jan Kiszka wrote: >> > From: Jan Kiszka >> > >> > This allows to pin the host controller in the Linux PCI domain space. >> > Linux requires that property

Re: [Qemu-devel] [PULL 0/4] pc, pci, virtio: fixes, features

On Fri, Apr 27, 2018 at 10:49:06AM +0100, Peter Maydell wrote: > On 27 April 2018 at 04:29, Michael S. Tsirkin wrote: > > The following changes since commit 4743c23509a51bd4ee85cc272287a41917d1be35: > > > > Update version for v2.12.0 release (2018-04-24 16:44:55 +0100) > > > > are available in t

Re: [Qemu-devel] [PATCH 0/2] fix coverity bugs

On 04/27/2018 09:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > Here are two bug fixes, thanks to Peter for reporting. > > Both are introduced in 2.12. > > Vladimir Sementsov-Ogievskiy (2): > nbd/client: fix nbd_negotiate_simple_meta_context > migration/block-dirty-bitmap: fix memo

Re: [Qemu-devel] [ARM/FDPIC v3 3/4] linux-user: ARM-FDPIC: Add support of FDPIC for ARM.

On 24 April 2018 at 08:27, Christophe Lyon wrote: > Add FDPIC info into image_info structure since interpreter info is on > stack and needs to be saved to be accessed later on. > > Compared to v2: Do not add the is_fdpic field to TaskState, as the > information can be retrieved from the 'info' dat

[Qemu-devel] [PATCH v6 09/11] qmp: permit query-hotpluggable-cpus in preconfig state

it will allow mgmt to query possible CPUs, which depends on used machine(version)/-smp options, without restarting QEMU and use results to configure numa mapping or adding CPUs with device_add* later. Signed-off-by: Igor Mammedov PS: *) device_add is not allowed to run at preconfig in this serie

Re: [Qemu-devel] [ARM/FDPIC v3 4/4] linux-user: ARM-FDPIC: Add support for signals for FDPIC targets

On 24 April 2018 at 08:28, Christophe Lyon wrote: > The FDPIC restorer needs to deal with a function descriptor, hence we > have to extend 'retcode' such that it can hold the instructions needed > to perform this. > > The restorer sequence uses the same thumbness as the exception > handler (mainly

Re: [Qemu-devel] [PATCH 3/9] target/xtensa: Use new min/max expanders

On Thu, Apr 26, 2018 at 5:26 PM, Richard Henderson wrote: > The generic expanders replace nearly identical code in the translator. > > Cc: Max Filippov > Signed-off-by: Richard Henderson > --- > target/xtensa/translate.c | 50 > +++ > 1 file changed,

[Qemu-devel] [PATCH v6 08/11] tests: extend qmp test with preconfig checks

Add permission checks for commands at 'preconfig' stage. Signed-off-by: Igor Mammedov --- v6: * replace 'cont' with 'exit-preconfig' command v5: * s/-preconfig/--preconfig/ v4: * s/is_err()/qmp_rsp_is_err()/ * return true even if 'error' doesn't contain 'desc' (Eric Blake ) --- tests

[Qemu-devel] [PATCH v6 03/11] cli: add --preconfig option

This option allows pausing QEMU in the new RUN_STATE_PRECONFIG state, allowing the configuration of QEMU from QMP before the machine jumps into board initialization code of machine_run_board_init() The intent is to allow management to query machine state and additionally configure it using previou

[Qemu-devel] [PATCH v6 02/11] numa: split out NumaOptions parsing into set_numa_options()

it will allow to reuse set_numa_options() for parsing configuration commands received via QMP interface Signed-off-by: Igor Mammedov --- v5: - (Eduardo Habkost ) * drop if (err) guard around error_propagate() * s/parse_NumaOptions/set_numa_options/ --- include/sysemu/numa.h | 1 + num

[Qemu-devel] [PATCH v6 00/11] enable numa configuration before machine_init() from QMP

v5->v6: * add exit-preconfig QMP command instead of overloading meaning of 'cont' command * add doc text to qemu-tech.texi about -S and --preconfig * add numa configuration example into commit message of 10/11 * limit set-numa-node QMP command to preconfig mode v4->v5: * rebase on top o

[Qemu-devel] [PATCH v6 10/11] qmp: add set-numa-node command

Command is allowed to run only in preconfig stage and will allow to configure numa mapping for CPUs depending on possible CPUs layout (query-hotpluggable-cpus) for given machine instance. Example of configuration session: $QEMU -smp 2 --preconfig ... QMP: -> {'execute': 'query-hotpluggable-cpus'

[Qemu-devel] [PATCH v6 07/11] tests: add allowed-in-preconfig-test for qapi-schema

make sure the QAPISchema can parse allowed-in-preconfig correctly Signed-off-by: Igor Mammedov --- tests/Makefile.include | 1 + tests/qapi-schema/allowed-in-preconfig-test.err | 1 + tests/qapi-schema/allowed-in-preconfig-test.exit | 1 + tests/qapi-schema/allowed-in-

[Qemu-devel] [PATCH v6 01/11] numa: postpone options post-processing till machine_run_board_init()

in preparation for numa options to being handled via QMP before machine_run_board_init(), move final numa configuration checks and processing to machine_run_board_init() so it could take into account both CLI (via parse_numa_opts()) and QMP input Signed-off-by: Igor Mammedov Reviewed-by: Eduardo

[Qemu-devel] [PATCH v6 11/11] tests: functional tests for QMP command set-numa-node

* start QEMU with 2 unmapped cpus, * while in preconfig state * add 2 numa nodes * assign cpus to them * exit preconfig and in running state check that cpus are mapped correctly. Signed-off-by: Igor Mammedov --- v6: * replace 'cont' with 'exit-preconfig' command v5: * s/qobject_

[Qemu-devel] [PATCH v6 04/11] hmp: disable monitor in preconfig state

Ban it for now, if someone would need it to work early, one would have to implement checks if HMP command is valid at preconfig state. Signed-off-by: Igor Mammedov --- v5: * add 'use QMP instead" to error message, suggesting user the right interface to use v4: * v3 was only printing error

  1   2   3   >