On Fri, May 25, 2018 at 10:01:57AM +0100, Stefan Hajnoczi wrote:
> On Fri, May 25, 2018 at 11:30:22AM +0800, Peter Xu wrote:
> > On Thu, May 24, 2018 at 10:28:37AM +0100, Stefan Hajnoczi wrote:
> > > On Thu, May 24, 2018 at 12:39:52PM +0800, Peter Xu wrote:
> > > > int monitor_fdset_get_fd(int64_t
On Thu, May 24, 2018 at 01:16:11PM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > On Thu, May 24, 2018 at 10:41:09AM +0200, Markus Armbruster wrote:
> >> Regarding the subject: what are "fleids"?
> >
> > Ouch. :( I meant the word "fields".
>
> Can touch that up in my tree.
[...]
> >>
On 25.05.2018 16:02, Greg Kurz wrote:
> On Fri, 18 May 2018 18:44:02 +0200
> Cédric Le Goater wrote:
>
>> This IRQ number hint can possibly be used by the VIO devices if the
>> "irq" property is defined on the command line but it seems it is never
>> the case. It is not used in libvirt for instan
The create_unimplemented_device() function is very useful to
register unimplemented devices to the SysBus 'absolute' address.
Some devices are modelled as container of memory subregions,
the subregions being mmio-mapped relatively to the container
base address.
With these container devices, the c
Having these entries sorted helps to add new ones.
Signed-off-by: Philippe Mathieu-Daudé
---
Makefile.objs | 82 +--
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/Makefile.objs b/Makefile.objs
index c6c3554203..2c8cb72407 100644
-
On 04/27/2018 12:51 PM, Peter Maydell wrote:
> Hi; I usually let people forget about releases for a month or
> so before bringing this topic up, but:
[...]
> That will make the next release be 3.0.0.
[...]
> (3) retrospective, lessons learned &c
[...]
> * provide your opinions here ?
Maybe v3 is
GEN qemu-doc.html
GEN qemu-doc.txt
GEN qemu.1
CC s390-ccw/bootmap.o
GEN docs/interop/qemu-qmp-ref.html
./qemu-options.texi:2855: unknown command `address'
./qemu-options.texi:2855: unknown command `hidden'
make: *** [Makefile:915: qemu-doc.html] Error 1
It seems th
On 04/26/2018 05:09 PM, Peter Maydell wrote:
> Our current interface for allowing a device to support execution from
> MMIO regions has the device return a pointer into host memory
> containing the contents to be used for execution. Unfortunately the
> obvious implementation this encourages (and w
Hi,
What is the best git-way to add a new board?
Thinking about testing/review.
The following ways occurred to me:
1/ how RISC-V boards got merged
Add devices individually,
finally add the board and default-configs/Makefile rules at once.
PRO: commits are easier to cherry-pick/rebase
CON:
Hi,
I'd like to connect a specific SD card to a specific SDHCI from command
line, and I'm getting a bit lost with command line options.
I'm using an updated version of this patch, but this is not relevant to
this thread:
http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg01914.html
In th
Issue EXTENDED COPY (LID1) command to implement the copy_range API.
The parameter data construction code is modified from libiscsi's
iscsi-dd.c.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/iscsi.c| 219 +++
include/scs
It's a BlockBackend wrapper of the BDS interface.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/block-backend.c | 18 ++
include/sysemu/block-backend.h | 4
2 files changed, 22 insertions(+)
diff --git a/block/block-backend.c b/block/block-backe
The two callbacks are implemented quite similarly to the read/write
functions: bdrv_co_copy_range_from maps for read and calls into bs->file
or bs->backing depending on the allocation status; bdrv_co_copy_range_to
maps for write and calls into bs->file.
Reviewed-by: Stefan Hajnoczi
Signed-off-by:
The new blk_co_copy_range interface offers a more efficient way in the
case of network based storage. Make use of it to allow faster convert
operation.
Since copy offloading cannot do zero detection ('-S') and compression
(-c), only try it when these options are not used.
Signed-off-by: Fam Zheng
This loop is repeated a growing number times. Make a helper.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
---
block/iscsi.c | 54 +-
1 file changed, 17 insertions(+), 37 deletions(-)
diff --git a/block/iscsi.
We don't verify the request range against s->size in the I/O callbacks
except for raw_co_pwritev. This is inconsistent (especially for
raw_co_pwrite_zeroes and raw_co_pdiscard), so fix them, in the meanwhile
make the helper reusable by the coming new callbacks.
Note that in most cases the block la
Just pass down to ->file.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/raw-format.c | 32
1 file changed, 32 insertions(+)
diff --git a/block/raw-format.c b/block/raw-format.c
index b69a0674b3..f2e468df6f 100644
--- a/block/raw-format.c
+++ b
The device designator data returned in INQUIRY command will be useful to
fill in source/target fields during copy offloading. Do this when
connecting to the target and save the data for later use.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/iscsi.c| 41 ++
With copy_file_range(2), we can implement the bdrv_co_copy_range
semantics.
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/file-posix.c | 96 +++--
include/block/raw-aio.h | 10 --
2 files changed, 101 insertions(+), 5 deleti
v6: Pick up rev-by from Stefan and Eric.
Tweak patch 2 commit message.
v5: - Fix raw offset/bytes check for read. [Eric]
- Fix qcow2_handle_l2meta. [Stefan]
- Add coroutine_fn whereever appropriate. [Stefan]
v4: - Fix raw offset and size. [Eric]
- iscsi: Drop unnecessary return va
Introduce the bdrv_co_copy_range() API for copy offloading. Block
drivers implementing this API support efficient copy operations that
avoid reading each block from the source device and writing it to the
destination devices. Examples of copy offload primitives are SCSI
EXTENDED COPY and Linux co
Hi Alistair,
On 02/27/2018 07:33 PM, Alistair Francis wrote:
> On Fri, Sep 22, 2017 at 10:13 AM, Philippe Mathieu-Daudé
> wrote:
>> From: Grant Likely
>>
>> There really isn't anything tdk-specific about tdk_init() other than the
>> phy id registers. The function should instead be generalized fo
On 05/27/2018 08:31 PM, Philippe Mathieu-Daudé wrote:
> On 05/27/2018 11:13 AM, Richard Henderson wrote:
>> Rather than pass base+offset to the helper, pass the full index.
>> In most cases the base is r0 and optimization yields a constant.
>
> and while here you use generic TCGv instead of 32bit
On 05/27/2018 11:13 AM, Richard Henderson wrote:
> The sizes are already the same, however, we can improve things
> if they are identical by design.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/openrisc/cpu.h| 10 --
> target/openrisc
On 05/27/2018 11:13 AM, Richard Henderson wrote:
> These values are unused.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/openrisc/translate.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/target/openrisc/translate.c b/target/openrisc/t
On 05/27/2018 11:13 AM, Richard Henderson wrote:
> This allows us to limit the amount of ifdefs and isolate
> the test for usermode.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/openrisc/translate.c | 27 ---
> 1 file changed,
On 05/27/2018 11:13 AM, Richard Henderson wrote:
> Rather than pass base+offset to the helper, pass the full index.
> In most cases the base is r0 and optimization yields a constant.
and while here you use generic TCGv instead of 32bit version.
>
> Signed-off-by: Richard Henderson
Reviewed-by:
On 05/27/2018 11:13 AM, Richard Henderson wrote:
> With tlb_fill in mmu.c, we can simplify things further.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/openrisc/mmu.c | 11 ++
> target/openrisc/mmu_helper.c | 40 -
On 05/27/2018 11:13 AM, Richard Henderson wrote:
> While we had defines for *_WAY, we didn't define more than 1.
> Reduce the complexity by eliminating this unused dimension.
>
> Signed-off-by: Richard Henderson
> ---
> target/openrisc/cpu.h| 6 ++
> target/openrisc/machine.c|
On 05/27/2018 11:13 AM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/openrisc/interrupt.c | 30 +-
> 1 file changed, 25 insertions(+), 5 deletions(-)
>
> diff --git a/target/openrisc/interrupt.c b/ta
> -Original Message-
> From: Stefan Hajnoczi [mailto:stefa...@redhat.com]
> Sent: Friday, May 25, 2018 6:20 PM
> To: Liu, Changpeng
> Cc: qemu-devel@nongnu.org; m...@redhat.com
> Subject: Re: [PATCH] vhost-blk: turn on pre-defined RO feature bit
>
> On Tue, May 22, 2018 at 02:39:28PM +0
On 05/25/2018 01:53 AM, Gerd Hoffmann wrote:
> Fixes: CID 1391291
> Signed-off-by: Gerd Hoffmann
> ---
> hw/display/bochs-display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
> index c33524b558..1187d77576 100644
> --- a/hw/di
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180527141324.11937-1-richard.hender...@linaro.org
Subject: [Qemu-devel] [PATCH 00/20] target/openrisc improvements
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
tota
Signed-off-by: Richard Henderson
---
target/openrisc/interrupt.c | 30 +-
1 file changed, 25 insertions(+), 5 deletions(-)
diff --git a/target/openrisc/interrupt.c b/target/openrisc/interrupt.c
index e28042856a..138ad17f00 100644
--- a/target/openrisc/interrupt.c
+++
The previous code was confused, avoiding the flush of the old entry
if the new entry is invalid. We need to flush the old page if the
old entry is valid and the new page if the new entry is valid.
This bug was masked by over-flushing elsewhere.
Signed-off-by: Richard Henderson
---
target/openr
With tlb_fill in mmu.c, we can simplify things further.
Signed-off-by: Richard Henderson
---
target/openrisc/mmu.c | 11 ++
target/openrisc/mmu_helper.c | 40 ---
target/openrisc/Makefile.objs | 2 +-
3 files changed, 12 insertions(+), 41 deletio
Signed-off-by: Richard Henderson
---
scripts/qemu-binfmt-conf.sh | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
index 7ab7435fbd..75ed7c6b65 100755
--- a/scripts/qemu-binfmt-conf.sh
+++ b/scripts/qemu-binfmt
While openrisc has a split i/d tlb, qemu does not. Perform a
lookup on both i & d tlbs in parallel and put the composite
rights into qemu's tlb. This avoids ping-ponging the qemu tlb
between EXEC and READ.
Signed-off-by: Richard Henderson
---
target/openrisc/cpu.h | 8 --
target/openrisc/mmu
There is no reason to use an indirect branch instead
of simply testing the SR bits that control mmu state.
Signed-off-by: Richard Henderson
---
target/openrisc/cpu.h | 11 -
target/openrisc/cpu.c | 4 --
target/openrisc/interrupt.c| 2 -
target/openrisc/in
The code in cpu_mmu_index does not properly honor SR_DME.
This bug has workarounds elsewhere in that we flush the
tlb more often than necessary, on the state changes that
should be reflected in a change of mmu_index.
Fixing this means that we can respect the mmu_index that
is given to tlb_flush.
The architecture supports 128 TLB entries. There is no reason
not to provide all of them. In the process we need to fix a
bug that failed to parameterize the configuration register that
tells the operating system the number of entries.
Signed-off-by: Richard Henderson
---
target/openrisc/cpu.h
Rather than emit disassembly while translating, reuse the
generated decoder to build a separate disassembler.
Signed-off-by: Richard Henderson
---
target/openrisc/cpu.h | 1 +
target/openrisc/cpu.c | 6 ++
target/openrisc/disas.c | 171 ++
This hook is only used by CONFIG_USER_ONLY.
Signed-off-by: Richard Henderson
---
target/openrisc/mmu.c | 35 +--
1 file changed, 5 insertions(+), 30 deletions(-)
diff --git a/target/openrisc/mmu.c b/target/openrisc/mmu.c
index ee3016a8b9..2f1f16fd6b 100644
--- a/
This allows us to limit the amount of ifdefs and isolate
the test for usermode.
Signed-off-by: Richard Henderson
---
target/openrisc/translate.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/target/openrisc/translate.c b/target/openrisc/transla
While we had defines for *_WAY, we didn't define more than 1.
Reduce the complexity by eliminating this unused dimension.
Signed-off-by: Richard Henderson
---
target/openrisc/cpu.h| 6 ++
target/openrisc/machine.c| 6 ++
target/openrisc/mmu.c| 30 ---
There is no reason to allocate this separately. This was probably
copied from target/mips which makes the same mistake.
While doing so, move tlb into the clear-on-reset range. While not
all of the TLB bits are guaranteed zero on reset, all of the valid
bits are cleared, and the rest of the bits
Track direct jumps via dc->jmp_pc_imm. Use that in
preference to jmp_pc when possible. Emit goto_tb in
that case, and lookup_and_goto_tb otherwise.
Signed-off-by: Richard Henderson
---
target/openrisc/translate.c | 82 +
1 file changed, 46 insertions(+), 36
We failed to store to cpu_pc before raising the exception,
which caused us to re-execute the same insn that we stepped.
Signed-off-by: Richard Henderson
---
target/openrisc/translate.c | 35 +--
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/targe
The sizes are already the same, however, we can improve things
if they are identical by design.
Signed-off-by: Richard Henderson
---
target/openrisc/cpu.h| 10 --
target/openrisc/machine.c| 4 ++--
target/openrisc/mmu.c| 4 ++--
target/openrisc/sys_helper.c | 16 +++
A store to SR changes interrupt state, which should return
to the main loop to recognize that state.
Signed-off-by: Richard Henderson
---
target/openrisc/translate.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/target/openrisc/translate.c b/target/
Rather than pass base+offset to the helper, pass the full index.
In most cases the base is r0 and optimization yields a constant.
Signed-off-by: Richard Henderson
---
target/openrisc/helper.h | 4 ++--
target/openrisc/sys_helper.c | 9 +++--
target/openrisc/translate.c | 16 +-
These values are unused.
Signed-off-by: Richard Henderson
---
target/openrisc/translate.c | 4
1 file changed, 4 deletions(-)
diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c
index e7c96ca990..f4f2f37e28 100644
--- a/target/openrisc/translate.c
+++ b/target/openrisc/t
No need to use the interrupt mechanisms when we can
simply exit the tb directly.
Signed-off-by: Richard Henderson
---
target/openrisc/interrupt_helper.c | 3 +--
target/openrisc/translate.c| 6 +++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/target/openrisc/interrup
This is almost a grab-bag of little improvements to the port.
patches 1-3:
Fix singlestepping for gdbstub. This has apparently never
worked, as the first commit has the same bug of not advancing
the pc when stepping.
patches 4-5:
Exit the TB after l.mtspr insns. In particular, storing t
** Changed in: qemu
Status: Incomplete => Triaged
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1396052
Title:
migration failed when running BurnInTest in guest
Status in QEMU:
Triaged
B
On Fri, May 25, 2018 at 05:36:09PM +0200, Marc-André Lureau wrote:
Signed-off-by: Marc-André Lureau
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
On Fri, May 25, 2018 at 06:53:44AM +0200, Gerd Hoffmann wrote:
Fixes: CID 1391291
Signed-off-by: Gerd Hoffmann
---
hw/display/bochs-display.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
On Fri, May 25, 2018 at 09:50:42AM +0800, Peter Xu wrote:
Buffers allocated with bitmap_new() should be freed with g_free().
Both reported by Coverity:
*** CID 1391300: API usage errors (ALLOC_FREE_MISMATCH)
/migration/ram.c: 3517 in ram_dirty_bitmap_reload()
3511 * the last one to s
58 matches
Mail list logo
