Re: [Qemu-devel] [PATCH v4 00/19] reverse debugging

2018-06-04 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > > Ping? > > I started having a look but I ran into this straight away. First I > recorded a boot of the kernel: > > ./aarch64-softmmu/qemu-system-aarch64 -machine virt,graphics=on,gic- >

Re: [Qemu-devel] [PATCH 6/6] linux-user: Use *at functions to implement interp_prefix

2018-06-04 Thread Richard Henderson
On 06/03/2018 06:04 PM, Laurent Vivier wrote: > On 01/06/2018 00:49, Richard Henderson wrote: >> If the interp_prefix is a complete chroot, it may have a *lot* of files. >> Setting up the cache for this is quite expensive. >> >> For the most part, we can use the *at versions of various syscalls to

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-04 Thread Thomas Huth
On 05.06.2018 03:17, Alex Williamson wrote: > On Mon, 4 Jun 2018 17:21:40 +0100 > Peter Maydell wrote: > >> The codebase has a bit of a mix of >> /* multiline comments >> * like this >> */ >> and >> /* multiline comments like this >> in the GNU Coding Standards style */ >> >> State a

[Qemu-devel] [Bug 1441443] Re: Is there a way to create a 10G network interface for VMs in KVM2.0?

2018-06-04 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1441443 Title: Is there a

[Qemu-devel] The side effect of changing Processor Brand string?

2018-06-04 Thread You, Lizhen
Hi All, I'd like to change the Processor Brand String(CPUID[0x8002|0x8003|0x8004]) of my guest OSS cpu model to a string that won't be standard Intel or AMD related processor brand string. Would this change have any side effect on the applications that run on this guest? Seems

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-04 Thread Thomas Huth
On 05.06.2018 00:40, Eric Blake wrote: > On 06/04/2018 05:34 AM, Thomas Huth wrote: >> On 04.06.2018 09:18, Markus Armbruster wrote: >>> Roman Kagan writes: >>> Add helper functions to query the block drivers actually supported by QEMU using "-drive format=?".  This allows to skip

Re: [Qemu-devel] [PATCH 2/4] sparp_pci: simplify how the PCI LSIs are allocated

2018-06-04 Thread David Gibson
On Sat, May 26, 2018 at 11:40:23AM +0200, Greg Kurz wrote: > On Fri, 18 May 2018 18:44:03 +0200 > Cédric Le Goater wrote: > > > PCI LSIs are today allocated one by one using the IRQ alloc_block > > routine. Change the code sequence to first allocate a PCI_NUM_PINS > > block. It will help us

Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues

2018-06-04 Thread Peter Xu
On Mon, Jun 04, 2018 at 05:01:21PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Jun 4, 2018 at 10:06 AM, Peter Xu wrote: > > Previously we cleanup the queues when we got CLOSED event. It was used > > to make sure we won't leftover replies/events of a old client to a new > > client. Now

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-06-04 Thread David Gibson
On Mon, May 28, 2018 at 09:06:12AM +0200, Cédric Le Goater wrote: > On 05/28/2018 08:17 AM, Thomas Huth wrote: > > On 25.05.2018 16:02, Greg Kurz wrote: > >> On Fri, 18 May 2018 18:44:02 +0200 > >> Cédric Le Goater wrote: > >> > >>> This IRQ number hint can possibly be used by the VIO devices if

Re: [Qemu-devel] [PATCH v3] target/ppc: Allow privileged access to SPR_PCR

2018-06-04 Thread David Gibson
On Mon, Jun 04, 2018 at 06:15:13PM +0930, Joel Stanley wrote: > The powerpc Linux kernel[1] and skiboot firmware[2] recently gained changes > that cause the Processor Compatibility Register (PCR) SPR to be cleared. > > These changes cause Linux to fail to boot on the Qemu powernv machine > with

Re: [Qemu-devel] [PATCH v11 4/5] i386: Enable TOPOEXT feature on AMD EPYC CPU

2018-06-04 Thread Eduardo Habkost
On Thu, May 24, 2018 at 11:43:33AM -0400, Babu Moger wrote: > Enable TOPOEXT feature on EPYC CPU. This is required to support > hyperthreading on VM guests. Also extend xlevel to 0x801E. > > Disable TOPOEXT feature for legacy machines and also disable > TOPOEXT feature if the config cannot be

Re: [Qemu-devel] [PATCH v1 5/7] docker: Update fedora image to 28

2018-06-04 Thread Fam Zheng
On Mon, 06/04 15:51, Alex Bennée wrote: > From: Fam Zheng > > Signed-off-by: Fam Zheng > Signed-off-by: Alex Bennée > --- > tests/docker/dockerfiles/fedora.docker | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/dockerfiles/fedora.docker >

Re: [Qemu-devel] [PATCH v11 3/5] i386: Add support for CPUID_8000_001E for AMD

2018-06-04 Thread Eduardo Habkost
On Thu, May 24, 2018 at 11:43:32AM -0400, Babu Moger wrote: > Add support for cpuid leaf CPUID_8000_001E. Build the config that closely > match the underlying hardware. Please refer to the Processor Programming > Reference (PPR) for AMD Family 17h Model for more details. > > Signed-off-by: Babu

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-04 Thread Jason Wang
On 2018年06月05日 09:41, Samudrala, Sridhar wrote: Ping on this patch now that the kernel patches are accepted into davem's net-next tree. https://patchwork.ozlabs.org/cover/920005/ On 5/7/2018 4:09 PM, Sridhar Samudrala wrote: This feature bit can be used by hypervisor to indicate virtio_net

Re: [Qemu-devel] [PATCH v11 2/5] i386: Populate AMD Processor Cache Information for cpuid 0x8000001D

2018-06-04 Thread Eduardo Habkost
On Thu, May 24, 2018 at 11:43:31AM -0400, Babu Moger wrote: > Add information for cpuid 0x801D leaf. Populate cache topology information > for different cache types (Data Cache, Instruction Cache, L2 and L3) supported > by 0x801D leaf. Please refer to the Processor Programming Reference

Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-04 Thread Samudrala, Sridhar
Ping on this patch now that the kernel patches are accepted into davem's net-next tree. https://patchwork.ozlabs.org/cover/920005/ On 5/7/2018 4:09 PM, Sridhar Samudrala wrote: This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with

Re: [Qemu-devel] [PATCH v4 08/14] spapr: handle pc-dimm unplug via hotplug handler chain

2018-06-04 Thread David Gibson
On Thu, May 17, 2018 at 10:15:21AM +0200, David Hildenbrand wrote: > Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/ > unplug memory devices (which a pc-dimm is) later. > > Signed-off-by: David Hildenbrand > --- > hw/ppc/spapr.c | 23 +++ > 1 file

Re: [Qemu-devel] [PATCH v4 09/14] spapr: handle cpu core unplug via hotplug handler chain

2018-06-04 Thread David Gibson
On Thu, May 17, 2018 at 10:15:22AM +0200, David Hildenbrand wrote: > Let's handle it via hotplug_handler_unplug(). > > Signed-off-by: David Hildenbrand Acked-by: David Gibson > --- > hw/ppc/spapr.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-04 Thread Alex Williamson
On Mon, 4 Jun 2018 17:21:40 +0100 Peter Maydell wrote: > The codebase has a bit of a mix of > /* multiline comments > * like this > */ > and > /* multiline comments like this > in the GNU Coding Standards style */ > > State a preference for the former. > > Signed-off-by: Peter

Re: [Qemu-devel] [PATCH v4 07/14] spapr: route all memory devices through the machine hotplug handler

2018-06-04 Thread David Gibson
On Thu, May 17, 2018 at 10:15:20AM +0200, David Hildenbrand wrote: > Necessary to hotplug them cleanly later. > > Signed-off-by: David Hildenbrand As for PC, I think it would be nicer to drop the explicit check against PC_DIMM, since it is covered by MEMORY_DEVICE. > --- > hw/ppc/spapr.c | 1

Re: [Qemu-devel] [PATCH v4 06/14] spapr: prepare for multi stage hotplug handlers

2018-06-04 Thread David Gibson
On Thu, May 17, 2018 at 10:15:19AM +0200, David Hildenbrand wrote: > For multi stage hotplug handlers, we'll have to do some error handling > in some hotplug functions, so let's use a local error variable (except > for unplug requests). > > Also, add code to pass control to the final stage

Re: [Qemu-devel] [PATCH v4 03/14] qdev: let machine hotplug handler to override bus hotplug handler

2018-06-04 Thread David Gibson
On Thu, May 17, 2018 at 10:15:16AM +0200, David Hildenbrand wrote: > From: Igor Mammedov > > it will allow to return another hotplug handler than the default > one for a specific bus based device type. Which is needed to handle > non trivial plug/unplug sequences that need the access to

Re: [Qemu-devel] [PATCH v2 2/2] vl: fix use of --daemonize with --preconfig

2018-06-04 Thread Eduardo Habkost
On Mon, Jun 04, 2018 at 05:01:11PM +0200, Igor Mammedov wrote: [...] > I'd prefer your patch, as it doesn't break error handling, > or maybe even shorter version which keeps state transitions in one place: > > diff --git a/vl.c b/vl.c > index c4fe255..fa44138 100644 > --- a/vl.c > +++ b/vl.c > @@

Re: [Qemu-devel] [PATCH] vl.c: make default main_loop_wait() timeout independed of slirp

2018-06-04 Thread Eduardo Habkost
On Mon, Jun 04, 2018 at 10:14:38PM +0200, Igor Mammedov wrote: > Since commit (047f7038f58 cli: add --preconfig option) QEMU is > stuck with indefinite timeout in os_host_main_loop_wait() > at RUN_STATE_PRECONFIG even if --preconfig option wasn't used > when it's started with -nodefaults CLI

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Eduardo Habkost
On Mon, Jun 04, 2018 at 04:21:47PM +0200, Michal Privoznik wrote: [...] > > @@ -3572,7 +3570,12 @@ int main(int argc, char **argv, char **envp) > > } > > break; > > case QEMU_OPTION_preconfig: > > -preconfig_exit_requested = false; > >

Re: [Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified

2018-06-04 Thread Eduardo Habkost
On Mon, Jun 04, 2018 at 11:32:44AM +0100, Daniel P. Berrangé wrote: [...] > Avoiding the double-run of main_loop is good, however, I think we should > also not have put current_run_state in RUN_STATE_PRECONFIG in the first > place if --preconfig wasn't set. I've sent a patch to fix that problem >

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Eduardo Habkost
On Mon, Jun 04, 2018 at 07:37:15PM +0200, Igor Mammedov wrote: > On Mon, 4 Jun 2018 17:11:57 +0100 > Daniel P. Berrangé wrote: > > > On Mon, Jun 04, 2018 at 05:40:32PM +0200, Igor Mammedov wrote: > > > On Mon, 4 Jun 2018 13:03:44 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > The

Re: [Qemu-devel] [PATCH] spapr: don't call KVM_PPC_CONFIGURE_V3_MMU if HPT is in userspace

2018-06-04 Thread David Gibson
On Fri, May 25, 2018 at 02:54:12PM +0200, Greg Kurz wrote: > Since the kernel commit "dbfcf3cb9c68 powerpc/64: Call H_REGISTER_PROC_TBL > when running as a HPT guest on POWER9", a nested guest running with PR KVM > hangs at boot: > > Preparing to boot Linux version 4.16.0-kvm-pr-hang-gku+ >

Re: [Qemu-devel] [RFC PATCH] target/ppc: extend eieio for POWER9

2018-06-04 Thread David Gibson
On Mon, Jun 04, 2018 at 07:20:39PM +0200, Cédric Le Goater wrote: > POWER9 introduced a new variant of the eieio instruction using bit 6 > as a hint to tell the CPU it is a store-forwarding barrier. > > The usage of this eieio extension was recently added in Linux 4.17 > which activated the

Re: [Qemu-devel] [PATCH 1/6] ahci: move PIO Setup FIS before transfer, fix it for ATAPI commands

2018-06-04 Thread John Snow
On 06/04/2018 11:50 AM, Paolo Bonzini wrote: > On 02/06/2018 03:22, John Snow wrote: >> - Status: Should be the status register after receiving the H2D Register >> update FIS, but prior to the data transfer, I think. "New value of the >> Status register of the Command Block for initiation

Re: [Qemu-devel] [PATCH v3 2/3] WHPX: dynamically load WHP libraries

2018-06-04 Thread Justin Terry (VM) via Qemu-devel
Paolo - I saw that this merged with commit: 327fccb288976f95808efa968082fc9d4a9ced84 but it seems to be missing whp-dispatch.h so now the build is failing. Any idea how this file failed to get included? Thanks, Justin > -Original Message- > From: petrutlucia...@gmail.com > Sent:

Re: [Qemu-devel] [PATCH 7/8] sdcard: Reflect when the Spec v3 is supported in the Config Register (SCR)

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > include/hw/sd/sd.h | 1 + > hw/sd/sd.c | 7 +-- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-04 Thread Eric Blake
On 06/04/2018 05:34 AM, Thomas Huth wrote: On 04.06.2018 09:18, Markus Armbruster wrote: Roman Kagan writes: Add helper functions to query the block drivers actually supported by QEMU using "-drive format=?". This allows to skip certain tests that require drivers not built in or whitelisted

Re: [Qemu-devel] [PATCH 05/12] migration: show the statistics of compression

2018-06-04 Thread Eric Blake
On 06/04/2018 04:55 AM, guangrong.x...@gmail.com wrote: From: Xiao Guangrong Then the uses can adjust the parameters based on this info Currently, it includes: pages: amount of pages compressed and transferred to the target VM busy: amount of count that no free thread to compress data

Re: [Qemu-devel] [PATCH V8 11/17] qapi: Add new command to query colo status

2018-06-04 Thread Eric Blake
On 06/03/2018 12:05 AM, Zhang Chen wrote: Libvirt or other high level software can use this command query colo status. You can test this command like that: {'execute':'query-colo-status'} Signed-off-by: Zhang Chen --- +++ b/qapi/migration.json @@ -1231,6 +1231,40 @@ ## { 'command':

Re: [Qemu-devel] [PATCH V8 10/17] qmp event: Add COLO_EXIT event to notify users while exited COLO

2018-06-04 Thread Eric Blake
On 06/03/2018 12:05 AM, Zhang Chen wrote: From: zhanghailiang If some errors happen during VM's COLO FT stage, it's important to notify the users of this event. Together with 'x-colo-lost-heartbeat', Users can intervene in COLO's failover work immediately. If users don't want to get involved

Re: [Qemu-devel] [RFC] qapi: command category to stimulate high-level machine devices

2018-06-04 Thread Eric Blake
On 06/01/2018 10:16 PM, Steffen Görtz wrote: From: Steffen Goertz Add a new category "stimulate" to host commands that act upon high-level devices associated with machines/boards. This is patch is part of an effort to add support for BBC:microbit educational computer to QEMU. The microbit

Re: [Qemu-devel] [PATCH RESEND v1 0/3] add support for VCPU event states

2018-06-04 Thread gengdongjiu
> On 1 June 2018 at 15:16, gengdongjiu wrote: > > Hi Peter, > > >> You should wait for that to get into master (it is in Paolo's most > >> recent patchset but that has an issue with a different patch, so is > >> waiting on Paolo to do a respin). Then you can base on that. At that > >> point a

Re: [Qemu-devel] [PATCH v2 2/2] vl: fix use of --daemonize with --preconfig

2018-06-04 Thread Igor Mammedov
On Mon, 4 Jun 2018 13:03:45 +0100 Daniel P. Berrangé wrote: > When using --daemonize, the initial lead process will fork a child and > then wait to be notified that setup is complete via a pipe, before it > exits. When using --preconfig there is an extra call to main_loop() > before the

[Qemu-devel] [PATCH v2] tcg-target.inc.c: Use byte form of xgetbv instruction

2018-06-04 Thread John Arbuckle
Signed-off-by: John Arbuckle --- v2 changes: - Fixed a spacing issue in the asm() function. tcg/i386/tcg-target.inc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index 5357909fff..09141fa8e0 100644 ---

Re: [Qemu-devel] [Qemu-block] [PATCH v2 5/8] qcow: Switch to a byte-based driver

2018-06-04 Thread Jeff Cody
On Thu, May 31, 2018 at 03:50:43PM -0500, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. The qcow driver is now ready to fully utilize the > byte-based callback interface, as long as we override the default > alignment to still be 512 (needed

Re: [Qemu-devel] [Qemu-block] [PATCH v2 4/8] qcow: Switch qcow_co_writev to byte-based calls

2018-06-04 Thread Jeff Cody
On Thu, May 31, 2018 at 03:50:42PM -0500, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the internals of the qcow > driver write function, by iterating over offset/bytes instead of > sector_num/nb_sectors, and with a

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/8] qcow: Switch qcow_co_readv to byte-based calls

2018-06-04 Thread Jeff Cody
On Thu, May 31, 2018 at 03:50:41PM -0500, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the internals of the qcow > driver read function, by iterating over offset/bytes instead of > sector_num/nb_sectors, and with a rename

Re: [Qemu-devel] [PATCH] tcg-target.inc.c: Use byte form of xgetbv instruction

2018-06-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180604211106.4442-1-programmingk...@gmail.com Subject: [Qemu-devel] [PATCH] tcg-target.inc.c: Use byte form of xgetbv instruction === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

2018-06-04 Thread Eduardo Habkost
On Mon, Jun 04, 2018 at 04:22:05PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Jun 04, 2018 at 05:07:01PM -0300, Eduardo Habkost wrote: > > On Fri, Jun 01, 2018 at 11:38:08AM -0400, Konrad Rzeszutek Wilk wrote: > > > AMD future CPUs expose _two_ ways to utilize the Intel equivalant > > > of the

[Qemu-devel] [PATCH] tcg-target.inc.c: Use byte form of xgetbv instruction

2018-06-04 Thread John Arbuckle
The assembler in most versions of Mac OS X is pretty old and does not support the xgetbv instruction. To go around this problem the raw encoding of the instruction is used instead. Signed-off-by: John Arbuckle --- tcg/i386/tcg-target.inc.c | 6 +- 1 file changed, 5 insertions(+), 1

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread Eduardo Habkost
On Mon, Jun 04, 2018 at 09:40:15PM +0300, Marcel Apfelbaum wrote: > > > On 06/04/2018 07:56 PM, Daniel P. Berrangé wrote: > > On Mon, Jun 04, 2018 at 07:48:51PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Jun 04, 2018 at 02:01:29PM +0100, Daniel P. Berrangé wrote: > > > > On Mon, Jun 04, 2018

Re: [Qemu-devel] [PATCH 10/33] linux-user: Split out brk, close, exit, read, write

2018-06-04 Thread Richard Henderson
On 06/04/2018 01:17 PM, Laurent Vivier wrote: > Le 01/06/2018 à 09:30, Richard Henderson a écrit : >> These are relatively simple unconditionally defined syscalls. >> >> Signed-off-by: Richard Henderson >> --- >> linux-user/syscall.c | 198 --- >> 1 file

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/8] qcow: Switch get_cluster_offset to be byte-based

2018-06-04 Thread Jeff Cody
On Thu, May 31, 2018 at 03:50:40PM -0500, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the internal helper function > get_cluster_offset(), by changing n_start and n_end to by byte s/by\ byte/be\ byte/ > offsets rather

Re: [Qemu-devel] Preconfig state reachable without --preconfig given

2018-06-04 Thread Igor Mammedov
On Mon, 4 Jun 2018 16:04:33 +0200 Max Reitz wrote: > On 2018-06-02 12:46, Michal Privoznik wrote: > > On 06/01/2018 03:28 PM, Max Reitz wrote: > >> Hi, > >> > >> The @preconfig RunState documentation states: > >> > >>> The state is reachable only if the --preconfig CLI option is used. > >>

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

2018-06-04 Thread Konrad Rzeszutek Wilk
On Mon, Jun 04, 2018 at 05:07:01PM -0300, Eduardo Habkost wrote: > On Fri, Jun 01, 2018 at 11:38:08AM -0400, Konrad Rzeszutek Wilk wrote: > > AMD future CPUs expose _two_ ways to utilize the Intel equivalant > > of the Speculative Store Bypass Disable. The first is via > > the virtualized

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

2018-06-04 Thread Konrad Rzeszutek Wilk
On Mon, Jun 04, 2018 at 09:54:40AM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 01, 2018 at 11:38:08AM -0400, Konrad Rzeszutek Wilk wrote: > > AMD future CPUs expose _two_ ways to utilize the Intel equivalant > > of the Speculative Store Bypass Disable. The first is via > > the virtualized

Re: [Qemu-devel] [PATCH 10/33] linux-user: Split out brk, close, exit, read, write

2018-06-04 Thread Laurent Vivier
Le 01/06/2018 à 09:30, Richard Henderson a écrit : > These are relatively simple unconditionally defined syscalls. > > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 198 --- > 1 file changed, 111 insertions(+), 87 deletions(-) > > diff

[Qemu-devel] [PATCH] vl.c: make default main_loop_wait() timeout independed of slirp

2018-06-04 Thread Igor Mammedov
Since commit (047f7038f58 cli: add --preconfig option) QEMU is stuck with indefinite timeout in os_host_main_loop_wait() at RUN_STATE_PRECONFIG even if --preconfig option wasn't used when it's started with -nodefaults CLI option like this: ./s390x-softmmu/qemu-system-s390x -nodefaults It's

[Qemu-devel] [Bug 1757363] Re: infinite loop due to improper deal with "eret" on mips32

2018-06-04 Thread Philippe Mathieu-Daudé
What model/cpu is your router? Which MIPS guest CPU are you using? Are you sure it matches the CPU of your router? Is your tplink firmware publicly available? (to reproduce your problem). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: Add case for a corrupted inactive image

2018-06-04 Thread Jeff Cody
On Mon, Jun 04, 2018 at 04:14:37PM +0200, Max Reitz wrote: > Signed-off-by: Max Reitz Aborts without patch 1, passes with it, so a twofer: Tested-by: Jeff Cody Reviewed-by: Jeff Cody > --- > tests/qemu-iotests/060 | 30 ++ > tests/qemu-iotests/060.out | 14

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

2018-06-04 Thread Eduardo Habkost
On Fri, Jun 01, 2018 at 11:38:08AM -0400, Konrad Rzeszutek Wilk wrote: > AMD future CPUs expose _two_ ways to utilize the Intel equivalant > of the Speculative Store Bypass Disable. The first is via > the virtualized VIRT_SPEC CTRL MSR (0xC001_011f) and the second > is via the SPEC_CTRL MSR

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] qcow2: Do not mark inactive images corrupt

2018-06-04 Thread Jeff Cody
On Mon, Jun 04, 2018 at 04:14:36PM +0200, Max Reitz wrote: > When signaling a corruption on a read-only image, qcow2 already makes > fatal events non-fatal (i.e., they will not result in the image being > closed, and the image header's corrupt flag will not be set). This is > necessary because we

Re: [Qemu-devel] [PATCH 09/33] linux-user: Set up infrastructure for table-izing syscalls

2018-06-04 Thread Laurent Vivier
Le 01/06/2018 à 09:30, Richard Henderson a écrit : > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 42 ++ > 1 file changed, 34 insertions(+), 8 deletions(-) > Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH 08/33] linux-user: Make syscall number unsigned

2018-06-04 Thread Laurent Vivier
Le 01/06/2018 à 09:30, Richard Henderson a écrit : > Signed-off-by: Richard Henderson > --- > linux-user/qemu.h| 2 +- > linux-user/syscall.c | 20 ++-- > 2 files changed, 11 insertions(+), 11 deletions(-) > Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH 07/33] linux-user: Propagate goto fail to return

2018-06-04 Thread Laurent Vivier
Le 01/06/2018 à 09:30, Richard Henderson a écrit : > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 62 > 1 file changed, 23 insertions(+), 39 deletions(-) > > @@ -9951,18 +9947,15 @@ static abi_long do_syscall1(void *cpu_env, int

Re: [Qemu-devel] [RFC PATCH] hw/registerfields: Deposit fields "in place"

2018-06-04 Thread Philippe Mathieu-Daudé
On 06/04/2018 03:01 PM, Alistair Francis wrote: > On Sat, Jun 2, 2018 at 3:26 PM, Philippe Mathieu-Daudé > wrote: >> On 06/02/2018 05:55 PM, Philippe Mathieu-Daudé wrote: >>> These macros are always used to deposit a field in place. >>> Update them to take the pointer argument. >>> >>> As these

Re: [Qemu-devel] [PATCH 06/33] linux-user: Split out goto unimplemented to do_unimplemented

2018-06-04 Thread Laurent Vivier
Le 01/06/2018 à 09:30, Richard Henderson a écrit : > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 82 +++- > 1 file changed, 43 insertions(+), 39 deletions(-) > Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH 05/33] linux-user: Propagate goto unimplemented_nowarn to return

2018-06-04 Thread Laurent Vivier
Le 01/06/2018 à 09:30, Richard Henderson a écrit : > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH 04/33] linux-user: Propagate goto efault to return

2018-06-04 Thread Laurent Vivier
Le 01/06/2018 à 09:30, Richard Henderson a écrit : > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 311 +-- > 1 file changed, 154 insertions(+), 157 deletions(-) > Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH 03/33] linux-user: Propagate goto ebadf to return

2018-06-04 Thread Laurent Vivier
Le 01/06/2018 à 09:30, Richard Henderson a écrit : > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 187 +-- > 1 file changed, 92 insertions(+), 95 deletions(-) > Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH 02/33] linux-user: Relax single exit from "break"

2018-06-04 Thread Laurent Vivier
Le 01/06/2018 à 09:30, Richard Henderson a écrit : > Transform outermost "break" to "return ret". If the immediately > preceeding statement was an assignment to ret, return the value > directly. > > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 969

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-04 Thread Philippe Mathieu-Daudé
On 06/04/2018 01:21 PM, Peter Maydell wrote: > The codebase has a bit of a mix of > /* multiline comments > * like this > */ > and > /* multiline comments like this > in the GNU Coding Standards style */ > > State a preference for the former. > > Signed-off-by: Peter Maydell > --- > I

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qcow2: Do not mark inactive images corrupt

2018-06-04 Thread John Snow
On 06/04/2018 10:14 AM, Max Reitz wrote: > The non-public logs in > https://bugzilla.redhat.com/show_bug.cgi?id=1583346 (sorry...) reveal > this problem: > > $ (Create a qcow2 file "foo.qcow2" with a corrupted first L1 entry) > $ echo 'qemu-io none0 "read 0 512"' \ > |

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread Marcel Apfelbaum
On 06/04/2018 07:56 PM, Daniel P. Berrangé wrote: On Mon, Jun 04, 2018 at 07:48:51PM +0300, Michael S. Tsirkin wrote: On Mon, Jun 04, 2018 at 02:01:29PM +0100, Daniel P. Berrangé wrote: On Mon, Jun 04, 2018 at 09:54:15AM -0300, Eduardo Habkost wrote: On Mon, Jun 04, 2018 at 04:38:22AM

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread Eduardo Habkost
On Mon, Jun 04, 2018 at 08:17:23PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2018 at 10:26:24AM -0300, Eduardo Habkost wrote: > > On Mon, Jun 04, 2018 at 02:01:29PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Jun 04, 2018 at 09:54:15AM -0300, Eduardo Habkost wrote: > > > > On Mon, Jun

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread Marcel Apfelbaum
Hi Michael, On 06/04/2018 04:38 AM, Michael S. Tsirkin wrote: On Sun, Jun 03, 2018 at 12:27:49PM +0300, Marcel Apfelbaum wrote: Moving to QEMU 3.0 seems like a good opportunity for such a change. I440FX is really old and does not support modern features like IOMMU. Q35's SATA emulation is

Re: [Qemu-devel] [PATCH 5/8] hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Can you add a justification for this in the commit message? Alistair > --- > hw/sd/ssi-sd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c > index

Re: [Qemu-devel] [PATCH 4/8] sdcard: Set Spec v2.00 as default

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > include/hw/sd/sd.h | 1 + > hw/sd/sd.c | 13 + > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 3/8] sdcard: Add a 'spec_version' property

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > include/hw/sd/sd.h | 4 > hw/sd/sd.c | 11 +++ > 2 files changed, 15 insertions(+) > > diff --git a/include/hw/sd/sd.h

Re: [Qemu-devel] [PATCH 2/8] sdcard: Allow commands valid in SPI mode

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé wrote: > From the "Physical Layer Simplified Specification Version 1.10" > Chapter 7.3 "SPI Mode Transaction Packets" > Table 57: "Commands and arguments" > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Alistair

Re: [Qemu-devel] [PATCH 0/8] sdcard: cleanup the SD_SPEC version

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé wrote: > Hi, > > This series adds a 'spec_version' property to the SD Card device, > to allow to limit some commands to specific spec version range > (some firmwares use this feature to detect which spec version the > card implements). > >

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread John Snow
On 06/04/2018 08:35 AM, Paolo Bonzini wrote: > On 04/06/2018 14:24, Igor Mammedov wrote: >>> Yes it's easy to add -machine pc but there's no documentation >>> that tells you to do so. Add to that shortcuts like -cdrom >>> stop working, hotplug needs extra bridges to work, and one >>> can see

Re: [Qemu-devel] [RFC PATCH] hw/registerfields: Deposit fields "in place"

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 3:26 PM, Philippe Mathieu-Daudé wrote: > On 06/02/2018 05:55 PM, Philippe Mathieu-Daudé wrote: >> These macros are always used to deposit a field in place. >> Update them to take the pointer argument. >> >> As these macros are constructed using compound statements, >> it is

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-04 Thread John Snow
On 06/04/2018 12:21 PM, Peter Maydell wrote: > The codebase has a bit of a mix of > /* multiline comments > * like this > */ > and > /* multiline comments like this > in the GNU Coding Standards style */ > > State a preference for the former. > > Signed-off-by: Peter Maydell > ---

Re: [Qemu-devel] [PATCH v7 0/7] aspeed: add a witherspoon-bmc machine

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 07:40, Cédric Le Goater wrote: > Hello > > This series adds a new Aspeed machine to emulate the BMC of a > Witherspoon system. It also extends the other Aspeed machines with I2C > devices and adds a simple model for the pca9552 LED blinker present on > the Witherspoon board. > >

Re: [Qemu-devel] [PATCH 2/6] ide: push end_transfer_func out of start_transfer callback, rename callback

2018-06-04 Thread John Snow
On 06/04/2018 11:48 AM, Paolo Bonzini wrote: > On 02/06/2018 02:24, John Snow wrote: >>> -if (s->bus->dma->ops->start_transfer) { >>> -s->bus->dma->ops->start_transfer(s->bus->dma); >>> +if (!s->bus->dma->ops->pio_transfer) { >>> +s->end_transfer_func =

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Igor Mammedov
On Mon, 4 Jun 2018 17:11:57 +0100 Daniel P. Berrangé wrote: > On Mon, Jun 04, 2018 at 05:40:32PM +0200, Igor Mammedov wrote: > > On Mon, 4 Jun 2018 13:03:44 +0100 > > Daniel P. Berrangé wrote: > > > > > The RUN_STATE_PRECONFIG state is not supposed to be reachable unless the > > >

Re: [Qemu-devel] [PATCH v3b 12/18] target/arm: Implement SVE Integer Compare - Immediate Group

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 44 +++ > target/arm/sve_helper.c| 88 ++ > target/arm/translate-sve.c | 66 >

Re: [Qemu-devel] [PULL 0/2] Vga 20180604 patches

2018-06-04 Thread Peter Maydell
1' into staging (2018-06-01 >> 17:32:30 +0100) >> >> are available in the git repository at: >> >> git://git.kraxel.org/qemu tags/vga-20180604-pull-request >> >> for you to fetch changes up to 6bc2fd57e1fc2d1957d1ff952793c53764130

Re: [Qemu-devel] [PATCH v3b 11/18] target/arm: Implement SVE Integer Compare - Vectors Group

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 115 +++ > target/arm/sve_helper.c| 187 + > target/arm/translate-sve.c | 91 ++ >

Re: [Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

2018-06-04 Thread John Snow
On 06/04/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote: > 20.04.2018 15:12, Vladimir Sementsov-Ogievskiy wrote: >> 19.04.2018 23:57, John Snow wrote: >>> >>> On 03/19/2018 04:07 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- If

[Qemu-devel] [RFC PATCH] target/ppc: extend eieio for POWER9

2018-06-04 Thread Cédric Le Goater
POWER9 introduced a new variant of the eieio instruction using bit 6 as a hint to tell the CPU it is a store-forwarding barrier. The usage of this eieio extension was recently added in Linux 4.17 which activated the "support for a store forwarding barrier at kernel entry/exit". This loosen the

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread Michael S. Tsirkin
On Mon, Jun 04, 2018 at 10:26:24AM -0300, Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 02:01:29PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jun 04, 2018 at 09:54:15AM -0300, Eduardo Habkost wrote: > > > On Mon, Jun 04, 2018 at 04:38:22AM +0300, Michael S. Tsirkin wrote: > > > > On Sun, Jun

Re: [Qemu-devel] [PATCH v3b 10/18] target/arm: Implement SVE Select Vectors Group

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 9 +++ > target/arm/sve_helper.c| 55 ++ > target/arm/translate-sve.c | 2 ++ > target/arm/sve.decode | 6 + > 4

Re: [Qemu-devel] [PATCH v3b 09/18] target/arm: Implement SVE vector splice (predicated)

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 2 ++ > target/arm/sve_helper.c| 37 + > target/arm/translate-sve.c | 13 + > target/arm/sve.decode | 3 +++ > 4

Re: [Qemu-devel] [PATCH v3b 08/18] target/arm: Implement SVE reverse within elements

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 14 + > target/arm/sve_helper.c| 41 +++--- > target/arm/translate-sve.c | 38 +++ >

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 07:48:51PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2018 at 02:01:29PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jun 04, 2018 at 09:54:15AM -0300, Eduardo Habkost wrote: > > > On Mon, Jun 04, 2018 at 04:38:22AM +0300, Michael S. Tsirkin wrote: > > > > On Sun,

Re: [Qemu-devel] [PATCH v3b 07/18] target/arm: Implement SVE copy to vector (predicated)

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 19 +++ > target/arm/sve.decode | 6 ++ > 2 files changed, 25 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v3b 01/18] target/arm: Extend vec_reg_offset to larger sizes

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Rearrange the arithmetic so that we are agnostic about the total size > of the vector and the size of the element. This will allow us to index > up to the 32nd byte and with 16-byte elements. > > Signed-off-by: Richard Henderson > --- >

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread Michael S. Tsirkin
On Mon, Jun 04, 2018 at 02:01:29PM +0100, Daniel P. Berrangé wrote: > On Mon, Jun 04, 2018 at 09:54:15AM -0300, Eduardo Habkost wrote: > > On Mon, Jun 04, 2018 at 04:38:22AM +0300, Michael S. Tsirkin wrote: > > > On Sun, Jun 03, 2018 at 12:27:49PM +0300, Marcel Apfelbaum wrote: > > > > Moving to

Re: [Qemu-devel] [PATCH v3b 06/18] target/arm: Implement SVE conditionally broadcast/extract element

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 2 + > target/arm/sve_helper.c| 11 ++ > target/arm/translate-sve.c | 318 + > target/arm/sve.decode | 20 +++ > 4 files

Re: [Qemu-devel] [PATCH v2 00/13] iommu: support txattrs, support TCG execution, implement TZ MPC

2018-06-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180604152941.20374-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/13] iommu: support txattrs, support TCG execution, implement TZ MPC === TEST SCRIPT BEGIN

[Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-04 Thread Peter Maydell
The codebase has a bit of a mix of /* multiline comments * like this */ and /* multiline comments like this in the GNU Coding Standards style */ State a preference for the former. Signed-off-by: Peter Maydell --- I admit that to some extent I'm imposing my aesthetic preferences here;

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 05:40:32PM +0200, Igor Mammedov wrote: > On Mon, 4 Jun 2018 13:03:44 +0100 > Daniel P. Berrangé wrote: > > > The RUN_STATE_PRECONFIG state is not supposed to be reachable unless the > > --preconfig argument is given to QEMU, but when it was introduced in: > > > >

  1   2   3   4   >