On 04/07/18 06:33, Sebastian Bauer wrote:
Am 2018-07-04 06:50, schrieb Mark Cave-Ayland:
Either to give up the vga cirrus preference or to apply the same as
was done with the spapr machine. I would prefer the first variant but
it would also cause some differences on other machines.
I
On Mon, Jul 02, 2018 at 07:43:06AM +0200, Markus Armbruster wrote:
> More lose ends:
>
> * scripts/qmp/ doesn't support OOB, yet. qmp-shell.py in particular
>
> * test-qmp-cmds neglects to cover the OOB additions to qmp-dispatch.c
Would you mind I put these aside for now?
I'm afraid things
On Tue, Jul 03, 2018 at 12:58:25PM +0300, Roman Kagan wrote:
> > >How is this supposed to work with legacy guests that don't support it?
> > Only PV device will be exposed on legacy guest.
>
> So how is this coordination going to work?
Here's a description:
On Tue, Jul 03, 2018 at 09:04:01AM +0100, Suzuki K Poulose wrote:
> Hi Michael,
>
> On 06/29/2018 06:42 PM, Michael S. Tsirkin wrote:
> > On Fri, Jun 29, 2018 at 12:15:21PM +0100, Suzuki K Poulose wrote:
> > > virtio-mmio with virtio-v1 uses a 32bit PFN for the queue.
> > > If the queue pfn is
Am 2018-07-04 06:50, schrieb Mark Cave-Ayland:
Either to give up the vga cirrus preference or to apply the same as
was done with the spapr machine. I would prefer the first variant but
it would also cause some differences on other machines.
I understand that the decision was taken to add VGA
On Tue, Jul 03, 2018 at 08:17:25AM -0700, Richard Henderson wrote:
> Beginning with John Arbuckle's fdiv test case, clean up some
> of the fp helpers. As with fdiv, fre and fresqrt are missing
> divide-by-zero exceptions.
>
> I've also noticed that load/store were using arithmetic conversions
>
On 03/07/18 20:24, Sebastian Bauer wrote:
Am 2018-07-03 21:00, schrieb Mark Cave-Ayland:
On 03/07/18 06:58, David Gibson wrote:
From: Sebastian Bauer
Drivers for this card exists on PPC-based AmigaOS guests so it is
useful to
allow users to emulate the graphics card for PPC machines.
As
Hi David, I'll reply to you using Peter mail :)
On 07/03/2018 06:13 AM, Peter Maydell wrote:
> On 3 July 2018 at 01:28, David Gibson wrote:
>> On Mon, Jul 02, 2018 at 10:42:07AM +0100, Peter Maydell wrote:
>>> I can have a look, but really I think these should go via the
>>> ppc tree -- the
在 2018/7/2 16:46, Paolo Bonzini 写道:
On 02/07/2018 02:49, xinhua.Cao wrote:
In the tcp_chr_write function, we checked errno,
but errno was not reset before a read or write operation.
Therefore, this check of errno's actions is often
incorrect after EAGAIN has occurred.
We reset errno before
Hi Zoltan,
On 06/26/2018 06:18 PM, BALATON Zoltan wrote:
> Emulate the i2c part of SM501 which is used to access the EDID info
> from a monitor.
>
> The vmstate structure is changed and its version is increased but
> SM501 is only used on SH and PPC sam460ex machines that don't support
>
In the tcp_chr_write function, we checked errno,
but errno was not reset before a read or write operation.
Therefore, this check of errno's actions is often
incorrect after EAGAIN has occurred.
we need check errno together with ret < 0.
Signed-off-by: xinhua.Cao
---
chardev/char-socket.c | 7
The '-trace' and '--trace' spellings are only both supported in qemu
binary, while for qemu-nbd or qemu-img only '--trace' spelling is
supported. So for the consistency of trace option invocation, we
should use double-dash spelling in our documentation.
This's also mentioned in
On Tue, Jul 03, 2018 at 02:45:24PM +0200, Cédric Le Goater wrote:
> On 07/02/2018 05:57 AM, Peter Xu wrote:
> > On Sun, Jul 01, 2018 at 07:19:53PM +0200, Cédric Le Goater wrote:
> >> When a PCI device is unplugged, the PCI memory regions are deleted
> >> before the optional ROM RAMBlock is flagged
在 2018/7/2 23:01, Stefan Hajnoczi 写道:
On Mon, Jul 02, 2018 at 08:49:10AM +0800, xinhua.Cao wrote:
In the tcp_chr_write function, we checked errno,
but errno was not reset before a read or write operation.
Therefore, this check of errno's actions is often
incorrect after EAGAIN has occurred.
On Tue, Jul 03, 2018 at 08:10:43PM +0100, Mark Cave-Ayland wrote:
> Commit 29f9cef39e "ppc: Include vga cirrus card into the compiling process"
> changed the default display adapter for all PPC machines to cirrus.
> Unfortunately
> it missed setting the default display type to stdvga for both Mac
On Tue, Jul 03, 2018 at 05:23:59PM +0200, Cédric Le Goater wrote:
> commit efe2add7cb7f ("spapr/vio: deprecate the "irq" property")
> introduced get/set accessors for the "irq" property to warn of its
> usage, but the warning in the get pollutes the monitor 'info qtree'.
>
> Signed-off-by: Cédric
On Tue, Jul 03, 2018 at 10:20:41AM -0500, Eric Blake wrote:
> On 07/02/2018 11:41 PM, David Gibson wrote:
>
> > That's a good point. At the moment there's really nothing there about
> > testing your patch before submission, which is a bit of an ommission.
> >
> > [1] covers a bunch of ways that
yes， I also think so.
On 2018/7/4 0:27, Paolo Bonzini wrote:
On 03/07/2018 09:20, l00284672 wrote:
}
The scsi inqury request from guest is cancelled by qemu. The qemu bt is
below:
(gdb) bt
#0 scsi_req_cancel_async (req=0x7f86d00055c0, notifier=0x0) at
hw/scsi/scsi-bus.c:1825
#1
** Tags added: arm
** Tags added: linux-user
** Tags added: qemu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1779955
Title:
qemu-arm-static read() doesn't accept mmap address as destination
Hello,
On Wed, Jul 4, 2018, 7:34 AM Philippe Mathieu-Daudé wrote:
> Hi Stafford,
>
> On 07/02/2018 12:10 PM, Stafford Horne wrote:
> > From: Richard Henderson
> >
> > All of the existing code was boilerplate from elsewhere,
> > and would crash the guest upon the first signal.
> >
> >
On Tue, Jul 3, 2018 at 7:52 AM, Cornelia Huck wrote:
> On Tue, 3 Jul 2018 09:28:17 -0500
> Venu Busireddy wrote:
>
>> On 2018-07-03 12:58:25 +0300, Roman Kagan wrote:
>> > On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote:
>> > > On 7/2/2018 9:14 AM, Roman Kagan wrote:
>> > > > Is the
Public bug reported:
When read() function takes an mmap'ed address as output buffer, it
returns EFAULT. The expected behavior is it should just work.
The following code works for qemu-system-arm, but not for qemu-arm-
static.
QEMU version affected: latest release 2.12.0.
Steps to reproduce
Hi Stafford,
On 07/02/2018 12:10 PM, Stafford Horne wrote:
> From: Richard Henderson
>
> All of the existing code was boilerplate from elsewhere,
> and would crash the guest upon the first signal.
>
> Signed-off-by: Richard Henderson
> Signed-off-by: Stafford Horne
>
> ---
> v2:
> Add a
On 7/3/2018 2:58 AM, Roman Kagan wrote:
On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote:
On 7/2/2018 9:14 AM, Roman Kagan wrote:
On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote:
The patch set "Enable virtio_net to act as a standby for a passthru
device" [1] deals
tory at:
>
> git://git.kraxel.org/qemu tags/vga-20180703-pull-request
>
> for you to fetch changes up to 1fcfdc435a3e25ab9037f6f7b8ab4bdf89ba1269:
>
> vga: disable global_vmstate for 3.0+ machine types (2018-07-03 11:19:49
> +0200)
>
> --
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-32-arm...@redhat.com>
---
monitor.c | 100 --
1 file changed, 45 insertions(+), 55 deletions(-)
diff --git a/monitor.c b/monitor.c
index
There's just one use of qobject_from_jsonf() to parse a JSON object
left: timestamp_put(). Switch it to qdict_from_jsonf_nofail().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-29-arm...@redhat.com>
---
qapi/qmp-event.c | 10 +-
1 file
Commit cf869d53172 "qmp: support out-of-band (oob) execution" added a
general mechanism for command-independent arguments just for an
out-of-band flag:
The "control" key is introduced to store this extra flag. "control"
field is used to store arguments that are shared by all the
Change monitor_qmp_dispatch_one() to take its parameters unwrapped,
move monitor_resume() to the one caller that needs it, rename the
function to monitor_qmp_dispatch().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-16-arm...@redhat.com>
---
handle_qmp_command() reports JSON syntax errors right away. This is
wrong when OOB is enabled, because the errors can "jump the queue"
then.
The previous commit fixed the same bug for semantic errors, by
delaying the checking until dispatch. We can't delay the checking, so
delay the reporting.
By using the more specific type, we get fewer downcasts. The
downcasts are safe, but not obviously so, at least not locally.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-24-arm...@redhat.com>
---
include/qapi/qmp/dispatch.h | 4 ++--
monitor.c
Commit cf869d53172 "qmp: support out-of-band (oob) execution"
accidentally made qemu-ga accept and ignore "control". Fix that.
Out-of-band execution in a monitor that doesn't support it now fails
with
{"error": {"class": "GenericError", "desc": "QMP input member 'control' is
unexpected"}}
When OOB is enabled, out-of-band commands are executed right away,
everything else is queued. This lets out-of-band commands "jump the
queue".
However, certain errors are always reported right away, and therefore
can jump the queue even when the erroneous input does not request
out-of-band
qmp_greeting() offers capabilities to the client, and
qmp_qmp_capabilities() accepts or denies capabilities requested by the
client. The two compute the set of available capabilities
independently. Not nice.
Clean this up as follows. Compute available capabilities just once in
Commit cf869d53172 "qmp: support out-of-band (oob) execution" changed
how we check "id":
Note that in the patch I exported qmp_dispatch_check_obj() to be
used to check the request earlier, and at the same time allowed
"id" field to be there since actually we always allow that.
The
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-33-arm...@redhat.com>
---
docs/devel/qapi-code-gen.txt | 61 +++-
1 file changed, 25 insertions(+), 36 deletions(-)
diff --git a/docs/devel/qapi-code-gen.txt
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-28-arm...@redhat.com>
---
qapi/qmp-dispatch.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 761812e924..6f2d466596 100644
--- a/qapi/qmp-dispatch.c
monitor_qmp_respond() takes both a response object and an error
object. If an error object is non-null, the response object must be
null, and the response is built from the error object.
Of the two callers, one always passes a null response object, and one
a null error object. Move building the
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-20-arm...@redhat.com>
---
monitor.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/monitor.c b/monitor.c
index ea5421399a..b3c5dcc685 100644
--- a/monitor.c
monitor_json_emitter() and monitor_json_emitter_raw() are
unnecessarily general: they can send arbitrary JSON values, even
though we only ever use them for QMP, which may send only JSON
objects.
Specialize the argument from QObject * to QDict *, and rename to
qmp_queue_response(),
Commit 71da4667db6 "monitor: separate QMP parser and dispatcher" moved
the handle_qmp_command tracepoint from handle_qmp_command() to
monitor_qmp_dispatch_one(). This delays tracing from enqueue time to
dequeue time. Revert that. Dequeue remains adequately visible via
tracepoint
All callers of qmp_build_error_object() duplicate the code to wrap it
in a response object. Replace it by qmp_error_response() that
captures the duplicated code, including error_free().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
qobject_from_jsonf() aborts on error, unlike qobject_from_jsonv(),
which returns null. Since all remaining users of qobject_from_jsonf()
cope fine with null, change it to return null.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
tests/qmp-test tests an out-of-band command overtaking a slow in-band
command. To do that, it needs:
1. An in-band command that *reliably* takes long enough to be
overtaken.
2. An out-of-band command to do the overtaking.
3. To avoid delays, a way to make the in-band command complete
get_qmp_greeting() returns a QDict * as QObject *. It's caller
converts it right back.
Return QDict * instead. While there, rename to qmp_greeting().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-26-arm...@redhat.com>
---
monitor.c | 13
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-9-arm...@redhat.com>
---
tests/test-qga.c | 20
1 file changed, 20 insertions(+)
diff --git a/tests/test-qga.c b/tests/test-qga.c
index 30c9643257..6b632e3da4 100644
---
Many uses of qobject_from_jsonf() convert JSON objects. Create new
convenience function qdict_from_jsonf_nofail() that includes the
conversion to QDict. The next few commits will put it to use.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
Wrapping global variables in a struct without a use for the wrapper
struct buys us nothing but longer lines. Unwrap them.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-21-arm...@redhat.com>
---
monitor.c | 60
The following changes since commit e8c858944ea61923ca563bb5905bf04624d05f16:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
(2018-07-02 19:07:19 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2018-07-03-v2
Affects documentation and a few error messages.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-2-arm...@redhat.com>
---
docs/devel/qapi-code-gen.txt| 2 +-
docs/interop/qmp-spec.txt | 2 +-
monitor.c
OOB documentation is spread over qmp-spec.txt sections 2.2.1
Capabilities and 2.3 Issuing Commands. The amount of detail is a bit
distracting there. Move the meat of the matter to new section 2.3.1
Out of band execution.
Throw in a few other improvements while there:
* 2.2 Server Greeting:
handle_qmp_command() reports certain errors right away. This is wrong
when OOB is enabled, because the errors can "jump the queue" then, as
the previous commit demonstrates.
To fix, we need to delay errors until dispatch. Do that for semantic
errors, mostly by reverting ill-advised parts of
monitor_qmp_dispatch_one() frees a QMPRequest manually, because it
needs to keep a reference to ->id. Premature optimization. Take an
additional reference so we can use qmp_request_free().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-7-arm...@redhat.com>
---
tests/qmp-test.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index 467b694aa2..c9d01b87ca 100644
--- a/tests/qmp-test.c
+++
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-3-arm...@redhat.com>
---
monitor.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/monitor.c b/monitor.c
index 208d7c7cfd..4f4f309d45 100644
---
Commit cf869d53172 "qmp: support out-of-band (oob) execution" made
"id" mandatory for all commands when the client accepted capability
"oob". This is rather onerous when you play with QMP by hand, and
unnecessarily so: only out-of-band commands need an ID for reliable
matching of response to
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180703085358.13941-11-arm...@redhat.com>
---
tests/test-qga.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/tests/test-qga.c b/tests/test-qga.c
index 564a4594b5..2e9e0f73bb 100644
---
Events are broadcast to all monitors. If another monitor's client has
a command with the same ID in flight, the event will incorrectly claim
that command was dropped. This must be fixed before out-of-band
execution can graduate from "experimental".
Signed-off-by: Markus Armbruster
Reviewed-by:
Now you've made me subscribe again to qemu-devel ;)
On 30/06/18 18:07, Bryce Lanham wrote:
> Oh hi!
>
> Luckily gmail brought this to the top since I don’t pay attention to the
> list. I’m away from my computer at the moment, but I had more than this
> working, including interrupts, Ethernet,
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180703163451.16936-1-laur...@vivier.eu
Subject: [Qemu-devel] [PULL 0/7] Linux user for 3.0 patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log
On 07/03/2018 12:53 PM, John Snow wrote:
>
>
> On 07/02/2018 11:46 PM, Jeff Cody wrote:
>> From: Fam Zheng
>>
>> The implementation is similar to the 'qemu-img convert'. In the
>> beginning of the job, offloaded copy is attempted. If it fails, further
>> I/O will go through the existing
From: Marc-André Lureau
Built-in objects remain unconditional. Explicitly defined objects use
the condition specified in the schema. Implicitly defined objects
inherit their condition from their users. For most of them, there is
exactly one user, so the condition to use is obvious. The
From: Marc-André Lureau
Add #if defined(CONFIG_VNC) in generated code, and adjust the
qmp/hmp code accordingly.
query-qmp-schema no longer reports the command/events etc as
available when disabled at compile.
Commands made conditional:
* query-vnc, query-vnc-servers, change-vnc-password
From: Marc-André Lureau
Accept 'if' key in top-level elements, accepted as string or list of
string type. The following patches will modify the test visitor to
check the value is correctly saved, and generate #if/#endif code (as a
single #if/endif line or a series for a list).
Example of 'if'
From: Marc-André Lureau
The documentation is generated only once, and doesn't know C
pre-conditions. Add 'If:' sections for top-level entities.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-Id: <20180703155648.11933-13-marcandre.lur...@redhat.com>
Signed-off-by:
From: Marc-André Lureau
Modify the test visitor to check correct passing of values.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-Id: <20180703155648.11933-5-marcandre.lur...@redhat.com>
[Accidental change to roms/seabios dropped]
Signed-off-by: Markus Armbruster
From: Marc-André Lureau
Add helpers to wrap generated code with #if/#endif lines.
A later patch wants to use QAPIGen for generating C snippets rather
than full C files with copyright headers etc. Splice in class
QAPIGenCCode between QAPIGen and QAPIGenC.
Add a 'with' statement context manager
From: Marc-André Lureau
This commit adds 'ifcond' conditions to top-level QLit objects.
Future work will add them to object and enum type members, i.e. within
QLit objects.
Extend the QLit generator to_qlit() to accept (@obj, @cond) tuples in
addition to just @obj. The tuple causes the QLit
From: Marc-André Lureau
Wrap generated code with #if/#endif using an 'ifcontext' on
QAPIGenCSnippet objects.
Signed-off-by: Marc-André Lureau
Message-Id: <20180703155648.11933-10-marcandre.lur...@redhat.com>
Reviewed-by: Markus Armbruster
[Line breaks tweaked]
Signed-off-by: Markus Armbruster
The following changes since commit b07cd3e748b3f27a17c27afeee578dc4eedb8dd5:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-3.0-20180703' into
staging (2018-07-03 14:59:27 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2018-07-03
From: Marc-André Lureau
We commonly initialize attributes to None in .init(), then set their
real value in .check(). Accessing the attribute before .check()
yields None. If we're lucky, the code that accesses the attribute
prematurely chokes on None.
It won't for .ifcond, because None is a
From: Marc-André Lureau
Wrap generated code with #if/#endif using an 'ifcontext' on
QAPIGenCSnippet objects.
This makes a conditional event's qapi_event_send_FOO() compile-time
conditional, but its enum QAPIEvent member remains unconditional for
now. A follow up patch "qapi-event: add 'if'
From: Marc-André Lureau
The following patch is going to break list entries with #if/#endif, so
they should have the trailing ',' as suffix.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-Id: <20180703155648.11933-8-marcandre.lur...@redhat.com>
Signed-off-by: Markus
From: Marc-André Lureau
Skip preprocessor lines when adding indentation, since that would
likely result in invalid code.
Signed-off-by: Marc-André Lureau
Reviewed-by: Markus Armbruster
Message-Id: <20180703155648.11933-6-marcandre.lur...@redhat.com>
Signed-off-by: Markus Armbruster
---
From: Chen Hanxiao
If we set mountpoints to qmp_guest_fsfreeze_freeze_list,
we may got nothing to freeze as all mountpoints are
not valid.
So call ga_unset_frozen in this senario.
Also, if we return 0 frozen fs, there is no need to call
guest-fsfreeze-thaw.
Cc: Michael Roth
Signed-off-by:
Types & visitors are coupled and must be handled together to avoid
temporary build regression.
Wrap generated types/visitor code with #if/#endif using the context
helpers. Derived from a patch by Marc-André.
Signed-off-by: Marc-André Lureau
Signed-off-by: Markus Armbruster
Message-Id:
On 07/03/2018 01:38 PM, Laurent Vivier wrote:
> Le 03/07/2018 à 17:39, Philippe Mathieu-Daudé a écrit :
>> On 07/03/2018 11:55 AM, Laurent Vivier wrote:
>>> Le 02/07/2018 à 19:50, Philippe Mathieu-Daudé a écrit :
Signed-off-by: Philippe Mathieu-Daudé
Tested-By: Guido Günther
From: Marc-André Lureau
Add #if defined(CONFIG_SPICE) in generated code, and adjust the
qmp/hmp code accordingly.
query-qmp-schema no longer reports the command/events etc as
available when disabled at compile time.
Commands made conditional:
* query-spice
Before the patch, the command for
From: Bishara AbuHattoum
Issue: When upgrading qemu-ga using the msi from an old version
to a newer one, the upgrade is not allowed by the msi
showing this error message "Another version of this product
is already installed."
BZ# 1536331:
From: Daniel Henrique Barboza
bios_support_mode verifies if the guest has support for a certain
suspend mode but it doesn't inform back which suspend tool
provides it. The caller, guest_suspend, executes all suspend
strategies in order again.
After adding systemd suspend support,
From: Daniel Henrique Barboza
Following the same logic of the previous patch, let's also
decouple the suspend logic from guest_suspend into specialized
functions, one for each strategy we support at this moment.
Signed-off-by: Daniel Henrique Barboza
Signed-off-by: Michael Roth
---
From: Daniel Henrique Barboza
This is a cleanup of the resulting code after detaching
pmutils and Linux sys state file logic:
- remove the SUSPEND_MODE_* macros and use an enumeration
instead. At the same time, drop the switch statements
at the start of each function and use the enumeration
From: Daniel Henrique Barboza
To be able to add new suspend mechanisms we need to detach
the existing QMP functions from the current implementation
specifics.
At this moment we have functions such as qmp_guest_suspend_ram
calling bios_suspend_mode and guest_suspend passing the
pmutils command
From: Tomáš Golembiovský
These commands did not get their tests in the original commits:
- guest-get-host-name
- guest-get-timezone
- guest-get-users
Trivial tests that mostly only call the commands were added.
Signed-off-by: Tomáš Golembiovský
Reviewed-by: Marc-André Lureau
* replace
From: Chen Hanxiao
This patch adds support for getting the usage of mounted
filesystem.
The usage of fs stored as used_bytes and total_bytes.
It's very useful when we try to monitor guest's filesystem.
Cc: Michael Roth
Cc: Daniel P. Berrangé
Reviewed-by: Eric Blake
Signed-off-by: Chen
From: Daniel Henrique Barboza
In bios_supports_mode there is a verification to assert if
the chosen suspend mode is supported by the pmutils tools and,
if not, we see if the Linux sys state files supports it.
This verification is done in the same function, one after
the other, and it works for
From: Daniel Henrique Barboza
pmutils isn't being supported by newer OSes like Fedora 27
or Mint. This means that the only suspend option QGA offers
for these guests are writing directly into the Linux sys state
file. This also means that QGA also loses the ability to do
hybrid suspend in those
From: Prasad J Pandit
While reading file content via 'guest-file-read' command,
'qmp_guest_file_read' routine allocates buffer of count+1
bytes. It could overflow for large values of 'count'.
Add check to avoid it.
Reported-by: Fakhri Zulkifli
Signed-off-by: Prasad J Pandit
Cc:
-for-3.0-20180703' into
staging (2018-07-03 14:59:27 +0100)
are available in the git repository at:
git://github.com/mdroth/qemu.git tags/qga-pull-2018-07-03-tag
for you to fetch changes up to 73e1d8eb9b738cef3dee2da26bb669b1092a4c12:
qga: removing bios_supports_mode (2018-07-03 15:20:51 -0500
From: Marc-André Lureau
Iterate over the PCI bridges to lookup the PCI device associated with
the block device.
This allows to lookup the driver under the following syspath:
/sys/devices/pci:00/:00:02.2/:03:00.0/virtio2/block/vda/vda3
It also works with an "old-style" Q35 libvirt
From: Tomáš Golembiovský
The documentation for kernel-version and kernel-release on Windows was
swapped.
Signed-off-by: Tomáš Golembiovský
Reviewed-by: Marc-André Lureau
Signed-off-by: Michael Roth
---
qga/qapi-schema.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
From: Chen Hanxiao
This patch adds support for getting the usage of
windows driver path.
The usage of fs stored as used_bytes and total_bytes.
Cc: Michael Roth
Signed-off-by: Chen Hanxiao
Signed-off-by: Michael Roth
---
qga/commands-win32.c | 12
1 file changed, 12
On 3 July 2018 at 19:49, Guenter Roeck wrote:
> Oddly enough, I now seem to be unable to reproduce the problem either.
> Weird, when I wrote the patch it was absolutely necessary.
>
> The only other change I can think of would be the code to set the
> serial baud rate in the boot loader, which I
On Tue, Jul 03, 2018 at 03:19:04PM -0400, ryang wrote:
> The current paths for modules are CONFIG_QEMU_MODDIR and paths relative
> to the executable. Qemu and its modules can be installed and executed in
> paths that are different from these search paths. This change allows
> a search path to be
tory at:
>
> git://git.kraxel.org/qemu tags/ui-20180703-pull-request
>
> for you to fetch changes up to 4939a1df7d60b4a24458544557ae262852e28567:
>
> ui: do not build-depend or link with libdrm, it is not needed (2018-07-03
> 10:30:25 +0200)
>
>
Paolo Bonzini writes:
> On 03/07/2018 12:14, Alex Bennée wrote:
>> The following changes since commit 46d0885adff9b99622d72f23a8b04c298a8bf91d:
>>
>> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
>> (2018-07-03 09:49:20 +0100)
>>
>> are available in the Git
Paolo Bonzini writes:
> On 03/07/2018 12:14, Alex Bennée wrote:
>> The recent change from TARGET_DIRS to TARGET_LIST (208ecb3e1) had the
>> effect of defaulting all docker builds to the current configured set
>> of targets. This is actually reasonable behaviour but does run into
>> problems if
Hi David,
On 07/03/2018 08:44 PM, David Hildenbrand wrote:
> On 03.07.2018 09:19, Eric Auger wrote:
>> From: Shameer Kolothum
>>
>> This patch adds the the memory hot-plug/hot-unplug infrastructure
>> in machvirt.
>>
>> Signed-off-by: Eric Auger
>> Signed-off-by: Shameer Kolothum
>>
Hi David,
On 07/03/2018 08:41 PM, David Hildenbrand wrote:
> On 03.07.2018 09:19, Eric Auger wrote:
>> When migrating a VM, we must make sure the destination host
>> supports as many IPA bits as the source. Otherwise the migration
>> must fail.
>>
>> We add a VMState infrastructure to machvirt. On
Hi David,
On 07/03/2018 08:28 PM, David Hildenbrand wrote:
> On 03.07.2018 09:19, Eric Auger wrote:
>> From: Shameer Kolothum
>>
>> This patch adds the the memory hot-plug/hot-unplug infrastructure
>> in machvirt.
>>
>> Signed-off-by: Eric Auger
>> Signed-off-by: Shameer Kolothum
>>
1 - 100 of 516 matches
Mail list logo
