[Qemu-devel] [Bug 1452904] Re: High CPU in idle Windows guest

2018-07-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1452904 Title: High CPU

[Qemu-devel] [Bug 1405385] Re: QEMU crashes when virtio network cards are used together with e1000 network cards

2018-07-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1405385 Title: QEMU

[Qemu-devel] [Bug 1453025] Re: remote usb3.0 redir failed, when guest os has more than one vcpus

2018-07-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1453025 Title: remote

Re: [Qemu-devel] [PATCH for-3.0 0/3] Sanitize linux-user stdout

2018-07-06 Thread Richard Henderson
On 07/06/2018 08:51 AM, Philippe Mathieu-Daudé wrote: > Philippe Mathieu-Daudé (3): > linux-user: Do not report "Unsupported syscall" by default > linux-user: Do not report "syscall not implemented" by default > linux-user: Report error message on stderr, rather than stdout Reviewed-by:

Re: [Qemu-devel] [PATCH for-3.0] ppc: fix default VGA display for PReP machines

2018-07-06 Thread David Gibson
On Fri, Jul 06, 2018 at 08:51:55AM +0100, Mark Cave-Ayland wrote: > Commit 29f9cef "ppc: Include vga cirrus card into the compiling process" > changed the default display adapter for all PPC machines to cirrus. > Unfortunately > it missed setting the default display type to stdvga for both PReP

Re: [Qemu-devel] [PATCH] translate-all: honour CF_NOCACHE in tb_gen_code

2018-07-06 Thread Alistair Francis
On Fri, Jul 6, 2018 at 6:05 AM, Peter Maydell wrote: > On 5 July 2018 at 17:07, Emilio G. Cota wrote: >> This fixes a record-replay regression introduced by 95590e2 >> ("translate-all: discard TB when tb_link_page returns an existing >> matching TB", 2018-06-15). The problem is that code using

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-06 Thread Siwei Liu
On Fri, Jul 6, 2018 at 6:54 AM, Cornelia Huck wrote: > On Thu, 5 Jul 2018 17:49:10 -0700 > Siwei Liu wrote: > >> On Wed, Jul 4, 2018 at 5:15 AM, Cornelia Huck wrote: >> > On Tue, 3 Jul 2018 16:31:03 -0700 >> > Siwei Liu wrote: >> > >> >> On Tue, Jul 3, 2018 at 7:52 AM, Cornelia Huck wrote: >>

Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc

2018-07-06 Thread Stafford Horne
On Fri, Jul 06, 2018 at 05:22:15PM -0500, Eric Blake wrote: > On 07/04/2018 03:54 PM, Richard Henderson wrote: > > On 07/03/2018 04:51 PM, Stafford Horne wrote: > > > Richard, how do you usually remove these before your pr?  I suppose you > > > have > > > some kind of script? > > > > No, I just

[Qemu-devel] [Bug 1776920] Re: qemu-img convert on Mac OSX creates corrupt images

2018-07-06 Thread Waldemar Kozaczuk
Bingo! Adding '-S 0' makes convert work. But it is not perfect as the end result is fully allocated image. So with qcow2 like this: image: mysql-example.qemu file format: qcow2 virtual size: 10G (10737418240 bytes) disk size: 50M cluster_size: 65536 Format specific information: compat: 1.1

Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc

2018-07-06 Thread Eric Blake
On 07/04/2018 03:54 PM, Richard Henderson wrote: On 07/03/2018 04:51 PM, Stafford Horne wrote: Richard, how do you usually remove these before your pr?  I suppose you have some kind of script? No, I just edit the things by hand. I do it by always using 'git am' to suck in patches from the

Re: [Qemu-devel] [RFC 15/15] s390-bios: Use sense ccw to ensure consistent device state at boot time

2018-07-06 Thread Halil Pasic
On 07/05/2018 07:25 PM, Jason J. Herne wrote: If a vfio-ccw device is left in an error state (example: pending unit check) then it is possible for that state to persist for a vfio-ccw device even after the enable subchannel that we do to bring the device online. If this state is allowed to

Re: [Qemu-devel] [PATCH v2 9/9] block: Use common write req handling in truncate

2018-07-06 Thread Eric Blake
On 07/05/2018 02:37 AM, Fam Zheng wrote: Truncation is the last to convert from open coded req handling to reusing helpers. This time the permission check in prepare has to adapt to the new caller: it checks a different permission bit, and don't did you mean "won't" or "doesn't"? trigger the

Re: [Qemu-devel] [PATCH v2 8/9] block: Fix bdrv_co_truncate overlap check

2018-07-06 Thread Eric Blake
On 07/05/2018 02:37 AM, Fam Zheng wrote: If we are growing the image and potentially using preallocation for the new area, we need to make sure that no write requests are made to the "preallocated" area which [@old_size, @offset), not [@offset, offset * 2 s/which/which is/ - @old_size).

Re: [Qemu-devel] [PATCH v4 0/4] fix image fleecing

2018-07-06 Thread Eric Blake
On 07/06/2018 01:30 PM, Vladimir Sementsov-Ogievskiy wrote: Hi all. This fixes image fleecing scheme for 3.0, details are in 04 patch. 01 is a significant fix too. v4: 01: fix copy_range architecture here too 02: rebase on 01 03: rebase Hmm - I commented on v3 before seeing you'd already

Re: [Qemu-devel] [PATCH v3 3/4] block: add BDRV_REQ_SERIALISING flag

2018-07-06 Thread Eric Blake
On 07/05/2018 02:46 AM, Vladimir Sementsov-Ogievskiy wrote: Serialized writes should be used in copy-on-write of backup(sync=none) for image fleecing scheme. We need to change an assert in bdrv_aligned_pwritev, added in 28de2dcd88de. The assert may fail now, because call to

Re: [Qemu-devel] [PATCH v3 1/4] block: disallow BDRV_REQ_NO_SERIALISING for write

2018-07-06 Thread Eric Blake
On 07/06/2018 04:32 PM, Eric Blake wrote: On 07/05/2018 02:46 AM, Vladimir Sementsov-Ogievskiy wrote: Before commit 9ded4a01149 "backup: Use copy offloading", BDRV_REQ_NO_SERIALISING was used for only one case: read in copy-on-write operation during backup. Also, the flag was handled only on

Re: [Qemu-devel] [PATCH v3 1/4] block: disallow BDRV_REQ_NO_SERIALISING for write

2018-07-06 Thread Eric Blake
On 07/05/2018 02:46 AM, Vladimir Sementsov-Ogievskiy wrote: Before commit 9ded4a01149 "backup: Use copy offloading", BDRV_REQ_NO_SERIALISING was used for only one case: read in copy-on-write operation during backup. Also, the flag was handled only on read path (in bdrv_co_preadv and

Re: [Qemu-devel] [PATCH] block: Fix copy-on-read crash with partial final cluster

2018-07-06 Thread Eric Blake
On 07/06/2018 11:45 AM, Kevin Wolf wrote: If the virtual disk size isn't aligned to full clusters, bdrv_co_do_copy_on_readv() may get pnum == 0 before having the full cluster completed, which will let it run into an assertion failure: qemu-io: block/io.c:1203: bdrv_co_do_copy_on_readv:

Re: [Qemu-devel] [PATCH 2/2] qapi: add transaction support for x-block-dirty-bitmap-merge

2018-07-06 Thread Eric Blake
On 07/06/2018 10:38 AM, John Snow wrote: I think the "discard stashed state, making undo impossible" interpretation is good because .commit() is not allowed to fail. That function should only do things that never fail. I think this is probably the correct way to proceed, and we ought to

Re: [Qemu-devel] [PATCH] qapi/block-core.json: Add missing documentation for blklogwrites log-append option

2018-07-06 Thread Eric Blake
On 07/06/2018 07:21 AM, Ari Sundholm wrote: This was accidentally omitted. Thanks to Eric Blake for spotting this. Signed-off-by: Ari Sundholm --- qapi/block-core.json | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Eric Blake diff --git a/qapi/block-core.json

[Qemu-devel] [PATCH v4 1/4] block/io: fix copy_range

2018-07-06 Thread Vladimir Sementsov-Ogievskiy
Here two things are fixed: 1. Architecture On each recursion step, we go to the child of src or dst, only for one of them. So, it's wrong to create tracked requests for both on each step. It leads to tracked requests duplication. 2. Wait for serializing requests on write path independently of

[Qemu-devel] [PATCH v4 0/4] fix image fleecing

2018-07-06 Thread Vladimir Sementsov-Ogievskiy
Hi all. This fixes image fleecing scheme for 3.0, details are in 04 patch. 01 is a significant fix too. v4: 01: fix copy_range architecture here too 02: rebase on 01 03: rebase v3: 02: fix typo in assert, to fix build v2: 01,02: new patches 03: - improve comment - fix assert in

[Qemu-devel] [PATCH v4 4/4] block/backup: fix fleecing scheme: use serialized writes

2018-07-06 Thread Vladimir Sementsov-Ogievskiy
Fleecing scheme works as follows: we want a kind of temporary snapshot of active drive A. We create temporary image B, with B->backing = A. Then we start backup(sync=none) from A to B. From this point, B reads as point-in-time snapshot of A (A continues to be active drive, accepting guest IO).

[Qemu-devel] [PATCH v4 3/4] block: add BDRV_REQ_SERIALISING flag

2018-07-06 Thread Vladimir Sementsov-Ogievskiy
Serialized writes should be used in copy-on-write of backup(sync=none) for image fleecing scheme. We need to change an assert in bdrv_aligned_pwritev, added in 28de2dcd88de. The assert may fail now, because call to wait_serialising_requests here may become first call to it for this request with

[Qemu-devel] [PATCH v4 2/4] block: split flags in copy_range

2018-07-06 Thread Vladimir Sementsov-Ogievskiy
Pass read flags and write flags separately. This is needed to handle coming BDRV_REQ_NO_SERIALISING clearly in following patches. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 3 ++- include/block/block_int.h | 14 ++

[Qemu-devel] [Bug 1771948] Re: aarch64 msr CNTFRQ_EL0

2018-07-06 Thread Peter Maydell
Looking more closely at this, I think this is because you've passed QEMU a file which it is treating as a Linux kernel. (-kernel treats raw binaries and uimage files as Linux kernels; it treats ELF files as not being Linux kernels). Linux expects to be started in EL2, so although the emulated CPU

Re: [Qemu-devel] [PULL 0/8] Bug fixes for 2018-07-06

2018-07-06 Thread Peter Maydell
On 6 July 2018 at 18:14, Paolo Bonzini wrote: > The following changes since commit 2a018f6e98782a4931b936a3087404ed81685bac: > > Merge remote-tracking branch > 'remotes/berrange/tags/qcrypto-next-pull-request' into staging (2018-07-03 > 23:06:18 +0100) > > are available in the git repository

[Qemu-devel] [Bug 1777672] Re: QEMU aarch64 virtual/physical frame buffer

2018-07-06 Thread Peter Maydell
Can you provide a test binary and QEMU command line that reproduce this, please ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1777672 Title: QEMU aarch64 virtual/physical frame buffer Status in

[Qemu-devel] [PATCH for-3.0] hw/net/dp8393x: don't make prom region 'nomigrate'

2018-07-06 Thread Peter Maydell
Currently we use memory_region_init_rom_nomigrate() to create the "dp3893x-prom" memory region, and we don't manually register it with vmstate_register_ram(). This currently means that its contents are migrated but as a ram block whose name is the empty string; in future it may mean they are not

Re: [Qemu-devel] [PATCH] vfio/pci: do not set the PCIDevice 'has_rom' attribute

2018-07-06 Thread Michael S. Tsirkin
On Fri, Jul 06, 2018 at 06:36:14PM +0200, Cédric Le Goater wrote: > PCI devices needing a ROM allocate an optional MemoryRegion with > pci_add_option_rom(). pci_del_option_rom() does the cleanup when the > device is destroyed. The only action taken by this routine is to call >

[Qemu-devel] [PULL 6/8] pr-manager-helper: fix memory leak on event

2018-07-06 Thread Paolo Bonzini
Reported by Coverity. Signed-off-by: Paolo Bonzini --- scsi/pr-manager-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c index 519a296..3027dde 100644 --- a/scsi/pr-manager-helper.c +++ b/scsi/pr-manager-helper.c @@ -46,6 +46,7 @@

[Qemu-devel] [PULL 3/8] qtest: Use cpu address space instead of system memory

2018-07-06 Thread Paolo Bonzini
From: Julia Suvorova Some devices (like nvic in armv7m) are not accessable through address_space_memory, therefore can not be tested with qtest. Signed-off-by: Julia Suvorova Message-Id: <20180702065237.27899-1-jus...@mail.ru> Signed-off-by: Paolo Bonzini --- qtest.c | 39

Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()

2018-07-06 Thread Michael S. Tsirkin
On Fri, Jul 06, 2018 at 07:06:36PM +0200, Paolo Bonzini wrote: > On 06/07/2018 18:25, Michael S. Tsirkin wrote: > > On Fri, Jul 06, 2018 at 05:55:23PM +0200, Paolo Bonzini wrote: > >> On 06/07/2018 03:51, Peter Xu wrote: > >>> > >>> A question about memory region auto destruction (which might not

[Qemu-devel] [PULL 2/8] pr-helper: Rework socket path handling

2018-07-06 Thread Paolo Bonzini
From: Michal Privoznik When reviewing Paolo's pr-helper patches I've noticed couple of problems: 1) socket_path needs to be calculated at two different places (one for printing out help, the other if socket activation is NOT used), 2) even though the default socket_path is allocated in

[Qemu-devel] [PULL 7/8] ioapic: remove useless lower bounds check

2018-07-06 Thread Paolo Bonzini
The vector cannot be negative. Coverity now reports this because it sees an array access before the check, in ioapic_stat_update_irq. Reviewed-by: Peter Xu Signed-off-by: Paolo Bonzini --- hw/intc/ioapic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/ioapic.c

[Qemu-devel] [PULL 8/8] checkpatch: handle token pasting better

2018-07-06 Thread Paolo Bonzini
The mechanism to find possible type tokens can sometimes be confused and go into an infinite loop. This happens for example in QEMU for a line that looks like uint## BITS ##_t S = _S, T = _T;\ uint## BITS ##_t as, at, xs, xt, xd;

Re: [Qemu-devel] [PATCH] vfio/pci: do not set the PCIDevice 'has_rom' attribute

2018-07-06 Thread Alex Williamson
On Fri, 6 Jul 2018 18:36:14 +0200 Cédric Le Goater wrote: > PCI devices needing a ROM allocate an optional MemoryRegion with > pci_add_option_rom(). pci_del_option_rom() does the cleanup when the > device is destroyed. The only action taken by this routine is to call > vmstate_unregister_ram()

[Qemu-devel] [PULL 4/8] i386: fix '-cpu ?' output for host cpu type

2018-07-06 Thread Paolo Bonzini
From: Greg Kurz Since commit d6dcc5583e7, '-cpu ?' shows the description of the X86_CPU_TYPE_NAME("max") for the host CPU model: Enables all features supported by the accelerator in the current host instead of the expected: KVM processor with all supported host features or HVF processor

[Qemu-devel] [PULL 1/8] pr-helper: avoid error on PR IN command with zero request size

2018-07-06 Thread Paolo Bonzini
After reading a PR IN command with zero request size in prh_read_request, the resp->result field will be uninitialized and the resp.sz field will be also uninitialized when returning to prh_co_entry. If resp->result == GOOD (from a previous successful reply or just luck), then the assert in

[Qemu-devel] [PULL 0/8] Bug fixes for 2018-07-06

2018-07-06 Thread Paolo Bonzini
The following changes since commit 2a018f6e98782a4931b936a3087404ed81685bac: Merge remote-tracking branch 'remotes/berrange/tags/qcrypto-next-pull-request' into staging (2018-07-03 23:06:18 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

[Qemu-devel] [PULL 5/8] qemu-char: check errno together with ret < 0

2018-07-06 Thread Paolo Bonzini
From: "xinhua.Cao" In the tcp_chr_write function, we checked errno, but errno was not reset before a read or write operation. Therefore, this check of errno's actions is often incorrect after EAGAIN has occurred. we need check errno together with ret < 0. Signed-off-by: xinhua.Cao Message-Id:

Re: [Qemu-devel] [PATCH v4 2/8] target/mips: Workaround for checkpatch.pl hanging on msa_helper.c

2018-07-06 Thread Aleksandar Markovic
> I'm not sure it's worth having this but you are the maintainer so your > choice :) If someone in future peruses an older version of this file (let's say, while working on an older version of QEMU), and comes across this problem with checkpatch.pl, by checking the full history of the file,

Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()

2018-07-06 Thread Paolo Bonzini
On 06/07/2018 18:25, Michael S. Tsirkin wrote: > On Fri, Jul 06, 2018 at 05:55:23PM +0200, Paolo Bonzini wrote: >> On 06/07/2018 03:51, Peter Xu wrote: >>> >>> A question about memory region auto destruction (which might not >>> related to this patch): I see that we have

Re: [Qemu-devel] [PATCH v4 5/8] target/mips: Add CP0 BadInstrX register

2018-07-06 Thread Philippe Mathieu-Daudé
On 07/06/2018 08:48 AM, Aleksandar Markovic wrote: > From: Stefan Markovic > > Add CP0 BadInstrX register. This register will be used in nanoMIPS. > > Signed-off-by: Stefan Markovic > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic > Reviewed-by: Aleksandar Markovic >

Re: [Qemu-devel] [PATCH v4 2/8] target/mips: Workaround for checkpatch.pl hanging on msa_helper.c

2018-07-06 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 07/06/2018 12:38 PM, Aleksandar Markovic wrote: > Hi, Paolo, > > It was an incredibly fast fix! :) > > I already confirmed that the fix fixes the problem on msa_helper.c. I would > nevertheless like to have this workaround applied. Can you perhaps give it > "Reviewed-by"? >

[Qemu-devel] [PATCH] block: Fix copy-on-read crash with partial final cluster

2018-07-06 Thread Kevin Wolf
If the virtual disk size isn't aligned to full clusters, bdrv_co_do_copy_on_readv() may get pnum == 0 before having the full cluster completed, which will let it run into an assertion failure: qemu-io: block/io.c:1203: bdrv_co_do_copy_on_readv: Assertion `skip_bytes < pnum' failed. Check for

Re: [Qemu-devel] [PATCH v4 1/3] spapr: introduce a fixed IRQ number space

2018-07-06 Thread Cédric Le Goater
On 07/06/2018 04:16 PM, Greg Kurz wrote: > On Fri, 6 Jul 2018 15:27:17 +0200 > Cédric Le Goater wrote: > >> > +/* >>> + * The register property of a VIO device is defined in livirt using a >>> + * base number + 0x1000 increment and in QEMU by incrementing the base >>> + * register number

Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()

2018-07-06 Thread Cédric Le Goater
On 07/06/2018 06:25 PM, Michael S. Tsirkin wrote: > On Fri, Jul 06, 2018 at 05:55:23PM +0200, Paolo Bonzini wrote: >> On 06/07/2018 03:51, Peter Xu wrote: >>> >>> A question about memory region auto destruction (which might not >>> related to this patch): I see that we have

Re: [Qemu-devel] [PATCH v3 15/20] kvm: arm/arm64: Allow tuning the physical address size for VM

2018-07-06 Thread Suzuki K Poulose
On 07/06/2018 04:09 PM, Marc Zyngier wrote: On 06/07/18 14:49, Suzuki K Poulose wrote: On 04/07/18 23:03, Suzuki K Poulose wrote: On 07/04/2018 04:51 PM, Will Deacon wrote: Hi Suzuki, On Fri, Jun 29, 2018 at 12:15:35PM +0100, Suzuki K Poulose wrote: Allow specifying the physical address

[Qemu-devel] [PATCH] vfio/pci: do not set the PCIDevice 'has_rom' attribute

2018-07-06 Thread Cédric Le Goater
PCI devices needing a ROM allocate an optional MemoryRegion with pci_add_option_rom(). pci_del_option_rom() does the cleanup when the device is destroyed. The only action taken by this routine is to call vmstate_unregister_ram() which clears the id string of the optional ROM RAMBlock and now, also

Re: [Qemu-devel] [PATCH 2/2] qapi: add transaction support for x-block-dirty-bitmap-merge

2018-07-06 Thread Vladimir Sementsov-Ogievskiy
06.07.2018 18:38, John Snow wrote: On 07/06/2018 06:12 AM, Vladimir Sementsov-Ogievskiy wrote: Ok, let's go this way for now, I'll rewrite it. Last requirement looks a bit strange for me in transaction context. We should not assume that action is done before commit. What is main idea of

Re: [Qemu-devel] [PATCH for-3.0 2/3] linux-user: Do not report "syscall not implemented" by default

2018-07-06 Thread Philippe Mathieu-Daudé
On 07/06/2018 01:08 PM, Peter Maydell wrote: > On 6 July 2018 at 16:51, Philippe Mathieu-Daudé wrote: >> This can still be reported using the "-d unimp" command line option. >> >> Code change produced with: >> >> git ls-files linux-user | \ >> xargs sed -i -E 's/fprintf\(stderr,\s?(".*not >>

Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()

2018-07-06 Thread Michael S. Tsirkin
On Fri, Jul 06, 2018 at 05:55:23PM +0200, Paolo Bonzini wrote: > On 06/07/2018 03:51, Peter Xu wrote: > > > > A question about memory region auto destruction (which might not > > related to this patch): I see that we have object_property_add_child() > > in memory_region_do_init() to achieve the

Re: [Qemu-devel] [PATCH v2 1/1] tests/migration: Skip tests for ppc tcg

2018-07-06 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 6 July 2018 at 15:31, Dr. David Alan Gilbert (git) > wrote: > > From: "Dr. David Alan Gilbert" > > > > PPC tcg seems to be failing migration tests quite regularly; > > we believe this is TCG bugs in dirty bit updating; it's > > not clear why

[Qemu-devel] [PATCH for-3.0 1/1] hw/sd/omap_mmc: Split 'pseudo-reset' from 'power-on-reset'

2018-07-06 Thread Philippe Mathieu-Daudé
DeviceClass::reset models a "cold power-on" reset which can also be use to powercycle a device; but there is no "hot reset" (a.k.a. soft-reset) method available. The OMAP MMC Power-Up Control bit is not designed to powercycle a card, but to disable it without powering it off (pseudo-reset):

[Qemu-devel] [PATCH for-3.0 0/1] Fix the Nokia N810 tablet MMC

2018-07-06 Thread Philippe Mathieu-Daudé
Hi Peter, This bug was previously reported here: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg01824.html Diff before/after ecd219f7abb using -append "console=ttyS1 printk.time=0" option to boot http://people.linaro.org/~peter.maydell/n8x0-images.tgz mmci-omap mmci-omap.0: command

Re: [Qemu-devel] [PATCH v2 1/1] tests/migration: Skip tests for ppc tcg

2018-07-06 Thread Peter Maydell
On 6 July 2018 at 15:31, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > PPC tcg seems to be failing migration tests quite regularly; > we believe this is TCG bugs in dirty bit updating; it's > not clear why PPC fails more but lets skip for the moment. > > $

Re: [Qemu-devel] [PATCH for-3.0 3/3] linux-user: Report error message on stderr, rather than stdout

2018-07-06 Thread Peter Maydell
On 6 July 2018 at 16:51, Philippe Mathieu-Daudé wrote: > Code change produced with: > > git ls-files linux-user | \ > xargs sed -i -E 's/(\s+)printf\s*\(("Unhandled.*)\);/\1fprintf(stderr, > \2);/g' > > Signed-off-by: Philippe Mathieu-Daudé > --- > linux-user/alpha/cpu_loop.c | 2 +- >

Re: [Qemu-devel] [PATCH for-3.0 1/3] linux-user: Do not report "Unsupported syscall" by default

2018-07-06 Thread Peter Maydell
On 6 July 2018 at 16:51, Philippe Mathieu-Daudé wrote: > This can still be reported using the "-d unimp" command line option. > > Fixes: https://bugs.launchpad.net/qemu/+bug/1777226 > Reported-by: John Paul Adrian Glaubitz > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé >

Re: [Qemu-devel] [PATCH for-3.0 2/3] linux-user: Do not report "syscall not implemented" by default

2018-07-06 Thread Peter Maydell
On 6 July 2018 at 16:51, Philippe Mathieu-Daudé wrote: > This can still be reported using the "-d unimp" command line option. > > Code change produced with: > > git ls-files linux-user | \ > xargs sed -i -E 's/fprintf\(stderr,\s?(".*not > implemented\\n")\);/qemu_log_mask(LOG_UNIMP, \1);/g'

Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()

2018-07-06 Thread Paolo Bonzini
On 06/07/2018 03:51, Peter Xu wrote: > > A question about memory region auto destruction (which might not > related to this patch): I see that we have object_property_add_child() > in memory_region_do_init() to achieve the auto destruction but only if > the "name" of memory region is specified.

[Qemu-devel] [PATCH for-3.0 3/3] linux-user: Report error message on stderr, rather than stdout

2018-07-06 Thread Philippe Mathieu-Daudé
Code change produced with: git ls-files linux-user | \ xargs sed -i -E 's/(\s+)printf\s*\(("Unhandled.*)\);/\1fprintf(stderr, \2);/g' Signed-off-by: Philippe Mathieu-Daudé --- linux-user/alpha/cpu_loop.c | 2 +- linux-user/cris/cpu_loop.c | 2 +- linux-user/microblaze/cpu_loop.c

[Qemu-devel] [PATCH for-3.0 2/3] linux-user: Do not report "syscall not implemented" by default

2018-07-06 Thread Philippe Mathieu-Daudé
This can still be reported using the "-d unimp" command line option. Code change produced with: git ls-files linux-user | \ xargs sed -i -E 's/fprintf\(stderr,\s?(".*not implemented\\n")\);/qemu_log_mask(LOG_UNIMP, \1);/g' Signed-off-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH for-3.0 1/3] linux-user: Do not report "Unsupported syscall" by default

2018-07-06 Thread Philippe Mathieu-Daudé
This can still be reported using the "-d unimp" command line option. Fixes: https://bugs.launchpad.net/qemu/+bug/1777226 Reported-by: John Paul Adrian Glaubitz Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH for-3.0 0/3] Sanitize linux-user stdout

2018-07-06 Thread Philippe Mathieu-Daudé
Hi Laurent, Here 3 trivial patches, the first one resolves this launchpad issue: https://bugs.launchpad.net/qemu/+bug/1777226, then the following two sanitize a bit further. Regards, Phil. Philippe Mathieu-Daudé (3): linux-user: Do not report "Unsupported syscall" by default linux-user: Do

Re: [Qemu-devel] [PATCH v2 8/8] target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0

2018-07-06 Thread Aleksandar Markovic
> MFHC0 and MTHC0 used to handle EntryLo0 and EntryLo1 registers only, > and placing ELPA flag checks befor switch statement were technically befor -> before this will be fixed in v5

Re: [Qemu-devel] [PATCH v3 8/8] target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0

2018-07-06 Thread Aleksandar Markovic
> From: Yongbok Kim > > MFHC0 and MTHC0 used to handle EntryLo0 and EntryLo1 registers only, > and placing ELPA flag checks befor switch statement were technically > correct. However, after adding handling more registers, these checks > should be moved to act only in cases of handling EntryLo0

Re: [Qemu-devel] [PATCH v4 2/8] target/mips: Workaround for checkpatch.pl hanging on msa_helper.c

2018-07-06 Thread Aleksandar Markovic
Hi, Paolo, It was an incredibly fast fix! :) I already confirmed that the fix fixes the problem on msa_helper.c. I would nevertheless like to have this workaround applied. Can you perhaps give it "Reviewed-by"? Regards, Aleksandar > Subject: [PATCH v4 2/8] target/mips: Workaround for

Re: [Qemu-devel] [PATCH 2/2] qapi: add transaction support for x-block-dirty-bitmap-merge

2018-07-06 Thread John Snow
On 07/06/2018 06:12 AM, Vladimir Sementsov-Ogievskiy wrote: > > Ok, let's go this way for now, I'll rewrite it. > > Last requirement looks a bit strange for me in transaction context. We > should not assume that action is done before commit. > What is main idea of transaction action, do

Re: [Qemu-devel] [PATCH v4 6/8] target/mips: Amend CP0 WatchHi register implementation

2018-07-06 Thread Aleksandar Markovic
> > +++ b/target/mips/op_helper.c > > @@ -893,7 +893,12 @@ target_ulong helper_mfc0_watchlo(CPUMIPSState *env, > > > uint32_t sel) > > > > target_ulong helper_mfc0_watchhi(CPUMIPSState *env, uint32_t sel) > > { > > -return env->CP0_WatchHi[sel]; > > +return (int32_t)

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-06 Thread Peter Maydell
On 6 July 2018 at 15:56, Kevin Wolf wrote: > Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: >> That way, we can still easily remove old cruft (case (a)), but still >> accommodate cases like this (case (c)). The obvious drawback is that >> we'd need someone to curate the deprecation

Re: [Qemu-devel] [PATCH v3 15/20] kvm: arm/arm64: Allow tuning the physical address size for VM

2018-07-06 Thread Marc Zyngier
On 06/07/18 14:49, Suzuki K Poulose wrote: > On 04/07/18 23:03, Suzuki K Poulose wrote: >> On 07/04/2018 04:51 PM, Will Deacon wrote: >>> Hi Suzuki, >>> >>> On Fri, Jun 29, 2018 at 12:15:35PM +0100, Suzuki K Poulose wrote: Allow specifying the physical address size for a new VM via the

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-06 Thread Michael S. Tsirkin
On Fri, Jul 06, 2018 at 03:54:06PM +0200, Cornelia Huck wrote: > On Thu, 5 Jul 2018 17:49:10 -0700 > Siwei Liu wrote: > > > On Wed, Jul 4, 2018 at 5:15 AM, Cornelia Huck wrote: > > > On Tue, 3 Jul 2018 16:31:03 -0700 > > > Siwei Liu wrote: > > > > > >> On Tue, Jul 3, 2018 at 7:52 AM,

Re: [Qemu-devel] [PATCH v3 1/2] nvic: Handle ARMv6-M SCS reserved registers

2018-07-06 Thread Peter Maydell
On 5 July 2018 at 23:21, Julia Suvorova wrote: > Handle SCS reserved registers listed in ARMv6-M ARM D3.6.1. > All reserved registers are RAZ/WI. ARM_FEATURE_M_MAIN is used for the > checks, because these registers are reserved in ARMv8-M Baseline too. > > Signed-off-by: Julia Suvorova > --- >

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-06 Thread Daniel P . Berrangé
On Fri, Jul 06, 2018 at 04:56:46PM +0200, Kevin Wolf wrote: > Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > > On Wed, 4 Jul 2018 17:14:02 +0100 > > Peter Maydell wrote: > > > > > On 4 July 2018 at 14:34, Kevin Wolf wrote: > > > > Essentially, what is important to me isn't getting

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-06 Thread Kevin Wolf
Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > On Wed, 4 Jul 2018 17:14:02 +0100 > Peter Maydell wrote: > > > On 4 July 2018 at 14:34, Kevin Wolf wrote: > > > Essentially, what is important to me isn't getting these options dropped > > > exactly in 3.0, but not setting a bad precedence

Re: [Qemu-devel] [RFC v3 2/2] tests: Add ARMv6-M reserved register test

2018-07-06 Thread Peter Maydell
On 5 July 2018 at 23:21, Julia Suvorova wrote: > Check that reserved SCS registers return 0 at read, > and writes are ignored. > > Based-on: <20180627143815.1829-1-j...@jms.id.au> > Based-on: <20180630091343.14391-1-stefa...@redhat.com> > > Signed-off-by: Julia Suvorova > --- > Test will work if

Re: [Qemu-devel] [PATCH v2 1/1] tests/migration: Skip tests for ppc tcg

2018-07-06 Thread Laurent Vivier
On 06/07/2018 16:31, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > PPC tcg seems to be failing migration tests quite regularly; > we believe this is TCG bugs in dirty bit updating; it's > not clear why PPC fails more but lets skip for the moment. > > $

Re: [Qemu-devel] [RFC 15/15] s390-bios: Use sense ccw to ensure consistent device state at boot time

2018-07-06 Thread Jason J. Herne
On 07/06/2018 06:08 AM, Cornelia Huck wrote: On Thu, 5 Jul 2018 13:25:43 -0400 "Jason J. Herne" wrote: If a vfio-ccw device is left in an error state (example: pending unit check) then it is possible for that state to persist for a vfio-ccw device even after the enable subchannel that we do

Re: [Qemu-devel] [qemu-s390x] [RFC 10/15] s390-bios: Support for running format-0/1 channel programs

2018-07-06 Thread Jason J. Herne
On 07/06/2018 09:33 AM, Halil Pasic wrote: On 07/06/2018 03:15 PM, Cornelia Huck wrote: On Fri, 6 Jul 2018 15:03:49 +0200 Halil Pasic wrote: On 07/06/2018 02:26 PM, Cornelia Huck wrote: On Fri, 6 Jul 2018 13:42:25 +0200 Halil Pasic wrote: On 07/06/2018 10:03 AM, Cornelia Huck wrote: On

Re: [Qemu-devel] [RFC 10/15] s390-bios: Support for running format-0/1 channel programs

2018-07-06 Thread Jason J. Herne
On 07/06/2018 04:03 AM, Cornelia Huck wrote: On Thu, 5 Jul 2018 13:25:38 -0400 "Jason J. Herne" wrote: ... + +senseIdCcw.cmd_code = CCW_CMD_SENSE_ID; +senseIdCcw.cda = ptr2u32(); Are we sure that this is always under 2G? I thought I saw somewhere that Qemu always loads the bios

Re: [Qemu-devel] [PATCH v3 0/4] fix image fleecing

2018-07-06 Thread Vladimir Sementsov-Ogievskiy
06.07.2018 16:41, Vladimir Sementsov-Ogievskiy wrote: 06.07.2018 10:17, Fam Zheng wrote: On Thu, 07/05 10:46, Vladimir Sementsov-Ogievskiy wrote: Hi all. This fixes image fleecing scheme for 3.0, details are in 04 patch. Looks like this breaks 'test-replication':

[Qemu-devel] [PATCH v2 1/1] tests/migration: Skip tests for ppc tcg

2018-07-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" PPC tcg seems to be failing migration tests quite regularly; we believe this is TCG bugs in dirty bit updating; it's not clear why PPC fails more but lets skip for the moment. $ ./tests/migration-test /ppc64/migration/deprecated: OK /ppc64/migration/bad_dest:

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: replace scrollingDeltaY with deltaY

2018-07-06 Thread Peter Maydell
On 6 July 2018 at 15:22, G 3 wrote: > > On Jul 6, 2018, at 5:11 AM, Peter Maydell wrote: > >> On 6 July 2018 at 03:53, John Arbuckle wrote: >>> >>> The NSEvent class method scrollingDeltaY is available >>> for Mac OS 10.7 and newer. Since QEMU supports Mac OS >>> 10.5 and up, we need to be using

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: replace scrollingDeltaY with deltaY

2018-07-06 Thread G 3
On Jul 6, 2018, at 5:11 AM, Peter Maydell wrote: On 6 July 2018 at 03:53, John Arbuckle wrote: The NSEvent class method scrollingDeltaY is available for Mac OS 10.7 and newer. Since QEMU supports Mac OS 10.5 and up, we need to be using a method that is available on these version of Mac OS

Re: [Qemu-devel] [PATCH v4 1/3] spapr: introduce a fixed IRQ number space

2018-07-06 Thread Greg Kurz
On Fri, 6 Jul 2018 15:27:17 +0200 Cédric Le Goater wrote: > > +/* > > + * The register property of a VIO device is defined in livirt using a > > + * base number + 0x1000 increment and in QEMU by incrementing the base > > + * register number 0x7100. > > + * > > + * The formula below tries

Re: [Qemu-devel] [PATCH v2] target/arm: Forbid unprivileged mode for M Baseline

2018-07-06 Thread Peter Maydell
On 5 July 2018 at 23:26, Julia Suvorova wrote: > MSR handling is the only place where CONTROL.nPRIV is modified. > > Signed-off-by: Julia Suvorova > --- > v2: > * Add the check in the CONTROL_NS case > > target/arm/helper.c | 12 > 1 file changed, 8 insertions(+), 4

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 1/3] spapr: introduce a fixed IRQ number space

2018-07-06 Thread Greg Kurz
On Fri, 6 Jul 2018 15:36:24 +0200 Greg Kurz wrote: [...] > Hmm... if you put a VIO net and two VIO vty in the domain XML, libvirt > will generate reg == 0x1000 for the VIO net and reg == 0x30001000 for the > second VIO vty... this will necessarily collide, won't it ? > > With a 256 VIO devices

[Qemu-devel] [Bug 1774677] Re: -icount increases boot time by >10x

2018-07-06 Thread Andreas Gustafsson
A couple of comments... First, the problem is not limited to Linux guests. In fact, I originally ran across it with a NetBSD guest, but then reproduced it with a Linux guest for the bug report, because in my experience, qemu bug reports involving non-Linux guests tend to be ignored. Second, the

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-06 Thread Cornelia Huck
On Thu, 5 Jul 2018 17:49:10 -0700 Siwei Liu wrote: > On Wed, Jul 4, 2018 at 5:15 AM, Cornelia Huck wrote: > > On Tue, 3 Jul 2018 16:31:03 -0700 > > Siwei Liu wrote: > > > >> On Tue, Jul 3, 2018 at 7:52 AM, Cornelia Huck wrote: > >> > From my point of view, there are several concerns: > >>

[Qemu-devel] [Bug 1738771] Re: qemu user does not provide AT_SECURE auxiliary vector entry

2018-07-06 Thread Peter Maydell
A patch to add AT_SECURE went in and was released in QEMU 2.12. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1738771 Title: qemu user does

Re: [Qemu-devel] [PATCH v3 15/20] kvm: arm/arm64: Allow tuning the physical address size for VM

2018-07-06 Thread Suzuki K Poulose
On 04/07/18 23:03, Suzuki K Poulose wrote: On 07/04/2018 04:51 PM, Will Deacon wrote: Hi Suzuki, On Fri, Jun 29, 2018 at 12:15:35PM +0100, Suzuki K Poulose wrote: Allow specifying the physical address size for a new VM via the kvm_type argument for KVM_CREATE_VM ioctl. This allows us to

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled

2018-07-06 Thread Peter Maydell
On 25 June 2018 at 10:56, Hongbo Zhang wrote: > On 25 June 2018 at 17:06, Peter Maydell wrote: >> On 25 June 2018 at 05:06, Hongbo Zhang wrote: >>> Hi Peter, >>> Yes, your considerations reasonable. >>> But in practice of hardware platforms, programmer checks that Arm TF >>> is using SMC for

Re: [Qemu-devel] [PATCH v3 0/4] fix image fleecing

2018-07-06 Thread Vladimir Sementsov-Ogievskiy
06.07.2018 10:17, Fam Zheng wrote: On Thu, 07/05 10:46, Vladimir Sementsov-Ogievskiy wrote: Hi all. This fixes image fleecing scheme for 3.0, details are in 04 patch. Looks like this breaks 'test-replication': http://patchew.org/QEMU/20180705074638.770905-1-vsement...@virtuozzo.com/

[Qemu-devel] [Bug 1751674] Re: qemu-system-arm segmentation fault trying to dump VM memory

2018-07-06 Thread Peter Maydell
** Changed in: qemu Status: New => Confirmed ** Summary changed: - qemu-system-arm segmentation fault trying to dump VM memory + qemu-system-arm segmentation fault using pmemsave on the interrupt controller registers -- You received this bug notification because you are a member of

Re: [Qemu-devel] [PATCH v4 6/8] target/mips: Amend CP0 WatchHi register implementation

2018-07-06 Thread Richard Henderson
On 07/06/2018 04:48 AM, Aleksandar Markovic wrote: > +++ b/target/mips/op_helper.c > @@ -893,7 +893,12 @@ target_ulong helper_mfc0_watchlo(CPUMIPSState *env, > uint32_t sel) > > target_ulong helper_mfc0_watchhi(CPUMIPSState *env, uint32_t sel) > { > -return env->CP0_WatchHi[sel]; > +

Re: [Qemu-devel] [PATCH v4 1/3] spapr: introduce a fixed IRQ number space

2018-07-06 Thread Greg Kurz
On Fri, 6 Jul 2018 11:07:11 +0200 Cédric Le Goater wrote: > This proposal introduces a new IRQ number space layout using static > numbers for all devices, depending on a device index, and a bitmap > allocator for the MSI IRQ numbers which are negotiated by the guest at > runtime. > > As the

[Qemu-devel] [Bug 1756080] Re: QEMU does not provide non-Linux kernels with ATAGS structure on ARM targets

2018-07-06 Thread Peter Maydell
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1756080 Title: QEMU does not provide non-Linux kernels with ATAGS structure on ARM targets Status

[Qemu-devel] [Bug 1766896] Re: qemu-system-arm segfault in arm_v7m_mmu_idx_for_secstate

2018-07-06 Thread Peter Maydell
The patch referred to in comment #4 has now been committed, so from QEMU 3.0 this will fail with a useful error message to tell the user their choice of machine and CPU aren't compatible. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you

Re: [Qemu-devel] [qemu-s390x] [RFC 10/15] s390-bios: Support for running format-0/1 channel programs

2018-07-06 Thread Halil Pasic
On 07/06/2018 03:15 PM, Cornelia Huck wrote: On Fri, 6 Jul 2018 15:03:49 +0200 Halil Pasic wrote: On 07/06/2018 02:26 PM, Cornelia Huck wrote: On Fri, 6 Jul 2018 13:42:25 +0200 Halil Pasic wrote: On 07/06/2018 10:03 AM, Cornelia Huck wrote: On Thu, 5 Jul 2018 13:25:38 -0400 "Jason

  1   2   3   >