[Qemu-devel] [PATCH] fw_cfg_mem: add read memory region callback

2018-09-11 Thread Li Qiang
The write/read should be paired, this can avoid the NULL-deref while the guest reads the fw_cfg port. Signed-off-by: Li Qiang --- hw/nvram/fw_cfg.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index d79a568f54..6de7809f1a 100644 --- a/hw/nvram/f

Re: [Qemu-devel] [PATCH 6/6] x86_iommu/amd: Enable Guest virtual APIC support

2018-09-11 Thread Peter Xu
On Tue, Sep 11, 2018 at 11:49:49AM -0500, Brijesh Singh wrote: > Now that amd-iommu support interrupt remapping, enable the GASup in IVRS > table and GASup in extended feature register to indicate that IOMMU > support guest virtual APIC mode. > > Note that the GAMSup is set to zero to indicate tha

Re: [Qemu-devel] [PATCH 4/6] i386: acpi: add IVHD device entry for IOAPIC

2018-09-11 Thread Peter Xu
On Tue, Sep 11, 2018 at 11:49:47AM -0500, Brijesh Singh wrote: > When interrupt remapping is enabled, add a special IVHD device > (type IOAPIC) -- which is typically PCI device 14:0.0. Linux IOMMU driver > checks for this special device. > > Cc: "Michael S. Tsirkin" > Cc: Paolo Bonzini > Cc: Ric

Re: [Qemu-devel] [PATCH 1/6] x86_iommu: move the kernel-irqchip check in common code

2018-09-11 Thread Peter Xu
On Tue, Sep 11, 2018 at 11:49:44AM -0500, Brijesh Singh wrote: > Interrupt remapping needs kernel-irqchip={off|split} on both Intel and AMD > platforms. Move the check in common place. > > Cc: "Michael S. Tsirkin" > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: Marcel A

Re: [Qemu-devel] [PATCH 2/6] x86_iommu/amd: Prepare for interrupt remap support

2018-09-11 Thread Peter Xu
On Tue, Sep 11, 2018 at 11:49:45AM -0500, Brijesh Singh wrote: > static AddressSpace *amdvi_host_dma_iommu(PCIBus *bus, void *opaque, int > devfn) > { > AMDVIState *s = opaque; > @@ -1055,6 +1151,12 @@ static AddressSpace *amdvi_host_dma_iommu(PCIBus *bus, > void *opaque, int devfn) >

Re: [Qemu-devel] [PATCH 3/6] x86_iommu/amd: Add interrupt remap support when VAPIC is not enabled

2018-09-11 Thread Peter Xu
On Tue, Sep 11, 2018 at 11:49:46AM -0500, Brijesh Singh wrote: > Emulate the interrupt remapping support when guest virtual APIC is > not enabled. > > See IOMMU spec: https://support.amd.com/TechDocs/48882_IOMMU.pdf > (section 2.2.5.1) for details information. > > When VAPIC is not enabled, it us

Re: [Qemu-devel] [PATCH v4 0/3] x86: QEMU side support on MSR based features

2018-09-11 Thread Robert Hoo
On Sun, 2018-09-02 at 19:46 +0800, Robert Hoo wrote: Ping ... :-) > KVM side has added the framework (kvm.git:d1d93fa90) to support MSR > based features. > Here is the QEMU part, including data structure changes/expanding, > referring > functions changes, and the implementations on  > KVM_GET_MSR_F

Re: [Qemu-devel] [PATCH v2 12/12] qht-bench: add -p flag to precompute hash values

2018-09-11 Thread Emilio G. Cota
On Tue, Sep 11, 2018 at 17:46:41 -0700, Richard Henderson wrote: > On 09/10/2018 11:58 AM, Emilio G. Cota wrote: > > @@ -289,7 +297,9 @@ static void htable_init(void) > > /* avoid allocating memory later by allocating all the keys now */ > > keys = g_malloc(sizeof(*keys) * n); > > fo

Re: [Qemu-devel] [PATCH 2/2] virtio-scsi/virtio-blk: Disable poll handlers when stopping vq handler

2018-09-11 Thread Fam Zheng
On Tue, 09/11 17:30, Paolo Bonzini wrote: > On 11/09/2018 16:12, Fam Zheng wrote: > > On Tue, 09/11 13:32, Paolo Bonzini wrote: > >> On 10/09/2018 16:56, Fam Zheng wrote: > >>> We have this unwanted call stack: > >>> > >>> > ... > >>> > #13 0x5586602b7793 in virtio_scsi_handle_cmd_vq > >>>

[Qemu-devel] What kind of situation to use internal or external snapshot?

2018-09-11 Thread lampahome
as title, I know there're two snapshots in qemu, but I don't know when to use them well. What I know is internal snapshot will save the info of L1 and L2 table in the end of image but external snapshot won't because external snapshot create new file to save cow data. So when to use internal snaps

Re: [Qemu-devel] [PATCH V1 RESEND 6/6] hmat acpi: Implement _HMA method to update HMAT at runtime

2018-09-11 Thread Liu, Jingqi
On Monday, July 16, 2018 8:29 PM, Igor Mammedov wrote: > On Tue, 19 Jun 2018 23:20:57 +0800 > Liu Jingqi wrote: > > > OSPM evaluates HMAT only during system initialization. > > Any changes to the HMAT state at runtime or information regarding HMAT > > for hot plug are communicated using _HMA m

Re: [Qemu-devel] [PATCH v2 12/12] qht-bench: add -p flag to precompute hash values

2018-09-11 Thread Richard Henderson
On 09/10/2018 11:58 AM, Emilio G. Cota wrote: > @@ -289,7 +297,9 @@ static void htable_init(void) > /* avoid allocating memory later by allocating all the keys now */ > keys = g_malloc(sizeof(*keys) * n); > for (i = 0; i < n; i++) { > -keys[i] = populate_offset + i; > +

[Qemu-devel] [PATCH v4 4/4] block/rbd: add deprecation documentation for filename keyvalue pairs

2018-09-11 Thread Jeff Cody
Signed-off-by: Jeff Cody --- qemu-deprecated.texi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 1b9c007f12..8d285b281e 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -190,6 +190,21 @@ used instead. In order

[Qemu-devel] [PATCH v4 1/4] block/rbd: pull out qemu_rbd_convert_options

2018-09-11 Thread Jeff Cody
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd into a helper function. Reviewed-by: Eric Blake Reviewed-by: John Snow Signed-off-by: Jeff Cody --- block/rbd.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/block

[Qemu-devel] [PATCH v4 2/4] block/rbd: Attempt to parse legacy filenames

2018-09-11 Thread Jeff Cody
When we converted rbd to get rid of the older key/value-centric encoding format, we broke compatibility with image files with backing file strings encoded in the old format. This leaves a bit of an ugly conundrum, and a hacky solution. If the initial attempt to parse the "proper" options fails, i

[Qemu-devel] [PATCH v4 0/4] block/rbd: enable filename parsing on open

2018-09-11 Thread Jeff Cody
Changes from v3: Patch 4: Typo fixed [Eric] Added examples [Eric] Changes from v2: = Patch 4: New, document deprecation. [Eric] Patch 3,2: Add r-b's Changes from v1: = Patch 1: Don't pass unused BlockDriverState to helper function Pat

[Qemu-devel] [PATCH v4 3/4] block/rbd: add iotest for rbd legacy keyvalue filename parsing

2018-09-11 Thread Jeff Cody
This is a small test that will check for the ability to parse both legacy and modern options for rbd. The way the test is set up is for failure to occur, but without having to wait to timeout on a non-existent rbd server. The error messages in the success path show that the arguments were parsed.

Re: [Qemu-devel] [PATCH v3 4/4] block/rbd: add deprecation documenation for filename keyvalue pairs

2018-09-11 Thread Jeff Cody
On Tue, Sep 11, 2018 at 04:56:36PM -0500, Eric Blake wrote: > [MAINTAINERS says libvir-list should have been cc'd; not sure why that > didn't happen] > Thanks > On 9/11/18 4:34 PM, Jeff Cody wrote: > >Signed-off-by: Jeff Cody > > In the subject: s/documenation/documentation/ > > >--- > > qem

Re: [Qemu-devel] [PATCH] PC Chipset: Improve serial divisor calculation

2018-09-11 Thread Guenter Roeck
On Tue, Sep 11, 2018 at 03:21:34PM +0200, Paolo Bonzini wrote: > On 01/09/2018 01:37, Guenter Roeck wrote: > > The patch results in an unexpected DLL register value. Here is the > > surrounding code from drivers/tty/serial/pxa.c: > > > > serial_out(up, UART_DLL, quot & 0xff); /* LS of

Re: [Qemu-devel] [PATCH v3 4/4] block/rbd: add deprecation documenation for filename keyvalue pairs

2018-09-11 Thread Eric Blake
[MAINTAINERS says libvir-list should have been cc'd; not sure why that didn't happen] On 9/11/18 4:34 PM, Jeff Cody wrote: Signed-off-by: Jeff Cody In the subject: s/documenation/documentation/ --- qemu-deprecated.texi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-depr

[Qemu-devel] [PATCH v3 2/4] block/rbd: Attempt to parse legacy filenames

2018-09-11 Thread Jeff Cody
When we converted rbd to get rid of the older key/value-centric encoding format, we broke compatibility with image files with backing file strings encoded in the old format. This leaves a bit of an ugly conundrum, and a hacky solution. If the initial attempt to parse the "proper" options fails, i

[Qemu-devel] [PATCH v3 1/4] block/rbd: pull out qemu_rbd_convert_options

2018-09-11 Thread Jeff Cody
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd into a helper function. Reviewed-by: Eric Blake Reviewed-by: John Snow Signed-off-by: Jeff Cody --- block/rbd.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/block

[Qemu-devel] [PATCH v3 0/4] block/rbd: enable filename parsing on open

2018-09-11 Thread Jeff Cody
Changes from v2: = Patch 4: New, document deprecation. [Eric] Patch 3,2: Add r-b's Changes from v1: = Patch 1: Don't pass unused BlockDriverState to helper function Patch 2: Do not allow mixed usage; fail if keyvalue is present [Eric] Add deprecation wa

[Qemu-devel] [PATCH v3 3/4] block/rbd: add iotest for rbd legacy keyvalue filename parsing

2018-09-11 Thread Jeff Cody
This is a small test that will check for the ability to parse both legacy and modern options for rbd. The way the test is set up is for failure to occur, but without having to wait to timeout on a non-existent rbd server. The error messages in the success path show that the arguments were parsed.

[Qemu-devel] [PATCH v3 4/4] block/rbd: add deprecation documenation for filename keyvalue pairs

2018-09-11 Thread Jeff Cody
Signed-off-by: Jeff Cody --- qemu-deprecated.texi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 1b9c007f12..4df8ac442d 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -190,6 +190,13 @@ used instead. In order to preven

[Qemu-devel] [PATCH] Fix breakpoints in nios2 user-mode emulation.

2018-09-11 Thread Sandra Loosemore
Without this patch, QEMU exits immediately when it execution stops at a breakpoint, instead of reporting it to GDB. Signed-off-by: Sandra Loosemore --- linux-user/nios2/cpu_loop.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c ind

Re: [Qemu-devel] [PATCH v2 2/3] block/rbd: Attempt to parse legacy filenames

2018-09-11 Thread Jeff Cody
On Tue, Sep 11, 2018 at 04:05:45PM -0500, Eric Blake wrote: > On 9/11/18 3:43 PM, Jeff Cody wrote: > >When we converted rbd to get rid of the older key/value-centric > >encoding format, we broke compatibility with image files with backing > >file strings encoded in the old format. > > > >This leave

Re: [Qemu-devel] [PATCH v2 3/3] block/rbd: add iotest for rbd legacy keyvalue filename parsing

2018-09-11 Thread Eric Blake
On 9/11/18 3:43 PM, Jeff Cody wrote: This is a small test that will check for the ability to parse both legacy and modern options for rbd. The way the test is set up is for failure to occur, but without having to wait to timeout on a non-existent rbd server. The error messages in the success pa

Re: [Qemu-devel] [PATCH v2 2/3] block/rbd: Attempt to parse legacy filenames

2018-09-11 Thread Eric Blake
On 9/11/18 3:43 PM, Jeff Cody wrote: When we converted rbd to get rid of the older key/value-centric encoding format, we broke compatibility with image files with backing file strings encoded in the old format. This leaves a bit of an ugly conundrum, and a hacky solution. If the initial attempt

Re: [Qemu-devel] [PATCH v3 11/13] target/i386: move cpu_tmp1_i64 to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 160 > 1 file changed, 80 insertions(+), 80 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 12/13] target/i386: move x86_64_hregs to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > And convert it to a bool to use an existing hole > in the struct. > > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 307 > 1 file changed, 154 insertions(+), 153 deletions(-) Reviewed-by:

Re: [Qemu-devel] [PATCH v3 10/13] target/i386: move cpu_tmp3_i32 to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 64 - > 1 file changed, 32 insertions(+), 32 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 09/13] target/i386: move cpu_tmp2_i32 to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 347 > 1 file changed, 174 insertions(+), 173 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 07/13] target/i386: move cpu_ptr0 to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 101 +--- > 1 file changed, 52 insertions(+), 49 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 08/13] target/i386: move cpu_ptr1 to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 52 - > 1 file changed, 26 insertions(+), 26 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 06/13] target/i386: move cpu_tmp4 to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 78 - > 1 file changed, 39 insertions(+), 39 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 05/13] target/i386: move cpu_tmp0 to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 282 > 1 file changed, 144 insertions(+), 138 deletions(-) Reviewed-by: Richard Henderson I will note that these tmpN variables ought to be e

[Qemu-devel] [PATCH v2 0/3] block/rbd: enable filename parsing on open

2018-09-11 Thread Jeff Cody
Changes from v1: Patch 1: Don't pass unused BlockDriverState to helper function Patch 2: Do not allow mixed usage; fail if keyvalue is present [Eric] Add deprecation warning [John] Pull legacy parsing code into function [John] Fixed filename leak Patch 3: New; iotest 2

Re: [Qemu-devel] [PATCH v3 03/13] target/i386: move cpu_T0 to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 1174 --- > 1 file changed, 594 insertions(+), 580 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 02/13] target/i386: move cpu_A0 to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 472 > 1 file changed, 236 insertions(+), 236 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 04/13] target/i386: move cpu_T1 to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 341 > 1 file changed, 170 insertions(+), 171 deletions(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v2 3/3] block/rbd: add iotest for rbd legacy keyvalue filename parsing

2018-09-11 Thread Jeff Cody
This is a small test that will check for the ability to parse both legacy and modern options for rbd. The way the test is set up is for failure to occur, but without having to wait to timeout on a non-existent rbd server. The error messages in the success path show that the arguments were parsed.

[Qemu-devel] [PATCH v2 2/3] block/rbd: Attempt to parse legacy filenames

2018-09-11 Thread Jeff Cody
When we converted rbd to get rid of the older key/value-centric encoding format, we broke compatibility with image files with backing file strings encoded in the old format. This leaves a bit of an ugly conundrum, and a hacky solution. If the initial attempt to parse the "proper" options fails, i

Re: [Qemu-devel] [PATCH v3 01/13] target/i386: move cpu_cc_srcT to DisasContext

2018-09-11 Thread Richard Henderson
On 09/11/2018 01:28 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 32 ++-- > 1 file changed, 18 insertions(+), 14 deletions(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v2 1/3] block/rbd: pull out qemu_rbd_convert_options

2018-09-11 Thread Jeff Cody
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd into a helper function. Reviewed-by: Eric Blake Reviewed-by: John Snow Signed-off-by: Jeff Cody --- block/rbd.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/block

Re: [Qemu-devel] [PATCH v2 02/12] util: add atomic64

2018-09-11 Thread Emilio G. Cota
On Tue, Sep 11, 2018 at 05:43:38 -0700, Richard Henderson wrote: > On 09/10/2018 04:27 PM, Emilio G. Cota wrote: > > +#define GEN_READ(name, type)\ > > +type name(const type *ptr) \ > > +{ \ > > +QemuSpin

[Qemu-devel] [PATCH v3 09/13] target/i386: move cpu_tmp2_i32 to DisasContext

2018-09-11 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 347 1 file changed, 174 insertions(+), 173 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index c51f61ca2c..ec68f7dba1 100644 --- a/target/i386/translate.c +++ b/tar

[Qemu-devel] [PATCH v3 11/13] target/i386: move cpu_tmp1_i64 to DisasContext

2018-09-11 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 160 1 file changed, 80 insertions(+), 80 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index cd880cc2a8..61a98ef872 100644 --- a/target/i386/translate.c +++ b/targe

[Qemu-devel] [PATCH v3 03/13] target/i386: move cpu_T0 to DisasContext

2018-09-11 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 1174 --- 1 file changed, 594 insertions(+), 580 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index c6b1baab9d..73fd7e5b9a 100644 --- a/target/i386/translate.c +++ b/tar

[Qemu-devel] [PATCH v3 12/13] target/i386: move x86_64_hregs to DisasContext

2018-09-11 Thread Emilio G. Cota
And convert it to a bool to use an existing hole in the struct. Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 307 1 file changed, 154 insertions(+), 153 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 61a9

[Qemu-devel] [PATCH v3 05/13] target/i386: move cpu_tmp0 to DisasContext

2018-09-11 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 282 1 file changed, 144 insertions(+), 138 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index bd27e65344..873231fb44 100644 --- a/target/i386/translate.c +++ b/tar

[Qemu-devel] [PATCH v3 02/13] target/i386: move cpu_A0 to DisasContext

2018-09-11 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 472 1 file changed, 236 insertions(+), 236 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index e9f512472e..c6b1baab9d 100644 --- a/target/i386/translate.c +++ b/tar

[Qemu-devel] [PATCH v3 13/13] configure: enable mttcg for i386 and x86_64

2018-09-11 Thread Emilio G. Cota
Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 58862d2ae8..f715252c9f 100755 --- a/configure +++ b/configure @@ -7025,12 +7025,14 @@ TARGET_ABI_DIR="" case "$target_name" in i386)

[Qemu-devel] [PATCH v3 06/13] target/i386: move cpu_tmp4 to DisasContext

2018-09-11 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 78 - 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 873231fb44..0ad6ffc4af 100644 --- a/target/i386/translate.c +++ b/targe

[Qemu-devel] [PATCH v3 08/13] target/i386: move cpu_ptr1 to DisasContext

2018-09-11 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 9531dafebe..c51f61ca2c 100644 --- a/target/i386/translate.c +++ b/targe

[Qemu-devel] [PATCH v3 07/13] target/i386: move cpu_ptr0 to DisasContext

2018-09-11 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 101 +--- 1 file changed, 52 insertions(+), 49 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 0ad6ffc4af..9531dafebe 100644 --- a/target/i386/translate.c +++ b/targe

[Qemu-devel] [PATCH v3 01/13] target/i386: move cpu_cc_srcT to DisasContext

2018-09-11 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 1f9d1d9b24..e9f512472e 100644 --- a/target/i386/translate.c +++ b/target/i386/tr

[Qemu-devel] [PATCH v3 00/13] i386 + x86_64 mttcg

2018-09-11 Thread Emilio G. Cota
v2: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg01122.html Changes since v2: - Add rth's R-b tag to the last patch - Drop v2's first 10 patches, since Paolo already picked those up - Move TCG temps + x86_64_hregs to DisasContext + While at it, drop the cpu_ prefix from the TCG temp

[Qemu-devel] [PATCH v3 10/13] target/i386: move cpu_tmp3_i32 to DisasContext

2018-09-11 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 64 - 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index ec68f7dba1..cd880cc2a8 100644 --- a/target/i386/translate.c +++ b/targe

[Qemu-devel] [PATCH v3 04/13] target/i386: move cpu_T1 to DisasContext

2018-09-11 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 341 1 file changed, 170 insertions(+), 171 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 73fd7e5b9a..bd27e65344 100644 --- a/target/i386/translate.c +++ b/tar

Re: [Qemu-devel] [PATCH v2 4/4] qapi: add transaction support for x-block-dirty-bitmap-merge

2018-09-11 Thread John Snow
On 07/06/2018 07:36 AM, Vladimir Sementsov-Ogievskiy wrote: > New action is like clean action: do the whole thing in .prepare and > undo in .abort. This behavior for bitmap-changing actions is needed > because backup job actions use bitmap in .prepare. > > Signed-off-by: Vladimir Sementsov-Ogie

[Qemu-devel] [Bug 1788665] Re: Low 2D graphics performance with Windows 10 (1803) VGA passthrough VM using "Spectre" protection

2018-09-11 Thread George Amanakis
Hello All, I can reproduce this on two different systems with Ivy-Bridge CPUs: Xeon E5 2667v2 / X9SRA running Fedora 28, with Windows 10 1803 as KVM guest Xeon E3 1270v2 / X9SCM running Archlinux, with Windows 10 1803 as KVM guest The performance degradation doesn't occur when the Windows 10 gues

Re: [Qemu-devel] [Bug 1791796] Re: unimplemented thread syscalls in nios2 user-mode emulation

2018-09-11 Thread Alex Bennée
Sandra Loosemore <1791...@bugs.launchpad.net> writes: > If you need a Nios II GNU/Linux toolchain, I think the most recent > CodeBench Lite release will work: > > https://sourcery.mentor.com/GNUToolchain/subscription42545 Hmm I tried automating that but it seems the installer has GTK dependenci

Re: [Qemu-devel] [PATCH 2/2] block/rbd: Attempt to parse legacy filenames

2018-09-11 Thread John Snow
On 09/11/2018 02:37 PM, Jeff Cody wrote: > On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote: >> >> >> On 09/11/2018 01:15 AM, Jeff Cody wrote: >>> When we converted rbd to get rid of the older key/value-centric >>> encoding format, we broke compatibility with image files with backing >>

Re: [Qemu-devel] [PATCH 2/2] block/rbd: Attempt to parse legacy filenames

2018-09-11 Thread Jeff Cody
On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote: > > > On 09/11/2018 01:15 AM, Jeff Cody wrote: > > When we converted rbd to get rid of the older key/value-centric > > encoding format, we broke compatibility with image files with backing > > file strings encoded in the old format. > >

Re: [Qemu-devel] [PATCH 2/2] block/rbd: Attempt to parse legacy filenames

2018-09-11 Thread Jeff Cody
On Tue, Sep 11, 2018 at 01:03:44PM -0500, Eric Blake wrote: > On 9/11/18 12:15 AM, Jeff Cody wrote: > >When we converted rbd to get rid of the older key/value-centric > >encoding format, we broke compatibility with image files with backing > >file strings encoded in the old format. > > > >This leav

Re: [Qemu-devel] [PATCH 2/2] block/rbd: Attempt to parse legacy filenames

2018-09-11 Thread John Snow
On 09/11/2018 01:15 AM, Jeff Cody wrote: > When we converted rbd to get rid of the older key/value-centric > encoding format, we broke compatibility with image files with backing > file strings encoded in the old format. > > This leaves a bit of an ugly conundrum, and a hacky solution. > > If

Re: [Qemu-devel] [PATCH 2/2] block/rbd: Attempt to parse legacy filenames

2018-09-11 Thread Eric Blake
On 9/11/18 12:15 AM, Jeff Cody wrote: When we converted rbd to get rid of the older key/value-centric encoding format, we broke compatibility with image files with backing file strings encoded in the old format. This leaves a bit of an ugly conundrum, and a hacky solution. If the initial attemp

Re: [Qemu-devel] [PATCH 1/2] block/rbd: pull out qemu_rbd_convert_options

2018-09-11 Thread John Snow
On 09/11/2018 01:15 AM, Jeff Cody wrote: > Code movement to pull the conversion from Qdict to BlockdevOptionsRbd > into a helper function. > > Signed-off-by: Jeff Cody > --- > block/rbd.c | 36 > 1 file changed, 24 insertions(+), 12 deletions(-) > > diff

Re: [Qemu-devel] [PATCH 2/2] block/rbd: Attempt to parse legacy filenames

2018-09-11 Thread Jeff Cody
On Tue, Sep 11, 2018 at 01:15:49AM -0400, Jeff Cody wrote: > When we converted rbd to get rid of the older key/value-centric > encoding format, we broke compatibility with image files with backing > file strings encoded in the old format. > > This leaves a bit of an ugly conundrum, and a hacky sol

Re: [Qemu-devel] [PATCH 1/2] block/rbd: pull out qemu_rbd_convert_options

2018-09-11 Thread Eric Blake
On 9/11/18 12:15 AM, Jeff Cody wrote: Code movement to pull the conversion from Qdict to BlockdevOptionsRbd into a helper function. Signed-off-by: Jeff Cody --- block/rbd.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) - +r = qemu_rbd_co

Re: [Qemu-devel] [Question] Question about ACPI table in qemu

2018-09-11 Thread Paolo Bonzini
On 11/09/2018 18:54, Li Qiang wrote: > Hi all, > > I noticed that both qemu and seabios create the ACPI table. > Once I think he bios' ACPI table will overwrite the qemu's if seabios > compiled with CONFIG_ACPI. Yes, SeaBIOS's ACPI tables are not used anymore, to remove the need to update QEMU an

Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode

2018-09-11 Thread Emilio G. Cota
On Tue, Sep 11, 2018 at 13:24:03 +0200, Paolo Bonzini wrote: > On 10/09/2018 14:30, Emilio G. Cota wrote: > >> I'm confused - as we can have multi-threaded user space don't the same > >> requirements apply? > > In user-mode, code generation is serialized by mmap_lock. > > Making these per-thread wo

Re: [Qemu-devel] [PATCH V2] block: increased maximum size of vvfat devices

2018-09-11 Thread аркадий иванов
Ping? Thu, 23 Aug. 2018 at 16:37, Arkasha : > This fixes the problem of the impossibility to create > FAT16 disks larger than 504 mb: > The change CHS made it possible to obtain a larger disk. > Also, auto-detection of disk parameters was added depending > on the volume of the connected files: >

[Qemu-devel] [PATCH 4/6] i386: acpi: add IVHD device entry for IOAPIC

2018-09-11 Thread Brijesh Singh
When interrupt remapping is enabled, add a special IVHD device (type IOAPIC) -- which is typically PCI device 14:0.0. Linux IOMMU driver checks for this special device. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Tom Lendacky

[Qemu-devel] [PATCH 2/6] x86_iommu/amd: Prepare for interrupt remap support

2018-09-11 Thread Brijesh Singh
Register the interrupt remapping callback and read/write ops for the amd-iommu-ir memory region. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Tom Lendacky Cc: Suravee Suthikulpanit Signed-off-by: Brijesh Singh --- hw/i386/am

[Qemu-devel] [PATCH 1/6] x86_iommu: move the kernel-irqchip check in common code

2018-09-11 Thread Brijesh Singh
Interrupt remapping needs kernel-irqchip={off|split} on both Intel and AMD platforms. Move the check in common place. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Tom Lendacky Cc: Suravee Suthikulpanit Signed-off-by: Brijesh S

[Qemu-devel] [Question] Question about ACPI table in qemu

2018-09-11 Thread Li Qiang
Hi all, I noticed that both qemu and seabios create the ACPI table. Once I think he bios' ACPI table will overwrite the qemu's if seabios compiled with CONFIG_ACPI. But after I read this --> https://lists.gnu.org/archive/html/qemu-devel/2013-02/msg04555.html There say: "just have QEMU pass the

[Qemu-devel] [PATCH 3/6] x86_iommu/amd: Add interrupt remap support when VAPIC is not enabled

2018-09-11 Thread Brijesh Singh
Emulate the interrupt remapping support when guest virtual APIC is not enabled. See IOMMU spec: https://support.amd.com/TechDocs/48882_IOMMU.pdf (section 2.2.5.1) for details information. When VAPIC is not enabled, it uses interrupt remapping as defined in Table 20 and Figure 15 from IOMMU spec.

[Qemu-devel] [PATCH 0/6] x86_iommu/amd: add interrupt remap support

2018-09-11 Thread Brijesh Singh
This series adds the interrupt remapping support for amd-iommu device. IOMMU spec is available at: https://support.amd.com/TechDocs/48882_IOMMU.pdf To enable the interrupt remap use below qemu cli # $QEMU \ -device amd-iommu,intremap=on I have tested FC-28 and Ubuntu 18.04 guest. Linux guest

[Qemu-devel] [PATCH 6/6] x86_iommu/amd: Enable Guest virtual APIC support

2018-09-11 Thread Brijesh Singh
Now that amd-iommu support interrupt remapping, enable the GASup in IVRS table and GASup in extended feature register to indicate that IOMMU support guest virtual APIC mode. Note that the GAMSup is set to zero to indicate that Guest Virtual APIC does not support advanced interrupt features (i.e v

[Qemu-devel] [Bug 1791796] Re: unimplemented thread syscalls in nios2 user-mode emulation

2018-09-11 Thread Sandra Loosemore
If you need a Nios II GNU/Linux toolchain, I think the most recent CodeBench Lite release will work: https://sourcery.mentor.com/GNUToolchain/subscription42545 We're planning on adding user-mode QEMU to the upcoming 2018.11 release that's actually what I've been testing it for. Results on t

Re: [Qemu-devel] [PATCH 2/2] virtio-scsi/virtio-blk: Disable poll handlers when stopping vq handler

2018-09-11 Thread Paolo Bonzini
On 11/09/2018 16:12, Fam Zheng wrote: > On Tue, 09/11 13:32, Paolo Bonzini wrote: >> On 10/09/2018 16:56, Fam Zheng wrote: >>> We have this unwanted call stack: >>> >>> > ... >>> > #13 0x5586602b7793 in virtio_scsi_handle_cmd_vq >>> > #14 0x5586602b8d66 in virtio_scsi_data_plane_handl

Re: [Qemu-devel] [PATCH] configure: Support --enable-capstone=internal

2018-09-11 Thread Eduardo Habkost
On Tue, Sep 11, 2018 at 07:33:08AM -0700, Richard Henderson wrote: > On 09/05/2018 08:19 AM, Eduardo Habkost wrote: > > Currently there's no way to make configure not try to use the > > system-provided capstone library using pkgconfig. > > Certainly there is. > > > > > Add support to --enable-ca

Re: [Qemu-devel] [RFC PATCH 3/4] linux-user/nios2: bump min uname to 4.16.0 [!HACK]

2018-09-11 Thread Marek Vasut
On 09/11/2018 05:08 PM, Alex Bennée wrote: > > Marek Vasut writes: > >> On 09/11/2018 04:14 PM, Laurent Vivier wrote: >>> Le 11/09/2018 à 16:06, Alex Bennée a écrit: This is to work around the limitations of the buildroot qemu_nios2_10m50_defconfig which sets the base kernel version fo

Re: [Qemu-devel] [RFC PATCH 3/4] linux-user/nios2: bump min uname to 4.16.0 [!HACK]

2018-09-11 Thread Alex Bennée
Marek Vasut writes: > On 09/11/2018 04:14 PM, Laurent Vivier wrote: >> Le 11/09/2018 à 16:06, Alex Bennée a écrit: >>> This is to work around the limitations of the buildroot >>> qemu_nios2_10m50_defconfig which sets the base kernel version for >>> glibc. >>> >>> Signed-off-by: Alex Bennée >>>

Re: [Qemu-devel] [RFC PATCH 3/4] linux-user/nios2: bump min uname to 4.16.0 [!HACK]

2018-09-11 Thread Laurent Vivier
Le 11/09/2018 à 16:40, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 11/09/2018 à 16:06, Alex Bennée a écrit: >>> This is to work around the limitations of the buildroot >>> qemu_nios2_10m50_defconfig which sets the base kernel version for >>> glibc. >>> >>> Signed-off-by: Alex Bennée

[Qemu-devel] [Bug 1791796] Re: [RFC PATCH 3/4] linux-user/nios2: bump min uname to 4.16.0 [!HACK]

2018-09-11 Thread Alex Bennée
Laurent Vivier writes: > Le 11/09/2018 à 16:06, Alex Bennée a écrit: >> This is to work around the limitations of the buildroot >> qemu_nios2_10m50_defconfig which sets the base kernel version for >> glibc. >> >> Signed-off-by: Alex Bennée >> --- >> linux-user/nios2/target_syscall.h | 2 +- >>

Re: [Qemu-devel] [PATCH] configure: Support --enable-capstone=internal

2018-09-11 Thread Richard Henderson
On 09/05/2018 08:19 AM, Eduardo Habkost wrote: > Currently there's no way to make configure not try to use the > system-provided capstone library using pkgconfig. Certainly there is. > > Add support to --enable-capstone=internal option to make QEMU not > use the system-provided library automatic

Re: [Qemu-devel] [RFC PATCH 3/4] linux-user/nios2: bump min uname to 4.16.0 [!HACK]

2018-09-11 Thread Marek Vasut
On 09/11/2018 04:14 PM, Laurent Vivier wrote: > Le 11/09/2018 à 16:06, Alex Bennée a écrit : >> This is to work around the limitations of the buildroot >> qemu_nios2_10m50_defconfig which sets the base kernel version for >> glibc. >> >> Signed-off-by: Alex Bennée >> --- >> linux-user/nios2/target

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-11 Thread Laszlo Ersek
+Alex, due to mention of 21e00fa55f3fd On 09/10/18 15:03, Marc-André Lureau wrote: > Hi > > On Mon, Sep 10, 2018 at 2:44 PM Dr. David Alan Gilbert > wrote: >> (I didn't know about guest_phys_block* and would have probably just used >> qemu_ram_foreach_block ) >> > > guest_phys_block*() seems to

Re: [Qemu-devel] [RFC PATCH 3/4] linux-user/nios2: bump min uname to 4.16.0 [!HACK]

2018-09-11 Thread Laurent Vivier
Le 11/09/2018 à 16:06, Alex Bennée a écrit : > This is to work around the limitations of the buildroot > qemu_nios2_10m50_defconfig which sets the base kernel version for > glibc. > > Signed-off-by: Alex Bennée > --- > linux-user/nios2/target_syscall.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH 2/2] virtio-scsi/virtio-blk: Disable poll handlers when stopping vq handler

2018-09-11 Thread Fam Zheng
On Tue, 09/11 13:32, Paolo Bonzini wrote: > On 10/09/2018 16:56, Fam Zheng wrote: > > We have this unwanted call stack: > > > > > ... > > > #13 0x5586602b7793 in virtio_scsi_handle_cmd_vq > > > #14 0x5586602b8d66 in virtio_scsi_data_plane_handle_cmd > > > #15 0x5586602ddab7 in

[Qemu-devel] [RFC PATCH 1/4] docker: add debian-buildroot-base

2018-09-11 Thread Alex Bennée
We can build some more cross-compilers using buildroot. This base system contains simply the minimum number of tools required for buildroot to work. We also download and unpack the buildroot source tree as that will be common for all system deriving from it. Signed-off-by: Alex Bennée --- tests/

Re: [Qemu-devel] [PATCH v1 1/1] qemu-img: add new function to remove bitmap in image

2018-09-11 Thread Eric Blake
On 9/11/18 8:56 AM, Eric Blake wrote: +    bitmap = bdrv_find_dirty_bitmap(bs, bitmapname); + +    /* + * Dirty bitmap may not be load if the 'IN_USE' flag is set (e.g. the + * qemu thread is corrupted and the 'IN_USE' flag is not be cleared), + * so the result of bdrv_find_dirty_

[Qemu-devel] [RFC PATCH 4/4] tests/tcg: add nios2 architecture (NEEDS FIXES)

2018-09-11 Thread Alex Bennée
Now we have a docker image with a nios2 compiler we can add the bits to build our TCG tests. Current failures: testmmap - fails in check_file_fixed_eof_mmaps due to inversion of offset linux-test - unimplemented lseek (probably others as well) Signed-off-by: Alex Bennée --- tests/tcg/nios2/

[Qemu-devel] [RFC PATCH 0/4] Add Nios II cross-compiler and enable tests/tcg

2018-09-11 Thread Alex Bennée
Hi, tl;dr Nios II linux-user seems pretty broken Following up on some mailing list queries about the state of Nios II Thomas pointed out that buildroot could build cross-compilers for the architecture. As a quick experiment I've enabled a docker based buildroot and turned on tests/tcg for it. Th

[Qemu-devel] [RFC PATCH 3/4] linux-user/nios2: bump min uname to 4.16.0 [!HACK]

2018-09-11 Thread Alex Bennée
This is to work around the limitations of the buildroot qemu_nios2_10m50_defconfig which sets the base kernel version for glibc. Signed-off-by: Alex Bennée --- linux-user/nios2/target_syscall.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/nios2/target_syscall.h

[Qemu-devel] [RFC PATCH 2/4] docker: add buildroot-nios2-cross image

2018-09-11 Thread Alex Bennée
Build a buildroot toolchain for the nios2 target. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 4 tests/docker/dockerfiles/buildroot-nios2-cross.docker | 10 ++ 2 files changed, 14 insertions(+) create mode 100644 tests/docker/dockerfiles/

Re: [Qemu-devel] [PATCH v1 1/1] qemu-img: add new function to remove bitmap in image

2018-09-11 Thread Eric Blake
On 9/11/18 3:37 AM, Ma Haocong wrote: Signed-off-by: Ma Haocong --- qemu-img-cmds.hx | 6 +++ qemu-img.c | 119 +++ 2 files changed, 125 insertions(+) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index 1526f327a5..cc397b64e4 10

  1   2   >