> >> +error_propagate(errp, local_err);
> > Shall we use error_propagate(errp, local_err, ("Failed to init VNC
> > server: ");
> > like vnc_display_open does?
>
> I don't know.
>
> The error reporting is somewhat poor around here. Consider:
>
> $ qemu-system-x86_64 -display vnc=:0
Hi,
> I don't know. The `disable-modern` option already exists but I
> don't know who would want to use it.
Compat property for old (2.6 & older) machine types.
> > Right - maybe a flag to disable modern interface is enough.
> > We thus get two types:
> > - transitional (legacy)
> > - non-tra
Hi
On Mon, Oct 15, 2018 at 9:34 PM Max Reitz wrote:
>
> This adds some whitespace into the option help (including indentation)
> and replaces '=' by ': ' (not least because '=' should be used for
> values, not types).
Without strong preference, I like the '=' better: it's the expected
syntax for
bdrv_img_create() takes an Error ** argument and used it in the
conventional way, except for one place: when qemu_opts_do_parse()
fails, it first reports its error to stderr or the HMP monitor with
error_report_err(), then error_setg()'s a generic error. When the
caller reports that second error s
On 16/10/2018 04:52, Richard Henderson wrote:
> On 10/5/18 2:14 PM, Emilio G. Cota wrote:
>> -target_ulong tlb_addr = env->tlb_table[mmu_idx][index].addr_write;
>> +target_ulong tlb_addr =
>> +atomic_read(&env->tlb_table[mmu_idx][index].addr_write);
>
> This fails for 32-bit hosts
Philippe Mathieu-Daudé writes:
> On 15/10/2018 16:48, Max Reitz wrote:
>> On 15.10.18 13:53, Markus Armbruster wrote:
>>> Calling error_report() from within a function that takes an Error **
>>> argument is suspicious. drive_new() calls error_report() even though
>>> it can run within drive_init
Fei Li writes:
> On 10/15/2018 07:53 PM, Markus Armbruster wrote:
>> Calling error_report() in a function that takes an Error ** argument
>> is suspicious. vnc_init_func() does that, and then fails without
>> setting an error. Its caller main(), via qemu_opts_foreach(), is fine
>> with it, but
Eduardo Habkost writes:
> On Mon, Oct 15, 2018 at 05:55:27PM +0100, Peter Maydell wrote:
>> On 15 October 2018 at 17:33, Markus Armbruster wrote:
>> > Kevin Wolf writes:
>> >
>> >> Am 15.10.2018 um 12:02 hat Peter Maydell geschrieben:
>> >> It's easier to port stuff to Python 3 though than maki
On aa64, "cross-compiling" to aa32, with
CC=arm-linux-gnueabihf-gcc
configure determines
aarch64-linux-user/config-target.mak:CROSS_CC_GUEST="aarch64-linux-gnu-gcc"
aarch64-linux-user/config-target.mak:CROSS_CC_GUEST_STATIC=y
aarch64-softmmu/config-target.mak:CROSS_CC_GUEST="aarch64-linux-gnu-gc
On 10/5/18 2:14 PM, Emilio G. Cota wrote:
> -target_ulong tlb_addr = env->tlb_table[mmu_idx][index].addr_write;
> +target_ulong tlb_addr =
> +atomic_read(&env->tlb_table[mmu_idx][index].addr_write);
This fails for 32-bit hosts emulating 64-bit hosts.
I think you need a separate hel
Hi Amit,
Thanks for your response.
See inline comments.
Amit Shah 于2018年10月16日周二 上午2:51写道：
>
> On (Thu) 11 Oct 2018 [18:15:41], Feng Li wrote:
> > Add Amit Shah.
> >
> > After some tests, we found:
> > - the virtio serial port number is inversely proportional to the iSCSI
> > virtio-blk-pci per
Commit 5a11d0f7 mistakenly converted a log message into an error
condition when irq map is failed for the pci device being
passed through. Revert that part of the commit.
Signed-off-by: Zhao Yan
---
hw/xen/xen_pt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/xen/xe
Hi Philippe,
On Monday, October 15, 2018 6:05 PM, Philippe Mathieu-Daudé wrote:
> Hi Stewart,
>
> On 15/10/2018 23:26, Stewart Hildebrand wrote:
> > +/* For the virt board, we write our startup "bootloader" at
> > the very
> > + * bottom of RAM, so that bit can't be used
On 10/15/18 7:57 PM, Eduardo Habkost wrote:
> On Mon, Oct 15, 2018 at 07:38:45PM -0400, Cleber Rosa wrote:
>>
>>
>> On 10/15/18 10:14 AM, Max Reitz wrote:
>>> iotest 169 uses the 'new' module to add methods to a class. This module
>>> no longer exists in Python 3. Instead, we can use a lambda.
On Mon, Oct 15, 2018 at 08:05:02PM -0400, Cleber Rosa wrote:
>
>
> On 10/15/18 5:17 PM, Eduardo Habkost wrote:
> > On Mon, Oct 15, 2018 at 04:14:52PM +0200, Max Reitz wrote:
> >> There are two imports that need to be modified when running the iotests
> >> under Python 3: One is StringIO, which no
On 10/15/18 5:17 PM, Eduardo Habkost wrote:
> On Mon, Oct 15, 2018 at 04:14:52PM +0200, Max Reitz wrote:
>> There are two imports that need to be modified when running the iotests
>> under Python 3: One is StringIO, which no longer exists; instead, the
>> StringIO class comes from the io module,
On Mon, Oct 15, 2018 at 07:38:45PM -0400, Cleber Rosa wrote:
>
>
> On 10/15/18 10:14 AM, Max Reitz wrote:
> > iotest 169 uses the 'new' module to add methods to a class. This module
> > no longer exists in Python 3. Instead, we can use a lambda. Best of
> > all, this works in 2.7 just as well.
On 10/15/18 10:14 AM, Max Reitz wrote:
> iotest 169 uses the 'new' module to add methods to a class. This module
> no longer exists in Python 3. Instead, we can use a lambda. Best of
> all, this works in 2.7 just as well.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/169 | 3 +--
On Mon, Oct 15, 2018 at 11:45:56AM +0200, Cornelia Huck wrote:
> On Fri, 12 Oct 2018 23:54:35 -0300
> Eduardo Habkost wrote:
>
> > The current virtio-*-pci device types actually represent 3
> > different types of devices:
> > * virtio 1.0 non-transitional devices
> > * virtio 1.0 transitional dev
On 10/15/18 10:14 AM, Max Reitz wrote:
> Python 3.2 introduced the inheritable attribute for FDs. At the same
> time, it changed the default so that all FDs are not inheritable by
> default, that only inheritable FDs are inherited to subprocesses, and
> only if close_fds is explicitly set to Fa
On 10/12/18 5:40 PM, Philippe Mathieu-Daudé wrote:
> Hi Fam,
>
> Few patches I added while testing the VM tests without KVM access.
> I doubt many people want to suffer using TCG for VM testing, but
> it was handy to debug/support aarch64 VM tests.
>
> Also this could be a useful TCG stress test.
On Mon, Oct 15, 2018 at 06:27:21AM -0400, Michael S. Tsirkin wrote:
> On Mon, Oct 15, 2018 at 10:16:41AM +0200, Gerd Hoffmann wrote:
> > On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote:
> > > The current virtio-*-pci device types actually represent 3
> > > different types of devices
Hi Aleksandar,
On 15/10/2018 12:50, Aleksandar Markovic wrote:
> From: Aleksandar Markovic
>
> Add a comment with an overview of CP0 registers close to the
> definition of their corresponding fields in CPUMIPSState.
>
> Signed-off-by: Aleksandar Markovic
> ---
> target/mips/cpu.h | 109
> +++
On 15/10/2018 13:52, Markus Armbruster wrote:
> From include/qapi/error.h:
>
> * Pass an existing error to the caller with the message modified:
> * error_propagate(errp, err);
> * error_prepend(errp, "Could not frobnicate '%s': ", name);
>
> Fei Li pointed out that doing error_prop
On 15/10/2018 13:53, Markus Armbruster wrote:
> From: Fei Li
>
> Signed-off-by: Fei Li
> Cc: Gerd Hoffmann
> Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
> ---
> include/ui/console.h | 2 +-
> ui/curses.c | 6 +++---
> ui/keymaps.c | 11 ++
On 15/10/2018 13:53, Markus Armbruster wrote:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. vnc_init_func() does that, and then fails without
> setting an error. Its caller main(), via qemu_opts_foreach(), is fine
> with it, but clean it up anyway.
>
> C
On Tue, Oct 16, 2018 at 12:28:07AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Caio,
>
> On 15/10/2018 20:41, Caio Carrara wrote:
> > On 13-10-2018 00:37, Eduardo Habkost wrote:
> >> On Fri, Oct 12, 2018 at 11:30:39PM +0200, Philippe Mathieu-Daudé wrote:
> >>> Hi Cleber,
> >>>
> >>> On 12/10/2018 18
On 10/15/18 10:14 AM, Max Reitz wrote:
> In Python 3, several functions now return iterators instead of lists.
> This includes range(), items(), map(), and filter(). This means that if
> we really want a list, we have to wrap those instances with list(). On
> the other hand, sometimes we do ju
On 15/10/2018 16:48, Max Reitz wrote:
> On 15.10.18 13:53, Markus Armbruster wrote:
>> Calling error_report() from within a function that takes an Error **
>> argument is suspicious. drive_new() calls error_report() even though
>> it can run within drive_init_func(), which takes an Error ** argume
On 15/10/2018 19:28, Max Reitz wrote:
> There is no good reason why there should be a newline in this
> description, so remove it.
>
> Signed-off-by: Max Reitz
Reviewed-by: Philippe Mathieu-Daudé
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.
Hi Caio,
On 15/10/2018 20:41, Caio Carrara wrote:
> On 13-10-2018 00:37, Eduardo Habkost wrote:
>> On Fri, Oct 12, 2018 at 11:30:39PM +0200, Philippe Mathieu-Daudé wrote:
>>> Hi Cleber,
>>>
>>> On 12/10/2018 18:53, Cleber Rosa wrote:
A number of QEMU tests are written in Python, and may benef
On Mon, Oct 15, 2018 at 04:14:53PM +0200, Max Reitz wrote:
> When dumping an object into the log, there are differences between
> Python 2 and 3. First, unicode strings are prefixed by 'u' in Python 2
> (they are no longer in 3, because unicode strings are the default
> there). [...]
This could
On 15/10/2018 21:04, Caio Carrara wrote:
> On 12-10-2018 13:53, Cleber Rosa wrote:
>> A number of QEMU tests are written in Python, and may benefit
>> from an untainted Python venv.
>>
>> By using make rules, tests that depend on specific Python libs
>> can set that rule as a requirement, along wit
Hi Max,
On 15/10/2018 16:14, Max Reitz wrote:
> This series prepares the iotests to work with both Python 2 and 3. In
> some places, it adds version-specific code and decides what to do based
> on the version (for instance, whether to import the StringIO class from
> the 'io' or the 'StringIO' mo
On 15/10/2018 16:14, Max Reitz wrote:
> Since byte strings are no longer the default in Python 3, we have to
> explicitly use them where we need to, which is mostly when working with
> structures. It also means that we need to open a file in binary mode
> when we want to use structures.
>
> On th
Hi Stewart,
On 15/10/2018 23:26, Stewart Hildebrand wrote:
> "The Image must be placed text_offset bytes from a 2MB aligned base
> address anywhere in usable system RAM and called there."
>
> For the virt board, we write our startup bootloader at the very
> bottom of RAM, so that bit can't be use
On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> +cpu->pmceid0 = pmceid & 0x;
> +cpu->pmceid1 = (pmceid >> 32) & 0x;
extract64(pmceid, 0, 32) and extract64(pmceid, 32, 32).
> +static const pm_event pm_events[] = {
> +};
> +#define MAX_EVENT_ID 0x0
Is this going to be A
On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> Add an array for PMOVSSET so we only define it for v7ve+ platforms
>
> Signed-off-by: Aaron Lindsay
> ---
> target/arm/helper.c | 28
> 1 file changed, 28 insertions(+)
Reviewed-by: Richard Henderson
r~
"The Image must be placed text_offset bytes from a 2MB aligned base
address anywhere in usable system RAM and called there."
For the virt board, we write our startup bootloader at the very
bottom of RAM, so that bit can't be used for the image. To avoid
overlap in case the image requests to be loa
On Mon, Oct 15, 2018 at 04:14:52PM +0200, Max Reitz wrote:
> There are two imports that need to be modified when running the iotests
> under Python 3: One is StringIO, which no longer exists; instead, the
> StringIO class comes from the io module, so import it from there. The
> other is the Config
On 10/15/18 10:14 AM, Max Reitz wrote:
> In Python 3, / is always a floating-point division. We usually do not
> want this, and as Python 2.7 understands // as well, change all integer
> divisions to use that.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/040| 4 ++--
> te
On Mon, Oct 15, 2018 at 04:14:51PM +0200, Max Reitz wrote:
> iotest 169 uses the 'new' module to add methods to a class. This module
> no longer exists in Python 3. Instead, we can use a lambda. Best of
> all, this works in 2.7 just as well.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iot
On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> Signed-off-by: Aaron Lindsay
> Reviewed-by: Peter Maydell
> ---
> target/arm/helper.c | 27 ++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> --- a/target/arm/machine.c
> +++ b/target/arm/machine.c
> @@ -584,7 +584,7 @@ static int cpu_pre_save(void *opaque)
> {
> ARMCPU *cpu = opaque;
>
> -pmccntr_op_start(&cpu->env);
> +pmu_op_start(&cpu->env);
Does it make sense to move this
On 10/15/18 10:14 AM, Max Reitz wrote:
> After issuing a command, flush the pipe. This does not change anything
> in Python 2, but it makes a difference in Python 3.
>
> Signed-off-by: Max Reitz
Reviewed-by: Cleber Rosa
On 10/15/18 1:30 PM, Aaron Lindsay wrote:
> On Oct 15 13:19, Richard Henderson wrote:
>> On 10/15/18 12:50 PM, Richard Henderson wrote:
>>> Ok, looking at this follow-up makes more sense than the previous patch.
>>> Would
>>> it make sense to squash these two together?
>>
>> Or, rather, split int
On Oct 15 12:45, Richard Henderson wrote:
> On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> > +static void cpu_post_save(void *opaque)
> > +{
> > +ARMCPU *cpu = opaque;
> > +pmccntr_sync(&cpu->env);
> > +}
>
> I'm confused about the need for this.
> Can you explain the sequence of events that
On Oct 15 13:19, Richard Henderson wrote:
> On 10/15/18 12:50 PM, Richard Henderson wrote:
> > Ok, looking at this follow-up makes more sense than the previous patch.
> > Would
> > it make sense to squash these two together?
>
> Or, rather, split into two different patches: the first splits pmcc
On Mon, Oct 15, 2018 at 04:14:50PM +0200, Max Reitz wrote:
> Python 3.2 introduced the inheritable attribute for FDs. At the same
> time, it changed the default so that all FDs are not inheritable by
> default, that only inheritable FDs are inherited to subprocesses, and
> only if close_fds is exp
On Fri, 12 Oct 2018 02:34:12 PDT (-0700), peter.mayd...@linaro.org wrote:
On 11 October 2018 at 21:52, Michael Clark wrote:
Peter, I have to pull in your remote wholesale. I don't cherry-pick from
your tree. I think this is truly dumb. This might serve the needs of some
folk running Linux but w
On Oct 15 12:50, Richard Henderson wrote:
> On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> > pmccntr_read and pmccntr_write contained duplicate code that was already
> > being handled by pmccntr_sync. Consolidate the duplicated code into two
> > functions: pmccntr_op_start and pmccntr_op_finish. Add a
On 10/15/18 10:14 AM, Max Reitz wrote:
> When closing a connection, make the nbd-fault-injector flush the socket.
> Without this, the output is a bit unreliable with Python 3.
>
> Signed-off-by: Max Reitz
Reviewed-by: Cleber Rosa
On 10/15/18 12:50 PM, Richard Henderson wrote:
> Ok, looking at this follow-up makes more sense than the previous patch. Would
> it make sense to squash these two together?
Or, rather, split into two different patches: the first splits pmccntr_sync and
updates all of the existing uses, and the se
Hi,
I'd like to start a discussion about virtual PCIe link width and speeds
in QEMU to figure out how we progress past the 2.5GT/s, x1 width links
we advertise today. This matters for assigned devices as the endpoint
driver may not enable full physical link utilization if the upstream
port only a
On Mon, Oct 15, 2018 at 02:59:28PM -0400, Cleber Rosa wrote:
>
>
> On 10/15/18 10:14 AM, Max Reitz wrote:
> > There are two imports that need to be modified when running the iotests
> > under Python 3: One is StringIO, which no longer exists; instead, the
> > StringIO class comes from the io modu
On Mon, Oct 15, 2018 at 04:14:49PM +0200, Max Reitz wrote:
> In Python 3, several functions now return iterators instead of lists.
> This includes range(), items(), map(), and filter(). This means that if
> we really want a list, we have to wrap those instances with list(). On
> the other hand, s
While testing the Python 3 changes which touch the 083 test, I noticed
that it would fail with qcow2. Expanding the testing, I noticed it
had nothing to do with the Python 3 changes, and in fact, it would not
pass on anything but raw:
raw: pass
bochs: not generic
cloop: not generic
parallels:
On Mon, Oct 15, 2018 at 04:14:48PM +0200, Max Reitz wrote:
> In Python 3, / is always a floating-point division. We usually do not
> want this, and as Python 2.7 understands // as well, change all integer
> divisions to use that.
>
> Signed-off-by: Max Reitz
Reviewed-by: Eduardo Habkost
--
E
On Mon, Oct 15, 2018 at 04:14:47PM +0200, Max Reitz wrote:
> Since byte strings are no longer the default in Python 3, we have to
> explicitly use them where we need to, which is mostly when working with
> structures. It also means that we need to open a file in binary mode
> when we want to use s
On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> pmccntr_read and pmccntr_write contained duplicate code that was already
> being handled by pmccntr_sync. Consolidate the duplicated code into two
> functions: pmccntr_op_start and pmccntr_op_finish. Add a companion to
> c15_ccnt in CPUARMState so that we
On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> +static void cpu_post_save(void *opaque)
> +{
> +ARMCPU *cpu = opaque;
> +pmccntr_sync(&cpu->env);
> +}
I'm confused about the need for this.
Can you explain the sequence of events that requires it?
r~
On Mon, Oct 15, 2018 at 04:14:45PM +0200, Max Reitz wrote:
> When closing a connection, make the nbd-fault-injector flush the socket.
> Without this, the output is a bit unreliable with Python 3.
>
> Signed-off-by: Max Reitz
Reviewed-by: Eduardo Habkost
--
Eduardo
On Mon, Oct 15, 2018 at 04:14:46PM +0200, Max Reitz wrote:
> After issuing a command, flush the pipe. This does not change anything
> in Python 2, but it makes a difference in Python 3.
>
> Signed-off-by: Max Reitz
Reviewed-by: Eduardo Habkost
--
Eduardo
On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> In some cases it may be helpful to modify state before saving it for
> migration, and then modify the state back after it has been saved. The
> existing pre_save function provides half of this functionality. This
> patch adds a post_save function to provi
On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> This is an amendment to my earlier patch:
> commit 7ece99b17e832065236c07a158dfac62619ef99b
> Author: Aaron Lindsay
> Date: Thu Apr 26 11:04:39 2018 +0100
>
> target/arm: Mask PMU register writes based on PMCR_EL0.N
>
> Signed-off-b
On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> I previously fixed this for PMINTENSET_EL1, but missed these.
>
> Signed-off-by: Aaron Lindsay
> Signed-off-by: Aaron Lindsay
> ---
> target/arm/helper.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
On 12-10-2018 13:53, Cleber Rosa wrote:
> A number of QEMU tests are written in Python, and may benefit
> from an untainted Python venv.
>
> By using make rules, tests that depend on specific Python libs
> can set that rule as a requirement, along with rules that require
> the presence or installa
On 10/15/18 10:14 AM, Max Reitz wrote:
> There are two imports that need to be modified when running the iotests
> under Python 3: One is StringIO, which no longer exists; instead, the
> StringIO class comes from the io module, so import it from there. The
> other is the ConfigParser, which has
On (Thu) 11 Oct 2018 [18:15:41], Feng Li wrote:
> Add Amit Shah.
>
> After some tests, we found:
> - the virtio serial port number is inversely proportional to the iSCSI
> virtio-blk-pci performance.
> If we set the virio-serial ports to 2(" type='virtio-serial' index='0' ports='2'/>), the perform
On 10/15/2018 08:33 PM, Eduardo Habkost wrote:
> On Mon, Oct 15, 2018 at 08:19:18PM +0200, Christian Borntraeger wrote:
[...]
It's easier to port stuff to Python 3 though than making them work with
both. I think Eduardo's RFC is in part motivated by a patch from
Philippe tha
On 13-10-2018 00:37, Eduardo Habkost wrote:
> On Fri, Oct 12, 2018 at 11:30:39PM +0200, Philippe Mathieu-Daudé wrote:
>> Hi Cleber,
>>
>> On 12/10/2018 18:53, Cleber Rosa wrote:
>>> A number of QEMU tests are written in Python, and may benefit
>>> from an untainted Python venv.
>>>
>>> By using mak
On 10/15/18 11:23 AM, Alex Bennée wrote:
>
> Richard Henderson writes:
>
>> On 10/5/18 8:48 AM, Alex Bennée wrote:
>>> +trace_tlb_flush_all_work(cpu->cpu_index);
>>> tlb_flush_nocheck(cpu);
>>> +trace_tlb_flush_work_complete(__LINE__, cpu->cpu_index);
>>
>> Why is __LINE__ an intere
On 10/15/18 11:17 AM, Alex Bennée wrote:
>
> Richard Henderson writes:
>
>> On 10/5/18 8:48 AM, Alex Bennée wrote:
>>> To avoid overly long lines in trace events I've split the event into
>>> tlb_set_page and tlb_set_page_attrs.
>>
>> I don't think this split is a good idea. It allows data from
On Mon, Oct 15, 2018 at 08:19:18PM +0200, Christian Borntraeger wrote:
>
>
> On 10/15/2018 06:33 PM, Markus Armbruster wrote:
> > Kevin Wolf writes:
> >
> >> Am 15.10.2018 um 12:02 hat Peter Maydell geschrieben:
> >>> On 15 October 2018 at 10:32, Daniel P. Berrangé
> >>> wrote:
> On Sat,
Richard Henderson writes:
> On 10/5/18 8:48 AM, Alex Bennée wrote:
>> +trace_tlb_flush_all_work(cpu->cpu_index);
>> tlb_flush_nocheck(cpu);
>> +trace_tlb_flush_work_complete(__LINE__, cpu->cpu_index);
>
> Why is __LINE__ an interesting argument to a trace function?
Yeah - I wanted
On 10/15/2018 06:33 PM, Markus Armbruster wrote:
> Kevin Wolf writes:
>
>> Am 15.10.2018 um 12:02 hat Peter Maydell geschrieben:
>>> On 15 October 2018 at 10:32, Daniel P. Berrangé wrote:
On Sat, Oct 13, 2018 at 02:02:27AM -0300, Eduardo Habkost wrote:
> Signed-off-by: Eduardo Habkos
Richard Henderson writes:
> On 10/5/18 8:48 AM, Alex Bennée wrote:
>> To avoid overly long lines in trace events I've split the event into
>> tlb_set_page and tlb_set_page_attrs.
>
> I don't think this split is a good idea. It allows data from different
> threads
> to be interleaved.
Won't w
Richard Henderson writes:
> On 10/5/18 8:49 AM, Alex Bennée wrote:
>> +GLIB_CFLAGS = $(shell pkg-config --cflags glib-2.0)
>> +CFLAGS = -I$(QEMU_SRC)/include/plugins $(GLIB_CFLAGS) -fno-PIE -fPIC -O3 -g
>> +LDFLAGS = $(shell pkg-config --libs glib-2.0) -shared
>
> I'm not keen on defaulting to
Richard Henderson writes:
> On 10/5/18 8:49 AM, Alex Bennée wrote:
>> +char *plugin_status(void)
>> +{
>> +GString *report = g_string_new("We have ");
>> +char *r;
>> +g_mutex_lock(&lock);
>> +g_string_append_printf(report, "%ud entries in the hash table\n",
>> +
On Sun, Oct 14, 2018 at 05:35:12PM -0400, Michael S. Tsirkin wrote:
> On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote:
> > The current virtio-*-pci device types actually represent 3
> > different types of devices:
> > * virtio 1.0 non-transitional devices
> > * virtio 1.0 transition
Another gentle ping on v2 of this series?
Patch was submitted a month ago.
Thanks,
-Liran
> On 8 Oct 2018, at 20:21, Liran Alon wrote:
>
> Gentle ping on v2 of this series.
> (I noticed 1st patch of series was already applied)
>
> Thanks,
> -Liran
>
>> On 16 Sep 2018, at 15:46, Liran Alon wr
On Mon, Oct 15, 2018 at 05:55:27PM +0100, Peter Maydell wrote:
> On 15 October 2018 at 17:33, Markus Armbruster wrote:
> > Kevin Wolf writes:
> >
> >> Am 15.10.2018 um 12:02 hat Peter Maydell geschrieben:
> >> It's easier to port stuff to Python 3 though than making them work with
> >> both. I th
From: Li Qiang
Define a TYPE_VFIO_PCI and drop DO_UPCAST.
Signed-off-by: Li Qiang
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Williamson
---
hw/vfio/pci.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio
From: Eric Auger
Up to now we have relied on the device type to identify a device tree
node creation function. Since we would like the vfio-platform device to
be instantiable with different compatible strings we introduce the
capability to specialize the node creation depending on actual
compati
From: Geert Uytterhoeven
Allow the instantation of generic dynamic vfio-platform devices again,
without the need to create a new device-specific vfio type.
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Eric Auger
Tested-by: Eric Auger
Signed-off-by: Alex Williamson
---
hw/arm/virt.c |1
From: Eric Auger
Up to now the vfio-platform device has been abstract and could not be
instantiated. The integration of a new vfio platform device required
creating a dummy derived device which only set the compatible string.
Following the few vfio-platform device integrations we have seen the
From: Gerd Hoffmann
Needed to make sure code using ramfb (vfio) compiles properly even on
platforms without fw_cfg (and therefore no ramfb) support.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Alex Williamson
---
stubs/Makefile.objs |1 +
stubs/ramfb.c | 13 +
2 files
The following changes since commit ff56877e911782dedc9a424233fd3f62369c258c:
Merge remote-tracking branch 'remotes/kraxel/tags/vga-20181015-pull-request'
into staging (2018-10-15 15:03:45 +0100)
are available in the Git repository at:
git://github.com/awilliam/qemu-vfio.git
From: Gerd Hoffmann
So we have a boot display when using a vgpu as primary display.
ramfb depends on a fw_cfg file. fw_cfg files can not be added and
removed at runtime, therefore a ramfb-enabled vfio device can't be
hotplugged.
Add a nohotplug variant of the vfio-pci device (as child class).
On 10/5/18 8:49 AM, Alex Bennée wrote:
> Signed-off-by: Alex Bennée
> ---
> trace/plugins/hotblocks/hotblocks.c | 33 -
> 1 file changed, 32 insertions(+), 1 deletion(-)
Oh, haha. Ignore the first half of my comment for the previous patch.
r~
On 10/5/18 8:49 AM, Alex Bennée wrote:
> As we don't have a monitor in linux-user mode we need some way of
> exporting our data to the world. We introduce a new -d option (plugin)
> which turns on the existing LOG_TRACE flag which qemu_plugin_status()
> will dump output to before we finally exit.
>
This adds some whitespace into the option help (including indentation)
and replaces '=' by ': ' (not least because '=' should be used for
values, not types). Furthermore, the list name is no longer printed as
part of every line, but only once in advance, and only if the caller did
not print a capt
On 10/5/18 8:49 AM, Alex Bennée wrote:
> +char *plugin_status(void)
> +{
> +GString *report = g_string_new("We have ");
> +char *r;
> +g_mutex_lock(&lock);
> +g_string_append_printf(report, "%ud entries in the hash table\n",
> + g_hash_table_size(hotblocks)
Just like in qemu_opts_print_help(), print the object name as a caption
instead of on every single line, indent all options, and replace the '='
by ': '.
Also, indent every object name in the list of available objects.
Signed-off-by: Max Reitz
---
vl.c | 12
1 file changed, 8 inser
There is no good reason why there should be a newline in this
description, so remove it.
Signed-off-by: Max Reitz
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index f9ed053eab..19f8cc67ff 100644
--- a/vl.c
+++ b/vl.c
@@ -529,7 +529,7 @@ static QemuOpts
Following the example of qemu_opts_print_help(), indent all entries in
the list of character devices.
Signed-off-by: Max Reitz
---
chardev/char.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/chardev/char.c b/chardev/char.c
index e115166995..10d44aaefc 100644
--- a/chardev/
Just like in qemu_opts_print_help(), print the device name as a caption
instead of on every single line, indent all options, and replace the '='
by ': '.
Signed-off-by: Max Reitz
---
qdev-monitor.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/qdev-monitor.c b/qdev-mo
I noticed that with the (more or less) recent series from Marc-André the
output of qemu-img amend -f qcow2 -o help changed to this:
$ ./qemu-img amend -f qcow2 -o help
Creation options for 'qcow2':
qcow2-create-opts.backing_file=str - File name of a base image
qcow2-create-opts.backing_fmt=str - I
On 10/5/18 8:49 AM, Alex Bennée wrote:
> Signed-off-by: Alex Bennée
> ---
> hmp-commands-info.hx | 17 +
> include/qemu/plugins.h | 1 +
> monitor.c | 14 ++
> trace/plugins.c| 15 +++
> 4 files changed, 47 insertions(+)
Reviewed-by
On 10/5/18 8:49 AM, Alex Bennée wrote:
> +GLIB_CFLAGS = $(shell pkg-config --cflags glib-2.0)
> +CFLAGS = -I$(QEMU_SRC)/include/plugins $(GLIB_CFLAGS) -fno-PIE -fPIC -O3 -g
> +LDFLAGS = $(shell pkg-config --libs glib-2.0) -shared
I'm not keen on defaulting to -O3.
I'd prefer if we passed up the fl
1 - 100 of 283 matches
Mail list logo
