Re: [Qemu-devel] Minutes of KVM Forum BoF on deprecating stuff

2018-10-27 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Oct 26, 2018 at 04:03:51PM +0200, Markus Armbruster wrote: >> This is from my (imperfect) notes, corrections welcome. >> >> Motivation: QEMU contains stuff of dubious value, which gets in the way >> in various (sometimes painful and expensive) ways. >> >>

Re: [Qemu-devel] [PATCH 04/10] cputlb: Split large page tracking per mmu_idx

2018-10-27 Thread Richard Henderson
On 10/27/18 1:16 AM, Emilio G. Cota wrote: > On Tue, Oct 23, 2018 at 08:02:47 +0100, Richard Henderson wrote: >> +static void tlb_flush_page_locked(CPUArchState *env, int midx, >> + target_ulong addr) >> +{ >> +target_ulong lp_addr =

Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features

2018-10-27 Thread Peter Maydell
On 26 October 2018 at 03:00, Michael S. Tsirkin wrote: > OK I fixed 32 bit issues. Could not reproduce the test issues, > could it be that it was a side effect of build issues maybe? > > Could you retyr? > If it still ails I will drop the test for now. Compiles OK, but still asserts

Re: [Qemu-devel] [PATCH 1/2] docs: tpm: Mention implemented TPM CRB interface emulation and specs

2018-10-27 Thread Marc-André Lureau
On Thu, Oct 18, 2018 at 10:21 PM Stefan Berger wrote: > > Add a few sentences about the implemented emulation of the TPM CRB > interface and its specification. > > Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau > --- > docs/specs/tpm.txt | 15 +++ > 1 file changed,

Re: [Qemu-devel] [PATCH RFC 4/4] net/slirp: add ipv6-hostfwd option for user netdev type

2018-10-27 Thread Samuel Thibault
Maxim Samoylov, le ven. 26 oct. 2018 03:03:43 +0300, a ecrit: > +void hmp_ipv6_hostfwd_remove(Monitor *mon, const QDict *qdict) > +{ Similarly, a lot can be shared, by introducing const char *hmp_hostfwd_lookup(Monitor *mon, const QDict *qdict, int is_v6) which will contain all the lookup and

Re: [Qemu-devel] [PATCH RFC 3/4] slirp: add helpers for ipv6 hostfwd manipulation

2018-10-27 Thread Samuel Thibault
Hello, Maxim Samoylov, le ven. 26 oct. 2018 03:03:42 +0300, a ecrit: > +int slirp_remove_ipv6_hostfwd(Slirp *slirp, int is_udp, > + struct in6_addr host_addr, int host_port) Similarly, we'd rather share the code than duplicate it :) Better put the existing

Re: [Qemu-devel] [PATCH RFC 2/4] slirp: add helper for udp6 socket creation

2018-10-27 Thread Samuel Thibault
Ditto :) Samuel

Re: [Qemu-devel] [PATCH RFC 1/4] slirp: add helper for tcp6 socket creation

2018-10-27 Thread Samuel Thibault
Samuel Thibault, le sam. 27 oct. 2018 13:11:41 +0200, a ecrit: > struct socket * > tcp_listen(Slirp *slirp, uint32_t haddr, u_int hport, uint32_t laddr, >u_int lport, int flags) > { > struct sockaddr_in addr; > struct socket *so; > socklen_t addrsize = sizeof(addr);

Re: [Qemu-devel] [PATCH RFC 1/4] slirp: add helper for tcp6 socket creation

2018-10-27 Thread Samuel Thibault
Hello, Thanks for working on this! There is a lot of overlap with tcp_listen. It'd be much better to refactor it this way: struct socket * tcpx_listen(Slirp *slirp, struct sockaddr *addr, socklen_t *addrlen, int flags) { ... The current content of tcp_listen, with all heading and

Re: [Qemu-devel] [PATCH 0/2] Deprecate the "collie" machine and Strongarm devices

2018-10-27 Thread Guenter Roeck
On 10/26/18 3:12 AM, Peter Maydell wrote: On 26 October 2018 at 11:06, Thomas Huth wrote: These files lack an entry in the MAINTAINERS file, and according to the initial commits, the board and devices are incomplete. Since there have hardly been any commits in the past to really improve them,

[Qemu-devel] [PATCH V5 0/5] add pvpanic mmio support

2018-10-27 Thread Peng Hao
The first patches are simple cleanups: - patch 1 move the pvpanic device with the 'ocmmon objects' so we compile it once for the x86/arm/aarch64 archs, - patch 2 simply renames ISA fields/definitions to generic ones. Then instead of add/use the MMIO pvpanic device in the virt machine in an

[Qemu-devel] [PATCH V5 3/5] hw/misc/pvpanic: Add the MMIO interface

2018-10-27 Thread Peng Hao
Signed-off-by: Peng Hao Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/pvpanic.c | 81 +-- include/hw/misc/pvpanic.h | 1 + 2 files changed, 65 insertions(+), 17 deletions(-) diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index

[Qemu-devel] [PATCH V5 1/5] hw/misc/pvpanic: Build the pvpanic device in $(common-obj)

2018-10-27 Thread Peng Hao
From: Philippe Mathieu-Daudé The 'pvpanic' ISA device can be use by any machine with an ISA bus. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs index

[Qemu-devel] [PATCH V5 2/5] hw/misc/pvpanic: Cosmetic renaming

2018-10-27 Thread Peng Hao
From: Philippe Mathieu-Daudé To ease the MMIO device addition in the next patch, rename: - ISA_PVPANIC_DEVICE -> PVPANIC (this just returns a generic Object), - ISADevice parent_obj -> isadev, - MemoryRegion io -> mr. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/pvpanic.c | 16

[Qemu-devel] [PATCH V5 4/5] hw/arm/virt: Use the pvpanic device

2018-10-27 Thread Peng Hao
add pvpanic device in aarch64 virt machine. Signed-off-by: Peng Hao Signed-off-by: Philippe Mathieu-Daudé --- default-configs/aarch64-softmmu.mak | 1 + hw/arm/virt.c | 21 + include/hw/arm/virt.h | 1 + 3 files changed, 23

[Qemu-devel] [PATCH V5 5/5] hw/arm/virt: add pvpanic device in virt acpi table

2018-10-27 Thread Peng Hao
add pvpanic device in virt acpi table, so when kenrel command line uses acpi=force, kernel can get info from acpi table in aarch64. Signed-off-by: Peng Hao --- hw/arm/virt-acpi-build.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/arm/virt-acpi-build.c

Re: [Qemu-devel] [Qemu-arm] [RFC v4 00/71] per-CPU locks

2018-10-27 Thread Alex Bennée
Emilio G. Cota writes: > [I forgot to add the cover letter to git send-email; here it is] > > v3: > > "Why is this an RFC?" See v3 link above. Also, see comment at > the bottom of this message regarding the last patch of this

Re: [Qemu-devel] [PATCH v3 01/16] hw/cpu: introduce CPU clusters

2018-10-27 Thread Alistair Francis
On Fri, Oct 26, 2018 at 9:41 AM Luc Michel wrote: > > This commit adds the cpu-cluster type. It aims at gathering CPUs from > the same cluster in a machine. > > For now it only has a `cluster-id` property. > > Signed-off-by: Luc Michel > --- > include/hw/cpu/cluster.h | 38

Re: [Qemu-devel] [PATCH] target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64

2018-10-27 Thread Alistair Francis
On Fri, Oct 26, 2018 at 7:14 PM Dayeol Lee wrote: > > Hi, > > I submitted the patch, but just found this has been already fixed by > Michael Clark > and pushed to riscv/riscv-qemu > but not in the upstream. > > Do we still need this patch? Yeah, this

Re: [Qemu-devel] [PATCH v2 00/29] target/riscv: Convert to decodetree

2018-10-27 Thread Palmer Dabbelt
On Fri, 26 Oct 2018 03:53:11 PDT (-0700), wrote: On 10/25/18 12:21 AM, Palmer Dabbelt wrote: On Sat, 20 Oct 2018 00:14:22 PDT (-0700), wrote: Hi, this patchset converts the RISC-V decoder to decodetree in three major steps: 1)