On Sat, Nov 17, 2018 at 02:34:18PM +0200, Marcel Apfelbaum wrote:
>
>
> On 11/13/18 9:13 AM, Yuval Shaia wrote:
> > Interface with the device is changed with the addition of support for
> > MAD packets.
> > Adjust documentation accordingly.
> >
> > While there fix a minor mistake which may lead
On Sat, Nov 17, 2018 at 11:13 PM Richard W.M. Jones
wrote:
> On Sat, Nov 17, 2018 at 10:59:26PM +0200, Nir Soffer wrote:
> > On Fri, Nov 16, 2018 at 5:26 PM Kevin Wolf wrote:
> >
> > > Am 15.11.2018 um 23:27 hat Nir Soffer geschrieben:
> > > > On Sun, Nov 11, 2018 at 6:11 PM Nir Soffer
>
On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
The helpers for starting/stopping qemu-nbd in 058 will be useful in
other test cases, so move them into a common.nbd file.
Signed-off-by: Daniel P. Berrangé
---
+function nbd_server_start_unix_socket()
+{
+nbd_server_stop
+$QEMU_NBD -v
On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
This does two minor fixes to the NBD code and adds significant coverage
of the NBD TLS support to detect future problems.
The first two patches should be for 3.1.
The tests can wait till 4.0 if desired.
Daniel P. Berrangé (6):
nbd: fix
On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
When sending a NBD_CMD_DISC message there is no reply expected,
however, the nbd_read_eof() coroutine is still waiting for a reply.
In a plain NBD connection this doesn't matter as it will just get an
EOF, however, on a TLS connection it will get an
Enhance test 233 to also perform I/O beyond the initial handshake.
Signed-off-by: Eric Blake
---
Depends on my tweak to 2/6 to suppress an EIO error message
on a failed read after NBD_CMD_DISC.
tests/qemu-iotests/233 | 12 +++-
tests/qemu-iotests/233.out | 10 ++
2 files
Commit 37ec36f6 intentionally ignores errors when trying to reply
to an NBD_OPT_ABORT request for plaintext clients, but did not make
the same change for a TLS server. Since NBD_OPT_ABORT is
documented as being a potential for an EPIPE when the client hangs
up without waiting for our reply, we
On 11/17/18 2:49 PM, Eric Blake wrote:
On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
Add tests that validate it is possible to connect to an NBD server
running TLS mode. Also test mis-matched TLS vs non-TLS connections
correctly fail.
---
Missing your Signed-off-by. Can you please supply
On 11/16/18 11:20 AM, Eric Blake wrote:
On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
Add tests that validate it is possible to connect to an NBD server
running TLS mode. Also test mis-matched TLS vs non-TLS connections
correctly fail.
---
+== check TLS client to plain server fails ==
On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
Add tests that validate it is possible to connect to an NBD server
running TLS mode. Also test mis-matched TLS vs non-TLS connections
correctly fail.
---
Missing your Signed-off-by. Can you please supply that, so I can include
this in my pull
On Sat, Nov 17, 2018 at 10:59:26PM +0200, Nir Soffer wrote:
> On Fri, Nov 16, 2018 at 5:26 PM Kevin Wolf wrote:
>
> > Am 15.11.2018 um 23:27 hat Nir Soffer geschrieben:
> > > On Sun, Nov 11, 2018 at 6:11 PM Nir Soffer wrote:
> > >
> > > > On Wed, Nov 7, 2018 at 7:55 PM Nir Soffer wrote:
> > >
On Fri, Nov 16, 2018 at 5:26 PM Kevin Wolf wrote:
> Am 15.11.2018 um 23:27 hat Nir Soffer geschrieben:
> > On Sun, Nov 11, 2018 at 6:11 PM Nir Soffer wrote:
> >
> > > On Wed, Nov 7, 2018 at 7:55 PM Nir Soffer wrote:
> > >
> > >> On Wed, Nov 7, 2018 at 7:27 PM Kevin Wolf wrote:
> > >>
> > >>>
From: Aleksandar Markovic
Add Stefan Markovic as a MIPS reviewer. He had several key
contributions to QEMU for MIPS this year. He is a meticulous
person with the ability to think and act on many levels.
Reviewed-by: Stefan Markovic
Signed-off-by: Aleksandar Markovic
---
MAINTAINERS | 9
From: Fredrik Noring
DIV1 and DIVU1 are generated in gen_div1_tx79 instead of the generic
gen_muldiv.
Signed-off-by: Fredrik Noring
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Aleksandar Markovic
---
target/mips/translate.c | 65 -
1
From: Fredrik Noring
Explicitely mark handling of PREF instruction for R5900 as
treating the same as NOP.
Reviewed-by: Aleksandar Markovic
Signed-off-by: Fredrik Noring
Signed-off-by: Aleksandar Markovic
---
target/mips/translate.c | 9 ++---
1 file changed, 6 insertions(+), 3
From: Aleksandar Markovic
Rename MMI-related opcodes.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Markovic
Signed-off-by: Aleksandar Markovic
---
target/mips/translate.c | 472
1 file changed, 236 insertions(+), 236 deletions(-)
From: Aleksandar Markovic
Rename MMI-related functions.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Markovic
Signed-off-by: Aleksandar Markovic
---
target/mips/translate.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git
From: Stefan Markovic
Perform needed checks before actual prctl() PR_SET_FP_MODE and
PR_GET_FP_MODE work based on kernel implementation. Also, update
necessary hflags.
Reviewed-by: Laurent Vivier
Signed-off-by: Stefan Markovic
Signed-off-by: Aleksandar Markovic
---
linux-user/syscall.c | 18
From: Aleksandar Markovic
Disable R5900 support. There are some outstanding issues related
to ABI support and emulation accuracy, that were not understood
well during review process. Disable to avoid backward compatibility
issues.
Reverts commit ed4f49ba9bb56ebca6987b1083255daf6c89b5de.
From: Fredrik Noring
MFLO1, MFHI1, MTLO1 and MTHI1 are generated in gen_HILO1_tx79 instead of
the generic gen_HILO.
Reviewed-by: Aleksandar Markovic
Signed-off-by: Fredrik Noring
Signed-off-by: Aleksandar Markovic
---
target/mips/translate.c | 51
From: Fredrik Noring
MOVN, MOVZ, MFHI, MFLO, MTHI, MTLO, MULT, MULTU, DIV, DIVU, DMULT,
DMULTU, DDIV, DDIVU and JR are decoded in decode_opc_special_tx79
instead of the generic decode_opc_special_legacy.
Reviewed-by: Aleksandar Markovic
Signed-off-by: Fredrik Noring
Signed-off-by: Aleksandar
From: Fredrik Noring
Avoid using check_opc_user_only() as a decision making code wrt
various architectures. Use ctx->insn_flags checks instead.
Reviewed-by: Aleksandar Markovic
Signed-off-by: Fredrik Noring
Signed-off-by: Aleksandar Markovic
---
target/mips/translate.c | 16
From: Aleksandar Markovic
Rename MMI-related masks.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Markovic
Signed-off-by: Aleksandar Markovic
---
target/mips/translate.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
From: Aleksandar Markovic
The following changes since commit 83c496599cc04926ecbc3e47a37debaa3e38b686:
Merge remote-tracking branch
'remotes/kraxel/tags/fixes-31-20181116-pull-request' into staging (2018-11-16
13:53:01 +)
are available in the git repository at:
Le sam. 17 nov. 2018 16:56, Aleksandar Markovic <
aleksandar.marko...@rt-rk.com> a écrit :
> From: Aleksandar Markovic
>
> Add Stefan Markovic as a MIPS reviewer. He had several key
> contributions to QEMU for MIPS this year. He is a meticulous
> person with the ability to think and act on many
> Some patches of this series miss your S-o-b tag
Will be fixed in a minute.
From: Philippe Mathieu-Daudé
Sent: Saturday, November 17, 2018 7:09:37 PM
To: Aleksandar Markovic
Cc: qemu-devel@nongnu.org Developers; Peter Maydell; Aleksandar Markovic
Hi Aleksandar,
Le sam. 17 nov. 2018 16:58, Aleksandar Markovic <
aleksandar.marko...@rt-rk.com> a écrit :
> From: Aleksandar Markovic
>
> The following changes since commit
> 83c496599cc04926ecbc3e47a37debaa3e38b686:
>
> Merge remote-tracking branch
>
The 1.12.0 version of SeaBIOS has now been released. For more
information on the release, please see:
http://seabios.org/Releases
New in this release:
* Initial support for "TPM CRB" hardware
* Improved cdrom media reporting in the boot menu on QEMU
* Improved floppy support on real floppy
On Tue, Nov 13, 2018 at 09:13:14AM +0200, Yuval Shaia wrote:
> RDMA MAD kernel module (ibcm) disallow more than one MAD-agent for a
> given MAD class.
> This does not go hand-by-hand with qemu pvrdma device's requirements
> where each VM is MAD agent.
> Fix it by adding implementation of RDMA MAD
Hi Peng,
On 11/17/18 8:22 PM, Peng Hao wrote:
> In match function it should not call OBJECK_CHECK. When there is
> a mismatch, we should continue to match rather than assert().
Normally this issue should have been fixed by
e9ac8e84f0 "hw/arm/sysbus-fdt: Only call match_fn callback if the type
This commit fixes a case where the CPU would try to go to EL3 when
executing an smc instruction, even though ARM_FEATURE_EL3 is false. This
case is raised when the PSCI conduit is set to smc, but the smc
instruction does not lead to a valid PSCI call.
QEMU crashes with an assertion failure latter
From: Aleksandar Markovic
Rename MMI-related opcodes.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Markovic
Signed-off-by: Aleksandar Markovic
---
target/mips/translate.c | 472
1 file changed, 236 insertions(+), 236 deletions(-)
From: Aleksandar Markovic
Rename MMI-related masks.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Markovic
Signed-off-by: Aleksandar Markovic
---
target/mips/translate.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
From: Fredrik Noring
Explicitely mark handling of PREF instruction for R5900 as
treating the same as NOP.
Reviewed-by: Aleksandar Markovic
Signed-off-by: Fredrik Noring
---
target/mips/translate.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git
From: Fredrik Noring
Avoid using check_opc_user_only() as a decision making code wrt
various architectures. Use ctx->insn_flags checks instead.
Reviewed-by: Aleksandar Markovic
Signed-off-by: Fredrik Noring
---
target/mips/translate.c | 16
1 file changed, 12 insertions(+),
From: Fredrik Noring
DIV1 and DIVU1 are generated in gen_div1_tx79 instead of the generic
gen_muldiv.
Signed-off-by: Fredrik Noring
Reviewed-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 65 -
1 file changed, 59 insertions(+), 6
From: Aleksandar Markovic
Rename MMI-related functions.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Markovic
Signed-off-by: Aleksandar Markovic
---
target/mips/translate.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git
From: Fredrik Noring
MFLO1, MFHI1, MTLO1 and MTHI1 are generated in gen_HILO1_tx79 instead of
the generic gen_HILO.
Reviewed-by: Aleksandar Markovic
Signed-off-by: Fredrik Noring
---
target/mips/translate.c | 51 ++---
1 file changed, 40
From: Fredrik Noring
MOVN, MOVZ, MFHI, MFLO, MTHI, MTLO, MULT, MULTU, DIV, DIVU, DMULT,
DMULTU, DDIV, DDIVU and JR are decoded in decode_opc_special_tx79
instead of the generic decode_opc_special_legacy.
Reviewed-by: Aleksandar Markovic
Signed-off-by: Fredrik Noring
---
From: Aleksandar Markovic
Disable R5900 support. There are some outstanding issues related
to ABI support and emulation accuracy, that were not understood
well during review process. Disable to avoid backward compatibility
issues.
Reverts commit ed4f49ba9bb56ebca6987b1083255daf6c89b5de.
From: Aleksandar Markovic
Add Stefan Markovic as a MIPS reviewer. He had several key
contributions to QEMU for MIPS this year. He is a meticulous
person with the ability to think and act on many levels.
Reviewed-by: Stefan Markovic
Signed-off-by: Aleksandar Markovic
---
MAINTAINERS | 9
From: Aleksandar Markovic
The following changes since commit 83c496599cc04926ecbc3e47a37debaa3e38b686:
Merge remote-tracking branch
'remotes/kraxel/tags/fixes-31-20181116-pull-request' into staging (2018-11-16
13:53:01 +)
are available in the git repository at:
From: Stefan Markovic
Perform needed checks before actual prctl() PR_SET_FP_MODE and
PR_GET_FP_MODE work based on kernel implementation. Also, update
necessary hflags.
Signed-off-by: Stefan Markovic
Reviewed-by: Laurent Vivier
---
linux-user/syscall.c | 18 ++
1 file changed,
> From: Fredrik Noring
> Subject: [PATCH v2 1/6] target/mips: Fix decoding mechanism of R5900 MFLO1,
> MFHI1, MTLO1 and MTHI1
Reviewed-by: Aleksandar Markovic
> From: Fredrik Noring
> Subject: [PATCH v2 6/6] target/mips: Guard check_insn with INSN_R5900 check
Reviewed-by: Aleksandar Markovic
Some minor changes will be made before integrating.
> From: Fredrik Noring
> Subject: [PATCH v2 5/6] target/mips: Guard check_insn_opc_user_only with
> INSN_R5900 check
Reviewed-by: Aleksandar Markovic
Some minor changes will be made before integrating.
> From: Fredrik Noring
> Subject: [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900
> opcodes
>
> MOVN, MOVZ, MFHI, MFLO, MTHI, MTLO, MULT, MULTU, DIV, DIVU, DMULT,
> DMULTU, DDIV, DDIVU and JR are decoded in decode_opc_special_tx79
> instead of the generic
On Sat, Nov 17, 2018, 2:29 AM Dr. David Alan Gilbert * Zhang Chen (zhangc...@gmail.com) wrote:
> > On Wed, Nov 14, 2018 at 7:17 PM Peter Maydell
> > wrote:
> >
> > > On 14 November 2018 at 11:06, Thomas Huth wrote:
> > > > On 2018-11-14 11:47, Peter Xu wrote:
> > > >> On Thu, Nov 01, 2018 at
On 11/13/18 9:13 AM, Yuval Shaia wrote:
The control over the RDMA device's GID table is done by updating the
device's Ethernet function addresses.
Usually the first GID entry is determine by the MAC address, the second
s/determine/determined
by the first IPv6 address and the third by the
On 11/13/18 9:13 AM, Yuval Shaia wrote:
Interface with the device is changed with the addition of support for
MAD packets.
Adjust documentation accordingly.
While there fix a minor mistake which may lead to think that there is a
relation between using RXE on host and the compatibility with
On 11/13/18 9:13 AM, Yuval Shaia wrote:
When device goes down the function fini_ports loops over all entries in
gid table regardless of the fact whether entry is valid or not. In case
that entry is not valid we'd like to skip from any further processing in
backend device.
Signed-off-by:
On 11/13/18 9:13 AM, Yuval Shaia wrote:
bitmap_zero_extend is designed to work for extending, not for
shrinking.
Using g_free instead.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_rm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/rdma_rm.c
On 11/13/18 9:13 AM, Yuval Shaia wrote:
In order to clean some external resources such as GIDs, QPs etc,
register to receive notification when VM is shutdown.
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma.h | 2 ++
hw/rdma/vmw/pvrdma_main.c | 12
2 files changed,
On 11/13/18 9:13 AM, Yuval Shaia wrote:
Device supports only one port, let's remove a dead code that handles
more than one port.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_rm.c | 34 --
hw/rdma/rdma_rm.h | 2 +-
hw/rdma/rdma_rm_defs.h | 4
On 11/13/18 9:13 AM, Yuval Shaia wrote:
Driver checks error code let's set it.
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma_cmd.c | 67
1 file changed, 48 insertions(+), 19 deletions(-)
diff --git a/hw/rdma/vmw/pvrdma_cmd.c
On 11/13/18 9:13 AM, Yuval Shaia wrote:
Add ability to pass specific WC attributes to CQE such as GRH_BIT flag.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.c | 59 +++--
hw/rdma/rdma_backend.h | 4 +--
hw/rdma/vmw/pvrdma_qp_ops.c | 31
On 11/13/18 9:13 AM, Yuval Shaia wrote:
User should be able to control the device by changing Ethernet function
state so if user runs 'ifconfig ens3 down' the PVRDMA function should be
down as well.
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma_cmd.c | 3 ++-
1 file changed, 2
On 11/13/18 9:13 AM, Yuval Shaia wrote:
node_guid should be set once device is load.
Make node_guid be GID format (32 bit) of PCI function 0 vmxnet3 device's
MAC.
A new function was added to do the conversion.
So for example the MAC 56:b6:44:e9:62:dc will be converted to GID
On 11/13/18 9:12 AM, Yuval Shaia wrote:
opcode for WC should be set by the device and not taken from work
element.
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma_qp_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c
Hi Yuval,
On 11/13/18 9:12 AM, Yuval Shaia wrote:
MAD (Management Datagram) packets are widely used by various modules
Please add a link to Spec, I sent it in the V1 mail-thread
Please add it also as a comment in the code. I know MADs
are a complicated matter, but if somebody wants to have a
On 11/13/18 9:12 AM, Yuval Shaia wrote:
Device is not supporting QP0, only QP1.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_backend.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h
index 86e8fe8ab6..3ccc9a2494 100644
On 11/11/18 9:45 AM, Yuval Shaia wrote:
On Sat, Nov 10, 2018 at 08:27:44PM +0200, Marcel Apfelbaum wrote:
On 11/8/18 6:08 PM, Yuval Shaia wrote:
Guest driver enforces it, we should also.
Signed-off-by: Yuval Shaia
---
hw/rdma/vmw/pvrdma.h | 2 ++
hw/rdma/vmw/pvrdma_main.c | 3
Hi Yuval,
On 11/11/18 12:31 PM, Yuval Shaia wrote:
On Sat, Nov 10, 2018 at 08:15:27PM +0200, Marcel Apfelbaum wrote:
Hi Yuval
On 11/8/18 6:08 PM, Yuval Shaia wrote:
MAD (Management Datagram) packets are widely used by various modules
both in kernel and in user space for example the rdma_*
In match function it should not call OBJECK_CHECK. When there is
a mismatch, we should continue to match rather than assert().
Signed-off-by: Peng Hao
---
hw/arm/sysbus-fdt.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-fdt.c
64 matches
Mail list logo
