Re: [Qemu-devel] [PATCH v9 4/8] migration: API to clear bits of guest free pages from the dirty bitmap

2018-11-26 Thread Peter Xu
On Tue, Nov 27, 2018 at 02:52:35PM +0800, Wei Wang wrote: > On 11/27/2018 02:06 PM, Peter Xu wrote: > > On Thu, Nov 15, 2018 at 06:08:00PM +0800, Wei Wang wrote: > > Again, is it possible to resize during migration? > > > > So I think the check is fine, but uncertain about the comment. > > Yes,

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v9 3/8] migration: use bitmap_mutex in migration_bitmap_clear_dirty

2018-11-26 Thread Peter Xu
On Tue, Nov 27, 2018 at 02:12:34PM +0800, Wei Wang wrote: > On 11/27/2018 02:02 PM, Wei Wang wrote: > > On 11/27/2018 01:40 PM, Peter Xu wrote: > > > On Thu, Nov 15, 2018 at 06:07:59PM +0800, Wei Wang wrote: > > > > The bitmap mutex is used to synchronize threads to update the dirty > > > > bitmap

Re: [Qemu-devel] [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy

2018-11-26 Thread Peter Xu
On Thu, Nov 15, 2018 at 06:08:01PM +0800, Wei Wang wrote: > This patch adds a notifier chain for the memory precopy. This enables various > precopy optimizations to be invoked at specific places. > > Signed-off-by: Wei Wang > CC: Dr. David Alan Gilbert > CC: Juan Quintela > CC: Michael S.

Re: [Qemu-devel] [PATCH] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size

2018-11-26 Thread Thomas Huth
On 2018-10-30 09:23, Gerd Hoffmann wrote: > Fixes: CVE-2018-??? > Cc: P J P > Reported-by: Wangjunqing > Suggested-by: Paolo Bonzini > Signed-off-by: Gerd Hoffmann > --- > hw/audio/fmopl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/audio/fmopl.h

Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-26 Thread Cédric Le Goater
On 11/27/18 12:48 AM, David Gibson wrote: > On Mon, Nov 26, 2018 at 12:20:19PM +0100, Cédric Le Goater wrote: >> On 11/26/18 6:39 AM, David Gibson wrote: >>> On Fri, Nov 23, 2018 at 02:28:35PM +0100, Cédric Le Goater wrote: +/* + * Returns whether the event notification

Re: [Qemu-devel] [PATCH v5 04/36] ppc/xive: introduce the XiveRouter model

2018-11-26 Thread Cédric Le Goater
On 11/27/18 1:11 AM, David Gibson wrote: > On Mon, Nov 26, 2018 at 10:39:44AM +0100, Cédric Le Goater wrote: >> On 11/26/18 6:44 AM, David Gibson wrote: >>> On Fri, Nov 23, 2018 at 11:28:24AM +0100, Cédric Le Goater wrote: On 11/23/18 2:10 AM, David Gibson wrote: > On Thu, Nov 22, 2018 at

Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org

2018-11-26 Thread Thomas Huth
On 2018-11-25 21:50, Philippe Mathieu-Daudé wrote: > The list is always selected by the 'All patches CC here' section. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 13 - > 1 file changed, 13 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

Re: [Qemu-devel] [PATCH for-3.1 24/25] MAINTAINERS: Use my work email to review Build and test automation patches

2018-11-26 Thread Thomas Huth
On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ad82c0377c..c616861ca3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@

Re: [Qemu-devel] [PATCH for-3.1 22/25] MAINTAINERS: Add a missing entry to the New World machines

2018-11-26 Thread Thomas Huth
On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote: > The CHRP NVRAM has his own section, but since the New World > section contains the mac_nvram.c, it makes sens to also monitor > the corresponding header. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1

Re: [Qemu-devel] [PATCH for-3.1 21/25] MAINTAINERS: Add a missing entry for the NVDIMM device

2018-11-26 Thread Thomas Huth
On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 26727c1561..92691589b1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1475,6 +1475,7 @@

Re: [Qemu-devel] [PATCH for-3.1 14/25] MAINTAINERS: Add missing entries to the vhost section

2018-11-26 Thread Thomas Huth
On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e124792557..eab0fb9742 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1359,6 +1359,7 @@

Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue

2018-11-26 Thread Xiao Guangrong
On 11/26/18 6:56 PM, Dr. David Alan Gilbert wrote: * Xiao Guangrong (guangrong.x...@gmail.com) wrote: On 11/23/18 7:02 PM, Dr. David Alan Gilbert wrote: +#include "qemu/osdep.h" +#include "qemu/bitmap.h" +#include "qemu/threaded-workqueue.h" + +#define SMP_CACHE_BYTES 64 That's

Re: [Qemu-devel] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

2018-11-26 Thread Thomas Huth
On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index bfe71f2555..e124792557 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1326,6 +1326,8

Re: [Qemu-devel] [RFC v9 00/17] VIRTIO-IOMMU device

2018-11-26 Thread Bharat Bhushan
Hi Eric, > -Original Message- > From: Eric Auger > Sent: Thursday, November 22, 2018 10:45 PM > To: eric.auger@gmail.com; eric.au...@redhat.com; qemu- > de...@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; > m...@redhat.com; jean-philippe.bruc...@arm.com > Cc:

Re: [Qemu-devel] [PATCH for-3.1 01/25] MAINTAINERS: Fix ACPI tests data files path

2018-11-26 Thread Thomas Huth
On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote: > Missed while moving those files in 438c78dab75. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Igor Mammedov > --- > MAINTAINERS | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS

Re: [Qemu-devel] [RFC v9 15/17] hw/arm/virt: Add the virtio-iommu device tree mappings

2018-11-26 Thread Bharat Bhushan
> -Original Message- > From: Eric Auger > Sent: Thursday, November 22, 2018 10:46 PM > To: eric.auger@gmail.com; eric.au...@redhat.com; qemu- > de...@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; > m...@redhat.com; jean-philippe.bruc...@arm.com > Cc:

Re: [Qemu-devel] [PATCH 2/2] hw: vmmouse: drop DEFINE_PROP_PTR()

2018-11-26 Thread Markus Armbruster
Li Qiang writes: > Use link property instead. > > Signed-off-by: Li Qiang > --- > hw/i386/pc.c | 2 +- > hw/i386/vmmouse.c | 17 +++-- > 2 files changed, 12 insertions(+), 7 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 5d3fd86b83..9b343b4fd1 100644 > ---

Re: [Qemu-devel] [PATCH 1/2] hw: pc: use TYPE_XXX instead of constant strings

2018-11-26 Thread Markus Armbruster
Li Qiang writes: > Signed-off-by: Li Qiang > --- > hw/i386/pc.c | 9 +++-- > hw/sparc64/sun4u.c | 2 +- > include/hw/i386/pc.h | 7 +++ > 3 files changed, 11 insertions(+), 7 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index f095725dba..5d3fd86b83 100644 > ---

[Qemu-devel] [PATCH RFC v5 4/5] virtio-iommu: add virtio-iommu replay

2018-11-26 Thread Bharat Bhushan
For virtio-iommu, on replay first unmap any previous iommu-mapping and then map in iommu as per guest iommu mappings. Also if virtual iommu do have it own replay then memory_region_iommu_replay() calls "imrc->translate()", While virtio-iommu translate() expects device to be registered before it

[Qemu-devel] [PATCH RFC v5 5/5] virtio-iommu: handle IOMMU Notifier flag changes

2018-11-26 Thread Bharat Bhushan
Finally handle the IOMMU Notifier flag changes for the iommu-memory region. Signed-off-by: Bharat Bhushan --- v4->v5: - Rebase to v9 version from Eric (no change) hw/virtio/trace-events | 2 ++ hw/virtio/virtio-iommu.c | 31 +++ 2 files changed, 33 insertions(+)

Re: [Qemu-devel] [PATCH v3] qapi: add query-display-options command

2018-11-26 Thread Gerd Hoffmann
Hi, > If it's not too much trouble, please tweak the commit message to be a > bit more explicit. Perhaps: > > Add query-display-options command, which allows querying the qemu > display configuration. This isn't particularly useful, except it > exposes QAPI type DisplayOptions in

[Qemu-devel] [PATCH RFC v5 3/5] virtio-iommu: Call iommu notifier on attach/detach

2018-11-26 Thread Bharat Bhushan
This patch extend the ATTACH/DETACH command handling to call iommu-notifier to map/unmap the memory region in IOMMU using vfio. This replay existing address space mappings on attach command and remove existing address space mappings on detach command. Signed-off-by: Bharat Bhushan Signed-off-by:

[Qemu-devel] [PULL 6/6] qapi: add query-display-options command

2018-11-26 Thread Gerd Hoffmann
Add query-display-options command, which allows querying the qemu display configuration. This isn't particularly useful, except it exposes QAPI type DisplayOptions in query-qmp-schema, so that libvirt can discover recently added -display parameter rendernode (commit d4dc4ab133b). Works around

[Qemu-devel] [PATCH RFC v5 0/5] virtio-iommu: VFIO integration

2018-11-26 Thread Bharat Bhushan
This patch series integrates VFIO with virtio-iommu. This is tested with assigning 2 pci devices to Virtual Machine. This version is mainly about rebasing on v9 version on virtio-iommu device framework from Eric Augur. This patch series allows PCI pass-through using virtio-iommu. This series is

[Qemu-devel] [PATCH RFC v5 2/5] virtio-iommu: Add iommu notifier for iommu-map/unmap

2018-11-26 Thread Bharat Bhushan
This patch extends VIRTIO_IOMMU_T_MAP/UNMAP request handling to notify registered iommu-notifier. These iommu-notifier maps the requested region in IOMMU using vfio. Signed-off-by: Bharat Bhushan --- v4->v5: - Rebase to v9 version from Eric - PCIe device hotplug fix hw/virtio/trace-events

[Qemu-devel] [PATCH RFC v5 1/5] hw/vfio/common: Do not print error when viommu translates into an mmio region

2018-11-26 Thread Bharat Bhushan
From: Eric Auger On ARM, the MSI doorbell is translated by the virtual IOMMU. As such address_space_translate() returns the MSI controller MMIO region and we get an "iommu map to non memory area" message. Let's remove this latter. Signed-off-by: Eric Auger Signed-off-by: Bharat Bhushan ---

[Qemu-devel] [PULL 1/6] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size

2018-11-26 Thread Gerd Hoffmann
Cc: P J P Reported-by: Wangjunqing Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Gerd Hoffmann Message-id: 20181030082340.17170-1-kra...@redhat.com Suggested-by: Paolo Bonzini Signed-off-by: Gerd Hoffmann --- hw/audio/fmopl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PULL 4/6] audio/hda: fix guest triggerable assert

2018-11-26 Thread Gerd Hoffmann
Guest writes to a readonly register trigger the assert in intel_hda_reg_write(). Add a check and just ignore them. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1628433 Signed-off-by: Gerd Hoffmann Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé Message-id:

[Qemu-devel] [PULL 5/6] usb-host: set ifs.detached as true if kernel driver is not active

2018-11-26 Thread Gerd Hoffmann
From: linzhecheng If no kernel driver is active, we can already claim and perform I/O on it without detaching it. Signed-off-by: linzhecheng Message-id: 20181120083419.17716-1-linzhech...@huawei.com Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 3 +++ 1 file changed, 3

[Qemu-devel] [PULL 0/6] Fixes 31 20181127 patches

2018-11-26 Thread Gerd Hoffmann
The following changes since commit 5298f4d67a911dd9cefa4c4185eed242074d64c2: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2018-11-23 08:54:52 +) are available in the git repository at: git://git.kraxel.org/qemu tags/fixes-31-20181127-pull-request for

[Qemu-devel] [PULL 2/6] ps2kbd: default to scan enabled after reset

2018-11-26 Thread Gerd Hoffmann
From: Hervé Poussineau A check for scan_enabled has been added to ps2_keyboard_event in commit 143c04c7e0639e53086519592ead15d2556bfbf2 to prevent stream corruption. This works well as long as operating system is resetting keyboard, or enabling it. This fixes IBM 40p firmware, which doesn't

[Qemu-devel] [PULL 3/6] cirrus_vga/migration: update the bank offset before use

2018-11-26 Thread Gerd Hoffmann
From: Wang Xin The cirrus bank0/1 offset should be updated before we update the vram's alias offset. Signed-off-by: Wang Xin Message-id: 20181123064646.23036-1-linzhech...@huawei.com Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 7 --- 1 file changed, 4 insertions(+), 3

Re: [Qemu-devel] [PATCH v9 4/8] migration: API to clear bits of guest free pages from the dirty bitmap

2018-11-26 Thread Wei Wang
On 11/27/2018 02:06 PM, Peter Xu wrote: On Thu, Nov 15, 2018 at 06:08:00PM +0800, Wei Wang wrote: Again, is it possible to resize during migration? So I think the check is fine, but uncertain about the comment. Yes, resize would not happen with the current implementation. But heard it could

Re: [Qemu-devel] [PATCH] hw: fw_cfg: Improve error message when can't load splash file

2018-11-26 Thread Markus Armbruster
Li Qiang writes: > read_splashfile() reports "failed to read splash file" without > further details. Get the details from g_file_get_contents(), and > include them in the error message. Also remove unnecessary 'res' > variable. > > Signed-off-by: Li Qiang > --- > hw/nvram/fw_cfg.c | 7 +++

Re: [Qemu-devel] [PATCH] target: hax: fix errors in comment

2018-11-26 Thread Markus Armbruster
Li Qiang writes: > Cc: qemu-triv...@nongnu.org > > Signed-off-by: Li Qiang > --- > target/i386/hax-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c > index 502ce6f0af..70213ebcf5 100644 > --- a/target/i386/hax-all.c >

Re: [Qemu-devel] [BUG] qemu stuck when detach host-usb device

2018-11-26 Thread linzhecheng
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Tuesday, November 27, 2018 2:09 PM > To: linzhecheng > Cc: qemu-devel@nongnu.org; wangxin (U) ; > Zhoujian (jay) ; libusb-de...@lists.sourceforge.net > Subject: Re: [Qemu-devel] [BUG] qemu stuck when detach

Re: [Qemu-devel] [BUG] qemu stuck when detach host-usb device

2018-11-26 Thread Gerd Hoffmann
On Tue, Nov 27, 2018 at 01:26:24AM +, linzhecheng wrote: > Description of problem: > The guest has a host-usb device(Kingston Technology DataTraveler 100 > G3/G4/SE9 G2), which is attached > to xhci controller(on host). Qemu will stuck if I detach it from guest. > > How reproducible: > 100%

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v9 3/8] migration: use bitmap_mutex in migration_bitmap_clear_dirty

2018-11-26 Thread Wei Wang
On 11/27/2018 02:02 PM, Wei Wang wrote: On 11/27/2018 01:40 PM, Peter Xu wrote: On Thu, Nov 15, 2018 at 06:07:59PM +0800, Wei Wang wrote: The bitmap mutex is used to synchronize threads to update the dirty bitmap and the migration_dirty_pages counter. For example, the free page optimization

Re: [Qemu-devel] [PATCH v9 4/8] migration: API to clear bits of guest free pages from the dirty bitmap

2018-11-26 Thread Peter Xu
On Thu, Nov 15, 2018 at 06:08:00PM +0800, Wei Wang wrote: > This patch adds an API to clear bits corresponding to guest free pages > from the dirty bitmap. Spilt the free page block if it crosses the QEMU > RAMBlock boundary. > > Signed-off-by: Wei Wang > CC: Dr. David Alan Gilbert > CC: Juan

Re: [Qemu-devel] [PATCH v9 3/8] migration: use bitmap_mutex in migration_bitmap_clear_dirty

2018-11-26 Thread Wei Wang
On 11/27/2018 01:40 PM, Peter Xu wrote: On Thu, Nov 15, 2018 at 06:07:59PM +0800, Wei Wang wrote: The bitmap mutex is used to synchronize threads to update the dirty bitmap and the migration_dirty_pages counter. For example, the free page optimization clears bits of free pages from the bitmap

Re: [Qemu-devel] [PATCH for-3.1] hw/arm/virt-acpi-build: Fix SMMUv3 ACPI integration

2018-11-26 Thread Auger Eric
Hi Shannon, On 11/26/18 4:46 PM, Eric Auger wrote: > The AcpiIortSmmu3 misses 2 32b fields corresponding to the > proximity domain and the device id mapping index. I fail to understand how we currently track the evolutions of the IORT structures: Looking at the smmuv3 node in kernel

Re: [Qemu-devel] [PATCH v9 3/8] migration: use bitmap_mutex in migration_bitmap_clear_dirty

2018-11-26 Thread Peter Xu
On Thu, Nov 15, 2018 at 06:07:59PM +0800, Wei Wang wrote: > The bitmap mutex is used to synchronize threads to update the dirty > bitmap and the migration_dirty_pages counter. For example, the free > page optimization clears bits of free pages from the bitmap in an > iothread context. This patch

[Qemu-devel] [PATCH] target: hax: fix errors in comment

2018-11-26 Thread Li Qiang
Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang --- target/i386/hax-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c index 502ce6f0af..70213ebcf5 100644 --- a/target/i386/hax-all.c +++ b/target/i386/hax-all.c @@ -205,7

[Qemu-devel] [PATCH 1/1] input: improve performance of mouse event handle

2018-11-26 Thread FelixYao
Hi Gerd Hoffmann: Qemu doesn't put mouse event into queue. It handle mouse event one by one independently. So, I think there is no need to use g_new0 to malloc memory dynamically. Using local variable can improve event handle performance. I have tested this patch in my platform. after applying

Re: [Qemu-devel] [PATCH v9 0/8] virtio-balloon: free page hint support

2018-11-26 Thread Wei Wang
On 11/15/2018 06:07 PM, Wei Wang wrote: This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device receives the guest free page hints from the driver and clears the corresponding bits in the dirty bitmap, so that those

Re: [Qemu-devel] [PATCH] hw: fw_cfg: Improve error message when can't load splash file

2018-11-26 Thread Li Qiang
Hello Paolo, Philippe Seems this patch has been lost... I think Philippe can merge it for 4.0, right? Also pls notice the following fw_cfg patchset. -->https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04097.html Thanks, Li Qiang Li Qiang 于2018年11月1日周四 下午2:02写道: > read_splashfile()

[Qemu-devel] [PATCH for-4.0 v3 0/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-26 Thread Eduardo Habkost
Existing modern-only device types are not being touched by v3, as they don't need separate variants. However, I plan to implement separate cleanups in the code that calls virtio_pci_force_virtio_1(), first, and then propose additional changes (e.g. deprecating disable-legacy and disable-modern in

[Qemu-devel] [PATCH for-4.0 v3 2/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-26 Thread Eduardo Habkost
Many of the current virtio-*-pci device types actually represent 3 different types of devices: * virtio 1.0 non-transitional devices * virtio 1.0 transitional devices * virtio 0.9 ("legacy device" in virtio 1.0 terminology) That would be just an annoyance if it didn't break our device/bus

[Qemu-devel] [PATCH for-4.0 v3 1/2] virtio: Helper for registering virtio device types

2018-11-26 Thread Eduardo Habkost
Introduce a helper for registering different flavours of virtio devices. Convert code to use the helper, but keep only the existing generic types. Transitional and non-transitional device types will be added by another patch. Acked-by: Andrea Bolognani Signed-off-by: Eduardo Habkost ---

Re: [Qemu-devel] [RFC 38/48] translator: implement 2-pass translation

2018-11-26 Thread Emilio G. Cota
On Mon, Nov 26, 2018 at 15:16:00 +, Alex Bennée wrote: > Emilio G. Cota writes: (snip) > > +if (tb_trans_cb && first_pass) { > > +qemu_plugin_tb_trans_cb(cpu, plugin_tb); > > +first_pass = false; > > +goto translate; > > +} > > So the only reason we are doing

Re: [Qemu-devel] [PATCH v5 04/36] ppc/xive: introduce the XiveRouter model

2018-11-26 Thread David Gibson
On Fri, Nov 23, 2018 at 09:06:07AM +0100, Cédric Le Goater wrote: > On 11/23/18 4:50 AM, David Gibson wrote: > > On Thu, Nov 22, 2018 at 08:53:00AM +0100, Cédric Le Goater wrote: > >> On 11/22/18 5:11 AM, David Gibson wrote: > >>> On Fri, Nov 16, 2018 at 11:56:57AM +0100, Cédric Le Goater > wrote:

Re: [Qemu-devel] [RFC 23/48] translator: add plugin_insn argument to translate_insn

2018-11-26 Thread Emilio G. Cota
On Mon, Nov 26, 2018 at 11:30:25 -0800, Richard Henderson wrote: > On 11/26/18 11:07 AM, Emilio G. Cota wrote: > > The main reason why I added the qemu_plugin_insn_append calls > > was to avoid reading the instructions twice from guest memory, > > because I was worried that doing so might somehow

[Qemu-devel] [BUG] qemu stuck when detach host-usb device

2018-11-26 Thread linzhecheng
Description of problem: The guest has a host-usb device(Kingston Technology DataTraveler 100 G3/G4/SE9 G2), which is attached to xhci controller(on host). Qemu will stuck if I detach it from guest. How reproducible: 100% Steps to Reproduce: 1.Use usb stick to copy files in guest ,

Re: [Qemu-devel] [RFC 22/48] cpu: hook plugin vcpu events

2018-11-26 Thread Emilio G. Cota
On Mon, Nov 26, 2018 at 11:17:27 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > On Fri, Nov 23, 2018 at 17:10:53 +, Alex Bennée wrote: > >> Emilio G. Cota writes: > > (snip) > >> > @@ -1322,12 +1323,21 @@ static void qemu_tcg_rr_wait_io_event(CPUState > >> > *cpu) > >> > > >>

Re: [Qemu-devel] [RFC 12/48] atomic_template: define pre/post macros

2018-11-26 Thread Emilio G. Cota
On Mon, Nov 26, 2018 at 11:21:13 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > On Thu, Nov 22, 2018 at 17:12:34 +, Alex Bennée wrote: > >> > >> Emilio G. Cota writes: > >> > >> > In preparation for plugin support. > >> > > >> > Signed-off-by: Emilio G. Cota > >> > >> More

Re: [Qemu-devel] [PATCH v5 02/36] ppc/xive: add support for the LSI interrupt sources

2018-11-26 Thread David Gibson
On Mon, Nov 26, 2018 at 12:20:19PM +0100, Cédric Le Goater wrote: > On 11/26/18 6:39 AM, David Gibson wrote: > > On Fri, Nov 23, 2018 at 02:28:35PM +0100, Cédric Le Goater wrote: > >> > >> +/* > >> + * Returns whether the event notification should be forwarded. > >> + */ > >>

Re: [Qemu-devel] [PATCH v5 04/36] ppc/xive: introduce the XiveRouter model

2018-11-26 Thread David Gibson
On Mon, Nov 26, 2018 at 10:39:44AM +0100, Cédric Le Goater wrote: > On 11/26/18 6:44 AM, David Gibson wrote: > > On Fri, Nov 23, 2018 at 11:28:24AM +0100, Cédric Le Goater wrote: > >> On 11/23/18 2:10 AM, David Gibson wrote: > >>> On Thu, Nov 22, 2018 at 05:50:07PM +1100, Benjamin Herrenschmidt

Re: [Qemu-devel] [PATCH V9 9/9] pvpanic : update pvpanic document

2018-11-26 Thread peng.hao2
>> Add mmio support info in docs/specs/pvpanic.txt. >> >> Signed-off-by: Peng Hao >> --- >> docs/specs/pvpanic.txt | 15 +-- >> 1 file changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt >> index c7bbacc..67f5591 100644 >>

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-26 Thread Eduardo Habkost
On Thu, Nov 15, 2018 at 12:21:55PM +0100, Cornelia Huck wrote: > On Wed, 14 Nov 2018 21:38:31 -0200 > Eduardo Habkost wrote: > > > diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h > > index 813082b0d7..1d2a11504f 100644 > > --- a/hw/virtio/virtio-pci.h > > +++

Re: [Qemu-devel] [PATCH v3 02/16] i2c: have I2C receive operation return uint8_t

2018-11-26 Thread Corey Minyard
On 11/26/18 2:23 PM, Philippe Mathieu-Daudé wrote: Hi Corey, On 26/11/18 21:04, miny...@acm.org wrote: From: Corey Minyard It is never supposed to fail and cannot return an error, so just have it return the proper type. Have it return 0xff on nothing available, since that's what would

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on high core count ARM system

2018-11-26 Thread dann frazier
ext4 filesystem, SATA drive: (gdb) thread apply all bt Thread 3 (Thread 0x9bffc9a0 (LWP 9015)): #0 0xaaa462cc in __GI___sigtimedwait (set=, set@entry=0xe725c070, info=info@entry=0x9bffbf18, timeout=0x3ff1, timeout@entry=0x0) at

Re: [Qemu-devel] [PATCH v3 16/16] i2c:smbus_eeprom: Add a reset function to smbus_eeprom

2018-11-26 Thread Corey Minyard
On 11/26/18 5:01 PM, Philippe Mathieu-Daudé wrote: On 26/11/18 23:41, Corey Minyard wrote: On 11/26/18 2:42 PM, Philippe Mathieu-Daudé wrote: Hi Corey, On 26/11/18 21:04, miny...@acm.org wrote: From: Corey Minyard Reset the contents to init data and reset the offset on a machine reset.

Re: [Qemu-devel] [RFC 10/48] exec: export do_tb_flush

2018-11-26 Thread Emilio G. Cota
On Mon, Nov 26, 2018 at 11:11:53 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > On Thu, Nov 22, 2018 at 17:09:22 +, Alex Bennée wrote: > >> > >> Emilio G. Cota writes: > >> > >> > This will be used by plugin code to flush the code cache as well > >> > as doing other bookkeeping

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on high core count ARM system

2018-11-26 Thread John Snow
Hi, can you do a `thread apply all bt` instead? If I were to bet, we're probably waiting for some slow call like lseek to return in another thread. What filesystem/blockdevice is involved here? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] [PATCH 4/4] tcg: Add reachable_code_pass

2018-11-26 Thread Richard Henderson
Delete trivially dead code that follows unconditional branches and noreturn helpers. These can occur either via optimization or via the structure of a target's translator following an exception. Signed-off-by: Richard Henderson --- tcg/tcg.c | 76

[Qemu-devel] [PATCH 3/4] tcg: Reference count labels

2018-11-26 Thread Richard Henderson
Increment when adding branches, and decrement when removing them. Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 1 + tcg/tcg.h| 3 ++- tcg/tcg-op.c | 2 ++ tcg/tcg.c| 20 4 files changed, 25 insertions(+), 1 deletion(-) diff --git a/tcg/tcg-op.h

[Qemu-devel] [PATCH 1/4] tcg: Renumber TCG_CALL_* flags

2018-11-26 Thread Richard Henderson
Previously, the low 4 bits were used for TCG_CALL_TYPE_MASK, which was removed in 6a18ae2d2947532d5c26439548afa0481c4529f9. Signed-off-by: Richard Henderson --- tcg/tcg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 73737dc671..e94f805370

[Qemu-devel] [PATCH 2/4] tcg: Add TCG_CALL_NO_RETURN

2018-11-26 Thread Richard Henderson
Remember which helpers have been marked noreturn. Signed-off-by: Richard Henderson --- include/exec/helper-head.h | 13 + include/exec/helper-tcg.h | 21 ++--- tcg/tcg.h | 2 ++ 3 files changed, 29 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH 0/4] tcg: Remove unreachable code

2018-11-26 Thread Richard Henderson
I've been meaning to add a trivial cleanup pass like this for some time. There have occasionally been instaces within front ends wherein we want to raise an invalid operand exception (or some such) deep within a set of subroutines. And without a longjmp (or some such) back to the top level of

Re: [Qemu-devel] [PATCH v3 16/16] i2c:smbus_eeprom: Add a reset function to smbus_eeprom

2018-11-26 Thread Philippe Mathieu-Daudé
On 26/11/18 23:41, Corey Minyard wrote: > On 11/26/18 2:42 PM, Philippe Mathieu-Daudé wrote: >> Hi Corey, >> >> On 26/11/18 21:04, miny...@acm.org wrote: >>> From: Corey Minyard >>> >>> Reset the contents to init data and reset the offset on a machine >>> reset. >>> >>> Signed-off-by: Corey

[Qemu-devel] [Bug 1805256] [NEW] qemu-img hangs on high core count ARM system

2018-11-26 Thread dann frazier
Public bug reported: On the HiSilicon D06 system - a 96 core NUMA arm64 box - qemu-img frequently hangs (~50% of the time) with this command: qemu-img convert -f qcow2 -O qcow2 /tmp/cloudimg /tmp/cloudimg2 Where "cloudimg" is a standard qcow2 Ubuntu cloud image. This qcow2->qcow2 conversion

Re: [Qemu-devel] [RFC v1 15/23] riscv: tcg-target: Add branch and jump instructions

2018-11-26 Thread Alistair Francis
On Tue, Nov 20, 2018 at 11:40 PM Richard Henderson wrote: > > On 11/21/18 12:49 AM, Alistair Francis wrote: > > On Fri, Nov 16, 2018 at 1:14 AM Richard Henderson > > wrote: > >> > >> On 11/15/18 11:36 PM, Alistair Francis wrote: > >>> +static void tcg_out_brcond(TCGContext *s, TCGCond cond,

[Qemu-devel] [PATCH] apic: Make APIC ID limit error message clearer

2018-11-26 Thread Eduardo Habkost
Remove the "apic initialization failed" prefix (it conveys no useful information), replace "invalid" with "too large", and add an error hint with two possible solutions for the problem. Before: $ qemu-system-x86_64 -machine q35 -smp 256 qemu-system-x86_64: apic initialization failed. APIC ID

Re: [Qemu-devel] [PATCH 2/5] vhost-net-user: add stubs for when no virtio-net device is present

2018-11-26 Thread Philippe Mathieu-Daudé
On 26/11/18 23:43, Michael S. Tsirkin wrote: > On Mon, Nov 26, 2018 at 05:45:47PM +0100, Philippe Mathieu-Daudé wrote: >> On 26/11/18 14:20, Paolo Bonzini wrote: >>> hw/net/vhost_net.c needs functions that are declared in net/vhost-user.c: >>> the >>> vhost-user code is always compiled into QEMU,

Re: [Qemu-devel] [PATCH 2/5] vhost-net-user: add stubs for when no virtio-net device is present

2018-11-26 Thread Michael S. Tsirkin
On Mon, Nov 26, 2018 at 05:45:47PM +0100, Philippe Mathieu-Daudé wrote: > On 26/11/18 14:20, Paolo Bonzini wrote: > > hw/net/vhost_net.c needs functions that are declared in net/vhost-user.c: > > the > > vhost-user code is always compiled into QEMU, only the constructor > > net_init_vhost_user is

Re: [Qemu-devel] [PATCH v3 16/16] i2c:smbus_eeprom: Add a reset function to smbus_eeprom

2018-11-26 Thread Corey Minyard
On 11/26/18 2:42 PM, Philippe Mathieu-Daudé wrote: Hi Corey, On 26/11/18 21:04, miny...@acm.org wrote: From: Corey Minyard Reset the contents to init data and reset the offset on a machine reset. Signed-off-by: Corey Minyard --- hw/i2c/smbus_eeprom.c | 8 +++- 1 file changed, 7

Re: [Qemu-devel] [PATCH 0/5] vhost: enable for all targets

2018-11-26 Thread Michael S. Tsirkin
On Mon, Nov 26, 2018 at 02:20:38PM +0100, Paolo Bonzini wrote: > vhost does not have to be supported only if KVM is present, in fact > vhost-user does not even need any kind of kernel support. This series > changes this. The rationale is that, when vhost-user-test.c will be > converted to

Re: [Qemu-devel] [RFC PATCH v2 3/3] target/ppc: support single stepping with KVM HV

2018-11-26 Thread David Gibson
On Wed, Nov 21, 2018 at 04:13:47PM -0200, Fabiano Rosas wrote: > The hardware singlestep mechanism in POWER works via a Trace Interrupt > (0xd00) that happens after any instruction executes, whenever MSR_SE = > 1 (PowerISA Section 6.5.15 - Trace Interrupt). > > However, with kvm_hv, the Trace

[Qemu-devel] [Bug 1793859] Re: GTK display and mouse input area scaling fails when using vfio-pci device

2018-11-26 Thread tinywrkbee
Chen, have you seen the following bug report? https://bugs.launchpad.net/qemu/+bug/1592351 See my comment there, with recent git build of 3.1.0 I don't have a pointer offset issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2018-11-26 Thread Alexander Gretha
hi, i am probably trying to ride a dead horse here, but is there any chance this patch will make its way into master? thanks, alex -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1336794 Title:

Re: [Qemu-devel] [RFC 19/48] translate-all: notify plugin code of tb_flush

2018-11-26 Thread Emilio G. Cota
On Mon, Nov 26, 2018 at 11:02:24 +, Alex Bennée wrote: > Emilio G. Cota writes: > > On Fri, Nov 23, 2018 at 17:00:59 +, Alex Bennée wrote: > >> What is the purpose of letting the plugin know a flush has occurred? > > > > Plugins might allocate per-TB data that then they get passed each >

Re: [Qemu-devel] [PATCH for-3.2 v7 0/6] Connect a PCIe host and graphics support to RISC-V

2018-11-26 Thread Guenter Roeck
On Mon, Nov 26, 2018 at 11:34:58AM -0800, Palmer Dabbelt wrote: > On Thu, 22 Nov 2018 02:59:18 PST (-0800), abolo...@redhat.com wrote: > > On Wed, 2018-11-21 at 17:02 +, Alistair Francis wrote: > >> V7: > >> - Fix the GPEX memory mapping thanks to Bin Meng > >> - Fix the interrupt mapping

Re: [Qemu-devel] [PATCH] target: hax: fix a typo

2018-11-26 Thread Richard Henderson
On 11/26/18 1:25 PM, Philippe Mathieu-Daudé wrote: >>> - * 1. The hax_tunnel is also destroied when vcpu destroy >>> + * 1. The hax_tunnel is also destroyed when vcpu destroy > I'm not native english speaker. Isn't it: > > 'The hax_tunnel is also destroyed at vcpu destroy' > > or > >

Re: [Qemu-devel] [PATCH] target: hax: fix a typo

2018-11-26 Thread Philippe Mathieu-Daudé
Hi Li, Alex. On 26/11/18 12:51, Alex Bennée wrote: > > Li Qiang writes: > >> Cc: qemu-triv...@nongnu.org >> >> Signed-off-by: Li Qiang > > Reviewed-by: Alex Bennée > >> --- >> target/i386/hax-all.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

Re: [Qemu-devel] [PATCH] hw/hyperv: fix NULL dereference with pure-kvm SynIC

2018-11-26 Thread Eduardo Habkost
On Mon, Nov 26, 2018 at 06:13:49PM +0100, Paolo Bonzini wrote: > On 26/11/18 16:28, Roman Kagan wrote: > > When started in compat configuration of SynIC, e.g. > > > > qemu-system-x86_64 -machine pc-i440fx-2.10,accel=kvm \ > > -cpu host,-vmx,hv-relaxed,hv_spinlocks=0x1fff,hv-vpindex,hv-synic > >

[Qemu-devel] [PULL 2/2] hw/hyperv: fix NULL dereference with pure-kvm SynIC

2018-11-26 Thread Eduardo Habkost
From: Roman Kagan When started in compat configuration of SynIC, e.g. qemu-system-x86_64 -machine pc-i440fx-2.10,accel=kvm \ -cpu host,-vmx,hv-relaxed,hv_spinlocks=0x1fff,hv-vpindex,hv-synic or explicitly qemu-system-x86_64 -enable-kvm -cpu host,hv-synic,x-hv-synic-kvm-only=on QEMU crashes

[Qemu-devel] [PULL 1/2] kvm: Use KVM_GET_MSR_INDEX_LIST for MSR_IA32_ARCH_CAPABILITIES support

2018-11-26 Thread Eduardo Habkost
From: Bandan Das When writing to guest's MSR_IA32_ARCH_CAPABILITIES, check whether it's supported in the guest using the KVM_GET_MSR_INDEX_LIST ioctl. Fixes: d86f963694df27f11b3681ffd225c9362de1b634 Suggested-by: Eduardo Habkost Tested-by: baldu...@units.it Signed-off-by: Bandan Das

[Qemu-devel] [PULL 0/2] x86 fixes for -rc3

2018-11-26 Thread Eduardo Habkost
The following changes since commit d522fba24478474911b0e6e488b6d1dcf1af54f8: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20181126' into staging (2018-11-26 13:58:46 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/x86-for-3.1

Re: [Qemu-devel] [PATCH for-3.2 01/11] vhost-user: define conventions for vhost-user backends

2018-11-26 Thread Eric Blake
On 11/26/18 6:42 AM, Marc-André Lureau wrote: As discussed during "[PATCH v4 00/29] vhost-user for input & GPU" review, let's define a common set of backend conventions to help with management layer implementation, and interoperability. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P.

Re: [Qemu-devel] [PATCH v5 10/24] qapi: Define new QMP message for pvrdma

2018-11-26 Thread Eric Blake
On 11/26/18 4:01 AM, Markus Armbruster wrote: Yuval Shaia writes: pvrdma requires that the same GID attached to it will be attached to the backend device in the host. A new QMP messages is defined so pvrdma device can broadcast any change made to its GID table. This event is captured by

Re: [Qemu-devel] [PATCH v3 16/16] i2c:smbus_eeprom: Add a reset function to smbus_eeprom

2018-11-26 Thread Philippe Mathieu-Daudé
Hi Corey, On 26/11/18 21:04, miny...@acm.org wrote: > From: Corey Minyard > > Reset the contents to init data and reset the offset on a machine > reset. > > Signed-off-by: Corey Minyard > --- > hw/i2c/smbus_eeprom.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [PATCH v3 12/16] i2c:smbus_eeprom: Add normal type name and cast to smbus_eeprom.c

2018-11-26 Thread Philippe Mathieu-Daudé
On 26/11/18 21:04, miny...@acm.org wrote: > From: Corey Minyard > > Create a type name and a cast macro and use those through the > code. > > Signed-off-by: Corey Minyard > Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > hw/i2c/smbus_eeprom.c | 15 ++- >

Re: [Qemu-devel] [PATCH] [PATCH] Allow AArch64 processors to boot from a kernel placed over 4GB.

2018-11-26 Thread Peter Maydell
On Mon, 26 Nov 2018 at 19:15, Perez Blanco, Ricardo (Nokia - BE/Antwerp) wrote: > > Some machine based on AArch64 can have its main memory over 4GBs. With > the current path, these machines can support "-kernel" in qemu > > Signed-off-by: Ricardo Perez Blanco Does this fix an issue with one of

[Qemu-devel] [PATCH v3 16/16] i2c:smbus_eeprom: Add a reset function to smbus_eeprom

2018-11-26 Thread minyard
From: Corey Minyard Reset the contents to init data and reset the offset on a machine reset. Signed-off-by: Corey Minyard --- hw/i2c/smbus_eeprom.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index

Re: [Qemu-devel] [PATCH 2/5] The discard flag for block stream operation

2018-11-26 Thread Eric Blake
On 11/22/18 12:48 PM, Andrey Shinkevich wrote: Adding a parameter to QMP block-stream command to allow discarding blocks in the backing chain while blocks are being copied to the active layer. Signed-off-by: Andrey Shinkevich --- block/stream.c| 3 +-- blockdev.c

[Qemu-devel] [PATCH v3 05/16] i2c: Simplify and correct the SMBus state machine

2018-11-26 Thread minyard
From: Corey Minyard The SMBus slave code had an unneeded state, unnecessary function pointers and incorrectly handled quick commands. Rewrite it to simplify the code and make it work correctly. smbus_eeprom is the only user, so no other effects and the eeprom code also gets a significant

Re: [Qemu-devel] [PATCH v3 03/16] arm:i2c: Don't mask return from i2c_recv()

2018-11-26 Thread Philippe Mathieu-Daudé
On 26/11/18 21:04, miny...@acm.org wrote: > From: Corey Minyard > > It can't fail, and now that it returns a uint8_t a 0xff mask > is unnecessary. > > Signed-off-by: Corey Minyard > Suggested-by: Peter Maydell > --- > hw/arm/stellaris.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PATCH v3 13/16] i2c:smbus_eeprom: Add a size constant for the smbus_eeprom size

2018-11-26 Thread minyard
From: Corey Minyard It was hard-coded to 256 in a number of places, create a constant for that. Signed-off-by: Corey Minyard Reviewed-by: Philippe Mathieu-Daudé --- hw/i2c/smbus_eeprom.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/i2c/smbus_eeprom.c

Re: [Qemu-devel] [PATCH v3 06/16] i2c: Add a length check to the SMBus write handling

2018-11-26 Thread Philippe Mathieu-Daudé
On 26/11/18 21:04, miny...@acm.org wrote: > From: Corey Minyard > > Avoid an overflow. > > Signed-off-by: Corey Minyard > Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > hw/i2c/smbus_slave.c | 6 +- > 1 file changed, 5

[Qemu-devel] [PATCH v3 12/16] i2c:smbus_eeprom: Add normal type name and cast to smbus_eeprom.c

2018-11-26 Thread minyard
From: Corey Minyard Create a type name and a cast macro and use those through the code. Signed-off-by: Corey Minyard Reviewed-by: Peter Maydell --- hw/i2c/smbus_eeprom.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/i2c/smbus_eeprom.c

  1   2   3   4   >