Re: [Qemu-devel] [RFC PATCH] fpu: add compile time check for old glibc/libm and fma

2018-12-21 Thread Aleksandar Markovic
On Dec 20, 2018 12:11 PM, "Alex Bennée" wrote: > > Some versions of glibc have been reported to have problems with > fused-multiply-accumulate operations. If the underlying fma > implementation does a two step operation it will instroduce subtle > rounding errors. Newer versions of the library

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2018-12-21 Thread Yu Zhang
On Fri, Dec 21, 2018 at 02:02:28PM -0500, Michael S. Tsirkin wrote: > On Sat, Dec 22, 2018 at 01:37:58AM +0800, Yu Zhang wrote: > > On Fri, Dec 21, 2018 at 12:04:49PM -0500, Michael S. Tsirkin wrote: > > > On Sat, Dec 22, 2018 at 12:09:44AM +0800, Yu Zhang wrote: > > > > Well, my understanding of

Re: [Qemu-devel] [PATCH] i386: remove the 'INTEL_PT' CPUID bit from named CPU models

2018-12-21 Thread Robert Hoo
On Fri, 2018-12-21 at 16:27 +0100, Paolo Bonzini wrote: > On 21/12/18 16:22, Philippe Mathieu-Daudé wrote: > > Hi Paolo, > > > > On 12/21/18 7:30 AM, Paolo Bonzini wrote: > > > From: Robert Hoo > > > > > > Processor tracing is not yet implemented for KVM and it will be > > > an > > > opt in

Re: [Qemu-devel] [PATCH 1/2] i386: remove the new CPUID 'PCONFIG' from Icelake-Server CPU model

2018-12-21 Thread Robert Hoo
On Fri, 2018-12-21 at 16:03 +0100, Paolo Bonzini wrote: > On 21/12/18 15:04, Robert Hoo wrote: > > > So this series is correct and I will follow up with one for > > > INTEL_PT; > > > however, this begs the question of how the patches are being > > > tested. > > > > My apologies for carelessness.

Re: [Qemu-devel] [PATCH v3 2/2] intel-iommu: extend VTD emulation to allow 57-bit IOVA address width.

2018-12-21 Thread Yu Zhang
On Fri, Dec 21, 2018 at 01:10:13PM -0500, Michael S. Tsirkin wrote: > On Sat, Dec 22, 2018 at 01:34:01AM +0800, Yu Zhang wrote: > > On Fri, Dec 21, 2018 at 12:15:26PM -0500, Michael S. Tsirkin wrote: > > > On Sat, Dec 22, 2018 at 12:19:20AM +0800, Yu Zhang wrote: > > > > > I'd like to avoid poking

[Qemu-devel] [PATCH 2/3] iotests: Bind qemu-nbd to localhost in 147

2018-12-21 Thread Max Reitz
By default, qemu-nbd binds to 0.0.0.0. However, we then proceed to connect to "localhost". Usually, this works out fine; but if this test is run concurrently, some other test function may have bound a different server to ::1 (on the same port -- you can bind different serves to the same port, as

[Qemu-devel] [PATCH 1/3] iotests.py: Add qemu_nbd_pipe()

2018-12-21 Thread Max Reitz
In some cases, we may want to deal with qemu-nbd errors (e.g. by launching it in a different configuration until it no longer throws any). In that case, we do not want its output ending up in the test output. It may still be useful for handling the error, though, so add a new function that works

[Qemu-devel] [PATCH 3/3] iotests: Allow 147 to be run concurrently

2018-12-21 Thread Max Reitz
To do this, we need to allow creating the NBD server on various ports instead of a single one (which may not even work if you run just one instance, because something entirely else might be using that port). So we just pick a random port in [32768, 32768 + 1024) and try to create a server there.

[Qemu-devel] [PATCH 0/3] iotests: Allow 147 to be run concurrently

2018-12-21 Thread Max Reitz
147 currently cannot be run concurrently for two reasons: (1) It creates TCP/IP NBD servers on a fixed port. (2) It uses a mix of "0.0.0.0", "localhost", and "::1" as host addresses to bind to. As explained in the commit messages of patches 2 and 3, this results in it potentially

[Qemu-devel] Segfaults in chardev due to races

2018-12-21 Thread Max Reitz
Hi, While fixing iotest 147 (which currently cannot be run in parallel), I've noticed that after it's fixed (and does run in parallel), I see some segfaults in chardev/char-socket.c. They usually look like this: #0 0x556f3b5765d0 in object_get_class (obj=obj@entry=0x0) at qom/object.c:822

[Qemu-devel] [RFC v2 2/4] elf-ops.h: Add get_elf_note_type()

2018-12-21 Thread Liam Merwick
Introduce a routine which, given a pointer to a range of ELF Notes, searches through them looking for a note matching the type specified and returns a pointer to the matching ELF note. Signed-off-by: Liam Merwick --- include/hw/elf_ops.h | 50 ++

Re: [Qemu-devel] [RFC PATCH] fpu: add compile time check for old glibc/libm and fma

2018-12-21 Thread Richard Henderson
On 12/21/18 11:30 AM, Emilio G. Cota wrote: > +ua.s = 0x0021; > +ub.s = 0x3ca0; > +uc.s = 0x0020; > +ur.h = fma(ua.h, ub.h, uc.h); > +if (ur.s != 0x0021) { Forgot your ull's, but otherwise ok. In email to Alex, I did wonder if

[Qemu-devel] [PATCH 3/3] If raw DB values are known, use them in paaudio

2018-12-21 Thread Yaroslav Isakov
Signed-off-by: Yaroslav Isakov --- audio/paaudio.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 4c100bc318..d25df102ab 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -724,8 +724,13 @@ static int qpa_ctl_out

[Qemu-devel] [PATCH 2/3] Pass raw DB values from hda-codec.c to audio driver

2018-12-21 Thread Yaroslav Isakov
Signed-off-by: Yaroslav Isakov --- hw/audio/hda-codec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c index 09f9da344b..d160e86d2a 100644 --- a/hw/audio/hda-codec.c +++ b/hw/audio/hda-codec.c @@ -437,6 +437,7 @@ static

[Qemu-devel] [PATCH 1/3] Allow audio driver to pass DB value to underlying drivers

2018-12-21 Thread Yaroslav Isakov
Signed-off-by: Yaroslav Isakov --- audio/audio.c | 15 +-- audio/audio.h | 6 -- audio/mixeng.h | 6 -- hw/audio/ac97.c | 4 ++-- hw/audio/hda-codec-common.h | 2 +- hw/audio/hda-codec.c| 8 ++--

[Qemu-devel] [PATCH 0/3] Allow hw/audio drivers to pass raw DB values to audio/ drivers

2018-12-21 Thread Yaroslav Isakov
This patch series introduces the ability for virtual audio drivers to pass information about guest-chosen DB values to backend audio drivers. For now, supported virtual driver is hda-codec, and backend is pulseaudio, as they both support DB values. Without these patches, emulated Windows has a

Re: [Qemu-devel] [PATCH 2/3] Pass raw DB values from hda-codec.c to audio driver

2018-12-21 Thread Yaroslav Isakov
Sorry, lost cover letter and first patch, resending them пт, 21 дек. 2018 г. в 21:57, Yaroslav Isakov : > > Signed-off-by: Yaroslav Isakov > --- > hw/audio/hda-codec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c >

Re: [Qemu-devel] [RFC 2/3] pc: Read PVH entry point from ELF note in kernel binary

2018-12-21 Thread Liam Merwick
Thanks Stefan for the review - comments inline. On 11/12/2018 14:17, Stefan Hajnoczi wrote: On Wed, Dec 05, 2018 at 10:37:25PM +, Liam Merwick wrote: From: Liam Merwick Add support to read the PVH Entry address from an ELF note in the uncompressed kernel binary (as defined by the x86/HVM

[Qemu-devel] [PATCH 3/3] If raw DB values are known, use them in paaudio

2018-12-21 Thread Yaroslav Isakov
Signed-off-by: Yaroslav Isakov --- audio/paaudio.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 4c100bc318..d25df102ab 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -724,8 +724,13 @@ static int qpa_ctl_out

[Qemu-devel] [PATCH 0/3] Allow hw/audio drivers to pass raw DB values to audio/ drivers

2018-12-21 Thread Yaroslav Isakov
This patch series introduces the ability for virtual audio drivers to pass information about guest-chosen DB values to backend audio drivers. For now, supported virtual driver is hda-codec, and backend is pulseaudio, as they both support DB values. Without these patches, emulated Windows has a

[Qemu-devel] [PATCH 1/3] Allow audio driver to pass DB value to underlying drivers

2018-12-21 Thread Yaroslav Isakov
Signed-off-by: Yaroslav Isakov --- audio/audio.c | 15 +-- audio/audio.h | 6 -- audio/mixeng.h | 6 -- hw/audio/ac97.c | 4 ++-- hw/audio/hda-codec-common.h | 2 +- hw/audio/hda-codec.c| 8 ++--

[Qemu-devel] [PATCH 2/3] Pass raw DB values from hda-codec.c to audio driver

2018-12-21 Thread Yaroslav Isakov
Signed-off-by: Yaroslav Isakov --- hw/audio/hda-codec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c index 09f9da344b..d160e86d2a 100644 --- a/hw/audio/hda-codec.c +++ b/hw/audio/hda-codec.c @@ -437,6 +437,7 @@ static

Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2018-12-21 Thread Peter Maydell
On Fri, 21 Dec 2018 at 12:40, Paolo Bonzini wrote: > > The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 > 14:31:06 +) > > are available in the git

[Qemu-devel] [RFC v2 4/4] pvh: Boot uncompressed kernel using direct boot ABI

2018-12-21 Thread Liam Merwick
These changes (along with corresponding Linux kernel and qboot changes) enable a guest to be booted using the x86/HVM direct boot ABI. This commit adds a load_elfboot() routine to pass the size and location of the kernel entry point to qboot (which will fill in the start_info struct information

[Qemu-devel] [RFC v2 0/4] QEMU changes to do PVH boot

2018-12-21 Thread Liam Merwick
For certain applications it is desirable to rapidly boot a KVM virtual machine. In cases where legacy hardware and software support within the guest is not needed, QEMU should be able to boot directly into the uncompressed Linux kernel binary with minimal firmware involvement. There already

[Qemu-devel] [RFC v2 1/4] elf: Add optional function ptr to load_elf() to parse ELF notes

2018-12-21 Thread Liam Merwick
This patch adds an optional function pointer, 'elf_note_fn', to load_elf() which causes load_elf() to additionally parse any ELF program headers of type PT_NOTE and check to see if the ELF Note is of the type specified by the 'translate_opaque' arg. If a matching ELF Note is found then the

Re: [Qemu-devel] [RFC 1/3] pvh: Add x86/HVM direct boot ABI header file

2018-12-21 Thread Liam Merwick
On 11/12/2018 14:57, Liam Merwick wrote: On 11/12/2018 14:01, Stefan Hajnoczi wrote: On Wed, Dec 05, 2018 at 10:37:24PM +, Liam Merwick wrote: From: Liam Merwick The x86/HVM direct boot ABI permits Qemu to be able to boot directly into the uncompressed Linux kernel binary without the

Re: [Qemu-devel] [PATCH v6 09/11] iotests: change qmp_log filters to expect QMP objects only

2018-12-21 Thread John Snow
On 12/21/18 7:41 AM, Vladimir Sementsov-Ogievskiy wrote: > Hmm. This made me check, is enumerate applicable to dicts, > and, yes it is. > enumerate on dicts gives you a numerical index paired with the key, so... k is the numerical index and v is the key. > so, it may be as easy as > >

Re: [Qemu-devel] [RFC PATCH] fpu: add compile time check for old glibc/libm and fma

2018-12-21 Thread Emilio G. Cota
On Thu, Dec 20, 2018 at 11:10:08 +, Alex Bennée wrote: (snip) > +#if defined(__GLIBC__) && (__GLIBC__ == 2 && __GLIBC_MINOR__ <= 12) > +#define QEMU_HARDFLOAT_USE_FMA 0 > +#else > +#define QEMU_HARDFLOAT_USE_FMA 1 > +#endif > +#else > +#define QEMU_HARDFLOAT_USE_FMA 1 > +#endif > + > /* > *

[Qemu-devel] [Bug 1809304] Re: qemu-img convert is freezing for some DMG files.

2018-12-21 Thread Julio Faracco
I'm almost sure that we need other improvements beyond fixing binary search deadlock. It is returning read errors when you apply your patch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1809304

[Qemu-devel] [RFC v2 3/4] pvh: Add x86/HVM direct boot ABI header file

2018-12-21 Thread Liam Merwick
From: Liam Merwick The x86/HVM direct boot ABI permits Qemu to be able to boot directly into the uncompressed Linux kernel binary with minimal firmware involvement. https://xenbits.xen.org/docs/unstable/misc/pvh.html This commit adds the header file that defines the start_info struct

Re: [Qemu-devel] [PULL 00/40] ppc-for-4.0 queue 20181221

2018-12-21 Thread Peter Maydell
in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.0-20181221 > > for you to fetch changes up to b62c6e1237fb5ca2563f7e72b66ac0c40ff7a714: > > MAINTAINERS: PPC: add a XIVE section (2018-12-21 09:40:43 +1100) > > -

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2018-12-21 Thread Eduardo Habkost
On Fri, Dec 21, 2018 at 02:02:28PM -0500, Michael S. Tsirkin wrote: > On Sat, Dec 22, 2018 at 01:37:58AM +0800, Yu Zhang wrote: > > On Fri, Dec 21, 2018 at 12:04:49PM -0500, Michael S. Tsirkin wrote: > > > On Sat, Dec 22, 2018 at 12:09:44AM +0800, Yu Zhang wrote: > > > > Well, my understanding of

[Qemu-devel] [PATCH 0/2] fp-bench fixes

2018-12-21 Thread Emilio G. Cota
Two small fixes for fp-bench. They fix the fact that we weren't generating normals, even though we intended to. You can pull this series from: https://github.com/cota/qemu/tree/fp-bench-fixes Thanks, Emilio

[Qemu-devel] [PATCH 1/2] fp-bench: fix update_random_ops

2018-12-21 Thread Emilio G. Cota
The second test in the branches is wrong; fix while converting to a switch statement, which is easier to get right. Signed-off-by: Emilio G. Cota --- tests/fp/fp-bench.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c

[Qemu-devel] [PATCH 2/2] fp-bench: remove wrong exponent raise in fill_random

2018-12-21 Thread Emilio G. Cota
At this point random_ops[] only contains normals, so there's no need to do anything to them. In fact, raising the exponent here can make the output !normal, which is precisely what the comment says we want to avoid. Signed-off-by: Emilio G. Cota --- tests/fp/fp-bench.c | 4 1 file changed,

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2018-12-21 Thread Michael S. Tsirkin
On Sat, Dec 22, 2018 at 01:37:58AM +0800, Yu Zhang wrote: > On Fri, Dec 21, 2018 at 12:04:49PM -0500, Michael S. Tsirkin wrote: > > On Sat, Dec 22, 2018 at 12:09:44AM +0800, Yu Zhang wrote: > > > Well, my understanding of the vt-d spec is that the address limitation in > > > DMAR are referring to

[Qemu-devel] [PATCH] iotests: Make 234 stable

2018-12-21 Thread Max Reitz
This test waits for a MIGRATION event with status=completed on the source VM before querying the migration status on both source and destination. However, just because the source says migration has completed does not mean the destination thinks the same. Therefore, in some cases, the destination

Re: [Qemu-devel] travis failures

2018-12-21 Thread Emilio G. Cota
On Fri, Dec 21, 2018 at 11:26:34 +0100, Greg Kurz wrote: > On Fri, 21 Dec 2018 09:36:23 +0100 > Greg Kurz wrote: > > > On Fri, 21 Dec 2018 07:47:07 +0100 > > Thomas Huth wrote: > > > > > On 2018-12-21 04:06, Alexey Kardashevskiy wrote: > > > > Hi > > > > > > > > I am trying

Re: [Qemu-devel] [PATCH v3 2/2] intel-iommu: extend VTD emulation to allow 57-bit IOVA address width.

2018-12-21 Thread Michael S. Tsirkin
On Sat, Dec 22, 2018 at 01:34:01AM +0800, Yu Zhang wrote: > On Fri, Dec 21, 2018 at 12:15:26PM -0500, Michael S. Tsirkin wrote: > > On Sat, Dec 22, 2018 at 12:19:20AM +0800, Yu Zhang wrote: > > > > I'd like to avoid poking at the CPU from VTD code. That's all. > > > > > > OK. So for the short

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2018-12-21 Thread Yu Zhang
On Fri, Dec 21, 2018 at 12:04:49PM -0500, Michael S. Tsirkin wrote: > On Sat, Dec 22, 2018 at 12:09:44AM +0800, Yu Zhang wrote: > > Well, my understanding of the vt-d spec is that the address limitation in > > DMAR are referring to the same concept of CPUID.MAXPHYSADDR. I do not think > > there's

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/15] ppc/spapr: Receive and store device tree blob from SLOF

2018-12-21 Thread Murilo Opsfelder Araujo
On Fri, Dec 21, 2018 at 01:34:48AM +0100, Greg Kurz wrote: > From: Alexey Kardashevskiy > > SLOF receives a device tree and updates it with various properties > before switching to the guest kernel and QEMU is not aware of any changes > made by SLOF. Since there is no real RTAS (QEMU implements

Re: [Qemu-devel] [PATCH v3 2/2] intel-iommu: extend VTD emulation to allow 57-bit IOVA address width.

2018-12-21 Thread Yu Zhang
On Fri, Dec 21, 2018 at 12:15:26PM -0500, Michael S. Tsirkin wrote: > On Sat, Dec 22, 2018 at 12:19:20AM +0800, Yu Zhang wrote: > > > I'd like to avoid poking at the CPU from VTD code. That's all. > > > > OK. So for the short term,how about I remove the check of host cpu, and add > > a TODO > >

[Qemu-devel] possible leak in bios-tables-test.c

2018-12-21 Thread Igor Mammedov
When running test under valgrind it spits out a bunch of still reachable allocations. most of them are glib g_test related but there is one that belong to the test itself. I've found why it happens so reporting in hope that someone else would be able to track it down. reproducer: make && make

Re: [Qemu-devel] [PATCH v3 2/2] intel-iommu: extend VTD emulation to allow 57-bit IOVA address width.

2018-12-21 Thread Michael S. Tsirkin
On Sat, Dec 22, 2018 at 12:19:20AM +0800, Yu Zhang wrote: > > I'd like to avoid poking at the CPU from VTD code. That's all. > > OK. So for the short term,how about I remove the check of host cpu, and add a > TODO > in the comments in vtd_decide_config()? My question would be what happens on

[Qemu-devel] [PATCH v6 3/3] not-for-commit: example of new command usage for debugging

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/222 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222 index 0ead56d574..91d88aa5c0 100644 --- a/tests/qemu-iotests/222 +++ b/tests/qemu-iotests/222 @@ -137,6 +137,8 @@ with

[Qemu-devel] [PATCH v6 1/3] qapi: add x-debug-query-block-graph

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
Add a new command, returning block nodes (and their users) graph. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 108 include/block/block.h | 1 + include/sysemu/block-backend.h | 2 + block.c| 148

[Qemu-devel] [PATCH v6 0/3] block nodes graph visualization

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
Hi all! On the way of backup schemes development (and in general any complicated developments in Qemu block layer) it would be good to have an ability to print out graph of block nodes with their permissions. v6: s/3.1/4.0 v5: 01: fix !name -> !*name for checking the result of blk_name

[Qemu-devel] [PATCH v6 2/3] scripts: add render_block_graph function for QEMUMachine

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
Render block nodes graph with help of graphviz. This new function is for debugging, so there is no sense to put it into qemu.py as a method of QEMUMachine. Let's instead put it separately. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Eduardo Habkost Reviewed-by: Max Reitz ---

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2018-12-21 Thread Michael S. Tsirkin
On Sat, Dec 22, 2018 at 12:09:44AM +0800, Yu Zhang wrote: > Well, my understanding of the vt-d spec is that the address limitation in > DMAR are referring to the same concept of CPUID.MAXPHYSADDR. I do not think > there's any different in the native scenario. :) I think native machines exist on

[Qemu-devel] [PATCH v3 0/2] improve block-latency-histogram-set

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
Support QOM path for block-latency-histogram-set and drop x- prefix. Libvirt discussion (not yet updated for using id instead of device): https://www.redhat.com/archives/libvir-list/2018-September/msg00011.html v3: rebase on master, s/3.1/4.0. v2: id,device -> id (with fall back to device name)

[Qemu-devel] [PATCH v3 2/2] qapi: drop x- from x-block-latency-histogram-set

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
Drop x- and x_ prefixes for latency histograms and update version to 3.1 Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 20 ++-- block/qapi.c | 12 ++-- blockdev.c | 2 +- 3 files changed, 17 insertions(+), 17 deletions(-) diff

[Qemu-devel] [PATCH v3 1/2] qapi: move to QOM path for x-block-latency-histogram-set

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
Move to way of device selecting, however fall back to device name if path is not found. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 4 ++-- blockdev.c | 22 +++--- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.

2018-12-21 Thread Peter Maydell
On Fri, 21 Dec 2018 at 16:13, Nick Hudson wrote: > > ping Thanks for the ping. This is on my to-review list but I'm not going to be doing any code review until after I get back to work in January now... thanks -- PMM

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-21 Thread Michael S. Tsirkin
On Fri, Dec 21, 2018 at 11:18:18AM +0800, Yi Zhang wrote: > On 2018-12-20 at 09:06:41 -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 20, 2018 at 01:37:40PM +0800, Yi Zhang wrote: > > > On 2018-12-19 at 22:42:07 -0500, Michael S. Tsirkin wrote: > > > > On Thu, Dec 20, 2018 at 11:03:12AM +0800, Yi

Re: [Qemu-devel] [PATCH v2 0/2] improve block-latency-histogram-set

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
21.12.2018 19:31, Vladimir Sementsov-Ogievskiy wrote: > ping oops, should s/3.1/4.0 > > 12.10.2018 16:15, Vladimir Sementsov-Ogievskiy wrote: >> Support QOM path for block-latency-histogram-set and drop x- prefix. >> >> Libvirt discussion (not yet updated for using id instead of device): >>

Re: [Qemu-devel] [PATCH v2 0/2] improve block-latency-histogram-set

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
ping 12.10.2018 16:15, Vladimir Sementsov-Ogievskiy wrote: > Support QOM path for block-latency-histogram-set and drop x- prefix. > > Libvirt discussion (not yet updated for using id instead of device): > https://www.redhat.com/archives/libvir-list/2018-September/msg00011.html > > v2: id,device

Re: [Qemu-devel] [PATCH 03/15] pci: allow cleanup/unregistration of PCI root buses

2018-12-21 Thread Michael S. Tsirkin
On Fri, Dec 21, 2018 at 01:35:30AM +0100, Greg Kurz wrote: > From: Michael Roth > > This adds cleanup counterparts to pci_register_root_bus(), > pci_root_bus_new(), and pci_bus_irqs(). > > These cleanup routines are needed in the case of hotpluggable > PCIHostBridge implementations. Currently

Re: [Qemu-devel] [PATCH v3 2/2] intel-iommu: extend VTD emulation to allow 57-bit IOVA address width.

2018-12-21 Thread Yu Zhang
On Thu, Dec 20, 2018 at 01:28:21PM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 20, 2018 at 01:49:21PM +0800, Yu Zhang wrote: > > On Wed, Dec 19, 2018 at 10:23:44AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 19, 2018 at 01:57:43PM +0800, Yu Zhang wrote: > > > > On Tue, Dec 18, 2018 at

Re: [Qemu-devel] [PATCH v3] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.

2018-12-21 Thread Nick Hudson
ping On 11/12/2018 12:27, Nick Hudson wrote: noload kernels are loaded with the u-boot image header and as a result the header size needs adding to the entry point.  Fake up a hdr so the kernel image is loaded at the right address and the entry point is adjusted appropriately. The bootloader

Re: [Qemu-devel] [PATCH for-4.0 v4 4/4] i386: allow to load initrd below 4G for recent linux

2018-12-21 Thread Michael S. Tsirkin
On Thu, Dec 06, 2018 at 10:32:13AM +0800, Li Zhijian wrote: > a new field xloadflags was added to recent x86 linux, and BIT 1: > XLF_CAN_BE_LOADED_ABOVE_4G is used to tell bootload that where initrd can be > loaded safely. > > Current QEMU/BIOS always loads initrd below below_4g_mem_size which is

[Qemu-devel] [PULL 06/14] sifive_u: Set 'clock-frequency' DT property for SiFive UART

2018-12-21 Thread Palmer Dabbelt
From: Anup Patel The 'clock-frequency' DT property is required by U-Boot to compute the divider value. This patch sets the 'clock-frequency' DT property of the SiFive UART device tree node (similar to virt machine). Signed-off-by: Anup Patel Signed-off-by: Anup Patel Signed-off-by: Alistair

Re: [Qemu-devel] [PATCH v11 09/10] qcow2: skip writing zero buffers to empty COW areas

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
18.12.2018 10:57, Anton Nefedov wrote: > If COW areas of the newly allocated clusters are zeroes on the backing image, > efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole > cluster instead of writing explicit zero buffers later in perform_cow(). > > iotest 060: > write

[Qemu-devel] [PULL 11/14] sifive_uart: Implement interrupt pending register

2018-12-21 Thread Palmer Dabbelt
From: Nathaniel Graff The watermark bits are set in the interrupt pending register according to the configuration of txcnt and rxcnt in the txctrl and rxctrl registers. Since the UART TX does not implement a FIFO, the txwm bit is set as long as the TX watermark level is greater than zero.

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2018-12-21 Thread Yu Zhang
On Fri, Dec 21, 2018 at 03:13:25PM +0100, Igor Mammedov wrote: > On Thu, 20 Dec 2018 19:18:01 -0200 > Eduardo Habkost wrote: > > > On Wed, Dec 19, 2018 at 11:40:37AM +0100, Igor Mammedov wrote: > > > On Wed, 19 Dec 2018 10:57:17 +0800 > > > Yu Zhang wrote: > > > > > > > On Tue, Dec 18, 2018

Re: [Qemu-devel] [PATCH for-4.0 v4 3/4] i386: import & use bootparam.h

2018-12-21 Thread Michael S. Tsirkin
On Thu, Dec 06, 2018 at 10:32:12AM +0800, Li Zhijian wrote: > it's from v4.20-rc5. > > CC: Michael S. Tsirkin > Signed-off-by: Li Zhijian Reviewed-by: Michael S. Tsirkin > --- > V4: use scirpt to import bootparam.h (Michael S. Tsirkin) > V3: new patch > > Signed-off-by: Li Zhijian > --- >

Re: [Qemu-devel] [PATCH for-4.0 v4 2/4] refactor load_image_size

2018-12-21 Thread Michael S. Tsirkin
On Thu, Dec 06, 2018 at 10:32:11AM +0800, Li Zhijian wrote: > Don't expect read(2) can always read as many as it's told. > > Signed-off-by: Li Zhijian > Reviewed-by: Richard Henderson This is more a theoretical bugfix than a refactoring right? > --- > V4: add reviewed-by tag > --- >

[Qemu-devel] [PULL 07/14] RISC-V: Add hartid and \n to interrupt logging

2018-12-21 Thread Palmer Dabbelt
From: Michael Clark Add carriage return that was erroneously removed when converting to qemu_log. Change hard coded core number to the actual hartid. Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Palmer Dabbelt Cc: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Alistair

[Qemu-devel] [PULL 08/14] RISC-V: Fix CLINT timecmp low 32-bit writes

2018-12-21 Thread Palmer Dabbelt
From: Michael Clark A missing shift made updates to the low order bits of timecmp erroneously copy the old low order bits into the high order bits of the 64-bit timecmp register. Add the missing shift and rename timecmp local variables to timecmp_hi and timecmp_lo. This bug didn't show up as

[Qemu-devel] [PULL 10/14] RISC-V: Enable second UART on sifive_e and sifive_u

2018-12-21 Thread Palmer Dabbelt
From: Michael Clark Previously the second UARTs on the sifive_e and sifive_u machines where disabled due to check-qtest-riscv32 and check-qtest-riscv64 failures. Recent changes in the QEMU core serial code have resolved these failures so the second UARTs can be instantiated. Cc: Palmer Dabbelt

[Qemu-devel] [PULL 13/14] riscv/cpu: use device_class_set_parent_realize

2018-12-21 Thread Palmer Dabbelt
From: Mao Zhongyi Signed-off-by: Mao Zhongyi Reviewed-by: Bastian Koppelmann Reviewed-by: Alistair Francis Signed-off-by: Palmer Dabbelt --- target/riscv/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index

[Qemu-devel] [PULL 09/14] RISC-V: Fix PLIC pending bitfield reads

2018-12-21 Thread Palmer Dabbelt
From: Michael Clark The address calculation for the pending bitfield had a copy paste bug. This bug went unnoticed because the Linux PLIC driver does not read the pending bitfield, rather it reads pending interrupt numbers from the claim register and writes acknowledgements back to the claim

[Qemu-devel] [PULL 14/14] MAINTAINERS: Mark RISC-V as Supported

2018-12-21 Thread Palmer Dabbelt
There's at least two of us that are paid to work on this. Reviewed-by: Alistair Francis Signed-off-by: Palmer Dabbelt --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d676c73f8840..317eff6cec4d 100644 --- a/MAINTAINERS +++

[Qemu-devel] [PULL 03/14] hw/riscv/virt: Connect the gpex PCIe

2018-12-21 Thread Palmer Dabbelt
From: Alistair Francis Connect the gpex PCIe device based on the device tree included in the HiFive Unleashed ROM. Signed-off-by: Alistair Francis Signed-off-by: Logan Gunthorpe Reviewed-by: Logan Gunthorpe Tested-by: Guenter Roeck Tested-by: Andrea Bolognani Signed-off-by: Palmer Dabbelt

[Qemu-devel] [PULL 05/14] sifive_u: Add clock DT node for GEM ethernet

2018-12-21 Thread Palmer Dabbelt
From: Anup Patel The GEM ethernet on SiFive unleashed has fixed input clock of 125MHz as-per SiFive FU540 manual. This patch updates FDT generation for QEMU sifive_u machine to provide fixed-rate clock for GEM ethernet. Signed-off-by: Anup Patel Signed-off-by: Anup Patel Signed-off-by:

[Qemu-devel] [PULL 12/14] target/riscv/pmp.c: Fix pmp_decode_napot()

2018-12-21 Thread Palmer Dabbelt
From: Anup Patel Currently, start and end address of a PMP region are not decoded correctly by pmp_decode_napot(). Let's say we have a 128KB PMP region with base address as 0x8000. Now, the PMPADDRx CSR value for this region will be 0x20003fff. The current pmp_decode_napot() implementation

[Qemu-devel] [PULL 02/14] hw/riscv/virt: Adjust memory layout spacing

2018-12-21 Thread Palmer Dabbelt
From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Logan Gunthorpe Tested-by: Guenter Roeck Tested-by: Andrea Bolognani Signed-off-by: Palmer Dabbelt --- hw/riscv/virt.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/riscv/virt.c

[Qemu-devel] [PULL 01/14] hw/riscv/virt: Increase the number of interrupts

2018-12-21 Thread Palmer Dabbelt
From: Alistair Francis Increase the number of interrupts to match the HiFive Unleashed board. Signed-off-by: Alistair Francis Tested-by: Guenter Roeck Tested-by: Andrea Bolognani Signed-off-by: Palmer Dabbelt --- include/hw/riscv/virt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PR RFC] RISC-V Changes for 3.2, Part 1

2018-12-21 Thread Palmer Dabbelt
The following changes since commit b72566a4ffaddbc0c0c1f6f5ee91b42ab13ff429: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2018-12-19 15:31:02 +) are available in the Git repository at: git://github.com/palmer-dabbelt/qemu.git

[Qemu-devel] [PULL 04/14] riscv: Enable VGA and PCIE_VGA

2018-12-21 Thread Palmer Dabbelt
From: Alistair Francis Enable compile support for VGA devices. This allows the user to conenct a display by adding '-device bochs-display -display sdl' to their command line argument. Signed-off-by: Alistair Francis Reviewed-by: Logan Gunthorpe Tested-by: Andrea Bolognani Signed-off-by:

Re: [Qemu-devel] [PULL v3 00/44] pci, pc, virtio: fixes, features

2018-12-21 Thread Peter Maydell
On Thu, 20 Dec 2018 at 18:37, Michael S. Tsirkin wrote: > > The following changes since commit b72566a4ffaddbc0c0c1f6f5ee91b42ab13ff429: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2018-12-19 > 15:31:02 +) > > are available in the

Re: [Qemu-devel] [PATCH v7 26/28] qdev-props: call object_apply_global_props()

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:04:08 +0400 Marc-André Lureau wrote: > It's now possible to use the common function. > > Teach object_apply_global_props() to warn if Error argument is NULL. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Igor Mammedov > --- > hw/core/qdev-properties.c | 24

Re: [Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:04:07 +0400 Marc-André Lureau wrote: > All qdev_prop_register_global() set _fatal for errp, except > '-rtc driftfix=slew', which arguably should also use _fatal, as > otherwise failing to apply the property would only report a warning. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v7 24/28] qdev-props: convert global_props to GPtrArray

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:04:06 +0400 Marc-André Lureau wrote: > A step towards being able to call a common function, > object_apply_global_props(). > > Signed-off-by: Marc-André Lureau > Reviewed-by: Igor Mammedov > --- > hw/core/qdev-properties.c | 29 - > 1 file

Re: [Qemu-devel] [PATCH] i386: remove the 'INTEL_PT' CPUID bit from named CPU models

2018-12-21 Thread Paolo Bonzini
On 21/12/18 16:22, Philippe Mathieu-Daudé wrote: > Hi Paolo, > > On 12/21/18 7:30 AM, Paolo Bonzini wrote: >> From: Robert Hoo >> >> Processor tracing is not yet implemented for KVM and it will be an >> opt in feature requiring a special module parameter. >> Disable it, because it is wrong to

Re: [Qemu-devel] [PATCH v7 23/28] qdev: all globals are now user-provided

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:04:05 +0400 Marc-André Lureau wrote: > All globals are now either provided via -global or through -cpu > features (CPU features are implemented by registering globals). > > If the global isn't being used, it should warn in either case. > > We can thus consider that all

Re: [Qemu-devel] [PATCH] hw/pci-bridge: check invalid slot number for root and downstream port

2018-12-21 Thread Xiong, Huan
On Fri, 14 Dec 2018 21:12:34 + (UTC), Michael S. Tsirkin wrote: > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: 2018年12月15日 5:13 > To: Xiong, Huan > Cc: qemu-devel@nongnu.org; marcel.apfelb...@gmail.com > Subject: Re: [PATCH] hw/pci-bridge: check invalid slot number for root and >

Re: [Qemu-devel] [PATCH v7 22/28] qdev: make a separate helper function to apply compat properties

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:04:04 +0400 Marc-André Lureau wrote: > This will allow to apply compat properties on other objects than QDev easily. > > Signed-off-by: Marc-André Lureau > --- > include/hw/qdev-core.h | 2 ++ > hw/core/qdev.c | 6 +- > 2 files changed, 7 insertions(+), 1

Re: [Qemu-devel] [PATCH] i386: remove the 'INTEL_PT' CPUID bit from named CPU models

2018-12-21 Thread Philippe Mathieu-Daudé
Hi Paolo, On 12/21/18 7:30 AM, Paolo Bonzini wrote: > From: Robert Hoo > > Processor tracing is not yet implemented for KVM and it will be an > opt in feature requiring a special module parameter. > Disable it, because it is wrong to enable it by default and > it is impossible that no one has

Re: [Qemu-devel] [PATCH] hw/usb: fix mistaken de-initialization of CCID state

2018-12-21 Thread Philippe Mathieu-Daudé
On 12/21/18 2:41 PM, Daniel P. Berrangé wrote: > In previous commit: > > commit 7dea29e4af17fc1d27478de9f8ea38144deac54a > Author: Li Qiang > Date: Fri Oct 19 03:50:36 2018 -0700 > > hw: ccid-card-emulated: cleanup resource when realize in error path > > The emulated_realize method

Re: [Qemu-devel] [PATCH RFC] i386: Enable NPT and NRIPSAVE for Epyc CPUs

2018-12-21 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Epyc CPUs support NPT and NRIPSAVE features and KVM exposes these when > present. Add them to EPYC and EPYC-IBPB cpu models. > > Signed-off-by: Vitaly Kuznetsov > --- > - RFC part: I'm not sure when these features first appeared, we may want to > modify some

Re: [Qemu-devel] [PATCH 1/2] i386: remove the new CPUID 'PCONFIG' from Icelake-Server CPU model

2018-12-21 Thread Paolo Bonzini
On 21/12/18 15:04, Robert Hoo wrote: >> So this series is correct and I will follow up with one for INTEL_PT; >> however, this begs the question of how the patches are being tested. > > My apologies for carelessness. No problem. In the future please check that "-cpu Icelake-Client" doesn't have

Re: [Qemu-devel] [PATCH v8 00/23] Add support for RDMA MAD

2018-12-21 Thread Yuval Shaia
On Fri, Dec 21, 2018 at 03:53:21PM +0200, Marcel Apfelbaum wrote: > > > On 12/17/18 8:45 PM, Yuval Shaia wrote: > > Hi all. > > Hi Yuval, > The series does not apply on master anymore, > can you please rebase it and send ii again? > > Thanks, > Marcel Yeah, conflict is because of a change

[Qemu-devel] [PATCH v9 22/23] hw/rdma: Do not call rdma_backend_del_gid on an empty gid

2018-12-21 Thread Yuval Shaia
When device goes down the function fini_ports loops over all entries in gid table regardless of the fact whether entry is valid or not. In case that entry is not valid we'd like to skip from any further processing in backend device. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum ---

[Qemu-devel] [Bug 1809304] Re: qemu-img convert is freezing for some DMG files.

2018-12-21 Thread yuchenlin
I have submitted a patch to prevent hanging in binary search. See: http://lists.nongnu.org/archive/html/qemu-devel/2018-12/msg05453.html?fbclid=IwAR0ObsaZ4kVMVv6MWIdq0ZCAN5tGhDsd9GmFv8_v7HBTl94Cu5EkRZ3z4n4 Thanks, Yu-Chen Lin -- You received this bug notification because you are a member of

[Qemu-devel] [PATCH v9 15/23] hw/pvrdma: Make device state depend on Ethernet function state

2018-12-21 Thread Yuval Shaia
User should be able to control the device by changing Ethernet function state so if user runs 'ifconfig ens3 down' the PVRDMA function should be down as well. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_cmd.c | 3 ++- 1 file changed, 2 insertions(+), 1

[Qemu-devel] [PATCH v9 20/23] hw/pvrdma: Clean device's resource when system is shutdown

2018-12-21 Thread Yuval Shaia
In order to clean some external resources such as GIDs, QPs etc, register to receive notification when VM is shutdown. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma.h | 2 ++ hw/rdma/vmw/pvrdma_main.c | 15 +++ 2 files changed, 17

Re: [Qemu-devel] [PATCH] hw/usb: fix mistaken de-initialization of CCID state

2018-12-21 Thread Michael Tokarev
21.12.2018 16:41, Daniel P. Berrangé wrote: In previous commit: commit 7dea29e4af17fc1d27478de9f8ea38144deac54a Author: Li Qiang Date: Fri Oct 19 03:50:36 2018 -0700 [] --- a/hw/usb/ccid-card-emulated.c +++ b/hw/usb/ccid-card-emulated.c @@ -549,6 +549,8 @@ static void

[Qemu-devel] [PATCH v9 14/23] hw/rdma: Initialize node_guid from vmxnet3 mac address

2018-12-21 Thread Yuval Shaia
node_guid should be set once device is load. Make node_guid be GID format (32 bit) of PCI function 0 vmxnet3 device's MAC. A new function was added to do the conversion. So for example the MAC 56:b6:44:e9:62:dc will be converted to GID 54b6:44ff:fee9:62dc. Signed-off-by: Yuval Shaia

[Qemu-devel] [PATCH v9 23/23] docs: Update pvrdma device documentation

2018-12-21 Thread Yuval Shaia
Interface with the device is changed with the addition of support for MAD packets. Adjust documentation accordingly. While there fix a minor mistake which may lead to think that there is a relation between using RXE on host and the compatibility with bare-metal peers. Signed-off-by: Yuval Shaia

  1   2   3   >