Re: [Qemu-devel] [PATCH v4 for-4.0 4/7] libvhost-user: Support tracking inflight I/O in shared memory

2019-01-14 Thread Jason Wang
On 2019/1/11 下午2:10, Yongji Xie wrote: On Fri, 11 Jan 2019 at 11:56, Jason Wang wrote: On 2019/1/9 下午7:27, elohi...@gmail.com wrote: From: Xie Yongji This patch adds support for VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD message to set/get shared memory to/from qemu. Then w

Re: [Qemu-devel] [PATCH v2 2/3] migration: fix memory leak when updating tls-creds and tls-hostname

2019-01-14 Thread Peter Xu
On Fri, Jan 11, 2019 at 02:37:31PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > If we update parameter, tls-creds and tls-hostname, these string > values are duplicated to local variables in migrate_params_test_apply() > by using g_strdup(), however these new allocated memory

Re: [Qemu-devel] [PATCH v3 0/2] intel-iommu: add support for 5-level virtual IOMMU.

2019-01-14 Thread Yu Zhang
On Mon, Jan 14, 2019 at 11:02:28PM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 12, 2018 at 09:05:37PM +0800, Yu Zhang wrote: > > Intel's upcoming processors will extend maximum linear address width to > > 57 bits, and introduce 5-level paging for CPU. Meanwhile, the platform > > will also extend

Re: [Qemu-devel] -device foo, help shouldn't be allowed for devices where -device foo is forbidden

2019-01-14 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 14 Jan 2019 at 16:59, Thomas Huth wrote: >> >> On 2019-01-14 17:31, Peter Maydell wrote: >> > We prohibit -device foo for non-pluggable devices: >> > $ ./build/all/x86_64-softmmu/qemu-system-x86_64 -device i8257 >> > qemu-system-x86_64: -device i8257: Parameter 'd

Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-01-14 Thread Denis Plotnikov
ping ping ping ping On 09.01.2019 11:18, Denis Plotnikov wrote: > ping ping!!! > > On 18.12.2018 11:53, Denis Plotnikov wrote: >> ping ping >> >> On 14.12.2018 14:54, Denis Plotnikov wrote: >>> >>> >>> On 13.12.2018 15:20, Kevin Wolf wrote: Am 13.12.2018 um 12:07 hat Denis Plotnikov gesc

Re: [Qemu-devel] [PATCH 03/10] vhost-net: compile it for all targets

2019-01-14 Thread Paolo Bonzini
On 15/01/19 04:50, Michael S. Tsirkin wrote: > On Thu, Nov 15, 2018 at 07:42:20PM +0100, Paolo Bonzini wrote: >> On 15/11/2018 15:31, Paolo Bonzini wrote: >>> Currently vhost-net is compiled only for KVM-enabled targets. This is >>> not needed anymore because ioeventfd is supported and emulated by

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2019-01-14 Thread Yu Zhang
On Fri, Dec 28, 2018 at 11:29:41PM -0200, Eduardo Habkost wrote: > On Fri, Dec 28, 2018 at 10:32:59AM +0800, Yu Zhang wrote: > > On Thu, Dec 27, 2018 at 01:14:11PM -0200, Eduardo Habkost wrote: > > > On Wed, Dec 26, 2018 at 01:30:00PM +0800, Yu Zhang wrote: > > > > On Tue, Dec 25, 2018 at 11:56:19A

Re: [Qemu-devel] [PATCH v2] hw/misc/ivshmem: Remove deprecated "ivshmem" legacy device

2019-01-14 Thread Thomas Huth
On 2019-01-14 19:08, Michael S. Tsirkin wrote: > On Mon, Jan 14, 2019 at 04:04:10PM -0200, Eduardo Habkost wrote: >> On Wed, Dec 19, 2018 at 03:56:30PM +0100, Markus Armbruster wrote: >>> Thomas Huth writes: >>> It's been marked as deprecated in QEMU v2.6.0 already, so really nobody shou

Re: [Qemu-devel] [PATCH V8 5/5] hostmem-file: add 'sync' option

2019-01-14 Thread Yi Zhang
On 2019-01-14 at 22:31:45 -0500, Michael S. Tsirkin wrote: > On Wed, Jan 02, 2019 at 01:26:34PM +0800, Zhang Yi wrote: > > This option controls will mmap the memory backend file with MAP_SYNC flag, > > which can ensure filesystem metadata consistent even after a system crash > > or power failure, i

Re: [Qemu-devel] [PATCH v4 for-4.0 2/7] vhost-user: Support transferring inflight buffer between qemu and backend

2019-01-14 Thread Yongji Xie
On Tue, 15 Jan 2019 at 06:25, Michael S. Tsirkin wrote: > > On Wed, Jan 09, 2019 at 07:27:23PM +0800, elohi...@gmail.com wrote: > > @@ -382,6 +397,30 @@ If VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD protocol > > feature is negotiated, > > slave can send file descriptors (at most 8 descriptors in each m

Re: [Qemu-devel] [PATCH v3 2/5] virtio-pmem: Add virtio pmem driver

2019-01-14 Thread Pankaj Gupta
> > This patch adds virtio-pmem driver for KVM guest. > > > > Guest reads the persistent memory range information from > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > creates a nd_region object with the persistent memory > > range information so that existing 'nvdimm/pmem' drive

Re: [Qemu-devel] [PULL 00/44] pci, pc, virtio: fixes, features

2019-01-14 Thread Peter Xu
On Mon, Jan 14, 2019 at 08:35:11PM -0500, Michael S. Tsirkin wrote: > The following changes since commit 89bd861c2b470e3fb45596945509079c72af3ac2: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2019-01-14 17:35:00 +) > > are available in the

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-14 Thread Pankaj Gupta
> > > > > > > > On Mon, Jan 14, 2019 at 02:15:40AM -0500, Pankaj Gupta wrote: > > > > > > > > > > > > Until you have images (and hence host page cache) shared between > > > > > > > multiple guests. People will want to do this, because it means > > > > > > > they > > > > > > > only need a single s

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-14 Thread Pankaj Gupta
> > > On Mon, Jan 14, 2019 at 02:15:40AM -0500, Pankaj Gupta wrote: > > > > > > > > > > Until you have images (and hence host page cache) shared between > > > > > > multiple guests. People will want to do this, because it means they > > > > > > only need a single set of pages in host memory for e

Re: [Qemu-devel] [PULLv3 00/65] slirp updates

2019-01-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190114225306.21569-1-samuel.thiba...@ens-lyon.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190114225306.21569-1-samuel.thiba...@ens-lyon.org Subject: [Qemu-devel] [PULLv3 00/65] slir

Re: [Qemu-devel] [PATCH v3 0/2] intel-iommu: add support for 5-level virtual IOMMU.

2019-01-14 Thread Michael S. Tsirkin
On Wed, Dec 12, 2018 at 09:05:37PM +0800, Yu Zhang wrote: > Intel's upcoming processors will extend maximum linear address width to > 57 bits, and introduce 5-level paging for CPU. Meanwhile, the platform > will also extend the maximum guest address width for IOMMU to 57 bits, > thus introducing th

Re: [Qemu-devel] [PATCH] vhost-user: fix qemu crash caused by failed backend

2019-01-14 Thread Michael S. Tsirkin
On Tue, Oct 02, 2018 at 01:54:25PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Sep 27, 2018 at 7:37 PM Liang Li wrote: > > > > During live migration, when stopping vhost-user device, 'vhost_dev_stop' > > will be called, 'vhost_dev_stop' will call a batch of 'vhost_user_read' > > and 'vhost_u

Re: [Qemu-devel] [PATCH v1 2/5] vl.c: add -smp, dies=* command line support

2019-01-14 Thread Xu, Like
> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, January 15, 2019 4:52 AM > To: Like Xu > Cc: qemu-devel@nongnu.org; Xu, Like ; > imamm...@redhat.com; drjo...@redhat.com; Michael S. Tsirkin > ; Marcelo Tosatti ; Marcel > Apfelbaum ; Paolo Bonzini >

Re: [Qemu-devel] [PATCH 03/10] vhost-net: compile it for all targets

2019-01-14 Thread Michael S. Tsirkin
On Thu, Nov 15, 2018 at 07:42:20PM +0100, Paolo Bonzini wrote: > On 15/11/2018 15:31, Paolo Bonzini wrote: > > Currently vhost-net is compiled only for KVM-enabled targets. This is > > not needed anymore because ioeventfd is supported and emulated by the > > memory core. Compile it and vhost-user

Re: [Qemu-devel] [PATCH V8 3/5] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-14 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 10:49:45AM +0800, Yi Zhang wrote: > On 2019-01-14 at 17:07:02 -0200, Eduardo Habkost wrote: > > On Wed, Jan 02, 2019 at 01:26:15PM +0800, Zhang Yi wrote: > > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > > > MAP_SYNC flag in addition which can ensur

Re: [Qemu-devel] [PATCH V8 5/5] hostmem-file: add 'sync' option

2019-01-14 Thread Michael S. Tsirkin
On Wed, Jan 02, 2019 at 01:26:34PM +0800, Zhang Yi wrote: > This option controls will mmap the memory backend file with MAP_SYNC flag, > which can ensure filesystem metadata consistent even after a system crash > or power failure, if MAP_SYNC flag is supported by the host kernel(Linux > kernel 4.15

[Qemu-devel] [Bug 1785698] Re: Solaris build error: unknown type name ‘gcry_error_t’

2019-01-14 Thread WHR
libutil should not be linked on Solaris, see https://bugs.launchpad.net/qemu/+bug/1777252 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1785698 Title: Solaris build error: unknown type name ‘gcry_e

Re: [Qemu-devel] Questions about VFIO enabling MSIX vector

2019-01-14 Thread Heyi Guo
Hi Alex, Really appreciate your comments. I have some more questions below. On 2019/1/15 0:07, Alex Williamson wrote: On Sat, 12 Jan 2019 10:30:40 +0800 Heyi Guo wrote: Hi folks, I have some questions about vfio_msix_vector_do_use() in hw/vfio/pci.c, could you help to explain? We can see

Re: [Qemu-devel] [PATCH V8 5/5] hostmem-file: add 'sync' option

2019-01-14 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 11:13:35AM +0800, Yi Zhang wrote: > On 2019-01-14 at 17:39:38 -0200, Eduardo Habkost wrote: > > On Wed, Jan 02, 2019 at 01:26:34PM +0800, Zhang Yi wrote: > > > This option controls will mmap the memory backend file with MAP_SYNC flag, > > > which can ensure filesystem metada

Re: [Qemu-devel] [PATCH V8 2/5] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

2019-01-14 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 10:39:14AM +0800, Yi Zhang wrote: > > It's needed for this series but yes, this ifdefery belongs in > > a more central header. Maybe qemu/osdep.h > > And it needs documentation and be a separate patch. > Agree, Thank Michael's explanation, better to doing this in a separate

Re: [Qemu-devel] [PATCH V8 5/5] hostmem-file: add 'sync' option

2019-01-14 Thread Yi Zhang
On 2019-01-14 at 17:39:38 -0200, Eduardo Habkost wrote: > On Wed, Jan 02, 2019 at 01:26:34PM +0800, Zhang Yi wrote: > > This option controls will mmap the memory backend file with MAP_SYNC flag, > > which can ensure filesystem metadata consistent even after a system crash > > or power failure, if M

Re: [Qemu-devel] [PATCH v2 09/12] tests/tcg/mips: Test R5900 three-operand MADDU1

2019-01-14 Thread Aleksandar Markovic
On Monday, January 14, 2019, Fredrik Noring wrote: > Hi Aleksandar, > > > Awesome! > > > > I am especially happy with your choice of naming "mmr" (MultiMedia > > Registers) for these fieilds, since that is what they really are (and > they > > are certainly not "gprs"). Right on the money! > > Gre

Re: [Qemu-devel] [PATCH V8 3/5] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-14 Thread Yi Zhang
On 2019-01-14 at 17:07:02 -0200, Eduardo Habkost wrote: > On Wed, Jan 02, 2019 at 01:26:15PM +0800, Zhang Yi wrote: > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > > MAP_SYNC flag in addition which can ensure file system metadata > > synced in each guest writes to the back

[Qemu-devel] MTTCG qemu-softmmu aborted on watchpoint hit by atomic instruction

2019-01-14 Thread Max Filippov
Hello, I tried to debug guest application on SMP xtensa softmmu QEMU through the gdbserver and found that QEMU aborts when guest uses atomic operation to modify memory location watched by the debugger. It exits with the following message: ERROR: cpus.c:1848:qemu_mutex_lock_iothread_impl: assertio

Re: [Qemu-devel] [PATCH V8 2/5] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

2019-01-14 Thread Yi Zhang
On 2019-01-14 at 14:04:25 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 14, 2019 at 04:50:36PM -0200, Eduardo Habkost wrote: > > On Wed, Jan 02, 2019 at 01:26:06PM +0800, Zhang Yi wrote: > > > As more flag parameters besides the existing 'shared' are going to be > > > added to qemu_ram_mmap(), let

Re: [Qemu-devel] [PATCH] vhost-user-blk: enable discard/write zeroes features

2019-01-14 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Monday, January 14, 2019 6:42 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; stefa...@redhat.com; m...@redhat.com; > sgaz...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] vhost-user-blk: enable disca

Re: [Qemu-devel] Meaning of "-smp threads" on mips_malta

2019-01-14 Thread Aleksandar Markovic
On Monday, January 14, 2019, Eduardo Habkost wrote: > Hi, > > I'm trying to refactor the SMP topology code in QEMU > Eduardo, I truly appreciate your interest in details of Malta implementations, but before I answer your questions, could you please outline the motivation and the current concept

Re: [Qemu-devel] [PATCH v1 1/5] cpu: introduce die, the new cpu toppolgy emulation level

2019-01-14 Thread Xu, Like
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, January 15, 2019 4:08 AM > To: Like Xu ; qemu-devel@nongnu.org > Cc: drjo...@redhat.com; Peter Crosthwaite > ; Eduardo Habkost ; > Michael S. Tsirkin ; Xu, Like ; > Marcelo Tosatti ; Paolo Bonzini > ; imamm.

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-14 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 09:21:32AM +1100, Dave Chinner wrote: > On Mon, Jan 14, 2019 at 01:35:57PM -0800, Dan Williams wrote: > > On Mon, Jan 14, 2019 at 1:25 PM Dave Chinner wrote: > > > > > > On Mon, Jan 14, 2019 at 02:15:40AM -0500, Pankaj Gupta wrote: > > > > > > > > > > Until you have images

Re: [Qemu-devel] [PATCH v5 4/4] i386: allow to load initrd below 4G for recent linux

2019-01-14 Thread Li Zhijian
Hi Eduardo On 1/15/19 01:53, Eduardo Habkost wrote: +if (protocol >= 0x20c && +lduw_p(header+0x236) & XLF_CAN_BE_LOADED_ABOVE_4G) { +/* + * Linux has supported initrd up to 4 GB for a very long time (2007, + * long before XLF_CAN_BE_LOADED_ABOVE_4G which was

Re: [Qemu-devel] [PATCH v5 4/4] i386: allow to load initrd below 4G for recent linux

2019-01-14 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 09:35:09AM +0800, Li Zhijian wrote: > Hi Eduardo > > > On 1/15/19 01:53, Eduardo Habkost wrote: > > +if (protocol >= 0x20c && > +lduw_p(header+0x236) & XLF_CAN_BE_LOADED_ABOVE_4G) { > +/* > + * Linux has supporte

[Qemu-devel] [PULL 02/44] msix: make pba size math more uniform

2019-01-14 Thread Michael S. Tsirkin
From: Dongli Zhang In msix_exclusive_bar the bar_pba_size is more than what the pba is expected to have, although this never affects the bar size. Specifically, the math in msix_init_exclusive_bar allocates too much memory in some cases. For example consider nentries = 8. msix_exclusive_bar wi

[Qemu-devel] [PULL 07/44] util: check the return value of fcntl in qemu_set_{block, nonblock}

2019-01-14 Thread Michael S. Tsirkin
From: Li Qiang Assert that the return value is not an error. This is like commit 7e6478e7d4f for qemu_set_cloexec. Signed-off-by: Li Qiang Reviewed-by: Thomas Huth Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- util/oslib-posix.c | 8 ++-- 1 file changed, 6 insert

[Qemu-devel] [PULL 06/44] vhost-user: fix ioeventfd_enabled

2019-01-14 Thread Michael S. Tsirkin
From: Li Qiang Currently, the vhost-user-test assumes the eventfd is available. However it's not true because the accel is qtest. So the 'vhost_set_vring_file' will not add fds to the msg and the server side of vhost-user-test will be broken. The bug is in 'ioeventfd_enabled'. We should make this

[Qemu-devel] [PULL 13/44] tests: smbios: fetch whole table in one step instead of reading it step by step

2019-01-14 Thread Michael S. Tsirkin
From: Igor Mammedov replace a bunch of ACPI_READ_ARRAY/ACPI_READ_FIELD macro, that read SMBIOS table field by field with one memread() to fetch whole table at once and drop no longer used ACPI_READ_ARRAY/ACPI_READ_FIELD macro. Signed-off-by: Igor Mammedov Acked-by: Thomas Huth Reviewed-by: Phi

[Qemu-devel] [PULL 05/44] tests: vhost-user-test: initialize 'fd' in chr_read

2019-01-14 Thread Michael S. Tsirkin
From: Li Qiang Currently when processing VHOST_USER_SET_VRING_CALL if 'qemu_chr_fe_get_msgfds' get no fd, the 'fd' will be a stack uninitialized value. Signed-off-by: Li Qiang Reviewed-by: Thomas Huth Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-tes

[Qemu-devel] [PULL 15/44] tests: acpi: use AcpiSdtTable::aml instead of AcpiSdtTable::header::signature

2019-01-14 Thread Michael S. Tsirkin
From: Igor Mammedov AcpiSdtTable::header::signature is the only remained field from AcpiTableHeader structure used by tests. Instead of using packed structure to access signature, just read it directly from table blob and remove no longer used AcpiSdtTable::header / union and keep only AcpiSdtTab

[Qemu-devel] [Bug 1811653] Re: usbredir slow when multi bulk packet per second

2019-01-14 Thread feihu
** Description changed: QEMU Ver: all version Client: virt-viewer with spice Guest VM: win7 Bug description:   Use Qemu 2.1 or later with usbredir, When I redirect a bulk usb-device from virt-viewer client,the bulk-usb-device driver or app in GuestVM will send 50 bulk-urb per times.

[Qemu-devel] [PULL 26/44] virtio: split vhost scsi bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 19 hw/virtio/vhost-scsi-pci.c | 97 ++ hw/virtio/virtio-pci.c | 61

[Qemu-devel] [PULL 08/44] tests: acpi: use AcpiSdtTable::aml in consistent way

2019-01-14 Thread Michael S. Tsirkin
From: Igor Mammedov Currently in the 1st case we store table body fetched from QEMU in AcpiSdtTable::aml minus it's header but in the 2nd case when we load reference aml from disk, it holds whole blob including header. More over in the 1st case, we read header in separate AcpiSdtTable::header str

[Qemu-devel] [PULL 03/44] hw/misc/ivshmem: Remove deprecated "ivshmem" legacy device

2019-01-14 Thread Michael S. Tsirkin
From: Thomas Huth It's been marked as deprecated in QEMU v2.6.0 already, so really nobody should use the legacy "ivshmem" device anymore (but use ivshmem-plain or ivshmem-doorbell instead). Time to remove the deprecated device now. Belatedly also update a mention of the deprecated "ivshmem" in t

[Qemu-devel] [PULL 27/44] virtio: split virtio scsi bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Notice that we can't still run tests with it disabled. Both cdrom-test and drive_del-test use virtio-scsi without checking if it is enabled. Reviewed-by: Thomas Huth Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: M

[Qemu-devel] [PULL 11/44] tests: acpi: reuse fetch_table() for fetching FACS and DSDT

2019-01-14 Thread Michael S. Tsirkin
From: Igor Mammedov It allows to remove a bit more of code duplication and reuse common utility to get ACPI tables from guest (modulo RSDP). While at it, consolidate signature checking into fetch_table() instead of open-codding it. Considering FACS is special and doesn't have checksum, make che

[Qemu-devel] [PULL 10/44] tests: acpi: simplify rsdt handling

2019-01-14 Thread Michael S. Tsirkin
From: Igor Mammedov RSDT referenced tables always have length at offset 4 and checksum at offset 9, that's enough for reusing fetch_table() and replacing custom RSDT fetching code with it. While at it * merge fetch_rsdt_referenced_tables() into test_acpi_rsdt_table() * drop test_data::rsdt_tabl

[Qemu-devel] [PULL 19/44] virtio: split virtio input host bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela For consistency with other devices, rename virtio_host_{initfn,pci_info} to virtio_input_host_{initfn,info}. Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- default-configs/virtio.mak|

[Qemu-devel] [PULL 00/44] pci, pc, virtio: fixes, features

2019-01-14 Thread Michael S. Tsirkin
The following changes since commit 89bd861c2b470e3fb45596945509079c72af3ac2: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2019-01-14 17:35:00 +) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/fo

[Qemu-devel] [PULL 18/44] virtio: split vhost vsock bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 18 hw/virtio/vhost-vsock-pci.c | 86 + hw/virtio/virtio-pci.c |

[Qemu-devel] [PULL 14/44] tests: acpi: squash sanitize_fadt_ptrs() into test_acpi_fadt_table()

2019-01-14 Thread Michael S. Tsirkin
From: Igor Mammedov some parts of sanitize_fadt_ptrs() do redundant job - locating FADT - checking original checksum There is no need to do it as test_acpi_fadt_table() already does that, so drop duplicate code and move remaining fixup code into test_acpi_fadt_table(). Signed-off-by: Igor M

[Qemu-devel] [PULL 22/44] virtio: split virtio balloon bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Thomas Huth Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 14 - hw/virtio/virtio-balloon-pci.c | 95 ++ hw/v

[Qemu-devel] [PULL 25/44] virtio: split vhost user scsi bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 11 hw/virtio/vhost-user-scsi-pci.c | 103 hw/virtio/virtio-pci.c

[Qemu-devel] [PULL 01/44] pci/pcie: stop plug/unplug if the slot is locked

2019-01-14 Thread Michael S. Tsirkin
From: David Hildenbrand We better stop right away. For now, errors would be partially ignored (so the guest might get informed or the device might get unplugged), although actual plug/unplug will be reported as failed to the user. While at it, properly move the check to the pre_plug handler for

[Qemu-devel] [PULL 24/44] virtio: split vhost user blk bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Thomas Huth Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 18 -- hw/virtio/vhost-user-blk-pci.c | 103 + hw

[Qemu-devel] [PULL 21/44] virtio: split virtio rng bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 14 -- hw/virtio/virtio-pci.c | 54 --- hw/virtio/virtio-rng-pci.c | 88

[Qemu-devel] [PULL 35/44] virtio: Make disable-legacy/disable-modern compat properties optional

2019-01-14 Thread Michael S. Tsirkin
From: Eduardo Habkost The disable-legacy and disable-modern properties apply only to some virtio-pci devices. Make those properties optional. This fixes the crash introduced by commit f6e501a28ef9 ("virtio: Provide version-specific variants of virtio PCI devices"): $ qemu-system-x86_64 -mach

[Qemu-devel] [PULL 04/44] qemu: avoid memory leak while remove disk

2019-01-14 Thread Michael S. Tsirkin
From: Jian Wang Memset vhost_dev to zero in the vhost_dev_cleanup function. This causes dev.vqs to be NULL, so that vqs does not free up space when calling the g_free function. This will result in a memory leak. But you can't release vqs directly in the vhost_dev_cleanup function, because vhost_n

[Qemu-devel] [PULL 23/44] virtio: split virtio 9p bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Acked-by: Greg Kurz Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h| 20 - hw/virtio/virtio-9p-pci.c | 88 +++ hw/virtio/

[Qemu-devel] [PULL 31/44] virtio: split virtio gpu bits from virtio-pci.h

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 14 -- hw/display/virtio-gpu-pci.c | 14 ++ hw/display/virtio-vga.c | 1 + 3 files cha

[Qemu-devel] [PULL 37/44] tpm: add a "ppi" boolean property

2019-01-14 Thread Michael S. Tsirkin
From: Marc-André Lureau The following patches implement the TPM Physical Presence Interface, make use of a new memory region and a fw_cfg entry. Enable PPI by default with >=4.0 machine type, to avoid migration issues. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Ph

[Qemu-devel] [PULL 17/44] virtio-net: changed VIRTIO_NET_F_RSC_EXT to be 61

2019-01-14 Thread Michael S. Tsirkin
From: Yuri Benditovich Allocated feature bit changed in spec draft per TC request. Signed-off-by: Yuri Benditovich Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c

[Qemu-devel] [PULL 09/44] tests: acpi: make sure FADT is fetched only once

2019-01-14 Thread Michael S. Tsirkin
From: Igor Mammedov Whole FADT is fetched as part of RSDT referenced tables in fetch_rsdt_referenced_tables() albeit a bit later than when FADT is partially parsed in fadt_fetch_facs_and_dsdt_ptrs(). However there is no reason for calling fetch_rsdt_referenced_tables() so late, just move it right

[Qemu-devel] [PULL 32/44] virtio: split virtio crypto bits from virtio-pci.h

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h| 14 -- hw/virtio/virtio-crypto-pci.c | 14 ++ 2 files changed, 14 insertions(+), 14 delet

[Qemu-devel] [PULL 20/44] virtio: split virtio input bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 22 - hw/virtio/virtio-input-pci.c | 157 +++ hw/virtio/virtio-pci.c |

[Qemu-devel] [PULL 12/44] tests: acpi: reuse fetch_table() in vmgenid-test

2019-01-14 Thread Michael S. Tsirkin
From: Igor Mammedov Move fetch_table() into acpi-utils.c renaming it to acpi_fetch_table() and reuse it in vmgenid-test that reads RSDT and then tables it references, to find and parse VMGNEID SSDT. While at it wrap RSDT referenced tables enumeration into FOREACH macro (similar to what we do with

[Qemu-devel] [PULL 40/44] acpi: build TPM Physical Presence interface

2019-01-14 Thread Michael S. Tsirkin
From: Stefan Berger The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can send messages to the firmware by writing a code into the shared memory through invoking the ACPI code. When a reboot happens, the firmware looks for the code

[Qemu-devel] [PULL 33/44] virtio: virtio 9p really requires CONFIG_VIRTFS to work

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Signed-off-by: Juan Quintela Reviewed-by: Greg Kurz Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- default-configs/virtio.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/default-configs/virtio.mak b/default-configs/virtio.mak

[Qemu-devel] [PULL 16/44] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2019-01-14 Thread Michael S. Tsirkin
From: Yuri Benditovich This commit adds implementation of RX packets coalescing, compatible with requirements of Windows Hardware compatibility kit. The device enables feature VIRTIO_NET_F_RSC_EXT in host features if it supports extended RSC functionality as defined in the specification. This fe

[Qemu-devel] [PULL 29/44] virtio: split virtio net bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Thomas Huth Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 14 -- hw/virtio/virtio-net-pci.c | 98 ++ hw/virt

[Qemu-devel] [PULL 34/44] globals: Allow global properties to be optional

2019-01-14 Thread Michael S. Tsirkin
From: Eduardo Habkost Making some global properties optional will let us simplify compat code when a given property works on most (but not all) subclasses of a given type. Device types will be able to opt out from optional compat properties by simply not registering those properties. Signed-off

[Qemu-devel] [PULL 41/44] acpi: add ACPI memory clear interface

2019-01-14 Thread Michael S. Tsirkin
From: Marc-André Lureau The interface is described in the "TCG Platform Reset Attack Mitigation Specification", chapter 6 "ACPI _DSM Function". According to Laszlo, it's not so easy to implement in OVMF, he suggested to do it in qemu instead. See specification documentation for more details, and

[Qemu-devel] [PULL 28/44] virtio: split virtio blk bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Reviewed-by: Thomas Huth Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 14 -- hw/virtio/virtio-pci.c | 61 - hw/vir

[Qemu-devel] [PULL 38/44] tpm: allocate/map buffer for TPM Physical Presence interface

2019-01-14 Thread Michael S. Tsirkin
From: Stefan Berger Implement a virtual memory device for the TPM Physical Presence interface. The memory is located at 0xFED45000 and used by ACPI to send messages to the firmware (BIOS) and by the firmware to provide parameters for each one of the supported codes. This interface should be used

[Qemu-devel] [PULL 36/44] hw/misc/edu: add msi_uninit() for pci_edu_uninit()

2019-01-14 Thread Michael S. Tsirkin
From: Fei Li Let's supplement the msi_uninit() when failing to realize the pci edu device. Reported-by: Markus Armbruster Signed-off-by: Fei Li Reviewed-by: Marcel Apfelbaum Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL 42/44] tpm: clear RAM when "memory overwrite" requested

2019-01-14 Thread Michael S. Tsirkin
From: Marc-André Lureau Note: the "Platform Reset Attack Mitigation" specification isn't explicit about NVDIMM, since they could have different usages. It uses the term "system memory" generally (and also "volatile memory RAM" in its introduction). For initial support, I propose to consider non-v

[Qemu-devel] [PULL 39/44] acpi: expose TPM/PPI configuration parameters to firmware via fw_cfg

2019-01-14 Thread Michael S. Tsirkin
From: Stefan Berger To avoid having to hard code the base address of the PPI virtual memory device we introduce a fw_cfg file etc/tpm/config that holds the base address of the PPI device, the version of the PPI interface and the version of the attached TPM. Signed-off-by: Stefan Berger [ Marc-A

[Qemu-devel] [PULL 30/44] virtio: split virtio serial bits from virtio-pci

2019-01-14 Thread Michael S. Tsirkin
From: Juan Quintela Virtio console and qga tests also depend on CONFIG_VIRTIO_SERIAL. Reviewed-by: Thomas Huth Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h| 14 - hw/virtio

[Qemu-devel] [PULL 43/44] hw: acpi: Fix memory hotplug AML generation error

2019-01-14 Thread Michael S. Tsirkin
From: Yang Zhong When using the generated memory hotplug AML, the iasl compiler would give the following error: dsdt.dsl 266: Return (MOST (_UID, Arg0, Arg1, Arg2)) Error 6080 - Called method returns no value ^ Signed-off-by: Yang Zhong Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirk

[Qemu-devel] [PULL 44/44] acpi: update expected files

2019-01-14 Thread Michael S. Tsirkin
Update expected files affected by: hw: acpi: Fix memory hotplug AML generation error Signed-off-by: Michael S. Tsirkin --- tests/data/acpi/pc/DSDT.dimmpxm | Bin 6790 -> 6784 bytes tests/data/acpi/pc/DSDT.memhp| Bin 6496 -> 6490 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9474 -> 9468 byt

[Qemu-devel] [PATCH v1 2/8] RISC-V: Mark mstatus.fs dirty

2019-01-14 Thread Alistair Francis
From: Richard Henderson Modifed from Richard Henderson's patch [1] to integrate with the new control and status register implementation. [1] https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg07034.html Note: the f* CSRs already mark mstatus.FS dirty using env->mstatus |= mstatus.FS so

[Qemu-devel] [PATCH v1 7/8] RISC-V: Add misa.MAFD checks to translate

2019-01-14 Thread Alistair Francis
From: Michael Clark Add misa checks for M, A, F and D extensions and if they are not present generate illegal instructions. This improves emulation accurary for harts with a limited set of extensions. Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Alistair Francis Cc: Emi

[Qemu-devel] [PATCH v1 8/8] RISC-V: Add misa runtime write support

2019-01-14 Thread Alistair Francis
From: Michael Clark This patch adds support for writing misa. misa is validated based on rules in the ISA specification. 'E' is mutually exclusive with all other extensions. 'D' depends on 'F' so 'D' bit is dropped if 'F' is not present. A conservative approach to consistency is taken by flushing

[Qemu-devel] [PATCH v1 6/8] RISC-V: Add misa to DisasContext

2019-01-14 Thread Alistair Francis
From: Michael Clark gen methods should access state from DisasContext. Add misa field to the DisasContext struct and remove CPURISCVState argument from all gen methods. Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Alistair Francis Cc: Emilio G. Cota Signed-off-by: Mich

[Qemu-devel] [PATCH v1 1/8] RISC-V: Split out mstatus_fs from tb_flags

2019-01-14 Thread Alistair Francis
From: Richard Henderson Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Richard Henderson Signed-off-by: Michael Clark Reviewed-by: Michael Clark Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 6 +++--- target/riscv/translate.c | 1

[Qemu-devel] [PATCH v1 4/8] RISC-V: Use riscv prefix consistently on cpu helpers

2019-01-14 Thread Alistair Francis
From: Michael Clark * Add riscv prefix to raise_exception function * Add riscv prefix to CSR read/write functions * Add riscv prefix to signal handler function * Add riscv prefix to get fflags function * Remove redundant declaration of riscv_cpu_init and rename cpu_riscv_init to riscv_cpu_init

[Qemu-devel] [PATCH v1 5/8] RISC-V: Add priv_ver to DisasContext

2019-01-14 Thread Alistair Francis
The gen methods should access state from DisasContext. Add priv_ver field to the DisasContext struct. Signed-off-by: Alistair Francis --- target/riscv/translate.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c inde

[Qemu-devel] [PATCH v1 3/8] RISC-V: Implement mstatus.TSR/TW/TVM

2019-01-14 Thread Alistair Francis
From: Michael Clark This adds the necessary minimum to support S-mode virtualization for priv ISA >= v1.10 Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Matthew Suozzo Signed-off-by: Michael Clark Signed-off-by: Alistair Francis Co-authored-by: M

[Qemu-devel] [PATCH v1 0/8] Upstream RISC-V fork patches, part 3

2019-01-14 Thread Alistair Francis
Alistair Francis (1): RISC-V: Add priv_ver to DisasContext Michael Clark (5): RISC-V: Implement mstatus.TSR/TW/TVM RISC-V: Use riscv prefix consistently on cpu helpers RISC-V: Add misa to DisasContext RISC-V: Add misa.MAFD checks to translate RISC-V: Add misa runtime write support R

[Qemu-devel] [PULL 62/65] slirp: set G_LOG_DOMAIN

2019-01-14 Thread Samuel Thibault
From: Marc-André Lureau We are moving to g_log() facilities to log errors and probably debug messages too. Let's have the "Slirp" prefix on messages slirp produces. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 2 ++ 1 file changed, 2 insertions(+)

[Qemu-devel] [PULL 56/65] slirp: use %p for pointers format

2019-01-14 Thread Samuel Thibault
From: Marc-André Lureau This fixes some compilation warnings on mingw64. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/ip6_icmp.c | 2 +- slirp/ip6_input.c | 2 +- slirp/ip6_output.c | 4 ++-- slirp/udp6.c | 6 +++--- 4 files changed, 7 insertions(+), 7 de

[Qemu-devel] [PULL 55/65] slirp: introduce SLIRP_DEBUG environment variable

2019-01-14 Thread Samuel Thibault
From: Marc-André Lureau Learn to read SLIRP_DEBUG=call,misc,error (all or help also handled) to set the slirp_debug flags. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/misc.c | 8 slirp/slirp.c | 15 +++ 2 files changed, 15 insertions(+), 8

[Qemu-devel] [PULL 53/65] slirp: no need to make DPRINTF conditional on DEBUG

2019-01-14 Thread Samuel Thibault
From: Marc-André Lureau DEBUG_CALL is already handled conditionally. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/bootp.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/slirp/bootp.c b/slirp/bootp.c index 5ab6692038..4c9a77eb98 100644 -

[Qemu-devel] [PULL 48/65] slirp: rename exec_list

2019-01-14 Thread Samuel Thibault
From: Marc-André Lureau This list is not only used to handle command to execute on guest connection, it can also redirect to an arbitrary object, such as a chardev. Let's rename the struct and the field to "guestfwd". Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/m

[Qemu-devel] [PULL 50/65] slirp: replace a fprintf with g_critical()

2019-01-14 Thread Samuel Thibault
From: Marc-André Lureau Reduce dependency on QEMU. QEMU could use a custom glib log handler if it wants to redirect/filter it. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/socket.c

[Qemu-devel] [PULL 61/65] build-sys: use a separate slirp-obj-y && slirp.mo

2019-01-14 Thread Samuel Thibault
From: Marc-André Lureau This will allow to have cflags for the whole slirp.mo -objs. It makes it possible to build tests that links only with slirp-obj-y (and not the whole common-obj). It is also a step towards building slirp as a shared library, although this requires a bit more thoughts to bu

[Qemu-devel] [PULL 43/65] glib-compat: add g_spawn_async_with_fds() fallback

2019-01-14 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- include/glib-compat.h | 56 +++ 1 file changed, 56 insertions(+) diff --git a/include/glib-compat.h b/include/glib-compat.h index fdf95a255d..8a078c5288 100644 -

Re: [Qemu-devel] [PATCH v2 3/3] util: check the return value of fcntl in qemu_set_{block, nonblock}

2019-01-14 Thread Michael S. Tsirkin
On Wed, Jan 02, 2019 at 03:07:24PM +0100, Thomas Huth wrote: > On 2018-12-15 13:03, Li Qiang wrote: > > Assert that the return value is not an error. This is like commit > > 7e6478e7d4f for qemu_set_cloexec. > > > > Signed-off-by: Li Qiang > > --- > > util/oslib-posix.c | 8 ++-- > > 1 file

  1   2   3   4   5   6   >