Re: [Qemu-devel] [PATCH] intel_iommu: Correct caching-mode error message

2019-03-26 Thread Peter Xu
On Tue, Mar 26, 2019 at 05:05:38PM -0600, Alex Williamson wrote: > If we try to use the intel-iommu device with vfio-pci devices without > caching mode enabled, we're told: > > qemu-system-x86_64: We need to set caching-mode=1 for intel-iommu to enable > device assignment with IOMMU

Re: [Qemu-devel] [PULL 02/29] ppc/spapr: Receive and store device tree blob from SLOF

2019-03-26 Thread David Gibson
On Tue, Mar 26, 2019 at 08:09:53AM +0100, Greg Kurz wrote: > On Tue, 26 Mar 2019 10:47:15 +1100 > David Gibson wrote: > > > On Mon, Mar 25, 2019 at 05:33:21PM +0100, Greg Kurz wrote: > > > On Mon, 25 Mar 2019 11:53:47 +1100 > > > David Gibson wrote: > > > > > > > On Sun, Mar 24, 2019 at

Re: [Qemu-devel] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-26 Thread David Gibson
On Tue, Mar 26, 2019 at 03:08:20PM +0100, Igor Mammedov wrote: > On Tue, 26 Mar 2019 14:50:58 +1100 > David Gibson wrote: > > > qemu_getrampagesize() works out the minimum host page size backing any of > > guest RAM. This is required in a few places, such as for POWER8 PAPR KVM > > guests,

Re: [Qemu-devel] [PATCH] target/ppc: Improve comment of bcctr used for spectre v2 mitigation

2019-03-26 Thread David Gibson
On Tue, Mar 26, 2019 at 11:21:11AM +0100, Greg Kurz wrote: > Signed-off-by: Greg Kurz Applied, thanks. > --- > target/ppc/translate.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > index

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-26 Thread David Gibson
On Tue, Mar 26, 2019 at 06:02:51PM +0100, David Hildenbrand wrote: > On 26.03.19 15:08, Igor Mammedov wrote: > > On Tue, 26 Mar 2019 14:50:58 +1100 > > David Gibson wrote: > > > >> qemu_getrampagesize() works out the minimum host page size backing any of > >> guest RAM. This is required in a

Re: [Qemu-devel] [PATCH for 4.0 v1 1/1] MAINTAINERS: Update the device tree maintainers

2019-03-26 Thread da...@gibson.dropbear.id.au
On Tue, Mar 26, 2019 at 08:59:23PM +, Alistair Francis wrote: > Remove Alex as a Device Tree maintainer as requested by him. Add myself > as a maintainer to avoid it being orphaned. Also add David as a > Reviewer (R) as he is the libfdt and DTC maintainer. > > Signed-off-by: Alistair Francis

[Qemu-devel] [Bug 1821839] [NEW] qemu 4.0 doesnt support glsl 3.0 but yes older versions, that have no sense IMO

2019-03-26 Thread salvador liébana
Public bug reported: tested on qemu 4.0.rc1 on rpi3, mesa 19.x maybe I am a bit confused, but why it can use and older version from my mesa driver, it should pickup the right version instead of going to the latest. pi@pi:~/Desktop/armbian/windows_95_vdi $ qemu-system-i386 -cpu qemu32 -m 32

Re: [Qemu-devel] [PATCH] SiFive RISC-V GPIO Device

2019-03-26 Thread Palmer Dabbelt
On Tue, 26 Mar 2019 10:49:11 PDT (-0700), chout...@adacore.com wrote: Hi Palmer, On 26/03/2019 09:58, Palmer Dabbelt wrote: Do you have anything that actually glues this to a machine so I can test it? In this patch I do instantiate the device in sifive_e machine. OK, that's what I thought

Re: [Qemu-devel] [PATCH V2 RFT] vhost_net: don't set backend for the uninitialized virtqueue

2019-03-26 Thread Jason Wang
On 2019/3/26 下午8:49, Michael S. Tsirkin wrote: On Tue, Mar 26, 2019 at 02:59:19PM +0800, Jason Wang wrote: On 2019/3/25 下午8:32, Michael S. Tsirkin wrote: On Mon, Mar 25, 2019 at 11:56:13AM +0800, Jason Wang wrote: We used to set backend unconditionally, this won't work for some guests (e.g

Re: [Qemu-devel] [PATCH] ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device

2019-03-26 Thread Chen Zhang via Qemu-devel
> On Mar 27, 2019, at 12:20 AM, Peter Maydell wrote: > > On Thu, 21 Mar 2019 at 07:10, Chen Zhang wrote: >> >> In fullscreen mode, the window property of cocoaView may not be the key >> window, and the current implementation would not grab mouse in >> fullscreen mode after left clicks on

[Qemu-devel] [PATCH] migration: not necessary to check ops again

2019-03-26 Thread Wei Yang
During each iteration, se->ops is checked before each loop. So it is not necessary to check it again and simplify the following check a little. Signed-off-by: Wei Yang --- migration/savevm.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/migration/savevm.c

Re: [Qemu-devel] [PATCH v2] ui/cocoa: Fix absolute input device grabbing issues on Mojave

2019-03-26 Thread Chen Zhang via Qemu-devel
> On Mar 27, 2019, at 12:15 AM, Peter Maydell wrote: > > On Tue, 19 Mar 2019 at 03:51, Chen Zhang > wrote: >> >> On Mojave, absolute input device, i.e. tablet, had trouble re-grabbing >> the cursor in re-entry into the virtual screen area. In some cases, >> the

Re: [Qemu-devel] [PATCH for 4.0 v1 1/1] MAINTAINERS: Update the device tree maintainers

2019-03-26 Thread Alexander Graf
> Am 27.03.2019 um 03:59 schrieb Alistair Francis : > > Remove Alex as a Device Tree maintainer as requested by him. Add myself > as a maintainer to avoid it being orphaned. Also add David as a > Reviewer (R) as he is the libfdt and DTC maintainer. > > Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-03-26 Thread Catherine Ho
Hi all, thanks for the comments, I am digging into another potential error in the ignore-shared live migration. After that, I will send out the v2 asap B.R. Catherine On Mon, 25 Mar 2019 at 11:39, Peter Xu wrote: > > On Fri, Mar 22, 2019 at 10:12:11AM +, Dr. David Alan Gilbert wrote: > >

Re: [Qemu-devel] [Qemu-block] [PATCH] vmdk: Set vmdk parent backing_format to vmdk

2019-03-26 Thread Eric Blake
On 3/26/19 2:58 PM, Sam Eiderman wrote: > Commit fb2105b ("vmdk: Support version=3 in VMDK descriptor files") fixed > the probe function to correctly guess vmdk descriptors with version=3. All patches need to cc qemu-devel in addition to their maintainers (I've added that now). > > This solves

Re: [Qemu-devel] [PATCH for 4.0 v1 5/5] riscv: plic: Log guest errors

2019-03-26 Thread Philippe Mathieu-Daudé
Le jeu. 21 mars 2019 02:00, Alistair Francis a écrit : > Instead of using error_report() to print guest errors let's use > qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. > > Signed-off-by: Alistair Francis > --- > hw/riscv/sifive_plic.c | 12 +--- > 1 file changed, 9

[Qemu-devel] [PATCH] intel_iommu: Correct caching-mode error message

2019-03-26 Thread Alex Williamson
If we try to use the intel-iommu device with vfio-pci devices without caching mode enabled, we're told: qemu-system-x86_64: We need to set caching-mode=1 for intel-iommu to enable device assignment with IOMMU protection. But to enable caching mode, the option is actually "caching-mode=on".

[Qemu-devel] [RFC PATCH] pci: Use PCI aliases when determining device IOMMU address space

2019-03-26 Thread Alex Williamson
Conventional PCI buses pre-date requester IDs. An IOMMU cannot distinguish by devfn & bus between devices in a conventional PCI topology and therefore we cannot assign them separate AddressSpaces. By taking this requester ID aliasing into account, QEMU better matches the bare metal behavior and

Re: [Qemu-devel] [PATCH for 4.0 v1 0/5] Update the QEMU PLIC addresses

2019-03-26 Thread Alistair Francis
On Wed, Mar 20, 2019 at 5:45 PM Alistair Francis wrote: > > This series updates the PLIC address to match the documentation. > > This fixes: https://github.com/riscv/opensbi/issues/97 > > Alistair Francis (5): > riscv: plic: Fix incorrect irq calculation > riscv: sifive_u: Fix PLIC priority

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-03-26 Thread Philippe Mathieu-Daudé
Le mar. 26 mars 2019 15:34, Jag Raman a écrit : > > > On 3/26/2019 4:08 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 08, 2019 at 09:50:36AM +, Stefan Hajnoczi wrote: > >> On Thu, Mar 07, 2019 at 03:29:41PM -0800, John G Johnson wrote: > On Mar 7, 2019, at 11:27 AM, Stefan Hajnoczi >

Re: [Qemu-devel] [PATCH V2] RISC-V: fix single stepping over ret and other branching instructions

2019-03-26 Thread Alistair Francis
On Mon, Mar 25, 2019 at 9:59 AM Richard Henderson wrote: > > On 3/25/19 4:45 AM, Fabien Chouteau wrote: > > This patch introduces wrappers around the tcg_gen_exit_tb() and > > tcg_gen_lookup_and_goto_ptr() functions that handle single stepping, > > i.e. call gen_exception_debug() when single

Re: [Qemu-devel] [PATCH for 4.0 v1 1/1] MAINTAINERS: Update the device tree maintainers

2019-03-26 Thread Philippe Mathieu-Daudé
Le mar. 26 mars 2019 21:59, Alistair Francis a écrit : > Remove Alex as a Device Tree maintainer as requested by him. Add myself > as a maintainer to avoid it being orphaned. Also add David as a > Reviewer (R) as he is the libfdt and DTC maintainer. > > Signed-off-by: Alistair Francis > --- >

[Qemu-devel] [PATCH v3 1/3] block: introducing 'bdrv_co_delete_file' interface

2019-03-26 Thread Daniel Henrique Barboza
Adding to Block Drivers the capability of being able to clean up its created files can be useful in certain situations. For the LUKS driver, for instance, a failure in one of its authentication steps can leave files in the host that weren't there before. This patch adds the 'bdrv_co_delete_file'

[Qemu-devel] [PATCH v3 0/3] delete created files when block_crypto_co_create_opts_luks fails

2019-03-26 Thread Daniel Henrique Barboza
In this new interation, the following changes were made from the previous version [1]: - moved the 'generic' code from block.c to file-posix.c - moved the file delete call from qemu_img to the error path of block_crypto_co_create_opts_luks [1]

[Qemu-devel] [PATCH v3 3/3] crypto.c: cleanup created file when block_crypto_co_create_opts_luks fails

2019-03-26 Thread Daniel Henrique Barboza
When using a non-UTF8 secret to create a volume using qemu-img, the following error happens: $ qemu-img create -f luks --object secret,id=vol_1_encrypt0,file=vol_resize_pool.vol_1.secret.qzVQrI -o key-secret=vol_1_encrypt0 /var/tmp/pool_target/vol_1 10240K Formatting

[Qemu-devel] [PATCH v3 2/3] block.c: adding bdrv_delete_file

2019-03-26 Thread Daniel Henrique Barboza
Using the new 'bdrv_co_delete_file' interface, bdrv_delete_file can be used in a way similar of the existing bdrv_create_file to to clean up a created file. The logic is also similar to what is already done in bdrv_create_file: a qemu_coroutine is created if needed, a specialized function

[Qemu-devel] [PATCH for 4.0 v1 1/1] MAINTAINERS: Update the device tree maintainers

2019-03-26 Thread Alistair Francis
Remove Alex as a Device Tree maintainer as requested by him. Add myself as a maintainer to avoid it being orphaned. Also add David as a Reviewer (R) as he is the libfdt and DTC maintainer. Signed-off-by: Alistair Francis --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH] MAINTAINERS: DT: Remove myself and degrade

2019-03-26 Thread Alistair Francis
On Sat, Mar 23, 2019 at 6:29 PM David Gibson wrote: > > On Sat, Mar 23, 2019 at 11:20:39AM +0100, Philippe Mathieu-Daudé wrote: > > Le sam. 23 mars 2019 07:50, Alistair Francis a > > écrit : > > > > > On Thu, Mar 21, 2019 at 11:49 PM Peter Maydell > > > wrote: > > > > > > > > Alex and I just

Re: [Qemu-devel] [PATCH 06/35] cpu: Replace ENV_GET_CPU with env_cpu

2019-03-26 Thread Alistair Francis
On Sat, Mar 23, 2019 at 12:52 PM Richard Henderson wrote: > > Now that we have both ArchCPU and CPUArchState, we can define > this generically instead of via macro in each target's cpu.h. > > Signed-off-by: Richard Henderson Acked-by: Alistair Francis Alistair > --- >

Re: [Qemu-devel] [PATCH 05/35] cpu: Define ArchCPU

2019-03-26 Thread Alistair Francis
On Sat, Mar 23, 2019 at 12:48 PM Richard Henderson wrote: > > For all targets, do this just before including exec/cpu-all.h. > > Signed-off-by: Richard Henderson Acked-by: Alistair Francis Alistair > --- > target/alpha/cpu.h | 1 + > target/arm/cpu.h| 1 + > target/cris/cpu.h

Re: [Qemu-devel] [PATCH 04/35] cpu: Define CPUArchState with typedef

2019-03-26 Thread Alistair Francis
On Sat, Mar 23, 2019 at 12:54 PM Richard Henderson wrote: > > For all targets, do this just before including exec/cpu-all.h. > > Signed-off-by: Richard Henderson Acked-by: Alistair Francis Alistair > --- > target/alpha/cpu.h | 4 ++-- > target/arm/cpu.h| 4 ++-- >

Re: [Qemu-devel] [PATCH 03/35] tcg: Create struct CPUTLB

2019-03-26 Thread Alistair Francis
On Sat, Mar 23, 2019 at 12:47 PM Richard Henderson wrote: > > Move all softmmu tlb data into this structure. Arrange the > members so that we are able to place mask+table together and > at a smaller absolute offset from ENV. > > Signed-off-by: Richard Henderson Acked-by: Alistair Francis

Re: [Qemu-devel] [PATCH 02/35] tcg: Split out target/arch/cpu-param.h

2019-03-26 Thread Alistair Francis
On Sat, Mar 23, 2019 at 12:44 PM Richard Henderson wrote: > > For all targets, into this new file move TARGET_LONG_BITS, > TARGET_PAGE_BITS, TARGET_PHYS_ADDR_SPACE_BITS, > TARGET_VIRT_ADDR_SPACE_BITS, and NB_MMU_MODES. > > Include this new file from exec/cpu-defs.h. > > This now removes the

[Qemu-devel] [ANNOUNCE] QEMU 4.0.0-rc1 is now available

2019-03-26 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 4.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-4.0.0-rc1.tar.xz

Re: [Qemu-devel] Why is vhost-user limited to 8 slots?

2019-03-26 Thread Raphael Norwitz
ping From: Raphael Norwitz Date: Monday, March 18, 2019 at 7:10 PM To: "m...@redhat.com" Cc: "qemu-devel@nongnu.org" , Malcolm Crossley , Mike Cui , Felipe Franciosi Subject: [Qemu-devel] Why is vhost-user limited to 8 slots? Hi MST, Looking at the kernel commit log, I see that commit

Re: [Qemu-devel] [PATCH] Categorize devices

2019-03-26 Thread Philippe Mathieu-Daudé
Le mar. 26 mars 2019 20:10, Eduardo Habkost a écrit : > On Tue, Mar 26, 2019 at 07:43:51PM +0100, Hervé Poussineau wrote: > > Le 24/03/2019 à 19:05, Ernest Esene a écrit : > > > Categorize devices in "uncategorised devices" section > > > This patch is based on BiteSizedTask. > > > > > >

Re: [Qemu-devel] [PATCH] Categorize devices

2019-03-26 Thread Eduardo Habkost
On Tue, Mar 26, 2019 at 07:43:51PM +0100, Hervé Poussineau wrote: > Le 24/03/2019 à 19:05, Ernest Esene a écrit : > > Categorize devices in "uncategorised devices" section > > This patch is based on BiteSizedTask. > > > > Signed-off-by: Ernest Esene > > --- > > hw/dma/i82374.c | 2 ++

Re: [Qemu-devel] [PATCH for 4.1 v2 10/13] tests: acpi: add simple arm/virt testcase

2019-03-26 Thread Philippe Mathieu-Daudé
Le mar. 26 mars 2019 17:05, Igor Mammedov a écrit : > On Tue, 26 Mar 2019 15:27:39 +0100 > Laszlo Ersek wrote: > > > On 03/26/19 14:09, Igor Mammedov wrote: > > > adds simple arm/virt test case that starts guest with > > > bios-tables-test.aarch64.iso.qcow2 boot image which > > > initializes

Re: [Qemu-devel] [PATCH for 4.1 v2 10/13] tests: acpi: add simple arm/virt testcase

2019-03-26 Thread Philippe Mathieu-Daudé
Le mar. 26 mars 2019 15:28, Laszlo Ersek a écrit : > On 03/26/19 14:09, Igor Mammedov wrote: > > adds simple arm/virt test case that starts guest with > > bios-tables-test.aarch64.iso.qcow2 boot image which > > initializes UefiTestSupport* structure in RAM once > > guest is booted. > > > > *

Re: [Qemu-devel] [PATCH] Categorize devices

2019-03-26 Thread Hervé Poussineau
Le 24/03/2019 à 19:05, Ernest Esene a écrit : Categorize devices in "uncategorised devices" section This patch is based on BiteSizedTask. Signed-off-by: Ernest Esene --- hw/dma/i82374.c | 2 ++ hw/i386/amd_iommu.c | 2 ++ hw/i386/intel_iommu.c | 2 ++ hw/i386/pc_piix.c

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-03-26 Thread Markus Armbruster
Laszlo Ersek writes: > On 03/26/19 17:39, Markus Armbruster wrote: >> Laszlo Ersek writes: > >>> With the dynamic sizing in QEMU (which, IIRC, I had originally >>> introduced still in the 1MB times, due to the split between the >>> executable and varstore parts), both the 1MB->2MB switch, and

[Qemu-devel] [PATCH for-4.0] qemu-img: Gracefully shutdown when map can't finish

2019-03-26 Thread Eric Blake
Trying 'qemu-img map -f raw nbd://localhost:10809' causes the NBD server to output a scary message: qemu-nbd: Disconnect client, due to: Failed to read request: Unexpected end-of-file before all bytes were read This is because the NBD client, being remote, has no way to expose a human-readable

Re: [Qemu-devel] [PATCH for-4.0] nbd-client: Work around server BLOCK_STATUS misalignment at EOF

2019-03-26 Thread Eric Blake
On 3/26/19 12:13 PM, Eric Blake wrote: > The NBD spec is clear that a server that advertises a minimum block > size should reply to NBD_CMD_BLOCK_STATUS with extents aligned > accordingly. However, we know that the qemu NBD server implementation > has had a corner-case bug where it is not

[Qemu-devel] [Bug 1821430] Re: qemu-user-arm (4.0.0-rc0) crashes

2019-03-26 Thread asavah
qemu-user-arm 4.0.0-rc1 no longer produces any crashes for me. Huge thanks. ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1821430

Re: [Qemu-devel] [PATCH] qapi/migration.json: Fix documentation issue about query_colo_status

2019-03-26 Thread Eric Blake
On 3/26/19 12:45 PM, Zhang Chen wrote: > From: Zhang Chen > > The documentation with the wrong initial version number of last_mode field, > This patch just fix this issue. Grammar is a bit odd, but I'll leave it up to a maintainer if they want to improve it. I suggest a shorter: Fix a wrong

[Qemu-devel] [PATCH 0/2 v2] misc usb-mtp fixes

2019-03-26 Thread Bandan Das
v2: 1/2: Add Reviewed-by tag 2/2: remove extra vars and directly call usb_mtp_queue_result The first patch removes a unnecessary function and the second is just a code reorg of usb_mtp_write_data to make it less confusing. Applies on top of [PATCH v3] usb-mtp: fix return status of delete

[Qemu-devel] [PATCH 1/2 v2] usb-mtp: remove usb_mtp_object_free_one

2019-03-26 Thread Bandan Das
This function is used in the delete path only and can be replaced by a call to usb_mtp_object_free. Reviewed-by: Peter Maydell Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c

[Qemu-devel] [PULL] target/xtensa fixes for v4.0

2019-03-26 Thread Max Filippov
-xtensa.git tags/20190326-xtensa for you to fetch changes up to bc19449acc2e05854118a47cdf96c1e86b30740d: tests/tcg/xtensa: clean up test set (2019-03-23 14:42:05 -0700) target/xtensa fixes for v4.0: - fix translation of FLIX

[Qemu-devel] [PATCH 2/2 v2] usb-mtp: refactor the flow of usb_mtp_write_data

2019-03-26 Thread Bandan Das
There's no functional change but the flow is (hopefully) more consistent for both file and folder object types. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 53 1 file changed, 26 insertions(+), 27 deletions(-) diff --git a/hw/usb/dev-mtp.c

Re: [Qemu-devel] [PATCH] SiFive RISC-V GPIO Device

2019-03-26 Thread Fabien Chouteau
Hi Palmer, On 26/03/2019 09:58, Palmer Dabbelt wrote: > Do you have anything that actually glues this to a machine so I can test it? > In this patch I do instantiate the device in sifive_e machine. Regards,

Re: [Qemu-devel] [PATCH 2/3] target/arm: cortex-a7 and cortex-a15 have pmus

2019-03-26 Thread Andrew Jones
On Tue, Mar 26, 2019 at 05:38:36PM +, Aaron Lindsay OS wrote: > On Mar 22 17:23, Andrew Jones wrote: > > cortex-a7 and cortex-a15 have pmus (PMUv2) and they advertise > > them in ID_DFR0. Let's allow them to function. This also enables > > the pmu cpu property to work with these cpu types,

Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-26 Thread Markus Armbruster
Anthony PERARD writes: > On Tue, Mar 26, 2019 at 03:58:52PM +, Anthony PERARD wrote: >> On Wed, Mar 13, 2019 at 09:43:30AM +0100, Markus Armbruster wrote: >> > Recent commit cda4aa9a5a0 moved block backend creation before machine >> > property evaluation. This broke qemu-iotests 055. Turns

[Qemu-devel] [PATCH] qapi/migration.json: Fix documentation issue about query_colo_status

2019-03-26 Thread Zhang Chen
From: Zhang Chen The documentation with the wrong initial version number of last_mode field, This patch just fix this issue. Signed-off-by: Zhang Chen --- qapi/migration.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index

Re: [Qemu-devel] [PATCH 3/3] target/arm: make pmccntr_op_start/finish static

2019-03-26 Thread Aaron Lindsay OS
On Mar 22 17:23, Andrew Jones wrote: > These functions are not used outside helper.c > > Signed-off-by: Andrew Jones I'm late to the party, but: Reviewed-by: Aaron Lindsay > --- > target/arm/cpu.h| 11 --- > target/arm/helper.c | 4 ++-- > 2 files changed, 2 insertions(+), 13

Re: [Qemu-devel] [PATCH 1/3] target/arm: fix crash on pmu register access

2019-03-26 Thread Aaron Lindsay OS
On Mar 22 17:23, Andrew Jones wrote: > Fix a QEMU NULL derefence that occurs when the guest attempts to > enable PMU counters with a non-v8 cpu model or a v8 cpu model > which has not configured a PMU. > > Fixes: 4e7beb0cc0f3 ("target/arm: Add a timer to predict PMU counter > overflow") >

Re: [Qemu-devel] [PATCH 2/3] target/arm: cortex-a7 and cortex-a15 have pmus

2019-03-26 Thread Aaron Lindsay OS
On Mar 22 17:23, Andrew Jones wrote: > cortex-a7 and cortex-a15 have pmus (PMUv2) and they advertise > them in ID_DFR0. Let's allow them to function. This also enables > the pmu cpu property to work with these cpu types, i.e. we can > now do '-cpu cortex-a15,pmu=off' to remove the pmu. I'm a

Re: [Qemu-devel] [PULL 14/15] Migration/colo.c: Make user obtain the last COLO mode info after failover

2019-03-26 Thread Zhang, Chen
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, March 26, 2019 10:41 PM > To: Juan Quintela ; qemu-devel@nongnu.org > Cc: Dr. David Alan Gilbert ; zhanghailiang > ; Markus Armbruster > ; Zhang, Chen > Subject: Re: [PULL 14/15] Migration/colo.c: Make

Re: [Qemu-devel] [RFC] arm/cpu: fix soft lockup panic after resuming from stop

2019-03-26 Thread Steven Price
Hi Heyi, On 26/03/2019 13:53, Heyi Guo wrote: > I also tested save/restore operations, and observed that clock in guest > would not jump after restoring either. If we consider guest clock not > being synchronized with real wall clock as an issue, does it mean > save/restore function has the same

[Qemu-devel] [PATCH for-4.0 1/3] block: continue until base is found in bdrv_freeze_backing_chain() et al

2019-03-26 Thread Alberto Garcia
All three functions that handle the BdrvChild.frozen attribute walk the backing chain from 'bs' to 'base' and stop either when 'base' is found or at the end of the chain if 'base' is NULL. However if 'base' is not found then the functions return without errors as if it was NULL. This is wrong:

[Qemu-devel] [PATCH for-4.0] nbd-client: Work around server BLOCK_STATUS misalignment at EOF

2019-03-26 Thread Eric Blake
The NBD spec is clear that a server that advertises a minimum block size should reply to NBD_CMD_BLOCK_STATUS with extents aligned accordingly. However, we know that the qemu NBD server implementation has had a corner-case bug where it is not compliant with the spec, present since the introduction

[Qemu-devel] [PATCH for-4.0 2/3] block: freeze the backing chain earlier in stream_start()

2019-03-26 Thread Alberto Garcia
Commit 6585493369819a48d34a86d57ec6b97cb5cd9bc0 added code to freeze the backing chain from 'top' to 'base' for the duration of the block-stream job. The problem is that the freezing happens too late in stream_start(): during the bdrv_reopen_set_read_only() call earlier in that function another

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-26 Thread David Hildenbrand
On 26.03.19 15:08, Igor Mammedov wrote: > On Tue, 26 Mar 2019 14:50:58 +1100 > David Gibson wrote: > >> qemu_getrampagesize() works out the minimum host page size backing any of >> guest RAM. This is required in a few places, such as for POWER8 PAPR KVM >> guests, because limitations of the

[Qemu-devel] [PATCH for-4.0 0/3] freeze the backing chain earlier in stream_start()

2019-03-26 Thread Alberto Garcia
Hi, this series fixes the bug that I found the other day and described here: https://lists.gnu.org/archive/html/qemu-block/2019-03/msg00764.html https://lists.gnu.org/archive/html/qemu-block/2019-03/msg00791.html Patch 2 is the important one, patch 3 is a test case, and patch 1 will allow

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-03-26 Thread Laszlo Ersek
On 03/26/19 17:39, Markus Armbruster wrote: > Laszlo Ersek writes: >> With the dynamic sizing in QEMU (which, IIRC, I had originally >> introduced still in the 1MB times, due to the split between the >> executable and varstore parts), both the 1MB->2MB switch, and the >> 2MB->4MB switch in the

[Qemu-devel] [PATCH for-4.0 3/3] block: test block-stream with a base node that is used by block-commit

2019-03-26 Thread Alberto Garcia
The base node of a block-stream operation indicates the first image from the backing chain starting from which no data is copied to the top node. The block-stream job allows others to use that base image, so a second block-stream job could be writing to it at the same time. An important

[Qemu-devel] [Bug 1801073] Re: util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werro

2019-03-26 Thread Peter Maydell
In QEMU commit fd813c72392a712022d5d75a9 we upgraded our ipxe, so this bug should now be fixed in git master and in the upcoming 4.0 release. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2019-03-26 Thread Peter Maydell
We think we have shaken all the bugs out of the patchset which overhauls the Cocoa UI, so the crashes on OSX Mojave should be fixed in QEMU git master; these will be in QEMU 4.0. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a

[Qemu-devel] [Bug 1798780] Re: hw/usb/dev-mtp.c:1616: bad test ?

2019-03-26 Thread Peter Maydell
Fixed by commit 49f9e8d660d4 which will be in QEMU 4.0. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1798780 Title:

[Qemu-devel] [Bug 1794187] Re: improve error message, when using raspi3 and RAM>4G

2019-03-26 Thread Peter Maydell
** Tags added: arm ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1794187 Title: improve error message, when using raspi3 and RAM>4G Status in

Re: [Qemu-devel] [PULL 26/27] pc: Support firmware configuration with -blockdev

2019-03-26 Thread Markus Armbruster
Laszlo Ersek writes: > Hi Markus, > > (+Michal, Peter) > > On 03/11/19 23:08, Markus Armbruster wrote: >> The PC machines put firmware in ROM by default. To get it put into >> flash memory (required by OVMF), you have to use -drive >> if=pflash,unit=0,... and optionally -drive

[Qemu-devel] [Bug 1807675] Re: qemu commit 80422b0: tcg.c crash in temp_load

2019-03-26 Thread Peter Maydell
(Still repros as of commit d37bfe142382fa82585.) ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1807675 Title: qemu commit 80422b0: tcg.c crash

[Qemu-devel] megasas: Unexpected response from lun 1 while scanning, scan aborted

2019-03-26 Thread Dongli Zhang
I am reporting an error that the scsi lun cannot initialize successfully when I am emulating megasas scsi controller with qemu. I am not sure if this is issue in qemu or linux kernel. When 'lun=1' is specified, there is "Unexpected response from lun 1 while scanning, scan aborted". Everything

[Qemu-devel] [Bug 1810956] Re: qemu-2.12.1 crashes when running malicious bootloader.

2019-03-26 Thread Peter Maydell
I think this bug was fixed in QEMU 3.1 -- I can reproduce the assert on 3.0 but not on 3.1. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1811499] Re: qemu/net/colo-compare.c:288: possible pointless code duplication ?

2019-03-26 Thread Peter Maydell
The fix is now in master as commit 6d3aaa5b255ffc55a0561 and will be in QEMU 4.0. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811499

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-03-26 Thread Markus Armbruster
Laszlo Ersek writes: > On 03/26/19 07:17, Markus Armbruster wrote: >> Zheng Xiang writes: >> >>> Hi Peter, >>> >>> Thanks for your reply! >>> >>> On 2019/3/25 21:11, Peter Maydell wrote: On Mon, 25 Mar 2019 at 12:53, Xiang Zheng wrote: > > Currently we fill the VIRT_FLASH space

Re: [Qemu-devel] [PULL 0/7] Block layer patches

2019-03-26 Thread Peter Maydell
On Tue, 26 Mar 2019 at 15:52, Kevin Wolf wrote: > > The following changes since commit 527266f324def9f7f392fe3b0dd940cb8dc699d9: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-pflash-2019-03-26' > into staging (2019-03-26 09:57:07 +) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH] ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device

2019-03-26 Thread Peter Maydell
On Thu, 21 Mar 2019 at 07:10, Chen Zhang wrote: > > In fullscreen mode, the window property of cocoaView may not be the key > window, and the current implementation would not grab mouse in > fullscreen mode after left clicks on relative input devices. > > This patch used isFullscreen value as a

Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-26 Thread Anthony PERARD
On Tue, Mar 26, 2019 at 03:58:52PM +, Anthony PERARD wrote: > On Wed, Mar 13, 2019 at 09:43:30AM +0100, Markus Armbruster wrote: > > Recent commit cda4aa9a5a0 moved block backend creation before machine > > property evaluation. This broke qemu-iotests 055. Turns out we need > > to create the

Re: [Qemu-devel] [PATCH v2] ui/cocoa: Fix absolute input device grabbing issues on Mojave

2019-03-26 Thread Peter Maydell
On Tue, 19 Mar 2019 at 03:51, Chen Zhang wrote: > > On Mojave, absolute input device, i.e. tablet, had trouble re-grabbing > the cursor in re-entry into the virtual screen area. In some cases, > the `window` property of NSEvent object is nil, after exit of cursor, > meaning that the

[Qemu-devel] [Bug 1821771] [NEW] KVM guest does not reflect numa distances configured through qemu

2019-03-26 Thread Satheesh Rajendran
Public bug reported: KVM guest does not reflect numa distances configured through qemu Env: Host/Guest Kernel: 5.1.0-rc1-g72999bbdc qemu : 3.1.90 (v2.8.0-rc0-18614-g278aebafa0-dirty) [repo: https://github.com/dgibson/qemu; branch:ppc-for-4.1 ] # git log -1 commit

Re: [Qemu-devel] [PATCH for 4.1 v2 10/13] tests: acpi: add simple arm/virt testcase

2019-03-26 Thread Igor Mammedov
On Tue, 26 Mar 2019 15:27:39 +0100 Laszlo Ersek wrote: > On 03/26/19 14:09, Igor Mammedov wrote: > > adds simple arm/virt test case that starts guest with > > bios-tables-test.aarch64.iso.qcow2 boot image which > > initializes UefiTestSupport* structure in RAM once > > guest is booted. > > > >

[Qemu-devel] [PULL 6/7] qemu-img: Use BDRV_REQ_NO_FALLBACK for pre-zeroing

2019-03-26 Thread Kevin Wolf
If qemu-img convert sees that the target image isn't zero-initialised yet, it tries to do an efficient zero write for the whole image first to save the overhead of repeated explicit zero writes during the conversion. Obviously, this provides only an advantage if the pre-zeroing is actually

Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-26 Thread Anthony PERARD
On Wed, Mar 13, 2019 at 09:43:30AM +0100, Markus Armbruster wrote: > Recent commit cda4aa9a5a0 moved block backend creation before machine > property evaluation. This broke qemu-iotests 055. Turns out we need > to create the migration object before block backends, so block > backends can add

[Qemu-devel] [PULL 7/7] qemu-io: Add write -n for BDRV_REQ_NO_FALLBACK

2019-03-26 Thread Kevin Wolf
This makes the new BDRV_REQ_NO_FALLBACK flag available in the qemu-io write command. Signed-off-by: Kevin Wolf Acked-by: Eric Blake --- qemu-io-cmds.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 35dcdcf413..09750a23ce

[Qemu-devel] [PULL 3/7] block: Add BDRV_REQ_NO_FALLBACK

2019-03-26 Thread Kevin Wolf
For qemu-img convert, we want an operation that zeroes out the whole image if this can be done efficiently, but that returns an error otherwise so we don't write explicit zeroes and immediately overwrite them with the real data, potentially doubling the amount of data to be written.

[Qemu-devel] [PULL 5/7] file-posix: Support BDRV_REQ_NO_FALLBACK for zero writes

2019-03-26 Thread Kevin Wolf
We know that the kernel implements a slow fallback code path for BLKZEROOUT, so if BDRV_REQ_NO_FALLBACK is given, we shouldn't call it. The other operations we call in the context of .bdrv_co_pwrite_zeroes should usually be quick, so no modification should be needed for them. If we ever notice

[Qemu-devel] [PULL 2/7] block: Remove error messages in bdrv_make_zero()

2019-03-26 Thread Kevin Wolf
There is only a single caller of bdrv_make_zero(), which is qemu-img convert. If the function fails, we just fall back to a different method of zeroing out blocks on the target image. There is no good reason to print error messages on stderr when the higher level operation will actually succeed.

[Qemu-devel] [PULL 4/7] block: Advertise BDRV_REQ_NO_FALLBACK in filter drivers

2019-03-26 Thread Kevin Wolf
Filter drivers that support .bdrv_co_pwrite_zeroes can safely advertise BDRV_REQ_NO_FALLBACK because they just forward the request flags to their child node. Signed-off-by: Kevin Wolf Acked-by: Eric Blake --- block/blkdebug.c | 2 +- block/copy-on-read.c | 7 +++ block/mirror.c |

[Qemu-devel] [PULL 1/7] iotests: add 248: test resume mirror after auto pause on ENOSPC

2019-03-26 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Test that mirror job actually resume on resume command after being automatically paused on ENOSPC error. It's a follow-up test for 8d9648cbf3e "blockjob: fix user pause in block_job_error_action" Signed-off-by: Vladimir Sementsov-Ogievskiy Tested-by:

[Qemu-devel] [PULL 0/7] Block layer patches

2019-03-26 Thread Kevin Wolf
The following changes since commit 527266f324def9f7f392fe3b0dd940cb8dc699d9: Merge remote-tracking branch 'remotes/armbru/tags/pull-pflash-2019-03-26' into staging (2019-03-26 09:57:07 +) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

Re: [Qemu-devel] [PATCH 0/3] migration: add sztd compression

2019-03-26 Thread Denis Plotnikov
ping ping ping ping ping! On 18.03.2019 10:53, Denis Plotnikov wrote: > ping ping ping ping! > > On 11.03.2019 11:20, Denis Plotnikov wrote: >> ping ping ping! >> >> On 04.03.2019 18:10, Denis Plotnikov wrote: >>> ping! >>> >>> On 26.02.2019 16:15, Denis Plotnikov wrote: zstd date

Re: [Qemu-devel] [PATCH for 4.1 v2 09/13] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-03-26 Thread Laszlo Ersek
On 03/26/19 15:19, Laszlo Ersek wrote: > On 03/26/19 14:09, Igor Mammedov wrote: >> once FW provides a pointer to SMBIOS entry point like it does for >> RSDP it should be possible to enable this one the same way. >> >> Signed-off-by: Igor Mammedov >> --- >> tests/bios-tables-test.c | 7 +--

[Qemu-devel] [Bug 1813305] Re: trace-root.h is not regerenerated after re-configure

2019-03-26 Thread Peter Maydell
This was fixed by commit 57b7bdf426445d83561, which will be in the 4.0 release. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1813305 Title:

[Qemu-devel] [Bug 1805445] Re: QEMU arm virt machine was stopped by STMFD command while debug process

2019-03-26 Thread Peter Maydell
I think there isn't a QEMU bug to address here, so I'm going to close this bug. Please let us know if there's anything we've missed. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1806243] Re: ARM conditional branch after if-then instruction not working

2019-03-26 Thread Peter Maydell
I think this was probably fixed by commit c2d9644e6d517170b, which was in QEMU 3.1.0 -- that commit certainly fixes some kinds of crash if guest code tried to do an UNPREDICTABLE conditional instruction inside an IT block. Could you try again with that version of QEMU, or at least provide a repro

[Qemu-devel] [Bug 1455912] Re: vnc websocket option not properly parsed when running on commandline

2019-03-26 Thread Peter Maydell
Dan's patch linked in comment #4 went into git as commit 1b1aeb5828c978a, so this has been fixed (with the fix going into the 2.9.0 release). ** Changed in: qemu Status: In Progress => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [Qemu-devel] [PATCH v3 0/4] target/arm: Implement ARMv8.5-BTI

2019-03-26 Thread Richard Henderson
On 3/26/19 6:57 AM, Peter Maydell wrote: > I'm pretty sure we talked about this on IRC at some point, > but for the record: I believe the relevent ELF ABI spec docs > are now public that have the changes that describe how ELF > executables are marked up to indicate which parts should be > loaded

[Qemu-devel] [Bug 1754605] Re: ppc64 migration bad_dest test is failed with failed to connect to socket

2019-03-26 Thread Peter Maydell
David's patch fixing this went in as commit f96d6651e4b7cb8a8e91, which will have been in the 3.0 release. ** Changed in: qemu Status: In Progress => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1294227] Re: migration wrong handling of KVM_GET_DIRTY_LOG ioctl

2019-03-26 Thread Peter Maydell
The apparently obvious fix was applied as commit b533f658a98325d0e4 but then reverted in commit 50212d6346f33d6e19, because not all errno returns from this ioctl should be treated as errors. That commit message said "Revert that patch instead of fixing it properly this late in the release

[Qemu-devel] [Bug 1796754] Re: ioctl SIOCGIFCONF causes qemu-aarch64-static to crash with "received signal outside vCPU context"

2019-03-26 Thread Peter Maydell
Kan Li's patch was applied to master as commit 22e4a267a6627e5b5b, so this will be fixed in the upcoming QEMU 4.0 release. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

  1   2   3   >