Re: [Qemu-devel] [PATCH] tci: Add implementation for INDEX_op_ld16u_i64

2019-04-10 Thread Richard Henderson
On 4/10/19 9:48 AM, Stefan Weil wrote: > @@ -127,6 +127,12 @@ static void tci_write_reg8(tcg_target_ulong *regs, > TCGReg index, uint8_t value) > tci_write_reg(regs, index, value); > } > > +static void > +tci_write_reg16(tcg_target_ulong *regs, TCGReg index, uint16_t value) > +{ > +tci

[Qemu-devel] [PATCH] ppc/spapr: Add H_PROD and H_CONFER

2019-04-10 Thread Cédric Le Goater
From: Benjamin Herrenschmidt H_PROD should be fully functional, H_CEDE is modified to ignore a proded CPU. H_CONFER is a stub to avoid returning an error. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater --- target/ppc/cpu.h | 3 +++ hw/ppc/spapr_hcall.c | 37 +++

Re: [Qemu-devel] [PATCH RFC 2/3] pxtool: Add new qemu-img command info generation tool

2019-04-10 Thread Markus Armbruster
John Snow writes: > On 4/10/19 1:54 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Presently we use hxtool and a .hx format to generate a few things like >>> the qemu_img subcommand dispatch table, the qemu_img help() display output, >>> and a help output in qemu-img.texi. >>> >>> Unf

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-10 Thread Richard Henderson
On 4/9/19 8:17 PM, Stefan Weil wrote: > On 09.04.19 22:39, Richard Henderson wrote: >> On 4/9/19 9:46 AM, Stefan Weil wrote: >>> * Calling conventions. The current implementation works on many hosts, >>> but for example not on Sparc. A fix would require simple calling >>> conventions for all helper

Re: [Qemu-devel] [PATCH] tci: Add implementation for INDEX_op_ld16u_i64

2019-04-10 Thread Thomas Huth
On 10/04/2019 21.48, Stefan Weil wrote: > This fixes "make check-tcg" on a Debian x86_64 host. > > Signed-off-by: Stefan Weil > --- > tcg/tci.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/tcg/tci.c b/tcg/tci.c > index 33edca1903..a6208653e8 100644 > --- a/tcg/tci.c

Re: [Qemu-devel] QEMU Logo question

2019-04-10 Thread Thomas Huth
On 10/04/2019 19.51, Barajas, Felipe wrote: > Hi, > > I am trying to understand who in the QEMU community can give me permission to > use the QEMU logo in a whitepaper. > I am an application engineer at Intel and I have prepared some benchmarks > using QEMU as a solution accelerated by Intel har

Re: [Qemu-devel] [PATCH for-4.0] hw/i386/pc: Fix crash when hot-plugging nvdimm on older machine types

2019-04-10 Thread Thomas Huth
Hi, On 11/04/2019 03.56, Wei Yang wrote: > On Mon, Apr 08, 2019 at 09:29:11PM +, Wei Yang wrote: Thomas, Thanks for pointing this out, while I have some different idea on how to fix this. The reason of the core dump is errp already been set in hot

Re: [Qemu-devel] [PATCH for-4.0-maybe] device_tree: Fix integer overflowing in load_device_tree()

2019-04-10 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 4/10/19 8:34 AM, Alistair Francis wrote: >> On Tue, Apr 9, 2019 at 10:59 PM Markus Armbruster wrote: >>> Philippe Mathieu-Daudé writes: On 4/10/19 7:28 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: [...] >> BTW how did you figure

Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-10 Thread Eric Farman
On 4/9/19 7:34 PM, Halil Pasic wrote: On Mon, 8 Apr 2019 19:07:47 +0200 Cornelia Huck wrote: On Mon, 8 Apr 2019 13:02:12 -0400 Farhan Ali wrote: On 03/01/2019 04:38 AM, Cornelia Huck wrote: When we get a solicited interrupt, the start function may have been cleared by a csch, but we sti

Re: [Qemu-devel] [PATCH for-4.0] hw/i386/pc: Fix crash when hot-plugging nvdimm on older machine types

2019-04-10 Thread Wei Yang
On Mon, Apr 08, 2019 at 09:29:11PM +, Wei Yang wrote: >>> >>> Thomas, >>> >>> Thanks for pointing this out, while I have some different idea on how to fix >>> this. >>> >>> The reason of the core dump is errp already been set in >>> hotplug_handler_pre_plug(), and this function check acpi ho

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-10 Thread Wei Yang
On Wed, Apr 10, 2019 at 05:01:50PM +0200, Igor Mammedov wrote: >On Wed, 10 Apr 2019 22:27:56 +0800 >Wei Yang wrote: > >[...] >> >@@ -2411,19 +2410,7 @@ build_mcfg_q35(GArray *table_data, BIOSLinker >> >*linker, AcpiMcfgInfo *info) >> > mcfg->allocation[0].start_bus_number = 0; >> > mcfg->

Re: [Qemu-devel] [PATCH] qemu-img: fix .hx and .texi disparity

2019-04-10 Thread John Snow
On 4/10/19 2:22 PM, Eric Blake wrote: > On 4/10/19 12:37 PM, John Snow wrote: >> >> >> On 4/10/19 1:39 AM, Markus Armbruster wrote: >>> John Snow writes: >>> It turns out that having options listed in three places continues to be a bad idea. I'm still toying with the idea of an improv

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-10 Thread Michael S. Tsirkin
On Wed, Apr 10, 2019 at 08:15:32PM +0100, Stefan Hajnoczi wrote: > On Wed, Apr 10, 2019 at 4:45 PM Yoni Bettan wrote: > > On 4/9/19 4:17 PM, Stefan Hajnoczi wrote: > > > On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: > > The final purpose is to have: > > > > 1. device specification >

Re: [Qemu-devel] [PATCH] hostmem-file: warn when memory-backend-file, share=on and in incoming migration

2019-04-10 Thread Catherine Ho
Hi Dr. David On Thu, 11 Apr 2019 at 00:57, Dr. David Alan Gilbert wrote: > * Catherine Ho (catherine.h...@gmail.com) wrote: > > Hi Dr. David > > > > On Wed, 10 Apr 2019 at 22:59, Dr. David Alan Gilbert < > dgilb...@redhat.com> > > wrote: > > > > > * Catherine Ho (catherine.h...@gmail.com) wrote:

Re: [Qemu-devel] Questions about acpi interrupt link device's ‘_PRS' field

2019-04-10 Thread Li Qiang
Paolo Bonzini 于2019年4月10日周三 下午11:55写道: > On 10/04/19 16:33, Li Qiang wrote: > > Hi all, > > > > > > > > I see the link device ‘_PRS’ uses irq line 5, 10, 11 in > > ‘build_link_dev’ function. > > > > But I never see the 5 lines uses in the guest, just uses 10 and 11. > > > > Why this happen? May

[Qemu-devel] [PATCH for 4.1 v3 0/6] RISC-V: Allow specifying CPU ISA via command line

2019-04-10 Thread Alistair Francis
This patch series adds a generic RISC-V CPU that can be generated at run time based on the ISA string specified to QEMU via the -cpu argument. This is supported on the virt and spike boards allowing users to specify the RISC-V extensions as well as the ISA version. As part of the conversion we hav

Re: [Qemu-devel] [PATCH] target/riscv: Remove unused include of riscv_htif.h for virt board

2019-04-10 Thread Alistair Francis
On Wed, Apr 10, 2019 at 9:30 AM Jonathan Behrens wrote: > > Unless I'm missing something, the virt board doesn't support HTIF and > should not be including this header. Thanks for the patch! You aren't missing anything, it can be removed. > > Jonathan Can you send a v2 without the uncertainty

[Qemu-devel] [PATCH for 4.1 v3 2/6] target/riscv: Fall back to generating a RISC-V CPU

2019-04-10 Thread Alistair Francis
If a user specifies a CPU that we don't understand then we want to fall back to a CPU generated from the ISA string. At the moment the generated CPU is assumed to be a privledge spec version 1.10 CPU with an MMU. This can be changed in the future. Signed-off-by: Alistair Francis --- v3: - Ensur

[Qemu-devel] [PATCH for 4.1 v3 4/6] riscv: virt: Allow specifying a CPU via commandline

2019-04-10 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/riscv/virt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index fc4c6b306e..5b25f028ad 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -400,7 +400,7 @@ static void riscv_virt_board_init(Machine

[Qemu-devel] [PATCH for 4.1 v3 1/6] linux-user/riscv: Add the CPU type as a comment

2019-04-10 Thread Alistair Francis
Signed-off-by: Alistair Francis --- linux-user/riscv/target_elf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/riscv/target_elf.h b/linux-user/riscv/target_elf.h index a6716a6aac..9dd65652ee 100644 --- a/linux-user/riscv/target_elf.h +++ b/linux-user/riscv/target_elf.h @@ -9,6 +

[Qemu-devel] [PATCH for 4.1 v3 6/6] riscv: Add a generic spike machine

2019-04-10 Thread Alistair Francis
Add a generic spike machine (not tied to a version) and deprecate the spike mahines that are tied to a specific version. As we can now specify the CPU via the command line we no londer need specific versions of the spike machines. Signed-off-by: Alistair Francis --- hw/riscv/spike.c | 106 ++

[Qemu-devel] [PATCH for 4.1 v3 5/6] target/riscv: Remove the generic no MMU CPUs

2019-04-10 Thread Alistair Francis
These can now be specified via the command line so we no longer need these. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 2 -- target/riscv/cpu.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index c792bacd24..9ba77a1983 100644 --- a/ta

[Qemu-devel] [PATCH for 4.1 v3 3/6] target/riscv: Create settable CPU properties

2019-04-10 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 52 ++ target/riscv/cpu.h | 8 +++ 2 files changed, 56 insertions(+), 4 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 27be9e412a..c792bacd24 100644 --- a/target/ris

Re: [Qemu-devel] [PATCH 0/3] vhost-scsi: Support live migration

2019-04-10 Thread Liran Alon
> On 9 Apr 2019, at 17:29, Stefan Hajnoczi wrote: > > On Thu, Mar 21, 2019 at 09:55:42AM +0200, Nir Weiner wrote: >> Originally migration was not possible with vhost-scsi because >> as part of migration, the source host target SCSI device state >> needs to be saved and loaded into the destinat

Re: [Qemu-devel] [PATCH] sd: Fix out-of-bounds assertions

2019-04-10 Thread Lidong Chen
Hi, Thank you all for the reviews and comments! Since the fixes in sd.c have gone through the review, I can fix the issue in util/main-loop.c (mentioned in the reviews of Peter and Liam) in a separate patch. Thanks, Lidong On 4/9/2019 3:39 AM, Liam Merwick wrote: On 09/04/2019 06:51, Marku

Re: [Qemu-devel] [ANNOUNCE] QEMU 4.0.0-rc3 is now available

2019-04-10 Thread Andrew Randrianasulu
Please also include this patch in next -rc or final, it fixes 32-bit compilation: https://patchew.org/QEMU/20190402073018.17747-1-kraxel%40redhat.com/ ([Qemu-devel] [PATCH] curses: fix wchar_t printf warning) without it I get ui/curses.c: In function 'get_ucs': ui/curses.c:456:25: error: forma

Re: [Qemu-devel] [PATCH] hw/char/escc: Lower irq when transmit buffer is filled

2019-04-10 Thread Stephen Checkoway
On Apr 10, 2019, at 16:01, Philippe Mathieu-Daudé wrote: > On 3/6/19 12:01 PM, Paolo Bonzini wrote: >> On 05/03/19 06:10, Stephen Checkoway wrote: >>> The SCC/ESCC will briefly stop asserting an interrupt when the >>> transmit FIFO is filled. >>> >>> This code doesn't model the transmit FIFO/

[Qemu-devel] [PATCH v2 6/6] iotests: Test qemu-img convert --salvage

2019-04-10 Thread Max Reitz
This test converts a simple image to another, but blkdebug injects block_status and read faults at some offsets. The resulting image should be the same as the input image, except that sectors that could not be read have to be 0. Signed-off-by: Max Reitz --- tests/qemu-iotests/249 | 163

[Qemu-devel] [PATCH v2 3/6] blkdebug: Add @iotype error option

2019-04-10 Thread Max Reitz
This new error option allows users of blkdebug to inject errors only on certain kinds of I/O operations. Users usually want to make a very specific operation fail, not just any; but right now they simply hope that the event that triggers the error injection is followed up with that very operation.

[Qemu-devel] [PATCH v2 1/6] qemu-img: Move quiet into ImgConvertState

2019-04-10 Thread Max Reitz
Move img_convert()'s quiet flag into the ImgConvertState so it is accessible by nested functions. -q dictates that it suppresses anything but errors, so if those functions want to emit warnings, they need to query this flag first. (There currently are no such warnings, but there will be as of the

[Qemu-devel] [PATCH v2 4/6] blkdebug: Add "none" event

2019-04-10 Thread Max Reitz
Together with @iotypes and @sector, this can be used to trap e.g. the first read or write access to a certain sector without having to know what happens internally in the block layer, i.e. which "real" events happen right before such an access. Signed-off-by: Max Reitz --- qapi/block-core.json |

[Qemu-devel] [PATCH v2 5/6] blkdebug: Inject errors on .bdrv_co_block_status()

2019-04-10 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qapi/block-core.json | 5 - block/blkdebug.c | 8 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 717b13f7f5..2aa675a192 100644 --- a/qapi/block-core.json +++ b/

[Qemu-devel] [PATCH v2 2/6] qemu-img: Add salvaging mode to convert

2019-04-10 Thread Max Reitz
This adds a salvaging mode (--salvage) to qemu-img convert which ignores read errors and treats the respective areas as containing only zeroes. This can be used for instance to at least partially recover the data from terminally corrupted qcow2 images. Signed-off-by: Max Reitz --- qemu-img.c

[Qemu-devel] [PATCH v2 0/6] qemu-img: Add salvaging mode to convert

2019-04-10 Thread Max Reitz
Hi, This series adds a --salvage option to qemu-img convert. With this, qemu-img will not abort when it encounters an I/O error. Instead, it tries to narrow it down and will treat the affected sectors as being completely 0 (and print a warning). Testing this is not so easy, because while real I

Re: [Qemu-devel] [PATCH 4/7] iotests: Update 241 to expose backing layer fragmentation

2019-04-10 Thread Eric Blake
On 4/8/19 8:51 AM, Vladimir Sementsov-Ogievskiy wrote: > 03.04.2019 6:05, Eric Blake wrote: >> Previous commits have mentioned that our NBD server still sends >> unaligned fragments when an active layer with large advertised minimum >> block size is backed by another layer with a smaller block >> s

[Qemu-devel] [PATCH for-4.0?] iotest: Fix 241 to run in generic directory

2019-04-10 Thread Eric Blake
Filter the qemu-nbd server output to get rid of a direct reference to my build directory. Fixes: e9dce9cb Reported-by: Max Reitz Signed-off-by: Eric Blake --- Not worth -rc4 on its own, but if something else pops up that requires another spin, I plan on a pull request for this one. Otherwise it

[Qemu-devel] [PATCH v4 08/11] iotests: Add filter commit test cases

2019-04-10 Thread Max Reitz
This patch adds some tests on how commit copes with filter nodes. Signed-off-by: Max Reitz --- tests/qemu-iotests/040 | 130 + tests/qemu-iotests/040.out | 4 +- 2 files changed, 132 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/040 b/te

[Qemu-devel] [PATCH v4 04/11] block: Inline bdrv_co_block_status_from_*()

2019-04-10 Thread Max Reitz
With bdrv_filtered_rw_bs(), we can easily handle this default filter behavior in bdrv_co_block_status(). blkdebug wants to have an additional assertion, so it keeps its own implementation, except bdrv_co_block_status_from_file() needs to be inlined there. Suggested-by: Eric Blake Signed-off-by:

[Qemu-devel] [PATCH v4 02/11] block: Filtered children access functions

2019-04-10 Thread Max Reitz
What bs->file and bs->backing mean depends on the node. For filter nodes, both signify a node that will eventually receive all R/W accesses. For format nodes, bs->file contains metadata and data, and bs->backing will not receive writes -- instead, writes are COWed to bs->file. Usually. In any c

[Qemu-devel] [PATCH v4 11/11] iotests: Test committing to overridden backing

2019-04-10 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/040 | 61 ++ tests/qemu-iotests/040.out | 4 +-- 2 files changed, 63 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040 index dc3fe57fbd..155c1d8c23 100755 --- a/tests

[Qemu-devel] [PATCH v4 10/11] iotests: Add test for commit in sub directory

2019-04-10 Thread Max Reitz
Add a test for committing an overlay in a sub directory to one of the images in its backing chain, using both relative and absolute filenames. Signed-off-by: Max Reitz --- tests/qemu-iotests/020 | 36 tests/qemu-iotests/020.out | 10 ++ 2 files ch

[Qemu-devel] [PATCH v4 09/11] iotests: Add filter mirror test cases

2019-04-10 Thread Max Reitz
This patch adds some test cases how mirroring relates to filters. One of them tests what happens when you mirror off a filtered COW node, two others use the mirror filter node as basically our only example of an implicitly created filter node so far (besides the commit filter). Signed-off-by: Max

[Qemu-devel] [PATCH v4 06/11] iotests: Add tests for mirror @replaces loops

2019-04-10 Thread Max Reitz
This adds two tests for cases where our old check_to_replace_node() function failed to detect that executing this job with these parameters would result in a cyclic graph. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/041 | 124 +

[Qemu-devel] [PATCH v4 07/11] block: Leave BDS.backing_file constant

2019-04-10 Thread Max Reitz
Parts of the block layer treat BDS.backing_file as if it were whatever the image header says (i.e., if it is a relative path, it is relative to the overlay), other parts treat it like a cache for bs->backing->bs->filename (relative paths are relative to the CWD). Considering bs->backing->bs->filena

[Qemu-devel] [PATCH v4 05/11] block: Fix check_to_replace_node()

2019-04-10 Thread Max Reitz
Currently, check_to_replace_node() only allows mirror to replace a node in the chain of the source node, and only if it is the first non-filter node below the source. Well, technically, the idea is that you can exactly replace a quorum child by mirroring from quorum. This has (probably) two reaso

[Qemu-devel] [PATCH v4 03/11] block: Storage child access function

2019-04-10 Thread Max Reitz
For completeness' sake, add a function for accessing a node's storage child, too. For filters, this is their filtered child; for non-filters, this is bs->file. Some places are deliberately left unconverted: - BDS opening/closing functions where bs->file is handled specially (which is basically

[Qemu-devel] [PATCH v4 01/11] block: Mark commit and mirror as filter drivers

2019-04-10 Thread Max Reitz
The commit and mirror block nodes are filters, so they should be marked as such. (Strictly speaking, BDS.is_filter's documentation states that a filter's child must be bs->file. The following patch will relax this restriction, however.) Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Revi

[Qemu-devel] [PATCH v4 00/11] block: Deal with filters

2019-04-10 Thread Max Reitz
Note: This is technically the first part of my active mirror followup. But just very technically. I noticed that that followup started to consist of two parts, namely (A) fix filtery things in the block layer, and (B) fix active mirror. So I decided to split it. This is part A. Part B is “mirror

Re: [Qemu-devel] [PATCH] hw/char/escc: Lower irq when transmit buffer is filled

2019-04-10 Thread Philippe Mathieu-Daudé
On 3/6/19 12:01 PM, Paolo Bonzini wrote: > On 05/03/19 06:10, Stephen Checkoway wrote: >> The SCC/ESCC will briefly stop asserting an interrupt when the >> transmit FIFO is filled. >> >> This code doesn't model the transmit FIFO/shift register so the >> pending transmit interrupt is never deasserte

[Qemu-devel] [PATCH] tci: Add implementation for INDEX_op_ld16u_i64

2019-04-10 Thread Stefan Weil
This fixes "make check-tcg" on a Debian x86_64 host. Signed-off-by: Stefan Weil --- tcg/tci.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tcg/tci.c b/tcg/tci.c index 33edca1903..a6208653e8 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -127,6 +127,12 @@ static void tci_write_

[Qemu-devel] [ANNOUNCE] QEMU 4.0.0-rc3 is now available

2019-04-10 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 4.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-4.0.0-rc3.tar.xz http://down

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-10 Thread Stefan Hajnoczi
On Wed, Apr 10, 2019 at 4:45 PM Yoni Bettan wrote: > On 4/9/19 4:17 PM, Stefan Hajnoczi wrote: > > On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: > The final purpose is to have: > > 1. device specification > > 2. device implementation > > 3. device driver > > 4. blog > > maybe I shou

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-10 Thread Stefan Hajnoczi
On Wed, Apr 10, 2019 at 4:45 PM Yoni Bettan wrote: > On 4/9/19 4:17 PM, Stefan Hajnoczi wrote: > > On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: > > There are multiple problems with the code, but the larger issue is that > > this example device is just helping people shoot themselve

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-10 Thread Stefan Weil
On 10.04.19 10:22, Thomas Huth wrote: > Additionally, I think it should be possible to compile with the > x86_64-linux-user target and then to run "make check-tcg" ... however, > that currently crashes with: > > TODO qemu/tcg/tci.c:859: tcg_qemu_tb_exec() > qemu/tcg/tci.c:859: tcg fatal error > qe

Re: [Qemu-devel] [PATCH for-4.1 v2] qemu-img: Saner printing of large file sizes

2019-04-10 Thread Max Reitz
On 01.04.19 16:57, Eric Blake wrote: > Disk sizes close to INT64_MAX cause overflow, for some pretty > ridiculous output: > > $ ./nbdkit -U - memory size=$((2**63 - 512)) --run 'qemu-img info $nbd' > image: nbd+unix://?socket=/tmp/nbdkitHSAzNz/socket > file format: raw > virtual size: -838

Re: [Qemu-devel] [PATCH for-4.0?] hmp: delvm: use hmp_handle_error

2019-04-10 Thread Cole Robinson
On 4/10/19 2:27 PM, Eric Blake wrote: > On 4/10/19 1:03 PM, Cole Robinson wrote: >> This gives us the consistent 'Error:' prefix added in 66363e9a43f, >> which helps users like libvirt who still need to scrape hmp error >> messages to detect failure. >> >> Signed-off-by: Cole Robinson >> --- >> h

[Qemu-devel] QEMU Logo question

2019-04-10 Thread Barajas, Felipe
Hi, I am trying to understand who in the QEMU community can give me permission to use the QEMU logo in a whitepaper. I am an application engineer at Intel and I have prepared some benchmarks using QEMU as a solution accelerated by Intel hardware (CPUs, SSDs, etc) I would like to use the QEMU log

Re: [Qemu-devel] [PATCH for-4.0?] hmp: delvm: use hmp_handle_error

2019-04-10 Thread Eric Blake
On 4/10/19 1:03 PM, Cole Robinson wrote: > This gives us the consistent 'Error:' prefix added in 66363e9a43f, > which helps users like libvirt who still need to scrape hmp error > messages to detect failure. > > Signed-off-by: Cole Robinson > --- > hmp.c | 7 --- > 1 file changed, 4 insertio

Re: [Qemu-devel] [PATCH v2] target/i386: kvm: add VMX migration blocker

2019-04-10 Thread Cole Robinson
On 11/20/18 6:44 AM, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> Nested VMX does not support live migration yet. Add a blocker >> until that is worked out. >> >> Nested SVM only does not support it, but unfortunately it is >> enabled by default for -cpu host so

Re: [Qemu-devel] [PATCH] qemu-img: fix .hx and .texi disparity

2019-04-10 Thread Eric Blake
On 4/10/19 12:37 PM, John Snow wrote: > > > On 4/10/19 1:39 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> It turns out that having options listed in three places continues to be >>> a bad idea. I'm still toying with the idea of an improved infrastructure >>> here, but in the meantime,

Re: [Qemu-devel] [PATCH for-4.1] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description

2019-04-10 Thread Laszlo Ersek
On 04/10/19 17:10, Philippe Mathieu-Daudé wrote: > On 4/10/19 4:58 PM, Laszlo Ersek wrote: >> On 04/10/19 06:57, Philippe Mathieu-Daudé wrote: >>> In commit 1cab464136b4 we incorrectly described the >>> EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS >>> options to the EDK2 build tools, but it

[Qemu-devel] [PATCH] hmp: delvm: use hmp_handle_error

2019-04-10 Thread Cole Robinson
This gives us the consistent 'Error:' prefix added in 66363e9a43f, which helps users like libvirt who still need to scrape hmp error messages to detect failure. Signed-off-by: Cole Robinson --- hmp.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hmp.c b/hmp.c index 8

Re: [Qemu-devel] [Qemu-block] [PULL 07/14] iotests: Add 241 to test NBD on unaligned images

2019-04-10 Thread Eric Blake
On 4/10/19 12:45 PM, Max Reitz wrote: > On 01.04.19 16:08, Eric Blake wrote: >> Add a test for the NBD client workaround in the previous patch. It's >> not really feasible for an iotest to assume a specific tracing engine, >> so we can't really probe trace_nbd_parse_blockstatus_compliance to see >

Re: [Qemu-devel] [PATCH RFC 2/3] pxtool: Add new qemu-img command info generation tool

2019-04-10 Thread John Snow
On 4/10/19 1:54 AM, Markus Armbruster wrote: > John Snow writes: > >> Presently we use hxtool and a .hx format to generate a few things like >> the qemu_img subcommand dispatch table, the qemu_img help() display output, >> and a help output in qemu-img.texi. >> >> Unfortunately, this means tha

Re: [Qemu-devel] [PATCH v2 6/8] migration: Add multifd-compress parameter

2019-04-10 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > > --- > Rename it to NONE > --- > hmp.c| 17 + > hw/core/qdev-properties.c| 11 +++ > include/hw/qdev-properties.h | 1 + > migration/migration.c| 16 +++

Re: [Qemu-devel] [PATCH] roms: List and describe the Makefile 'clean' rule

2019-04-10 Thread Laszlo Ersek
On 04/10/19 07:36, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > roms/Makefile | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/roms/Makefile b/roms/Makefile > index 1ff78b63bb3..f55c4a2d3bb 100644 > --- a/roms/Makefile > +++ b/r

Re: [Qemu-devel] [Qemu-block] [PULL 07/14] iotests: Add 241 to test NBD on unaligned images

2019-04-10 Thread Max Reitz
On 01.04.19 16:08, Eric Blake wrote: > Add a test for the NBD client workaround in the previous patch. It's > not really feasible for an iotest to assume a specific tracing engine, > so we can't really probe trace_nbd_parse_blockstatus_compliance to see > if the server was fixed vs. whether the cl

Re: [Qemu-devel] [PATCH] qemu-img: fix .hx and .texi disparity

2019-04-10 Thread John Snow
On 4/10/19 1:39 AM, Markus Armbruster wrote: > John Snow writes: > >> It turns out that having options listed in three places continues to be >> a bad idea. I'm still toying with the idea of an improved infrastructure >> here, but in the meantime, another bandaid. >> >> There are three locatio

Re: [Qemu-devel] [PATCH RESEND v2 2/2] cpus: move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-04-10 Thread Paolo Bonzini
On 10/04/19 16:02, Roman Bolshakov wrote: > I've applied, built and tested both sequentially. Applying and running > with patch 1/2 alone doesn't result in the behavior I mentioned. I also > tried to apply only the first hunk that moves hvf_cpu_synchronize_state > into cpu_synchronize_state and it

Re: [Qemu-devel] [PATCH v2 13/13] qemu-iotests: Test the x-blockdev-reopen QMP command

2019-04-10 Thread Max Reitz
On 06.03.19 19:11, Alberto Garcia wrote: > This patch adds several tests for the x-blockdev-reopen QMP command. > > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/243 | 991 > + > tests/qemu-iotests/243.out | 5 + > tests/qemu-iotests/

Re: [Qemu-devel] [PATCH] hostmem-file: warn when memory-backend-file, share=on and in incoming migration

2019-04-10 Thread Dr. David Alan Gilbert
* Catherine Ho (catherine.h...@gmail.com) wrote: > Hi Dr. David > > On Wed, 10 Apr 2019 at 22:59, Dr. David Alan Gilbert > wrote: > > > * Catherine Ho (catherine.h...@gmail.com) wrote: > > > Hi Igor > > > > > > > > > On Mon, 8 Apr 2019 at 18:35, Igor Mammedov wrote: > > > > > > > On Sun, 7 Apr

Re: [Qemu-devel] [PATCH for-4.0?] iotests: Let 245 pass on tmpfs

2019-04-10 Thread Peter Maydell
On Wed, 10 Apr 2019 at 17:40, Max Reitz wrote: > > On 10.04.19 18:39, Eric Blake wrote: > > On 4/10/19 11:29 AM, Max Reitz wrote: > >> tmpfs does not support O_DIRECT. Detect this case, and skip flipping > >> @direct if the filesystem does not support it. > >> > >> Fixes: bf3e50f6239090e63a8ffaae

Re: [Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver

2019-04-10 Thread Cornelia Huck
On Wed, 10 Apr 2019 12:46:12 -0400 "Michael S. Tsirkin" wrote: > On Wed, Apr 10, 2019 at 04:31:39PM +0200, Cornelia Huck wrote: > > On Wed, 10 Apr 2019 10:03:01 -0400 (EDT) > > Pankaj Gupta wrote: > > > > > > > > > > On Wed, Apr 10, 2019 at 09:38:22AM +0530, Pankaj Gupta wrote: > > > > >

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] aio: Add a knob to always poll if there are in-flight requests

2019-04-10 Thread Sergio Lopez
Stefan Hajnoczi writes: > On Tue, Apr 02, 2019 at 02:19:08PM +0200, Sergio Lopez wrote: >> The polling mode in aio_poll is able to trim down ~20us on the average >> request latency, but it needs manual fine tuning to adjust it to the >> characteristics of the storage. >> >> Here we add a new kn

Re: [Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver

2019-04-10 Thread Michael S. Tsirkin
On Wed, Apr 10, 2019 at 04:31:39PM +0200, Cornelia Huck wrote: > On Wed, 10 Apr 2019 10:03:01 -0400 (EDT) > Pankaj Gupta wrote: > > > > > > > On Wed, Apr 10, 2019 at 09:38:22AM +0530, Pankaj Gupta wrote: > > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > > > Guest reads the

Re: [Qemu-devel] [PATCH for-4.0?] iotests: Let 245 pass on tmpfs

2019-04-10 Thread Max Reitz
On 10.04.19 18:39, Eric Blake wrote: > On 4/10/19 11:29 AM, Max Reitz wrote: >> tmpfs does not support O_DIRECT. Detect this case, and skip flipping >> @direct if the filesystem does not support it. >> >> Fixes: bf3e50f6239090e63a8ffaaec971671e66d88e07 >> Signed-off-by: Max Reitz >> --- >> tests

Re: [Qemu-devel] [PATCH for-4.0?] iotests: Let 245 pass on tmpfs

2019-04-10 Thread Eric Blake
On 4/10/19 11:29 AM, Max Reitz wrote: > tmpfs does not support O_DIRECT. Detect this case, and skip flipping > @direct if the filesystem does not support it. > > Fixes: bf3e50f6239090e63a8ffaaec971671e66d88e07 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/245 | 10 -- > 1 file c

[Qemu-devel] [PATCH] target/riscv: Remove unused include of riscv_htif.h for virt board

2019-04-10 Thread Jonathan Behrens
Unless I'm missing something, the virt board doesn't support HTIF and should not be including this header. Jonathan Signed-off-by: Jonathan Behrens --- hw/riscv/virt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index fc4c6b306e..3526463034 100644 --- a/

[Qemu-devel] [PATCH] iotests: Let 245 pass on tmpfs

2019-04-10 Thread Max Reitz
tmpfs does not support O_DIRECT. Detect this case, and skip flipping @direct if the filesystem does not support it. Fixes: bf3e50f6239090e63a8ffaaec971671e66d88e07 Signed-off-by: Max Reitz --- tests/qemu-iotests/245 | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH 2/3] xen-bus: allow AioContext to be specified for each event channel

2019-04-10 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 10 April 2019 16:23 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; > xen-de...@lists.xenproject.org; Stefano Stabellini > ; Stefan Hajnoczi ; Kevin Wolf > ; Max > Reitz > Subje

Re: [Qemu-devel] Questions about acpi interrupt link device's ‘_PRS' field

2019-04-10 Thread Paolo Bonzini
On 10/04/19 16:33, Li Qiang wrote: > Hi all, > >   > > I see the link device ‘_PRS’  uses irq line 5, 10, 11 in > ‘build_link_dev’ function. > > But I never see the 5 lines uses in the guest, just uses 10 and 11. > > Why this happen?  Maybe related with the guest? Because the MADT table tells

Re: [Qemu-devel] [PATCH] xen-block: support feature-large-sector-size

2019-04-10 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 10 April 2019 16:52 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; > qemu-bl...@nongnu.org; Stefano Stabellini > ; Stefan Hajnoczi ; Kevin Wolf > ; Max > Reitz > Subje

Re: [Qemu-devel] [PATCH] xen-block: support feature-large-sector-size

2019-04-10 Thread Anthony PERARD
On Tue, Apr 09, 2019 at 05:40:38PM +0100, Paul Durrant wrote: > A recent Xen commit [1] clarified the semantics of sector based quantities > used in the blkif protocol such that it is now safe to create a xen-block > device with a logical_block_size != 512, as long as the device only > connects to

[Qemu-devel] [PATCH for-4.0-maybe] device_tree: Fix integer overflowing in load_device_tree()

2019-04-10 Thread Philippe Mathieu-Daudé
On 4/10/19 8:34 AM, Alistair Francis wrote: > On Tue, Apr 9, 2019 at 10:59 PM Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >>> On 4/10/19 7:28 AM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: > On 4/9/19 7:40 PM, Markus Armbruster wrote: >> If the value of g

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-10 Thread Yoni Bettan
On 4/9/19 4:17 PM, Stefan Hajnoczi wrote: On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: The main goal is to add an example device to Qemu to be used as template or guideline for contributors when they wish to create a new virtio device. Another reason for this device is to docu

Re: [Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver

2019-04-10 Thread Pankaj Gupta
> > > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > Guest reads the persistent memory range information from > > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > > creates a nd_region object with the persistent memory > > > range information so that existing 'n

Re: [Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver

2019-04-10 Thread Pankaj Gupta
> > > This patch adds virtio-pmem driver for KVM guest. > > > > Guest reads the persistent memory range information from > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > creates a nd_region object with the persistent memory > > range information so that existing 'nvdimm/pmem' dr

Re: [Qemu-devel] [PATCH] hostmem-file: warn when memory-backend-file, share=on and in incoming migration

2019-04-10 Thread Catherine Ho
Hi Dr. David On Wed, 10 Apr 2019 at 22:59, Dr. David Alan Gilbert wrote: > * Catherine Ho (catherine.h...@gmail.com) wrote: > > Hi Igor > > > > > > On Mon, 8 Apr 2019 at 18:35, Igor Mammedov wrote: > > > > > On Sun, 7 Apr 2019 22:19:05 -0400 > > > Catherine Ho wrote: > > > > > > > Currently i

Re: [Qemu-devel] [PATCH for-4.1] commit: Make base read-only if there is an early failure

2019-04-10 Thread Eric Blake
On 4/10/19 10:24 AM, Alberto Garcia wrote: > You can reproduce this by passing an invalid filter-node-name (like > "1234") to block-commit. In this case the base image is put in > read-write mode but is never reset back to read-only. > Is it worth iotest coverage? > Signed-off-by: Alberto Garcia

Re: [Qemu-devel] [PATCH 2/3] xen-bus: allow AioContext to be specified for each event channel

2019-04-10 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 10 April 2019 13:57 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; > xen-de...@lists.xenproject.org; Stefano Stabellini > ; Stefan Hajnoczi ; Kevin Wolf > ; Max > Reitz > Subje

Re: [Qemu-devel] [PATCH 0/2] qemu-img convert: ignore read errors

2019-04-10 Thread Max Reitz
On 09.04.19 16:56, Andrey Shinkevich wrote: > The 'qemu-img convert' new command option 'force read' with the key '-R' > allows converting a damaged image to get all the available information > in case of the read errors. The program reports read errors and continue > the image conversion. The user

[Qemu-devel] [PATCH for-4.1] commit: Make base read-only if there is an early failure

2019-04-10 Thread Alberto Garcia
You can reproduce this by passing an invalid filter-node-name (like "1234") to block-commit. In this case the base image is put in read-write mode but is never reset back to read-only. Signed-off-by: Alberto Garcia --- block/commit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/c

Re: [Qemu-devel] [PATCH 2/3] xen-bus: allow AioContext to be specified for each event channel

2019-04-10 Thread Anthony PERARD
On Wed, Apr 10, 2019 at 04:20:05PM +0100, Paul Durrant wrote: > > -Original Message- > > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > > Sent: 10 April 2019 13:57 > > To: Paul Durrant > > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; > > xen-de...@lists.xenproject.org; Ste

Re: [Qemu-devel] [PATCH v2 for-4.0?] aio-posix: ensure poll mode is left when aio_notify is called

2019-04-10 Thread Stefan Hajnoczi
On Tue, Apr 09, 2019 at 02:28:23PM +0200, Paolo Bonzini wrote: > With aio=thread, adaptive polling makes latency worse rather than > better, because it delays the execution of the ThreadPool's > completion bottom half. > > event_notifier_poll() does run while polling, detecting that > a bottom hal

Re: [Qemu-devel] [PATCH for-4.1] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description

2019-04-10 Thread Philippe Mathieu-Daudé
On 4/10/19 4:58 PM, Laszlo Ersek wrote: > On 04/10/19 06:57, Philippe Mathieu-Daudé wrote: >> In commit 1cab464136b4 we incorrectly described the >> EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS >> options to the EDK2 build tools, but it only expands >> the CFLAGS (not to the CPPFLAGS). >> U

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-10 Thread Igor Mammedov
On Wed, 10 Apr 2019 22:27:56 +0800 Wei Yang wrote: [...] > >@@ -2411,19 +2410,7 @@ build_mcfg_q35(GArray *table_data, BIOSLinker > >*linker, AcpiMcfgInfo *info) > > mcfg->allocation[0].start_bus_number = 0; > > mcfg->allocation[0].end_bus_number = PCIE_MMCFG_BUS(info->mcfg_size - > > 1)

Re: [Qemu-devel] [PATCH 3/3] xen-bus / xen-block: add support for event channel polling

2019-04-10 Thread Anthony PERARD
On Mon, Apr 08, 2019 at 04:16:17PM +0100, Paul Durrant wrote: > This patch introduces a poll callback for event channel fd-s and uses > this to invoke the channel callback function. > > To properly support polling, it is necessary for the event channel callback > function to return a boolean sayin

Re: [Qemu-devel] [PATCH] hostmem-file: warn when memory-backend-file, share=on and in incoming migration

2019-04-10 Thread Dr. David Alan Gilbert
* Catherine Ho (catherine.h...@gmail.com) wrote: > Hi Igor > > > On Mon, 8 Apr 2019 at 18:35, Igor Mammedov wrote: > > > On Sun, 7 Apr 2019 22:19:05 -0400 > > Catherine Ho wrote: > > > > > Currently it is not forbidden to use "-object > > memory-backend-file,share=on" > > > and together with

Re: [Qemu-devel] [PATCH for-4.1] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description

2019-04-10 Thread Laszlo Ersek
On 04/10/19 06:57, Philippe Mathieu-Daudé wrote: > In commit 1cab464136b4 we incorrectly described the > EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS > options to the EDK2 build tools, but it only expands > the CFLAGS (not to the CPPFLAGS). > Update the description to be more accurate. > >

Re: [Qemu-devel] [PATCH v2 for-4.0?] aio-posix: ensure poll mode is left when aio_notify is called

2019-04-10 Thread Stefan Hajnoczi
On Tue, Apr 09, 2019 at 02:28:23PM +0200, Paolo Bonzini wrote: Why is this 4.0 material? It's not a 4.0 regression and tweaking the event loop is risky. I suggest waiting for 4.1. > With aio=thread, adaptive polling makes latency worse rather than > better, because it delays the execution of th

  1   2   >