Re: [PATCH] virtio-net: prevent offloads reset on migration

2019-10-09 Thread Jason Wang
On 2019/10/2 下午5:55, Dr. David Alan Gilbert wrote: Copying in Stefan, Jason and Michael who know the virtio details Dave * Mikhail Sennikovsky (mikhail.sennikovs...@cloud.ionos.com) wrote: Currently offloads disabled by guest via the VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET command are not

[Bug 1847440] Re: ppc64le: KVM guest fails to boot with an error `virtio_scsi: probe of virtio1 failed with error -22` on master

2019-10-09 Thread Satheesh Rajendran
** Description changed: PowerPC KVM Guest fails to boot on current qemu master, bad commit: e68cd0cb5cf49d334abe17231a1d2c28b846afa2 Env: - HW: IBM Power8 + HW: IBM Power9 Host Kernel: 5.4.0-rc2-00038-ge3280b54afed Guest Kernel: 4.13.9-300.fc27.ppc64le Qemu:

[PATCH v6 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE

2019-10-09 Thread Tao Xu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. This patch adds support for user wait instructions in KVM. Availability of the user wait instructions is indicated by the presence of the CPUID feature flag WAITPKG CPUID.0x07.0x0:ECX[5]. User wait instructions may be executed at any

[PATCH v6 0/2] x86: Enable user wait instructions

2019-10-09 Thread Tao Xu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. UMONITOR arms address monitoring hardware using an address. A store to an address within the specified address range triggers the monitoring hardware to wake up the processor waiting in umwait. UMWAIT instructs the processor to

[PATCH v6 2/2] target/i386: Add support for save/load IA32_UMWAIT_CONTROL MSR

2019-10-09 Thread Tao Xu
UMWAIT and TPAUSE instructions use 32bits IA32_UMWAIT_CONTROL at MSR index E1H to determines the maximum time in TSC-quanta that the processor can reside in either C0.1 or C0.2. This patch is to Add support for save/load IA32_UMWAIT_CONTROL MSR in guest. Co-developed-by: Jingqi Liu

Re: [Qemu-devel] [RFC 2 PATCH 02/16] hw/i386: Rename X86CPUTopoInfo structure to X86CPUTopoIDs

2019-10-09 Thread Eduardo Habkost
On Fri, Sep 06, 2019 at 07:11:50PM +, Moger, Babu wrote: > Rename few data structures related to X86 topology. > X86CPUTopoIDs will have individual arch ids. Next > patch introduces X86CPUTopoInfo which will have all > topology information(like cores, threads etc..). > > Adds node_id and

Re: [Qemu-devel] [RFC 2 PATCH 01/16] numa: Split the numa functionality

2019-10-09 Thread Eduardo Habkost
Hi, First of all, sorry for taking more than a month to start reviewing this. On Fri, Sep 06, 2019 at 07:11:43PM +, Moger, Babu wrote: > To support new epyc mode, we need to know the number of numa nodes > in advance to generate apic id correctly. [...] This explains that we need to

Re: [PATCH v4 17/19] spapr: Remove last pieces of SpaprIrq

2019-10-09 Thread David Gibson
On Wed, Oct 09, 2019 at 06:44:53PM +0200, Cédric Le Goater wrote: > On 09/10/2019 08:08, David Gibson wrote: > > The only thing remaining in this structure are the flags to allow either > > XICS or XIVE to be present. These actually make more sense as spapr > > capabilities - that way they can

Re: [PATCH v4 17/19] spapr: Remove last pieces of SpaprIrq

2019-10-09 Thread David Gibson
On Wed, Oct 09, 2019 at 07:02:15PM +0200, Greg Kurz wrote: > On Wed, 9 Oct 2019 17:08:16 +1100 > David Gibson wrote: > > > The only thing remaining in this structure are the flags to allow either > > XICS or XIVE to be present. These actually make more sense as spapr > > capabilities - that

Re: [PATCH v4 15/19] spapr: Remove SpaprIrq::nr_msis

2019-10-09 Thread David Gibson
On Wed, Oct 09, 2019 at 05:59:13PM +0200, Cédric Le Goater wrote: > On 09/10/2019 08:08, David Gibson wrote: > > The nr_msis value we use here has to line up with whether we're using > > legacy or modern irq allocation. Therefore it's safer to derive it based > > on legacy_irq_allocation rather

Re: [PATCH v4 19/19] spapr: Work around spurious warnings from vfio INTx initialization

2019-10-09 Thread David Gibson
On Wed, Oct 09, 2019 at 07:16:39PM +0200, Greg Kurz wrote: > On Wed, 9 Oct 2019 19:52:59 +1100 > David Gibson wrote: > > > On Wed, Oct 09, 2019 at 10:37:38AM +0200, Greg Kurz wrote: > > > On Wed, 9 Oct 2019 17:08:18 +1100 > > > David Gibson wrote: > > > > > > > Traditional PCI INTx for vfio

Re: [PATCH v2 0/2] migration/postcopy: cleanup related to postcopy

2019-10-09 Thread Peter Xu
On Thu, Oct 10, 2019 at 09:13:14AM +0800, Wei Yang wrote: > Refine a function name and handle on corner case related to PostcopyState. > > v2: >* remove one unnecessary patch >* simplify corner case handling > > Wei Yang (2): > migration/postcopy: rename postcopy_ram_enable_notify to >

Re: [PATCH 3/3] migration/postcopy: replace have_listen_thread check with PostcopyState check

2019-10-09 Thread Wei Yang
On Wed, Oct 09, 2019 at 11:17:16AM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> On Tue, Oct 08, 2019 at 08:15:51PM +0100, Dr. David Alan Gilbert wrote: >> >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> >> After previous cleanup, postcopy thread

Re: [PATCH v2 8/8] hw/misc/vmcoreinfo: Add comment about reset handler

2019-10-09 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年10月8日周二 下午10:40写道: > The VM coreinfo device does not sit on a bus, so it won't be > reset automatically. This is why it calls qemu_register_reset(). > > Add a comment about it, so we don't convert its reset handler > to a DeviceReset method. > > Signed-off-by:

Re: [PATCH v2 7/8] hw/input/lm832x: Convert reset handler to DeviceReset

2019-10-09 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年10月8日周二 下午10:38写道: > The LM8323 key-scan controller is a I2C device, it will be reset > when the I2C bus it stands on is reset. > > Convert its reset handler into a proper Device reset method. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Li Qiang >

[PATCH v2 1/2] migration/postcopy: rename postcopy_ram_enable_notify to postcopy_ram_incoming_setup

2019-10-09 Thread Wei Yang
Function postcopy_ram_incoming_setup and postcopy_ram_incoming_cleanup is a pair. Rename to make it clear for audience. Signed-off-by: Wei Yang Reviewed-by: Dr. David Alan Gilbert --- migration/postcopy-ram.c | 4 ++-- migration/postcopy-ram.h | 2 +- migration/savevm.c | 2 +- 3 files

[PATCH v2 2/2] migration/postcopy: check PostcopyState before setting to POSTCOPY_INCOMING_RUNNING

2019-10-09 Thread Wei Yang
Currently, we set PostcopyState blindly to RUNNING, even we found the previous state is not LISTENING. This will lead to a corner case. First let's look at the code flow: qemu_loadvm_state_main() ret = loadvm_process_command() loadvm_postcopy_handle_run() return -1;

[PATCH v2 0/2] migration/postcopy: cleanup related to postcopy

2019-10-09 Thread Wei Yang
Refine a function name and handle on corner case related to PostcopyState. v2: * remove one unnecessary patch * simplify corner case handling Wei Yang (2): migration/postcopy: rename postcopy_ram_enable_notify to postcopy_ram_incoming_setup migration/postcopy: check PostcopyState

Re: [PATCH v2 6/8] hw/isa/vt82c686: Convert reset handler to DeviceReset

2019-10-09 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年10月8日周二 下午10:39写道: > The VIA VT82C686 Southbridge is a PCI device, it will be reset > when the PCI bus it stands on is reset. > > Convert its reset handler into a proper Device reset method. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Li Qiang > ---

Re: [PATCH v2 5/8] hw/ide/via82c: Convert reset handler to DeviceReset

2019-10-09 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年10月8日周二 下午10:36写道: > The VIA82C686B IDE controller is a PCI device, it will be reset > when the PCI bus it stands on is reset. > > Convert its reset handler into a proper Device reset method. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Li Qiang >

Re: [PATCH v2 4/8] hw/ide/sii3112: Convert reset handler to DeviceReset

2019-10-09 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年10月8日周二 下午10:32写道: > The SiI3112A SATA controller is a PCI device, it will be reset > when the PCI bus it stands on is reset. > > Convert its reset handler into a proper Device reset method. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Li Qiang > ---

Re: [PATCH v2 0/8] hw: Convert various reset() handler to DeviceReset

2019-10-09 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年10月10日周四 上午3:54写道: > Hi Li, > > On 10/9/19 4:28 AM, Li Qiang wrote: > > Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于 > > 2019年10月8日周二 下午10:47写道: > > > > Since v1: > > - Removed the pci-host devices > > > > > > Hello I want to know why remove this? >

Re: [PATCH v15 0/7] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-10-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191009091010.16467-1-ganes...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v15 0/7] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests Type: series

Re: [PATCH 3/3] migration/postcopy: handle POSTCOPY_INCOMING_RUNNING corner case properly

2019-10-09 Thread Wei Yang
On Wed, Oct 09, 2019 at 10:08:42AM +0100, Dr. David Alan Gilbert wrote: >> >> > >> >> >Maybe simply fix loadvm_postcopy_handle_run() to set the state after >> >> >the POSTCOPY_INCOMING_LISTENING check? >> >> > >> >> >> >> Set state back to ps if ps is not POSTCOPY_INCOMING_LISTENING? >> >> >> >>

Re: [RFC PATCH 5/5] target/arm/cpu: Add the kvm-adjvtime CPU property

2019-10-09 Thread Richard Henderson
On 10/7/19 1:06 PM, Andrew Jones wrote: > kvm-adjvtime is a KVM specific CPU property and a first of its kind. > To accommodate it we also add kvm_arm_add_vcpu_properties() and a > KVM specific CPU properties description to the CPU features document. > > Signed-off-by: Andrew Jones > ---

Re: [RFC PATCH 4/5] tests/arm-cpu-features: Check feature default values

2019-10-09 Thread Richard Henderson
On 10/7/19 1:06 PM, Andrew Jones wrote: > If we know what the default value should be then we can test for > that as well as the feature existence. > > Signed-off-by: Andrew Jones > --- > tests/arm-cpu-features.c | 44 > 1 file changed, 35 insertions(+),

Re: [RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime

2019-10-09 Thread Richard Henderson
On 10/7/19 1:06 PM, Andrew Jones wrote: > +static void kvm_arm_vm_state_change(void *opaque, int running, RunState > state) > +{ > +CPUState *cs = opaque; > +ARMCPU *cpu = ARM_CPU(cs); > + > +if (running) { > +if (cpu->kvm_adjvtime) { > +

Re: [RFC PATCH 1/5] target/arm/kvm64: kvm64 cpus have timer registers

2019-10-09 Thread Richard Henderson
On 10/7/19 1:06 PM, Andrew Jones wrote: > Add the missing GENERIC_TIMER feature to kvm64 cpus. > > We don't currently use these registers when KVM is enabled, but it's > probably best we add the feature flag for consistency and potential > future use. There's also precedent, as we add the PMU

Re: [RFC PATCH 2/5] timer: arm: Introduce functions to get the host cntfrq

2019-10-09 Thread Richard Henderson
On 10/7/19 1:06 PM, Andrew Jones wrote: > When acceleration like KVM is in use it's necessary to use the host's > counter frequency when converting ticks to or from time units. > > Signed-off-by: Andrew Jones > --- > include/qemu/timer.h | 16 > 1 file changed, 16 insertions(+)

Re: [PATCH v2] target/arm/arch_dump: Add SVE notes

2019-10-09 Thread Richard Henderson
On 10/4/19 8:03 AM, Andrew Jones wrote: > +#ifdef TARGET_AARCH64 > +static off_t sve_zreg_offset(uint32_t vq, int n) > +{ > +off_t off = sizeof(struct aarch64_user_sve_header); > +return ROUND_UP(off, 16) + vq * 16 * n; > +} > +static off_t sve_preg_offset(uint32_t vq, int n) > +{ > +

Re: [PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs

2019-10-09 Thread Mario Smarduch
On 10/09/2019 02:19 PM, Paolo Bonzini wrote: > On 09/10/19 18:44, Mario Smarduch wrote: >> In a large VPC environment we want to log memory error occurrences >> and log them with guest name and type - there are few use cases >> >> >> - if VM crashes on AR mce inform the user about the reason

Re: [PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs

2019-10-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191009164459.8209-1-msmard...@digitalocean.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

[PATCH v2 1/1] IDE: deprecate ide-drive

2019-10-09 Thread John Snow
It's an old compatibility shim that just delegates to ide-cd or ide-hd. I'd like to refactor these some day, and getting rid of the super-object will make that easier. Either way, we don't need this. Libvirt-checked-by: Peter Krempa Signed-off-by: John Snow --- qemu-deprecated.texi |

Re: [PATCH 1/1] IDE: deprecate ide-drive

2019-10-09 Thread John Snow
On 10/8/19 2:51 AM, Markus Armbruster wrote: >> I'll respin to hit the tests with a stiffer scrub-brush. > Thanks! 051 is the only test I can find that uses ide-drive, and the non-pc version of the test doesn't seem to use it, so this actually seems sufficient. I'd like to keep the test for

[PATCH v2 0/1] IDE: Deprecate ide-drive

2019-10-09 Thread John Snow
V2: Change phrasings and spellings as Markus suggested. John Snow (1): IDE: deprecate ide-drive qemu-deprecated.texi | 5 + hw/ide/qdev.c | 3 +++ tests/qemu-iotests/051.pc.out | 6 -- 3 files changed, 12 insertions(+), 2 deletions(-) -- 2.21.0

Re: [PATCH] RISC-V: fcvt can set fflags, so set FS accordingly

2019-10-09 Thread Richard Henderson
On 10/9/19 5:15 PM, Palmer Dabbelt wrote: > A user pinged me to say "my floating point heavy code works in user mode > but not system mode", which I'm guessing is the result of a lazy FP > save/restore issue as those still crop up from time to time as long tail > bugs. I figured it was worth

Re: [PATCH v4] s390x/tcg: MVCL: Exit to main loop if requested

2019-10-09 Thread Richard Henderson
On 10/9/19 7:00 AM, David Hildenbrand wrote: > MVCL is interruptible and we should check for interrupts and process > them after writing back the variables to the registers. Let's check > for any exit requests and exit to the main loop. Introduce a new helper > function for that:

Re: [PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs

2019-10-09 Thread Paolo Bonzini
On 09/10/19 18:44, Mario Smarduch wrote: > In a large VPC environment we want to log memory error occurrences > and log them with guest name and type - there are few use cases > > > - if VM crashes on AR mce inform the user about the reason and resolve the > case > - if VM hangs notify the user

Re: [PATCH 2/3] ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory()

2019-10-09 Thread David Gibson
On Wed, Oct 09, 2019 at 01:19:21PM +0200, Igor Mammedov wrote: > On Wed, 9 Oct 2019 12:21:06 +1100 > David Gibson wrote: > > > On Tue, Oct 08, 2019 at 07:33:17AM -0400, Igor Mammedov wrote: > > > rs6000mc_realize() violates memory_region_allocate_system_memory() > > > contract > > > by calling

Re: [PATCH v3] dirty-bitmaps: remove deprecated autoload parameter

2019-10-09 Thread John Snow
On 10/2/19 7:24 PM, John Snow wrote: > This parameter has been deprecated since 2.12.0 and is eligible for > removal. Remove this parameter as it is actually completely ignored; > let's not give false hope. > > Signed-off-by: John Snow > Reviewed-by: Eric Blake > Reviewed-by: Vladimir

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-09 Thread Laszlo Ersek
On 10/08/19 17:59, Igor Mammedov wrote: > On Tue, 8 Oct 2019 12:52:58 +0200 > Laszlo Ersek wrote: > >> FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, >> due to historical reasons. That value is not useful to edk2, however. For >> supporting VCPU hotplug, edk2 needs:

Re: [PATCH v31 0/8] QEMU AVR 8 bit cores

2019-10-09 Thread Aleksandar Markovic
23.09.2019. 15.29, "Michael Rolnik" је написао/ла: > > Hi all, > > is there any hope this will be ever pulled? > > regards, > Michael > Hello, Michael. I am practically new to your series, even though it is v31. Could you perhaps include links to any documentation that you think it can be

Re: [PATCH v2 3/8] hw/ide/piix: Convert reset handler to DeviceReset

2019-10-09 Thread Philippe Mathieu-Daudé
On 10/9/19 3:08 AM, Li Qiang wrote: Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于 2019年10月8日周二 下午10:32写道: The PIIX3/IDE is a PCI device within the PIIX3 chipset, it will be reset when the PCI bus it stands on is reset. Convert its reset handler into a proper Device reset

[PATCH v2 4/4] qemu-iotests: 044: remove inaccurate docstring class description

2019-10-09 Thread Cleber Rosa
Reviewed-by: Eric Blake Reviewed-by: John Snow Signed-off-by: Cleber Rosa --- tests/qemu-iotests/044 | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044 index aa2a00ceed..bae99e25cf 100755 --- a/tests/qemu-iotests/044 +++ b/tests/qemu-iotests/044

[PATCH v2 3/4] qemu-iotests: 044: pass is actually a noop, so remove it

2019-10-09 Thread Cleber Rosa
Reviewed-by: Eric Blake Signed-off-by: Cleber Rosa --- tests/qemu-iotests/044 | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044 index 8b2afa2a11..aa2a00ceed 100755 --- a/tests/qemu-iotests/044 +++ b/tests/qemu-iotests/044 @@ -102,17 +102,14 @@

Re: [PATCH] mc146818rtc: fix timer interrupt reinjection

2019-10-09 Thread Paolo Bonzini
On 09/10/19 20:40, Marcelo Tosatti wrote: > s->period = period; > lost_clock += old_irq_coalesced * old_period; > -s->irq_coalesced = lost_clock / s->period; > +if (old_period) { > +s->irq_coalesced = lost_clock / s->period; > +

Re: [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options

2019-10-09 Thread Paolo Bonzini
On 09/10/19 18:44, Mario Smarduch wrote: > }; > @@ -1263,6 +1267,7 @@ static void realtime_init(void) > static void configure_msg(QemuOpts *opts) > { > enable_timestamp_msg = qemu_opt_get_bool(opts, "timestamp", true); > +enable_guestname_msg = qemu_opt_get_bool(opts, "name", false); >

[PATCH v15 7/7] ppc: spapr: Activate the FWNMI functionality

2019-10-09 Thread Ganesh Goudar
From: Aravinda Prasad This patch sets the default value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for machine type 4.2. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index

Re: [PATCH v2 1/4] qemu-iotests: remove bash shebang from library files

2019-10-09 Thread Cleber Rosa
- Original Message - > From: "Eric Blake" > To: "Cleber Rosa" , qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org, "Max Reitz" , "Kevin Wolf" > , qemu-triv...@nongnu.org, > "Michael Tokarev" , "Laurent Vivier" > Sent: Wednesday, October 9, 2019 3:51:56 PM > Subject: Re: [PATCH v2

Re: [PATCH v31 0/8] QEMU AVR 8 bit cores

2019-10-09 Thread Michael Rolnik
Hello Aleksandar. https://ww1.microchip.com/downloads/en/devicedoc/atmel-2549-8-bit-avr-microcontroller-atmega640-1280-1281-2560-2561_datasheet.pdf On Wed, Oct 9, 2019 at 11:38 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > 23.09.2019. 15.29, "Michael Rolnik" је написао/ла:

[PATCH] RISC-V: fcvt can set fflags, so set FS accordingly

2019-10-09 Thread Palmer Dabbelt
A user pinged me to say "my floating point heavy code works in user mode but not system mode", which I'm guessing is the result of a lazy FP save/restore issue as those still crop up from time to time as long tail bugs. I figured it was worth giving the FP stuff a look to see if anything jumps

[PATCH v15 1/7] Wrapper function to wait on condition for the main loop mutex

2019-10-09 Thread Ganesh Goudar
From: Aravinda Prasad Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by:

Re: [PATCH v7 00/12] Introduce the microvm machine type

2019-10-09 Thread Paolo Bonzini
On 09/10/19 21:26, Michael S. Tsirkin wrote: > On Tue, Oct 08, 2019 at 03:55:26PM +0200, Sergio Lopez wrote: >> Microvm is a machine type inspired by Firecracker and constructed >> after the its machine model. >> >> It's a minimalist machine type without PCI nor ACPI support, designed >> for

[PATCH v15 0/7] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-10-09 Thread Ganesh Goudar
This patch set adds support for FWNMI in PowerKVM guests. System errors such as SLB multihit and memory errors that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exceptions, if the address in error

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-09 Thread Eduardo Habkost
On Tue, Oct 08, 2019 at 08:58:30PM +0200, Laszlo Ersek wrote: > Eduardo, Igor, > > On 10/08/19 12:52, Laszlo Ersek wrote: > > FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, > > due to historical reasons. That value is not useful to edk2, however. For > > supporting

Re: [PATCH v2 0/8] hw: Convert various reset() handler to DeviceReset

2019-10-09 Thread Philippe Mathieu-Daudé
Hi Li, On 10/9/19 4:28 AM, Li Qiang wrote: Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于 2019年10月8日周二 下午10:47写道: Since v1: - Removed the pci-host devices Hello  I want to know why  remove this? I haven't removed the devices, I simply remove the patches converting them to

[Bug 1847525] [NEW] qemu-system-i386 eats a lot of cpu after just few hours, with sdl, gl=on

2019-10-09 Thread Andrew Randrianasulu
Public bug reported: I already send this email to qemu-disc...@nongnu.org , but I can't see it arriving in archives, so here is copy. Hello, all! I use qemu-system-i386/qemu-system_x86_64 for rebuilding Slax-like live cd/dvd. Usually guests (with various self-compiled kernels and X stack with

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-09 Thread Laszlo Ersek
On 10/09/19 13:13, Igor Mammedov wrote: > On Tue, 8 Oct 2019 20:58:30 +0200 > Laszlo Ersek wrote: > >> Eduardo, Igor, >> >> On 10/08/19 12:52, Laszlo Ersek wrote: >>> FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, >>> due to historical reasons. That value is not

[PATCH v2 1/4] qemu-iotests: remove bash shebang from library files

2019-10-09 Thread Cleber Rosa
Due to not being able to find a reason to have shebangs on files that are not executable. While at it, add a mode hint to emacs, which would be clueless or plain wrong about these containing shell code. Suggested-by: Eric Blake Signed-off-by: Cleber Rosa --- tests/qemu-iotests/common.config

Re: [PATCH 0/1] MAINTAINERS: Add Vladimir as a reviewer for bitmaps

2019-10-09 Thread John Snow
On 10/5/19 3:44 PM, John Snow wrote: > Hi; I'll be going away on an extended trip this November and have made > arrangements for reviews to be handled in my absence. I've asked Vladimir > to take point on any reviews for patches he didn't author, and have asked > Eric to take point on reviewing

Re: [PATCH v6 00/10] Introduce the microvm machine type

2019-10-09 Thread Michael S. Tsirkin
On Mon, Oct 07, 2019 at 03:44:40PM +0200, Sergio Lopez wrote: > > Michael S. Tsirkin writes: > > > On Fri, Oct 04, 2019 at 11:37:42AM +0200, Sergio Lopez wrote: > >> Microvm is a machine type inspired by Firecracker and constructed > >> after the its machine model. > >> > >> It's a minimalist

[PATCH v2 2/4] qemu-iotests: remove forceful execution success from library files

2019-10-09 Thread Cleber Rosa
Should not be necessary on files that are not executed standalone. Reviewed-by: Eric Blake Signed-off-by: Cleber Rosa --- tests/qemu-iotests/common.config | 3 --- tests/qemu-iotests/common.filter | 3 --- tests/qemu-iotests/common.rc | 3 --- 3 files changed, 9 deletions(-) diff --git

Re: [PATCH] monitor/qmp: resume monitor when clearing its queue

2019-10-09 Thread Markus Armbruster
Wolfgang Bumiller writes: > On Wed, Oct 09, 2019 at 10:39:44AM +0200, Markus Armbruster wrote: >> Cc: Marc-André for additional monitor and chardev expertise. >> >> Wolfgang Bumiller writes: >> >> > When a monitor's queue is filled up in handle_qmp_command() >> > it gets suspended. It's the

[PATCH v2 0/4] iotests: trivial cleanups

2019-10-09 Thread Cleber Rosa
The most trivial set of cleanups to iotests common libraries and the 044 test. Changes from v1: * Added emacs mode hints on tests/qemu-iotests/common.* files (Eric Blake) Cleber Rosa (4): qemu-iotests: remove bash shebang from library files qemu-iotests: remove forceful execution success

Re: [PATCH v2 1/8] hw/acpi/piix4: Convert reset handler to DeviceReset

2019-10-09 Thread Michael S. Tsirkin
On Tue, Oct 08, 2019 at 04:25:32PM +0200, Philippe Mathieu-Daudé wrote: > The PIIX4/PM is a PCI device within the PIIX4 chipset, it will be reset > when the PCI bus it stands on is reset. > > Convert its reset handler into a proper Device reset method. > > Reviewed-by: Igor Mammedov >

[Bug 1847525] Re: qemu-system-i386 eats a lot of cpu after just few hours, with sdl, gl=on

2019-10-09 Thread Andrew Randrianasulu
Illustration for this bug (link to screenshot): https://www.imgbin.net/z/9W9eVVvbll.png as you hopefully can see, just after less than 6 hrs of guest uptime HOST cpu is eaten at 70% by qemu-system-i386 task .. up from just 50% two hours ago! By this rate it will not survive even day of

Re: [PATCH v7 00/12] Introduce the microvm machine type

2019-10-09 Thread Michael S. Tsirkin
On Tue, Oct 08, 2019 at 03:55:26PM +0200, Sergio Lopez wrote: > Microvm is a machine type inspired by Firecracker and constructed > after the its machine model. > > It's a minimalist machine type without PCI nor ACPI support, designed > for short-lived guests. Microvm also establishes a baseline

Re: [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps

2019-10-09 Thread Eric Blake
On 6/6/19 1:41 PM, John Snow wrote: When adding new persistent dirty bitmaps, we only check constraints against currently stored bitmaps, and ignore the pending number and size of any bitmaps yet to be stored. Rework the "can_store" and "remove" interface to explicit "add" and "remove", and

Re: [PATCH v2 1/4] qemu-iotests: remove bash shebang from library files

2019-10-09 Thread Eric Blake
On 10/9/19 2:47 PM, Cleber Rosa wrote: Due to not being able to find a reason to have shebangs on files that are not executable. While at it, add a mode hint to emacs, which would be clueless or plain wrong about these containing shell code. Suggested-by: Eric Blake Signed-off-by: Cleber Rosa

Re: [RFC PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is also advertised

2019-10-09 Thread Michael S. Tsirkin
On Tue, Oct 08, 2019 at 02:24:16PM +0100, Stefan Hajnoczi wrote: > On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote: > > Virtio spec 1.1 (and earlier), 5.2.5.1 Driver Requirements: Device > > Initialization: > > > > "Devices SHOULD always offer VIRTIO_BLK_F_FLUSH, and MUST offer it

Re: [PATCH v4 01/31] errp: rename errp to errp_in where it is IN-argument

2019-10-09 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 08.10.2019 12:08, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: [...] >>> diff --git a/util/error.c b/util/error.c >>> index d4532ce318..b3ff3832d6 100644 >>> --- a/util/error.c >>> +++ b/util/error.c >>> @@ -271,11 +271,11 @@ void

Re: [PATCH v6 00/10] Introduce the microvm machine type

2019-10-09 Thread Eduardo Habkost
On Wed, Oct 09, 2019 at 03:21:46PM -0400, Michael S. Tsirkin wrote: > On Mon, Oct 07, 2019 at 03:44:40PM +0200, Sergio Lopez wrote: > > > > Michael S. Tsirkin writes: > > > > > On Fri, Oct 04, 2019 at 11:37:42AM +0200, Sergio Lopez wrote: > > >> Microvm is a machine type inspired by Firecracker

Re: [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210

2019-10-09 Thread Cleber Rosa
On Wed, Oct 09, 2019 at 02:38:02PM +0100, Peter Maydell wrote: > On Tue, 8 Oct 2019 at 22:49, Cleber Rosa wrote: > > > > I find it hard to judge precisely how much of a third-party some of > > these are. I remember Philippe mentioning that one of them, I guess > > the images used on

[PATCH v15 5/7] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-10-09 Thread Ganesh Goudar
From: Aravinda Prasad This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also handles the case when multiple processors experience machine

Re: [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps

2019-10-09 Thread John Snow
On 10/9/19 2:57 PM, Eric Blake wrote: > On 6/6/19 1:41 PM, John Snow wrote: >> When adding new persistent dirty bitmaps, we only check constraints >> against currently stored bitmaps, and ignore the pending number and size >> of any bitmaps yet to be stored. >> >> Rework the "can_store" and

Re: [PATCH 5/5] travis.yml: Compile on arm64, too

2019-10-09 Thread Philippe Mathieu-Daudé
On 10/9/19 7:07 PM, Thomas Huth wrote: Travis now features an arm64 build host, so let's check compilation there, too. Unfortunately, there are some quirks: - block/ssh.c does not compile properly in this environment, so we have to use --disable-libssh until that problem is fixed. -

[Bug 1838763] Re: Bugs in SSH module (ssh.c)

2019-10-09 Thread Philippe Mathieu-Daudé
As suggested by Richard in [*], filled a libssh report: https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1847514 [*] https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg02506.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[PATCH v15 4/7] target/ppc: Build rtas error log upon an MCE

2019-10-09 Thread Ganesh Goudar
From: Aravinda Prasad Upon a machine check exception (MCE) in a guest address space, KVM causes a guest exit to enable QEMU to build and pass the error to the guest in the PAPR defined rtas error log format. This patch builds the rtas error log, copies it to the rtas_addr and then invokes the

Re: [PATCH v4 50/54] tests/plugin: add instruction execution breakdown

2019-10-09 Thread Alex Bennée
Aaron Lindsay OS writes: > On Jul 31 17:07, Alex Bennée wrote: >> + * Attempt to measure the amount of vectorisation that has been done >> + * on some code by counting classes of instruction. This is very much >> + * ARM specific. > > I suspect some of my plugins will also be

[PATCH v15 2/7] ppc: spapr: Introduce FWNMI capability

2019-10-09 Thread Ganesh Goudar
From: Aravinda Prasad Introduce the KVM capability KVM_CAP_PPC_FWNMI so that the KVM causes guest exit with NMI as exit reason when it encounters a machine check exception on the address belonging to a guest. Without this capability enabled, KVM redirects machine check exceptions to guest's

Re: [PATCH 1/4] qemu-iotests: remove bash shebang from library files

2019-10-09 Thread Cleber Rosa
On Wed, Oct 09, 2019 at 12:26:27PM -0400, Cleber Rosa wrote: > On Fri, Sep 27, 2019 at 11:37:52AM -0500, Eric Blake wrote: > > On 9/27/19 9:17 AM, Cleber Rosa wrote: > > > Due to not being able to find a reason to have shebangs on files that > > > are not executable. > > > > > > Signed-off-by:

Re: [PATCH 4/5] travis.yml: Fix the ccache lines

2019-10-09 Thread Philippe Mathieu-Daudé
On 10/9/19 7:07 PM, Thomas Huth wrote: The "command -v ccache && ccache ..." likely were supposed to test the availability of ccache before running the program. But this shell construct causes Travis to abort if ccache is not available. Oops. Why can't you install ccache if these are Ubuntu

Re: [Qemu-devel] [RFC v3 PATCH 07/45] multi-process: define proxy-link object

2019-10-09 Thread Elena Ufimtseva
On Wed, Oct 09, 2019 at 02:37:24PM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 12, 2019 at 05:34:35PM +0200, Stefan Hajnoczi wrote: > > On Tue, Sep 03, 2019 at 04:37:33PM -0400, Jagannathan Raman wrote: > > > +msg->num_fds = 0; > > > +for (chdr = CMSG_FIRSTHDR(); chdr != NULL; > > > +

Re: [PATCH 09/10] nbd/server: use bdrv_dirty_bitmap_next_dirty_area

2019-10-09 Thread Eric Blake
On 9/30/19 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: Use bdrv_dirty_bitmap_next_dirty_area for bitmap_to_extents. Since bdrv_dirty_bitmap_next_dirty_area is very accurate in its interface, we'll never exceed requested region with last chunk. So, we don't need dont_fragment, and

Re: [PATCH v4 24/54] plugins: implement helpers for resolving hwaddr

2019-10-09 Thread Alex Bennée
Aaron Lindsay OS writes: > On Jul 31 17:06, Alex Bennée wrote: >> We need to keep a local per-cpu copy of the data as other threads may >> be running. We use a automatically growing array and re-use the space >> for subsequent queries. > > [...] > >> +bool tlb_plugin_lookup(CPUState *cpu,

Re: [PATCH v4 04/31] error: auto propagated local_err

2019-10-09 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 09.10.2019 11:04, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of >>> functions with errp OUT parameter. >>> >>> It has three goals: >>> >>> 1. Fix issue with

Re: [PATCH v4 19/19] spapr: Work around spurious warnings from vfio INTx initialization

2019-10-09 Thread Greg Kurz
On Wed, 9 Oct 2019 19:52:59 +1100 David Gibson wrote: > On Wed, Oct 09, 2019 at 10:37:38AM +0200, Greg Kurz wrote: > > On Wed, 9 Oct 2019 17:08:18 +1100 > > David Gibson wrote: > > > > > Traditional PCI INTx for vfio devices can only perform well if using > > > an in-kernel irqchip.

[PATCH] mc146818rtc: fix timer interrupt reinjection

2019-10-09 Thread Marcelo Tosatti
commit 369b41359af46bded5799c9ef8be2b641d92e043 broke timer interrupt reinjection when there is no period change by the guest. In that case, old_period is 0, which ends up zeroing irq_coalesced (counter of reinjected interrupts). The consequence is Windows 7 is unable to synchronize time via

[PATCH v15 6/7] migration: Include migration support for machine check handling

2019-10-09 Thread Ganesh Goudar
From: Aravinda Prasad This patch includes migration support for machine check handling. Especially this patch blocks VM migration requests until the machine check error handling is complete as these errors are specific to the source hardware and is irrelevant on the target hardware. [Do not set

Re: [RFC PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is also advertised

2019-10-09 Thread Stefan Hajnoczi
On Wed, Oct 09, 2019 at 03:37:35PM +0300, Evgeny Yakovlev wrote: > On 08.10.2019 16:24, Stefan Hajnoczi wrote: > > On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote: > > The motivation for this change looks correct but this patch may cause > > host_features to change across live

[PATCH v15 3/7] target/ppc: Handle NMI guest exit

2019-10-09 Thread Ganesh Goudar
From: Aravinda Prasad Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit

[PATCH 4/5] travis.yml: Fix the ccache lines

2019-10-09 Thread Thomas Huth
The "command -v ccache && ccache ..." likely were supposed to test the availability of ccache before running the program. But this shell construct causes Travis to abort if ccache is not available. Use an if-statement instead to fix this problem. Signed-off-by: Thomas Huth --- .travis.yml | 4

[PATCH 1/5] travis.yml: Add libvdeplug-dev to compile-test net/vde.c

2019-10-09 Thread Thomas Huth
This library is needed to compile the VDE network backend. Signed-off-by: Thomas Huth --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index d0b9e099b9..63328387f6 100644 --- a/.travis.yml +++ b/.travis.yml @@ -46,6 +46,7 @@ addons: -

[PATCH 5/5] travis.yml: Compile on arm64, too

2019-10-09 Thread Thomas Huth
Travis now features an arm64 build host, so let's check compilation there, too. Unfortunately, there are some quirks: - block/ssh.c does not compile properly in this environment, so we have to use --disable-libssh until that problem is fixed. - test-util-filemonitor fails, so we can not run the

[PATCH 0/5] travis.yml improvements: Update libraries, build with arm64

2019-10-09 Thread Thomas Huth
Update / add some libraries that we use in the Travis builds, and enable compiling on the aarch64 host, too. Thomas Huth (5): travis.yml: Add libvdeplug-dev to compile-test net/vde.c travis.yml: Use libsdl2 instead of libsdl1.2, and install libsdl2-image travis.yml: Use newer version of

[PATCH 2/5] travis.yml: Use libsdl2 instead of libsdl1.2, and install libsdl2-image

2019-10-09 Thread Thomas Huth
We've removed support for SDL 1.2 quite a while ago already, so let's use SDL 2 now in Travis to get test coverage for SDL again. And while we're at it, also add libsdl2-image-dev which can be used by QEMU nowadays, too. Signed-off-by: Thomas Huth --- .travis.yml | 6 -- 1 file changed, 4

Re: [PATCH v4 17/19] spapr: Remove last pieces of SpaprIrq

2019-10-09 Thread Greg Kurz
On Wed, 9 Oct 2019 17:08:16 +1100 David Gibson wrote: > The only thing remaining in this structure are the flags to allow either > XICS or XIVE to be present. These actually make more sense as spapr > capabilities - that way they can take advantage of the existing > infrastructure to sanity

Re: [PATCH v4 01/31] errp: rename errp to errp_in where it is IN-argument

2019-10-09 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 08.10.2019 15:05, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 08.10.2019 12:08, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > Error **errp is almost always OUT-argument: it's assumed to be NULL,

Re: [PATCH 08/10] nbd/server: introduce NBDExtentArray

2019-10-09 Thread Eric Blake
On 9/30/19 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: Introduce NBDExtentArray class, to handle extents list creation in more controlled way and with less OUT parameters in functions. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 184

[PATCHv2 2/2] target/i386: log MCE guest and host addresses

2019-10-09 Thread Mario Smarduch
Patch logs MCE AO, AR messages injected to guest or taken by QEMU itself. We print the QEMU address for guest MCEs, helps on hypervisors that have another source of MCE logging like mce log, and when they go missing. For example we found these QEMU logs: September 26th 2019, 17:36:02.309

  1   2   3   >