[PATCH] MAINTAINERS: Change to my personal email address

2019-10-29 Thread Palmer Dabbelt
I'm leaving SiFive in a bit less than two weeks, which means I'll be losing my @sifive email address. I don't have my new email address yet, so I'm switching over to my personal address instead. Signed-off-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- MAINTAINERS | 4 ++-- 1 file

RE: [PATCH v2] qcow2-bitmap: Fix uint64_t left-shift overflow

2019-10-29 Thread Tuguoyi
On 29.10.2019 19:57 Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 14:14, Max Reitz wrote: > > On 28.10.19 07:33, Tuguoyi wrote: > >> In check_constraints_on_bitmap(), the sanity check on the granularity > >> will cause uint64_t integer left-shift overflow when cluster_size is > >> 2M and the

[Bug 1850570] [NEW] Cannot use usb-host on Mac OS

2019-10-29 Thread John Canada
Public bug reported: Usb-host will not work on Mac OS 10.15. Qemu runs, though it gives these errors and the drive does not show up. Also, when Qemu is starting the drive ejects and remounts twice. Qemu built with ./configure --target-list=i386-softmmu,x86_64-softmmu --enable-sdl

[PATCH] remove unnecessary ifdef TARGET_RISCV64

2019-10-29 Thread hiroyuki . obinata
From: "hiroyuki.obinata" Signed-off-by: Hiroyuki Obinata --- target/riscv/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index adeddb85f6..5c4dd21a98 100644 --- a/target/riscv/translate.c +++

Re: [PULL 0/16] Python (acceptance tests) queue, 2019-10-28

2019-10-29 Thread Cleber Rosa
On Tue, Oct 29, 2019 at 05:58:13PM -0400, Cleber Rosa wrote: > On Tue, Oct 29, 2019 at 05:51:28PM -0400, Cleber Rosa wrote: > > On Tue, Oct 29, 2019 at 09:13:45PM +, Peter Maydell wrote: > > > On Mon, 28 Oct 2019 at 23:50, Cleber Rosa wrote: > > > > > > > > The following changes since commit

[PULL 14/14] virtio: Use auto rcu_read macros

2019-10-29 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Use RCU_READ_LOCK_GUARD and WITH_RCU_READ_LOCK_GUARD to replace the manual rcu_read_(un)lock calls. I think the only change is virtio_load which was missing unlocks in error paths; those end up being fatal errors so it's not that important anyway. Signed-off-by:

[PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test

2019-10-29 Thread Cleber Rosa
The boot_linux_console.py:BootLinuxConsole.test_m68k_q800 was very recently merged, but between its last review and now, the Kernel package used went missing. This updates the Kernel package, and protects the test from failing if it gets updated again. Cleber Rosa (2): Acceptance test: cancel

[PATCH 2/2] Acceptance test: update kernel for m68k/q800 test

2019-10-29 Thread Cleber Rosa
There's an updated version of the Debian package containing the m68k Kernel. Now, if the package gets updated again, the test won't fail, but will be canceled. A more permanent solution is certainly needed. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux_console.py | 6 +++--- 1

[PATCH 1/2] Acceptance test: cancel test if m68k kernel packages goes missing

2019-10-29 Thread Cleber Rosa
The Linux kernel that is extracted from a Debian package for the q800 machine test is hosted on a "pool" location. AFAICT, it gets updated without too much ceremony, and I don't see any archival location that is stable enough. For now, to avoid test errors, let's cancel the test if fetching the

[PULL 11/14] vfio: unplug failover primary device before migration

2019-10-29 Thread Michael S. Tsirkin
From: Jens Freimann As usual block all vfio-pci devices from being migrated, but make an exception for failover primary devices. This is achieved by setting unmigratable to 0 but also add a migration blocker for all vfio-pci devices except failover primary devices. These will be unplugged before

[PULL 10/14] net/virtio: add failover support

2019-10-29 Thread Michael S. Tsirkin
From: Jens Freimann This patch adds support to handle failover device pairs of a virtio-net device and a (vfio-)pci device, where the virtio-net acts as the standby device and the (vfio-)pci device as the primary. The general idea is that we have a pair of devices, a (vfio-)pci and a emulated

[PULL 09/14] libqos: tolerate wait-unplug migration state

2019-10-29 Thread Michael S. Tsirkin
From: Jens Freimann Signed-off-by: Jens Freimann Message-Id: <20191029114905.6856-10-jfreim...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/libqos/libqos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/libqos/libqos.c

[PULL 13/14] virtio_net: use RCU_READ_LOCK_GUARD

2019-10-29 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Use RCU_READ_LOCK_GUARD rather than the manual rcu_read_(un)lock call. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20191025103403.120616-3-dgilb...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 7

[PULL 02/14] pci: add option for net failover

2019-10-29 Thread Michael S. Tsirkin
From: Jens Freimann This patch adds a failover_pair_id property to PCIDev which is used to link the primary device in a failover pair (the PCI dev) to a standby (a virtio-net-pci) device. It only supports ethernet devices. Also currently it only supports PCIe devices. The requirement for PCIe

[PULL 01/14] qdev/qbus: add hidden device support

2019-10-29 Thread Michael S. Tsirkin
From: Jens Freimann This adds support for hiding a device to the qbus and qdev APIs. The first user of this will be the virtio-net failover feature but the API introduced with this patch could be used to implement other features as well, for example hiding pci devices when a pci bus is powered

[PULL 12/14] virtio/vhost: Use auto_rcu_read macros

2019-10-29 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Use RCU_READ_LOCK_GUARD instead of manual rcu_read_(un)lock Signed-off-by: Dr. David Alan Gilbert Message-Id: <20191025103403.120616-2-dgilb...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 4 +--- 1 file

[PULL 07/14] migration: allow unplug during migration for failover devices

2019-10-29 Thread Michael S. Tsirkin
From: Jens Freimann In "b06424de62 migration: Disable hotplug/unplug during migration" we added a check to disable unplug for all devices until we have figured out what works. For failover primary devices qdev_unplug() is called from the migration handler, i.e. during migration. This patch adds

[PULL 06/14] qapi: add failover negotiated event

2019-10-29 Thread Michael S. Tsirkin
From: Jens Freimann This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature is enabled. The primary device this virtio-net (standby) device is associated with, is now hotplugged by the virtio-net device. Signed-off-by: Jens Freimann Message-Id:

[PULL 08/14] migration: add new migration state wait-unplug

2019-10-29 Thread Michael S. Tsirkin
From: Jens Freimann This patch adds a new migration state called wait-unplug. It is entered after the SETUP state if failover devices are present. It will transition into ACTIVE once all devices were succesfully unplugged from the guest. So if a guest doesn't respond or takes long to honor the

[PULL 03/14] pci: mark devices partially unplugged

2019-10-29 Thread Michael S. Tsirkin
From: Jens Freimann Only the guest unplug request was triggered. This is needed for the failover feature. In case of a failed migration we need to plug the device back to the guest. Signed-off-by: Jens Freimann Message-Id: <20191029114905.6856-4-jfreim...@redhat.com> Reviewed-by: Michael S.

[PULL 00/14] virtio: features, cleanups

2019-10-29 Thread Michael S. Tsirkin
The following changes since commit 16884391c750d0c5e863f55ad7146fc5181e: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2019-10-29' into staging (2019-10-29 20:06:08 +) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[PULL 05/14] qapi: add unplug primary event

2019-10-29 Thread Michael S. Tsirkin
From: Jens Freimann This event is emitted when we sent a request to unplug a failover primary device from the Guest OS and it includes the device id of the primary device. Signed-off-by: Jens Freimann Message-Id: <20191029114905.6856-6-jfreim...@redhat.com> Reviewed-by: Michael S. Tsirkin

[PULL 04/14] pci: mark device having guest unplug request pending

2019-10-29 Thread Michael S. Tsirkin
From: Jens Freimann Set pending_deleted_event in DeviceState for failover primary devices that were successfully unplugged by the Guest OS. Signed-off-by: Jens Freimann Message-Id: <20191029114905.6856-5-jfreim...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

Re: RFC: New device for zero-copy VM memory access

2019-10-29 Thread geoff
Just to follow this up, here is a sample client application for this device https://gist.github.com/gnif/77e7fb54604b42a1a98ecb8bf3d2cf46 -Geoff On 2019-10-30 01:31, ge...@hostfission.com wrote: Hi All, Over the past week, I have been working to come up with a solution to the memory

Re: [PATCH 00/30] virtiofs daemon (base)

2019-10-29 Thread Michael S. Tsirkin
On Mon, Oct 21, 2019 at 11:58:02AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is the 1st set for the virtiofsd - a daemon > that implements the user space side of virtiofs. > > The kernel and qemu device parts recently went in, > so the daemon

Re: [PATCH v6 0/11] add failover feature for assigned network devices

2019-10-29 Thread Michael S. Tsirkin
On Fri, Oct 25, 2019 at 02:19:19PM +0200, Jens Freimann wrote: > This is implementing the host side of the net_failover concept > (https://www.kernel.org/doc/html/latest/networking/net_failover.html) OK so I put this on a next branch for now, to merge after the release. I plan to rebase it after

[PATCH] linux-user: Support for NETLINK socket options

2019-10-29 Thread Josh Kunz
This change includes support for all AF_NETLINK socket options up to about kernel version 5.4 (5.4 is not formally released at the time of writing). Socket options that were introduced in kernel versions before the oldest currently stable kernel version are guarded by kernel version macros. This

Re: [PATCH v6 06/11] qapi: add failover negotiated event

2019-10-29 Thread Michael S. Tsirkin
On Fri, Oct 25, 2019 at 07:39:21PM +0200, Jens Freimann wrote: > On Fri, Oct 25, 2019 at 04:03:54PM +0200, Markus Armbruster wrote: > > Bear with me, I know next to nothing about failover. > > > > Jens Freimann writes: > > > > > This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY

Re: [PULL 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-10-29 Thread Aleksandar Markovic
On Tuesday, October 29, 2019, Philippe Mathieu-Daudé wrote: > Hi Aleksandar, > > On 10/29/19 6:18 AM, Aleksandar Markovic wrote: > >> >> >> On Monday, October 28, 2019, Philippe Mathieu-Daudé > > wrote: >> >> Hi Peter, >> >> This is a X86/MIPS pull, Paolo and

Re: [PATCH v35 00/13] QEMU AVR 8 bit cores

2019-10-29 Thread Michael Rolnik
Hi Aleksandar. I appreciate it. Regards, Michael On Tue, Oct 29, 2019 at 11:43 PM Aleksandar Markovic wrote: > > > > On Tuesday, October 29, 2019, Michael Rolnik wrote: >> >> This series of patches adds 8bit AVR cores to QEMU. > > > Hi Michael, > > I am going to take more detailed look at

Re: [PULL 0/16] Python (acceptance tests) queue, 2019-10-28

2019-10-29 Thread Cleber Rosa
On Tue, Oct 29, 2019 at 05:51:28PM -0400, Cleber Rosa wrote: > On Tue, Oct 29, 2019 at 09:13:45PM +, Peter Maydell wrote: > > On Mon, 28 Oct 2019 at 23:50, Cleber Rosa wrote: > > > > > > The following changes since commit > > > aaffb853359829a37daaf883c773e8320b55c723: > > > > > > Merge

Re: [PULL 0/16] Python (acceptance tests) queue, 2019-10-28

2019-10-29 Thread Cleber Rosa
On Tue, Oct 29, 2019 at 09:13:45PM +, Peter Maydell wrote: > On Mon, 28 Oct 2019 at 23:50, Cleber Rosa wrote: > > > > The following changes since commit aaffb853359829a37daaf883c773e8320b55c723: > > > > Merge remote-tracking branch > > 'remotes/maxreitz/tags/pull-block-2019-10-28' into

Re: [PATCH v35 00/13] QEMU AVR 8 bit cores

2019-10-29 Thread Aleksandar Markovic
On Tuesday, October 29, 2019, Michael Rolnik wrote: > This series of patches adds 8bit AVR cores to QEMU. Hi Michael, I am going to take more detailed look at your series as soon as these hectic days around softfreeze/hardfreeze days pass. It is definitely a series that needed a lot of hard

[PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-10-29 Thread Michael Rolnik
From: Sarah Harris These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins).

[PATCH v35 11/13] target/avr: Add example board configuration

2019-10-29 Thread Michael Rolnik
A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. NOTE: this is not a real board NOTE: it's used for CPU testing Signed-off-by: Michael

[PATCH v35 12/13] target/avr: Register AVR support with the rest of QEMU, the build system, and the WMAINTAINERS file

2019-10-29 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- MAINTAINERS | 9 + arch_init.c | 2 ++ configure | 7 +++ default-configs/avr-softmmu.mak | 5 + include/disas/dis-asm.h | 6 ++ include/sysemu/arch_init.h | 1 +

[PATCH v35 13/13] target/avr: Add tests

2019-10-29 Thread Michael Rolnik
1. Avocado test The test is based on https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo demo which. If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out. it also demostrates that timer and IRQ are working 2. Boot serial test Print out 'T' through

[PATCH v35 07/13] target/avr: Add instruction translation - Bit and Bit-test Instructions

2019-10-29 Thread Michael Rolnik
This includes: - LSR, ROR - ASR - SWAP - SBI, CBI - BST, BLD - BSET, BCLR Signed-off-by: Michael Rolnik --- target/avr/translate.c | 1123 1 file changed, 1123 insertions(+) diff --git a/target/avr/translate.c

[PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-10-29 Thread Michael Rolnik
This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris Signed-off-by: Michael Rolnik Signed-off-by: Sarah Harris Signed-off-by: Michael Rolnik Acked-by: Igor Mammedov ---

[PATCH v35 09/13] target/avr: Add instruction translation - CPU main translation function

2019-10-29 Thread Michael Rolnik
Co-developed-by: Richard Henderson Co-developed-by: Michael Rolnik Signed-off-by: Michael Rolnik --- target/avr/translate.c | 234 + 1 file changed, 234 insertions(+) diff --git a/target/avr/translate.c b/target/avr/translate.c index

[PATCH v35 06/13] target/avr: Add instruction translation - Branch Instructions

2019-10-29 Thread Michael Rolnik
This includes: - RJMP, IJMP, EIJMP, JMP - RCALL, ICALL, EICALL, CALL - RET, RETI - CPSE, CP, CPC, CPI - SBRC, SBRS, SBIC, SBIS - BRBC, BRBS Signed-off-by: Michael Rolnik --- target/avr/translate.c | 549 - 1 file changed, 546

[PATCH v35 08/13] target/avr: Add instruction translation - MCU Control Instructions

2019-10-29 Thread Michael Rolnik
This includes: - BREAK - NOP - SLEEP - WDR Signed-off-by: Michael Rolnik --- target/avr/translate.c | 174 + 1 file changed, 174 insertions(+) diff --git a/target/avr/translate.c b/target/avr/translate.c index f2ec2e2d2f..30ba13bdd7

[PATCH v35 00/13] QEMU AVR 8 bit cores

2019-10-29 Thread Michael Rolnik
This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support

[PATCH v35 02/13] target/avr: Add instruction helpers

2019-10-29 Thread Michael Rolnik
Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. SPM and WDR are unimplemented because they require emulation of complex peripherals. The implementation of SLEEP is very limited due to the lack of peripherals to generate wake interrupts. Memory

[PATCH v35 04/13] target/avr: Add instruction translation - Registers definition

2019-10-29 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target/avr/translate.c | 132 + 1 file changed, 132 insertions(+) create mode 100644 target/avr/translate.c diff --git a/target/avr/translate.c b/target/avr/translate.c new file mode 100644 index 00..53c9892a60

[PATCH v35 05/13] target/avr: Add instruction translation - Arithmetic and Logic Instructions

2019-10-29 Thread Michael Rolnik
This includes: - ADD, ADC, ADIW - SBIW, SUB, SUBI, SBC, SBCI - AND, ANDI - OR, ORI, EOR - COM, NEG - INC, DEC - MUL, MULS, MULSU - FMUL, FMULS, FMULSU - DES Signed-off-by: Michael Rolnik --- target/avr/translate.c | 822 + 1 file changed, 822

[PATCH v35 03/13] target/avr: Add instruction decoding

2019-10-29 Thread Michael Rolnik
This includes: - encoding of all 16 bit instructions - encoding of all 32 bit instructions Signed-off-by: Michael Rolnik --- target/avr/insn.decode | 175 + 1 file changed, 175 insertions(+) create mode 100644 target/avr/insn.decode diff --git

Re: [PULL 0/16] Python (acceptance tests) queue, 2019-10-28

2019-10-29 Thread Peter Maydell
On Mon, 28 Oct 2019 at 23:50, Cleber Rosa wrote: > > The following changes since commit aaffb853359829a37daaf883c773e8320b55c723: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-10-28' > into staging (2019-10-28 14:40:01 +) > > are available in the Git repository

Re: [PULL 00/19] QAPI patches for 2019-10-29

2019-10-29 Thread Peter Maydell
On Tue, 29 Oct 2019 at 10:24, Markus Armbruster wrote: > > The following changes since commit aaffb853359829a37daaf883c773e8320b55c723: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-10-28' > into staging (2019-10-28 14:40:01 +) > > are available in the Git

Re: [PULL V2 0/4] Net patches

2019-10-29 Thread Peter Maydell
On Tue, 29 Oct 2019 at 02:37, Jason Wang wrote: > > The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26 > 10:13:48 +0100) > > are available in the git

Re: [PATCH] fdc: support READ command with VERIFY DMA mode

2019-10-29 Thread Hervé Poussineau
Le 29/10/2019 à 12:00, John Snow a écrit : > > > On 10/20/19 2:38 AM, Sven Schnelle wrote: >> While working on the Tulip driver i tried to write some Teledisk images to >> a floppy image which didn't work. Turned out that Teledisk checks the written >> data by issuing a READ command to the FDC

Re: [PULL 0/1] qemu-openbios queue 20191028

2019-10-29 Thread Peter Maydell
On Mon, 28 Oct 2019 at 19:42, Mark Cave-Ayland wrote: > > [This contains a last-minute bugfix for qemu-system-sparc which fixes the > keyboard > in OpenBIOS when booting in graphics mode.] > > The following changes since commit 9bb73502321d46f4d320fa17aa38201445783fc4: > > Merge

Re: [RFC PATCH 0/6] docs: integrate doc comments with Sphinx build

2019-10-29 Thread Peter Maydell
On Tue, 29 Oct 2019 at 16:22, Paolo Bonzini wrote: > > Hello, > > this is an attempt at including kernel-doc, with small tweaks (see patch > 2) to support QEMU's doc comment format, in the Sphinx documentation pipeline. > > The ugly part is patch 3, which disables Sphinx's "nitpicking" (warn on >

Re: [RFC PATCH 0/6] docs: integrate doc comments with Sphinx build

2019-10-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191029162248.13383-1-pbonz...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PULL 00/11] Q800 branch patches

2019-10-29 Thread Peter Maydell
On Mon, 28 Oct 2019 at 18:48, Laurent Vivier wrote: > > The following changes since commit 7bc8f9734213b76e76631a483be13d6737c2adbc: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20191025' into staging (2019-10-25 > 13:12:16 +0100) > > are available in the Git

[Bug 1850378] Re: RISC-V unreliable IPIs

2019-10-29 Thread tm
I created a minimal example from my setup. I'm running a kernel 4.19.57 with a custom firmware based on bbl (https://github.com/riscv/riscv-pk). An ioctl device from a kernel module is used to execute the code above in kernel space. In the example, the userspace application proceeds after a

Re: [PULL 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-10-29 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 10/29/19 6:18 AM, Aleksandar Markovic wrote: On Monday, October 28, 2019, Philippe Mathieu-Daudé > wrote: Hi Peter, This is a X86/MIPS pull, Paolo and Aleksandar are OK I send it:

[PATCH 2/2] tests/fw_cfg: Test 'reboot-timeout=-1' special value

2019-10-29 Thread Philippe Mathieu-Daudé
The special value -1 means "don't reboot" for QEMU/libvirt. Add a trivial test. Signed-off-by: Philippe Mathieu-Daudé --- tests/fw_cfg-test.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c index 1d3147f821..5dc807ba23 100644

[PATCH 0/2] fw_cfg: Allow reboot-timeout=-1 again

2019-10-29 Thread Philippe Mathieu-Daudé
Fix the '-1' special value, and add a test. Dr. David Alan Gilbert (1): fw_cfg: Allow reboot-timeout=-1 again Philippe Mathieu-Daudé (1): tests/fw_cfg: Test 'reboot-timeout=-1' special value hw/nvram/fw_cfg.c | 7 --- tests/fw_cfg-test.c | 21 + 2 files changed,

[PATCH 1/2] fw_cfg: Allow reboot-timeout=-1 again

2019-10-29 Thread Philippe Mathieu-Daudé
From: "Dr. David Alan Gilbert" Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout to only allow the range 0..65535; however both qemu and libvirt document the special value -1 to mean don't reboot. Allow it again. Fixes: ee5d0f89de3e53cdb0dc ("fw_cfg: Fix -boot reboot-timeout

Re: [PULL 0/4] Crypto luks patches

2019-10-29 Thread Peter Maydell
On Mon, 28 Oct 2019 at 15:58, Daniel P. Berrangé wrote: > > The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26 > 10:13:48 +0100) > > are available in the Git

[PATCH 5/6] docs: add memory API reference

2019-10-29 Thread Paolo Bonzini
Add kernel-doc directive to parse and include doc comments from include/exec/memory.h. Signed-off-by: Paolo Bonzini --- docs/devel/memory.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/devel/memory.rst b/docs/devel/memory.rst index b6a4c37ea5..5dc8a12682 100644 ---

[PATCH 6/6] memory: include MemoryListener documentation and some missing function parameters

2019-10-29 Thread Paolo Bonzini
These cover the remaining warnings from kernel-doc. Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 211 +- 1 file changed, 209 insertions(+), 2 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 1e875996ec..c84fde75fa

[PATCH 4/6] memory: adjust API documentation to (modified) kerneldoc format

2019-10-29 Thread Paolo Bonzini
Fix a few instances where kernel-doc complains about doc comments in memory.h. Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index e499dc215b..1e875996ec

[PATCH 1/6] docs: import Linux kernel-doc script and extension

2019-10-29 Thread Paolo Bonzini
Import Linux's kernel-doc script, as well as the Linux extension to call kernel-doc according to the arguments and parameters given to a reStructuredText directive. The kernel-doc extension accepts a filename, which is relative to the QEMU source tree root. The extension also notifies Sphinx

[PATCH 2/6] docs: tweak kernel-doc for QEMU coding standards

2019-10-29 Thread Paolo Bonzini
Surprisingly, QEMU does have a pretty consistent doc comment style and it is not very different from the Linux kernel's. Of the documentation "sigils", only "#" separates the QEMU doc comment style from Linux's, and it has 200+ instances vs. 6 for the kernel's ' foo' (all in

[RFC PATCH 0/6] docs: integrate doc comments with Sphinx build

2019-10-29 Thread Paolo Bonzini
Hello, this is an attempt at including kernel-doc, with small tweaks (see patch 2) to support QEMU's doc comment format, in the Sphinx documentation pipeline. The ugly part is patch 3, which disables Sphinx's "nitpicking" (warn on invalid cross-reference) mode. It would probably be possible to

[PATCH 3/6] docs: disable sphinx warning about missing cross references

2019-10-29 Thread Paolo Bonzini
Sphinx is a bit *too* strict about missing cross references to C types, where it complains about missing references to uint8_t. Even if that were fixed in kernel-doc, we would still have lots of missing references to types that are not yet documented. So unfortunately let's disable for now the

Re: [PATCH v5 00/13] Multi-phase reset mechanism

2019-10-29 Thread Damien Hedde
Hi, Does anyone has comment about the interface / patch 3 ? Should I try to split it ? Thanks, Damien On 10/18/19 5:06 PM, Damien Hedde wrote: > Hi all, > > The purpose of this series is to split the current reset procedure > into multiple phases. This will help to solve some ordering >

Re: [PULL v2 00/12] tcg patch queue

2019-10-29 Thread Peter Maydell
On Mon, 28 Oct 2019 at 14:59, Richard Henderson wrote: > > V2 fixes a build problem that affected win32. > > > r~ > > > The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging

[Bug 1850378] Re: RISC-V unreliable IPIs

2019-10-29 Thread Palmer Dabbelt
Can you post a whole program that reproduces this? freedom-e-sdk will run bare-metal code on QEMU if you don't want to post the rest of the surrounding infrastructure. -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [PATCH v1 1/1] target/riscv: Remove atomic accesses to MIP CSR

2019-10-29 Thread Palmer Dabbelt
On Tue, 29 Oct 2019 03:49:23 PDT (-0700), alistai...@gmail.com wrote: On Fri, Oct 18, 2019 at 7:44 PM Alistair Francis wrote: On Fri, Oct 18, 2019 at 9:51 AM Palmer Dabbelt wrote: > > On Tue, 08 Oct 2019 15:04:18 PDT (-0700), Alistair Francis wrote: > > Instead of relying on atomics to

[PATCH] block/block-copy: fix s->copy_size for compressed cluster

2019-10-29 Thread Vladimir Sementsov-Ogievskiy
0e2402452f1f20429 allowed writes larger than cluster, but that's unsupported for compressed write. Fix it. Fixes: 0e2402452f1f20429 Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-copy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/block-copy.c

RFC: New device for zero-copy VM memory access

2019-10-29 Thread geoff
Hi All, Over the past week, I have been working to come up with a solution to the memory transfer performance issues that hinder the Looking Glass Project. Currently Looking Glass works by using the IVSHMEM shared memory device which is fed by an application that captures the guest's video

Re: [RFC v2 07/22] hw/pci: introduce pci_device_iommu_context()

2019-10-29 Thread David Gibson
On Thu, Oct 24, 2019 at 08:34:28AM -0400, Liu Yi L wrote: > This patch adds pci_device_iommu_context() to get an iommu_context > for a given device. A new callback is added in PCIIOMMUOps. Users > who wants to listen to events issued by vIOMMU could use this new > interface to get an iommu_context

Re: [RFC v2 09/22] vfio/pci: add iommu_context notifier for pasid alloc/free

2019-10-29 Thread David Gibson
On Thu, Oct 24, 2019 at 08:34:30AM -0400, Liu Yi L wrote: > This patch adds pasid alloc/free notifiers for vfio-pci. It is > supposed to be fired by vIOMMU. VFIO then sends PASID allocation > or free request to host. > > Cc: Kevin Tian > Cc: Jacob Pan > Cc: Peter Xu > Cc: Eric Auger > Cc: Yi

Re: [PATCH] nvme: fix NSSRS offset in CAP register

2019-10-29 Thread Max Reitz
On 23.10.19 09:33, Klaus Jensen wrote: > Fix the offset of the NSSRS field the CAP register. > > Signed-off-by: Klaus Jensen > Reported-by: Javier Gonzalez > --- > include/block/nvme.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks; added John’s note and applied to my block

Re: [PATCH] iotests: Remove 130 from the "auto" group

2019-10-29 Thread Max Reitz
On 18.10.19 18:10, Thomas Huth wrote: > Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared > 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?" > error with 130 already twice. Looks like this test is a little bit > shaky, and currently nobody has a real clue

Re: [PATCH 0/1] dirty-bitmaps: remove deprecated autoload parameter

2019-10-29 Thread Max Reitz
On 25.09.19 01:01, John Snow wrote: > I'm going to be honest, here. There's actually no real reason to remove > this now, but we could, so I'm going to. > > Also, in terms of the API serving as documentation, it's nicer to not > pretend this is an option that does anything, so out it goes. > >

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-29 Thread Philippe Mathieu-Daudé
On 10/29/19 3:26 AM, Dr. David Alan Gilbert wrote: * Laszlo Ersek (ler...@redhat.com) wrote: On 10/25/19 18:57, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout to only allow the range 0..65535; however both

Re: [PATCH v7 05/11] qapi: add unplug primary event

2019-10-29 Thread Markus Armbruster
Jens Freimann writes: > On Tue, Oct 29, 2019 at 01:50:02PM +0100, Markus Armbruster wrote: >>Jens Freimann writes: >> >>> This event is emitted when we sent a request to unplug a >> >>Uh, "we sent a requestion [...] from the Guest OS"... do you mean "we >>received"? > > No, we sent a pci

Re: [PATCH v7 05/11] qapi: add unplug primary event

2019-10-29 Thread Jens Freimann
On Tue, Oct 29, 2019 at 01:50:02PM +0100, Markus Armbruster wrote: Jens Freimann writes: This event is emitted when we sent a request to unplug a Uh, "we sent a requestion [...] from the Guest OS"... do you mean "we received"? No, we sent a pci hotplug event to the guest by "pushing" the

Re: [PATCH] MAINTAINERS: add more bitmap-related to Dirty Bitmaps section

2019-10-29 Thread John Snow
On 10/26/19 12:56 PM, Vladimir Sementsov-Ogievskiy wrote: > Let's add bitmaps persistence qcow2 feature and postcopy bitmaps > migration to Dirty Bitmaps section. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow > --- > MAINTAINERS | 2 ++ > 1 file changed, 2

Re: [PATCH v2 0/2] block/nvme: add support for write zeros and discard

2019-10-29 Thread John Snow
On 10/28/19 6:35 AM, Max Reitz wrote: > On 13.09.19 15:36, Maxim Levitsky wrote: >> This is the second part of the patches I prepared >> for this driver back when I worked on mdev-nvme. >> >> V2: addressed review feedback, no major changes >> >> Best regards, >> Maxim Levitsky >> >> Maxim

[Bug 1850378] [NEW] RISC-V unreliable IPIs

2019-10-29 Thread tm
Public bug reported: I am working on a project with custom inter processor interrupts (IPIs) on the RISC-V virt machine. After upgrading from version 3.1.0 to 4.1.0 which fixes a related issue (https://github.com/riscv/riscv-qemu/issues/132) I am able to use the CPU hotplug feature. However,

Re: [PATCH v5 1/2] hw: rtc: Add Goldfish RTC device

2019-10-29 Thread Alistair Francis
On Fri, Oct 25, 2019 at 6:30 AM Anup Patel wrote: > > This patch adds model for Google Goldfish virtual platform RTC device. > > We will be adding Goldfish RTC device to the QEMU RISC-V virt machine > for providing real date-time to Guest Linux. The corresponding Linux > driver for Goldfish RTC

Re: [PATCH v5 0/2] RTC support for QEMU RISC-V virt machine

2019-10-29 Thread Alistair Francis
On Fri, Oct 25, 2019 at 6:28 AM Anup Patel wrote: > > This series adds RTC device to QEMU RISC-V virt machine. We have > selected Goldfish RTC device model for this. It's a pretty simple > synthetic device with few MMIO registers and no dependency external > clock. The driver for Goldfish RTC is

Re: [PATCH v7 1/4] block/replication.c: Ignore requests after failover

2019-10-29 Thread Max Reitz
On 24.10.19 16:25, Lukas Straub wrote: > After failover the Secondary side of replication shouldn't change state, > because > it now functions as our primary disk. > > In replication_start, replication_do_checkpoint, replication_stop, ignore > the request if current state is

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-29 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert (git)" writes: > >> > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Commit ee5d0f89de3e53cdb0dc added range checking on

Re: [PATCH v7 05/11] qapi: add unplug primary event

2019-10-29 Thread Markus Armbruster
Jens Freimann writes: > This event is emitted when we sent a request to unplug a Uh, "we sent a requestion [...] from the Guest OS"... do you mean "we received"? > failover primary device from the Guest OS and it includes the > device id of the primary device. > > Signed-off-by: Jens Freimann

Re: [PATCH v7 06/11] qapi: add failover negotiated event

2019-10-29 Thread Markus Armbruster
Jens Freimann writes: > This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature > is enabled. The primary device this virtio-net (standby) device is > associated with, is now hotplugged by the virtio-net device. > > Signed-off-by: Jens Freimann > --- > qapi/net.json | 19

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-29 Thread Max Reitz
On 29.10.19 13:19, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 15:11, Max Reitz wrote: >> On 29.10.19 13:05, Vladimir Sementsov-Ogievskiy wrote: >>> 29.10.2019 14:55, Max Reitz wrote: On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 11:50, Max Reitz wrote: >>

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-29 Thread Vladimir Sementsov-Ogievskiy
29.10.2019 15:11, Max Reitz wrote: > On 29.10.19 13:05, Vladimir Sementsov-Ogievskiy wrote: >> 29.10.2019 14:55, Max Reitz wrote: >>> On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: 29.10.2019 11:50, Max Reitz wrote: > On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: >>

Re: [PATCH v6 06/11] qapi: add failover negotiated event

2019-10-29 Thread Markus Armbruster
Jens Freimann writes: > On Fri, Oct 25, 2019 at 04:03:54PM +0200, Markus Armbruster wrote: >>Bear with me, I know next to nothing about failover. >> >>Jens Freimann writes: >> >>> This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature >>> was enabled. The primary device this

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-29 Thread Max Reitz
On 29.10.19 13:05, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 14:55, Max Reitz wrote: >> On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: >>> 29.10.2019 11:50, Max Reitz wrote: On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: > 28.10.2019 14:04, Kevin Wolf wrote: >>

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-29 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" writes: >> >> > From: "Dr. David Alan Gilbert" >> > >> > Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout >> > to only allow the range 0..65535; however both

Re: [PATCH v5 1/3] tests/vm: netbsd autoinstall, using serial console

2019-10-29 Thread Alex Bennée
Thomas Huth writes: > On 18/10/2019 20.17, Eduardo Habkost wrote: >> From: Gerd Hoffmann >> >> Instead of fetching the prebuilt image from patchew download the install >> iso and prepare the image locally. Install to disk, using the serial >> console. Create qemu user, configure ssh login.

Re: [PATCH v1 1/1] target/riscv: Remove atomic accesses to MIP CSR

2019-10-29 Thread Alex Bennée
Alistair Francis writes: > Instead of relying on atomics to access the MIP register let's update > our helper function to instead just lock the IO mutex thread before > writing. This follows the same concept as used in PPC for handling > interrupts > > Signed-off-by: Alistair Francis

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-29 Thread Vladimir Sementsov-Ogievskiy
29.10.2019 14:55, Max Reitz wrote: > On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: >> 29.10.2019 11:50, Max Reitz wrote: >>> On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: 28.10.2019 14:04, Kevin Wolf wrote: > Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben: >>

[PATCH v7 11/11] vfio: unplug failover primary device before migration

2019-10-29 Thread Jens Freimann
As usual block all vfio-pci devices from being migrated, but make an exception for failover primary devices. This is achieved by setting unmigratable to 0 but also add a migration blocker for all vfio-pci devices except failover primary devices. These will be unplugged before migration happens by

  1   2   >