[PATCH v17 11/14] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-11-21 Thread Tao Xu
From: Liu Jingqi This structure describes the memory access latency and bandwidth information from various memory access initiator proximity domains. The latency and bandwidth numbers represented in this structure correspond to rated latency and bandwidth for the platform. The software could use

[PATCH 1/4] s390x: Don't do a normal reset on the initial cpu

2019-11-21 Thread Janosch Frank
The initiating cpu needs to be reset with an initial reset. While doing a normal reset followed by a initial reset is not wron per-se, the Ultravisor will only allow the correct reset to be performed. Signed-off-by: Janosch Frank --- hw/s390x/s390-virtio-ccw.c | 3 +++ 1 file changed, 3

[PATCH v17 07/14] numa: Extend CLI to provide initiator information for numa nodes

2019-11-21 Thread Tao Xu
In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), The initiator represents processor which access to memory. And in 5.2.27.3 Memory Proximity Domain Attributes Structure, the attached initiator is defined as where the memory controller responsible for a memory proximity

[PATCH v17 10/14] hmat acpi: Build Memory Proximity Domain Attributes Structure(s)

2019-11-21 Thread Tao Xu
From: Liu Jingqi HMAT is defined in ACPI 6.3: 5.2.27 Heterogeneous Memory Attribute Table (HMAT). The specification references below link: http://www.uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf It describes the memory attributes, such as memory side cache attributes and

[PATCH v17 09/14] numa: Extend CLI to provide memory side cache information

2019-11-21 Thread Tao Xu
From: Liu Jingqi Add -numa hmat-cache option to provide Memory Side Cache Information. These memory attributes help to build Memory Side Cache Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Reviewed-by: Daniel Black Signed-off-by: Liu Jingqi Signed-off-by: Tao

[PATCH 4/4] s390x: Beautify machine reset

2019-11-21 Thread Janosch Frank
* Add comments that tell you which diag308 subcode caused the reset * Sort by diag308 reset subcode Signed-off-by: Janosch Frank --- hw/s390x/s390-virtio-ccw.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c

[PATCH v17 05/14] qapi: Add builtin type time

2019-11-21 Thread Tao Xu
Add optional builtin type time, fallback is uint64. This type use qemu_strtotime_ns() for pre-converting time suffix to numbers. Signed-off-by: Tao Xu --- No changes in v17. Changes in v14: - Drop time unit picosecond (Eric) --- include/qapi/visitor-impl.h | 4

[PATCH v17 01/14] util/cutils: Add Add qemu_strtold and qemu_strtold_finite

2019-11-21 Thread Tao Xu
Work like qemu_strtod() and qemu_strtold_finite, except store long double. Signed-off-by: Tao Xu --- No changes in v17. --- include/qemu/cutils.h | 3 +++ util/cutils.c | 48 ++- 2 files changed, 50 insertions(+), 1 deletion(-) diff --git

[PATCH v17 00/14] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-11-21 Thread Tao Xu
This series of patches will build Heterogeneous Memory Attribute Table (HMAT) according to the command line. The ACPI HMAT describes the memory attributes, such as memory side cache attributes and bandwidth and latency details, related to the Memory Proximity Domain. The software is expected to

[PATCH v17 06/14] tests: Add test for QAPI builtin type time

2019-11-21 Thread Tao Xu
Add tests for time input such as zero, around limit of precision, signed upper limit, actual upper limit, beyond limits, time suffixes, and etc. Signed-off-by: Tao Xu --- No changes in v17. Changes in v16: - Update the test cases Changes in v14: - Drop time unit picosecond (Eric) ---

[PATCH v17 08/14] numa: Extend CLI to provide memory latency and bandwidth information

2019-11-21 Thread Tao Xu
From: Liu Jingqi Add -numa hmat-lb option to provide System Locality Latency and Bandwidth Information. These memory attributes help to build System Locality Latency and Bandwidth Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Reviewed-by: Igor Mammedov

[PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

2019-11-21 Thread Tao Xu
Add do_strtomul() to convert string according to different suffixes. Reviewed-by: Eduardo Habkost Signed-off-by: Tao Xu --- No changes in v17. Changes in v15: - Add a new patch to refactor do_strtosz() (Eduardo) --- util/cutils.c | 72 ++-

[PATCH v17 04/14] util/cutils: Add qemu_strtotime_ns()

2019-11-21 Thread Tao Xu
To convert strings with time suffixes to numbers, support time unit are "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" for second. Add test for qemu_strtotime_ns, test the input of basic, time suffixes, float, invaild, trailing and overflow. Reviewed-by: Eduardo Habkost

[PATCH v17 02/14] util/cutils: Use qemu_strtold_finite to parse size

2019-11-21 Thread Tao Xu
Support full 64bit precision, modify related test cases. Signed-off-by: Tao Xu --- No changes in v17. --- tests/test-cutils.c| 41 +--- tests/test-keyval.c| 47 +++--- tests/test-qemu-opts.c | 39

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-11-21 Thread Richard Henderson
On 11/22/19 6:33 AM, Pavel Dovgalyuk wrote: >> From: Aleksandar Markovic [mailto:aleksandar.m.m...@gmail.com] >>> Why not implement the dump_ASM code? This is very useful... >>> >> >> ... and time-consuming to implement, unless Michael have some >> ready off-shelf code. > > We already did this by

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-11-21 Thread Richard Henderson
On 11/21/19 8:53 PM, Michael Rolnik wrote: > It seems to be a huge investment. this function should parse the > binary data as `decode_insn` does, so I suggest to modify decodetree > tool to make decoding information available to the instruction print > function. > what do you think? See

Re: [PATCH v2] linux-user/strace: Add missing signal strings

2019-11-21 Thread Helge Deller
On 21.11.19 19:43, Aleksandar Markovic wrote: > On Wed, Nov 20, 2019 at 3:57 PM Helge Deller wrote: >> >> Add the textual representations of some missing target signals. >> >> Signed-off-by: Helge Deller >> >> diff --git a/linux-user/strace.c b/linux-user/strace.c >> index 3d4d684450..de43238fa4

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Markus Armbruster
Eric Blake writes: > On 11/21/19 1:46 PM, Markus Armbruster wrote: > The '*' is redundant in this form. Can anyone think of reasons for keeping it anyway? Against? >>> >>> Is there ever a reason to allow an optional member but without a >>> 'default' value? Or can we just

Re: [PATCH 0/5] vfio/spapr: Handle changes of master irq chip for VFIO devices

2019-11-21 Thread Greg Kurz
On Thu, 21 Nov 2019 11:56:02 +1100 David Gibson wrote: > Due to the way feature negotiation works in PAPR (which is a > paravirtualized platform), we can end up changing the global irq chip > at runtime, including it's KVM accelerate model. That causes > complications for VFIO devices with

Re: [PATCH 3/5] vfio/pci: Respond to KVM irqchip change notifier

2019-11-21 Thread David Gibson
On Fri, Nov 22, 2019 at 06:12:57AM +0100, Greg Kurz wrote: > On Thu, 21 Nov 2019 11:56:05 +1100 > David Gibson wrote: > > > VFIO PCI devices already respond to the pci intx routing notifier, in order > > to update kernel irqchip mappings when routing is updated. However this > > won't handle

RE: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-11-21 Thread Pavel Dovgalyuk
> From: Aleksandar Markovic [mailto:aleksandar.m.m...@gmail.com] > > Why not implement the dump_ASM code? This is very useful... > > > > ... and time-consuming to implement, unless Michael have some > ready off-shelf code. We already did this by taking the disassembly code from binutils:

Re: [PATCH 3/5] vfio/pci: Respond to KVM irqchip change notifier

2019-11-21 Thread Greg Kurz
On Thu, 21 Nov 2019 11:56:05 +1100 David Gibson wrote: > VFIO PCI devices already respond to the pci intx routing notifier, in order > to update kernel irqchip mappings when routing is updated. However this > won't handle the case where the irqchip itself is replaced by a different > model

Re: [PATCH v3 2/3] spapr: Add NVDIMM device support

2019-11-21 Thread David Gibson
On Mon, Oct 14, 2019 at 01:37:50PM -0500, Shivaprasad G Bhat wrote: > Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm > device interface in QEMU to support virtual NVDIMM devices for Power. > Create the required DT entries for the device (some entries have > dummy values

Re: [PATCH v3 3/3] spapr: Add Hcalls to support PAPR NVDIMM device

2019-11-21 Thread David Gibson
On Mon, Oct 14, 2019 at 01:38:16PM -0500, Shivaprasad G Bhat wrote: > This patch implements few of the necessary hcalls for the nvdimm support. > > PAPR semantics is such that each NVDIMM device is comprising of multiple > SCM(Storage Class Memory) blocks. The guest requests the hypervisor to >

Re: [PATCH 2/5] ipmi: Add support to customize OEM functions

2019-11-21 Thread David Gibson
On Thu, Nov 21, 2019 at 08:22:50PM -0600, Corey Minyard wrote: > On Mon, Oct 21, 2019 at 03:12:12PM +0200, Cédric Le Goater wrote: > > The routine ipmi_register_oem_netfn() lets external modules register > > command handlers for OEM functions. Required for the PowerNV machine. > > > > Cc: Corey

Re: [PATCH v2] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread David Gibson
On Thu, Nov 21, 2019 at 05:23:40PM +0100, Cédric Le Goater wrote: > The BMC of the OpenPOWER systems monitors the machine state using > sensors, controls the power and controls the access to the PNOR flash > device containing the firmware image required to boot the host. > > QEMU models the power

Re: [PATCH] riscv: sifive_u: Add a "serial" property for board serial number

2019-11-21 Thread Palmer Dabbelt
On Thu, 21 Nov 2019 17:10:18 PST (-0800), bmeng...@gmail.com wrote: On Sat, Nov 16, 2019 at 11:08 PM Bin Meng wrote: At present the board serial number is hard-coded to 1, and passed to OTP model during initialization. Firmware (FSBL, U-Boot) uses the serial number to generate a unique MAC

Re: [PATCH 2/5] ipmi: Add support to customize OEM functions

2019-11-21 Thread Corey Minyard
On Mon, Oct 21, 2019 at 03:12:12PM +0200, Cédric Le Goater wrote: > The routine ipmi_register_oem_netfn() lets external modules register > command handlers for OEM functions. Required for the PowerNV machine. > > Cc: Corey Minyard > Signed-off-by: Cédric Le Goater David, Sorry, I wasn't

Re: [PATCH 0/5] vfio/spapr: Handle changes of master irq chip for VFIO devices

2019-11-21 Thread David Gibson
On Thu, Nov 21, 2019 at 06:28:07PM -0700, Alex Williamson wrote: > On Fri, 22 Nov 2019 12:18:24 +1100 > David Gibson wrote: > > > On Thu, Nov 21, 2019 at 09:57:38AM -0700, Alex Williamson wrote: > > > On Thu, 21 Nov 2019 11:56:02 +1100 > > > David Gibson wrote: > > > > > > > Due to the way

Re: [PATCH 0/5] vfio/spapr: Handle changes of master irq chip for VFIO devices

2019-11-21 Thread Alex Williamson
On Fri, 22 Nov 2019 12:18:24 +1100 David Gibson wrote: > On Thu, Nov 21, 2019 at 09:57:38AM -0700, Alex Williamson wrote: > > On Thu, 21 Nov 2019 11:56:02 +1100 > > David Gibson wrote: > > > > > Due to the way feature negotiation works in PAPR (which is a > > > paravirtualized platform), we

Re: [PATCH 0/5] vfio/spapr: Handle changes of master irq chip for VFIO devices

2019-11-21 Thread David Gibson
On Thu, Nov 21, 2019 at 09:57:38AM -0700, Alex Williamson wrote: > On Thu, 21 Nov 2019 11:56:02 +1100 > David Gibson wrote: > > > Due to the way feature negotiation works in PAPR (which is a > > paravirtualized platform), we can end up changing the global irq chip > > at runtime, including it's

Re: [PATCH] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread David Gibson
On Thu, Nov 21, 2019 at 09:35:07AM -0600, Corey Minyard wrote: > On Wed, Nov 20, 2019 at 09:05:07AM +1100, David Gibson wrote: > > On Tue, Nov 19, 2019 at 07:49:33AM +0100, Cédric Le Goater wrote: > > > On 19/11/2019 01:52, David Gibson wrote: > > > > On Mon, Nov 18, 2019 at 10:22:22AM +0100,

Re: [PATCH] riscv: sifive_u: Add a "serial" property for board serial number

2019-11-21 Thread Bin Meng
On Sat, Nov 16, 2019 at 11:08 PM Bin Meng wrote: > > At present the board serial number is hard-coded to 1, and passed > to OTP model during initialization. Firmware (FSBL, U-Boot) uses > the serial number to generate a unique MAC address for the on-chip > ethernet controller. When multiple QEMU

Re: [PATCH 0/5] hvf: stability fixes for HVF

2019-11-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1574375668.git.di...@apple.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/5] hvf: stability fixes for HVF Type: series Message-id: cover.1574375668.git.di...@apple.com ===

[PATCH v2] Fix incorrect integer->float conversions caught by clang -Wimplicit-int-float-conversion

2019-11-21 Thread Fangrui Song
On 2019-11-21, Eric Blake wrote: On 11/19/19 2:49 PM, Fangrui Song wrote: Can we simply drop the offending line statement instead? Fixed in the new patch. The first val * mul above this range is 0x1p64.  Rejecting it is correct, because it overflows yint64_t. I am not subscribed, so

RE: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-21 Thread Taylor Simpson
Hi Aleksandar, The complete qemu-hexagon implementation can be found here https://github.com/quic/qemu From the beginning, I knew I would have to divide it up into smaller patches for review. The discussion on how divide it was here

Re: [PATCH] linux-user: Improve strace output for read() and getcwd()

2019-11-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191121201448.ga3...@ls3530.fritz.box/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] linux-user: Improve strace output for read() and getcwd() Type: series Message-id:

[PATCH 4/5] hvf: more accurately match SDM when setting CR0 and PDPTE registers

2019-11-21 Thread Cameron Esfahani via
More accurately match SDM when setting CR0 and PDPTE registers. Clear PDPTE registers when resetting vcpus. Signed-off-by: Cameron Esfahani --- target/i386/hvf/hvf.c | 8 target/i386/hvf/vmx.h | 18 ++ 2 files changed, 18 insertions(+), 8 deletions(-) diff --git

[PATCH 3/5] hvf: correctly handle REX prefix in relation to legacy prefixes

2019-11-21 Thread Cameron Esfahani via
In real x86 processors, the REX prefix must come after legacy prefixes. REX before legacy is ignored. Update the HVF emulation code to properly handle this. Fix some spelling errors in constants. Fix some decoder table initialization issues found by Coverity. Signed-off-by: Cameron Esfahani

[PATCH 1/5] hvf: non-RAM, non-ROMD memory ranges are now correctly mapped in

2019-11-21 Thread Cameron Esfahani via
If an area is non-RAM and non-ROMD, then remove mappings so accesses will trap and can be emulated. Change hvf_find_overlap_slot() to take a size instead of an end address: it wouldn't return a slot because callers would pass the same address for start and end. Don't always map area as

[PATCH 5/5] hvf: save away type as well as vector so we can reinject them

2019-11-21 Thread Cameron Esfahani via
Save away type as well as vector in hvf_store_events() so we can correctly reinject both in hvf_inject_interrupts(). Make sure to clear ins_len and has_error_code when ins_len isn't valid and error_code isn't set. Signed-off-by: Cameron Esfahani --- target/i386/hvf/hvf.c| 16

[PATCH 0/5] hvf: stability fixes for HVF

2019-11-21 Thread Cameron Esfahani via
The following patches fix stability issues with running QEMU on Apple Hypervisor Framework (HVF): - non-RAM, non-ROMD areas need to trap so accesses can be correctly emulated. - Current TSC synchronization implementation is insufficient: when running with more than 1 core, TSC values can go

[PATCH 2/5] hvf: remove TSC synchronization code because it isn't fully complete

2019-11-21 Thread Cameron Esfahani via
The existing code in QEMU's HVF support to attempt to synchronize TSC across multiple cores is not sufficient. TSC value on other cores can go backwards. Until implementation is fixed, remove calls to hv_vm_sync_tsc(). Pass through TSC to guest OS. Signed-off-by: Cameron Esfahani ---

Re: [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

2019-11-21 Thread Corey Minyard
On Wed, Nov 20, 2019 at 07:24:36PM +0400, Marc-André Lureau wrote: > Instead, set the initial data field directly. > > (the initial data is an array of 256 bytes. As I don't know if it may > change over time, I keep the pointer to original buffer as is, but it > might be worth to consider to copy

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-11-21 Thread Aleksandar Markovic
> Why not implement the dump_ASM code? This is very useful... > ... and time-consuming to implement, unless Michael have some ready off-shelf code. It is great that you have lots of ideas, Philippe, however I think that it is counterproductive to suggest Michael to work on this at this moment.

Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-21 Thread Aleksandar Markovic
On Thu, Nov 21, 2019 at 8:52 PM Taylor Simpson wrote: > > They are imported from the existing Hexagon simulator. Please understand > that this patch is the first in a series. Later patches will contain more > elaborate contents in that directory. The reason I don't want to reformat > them

[PATCH] linux-user: Improve strace output for read() and getcwd()

2019-11-21 Thread Helge Deller
The strace functionality in qemu-user lacks the possibility to trace which real values get returned to pointers in userspace by syscalls. For example, the read() and getcwd() syscalls currently only show the destination address where the syscalls should put the return values: 2532

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Eric Blake
On 11/21/19 1:46 PM, Markus Armbruster wrote: The '*' is redundant in this form. Can anyone think of reasons for keeping it anyway? Against? Is there ever a reason to allow an optional member but without a 'default' value? Or can we just blindly state that if 'default' is not present, that

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-11-21 Thread Michael Rolnik
It seems to be a huge investment. this function should parse the binary data as `decode_insn` does, so I suggest to modify decodetree tool to make decoding information available to the instruction print function. what do you think? On Thu, Nov 21, 2019 at 9:44 PM Michael Rolnik wrote: > > On

RE: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-21 Thread Taylor Simpson
They are imported from the existing Hexagon simulator. Please understand that this patch is the first in a series. Later patches will contain more elaborate contents in that directory. The reason I don't want to reformat them is to stay in sync with the other simulator in the future. When

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Markus Armbruster
Eric Blake writes: > On 11/21/19 9:07 AM, Markus Armbruster wrote: >> Max Reitz writes: >> >>> With this change, it is possible to give default values for struct >>> members, as follows: >>> >>>What you had to do so far: >>> >>> # @member: Some description, defaults to 42. >>> {

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-11-21 Thread Michael Rolnik
On Thu, Nov 21, 2019 at 8:55 PM Philippe Mathieu-Daudé wrote: > > Hi Michael, > > On 10/29/19 10:24 PM, Michael Rolnik wrote: > > This includes: > > - CPU data structures > > - object model classes and functions > > - migration functions > > - GDB hooks > > > > Co-developed-by: Michael Rolnik >

Re: [PATCH v3] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Aleksandar Markovic
On Thu, Nov 21, 2019 at 8:33 PM Helge Deller wrote: > > Improve strace output of various syscalls which either have none > or only int-type parameters. > > Signed-off-by: Helge Deller > > --- Reviewed-by: Aleksandar Markovic > Changes in v3: > fixed alarm() > added epoll_create(),

Re: [PATCH] vmstate-static-checker: Fix for current python

2019-11-21 Thread Cleber Rosa
- Original Message - > From: "Dr. David Alan Gilbert (git)" > To: qemu-devel@nongnu.org, quint...@redhat.com, ehabk...@redhat.com, > cr...@redhat.com > Sent: Thursday, November 21, 2019 1:53:03 PM > Subject: [PATCH] vmstate-static-checker: Fix for current python > > From: "Dr. David

[PATCH v3] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Helge Deller
Improve strace output of various syscalls which either have none or only int-type parameters. Signed-off-by: Helge Deller --- Changes in v3: fixed alarm() added epoll_create(), epoll_create1(), eventfd(), eventfd2() Changes in v2: fixed ioctl() diff --git a/linux-user/strace.list

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Aleksandar Markovic
On Thu, Nov 21, 2019 at 8:12 PM Helge Deller wrote: > > On 21.11.19 19:23, Philippe Mathieu-Daudé wrote: > > On 11/21/19 6:35 PM, Aleksandar Markovic wrote: > >> On Thursday, November 21, 2019, Philippe Mathieu-Daudé >> > wrote: > >> > >> On 11/21/19 6:00 PM,

Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-21 Thread Aleksandar Markovic
> create mode 100644 target/hexagon/imported/global_types.h > create mode 100644 target/hexagon/imported/iss_ver_registers.h > create mode 100644 target/hexagon/imported/max.h > create mode 100644 target/hexagon/imported/regs.h Taylor, if I understood you well, these files don't confirm to

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Helge Deller
On 21.11.19 19:23, Philippe Mathieu-Daudé wrote: > On 11/21/19 6:35 PM, Aleksandar Markovic wrote: >> On Thursday, November 21, 2019, Philippe Mathieu-Daudé > > wrote: >> >>     On 11/21/19 6:00 PM, Aleksandar Markovic wrote: >> >>     On Thursday, November 21, 2019,

Re: [PATCH] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-21 Thread Palmer Dabbelt
On Thu, 21 Nov 2019 10:55:32 PST (-0800), alistai...@gmail.com wrote: On Wed, Nov 20, 2019 at 6:40 PM Palmer Dabbelt wrote: On Sun, 10 Nov 2019 13:10:33 PST (-0800), da...@gibson.dropbear.id.au wrote: > On Fri, Nov 08, 2019 at 10:13:16AM -0800, Palmer Dabbelt wrote: >> On Fri, 08 Nov 2019

Re: [PATCH] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-21 Thread Alistair Francis
On Wed, Nov 20, 2019 at 6:40 PM Palmer Dabbelt wrote: > > On Sun, 10 Nov 2019 13:10:33 PST (-0800), da...@gibson.dropbear.id.au wrote: > > On Fri, Nov 08, 2019 at 10:13:16AM -0800, Palmer Dabbelt wrote: > >> On Fri, 08 Nov 2019 10:04:47 PST (-0800), Peter Maydell wrote: > >> > On Fri, 8 Nov 2019

Re: [PATCH-for-4.2?] vmstate-static-checker: Fix for current python

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 7:53 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Python 3.7.5 on f31 doesn't seem to like the old type=file syntax on argparse. Looks 4.2 worth to me. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Dr. David Alan Gilbert ---

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-11-21 Thread Philippe Mathieu-Daudé
Hi Michael, On 10/29/19 10:24 PM, Michael Rolnik wrote: This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris Signed-off-by: Michael Rolnik Signed-off-by: Sarah Harris

Re: [PATCH v2] linux-user/strace: Add missing signal strings

2019-11-21 Thread Aleksandar Markovic
On Thu, Nov 21, 2019 at 6:27 PM Laurent Vivier wrote: > > Le 20/11/2019 à 15:55, Helge Deller a écrit : > > Add the textual representations of some missing target signals. > > > > Signed-off-by: Helge Deller > > > > diff --git a/linux-user/strace.c b/linux-user/strace.c > > index

[PATCH] vmstate-static-checker: Fix for current python

2019-11-21 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Python 3.7.5 on f31 doesn't seem to like the old type=file syntax on argparse. Signed-off-by: Dr. David Alan Gilbert --- scripts/vmstate-static-checker.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/vmstate-static-checker.py

Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device

2019-11-21 Thread Marc-André Lureau
Hi On Thu, Nov 21, 2019 at 10:24 PM Peter Maydell wrote: > > On Thu, 21 Nov 2019 at 18:15, Marc-André Lureau > wrote: > > > > On Thu, Nov 21, 2019 at 5:47 PM Peter Maydell > > wrote: > > > > > > On Wed, 20 Nov 2019 at 15:27, Marc-André Lureau > > > wrote: > > > > > > > > Memory mapped serial

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Aleksandar Markovic
> > Ahah very easy indeed :) Not noticing it shows how busy I am with > > firmware world than I forgot linux-user can be a simpler/powerful > > way to easily test stuff, as the Hexagon recent port also demonstrated. > > > > > > Hexagon port doesn't have anything to do with this patch

Re: [PATCH v2] linux-user/strace: Add missing signal strings

2019-11-21 Thread Aleksandar Markovic
On Wed, Nov 20, 2019 at 3:57 PM Helge Deller wrote: > > Add the textual representations of some missing target signals. > > Signed-off-by: Helge Deller > > diff --git a/linux-user/strace.c b/linux-user/strace.c > index 3d4d684450..de43238fa4 100644 > --- a/linux-user/strace.c > +++

Re: [PATCH 1/4] block/quorum.c: stable children names

2019-11-21 Thread Lukas Straub
On Thu, 21 Nov 2019 12:04:58 -0600 Eric Blake wrote: > On 11/21/19 11:49 AM, Lukas Straub wrote: > > If we remove the child with the highest index from the quorum, > > decrement s->next_child_index. This way we get stable children > > names as long as we only remove the last child. > > > >

Re: [PATCH v6] Implement backend program convention command for vhost-user-blk

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 2:58 AM, Micky Yun Chan wrote: From: michan FYI your email setup is still incorrect. This patch is to add standard commands defined in docs/interop/vhost-user.rst For vhost-user-* program Signed-off-by: Micky Yun Chan (michiboo) ---

Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device

2019-11-21 Thread Peter Maydell
On Thu, 21 Nov 2019 at 18:15, Marc-André Lureau wrote: > > On Thu, Nov 21, 2019 at 5:47 PM Peter Maydell > wrote: > > > > On Wed, 20 Nov 2019 at 15:27, Marc-André Lureau > > wrote: > > > > > > Memory mapped serial device is in fact a sysbus device. The following > > > patches will make use of

Re: [PULL 0/4] x86 updates for QEMU 4.2-rc

2019-11-21 Thread Peter Maydell
On Thu, 21 Nov 2019 at 15:39, Paolo Bonzini wrote: > > The following changes since commit 39e2821077e6dcf788b7c2a9ef50970ec7995437: > > Update version for v4.2.0-rc2 release (2019-11-19 19:34:10 +) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 6:35 PM, Aleksandar Markovic wrote: On Thursday, November 21, 2019, Philippe Mathieu-Daudé mailto:phi...@redhat.com>> wrote: On 11/21/19 6:00 PM, Aleksandar Markovic wrote: On Thursday, November 21, 2019, Philippe Mathieu-Daudé mailto:phi...@redhat.com>

Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device

2019-11-21 Thread Marc-André Lureau
On Thu, Nov 21, 2019 at 5:47 PM Peter Maydell wrote: > > On Wed, 20 Nov 2019 at 15:27, Marc-André Lureau > wrote: > > > > Memory mapped serial device is in fact a sysbus device. The following > > patches will make use of sysbus facilities for resource and > > registration. In particular,

Re: [PATCH 1/4] block/quorum.c: stable children names

2019-11-21 Thread Eric Blake
On 11/21/19 11:49 AM, Lukas Straub wrote: If we remove the child with the highest index from the quorum, decrement s->next_child_index. This way we get stable children names as long as we only remove the last child. Signed-off-by: Lukas Straub --- block/quorum.c | 6 ++ 1 file changed,

[PATCH 3/4] colo: Introduce high-level test

2019-11-21 Thread Lukas Straub
Add high-level test relying on the colo resource-agent to test all failover cases while checking guest network connectivity Signed-off-by: Lukas Straub --- scripts/colo-resource-agent/crm_master | 44 +++ tests/acceptance/colo.py | 444 + 2 files changed,

[PATCH 1/4] block/quorum.c: stable children names

2019-11-21 Thread Lukas Straub
If we remove the child with the highest index from the quorum, decrement s->next_child_index. This way we get stable children names as long as we only remove the last child. Signed-off-by: Lukas Straub --- block/quorum.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/quorum.c

[PATCH 0/4] colo: Introduce resource agent and high-level test

2019-11-21 Thread Lukas Straub
Hello Everyone, These patches introduce a resource agent for use with the Pacemaker CRM and a high-level test utilizing it for testing qemu COLO. The resource agent manages qemu COLO including continuous replication. Currently the second test case (where the peer qemu is frozen) fails on primary

[PATCH 4/4] MAINTAINERS: Add myself as maintainer for COLO resource agent

2019-11-21 Thread Lukas Straub
While I'm not going to have much time for this, I'll still try to test and review patches. Signed-off-by: Lukas Straub --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d6de200453..aad8356149 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH 2/4] colo: Introduce resource agent

2019-11-21 Thread Lukas Straub
Introduce a resource agent which can be used in a Pacemaker cluster to manage qemu COLO. Signed-off-by: Lukas Straub --- scripts/colo-resource-agent/colo | 1026 ++ 1 file changed, 1026 insertions(+) create mode 100755 scripts/colo-resource-agent/colo diff --git

Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion

2019-11-21 Thread Eric Blake
On 11/19/19 2:49 PM, Fangrui Song wrote: Can we simply drop the offending line statement instead? Fixed in the new patch. The first val * mul above this range is 0x1p64.  Rejecting it is correct, because it overflows yint64_t. I am not subscribed, so apologize that this email may be

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Aleksandar Markovic
On Thursday, November 21, 2019, Philippe Mathieu-Daudé wrote: > On 11/21/19 6:00 PM, Aleksandar Markovic wrote: > >> On Thursday, November 21, 2019, Philippe Mathieu-Daudé > > wrote: >> >> On 11/21/19 9:19 AM, Helge Deller wrote: >> >> On 20.11.19 23:20,

Re: [PATCH v2] linux-user/strace: Add missing signal strings

2019-11-21 Thread Laurent Vivier
Le 20/11/2019 à 15:55, Helge Deller a écrit : > Add the textual representations of some missing target signals. > > Signed-off-by: Helge Deller > > diff --git a/linux-user/strace.c b/linux-user/strace.c > index 3d4d684450..de43238fa4 100644 > --- a/linux-user/strace.c > +++

Re: [PULL 0/3] Fixes 20191121 patches

2019-11-21 Thread Peter Maydell
axel.org/qemu tags/fixes-20191121-pull-request > > for you to fetch changes up to c55c974486b0dadf97fe47e2e789d5dba9b77138: > > ui/gtk: fix gettext message's charset. (2019-11-21 09:42:30 +0100) > >

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 6:00 PM, Aleksandar Markovic wrote: On Thursday, November 21, 2019, Philippe Mathieu-Daudé mailto:phi...@redhat.com>> wrote: On 11/21/19 9:19 AM, Helge Deller wrote: On 20.11.19 23:20, Aleksandar Markovic wrote: On Wed, Nov 20, 2019 at 10:13 PM Aleksandar

Re: [PATCH] kvm: Reallocate dirty_bmap when we change a slot

2019-11-21 Thread Peter Xu
On Thu, Nov 21, 2019 at 04:56:45PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > kvm_set_phys_mem can be called to reallocate a slot by something the > guest does (e.g. writing to PAM and other chipset registers). > This can happen in the middle of a migration,

Re: [PATCH v2] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread Corey Minyard
On Thu, Nov 21, 2019 at 05:23:40PM +0100, Cédric Le Goater wrote: > The BMC of the OpenPOWER systems monitors the machine state using > sensors, controls the power and controls the access to the PNOR flash > device containing the firmware image required to boot the host. > > QEMU models the power

Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion

2019-11-21 Thread Fangrui Song
On 2019-11-21, Markus Armbruster wrote: Richard Henderson writes: On 11/20/19 6:30 PM, Fangrui Song wrote: On 2019-11-20, Juan Quintela wrote: Markus Armbruster wrote: Fangrui Song writes: [...] diff --git a/util/cutils.c b/util/cutils.c index fd591cadf0..2b4484c015 100644 ---

Re: [qemu-web PATCH] Add a blog post about the QEMU-related presentation of KVM Forum 2019

2019-11-21 Thread Thomas Huth
On 21/11/2019 17.04, Paolo Bonzini wrote: > On 21/11/19 14:59, Eric Blake wrote: >> On 11/21/19 5:52 AM, Thomas Huth wrote: >>> There have been quite a lot of QEMU-related talks at KVM Forum this >>> year - let's provide a summary for the people who could not attend. >>> >>> Signed-off-by: Thomas

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Aleksandar Markovic
ū On Thursday, November 21, 2019, Philippe Mathieu-Daudé wrote: > On 11/21/19 9:19 AM, Helge Deller wrote: > >> On 20.11.19 23:20, Aleksandar Markovic wrote: >> >>> On Wed, Nov 20, 2019 at 10:13 PM Aleksandar Markovic >>> wrote: >>> On Wed, Nov 20, 2019 at 3:58 PM Helge Deller

Re: [PATCH 0/5] vfio/spapr: Handle changes of master irq chip for VFIO devices

2019-11-21 Thread Alex Williamson
On Thu, 21 Nov 2019 11:56:02 +1100 David Gibson wrote: > Due to the way feature negotiation works in PAPR (which is a > paravirtualized platform), we can end up changing the global irq chip > at runtime, including it's KVM accelerate model. That causes > complications for VFIO devices with

Re: [PULL 0/4] x86 updates for QEMU 4.2-rc

2019-11-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1574350609-29518-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 0/4] x86 updates for QEMU 4.2-rc Type: series Message-id:

[PATCH] kvm: Reallocate dirty_bmap when we change a slot

2019-11-21 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" kvm_set_phys_mem can be called to reallocate a slot by something the guest does (e.g. writing to PAM and other chipset registers). This can happen in the middle of a migration, and if we're unlucky it can now happen between the split 'sync' and 'clear'; the clear

Re: [PATCH 4/5] spapr: Handle irq backend changes with VFIO PCI devices

2019-11-21 Thread Cédric Le Goater
On 21/11/2019 01:56, David Gibson wrote: > pseries machine type can have one of two different interrupt controllers in > use depending on feature negotiation with the guest. Usually this is > invisible to devices, because they route to a common set of qemu_irqs which > in turn dispatch to the

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 9:19 AM, Helge Deller wrote: On 20.11.19 23:20, Aleksandar Markovic wrote: On Wed, Nov 20, 2019 at 10:13 PM Aleksandar Markovic wrote: On Wed, Nov 20, 2019 at 3:58 PM Helge Deller wrote: Improve strace output of various syscalls which either have none or only int-type

Re: [PATCH 5/5] spapr: Work around spurious warnings from vfio INTx initialization

2019-11-21 Thread Cédric Le Goater
On 21/11/2019 01:56, David Gibson wrote: > Traditional PCI INTx for vfio devices can only perform well if using > an in-kernel irqchip. Therefore, vfio_intx_update() issues a warning > if an in kernel irqchip is not available. > > We usually do have an in-kernel irqchip available for pseries

Re: [PATCH v2] linux-user/strace: Add missing signal strings

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/20/19 3:55 PM, Helge Deller wrote: Add the textual representations of some missing target signals. Signed-off-by: Helge Deller diff --git a/linux-user/strace.c b/linux-user/strace.c index 3d4d684450..de43238fa4 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -146,6 +146,19

[PATCH v2] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread Cédric Le Goater
The BMC of the OpenPOWER systems monitors the machine state using sensors, controls the power and controls the access to the PNOR flash device containing the firmware image required to boot the host. QEMU models the power cycle process, access to the sensors and access to the PNOR device. But,

Re: [Qemu-devel] [PATCH 0/2] hw/timer/m48t59: Convert to trace events

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 4:28 PM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: ping? Did this fall through the cracks? Certainly =) Thanks for noticing. This now need a (trivial) rebase. I'll respin for 5.0. On 6/26/19 2:20 PM, Philippe Mathieu-Daudé wrote: Another trivial cleanup

Re: [PATCH] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread Cédric Le Goater
On 21/11/2019 16:36, Corey Minyard wrote: > On Mon, Nov 18, 2019 at 10:22:22AM +0100, Cédric Le Goater wrote: >> The BMC of the OpenPOWER systems monitors the machine state using >> sensors, controls the power and controls the access to the PNOR flash >> device containing the firmware image

Re: [qemu-web PATCH] Add a blog post about the QEMU-related presentation of KVM Forum 2019

2019-11-21 Thread Paolo Bonzini
On 21/11/19 14:59, Eric Blake wrote: > On 11/21/19 5:52 AM, Thomas Huth wrote: >> There have been quite a lot of QEMU-related talks at KVM Forum this >> year - let's provide a summary for the people who could not attend. >> >> Signed-off-by: Thomas Huth >> --- >>   Note: For some talks it's hard

  1   2   3   >