Re: Can we retire Python 2 now?

2019-12-20 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Python 2 EOL is only a few days away[*]. We made configure bitch about >> it in commit e5abf59eae "Deprecate Python 2 support", 2019-07-01. Any >> objections to retiring it now, i.e. in 5.0? >> >> Cc'ing everyone who appears to be

RE: issue about virtio-blk queue size

2019-12-20 Thread Wangyong
> From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Friday, December 20, 2019 5:53 PM > To: wangyong (Cloud) > Cc: Stefan Hajnoczi ; pbonz...@redhat.com; > mark.ka...@oracle.com; h...@lst.de; qemu-devel@nongnu.org > Subject: Re: issue about virtio-blk queue size > > On Thu, Dec 05, 2019

[PATCH v2 6/8] tests/acceptance: Do not set the machine type manually

2019-12-20 Thread Philippe Mathieu-Daudé
Since commit ba21bde93 we don't need to set the machine type manually, the one set by the ":avocado: tags=machine" will be used. Suggested-by: Cleber Rosa Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/machine_avr6.py | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v2 4/8] hw/avr: Add some Arduino boards

2019-12-20 Thread Philippe Mathieu-Daudé
Arduino boards are build with AVR chipsets. Add some of the popular boards: - Arduino Duemilanove - Arduino Uno - Arduino Mega For more information: https://www.arduino.cc/en/Main/Products https://store.arduino.cc/arduino-genuino/most-popular Signed-off-by: Philippe Mathieu-Daudé --- v2: -

[PATCH v2 5/8] tests/boot-serial-test: Test some Arduino boards (AVR based)

2019-12-20 Thread Philippe Mathieu-Daudé
The Arduino Duemilanove is based on a AVR5 CPU, while the Arduino MEGA2560 on a AVR6 CPU. Signed-off-by: Philippe Mathieu-Daudé --- tests/boot-serial-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c index e556f09db8..582a497963

Re: [PATCH v2 0/8] hw/avr: Introduce the Arduino boards

2019-12-20 Thread Philippe Mathieu-Daudé
On Sat, Dec 21, 2019 at 2:02 AM Philippe Mathieu-Daudé wrote: > > Hi, > > This series add the arduino boards, aiming at removing the > 'sample' board that doesn't follow any specification. > > Since v1: > - Addressed Igor comments > - Addressed Aleksandar comments > - Fixed UART issue (was due to

[PATCH v2 2/8] hw/timer/avr_timer16: Rename memory region debugging name

2019-12-20 Thread Philippe Mathieu-Daudé
This device expose 3 different I/O regions. Name them differently to have a clearer 'info mtree' output. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/avr_timer16.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/timer/avr_timer16.c b/hw/timer/avr_timer16.c

[PATCH v2 0/8] hw/avr: Introduce the Arduino boards

2019-12-20 Thread Philippe Mathieu-Daudé
Hi, This series add the arduino boards, aiming at removing the 'sample' board that doesn't follow any specification. Since v1: - Addressed Igor comments - Addressed Aleksandar comments - Fixed UART issue (was due to IRQ shifted by 2 in CPU) TODO after merge is: - Extract Timer8 common parts

Re: [PATCH v2] mos6522: remove anh register

2019-12-20 Thread David Gibson
On Fri, Dec 20, 2019 at 10:40:54PM +0100, Laurent Vivier wrote: > Register addr 1 is defined as buffer A with handshake (vBufAH), > register addr 15 is also defined as buffer A without handshake (vBufA). > > As both addresses access the same register, remove the definition of > 'anh' and use only

Re: [PATCH 2/2] ppc/pnv: Use the CPU topology to compute the default number of chips

2019-12-20 Thread David Gibson
On Fri, Dec 20, 2019 at 05:51:48PM +0100, Greg Kurz wrote: > Multi TCG mandates the CPU topology to be dimensioned to the actual > number of CPUs, depending on the number of chips the user asked for. > That is, '-machine num-chips=N' should always have a '-smp' companion > with a topology that

[PATCH v2 7/8] tests/acceptance: Keep multilines comment consistent with other tests

2019-12-20 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- Cc: Cleber Rosa tests/acceptance/machine_avr6.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/acceptance/machine_avr6.py b/tests/acceptance/machine_avr6.py index 394b3d4f8f..94a8004e94 100644 ---

[PATCH v2 3/8] hw/avr: Add some ATmega microcontrollers

2019-12-20 Thread Philippe Mathieu-Daudé
Add some microcontrollers from the megaAVR family (ATmega series): - middle range: ATmega168 and ATmega328 - high range: ATmega1280 and ATmega2560 For product comparison: https://www.microchip.com/wwwproducts/ProductCompare/ATmega168P/ATmega328P

[PATCH v2 8/8] tests/acceptance: Test the Arduino MEGA2560 board

2019-12-20 Thread Philippe Mathieu-Daudé
As the path name demonstrates, the FreeRTOS tests target a board based on a ATMega2560 MCU. We have one, the Arduino MEGA2560. Complementary documentation: https://feilipu.me/2012/01/15/ethermega-arduino-mega-2560-and-freertos/ https://feilipu.me/2015/11/24/arduino_freertos/ (see

[PATCH v2 1/8] hw/char/avr: Reduce USART I/O size

2019-12-20 Thread Philippe Mathieu-Daudé
Per the datasheet the USART uses 7 consecutive 8-bit registers. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/avr_usart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/avr_usart.c b/hw/char/avr_usart.c index cb307fe23d..becdb87847 100644 ---

Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation

2019-12-20 Thread Finn Thain
On Fri, 20 Dec 2019, Laurent Vivier wrote: > Le 20/12/2019 ? 12:38, Aleksandar Markovic a ?crit?: > > On Sat, Dec 14, 2019 at 2:29 AM Finn Thain > > wrote: > >> > >> Hi All, > >> > >> There is a bug in the DP8393X emulation that can stop packet reception. > >> > >> Whilst debugging that issue I

Re: [PATCH v39 15/22] target/avr: Add example board configuration

2019-12-20 Thread Philippe Mathieu-Daudé
Hi Michael, Few minor comments below. On 12/18/19 10:03 PM, Michael Rolnik wrote: A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. NOTE: this

Re: [PATCH v2 13/13] dp8393x: Correctly advance RRP

2019-12-20 Thread Finn Thain
Please disregard this patch. An off-by-one bug was found in one of my Linux sonic driver patches. When I fixed that bug, this patch (13/13) was shown to be incorrect. The Linux sonic driver patches are being tested on actual SONIC hardware (Mac Centris 610). I will send v3 of this series

Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-20 Thread Eric Blake
On 12/19/19 10:14 AM, Nir Soffer wrote: 1. Using disk name as a bitmap name is a bad behavior, as they are completely different concepts. Especially keeping in mind that user already knows disk name anyway and no reason to write this export name inside metadata context of this export. The

Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-20 Thread Eric Blake
On 12/19/19 9:08 AM, Nir Soffer wrote: Let's just fix qapi spec now. But qapi documents a better behavior for users. We should fix the code instead to mach the docs. 1. Using disk name as a bitmap name is a bad behavior, as they are completely different concepts. Especially keeping in mind

Re: [PATCH 04/13] hw/timer/allwinner: Move definitions from header to source

2019-12-20 Thread Niek Linnenbank
On Thu, Dec 19, 2019 at 7:51 PM Philippe Mathieu-Daudé wrote: > These definitions are only used in the implementation, thus don't > need to be exported. Move them in the source file. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/timer/allwinner-a10-pit.h | 28

[PATCH v2] mos6522: remove anh register

2019-12-20 Thread Laurent Vivier
Register addr 1 is defined as buffer A with handshake (vBufAH), register addr 15 is also defined as buffer A without handshake (vBufA). As both addresses access the same register, remove the definition of 'anh' and use only 'a' (with VIA_REG_ANH and VIA_REG_A). Fixes: 51f233ec92cd ("misc:

Re: [PATCH 03/13] hw/timer/allwinner: Remove unused definitions

2019-12-20 Thread Niek Linnenbank
On Thu, Dec 19, 2019 at 7:51 PM Philippe Mathieu-Daudé wrote: > Keeping unused definition is rather confusing when reviewing. > Remove them. > Perhaps make it more clear that the definitions are unused IRQ defines? > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH 2/2] iotests: Fix IMGOPTSSYNTAX for nbd

2019-12-20 Thread Eric Blake
On 12/18/19 4:48 AM, Max Reitz wrote: There is no $SOCKDIR, only $SOCK_DIR. Fixes: f3923a72f199b2c63747a7032db74730546f55c6 Signed-off-by: Max Reitz --- tests/qemu-iotests/common.rc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Whoops. Thanks for the fix. Reviewed-by: Eric

Re: [PATCH 02/13] hw/timer/allwinner: Add AW_PIT_TIMER_MAX definition

2019-12-20 Thread Niek Linnenbank
On Thu, Dec 19, 2019 at 7:51 PM Philippe Mathieu-Daudé wrote: > This controller is able to use up to 6 timers. > Later we will reuse part of it to model other similar controllers > but with less timers. To simplify the VMSTATE, we'll keep a max > of 6 timers. Add a definition for that value. > >

Re: [PATCH 00/18] block: Allow exporting BDSs via FUSE

2019-12-20 Thread Eric Blake
On 12/20/19 6:50 AM, Kevin Wolf wrote: Am 20.12.2019 um 11:30 hat Max Reitz geschrieben: I placed it into block/ because that just seemed like the least bad place to me (apart from creating a new top-level directory like nbd has) – and also because we already have quite some few non-driver

Re: [PATCH 01/13] hw/timer/allwinner: Use the AW_A10_PIT_TIMER_NR definition

2019-12-20 Thread Niek Linnenbank
On Thu, Dec 19, 2019 at 7:51 PM Philippe Mathieu-Daudé wrote: > We have a definition for this magic value '6', use it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/timer/allwinner-a10-pit.h | 2 +- > hw/timer/allwinner-a10-pit.c | 2 +- > 2 files changed, 2

[PATCH v5 5/6] hppa: Add emulation of Artist graphics

2019-12-20 Thread Sven Schnelle
This adds emulation of Artist graphics good enough to get a Text console on both Linux and HP-UX. The X11 server from HP-UX also works. Signed-off-by: Sven Schnelle --- hw/display/Kconfig |4 + hw/display/Makefile.objs |1 + hw/display/artist.c | 1450

[PATCH v5 4/6] hppa: add emulation of LASI PS2 controllers

2019-12-20 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/hppa/Kconfig| 1 + hw/hppa/lasi.c | 10 +- hw/input/Kconfig | 3 + hw/input/Makefile.objs | 1 + hw/input/lasips2.c | 289 + hw/input/ps2.c | 5 +

[PATCH v5 2/6] hppa: Add support for LASI chip with i82596 NIC

2019-12-20 Thread Sven Schnelle
From: Helge Deller LASI is a built-in multi-I/O chip which supports serial, parallel, network (Intel i82596 Apricot), sound and other functionalities. LASI has been used in many HP PARISC machines. This patch adds the necessary parts to allow Linux and HP-UX to detect LASI and the network card.

Re: [PATCH 02/18] fuse: Allow exporting BDSs via FUSE

2019-12-20 Thread Eric Blake
On 12/20/19 7:25 AM, Markus Armbruster wrote: I suppose moving a field between a union base and all variants does still result in different introspection even though the accepted inputs are the same. Correct. A common member (whether it's local or from the base) is in

[PATCH v5 1/6] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2019-12-20 Thread Sven Schnelle
From: Helge Deller The tests of the dino chip with the Online-diagnostics CD ("ODE DINOTEST") now succeeds. Additionally add some qemu trace events. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- hw/hppa/dino.c

[PATCH v5 0/6] HPPA: i82596, PS/2 and graphics emulation

2019-12-20 Thread Sven Schnelle
Hi, these series adds quite a lot to the HPPA emulation in QEMU: i82596 emulation from Helge, PS/2 and Artist graphics emulation. See https://parisc.wiki.kernel.org/index.php/Qemu for a few screenshots of QEMU running a X11/CDE session in HP-UX. Changes in v5: - fix a buffer overrun in

Re: [PATCH 02/18] fuse: Allow exporting BDSs via FUSE

2019-12-20 Thread Eric Blake
On 12/19/19 8:38 AM, Max Reitz wrote: fuse-export-add allows mounting block graph nodes via FUSE on some existing regular file. That file should then appears like a raw disk image, and accesses to it result in accesses to the exported BDS. Right now, we only set up the mount point and tear all

[PATCH v5 3/6] ps2: accept 'Set Key Make and Break' commands

2019-12-20 Thread Sven Schnelle
HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and just reply with ACK. Signed-off-by: Sven

Re: [RFC PATCH 11/13] hw/timer/allwinner: Introduce TYPE_AW_COMMON_PIT abstract device

2019-12-20 Thread Niek Linnenbank
Hi Philippe, On Thu, Dec 19, 2019 at 7:51 PM Philippe Mathieu-Daudé wrote: > Extract the common code from the TYPE_AW_A10_PIT device into a new > abstract device: TYPE_AW_COMMON_PIT, then use it as parent, so we > inherit the same functionalities. > > Signed-off-by: Philippe Mathieu-Daudé >

Re: Making QEMU easier for management tools and applications

2019-12-20 Thread Richard W.M. Jones
On Fri, Dec 20, 2019 at 04:13:59PM +, Stefan Hajnoczi wrote: > Hi, > QEMU presents a command-line interface and QMP monitor for > applications to interact with. Applications actually need API > bindings in their programming language. Bindings avoid reimplementing > code to spawn a QEMU

Re: [PATCH] block/rbd: Add support for ceph namespaces

2019-12-20 Thread Eric Blake
On 12/20/19 11:17 AM, Florian Florensa wrote: The patch LGTM, but I'd like to use 'namespace' instead of cryptic 'nspace'. (as BlockdevOptionsNVMe did) What do you think? Yes no worries, I can rename it to 'rbd_namespace' to avoid any possible confusion, is this Ok for you ? We use

Re: [PATCH] block/rbd: Add support for ceph namespaces

2019-12-20 Thread Eric Blake
On 12/19/19 7:34 AM, Florian Florensa wrote: Starting from ceph Nautilus, RBD has support for namespaces, allowing for finer grain ACLs on images inside a pool, and tenant isolation. In the rbd cli tool documentation, the new image-spec and snap-spec are : -

Re: [RFC PATCH 00/13] hw/timer/allwinner: Make it reusable

2019-12-20 Thread Niek Linnenbank
Hi Philippe, On Thu, Dec 19, 2019 at 7:51 PM Philippe Mathieu-Daudé wrote: > Hi, > > Niek added the H3 SoC in [1] and noticed in [2] the timer > controller is very similar (less timers, watchdog register > placed at different address). > > On 12/18/19 9:14 PM, Niek Linnenbank wrote: > >

[RFC PATCH 0/1] target/arm: kvm: Support for KVM DABT without valid ISS

2019-12-20 Thread Beata Michalska
Some of the ARMv7 & ARMv8 load/store instructions might trigger a data abort exception with no valid ISS info to be decoded. The lack of decode info makes it at least tricky to emulate the instruction which is one of the (many) reasons why KVM will not even try to do so. So far, if a guest made

[RFC PATCH 1/1] target/arm: kvm: Handle DABT with no valid ISS

2019-12-20 Thread Beata Michalska
On ARMv7 & ARMv8 some load/store instructions might trigger a data abort exception with no valid ISS info to be decoded. The lack of decode info makes it at least tricky to emulate those instruction which is one of the (many) reasons why KVM will not even try to do so. Add suport for handling

Re: [PULL 2/2] configure: Require Python >= 3.5

2019-12-20 Thread Eduardo Habkost
On Fri, Dec 20, 2019 at 07:59:28PM +0100, Juan Quintela wrote: > Eduardo Habkost wrote: > > Python 3.5 is the oldest Python version available on our > > supported build platforms, and Python 2 end of life will be 3 > > weeks after the planned release date of QEMU 4.2.0. Drop Python > > 2 support

[Bug 1857143] Re: VMs won't boot from external snapshots on qemu 4.2

2019-12-20 Thread Toolybird
This is due to the new way of configuring block devices in 4.2. You'll need to create your snapshots correctly by using the '-F' parameter of qemu-img create. Full details here: https://www.redhat.com/archives/libvirt- users/2019-December/msg00016.html -- You received this bug notification

Re: [PATCH v2 28/28] cputlb: Expand cpu_ldst_template.h in cputlb.c

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > Reduce the amount of preprocessor obfuscation by expanding > the text of each of the functions generated. The result is > only slightly smaller than the original. > > Reviewed-by: Aleksandar Markovic > Signed-off-by: Richard Henderson \o/ Reviewed-by: Alex

Re: [PATCH v2 27/28] cputlb: Remove support for MMU_MODE*_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > All users have now been converted to cpu_*_mmuidx_ra. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/exec/cpu_ldst.h | 230 > 1 file changed, 230 deletions(-) > > diff --git

Re: [PATCH v2 26/28] target/ppc: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > There are only two uses. Within dcbz_common, the local variable > mmu_idx already contains the epid computation, and we can avoid > repeating it for the store. Within helper_icbiep, the usage is > trivially expanded using PPC_TLB_EPID_LOAD. > > Acked-by: David

Re: [PATCH v2 25/28] target/s390x: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The generated functions aside from *_real are unused. > The *_real functions have a couple of users in mem_helper.c; > use *_mmuidx_ra instead, with MMU_REAL_IDX. > > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Henderson FYI there is a merge conflict

Re: [PATCH v2 24/28] target/mips: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The separate suffixed functions were used to construct > some do_##insn function switched on mmu_idx. The interface > is exactly identical to the *_mmuidx_ra functions. Replace > them directly and remove the constructions. > > Cc: Aurelien Jarno > Cc: Aleksandar

Re: [PATCH v2 23/28] target/m68k: Use cpu_*_mmuidx_ra instead of MMU_MODE{0, 1}_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The generated *_user functions are unused. The *_kernel functions > have a couple of users in op_helper.c; use *_mmuidx_ra instead, > with MMU_KERNEL_IDX. > > Reviewed-by: Laurent Vivier > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > v2:

Re: [PATCH v2 22/28] target/xtensa: Remove MMU_MODE{0,1,2,3}_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The functions generated by these macros are unused. > > Acked-by: Max Filippov > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/xtensa/cpu.h | 4 > 1 file changed, 4 deletions(-) > > diff --git a/target/xtensa/cpu.h

[PULL 3/3] numa: properly check if numa is supported

2019-12-20 Thread Eduardo Habkost
From: Igor Mammedov Commit aa57020774b, by mistake used MachineClass::numa_mem_supported to check if NUMA is supported by machine and also as unrelated change set it to true for sbsa-ref board. Luckily change didn't break machines that support NUMA, as the field is set to true for them. But

[PULL 1/3] i386: Resolve CPU models to v1 by default

2019-12-20 Thread Eduardo Habkost
When using `query-cpu-definitions` using `-machine none`, QEMU is resolving all CPU models to their latest versions. The actual CPU model version being used by another machine type (e.g. `pc-q35-4.0`) might be different. In theory, this was OK because the correct CPU model version is returned

[PULL 2/3] numa: remove not needed check

2019-12-20 Thread Eduardo Habkost
From: Igor Mammedov Currently parse_numa_node() is always called from already numa enabled context. Drop unnecessary check if numa is supported. Signed-off-by: Igor Mammedov Message-Id: <1576154936-178362-2-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/core/numa.c

[PULL 0/3] x86 and machine queue, 2019-12-20

2019-12-20 Thread Eduardo Habkost
The following changes since commit aceeaa69d28e6f08a24395d0aa6915b687d0a681: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-12-17' into staging (2019-12-17 15:55:20 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git

Re: [PULL 2/2] configure: Require Python >= 3.5

2019-12-20 Thread Juan Quintela
Eduardo Habkost wrote: > Python 3.5 is the oldest Python version available on our > supported build platforms, and Python 2 end of life will be 3 > weeks after the planned release date of QEMU 4.2.0. Drop Python > 2 support from configure completely, and require Python 3.5 or > newer. > >

Re: Can we retire Python 2 now?

2019-12-20 Thread Juan Quintela
Markus Armbruster wrote: > Python 2 EOL is only a few days away[*]. We made configure bitch about > it in commit e5abf59eae "Deprecate Python 2 support", 2019-07-01. Any > objections to retiring it now, i.e. in 5.0? > > Cc'ing everyone who appears to be maintaining something that looks like > a

Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > With the tracing hooks, the inline functions are no longer > so simple. Once out-of-line, the current tlb_entry lookup > is redundant with the one in the main load/store_helper. > > This also begins the introduction of a new target facing > interface, with suffix

Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line

2019-12-20 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> With the tracing hooks, the inline functions are no longer >> so simple. Once out-of-line, the current tlb_entry lookup >> is redundant with the one in the main load/store_helper. >> >> This also begins the introduction of a new target

Re: [PULL 00/24] virtio, pci, pc: fixes, features

2019-12-20 Thread Peter Maydell
On Thu, 19 Dec 2019 at 13:27, Michael S. Tsirkin wrote: > > The following changes since commit b0ca999a43a22b38158a33d3f5881648bb4f: > > Update version for v4.2.0 release (2019-12-12 16:45:57 +) > > are available in the Git repository at: > >

Re: [PATCH v2 21/28] target/unicore32: Remove MMU_MODE{0,1}_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The functions generated by these macros are unused. > > Cc: Guan Xuetao > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/unicore32/cpu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target/unicore32/cpu.h

Re: [PATCH v2 20/28] target/sh4: Remove MMU_MODE{0,1}_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The functions generated by these macros are unused. > > Cc: Aurelien Jarno > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/sh4/cpu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h >

Re: [PATCH v2 19/28] target/microblaze: Remove MMU_MODE{0, 1, 2}_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The functions generated by these macros are unused. > > Cc: Edgar E. Iglesias > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/microblaze/cpu.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/target/microblaze/cpu.h

Re: [PATCH v2 16/28] target/alpha: Remove MMU_MODE{0,1}_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The functions generated by these macros are unused. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/alpha/cpu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target/alpha/cpu.h b/target/alpha/cpu.h > index

Re: [PATCH v2 18/28] target/i386: Remove MMU_MODE{0,1,2}_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The functions generated by these macros are unused. > > Cc: Eduardo Habkost > Acked-by: Paolo Bonzini > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/i386/cpu.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git

Re: [PATCH v2 17/28] target/cris: Remove MMU_MODE{0,1}_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The functions generated by these macros are unused. > > Cc: Edgar E. Iglesias > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/cris/cpu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target/cris/cpu.h b/target/cris/cpu.h

Re: [PATCH v2 15/28] target/nios2: Remove MMU_MODE{0,1}_SUFFIX

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The functions generated by these macros are unused. > > Cc: Chris Wulff > Cc: Marek Vasut > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/nios2/cpu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target/nios2/cpu.h

Re: [PATCH v2 14/28] cputlb: Expand cpu_ldst_useronly_template.h in user-exec.c

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > With the tracing hooks, the inline functions are no longer > so simple. Reduce the amount of preprocessor obfuscation > by expanding the text of each of the functions generated. > The result is only slightly larger than the original. > > Signed-off-by: Richard

Re: [PATCH v2 13/28] linux-user: Include trace-root.h in syscall-trace.h

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > Code movement in an upcoming patch will show that this file > was implicitly depending on trace-root.h being included beforehand. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/user/syscall-trace.h | 2 ++ > 1 file changed, 2

Re: [PULL 0/6] more s390x patches

2019-12-20 Thread Peter Maydell
On Thu, 19 Dec 2019 at 11:01, Cornelia Huck wrote: > > The following changes since commit aceeaa69d28e6f08a24395d0aa6915b687d0a681: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-12-17' into staging (2019-12-17 > 15:55:20 +) > > are available in the Git

Re: [PATCH v2 12/28] linux-user: Include tcg.h in syscall.c

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > Code movement in an upcoming patch will show that this file > was implicitly depending on tcg.h being included indirectly. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > linux-user/syscall.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH v2 10/28] target/arm: Include tcg.h in sve_helper.c

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > Code movement in an upcoming patch will show that this file > was implicitly depending on tcg.h being included indirectly. > > Cc: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/sve_helper.c | 1 + > 1 file

Re: [PATCH v2 09/28] target/s390x: Include tcg.h in mem_helper.c

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > Code movement in an upcoming patch will show that this file > was implicitly depending on tcg.h being included indirectly. > > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/s390x/mem_helper.c | 1 + >

Re: [PATCH v2 08/28] target/i386: Use cpu_*_mmuidx_ra instead of templates

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > Do not use exec/cpu_ldst_{,useronly_}template.h directly, > but instead use the functional interface. > > Cc: Eduardo Habkost > Acked-by: Paolo Bonzini > Signed-off-by: Richard Henderson > --- > target/i386/seg_helper.c | 56

Re: [PATCH v2 07/28] cputlb: Provide cpu_(ld, st}*_mmuidx_ra for user-only

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > This finishes the new interface began with the previous patch. > Document the interface and deprecate MMU_MODE_SUFFIX. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/exec/cpu_ldst.h | 80 +- >

[Bug 1856834] Re: Virtio broken in qemu ppc in 4.2.0 and other versions

2019-12-20 Thread ecsdn
fyi from what I recall guest kernel was built using mpc85xx_defconfig with some additions like virtio etc. If virtio is working for you just fine using same command as mine, then perhaps its some peculiarity to do with my specific guest kernel or kernel version? (uImage is about 3.4M with

Re: [PATCH v2 06/28] cputlb: Rename helper_ret_ld*_cmmu to cpu_ld*_code

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > There are no uses of the *_cmmu names other than the bare wrapping > within the *_code inlines. Therefore rename the functions so we > can drop the inlines. > > Use abi_ptr instead of target_ulong in preparation for user-only; > the two types are identical for

[PATCH v2] target/m68k: only change valid bits in CACR

2019-12-20 Thread Laurent Vivier
This is used by netBSD (and MacOS ROM) to detect the MMU type Signed-off-by: Laurent Vivier --- Notes: v2: change accordingly to Thomas' comments - Replace MMU feature id by a CPU feature id - fix 68030 mask - add 68060 mask - only mask in m68k_movec_to() function

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu - status update

2019-12-20 Thread John G Johnson
> On Dec 19, 2019, at 5:36 AM, Stefan Hajnoczi wrote: > > On Wed, Dec 18, 2019 at 01:00:55AM +0100, Paolo Bonzini wrote: >> On 17/12/19 23:57, Felipe Franciosi wrote: >>> Doing it in userspace was the flow we proposed back in last year's KVM >>> Forum (Edinburgh), but it got turned down. >>

Re: [PATCH] block/rbd: Add support for ceph namespaces

2019-12-20 Thread Florian Florensa
On Fri, Dec 20, 2019 at 09:56:51AM -0500, Jason Dillaman wrote: > On Fri, Dec 20, 2019 at 9:11 AM Florian Florensa wrote: > > > > Hello Stefano and Jason, > > > > First of all thanks for the quick reply, > > Response inline belowe > > > Hi Florian, > > > > > > I think we need to add (Since: 5.0).

Re: [PATCH v2 05/28] translator: Use cpu_ld*_code instead of open-coding

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > The DO_LOAD macros replicate the distinction already performed > by the cpu_ldst.h functions. Use them. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/exec/cpu_ldst.h | 11 - > include/exec/translator.h | 48

[Bug 1856834] Re: Virtio broken in qemu ppc in 4.2.0 and other versions

2019-12-20 Thread ecsdn
Thanks I tried with: /root/QEMU/qemu-git-4.2.0rc4/qemu/build/ppc-softmmu/qemu-system-ppc -M mpc8544ds -nographic -kernel /home/me/boot/uImage-2.6.32 -append "root=/dev/vda rw" -device virtio-blk-pci,drive=drive0,disable- modern=true -drive file=/home/me/mmcblk0p2.dd,if=none,id=drive0,format=raw

Re: [PATCH v2 04/28] cputlb: Move body of cpu_ldst_template.h out of line

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > With the tracing hooks, the inline functions are no longer > so simple. Once out-of-line, the current tlb_entry lookup > is redundant with the one in the main load/store_helper. > > This also begins the introduction of a new target facing > interface, with suffix

Re: [PATCH v4 5/6] hppa: Add emulation of Artist graphics

2019-12-20 Thread Sven Schnelle
Hi, On Fri, Dec 20, 2019 at 05:36:36PM +0100, Helge Deller wrote: > On 20.12.19 08:26, Helge Deller wrote: > > On 19.12.19 01:28, Richard Henderson wrote: > >> On 11/3/19 10:56 AM, Sven Schnelle wrote: > >>> This adds emulation of Artist graphics good enough > >>> to get a Text console on both

Re: [PATCH for-5.0 v11 05/20] virtio-iommu: Endpoint and domains structs and helpers

2019-12-20 Thread Jean-Philippe Brucker
On Thu, Dec 19, 2019 at 07:31:08PM +0100, Auger Eric wrote: > Hi Jean, > > On 12/10/19 5:37 PM, Jean-Philippe Brucker wrote: > > On Fri, Nov 22, 2019 at 07:29:28PM +0100, Eric Auger wrote: > >> +typedef struct viommu_domain { > >> +uint32_t id; > >> +GTree *mappings; > >> +

Re: [PULL 0/2] Require Python >= 3.5 to build QEMU

2019-12-20 Thread Philippe Mathieu-Daudé
On 12/20/19 5:51 PM, Eduardo Habkost wrote: Differences from the previous Python 3.5 pull request that was rejected: * Now tests/vm/netbsd was fixed * .travis.yml is being updated to replace Python 3.4 job with 3.5 The following changes since commit f59b31e6d0c69792b5d817c5aa0a6ed64fba42e0:

[PULL 2/2] configure: Require Python >= 3.5

2019-12-20 Thread Eduardo Habkost
Python 3.5 is the oldest Python version available on our supported build platforms, and Python 2 end of life will be 3 weeks after the planned release date of QEMU 4.2.0. Drop Python 2 support from configure completely, and require Python 3.5 or newer. Signed-off-by: Eduardo Habkost Message-Id:

Re: Can we retire Python 2 now?

2019-12-20 Thread Eduardo Habkost
On Fri, Dec 20, 2019 at 05:29:30PM +0100, Markus Armbruster wrote: > Python 2 EOL is only a few days away[*]. We made configure bitch about > it in commit e5abf59eae "Deprecate Python 2 support", 2019-07-01. Any > objections to retiring it now, i.e. in 5.0? Thanks for the reminder! I'll be

[PULL 1/2] travis: Replace Python 3.4 build with 3.5

2019-12-20 Thread Eduardo Habkost
We'll start requiring Python 3.5 to build QEMU. Signed-off-by: Eduardo Habkost --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 376b7d6dfa..638fba4799 100644 --- a/.travis.yml +++ b/.travis.yml @@ -247,7 +247,7 @@ matrix:

[PATCH 2/2] ppc/pnv: Use the CPU topology to compute the default number of chips

2019-12-20 Thread Greg Kurz
Multi TCG mandates the CPU topology to be dimensioned to the actual number of CPUs, depending on the number of chips the user asked for. That is, '-machine num-chips=N' should always have a '-smp' companion with a topology that meats the resulting number of CPUs, typically '-smp sockets=N'.

[PATCH 0/2] ppc/pnv: Improve command line experience with multi-chip

2019-12-20 Thread Greg Kurz
Patch 1 adds a sanity check of the CPU topology to avoid an assertion in the multi TCG code that can be easily triggered with the "num-chips" property of the powernv machine. This still leaves us with the fact that the number of chips must be specified twice on the command line: once for the

[PULL 0/2] Require Python >= 3.5 to build QEMU

2019-12-20 Thread Eduardo Habkost
Differences from the previous Python 3.5 pull request that was rejected: * Now tests/vm/netbsd was fixed * .travis.yml is being updated to replace Python 3.4 job with 3.5 The following changes since commit f59b31e6d0c69792b5d817c5aa0a6ed64fba42e0: Merge remote-tracking branch

[PATCH 1/2] ppc/pnv: Exit gracefully if CPU topology doesn't match the machine capacities

2019-12-20 Thread Greg Kurz
QEMU crashes when started with: -machine powernv,num-chips=2 -smp cores=2 -accel tcg,thread=multi ERROR: tcg/tcg.c:789:tcg_register_thread: assertion failed: (n < ms->smp.max_cpus) Aborted (core dumped) This happens because the powernv machine creates num-chips * smp.cores CPUs, which might

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-12-20 Thread Peter Xu
On Fri, Dec 20, 2019 at 05:26:42PM +0100, Jean-Philippe Brucker wrote: > There is at the virtio transport level: the driver sets status to > FEATURES_OK once it accepted the feature bits, and to DRIVER_OK once its > fully operational. The virtio-iommu spec says: > > If the driver does not

Re: [PATCH v5 37/37] qdev/qom: remove some TODO limitations now that PROP_PTR is gone

2019-12-20 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > hw/core/qdev.c | 8 > qom/qom-qmp-cmds.c | 10 -- > 2 files changed, 18 deletions(-) > > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > index 98e786c50f..9feb81cff2 100644 > --- a/hw/core/qdev.c > +++

Re: [PATCH v2 03/28] trace: Remove trace_mem_build_info_no_se_[bl]e

2019-12-20 Thread Alex Bennée
Richard Henderson writes: > It is easy for the atomic helpers to use trace_mem_build_info > directly, without resorting to symbol pasting. For this usage, > we cannot use trace_mem_get_info, because the MemOp does not > support 16-byte accesses. > > Signed-off-by: Richard Henderson > --- >

Re: [PULL 00/25] testing and logging updates

2019-12-20 Thread Peter Maydell
On Thu, 19 Dec 2019 at 10:49, Alex Bennée wrote: > > The following changes since commit aceeaa69d28e6f08a24395d0aa6915b687d0a681: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-12-17' into staging (2019-12-17 > 15:55:20 +) > > are available in the Git

Re: [PATCH v4 5/6] hppa: Add emulation of Artist graphics

2019-12-20 Thread Helge Deller
On 20.12.19 08:26, Helge Deller wrote: > On 19.12.19 01:28, Richard Henderson wrote: >> On 11/3/19 10:56 AM, Sven Schnelle wrote: >>> This adds emulation of Artist graphics good enough >>> to get a Text console on both Linux and HP-UX. The >>> X11 server from HP-UX also works. >>> >>>

Can we retire Python 2 now?

2019-12-20 Thread Markus Armbruster
Python 2 EOL is only a few days away[*]. We made configure bitch about it in commit e5abf59eae "Deprecate Python 2 support", 2019-07-01. Any objections to retiring it now, i.e. in 5.0? Cc'ing everyone who appears to be maintaining something that looks like a Python script. [*]

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2019-12-20 Thread Jean-Philippe Brucker
On Thu, Dec 19, 2019 at 04:09:47PM +0100, Auger Eric wrote: > >> @@ -412,19 +412,80 @@ static IOMMUTLBEntry > >> virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr, > >> int iommu_idx) > >> { > >> IOMMUDevice *sdev =

Making QEMU easier for management tools and applications

2019-12-20 Thread Stefan Hajnoczi
Hi, QEMU presents a command-line interface and QMP monitor for applications to interact with. Applications actually need API bindings in their programming language. Bindings avoid reimplementing code to spawn a QEMU process and interact with QMP. QEMU is kind of lazy and de facto relies on

  1   2   3   4   >