Re: Semihosting, arm, riscv, ppc and common code

2020-01-15 Thread Liviu Ionescu
> On 16 Jan 2020, at 04:04, Benjamin Herrenschmidt > wrote: > > ... I agree, which is also why I want to use the same interface for > powerpc, it will simply make life easier for everybody. I don't know the current implementation in QEMU, but I suggest you also take a look at the current

Re: [PATCH v5 18/22] tests/tcg/aarch64: add a gdbstub testcase for SVE registers

2020-01-15 Thread Alex Bennée
Richard Henderson writes: > On 1/14/20 5:09 AM, Alex Bennée wrote: >> A very simple test case which sets and reads SVE registers while >> running a test case. We don't really need to compile a SVE binary for >> this case but we will later so keep it simple for now. >> >> Signed-off-by: Alex

Re: [PATCH 071/104] virtiofsd: extract root inode init into setup_root()

2020-01-15 Thread Misono Tomohiro
> From: Miklos Szeredi > > Inititialize the root inode in a single place. > > Signed-off-by: Miklos Szeredi > Signed-off-by: Stefan Hajnoczi > --- > tools/virtiofsd/passthrough_ll.c | 26 -- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 070/104] virtiofsd: fail when parent inode isn't known in lo_do_lookup()

2020-01-15 Thread Misono Tomohiro
Looks good to me. Reviewed-by: Misono Tomohiro > --- > tools/virtiofsd/passthrough_ll.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/tools/virtiofsd/passthrough_ll.c > b/tools/virtiofsd/passthrough_ll.c > index 1618db5a92..ef8b88e3d1 100644 > ---

[Bug 1859916] Re: coreaudio not working on MacOS

2020-01-15 Thread JS
** Description changed: OS: MacOS Catalina 10.15.2 qemu-system-x86_64 -version QEMU emulator version 4.2.50 (v4.2.0-13-g084a398bf8-dirty) Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers Qemu install via brew: brew install qemu --- I use following

Re: [PATCH v2] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS

2020-01-15 Thread David Gibson
On Tue, Jan 14, 2020 at 12:46:17PM +0100, Thomas Huth wrote: > It's been deprecated since QEMU v3.1. The 40p machine should be > used nowadays instead. > > Reviewed-by: Philippe Mathieu-Daudé > Acked-by: Hervé Poussineau > Signed-off-by: Thomas Huth Applied to ppc-for-5.0, thanks. > --- >

[Bug 1859920] [NEW] daemoniz not working on MacOS

2020-01-15 Thread JS
Public bug reported: OS: MacOS Catalina 10.15.2 Qemu install via brew: brew install qemu qemu-system-x86_64 -version QEMU emulator version 4.2.50 (v4.2.0-13-g084a398bf8-dirty) Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers --- Start Ubuntu Desktop 18.04 client as

[Bug 1859916] [NEW] coreaudio not working on MacOS

2020-01-15 Thread JS
Public bug reported: OS: MacOS Catalina 10.15.2 qemu-system-x86_64 -version QEMU emulator version 4.2.50 (v4.2.0-13-g084a398bf8-dirty) Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers Qemu install via brew: brew install qemu --- I use following to install Ubuntu 18.04

Re: Semihosting, arm, riscv, ppc and common code

2020-01-15 Thread Benjamin Herrenschmidt
On Wed, 2020-01-15 at 12:01 +, Alex Bennée wrote: > > > There seem to be some linux-user stuff in there, I'm mostly considering > > whatever ARM does today but we can certainly extend later. > > Depends on if it is to be used. AFAIK the main users of arm linux user > are compiler test cases

Re: [PATCH v3 4/7] dt-bindings: gpio: Add gpio-repeater bindings

2020-01-15 Thread Harish Jenny K N
Hi Linus, On 07/01/20 2:52 PM, Harish Jenny K N wrote: > On 06/01/20 1:42 PM, Geert Uytterhoeven wrote: >> Hi Rob, >> >> On Fri, Dec 6, 2019 at 4:04 PM Rob Herring wrote: >>> On Fri, Dec 6, 2019 at 3:17 AM Geert Uytterhoeven >>> wrote: On Thu, Dec 5, 2019 at 10:06 PM Rob Herring wrote:

Re: [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer machine types

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:37PM +0100, Igor Mammedov wrote: > Deprecation period is ran out and it's a time to flip the switch > introduced by cd5ff8333a. > Disable legacy option for new machine types and amend documentation. > > Signed-off-by: Igor Mammedov ppc parts Acked-by: David Gibson

Re: [PATCH v2 71/86] ppc:virtex_ml507: use memdev for RAM

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:26PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: [PATCH v2 71/86] ppc:virtex_ml507: use memdev for RAM

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:26PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: [PATCH 053/104] virtiofsd: Drop CAP_FSETID if client asked for it

2020-01-15 Thread Misono Tomohiro
> From: Vivek Goyal > > If client requested killing setuid/setgid bits on file being written, drop > CAP_FSETID capability so that setuid/setgid bits are cleared upon write > automatically. > > pjdfstest chown/12.t needs this. > > Signed-off-by: Vivek Goyal > dgilbert: reworked for

Re: [PATCH v2 68/86] ppc:prep: use memdev for RAM

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:23PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: [PATCH v2 69/86] ppc:spapr: use memdev for RAM

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:24PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: [PATCH v2 66/86] ppc/{ppc440_bamboo, sam460x}: drop RAM size fixup

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:21PM +0100, Igor Mammedov wrote: > If user provided non-sense RAM size, board will complain and > continue running with max RAM size supported or sometimes > crash like this: > %QEMU -M bamboo -m 1 > exec.c:1926: find_ram_offset: Assertion `size != 0' failed. >

Re: [PATCH v2 65/86] ppc:ppc405_boards: use memdev for RAM

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:20PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: [PATCH v2 64/86] ppc:ppc405_boards: add RAM size checks

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:19PM +0100, Igor Mammedov wrote: > If user provided non-sense RAM size, board will ignore it > and continue running with fixed RAM size. > > Also RAM is going to be allocated by generic code, so it > won't be possible for board to fix CLI. > > Make it error message

Re: [RFC PATCH 3/3] Introduce Configurable Number of Memory Slots Exposed by vhost-user:

2020-01-15 Thread Raphael Norwitz
On Tue, Jan 14, 2020 at 02:12:46AM -0500, Michael S. Tsirkin wrote: > > On Mon, Dec 09, 2019 at 02:00:47AM -0500, Raphael Norwitz wrote: > > The current vhost-user implementation in Qemu imposes a limit on the > > maximum number of memory slots exposed to a VM using a vhost-user > > device. This

Re: [RFC PATCH 1/3] Fixed Error Handling in vhost_user_set_mem_table_postcopy

2020-01-15 Thread Raphael Norwitz
Makes sense - will fix On Tue, Jan 14, 2020 at 02:07:03AM -0500, Michael S. Tsirkin wrote: > > On Mon, Dec 09, 2019 at 02:00:45AM -0500, Raphael Norwitz wrote: > > The current vhost_user_set_mem_table_postcopy() implementation > > populates each region of the VHOST_USER_SET_MEM_TABLE > > message

[PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl

2020-01-15 Thread Aleksandar Markovic
On Wednesday, January 15, 2020, Laurent Vivier wrote: > Le 15/01/2020 à 20:17, Filip Bozuta a écrit : > > > > On 15.1.20. 17:37, Arnd Bergmann wrote: > >> On Wed, Jan 15, 2020 at 5:32 PM Laurent Vivier > wrote: > >>> Le 15/01/2020 à 17:18, Arnd Bergmann a écrit : > On Wed, Jan 15, 2020 at

Re: [PATCH v7 03/11] hw/core: create Resettable QOM interface

2020-01-15 Thread Philippe Mathieu-Daudé
On 1/16/20 2:59 AM, Philippe Mathieu-Daudé wrote: On 1/15/20 1:36 PM, Damien Hedde wrote: This commit defines an interface allowing multi-phase reset. This aims to solve a problem of the actual single-phase reset (built in DeviceClass and BusClass): reset behavior is dependent on the order in

Re: Semihosting, arm, riscv, ppc and common code

2020-01-15 Thread Benjamin Herrenschmidt
On Thu, 2020-01-16 at 00:02 +0200, Liviu Ionescu wrote: > > ... they did have the opportunity to do better, and did not. > > I don't know why you present Arm semihosting as a disaster. It is not > perfect, but it is functional, and common unit tests use only a small > subset of the calls. > >

Re: [PATCH v2 63/86] ppc:pnv: use memdev for RAM

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:18PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: [PATCH v7 02/11] hw/core/qdev: add trace events to help with resettable transition

2020-01-15 Thread Philippe Mathieu-Daudé
On 1/15/20 1:36 PM, Damien Hedde wrote: Adds trace events to reset procedure and when updating the parent bus of a device. Signed-off-by: Damien Hedde Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck Tested-by: Philippe Mathieu-Daudé ---

Re: [PATCH v7 04/11] hw/core: add Resettable support to BusClass and DeviceClass

2020-01-15 Thread Philippe Mathieu-Daudé
On 1/15/20 1:36 PM, Damien Hedde wrote: This commit adds support of Resettable interface to buses and devices: + ResettableState structure is added in the Bus/Device state + Resettable methods are implemented. + device/bus_is_in_reset function defined This commit allows to transition the

Re: [PATCH v7 06/11] hw/core/qdev: handle parent bus change regarding resettable

2020-01-15 Thread Philippe Mathieu-Daudé
On 1/15/20 1:36 PM, Damien Hedde wrote: In qdev_set_parent_bus(), when changing the parent bus of a realized device, if the source and destination buses are not in the same reset state, some adaptations are required. This patch adds needed call to resettable_change_parent() to make sure a device

Re: [PATCH v2 62/86] ppc:mac_oldworld: use memdev for RAM

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:17PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: Semihosting, arm, riscv, ppc and common code

2020-01-15 Thread Benjamin Herrenschmidt
On Wed, 2020-01-15 at 13:32 +, Peter Maydell wrote: > On Wed, 15 Jan 2020 at 01:17, Benjamin Herrenschmidt > wrote: > > On Tue, 2020-01-14 at 09:59 +, Peter Maydell wrote: > > > Note that semihosting is not a "here's a handy QEMU feature" > > > thing. It's an architecture-specific API and

Re: [PATCH v2 61/86] ppc:mac_newworld: use memdev for RAM

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:16PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: [PATCH v2 60/86] ppc:e500: use memdev for RAM

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:15PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: [PATCH v7 03/11] hw/core: create Resettable QOM interface

2020-01-15 Thread Philippe Mathieu-Daudé
On 1/15/20 1:36 PM, Damien Hedde wrote: This commit defines an interface allowing multi-phase reset. This aims to solve a problem of the actual single-phase reset (built in DeviceClass and BusClass): reset behavior is dependent on the order in which reset handlers are called. In particular doing

Re: [PATCH v2 07/86] arm:aspeed: convert valid RAM sizes to data

2020-01-15 Thread Joel Stanley
On Wed, 15 Jan 2020 at 15:10, Igor Mammedov wrote: > > various foo_rambits() hardcode mapping of RAM sizes to RAM feature bits, > which is hard to reuse and repeats over and over. > > Convert maps into GLib's hash tables and perform mapping using > common mapping function. Thanks for the patch.

[PULL v2 00/34] tcg patch queue

2020-01-15 Thread Richard Henderson
3a63b24a1bbf166e6f455fe43a6bbd8dea413d92: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20200114-pull-request' into staging (2020-01-14 16:00:31 +) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-tcg-20200115 for you to fetch changes up

RE: [PATCH RFC 00/12] *** mulitple RDMA channels for migration ***

2020-01-15 Thread fengzhimin
Thanks for your review. I will add more trace_ calls in the next version(V2) and modify its according to your suggestions. -Original Message- From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] Sent: Thursday, January 16, 2020 3:57 AM To: fengzhimin Cc: quint...@redhat.com;

Re: [PATCH v2 59/86] ppc:e500: drop RAM size fixup

2020-01-15 Thread David Gibson
On Wed, Jan 15, 2020 at 04:07:14PM +0100, Igor Mammedov wrote: > If user provided non-sense RAM size, board will complain and > continue running with max RAM size supported. > Also RAM is going to be allocated by generic code, so it won't be > possible for board to fix things up for user. > >

[PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later

2020-01-15 Thread Philippe Mathieu-Daudé
The GdkMonitor was introduced in GTK+ 3.22: https://developer.gnome.org/gdk3/stable/api-index-3-22.html#api-index-3.22 If we build with older GTK+, the build fails: CC ui/gtk.o qemu/ui/gtk.c: In function ‘gd_vc_gfx_init’: qemu/ui/gtk.c:1973:5: error: unknown type name ‘GdkMonitor’

RE: [PATCH 084/104] Virtiofsd: fix memory leak on fuse queueinfo

2020-01-15 Thread misono.tomoh...@fujitsu.com
> * Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > > From: Liu Bo > > > > > > For fuse's queueinfo, both queueinfo array and queueinfos are > > > allocated in > > > fv_queue_set_started() but not cleaned up when the daemon process quits. > > > > > > This fixes the leak in proper

Re: [PATCH v2 35/86] arm:xilinx_zynq: use memdev for RAM

2020-01-15 Thread Alistair Francis
On Thu, Jan 16, 2020 at 1:29 AM Igor Mammedov wrote: > > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: [PATCH v2 37/86] arm:xlnx-zcu102: use memdev for RAM

2020-01-15 Thread Alistair Francis
On Thu, Jan 16, 2020 at 1:39 AM Igor Mammedov wrote: > > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: [PATCH v7 10/11] vl: replace deprecated qbus_reset_all registration

2020-01-15 Thread Philippe Mathieu-Daudé
On 1/15/20 1:36 PM, Damien Hedde wrote: Replace deprecated qbus_reset_all by resettable_cold_reset_fn for the sysbus reset registration. Apart for the raspi machines, this does not impact the behavior because: + at this point resettable just calls the old reset methods of devices and buses

Re: [PATCH 085/104] virtiofsd: Support remote posix locks

2020-01-15 Thread Masayoshi Mizuma
On Thu, Dec 12, 2019 at 04:38:45PM +, Dr. David Alan Gilbert (git) wrote: > From: Vivek Goyal > > Doing posix locks with-in guest kernel are not sufficient if a file/dir > is being shared by multiple guests. So we need the notion of daemon doing > the locks which are visible to rest of the

Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

2020-01-15 Thread Richard Henderson
On 1/15/20 7:09 AM, Igor Mammedov wrote: > On Wed, 15 Jan 2020 08:43:33 -0800 (PST) > no-re...@patchew.org wrote: > >> Patchew URL: >> https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imamm...@redhat.com/ >> >> >> >> Hi, >> >> This series seems to have some coding style problems. See

Re: [PATCH v5 21/22] gdbstub: change GDBState.last_packet to GByteArray

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > From: Damien Hedde > > Remove the packet size upper limit by using a GByteArray > instead of a statically allocated array for last_packet. > Thus we can now send big packets. > > Also remove the last_packet_len field and use last_packet->len > instead. >

Re: [PATCH v5 22/22] gdbstub: do not split gdb_monitor_write payload

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > From: Damien Hedde > > Since we can now send packets of arbitrary length: > simplify gdb_monitor_write() and send the whole payload > in one packet. > > Suggested-by: Luc Michel > Signed-off-by: Damien Hedde > Signed-off-by: Alex Bennée > Message-Id:

Re: [PATCH v5 20/22] tests/tcg/aarch64: add test-sve-ioctl guest-debug test

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > This test exercises the gdbstub while runing the sve-iotcl test. I > haven't plubmed it into make system as we need a way of verifying if > gdb has the right support for SVE. > > Signed-off-by: Alex Bennée > > --- > v4 > - interrogate ZCR_EL1 directly

Re: [PATCH v3 1/3] target/riscv: Fix tb->flags FS status

2020-01-15 Thread Alistair Francis
On Thu, Jan 16, 2020 at 7:46 AM Richard Henderson wrote: > > On 1/14/20 8:28 PM, Alistair Francis wrote: > > On Wed, Jan 15, 2020 at 4:18 PM wrote: > >> > >> It was found that running libquantum on riscv-linux qemu produced an > >> incorrect result. After investigation, FP registers are not

Re: [PATCH 101/104] virtiofsd: prevent FUSE_INIT/FUSE_DESTROY races

2020-01-15 Thread Masayoshi Mizuma
On Thu, Dec 12, 2019 at 04:39:01PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > When running with multiple threads it can be tricky to handle > FUSE_INIT/FUSE_DESTROY in parallel with other request types or in > parallel with themselves. Serialize FUSE_INIT and

Re: [PATCH v5 17/22] tests/guest-debug: add a simple test runner

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > +if "system" in args.qemu: > +cmd = "%s %s %s -s -S" % (args.qemu, args.qargs, args.binary) > +else: > +cmd = "%s %s -g 1234 %s" % (args.qemu, args.qargs, args.binary) Oh, hard-coding of the port is going to cause failures.

Re: [PATCH v5 18/22] tests/tcg/aarch64: add a gdbstub testcase for SVE registers

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > A very simple test case which sets and reads SVE registers while > running a test case. We don't really need to compile a SVE binary for > this case but we will later so keep it simple for now. > > Signed-off-by: Alex Bennée > > --- > v5 > - properly

Re: [PATCH v5 19/22] tests/tcg/aarch64: add SVE iotcl test

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > +int main(int argc, char **argv) > +{ > +unsigned int sve_feature = (get_cpu_reg(ID_AA64PFR0_EL1) >> 32) & 0xf; > +/* Exit early if we don't support SVE at all */ > +if (sve_feature == 0x1) { > +/* we also need to probe for the ioctl

[PATCH 2/2] virtio-balloon: Reject qmp_balloon during hot-unplug

2020-01-15 Thread Julia Suvorova
Hot-unplug takes some time due to communication with the guest. Do not change the device while freeing up resources. Signed-off-by: Julia Suvorova --- balloon.c | 2 +- hw/virtio/virtio-balloon.c | 9 - include/sysemu/balloon.h | 2 +- 3 files changed, 10

[PATCH 0/2] virtio-balloon: Reject qmp_balloon during hot-unplug

2020-01-15 Thread Julia Suvorova
Julia Suvorova (2): qdev: Introduce qdev_get_bus_device virtio-balloon: Reject qmp_balloon during hot-unplug balloon.c | 2 +- hw/core/qdev.c | 5 + hw/pci-bridge/pci_expander_bridge.c | 4 +++- hw/scsi/scsi-bus.c | 4

[PATCH 1/2] qdev: Introduce qdev_get_bus_device

2020-01-15 Thread Julia Suvorova
For bus devices, it is useful to be able to handle the parent device. Signed-off-by: Julia Suvorova --- hw/core/qdev.c | 5 + hw/pci-bridge/pci_expander_bridge.c | 4 +++- hw/scsi/scsi-bus.c | 4 +++- hw/usb/bus.c| 4 +++-

Re: [PATCH v5 17/22] tests/guest-debug: add a simple test runner

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > +gdb_cmd = "%s %s -ex 'target remote localhost:1234' -x %s" % (args.gdb, > args.binary, args.test) It'd be nice to wrap this line. Otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH v5 16/22] configure: allow user to specify what gdb to use

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > + --with-gdb=GBB-path gdb to use for gdbstub tests [$gdb_bin] s/GBB/GDB/ Reviewed-by: Richard Henderson r~

Re: [PATCH v5 15/22] tests/tcg/aarch64: userspace system register test

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > This tests a bunch of registers that the kernel allows userspace to > read including the CPUID registers. We need a SVE aware compiler as we > are testing the id_aa64zfr0_el1 register in the set. > > Signed-off-by: Alex Bennée > Message-Id:

Re: [PATCH v5 13/22] tests/tcg: add a configure compiler check for ARMv8.1 and SVE

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > + > +# Test for compiler features for optional tests. We only do this > +# for cross compilers because ensuring the docker containers based > +# compilers is a requirememt for adding a new test that needs a > +# compiler feature. > +case

Re: [PATCH v5 09/22] target/arm: prepare for multiple dynamic XMLs

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > We will want to generate similar dynamic XML for gdbstub support of > SVE registers (the upstream doesn't use XML). To that end lightly > rename a few things to make the distinction. > > Signed-off-by: Alex Bennée > --- > target/arm/cpu.h | 20

Re: [PATCH v5 12/22] target/arm: generate xml description of our SVE registers

2020-01-15 Thread Richard Henderson
On 1/14/20 5:09 AM, Alex Bennée wrote: > We also expose a the helpers to read/write the the registers. > > Signed-off-by: Alex Bennée > > --- > v2 > - instead of zNpM expose zN at sve_max_vq width > - wrap union in union q(us), d(usf), s(usf), h(usf), b(us) > v3 > - add a vg pseudo

Re: Semihosting, arm, riscv, ppc and common code

2020-01-15 Thread Liviu Ionescu
> On 15 Jan 2020, at 23:28, Richard Henderson > wrote: > > For risc-v, the odd nop-full semi-hosting call sequence That unfortunate call sequence was the least worst compromise that the RISC-V design team could agree on. :-( The actual problem was that the RISC-V instruction set has a

Re: [PATCH v2 41/86] hw/hppa/machine: Correctly check the firmware is in PDC range

2020-01-15 Thread BALATON Zoltan
On Wed, 15 Jan 2020, Philippe Mathieu-Daudé wrote: On 1/15/20 7:15 PM, BALATON Zoltan wrote: On Wed, 15 Jan 2020, Igor Mammedov wrote: From: Philippe Mathieu-Daudé The firmware has to reside in the PDC range. If the Elf file expects to load it below FIRMWARE_START, it is incorrect,

Re: [PATCH v8 13/13] linux-user: Add support for TYPE_LONG and TYPE_ULONG in do_ioctl()

2020-01-15 Thread Laurent Vivier
Le 15/01/2020 à 20:36, Filip Bozuta a écrit : > Function "do_ioctl()" located in file "syscall.c" was missing > an option for TYPE_LONG and TYPE_ULONG. This caused some ioctls > to not be recognised because they had the third argument that was > of type 'long' or 'unsigned long'. > > For example:

Re: [PATCH] m68k: Fix regression causing Single-Step via GDB/RSP to not single step

2020-01-15 Thread Richard Henderson
On 1/15/20 1:03 AM, Laurent Vivier wrote: > +if (dc->base.singlestep_enabled) { > +tcg_gen_movi_i32(QREG_PC, dc->pc); > +gen_helper_raise_exception(cpu_env, tcg_const_i32(EXCP_DEBUG)); This leaks the temporary, and so not quite ideal. It would be of more concern

Re: [PATCH v7 13/13] linux-user: Add support for TYPE_LONG and TYPE_ULONG in do_ioctl()

2020-01-15 Thread Laurent Vivier
Le 15/01/2020 à 20:12, Filip Bozuta a écrit : > Function "do_ioctl()" located in file "syscall.c" was missing > an option for TYPE_LONG and TYPE_ULONG. This caused some ioctls > to not be recognised because they had the third argument that was > of type 'long' or 'unsigned long'. > > For example:

Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl

2020-01-15 Thread Laurent Vivier
Le 15/01/2020 à 20:17, Filip Bozuta a écrit : > > On 15.1.20. 17:37, Arnd Bergmann wrote: >> On Wed, Jan 15, 2020 at 5:32 PM Laurent Vivier wrote: >>> Le 15/01/2020 à 17:18, Arnd Bergmann a écrit : On Wed, Jan 15, 2020 at 4:53 PM Filip Bozuta wrote: > This patch implements

Re: [PATCH v3 1/3] target/riscv: Fix tb->flags FS status

2020-01-15 Thread Richard Henderson
On 1/14/20 8:28 PM, Alistair Francis wrote: > On Wed, Jan 15, 2020 at 4:18 PM wrote: >> >> It was found that running libquantum on riscv-linux qemu produced an >> incorrect result. After investigation, FP registers are not saved >> during context switch due to incorrect mstatus.FS. >> >> In

Re: [PATCH v2 67/86] ppc:ppc440_bamboo/sam460ex: use memdev for RAM

2020-01-15 Thread BALATON Zoltan
On Wed, 15 Jan 2020, Igor Mammedov wrote: memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using

Re: [PATCH v2 66/86] ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup

2020-01-15 Thread BALATON Zoltan
Subject line is still wrong, it's sam460ex not sam460x. Also you change ppc:whatever to ppc/whatever here but left : as path separator in all other patches. This is not consistent with other commits where the tag in the title is usually a path of the changed part or in this case could be

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-15 Thread puchuu
I've created a new patches for getdents bug https://sourceware.org/bugzilla/show_bug.cgi?id=23960 and I can't reproduce python permissions issue anymore. My mips image built with qemu user works perfect. ** Bug watch added: Sourceware.org Bugzilla #23960

Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl

2020-01-15 Thread Laurent Vivier
Le 15/01/2020 à 20:51, Arnd Bergmann a écrit : > On Wed, Jan 15, 2020 at 8:17 PM Filip Bozuta wrote: >> On 15.1.20. 17:37, Arnd Bergmann wrote: >>> On Wed, Jan 15, 2020 at 5:32 PM Laurent Vivier wrote: Le 15/01/2020 à 17:18, Arnd Bergmann a écrit : > On Wed, Jan 15, 2020 at 4:53 PM

Re: Semihosting, arm, riscv, ppc and common code

2020-01-15 Thread Richard Henderson
On 1/15/20 2:01 AM, Alex Bennée wrote: > Hmm, I'm not so sure. QEMU tries to emulate real HW although I > appreciate that is a somewhat loose definition once you get to things > like -M virt and other such SW like abstractions. Is semihosting even > going to be a thing on real RiscV/Power silicon?

Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

2020-01-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imamm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend Type: series Message-id:

Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

2020-01-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imamm...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

Re: [PATCH v6 11/21] libqtest: make bufwrite rely on the TransportOps

2020-01-15 Thread Alexander Bulekov
On 200103 1745, Philippe Mathieu-Daudé wrote: > On 11/29/19 10:34 PM, Oleinik, Alexander wrote: > > When using qtest "in-process" communication, qtest_sendf directly calls > > a function in the server (qtest.c). Previously, bufwrite used > > socket_send, which bypasses the TransportOps enabling

Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

2020-01-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imamm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend Type: series Message-id:

Re: [PATCH v2 19/86] arm:kzm: use memdev for RAM

2020-01-15 Thread Chubb, Peter (Data61, Kensington NSW)
> "Igor" == Igor Mammedov writes: Igor> memory region. Igor> Signed-off-by: Igor Mammedov Igor> Reviewed-by: Philippe Mathieu-Daudé Igor> --- Igor> CC: peter.ch...@nicta.com.au You can add: Reviewed-by: Peter Chubb Igor> CC: peter.mayd...@linaro.org Igor> CC: qemu-...@nongnu.org Peter

Re: [PATCH RFC 00/12] *** mulitple RDMA channels for migration ***

2020-01-15 Thread Dr. David Alan Gilbert
* Zhimin Feng (fengzhim...@huawei.com) wrote: > From: fengzhimin > > Currently there is a single channel for RDMA migration, this causes > the problem that the network bandwidth is not fully utilized for > 25Gigabit NIC. Inspired by the Multifd, we use two RDMA channels to > send RAM pages,

Re: [PATCH RFC 05/12] migration/rdma: Create the multiRDMA channels

2020-01-15 Thread Dr. David Alan Gilbert
* Zhimin Feng (fengzhim...@huawei.com) wrote: > From: fengzhimin > > In both sides. We still don't transmit anything through them, > and we only build the RDMA connections. > > Signed-off-by: fengzhimin > --- > migration/rdma.c | 253 +-- > 1 file

Re: [PATCH v2 18/86] arm:kzm: drop RAM size fixup

2020-01-15 Thread Chubb, Peter (Data61, Kensington NSW)
> "Igor" == Igor Mammedov writes: Igor> If user provided non-sense RAM size, board will complain and Igor> continue running with max RAM size supported. Also RAM is going Igor> to be allocated by generic code, so it won't be possible for Igor> board to fix things up for user. Igor> Make it

Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl

2020-01-15 Thread Arnd Bergmann
On Wed, Jan 15, 2020 at 8:17 PM Filip Bozuta wrote: > On 15.1.20. 17:37, Arnd Bergmann wrote: > > On Wed, Jan 15, 2020 at 5:32 PM Laurent Vivier wrote: > >> Le 15/01/2020 à 17:18, Arnd Bergmann a écrit : > >>> On Wed, Jan 15, 2020 at 4:53 PM Filip Bozuta > >>> wrote: > >> Do the kernel patches

[PATCH v8 13/13] linux-user: Add support for TYPE_LONG and TYPE_ULONG in do_ioctl()

2020-01-15 Thread Filip Bozuta
Function "do_ioctl()" located in file "syscall.c" was missing an option for TYPE_LONG and TYPE_ULONG. This caused some ioctls to not be recognised because they had the third argument that was of type 'long' or 'unsigned long'. For example: Since implemented ioctls RTC_IRQP_SET and RTC_EPOCH_SET

[PATCH v8 07/13] linux-user: Add support for getting alsa timer version and id

2020-01-15 Thread Filip Bozuta
This patch implements functionalities of following ioctls: SNDRV_TIMER_IOCTL_PVERSION - Getting the sound timer version Read the sound timer version. The third ioctl's argument is a pointer to an int in which the specified timers version is returned. SNDRV_TIMER_IOCTL_NEXT_DEVICE -

[PATCH v8 05/13] linux-user: Add support for getting/setting RTC PLL correction using ioctls

2020-01-15 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_PLL_GET - Getting PLL correction Read the PLL correction for RTCs that support PLL. The PLL correction is returned in the following structure: struct rtc_pll_info { int pll_ctrl;/* placeholder for

Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

2020-01-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imamm...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

[PATCH v8 12/13] linux-user: Add support for selected alsa timer instructions using ioctls

2020-01-15 Thread Filip Bozuta
This patch implements functionalities of following ioctls: SNDRV_TIMER_IOCTL_START - Start selected alsa timer Starts the timer device that is selected. The third ioctl's argument is ignored. Before calling this ioctl, the ioctl "SNDRV_TIMER_IOCTL_SELECT" should be called first to

[PATCH v8 08/13] linux-user: Add support for setting alsa timer enhanced read using ioctl

2020-01-15 Thread Filip Bozuta
This patch implements functionality of following ioctl: SNDRV_TIMER_IOCTL_TREAD - Setting enhanced time read Sets enhanced time read which is used for reading time with timestamps and events. The third ioctl's argument is a pointer to an 'int'. Enhanced reading is set if the third

[PATCH v8 02/13] linux-user: Add support for getting/setting RTC time and alarm using ioctls

2020-01-15 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_RD_TIME - Getting RTC time Returns this RTC's time in the following structure: struct rtc_time { int tm_sec; int tm_min; int tm_hour; int tm_mday; int tm_mon;

[PATCH v8 00/13] linux-user: Add support for real time clock and

2020-01-15 Thread Filip Bozuta
This series covers following RTC and sound timer ioctls: RTC ioctls(22): * RTC_AIE_ON * RTC_ALM_SET * RTC_WKALM_SET * RTC_AIE_OFF * RTC_ALM_READ* RTC_WKALM_RD * RTC_UIE_ON * RTC_RD_TIME * RTC_PLL_GET * RTC_UIE_OFF *

[PATCH v8 09/13] linux-user: Add support for getting/setting specified alsa timer parameters using ioctls

2020-01-15 Thread Filip Bozuta
This patch implements functionalities of following ioctls: SNDRV_TIMER_IOCTL_GINFO - Getting information about specified timer Read information about the specified timer. The information about the timer is returned in the following structure: struct snd_timer_ginfo {

[PATCH v8 06/13] linux-user: Add support for read/clear RTC voltage low detector using ioctls

2020-01-15 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_VL_READ - Read voltage low detection information Read the voltage low for RTCs that support voltage low. The third ioctl's' argument points to an int in which the voltage low is returned. RTC_VL_CLR - Clear voltage low

[PATCH v8 01/13] linux-user: Add support for enabling/disabling RTC features using ioctls

2020-01-15 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_AIE_ON, RTC_AIE_OFF - Alarm interrupt enabling on/off Enable or disable the alarm interrupt, for RTCs that support alarms. The third ioctl's argument is ignored. RTC_UIE_ON, RTC_UIE_OFF - Update interrupt enabling on/off

[PATCH v8 11/13] linux-user: Add support for getting/setting selected alsa timer parameters using ioctls

2020-01-15 Thread Filip Bozuta
This patch implements functionalities of following ioctls: SNDRV_TIMER_IOCTL_INFO - Getting information about selected timer Read information about the selected timer. The information is returned in the following structure: struct snd_timer_info { unsigned int flags;

[PATCH v8 03/13] linux-user: Add support for getting/setting RTC periodic interrupt and epoch using ioctls

2020-01-15 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_IRQP_READ, RTC_IRQP_SET - Getting/Setting IRQ rate Read and set the frequency for periodic interrupts, for RTCs that support periodic interrupts. The periodic interrupt must be separately enabled or disabled using the

[PATCH v8 04/13] linux-user: Add support for getting/setting RTC wakeup alarm using ioctls

2020-01-15 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_WKALM_SET, RTC_WKALM_GET - Getting/Setting wakeup alarm Some RTCs support a more powerful alarm interface, using these ioctls to read or write the RTC's alarm time (respectively) with this structure: struct

[PATCH v8 10/13] linux-user: Add support for selecting alsa timer using ioctl

2020-01-15 Thread Filip Bozuta
This patch implements functionality of following ioctl: SNDRV_TIMER_IOCTL_SELECT - Selecting timer Selects the timer which id is specified. The timer id is specified in the following strcuture: struct snd_timer_select { struct snd_timer_id id; /* timer ID */

Re: [PATCH v2 38/86] s390x:s390-virtio-ccw: use memdev for RAM

2020-01-15 Thread Philippe Mathieu-Daudé
On 1/15/20 4:06 PM, Igor Mammedov wrote: memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using

Re: [PATCH v2 37/86] arm:xlnx-zcu102: use memdev for RAM

2020-01-15 Thread Philippe Mathieu-Daudé
On 1/15/20 4:06 PM, Igor Mammedov wrote: memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using

Re: [PATCH v2 10/86] arm:aspeed: use memdev for RAM

2020-01-15 Thread Philippe Mathieu-Daudé
On 1/15/20 4:06 PM, Igor Mammedov wrote: memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using

  1   2   3   4   >