Re: [PATCH] audio/dsound: fix invalid parameters error

2020-02-02 Thread Howard Spoelstra
On Mon, Feb 3, 2020 at 12:02 AM Kővágó, Zoltán wrote: > Windows (unlike wine) bails out when IDirectSoundBuffer8::Lock is called > with zero length. Also, hw->pos_emul handling was incorrect when > calling this function for the first time. > > Signed-off-by: Kővágó, Zoltán > Reported-by: KJ

Re: [PATCH v22 7/9] ACPI: Record Generic Error Status Block(GESB) table

2020-02-02 Thread Igor Mammedov
On Sun, 2 Feb 2020 21:42:23 +0800 gengdongjiu wrote: > On 2020/1/28 23:29, Igor Mammedov wrote: > > On Wed, 8 Jan 2020 19:32:21 +0800 > > Dongjiu Geng wrote: > > > >> kvm_arch_on_sigbus_vcpu() error injection uses source_id as > >> index in etc/hardware_errors to find out Error Status Data >

Re: [PATCH] target/mips: Fix ll/sc after 7dd547e5ab6b31e7a0cfc182d3ad131dd55a948f

2020-02-02 Thread Richard Henderson
On 2/2/20 3:34 PM, James Clarke wrote: > From: Alex Richardson > > After 7dd547e5ab6b31e7a0cfc182d3ad131dd55a948f the env->llval value is > loaded as an unsigned value (instead of sign-extended as before). > Therefore, the CMPXCHG in gen_st_cond() in translate.c fails if the sign > bit is set in

Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address

2020-02-02 Thread Igor Mammedov
On Sun, 2 Feb 2020 20:44:35 +0800 gengdongjiu wrote: > sorry for the late response due to Chinese new year > > On 2020/1/28 22:41, Igor Mammedov wrote: > > On Wed, 8 Jan 2020 19:32:19 +0800 > > Dongjiu Geng wrote: > > > > in addition to comments of others: > > > >> Record the GHEB address

[PATCH] pl031: add finalize function to avoid memleaks

2020-02-02 Thread pannengyuan
From: Pan Nengyuan There is a memory leak when we call 'device_list_properties' with typename = pl031. It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments": {"typename": "pl031"}}' The memory leak stack: Direct leak

Re: [PATCH 2/4] target/arm: Update MSR access to UAO

2020-02-02 Thread Richard Henderson
On 2/2/20 1:29 PM, Peter Maydell wrote: > Yes, but SPSR_ELx isn't started with a clean zero and built up > the way the new PSTATE is, it gets copied from the AArch32 CPSR > via cpsr_read(). I forget how carefully we keep the guest from setting > CPSR bits that aren't really valid for the CPU...

Re: [PATCH v2 0/7] Some cleanup in arm/virt/acpi

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:14:58AM +0800, Heyi Guo wrote: > Remove conflict _ADR objects, and fix and refine PCI device definition in > ACPI/DSDT. > > Cc: Peter Maydell > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Shannon Zhao > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org

Re: [PATCH] boot-order-test: fix memleaks in boot-order-test

2020-02-02 Thread Thomas Huth
On 03/02/2020 03.59, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > It's not a big deal, but 'check qtest-ppc/ppc64' runs fail if sanitizers is > enabled. > The memory leak stack is as follow: > > Direct leak of 128 byte(s) in 4 object(s) allocated from: > #0 0x7f11756f5970 in

Re: [PATCH] virtio: add the queue number check

2020-02-02 Thread Michael S. Tsirkin
On Fri, Jan 31, 2020 at 05:22:47PM +0100, Paolo Bonzini wrote: > I have just found this email... sorry for the delay. > > On 10/01/20 07:10, Yang Zhong wrote: > >> No. If virtio-blk works, the bug is in vhost-user-blk; if virtio-blk needs > >> no check in cpu count, vhost-user-blk also doesn't. >

Re: [PULL v3 17/18] i386:acpi: Remove _HID from the SMBus ACPI entry

2020-02-02 Thread Michael S. Tsirkin
On Thu, Jan 30, 2020 at 07:05:16PM +, Peter Maydell wrote: > On Thu, 23 Jan 2020 at 07:11, Michael S. Tsirkin wrote: > > > > From: Corey Minyard > > > > Per the ACPI spec (version 6.1, section 6.1.5 _HID) it is not required > > on enumerated buses (like PCI in this case), _ADR is required

[PULL 31/35] target/ppc: Use probe_access for LSW, STSW

2020-02-02 Thread David Gibson
From: Richard Henderson Use a minimum number of mmu lookups for the contiguous bytes that are accessed. If the lookup succeeds, we can finish the operation with host addresses only. Reported-by: Howard Spoelstra Signed-off-by: Richard Henderson Message-Id:

Re: Making QEMU easier for management tools and applications

2020-02-02 Thread Markus Armbruster
Paolo Bonzini writes: > Il dom 2 feb 2020, 10:22 Kevin Wolf ha scritto: > >> Am 31.01.2020 um 13:27 hat Eric Blake geschrieben: >> > On 1/28/20 6:54 AM, Kevin Wolf wrote: >> > >> > > > >> > > > The arguments as dotted keys: >> > > > >> > > >

[Bug 1861653] [NEW] CPU of qemu-system-aarch64 always stuck

2020-02-02 Thread zwq
Public bug reported: I started qemu with these arguments: qemu-system-aarch64 -M virt-2.9 -cpu cortex-a72 -smp cores=8,threads=1,sockets=1 -m 2G -device nec-usb-xhci -device usb-kbd -device usb-tablet -pflash /sdcard/QEMU_EFI.img -pflash /sdcard/QEMU_VARS.img -device

[PULL 33/35] target/ppc: Remove redundant mask in DCBZ

2020-02-02 Thread David Gibson
From: Richard Henderson The value of addr has already been masked, just above. Signed-off-by: Richard Henderson Message-Id: <20200129235040.24022-4-richard.hender...@linaro.org> Tested-by: Howard Spoelstra Signed-off-by: David Gibson --- target/ppc/mem_helper.c | 2 +- 1 file changed, 1

[PULL 19/35] ppc/pnv: Add models for POWER9 PHB4 PCIe Host bridge

2020-02-02 Thread David Gibson
From: Benjamin Herrenschmidt These changes introduces models for the PCIe Host Bridge (PHB4) of the POWER9 processor. It includes the PowerBus logic interface (PBCQ), IOMMU support, a single PCIe Gen.4 Root Complex, and support for MSI and LSI interrupt sources as found on a POWER9 system using

[PULL 34/35] target/ppc: Use probe_write for DCBZ

2020-02-02 Thread David Gibson
From: Richard Henderson Using probe_write instead of tlb_vaddr_to_host means that we process watchpoints and notdirty pages more efficiently. Signed-off-by: Richard Henderson Message-Id: <20200129235040.24022-5-richard.hender...@linaro.org> Tested-by: Howard Spoelstra Signed-off-by: David

[PULL 27/35] target/ppc: Build rtas error log upon an MCE

2020-02-02 Thread David Gibson
From: Aravinda Prasad Upon a machine check exception (MCE) in a guest address space, KVM causes a guest exit to enable QEMU to build and pass the error to the guest in the PAPR defined rtas error log format. This patch builds the rtas error log, copies it to the rtas_addr and then invokes the

[PULL 35/35] tests: Silence various warnings with pseries

2020-02-02 Thread David Gibson
From: Greg Kurz Some default features of the pseries machine are only available with KVM. Warnings are printed when the pseries machine is used with another accelerator: qemu-system-ppc64: warning: TCG doesn't support requested feature, cap-ccf-assist=on qemu-system-ppc64: warning: Firmware

[PULL 29/35] migration: Include migration support for machine check handling

2020-02-02 Thread David Gibson
From: Aravinda Prasad This patch includes migration support for machine check handling. Especially this patch blocks VM migration requests until the machine check error handling is complete as these errors are specific to the source hardware and is irrelevant on the target hardware.

[PULL 28/35] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2020-02-02 Thread David Gibson
From: Aravinda Prasad This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also handles the case when multiple processors experience machine

[PULL 32/35] target/ppc: Use probe_access for LMW, STMW

2020-02-02 Thread David Gibson
From: Richard Henderson Use a minimum number of mmu lookups for the contiguous bytes that are accessed. If the lookup succeeds, we can finish the operation with host addresses only. Reported-by: Howard Spoelstra Signed-off-by: Richard Henderson Message-Id:

[PULL 23/35] target/ppc/cpu.h: Put macro parameter in parentheses

2020-02-02 Thread David Gibson
From: BALATON Zoltan Fix PPC_INPUT macro to work with more complex expressions by protecting its argument with parentheses. Signed-off-by: BALATON Zoltan Message-Id: <20200130021619.65fab747...@zero.eik.bme.hu> Signed-off-by: David Gibson --- target/ppc/cpu.h | 2 +- 1 file changed, 1

Re: [RFC PATCH] audio: proper support for float samples in mixeng

2020-02-02 Thread Markus Armbruster
"Kővágó, Zoltán" writes: > This adds proper support for float samples in mixeng by adding a new > audio format for it. > > Limitations: only native endianness is supported. > > Signed-off-by: Kővágó, Zoltán > --- > > This patch is meant to be applied on top of "[PATCH] coreaudio: fix coreaudio

[PULL 21/35] ppc/pnv: change the PowerNV machine devices to be non user creatable

2020-02-02 Thread David Gibson
From: Cédric Le Goater The PowerNV machine emulates an OpenPOWER system and the PowerNV chip devices are models of the internal logic of the POWER processor. They can not be instantiated by the user on the QEMU command line. The PHB3/PHB4 devices could be an exception in the future after some

[PULL 24/35] Wrapper function to wait on condition for the main loop mutex

2020-02-02 Thread David Gibson
From: Aravinda Prasad Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by:

[PULL 26/35] target/ppc: Handle NMI guest exit

2020-02-02 Thread David Gibson
From: Aravinda Prasad Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit

[PULL 25/35] ppc: spapr: Introduce FWNMI capability

2020-02-02 Thread David Gibson
From: Aravinda Prasad Introduce fwnmi an spapr capability and add a helper function which tries to enable it, which would be used by following patch of the series. This patch by itself does not change the existing behavior. Signed-off-by: Aravinda Prasad [eliminate cap_ppc_fwnmi, add fwnmi cap

[PULL 30/35] ppc: spapr: Activate the FWNMI functionality

2020-02-02 Thread David Gibson
From: Aravinda Prasad This patch sets the default value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for machine type 5.0. Signed-off-by: Aravinda Prasad Signed-off-by: Ganesh Goudar Message-Id: <20200130184423.20519-8-ganes...@linux.ibm.com> Signed-off-by: David Gibson --- hw/ppc/spapr.c | 3 ++-

[PULL 20/35] ppc/pnv: Add models for POWER8 PHB3 PCIe Host bridge

2020-02-02 Thread David Gibson
From: Cédric Le Goater This is a model of the PCIe Host Bridge (PHB3) found on a POWER8 processor. It includes the PowerBus logic interface (PBCQ), IOMMU support, a single PCIe Gen.3 Root Complex, and support for MSI and LSI interrupt sources as found on a POWER8 system using the XICS interrupt

[PULL 17/35] hw/ppc/Kconfig: Enable TPM_SPAPR as part of PSERIES config

2020-02-02 Thread David Gibson
From: Stefan Berger Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau Reviewed-by: David Gibson Message-Id: <20200121152935.649898-6-stef...@linux.ibm.com> [dwg: Use default in Kconfig rather than select to avoid breaking Windows host build] Signed-off-by: David Gibson ---

[PULL 15/35] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2020-02-02 Thread David Gibson
From: Stefan Berger Implement support for TPM on ppc64 by implementing the vTPM CRQ interface as a frontend. It can use the tpm_emulator driver backend with the external swtpm. The Linux vTPM driver for ppc64 works with this emulation. This TPM emulator also handles the TPM 2 case.

[PULL 04/35] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS

2020-02-02 Thread David Gibson
From: Thomas Huth It's been deprecated since QEMU v3.1. The 40p machine should be used nowadays instead. Reviewed-by: Philippe Mathieu-Daudé Acked-by: Hervé Poussineau Signed-off-by: Thomas Huth Message-Id: <20200114114617.28854-1-th...@redhat.com> Signed-off-by: David Gibson ---

[PULL 12/35] ppc/pnv: Add support for "hostboot" mode

2020-02-02 Thread David Gibson
From: Cédric Le Goater When the "hb-mode" option is activated on the powernv machine, the firmware is mapped at 0x800 and the HRMOR of the HW threads are set to the same address. The PNOR mapping on the FW address space of the LPC bus is left enabled to let the firmware load any other

[PULL 11/35] ppc/pnv: remove useless "core-pir" property alias.

2020-02-02 Thread David Gibson
From: Cédric Le Goater Commit 158e17a65e1a ("ppc/pnv: Link "chip" property to PnvCore::chip pointer") introduced some cleanups of the PnvCore realize handler. Let's continue by reworking a bit the interface of the PnvCore handlers for the CPU threads. These changes make the "core-pir" property

[PULL 18/35] docs/specs/tpm: reST-ify TPM documentation

2020-02-02 Thread David Gibson
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Message-Id: <20200121152935.649898-7-stef...@linux.ibm.com> Signed-off-by: David Gibson --- docs/specs/index.rst | 1 + docs/specs/tpm.rst | 503 +++

[PULL 07/35] target/ppc: Add privileged message send facilities

2020-02-02 Thread David Gibson
From: Cédric Le Goater The Processor Control facility for POWER8 processors and later provides a mechanism for the hypervisor to send messages to other threads in the system (msgsnd instruction) and cause hypervisor-level exceptions. Privileged non-hypervisor programs can also send messages

[PULL 14/35] spapr: Implement get_dt_compatible() callback

2020-02-02 Thread David Gibson
From: Stefan Berger For devices that cannot be statically initialized, implement a get_dt_compatible() callback that allows us to ask the device for the 'compatible' value. Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau Reviewed-by: David Gibson Message-Id:

[PULL 16/35] tpm_spapr: Support suspend and resume

2020-02-02 Thread David Gibson
From: Stefan Berger Extend the tpm_spapr frontend with VM suspend and resume support. Signed-off-by: Stefan Berger Message-Id: <20200121152935.649898-5-stef...@linux.ibm.com> Reviewed-by: Marc-André Lureau Signed-off-by: David Gibson --- hw/tpm/tpm_spapr.c | 52

[PULL 09/35] spapr: Don't allow multiple active vCPUs at CAS

2020-02-02 Thread David Gibson
From: Greg Kurz According to the description of "ibm,client-architecture-support" that can found in LoPAPR "B.6.2.3 Root Node Methods": If multiple partition processors or threads are active at the time of the ibm,client-architecture-support method call, or an error is detected in the format of

[PULL 13/35] tpm: Move tpm_tis_show_buffer to tpm_util.c

2020-02-02 Thread David Gibson
From: Stefan Berger Signed-off-by: Stefan Berger Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson Message-Id: <20200121152935.649898-2-stef...@linux.ibm.com> Signed-off-by: David Gibson --- hw/tpm/tpm_tis.c| 32 hw/tpm/tpm_util.c | 25

[PULL 22/35] spapr: Enable DD2.3 accelerated count cache flush in pseries-5.0 machine

2020-02-02 Thread David Gibson
For POWER9 DD2.2 cpus, the best current Spectre v2 indirect branch mitigation is "count cache disabled", which is configured with: -machine cap-ibs=fixed-ccd However, this option isn't available on DD2.3 CPUs with KVM, because they don't have the count cache disabled. For POWER9 DD2.3 cpus,

[PULL 05/35] target/ppc: Clarify the meaning of return values in kvm_handle_debug

2020-02-02 Thread David Gibson
From: Fabiano Rosas The kvm_handle_debug function can return 0 to go back into the guest or return 1 to notify the gdbstub thread and pass control to GDB. Signed-off-by: Fabiano Rosas Message-Id: <20200110151344.278471-2-faro...@linux.ibm.com> Tested-by: Leonardo Bras Signed-off-by: David

[PULL 06/35] spapr: Fail CAS if option vector table cannot be parsed

2020-02-02 Thread David Gibson
From: Greg Kurz Most of the option vector helpers have assertions to check their arguments aren't null. The guest can provide an arbitrary address for the CAS structure that would result in such null arguments. Fail CAS with H_PARAMETER and print a warning instead of aborting QEMU.

[PULL 08/35] target/ppc: add support for Hypervisor Facility Unavailable Exception

2020-02-02 Thread David Gibson
From: Cédric Le Goater The privileged message send and clear instructions (msgsndp & msgclrp) are privileged, but will generate a hypervisor facility unavailable exception if not enabled in the HFSCR and executed in privileged non-hypervisor state. Add checks when accessing the DPDES register

[PULL 10/35] ppc/pnv: Add support for HRMOR on Radix host

2020-02-02 Thread David Gibson
From: Cédric Le Goater When in HV mode, if EA[0] is 0, the Hypervisor Offset Real Mode Register controls the access. Signed-off-by: Cédric Le Goater Message-Id: <20200127144154.10170-2-...@kaod.org> Signed-off-by: David Gibson --- target/ppc/mmu-radix64.c | 6 ++ 1 file changed, 6

[PULL 00/35] ppc-for-5.0 queue 20200203

2020-02-02 Thread David Gibson
The following changes since commit 28db64fce555a03b4ca256d5b6f4290abdfbd9e8: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2020-01-31 17:37:00 +) are available in the Git repository at: git://github.com/dgibson/qemu.git

[PULL 03/35] ppc:virtex_ml507: remove unused arguments

2020-02-02 Thread David Gibson
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <1579100861-73692-71-git-send-email-imamm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/ppc/virtex_ml507.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[PULL 02/35] ppc/pnv: improve error logging when a PNOR update fails

2020-02-02 Thread David Gibson
From: Cédric Le Goater Print out the offset at which the error occured. Signed-off-by: Cédric Le Goater Message-Id: <20200108090348.21224-3-...@kaod.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/ppc/pnv_pnor.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PULL 01/35] ppc/pnv: use QEMU unit definition MiB

2020-02-02 Thread David Gibson
From: Cédric Le Goater Signed-off-by: Cédric Le Goater Message-Id: <20200108090348.21224-2-...@kaod.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/ppc/pnv_pnor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv_pnor.c

Re: [PATCH v2 4/7] arm/acpi: fix PCI _PRT definition

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:15:02AM +0800, Heyi Guo wrote: > The address field in each _PRT mapping package should be constructed > with high word for device# and low word for function#, so it is wrong > to use bus_no as the high word. Enumerate all possible slots > (i.e. PCI_SLOT_MAX) instead. >

Re: [PATCH] tests/qtest: update comments about bios-tables-test-allowed-diff.h

2020-02-02 Thread Thomas Huth
On 02/02/2020 12.00, Heyi Guo wrote: > Update comments in tests/qtest/bios-tables-test.c to reflect the > current path of bios-tables-test-allowed-diff.h, which is now under > tests/qtest/ as well. > > Signed-off-by: Heyi Guo > > --- > > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc:

Re: [PATCH v2 6/7] arm/acpi: simplify the description of PCI _CRS

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:15:04AM +0800, Heyi Guo wrote: > The original code defines a named object for the resource template but > then returns the resource template object itself; the resulted output > is like below: > > Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings > { >

Re: [PATCH v2 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:15:03AM +0800, Heyi Guo wrote: > Using _UID of 0 for all PCI interrupt link devices absolutely violates > the spec. Simply increase one by one. > > Signed-off-by: Heyi Guo Reviewed-by: Michael S. Tsirkin > --- > Cc: Peter Maydell > Cc: "Michael S. Tsirkin" > Cc:

Re: [PATCH v2 7/7] virt/acpi: update golden masters for DSDT update

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:15:05AM +0800, Heyi Guo wrote: > Differences between disassembled ASL files: > > diff --git a/DSDT.dsl.orig b/DSDT.dsl > index ed3e5f0fa9..10cf70c886 100644 > --- a/DSDT.dsl.orig > +++ b/DSDT.dsl > @@ -5,13 +5,13 @@ > * > * Disassembling to symbolic ASL+ operators >

Re: [PATCH v2 1/7] bios-tables-test: prepare to change ARM virt ACPI DSDT

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:14:59AM +0800, Heyi Guo wrote: > We are going to change ARM virt ACPI DSDT table, which will cause make > check to fail, so temporarily add related golden masters to ignore > list. > > Signed-off-by: Heyi Guo Reviewed-by: Michael S. Tsirkin > --- > Cc: Peter

Re: [PATCH v2 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:15:01AM +0800, Heyi Guo wrote: > According to ACPI spec, _ADR should be used for device on a bus that > has a standard enumeration algorithm, but not for device which is on > system bus and must be enumerated by OSPM. And it is not recommended > to contain both _HID and

Re: [Bug 1860759] Re: [REGRESSION] option `-snapshot` ignored with blockdev

2020-02-02 Thread Ildar
this answers the whole question. Thanks a lot. closing ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1860759 Title: [REGRESSION] option

[PATCH qemu v6 5/6] spapr: Allow changing offset for -kernel image

2020-02-02 Thread Alexey Kardashevskiy
This allows moving the kernel in the guest memory. The option is useful for step debugging (as Linux is linked at 0x0); it also allows loading grub which is normally linked to run at 0x2. This uses the existing kernel address by default. Signed-off-by: Alexey Kardashevskiy ---

[PATCH qemu v6 2/6] ppc/spapr: Move GPRs setup to one place

2020-02-02 Thread Alexey Kardashevskiy
At the moment "pseries" starts in SLOF which only expects the FDT blob pointer in r3. As we are going to introduce a OpenFirmware support in QEMU, we will be booting OF clients directly and these expect a stack pointer in r1, the OF entry point in r5 and in addition to this, Linux looks at r3/r4

[PATCH qemu v6 3/6] spapr/spapr: Make vty_getchars public

2020-02-02 Thread Alexey Kardashevskiy
A serial device fetches the data from the chardev backend as soon as input happens and stores it in its internal device specific buffer, every char device implements it again. Since there is no unified interface to read such buffer, we will have to read characters directly from

[PATCH qemu v6 6/6] spapr: Implement Open Firmware client interface

2020-02-02 Thread Alexey Kardashevskiy
The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of the firmware (RTAS) has been implemented as a

[PATCH qemu v6 4/6] spapr/cas: Separate CAS handling from rebuilding the FDT

2020-02-02 Thread Alexey Kardashevskiy
At the moment "ibm,client-architecture-support" ("CAS") is implemented in SLOF and QEMU assists via the custom H_CAS hypercall which copies an updated flatten device tree (FDT) blob to the SLOF memory which it then uses to update its internal tree. When we enable the OpenFirmware client interface

[PATCH qemu v6 1/6] ppc: Start CPU in the default mode which is big-endian 32bit

2020-02-02 Thread Alexey Kardashevskiy
At the moment we enforce 64bit mode on a CPU when reset. This does not make difference as SLOF or Linux set the desired mode straight away. However if we ever boot something other than these two, this might not work as, for example, GRUB expects the default MSR state and does not work properly.

[PATCH qemu v6 0/6] spapr: Kill SLOF

2020-02-02 Thread Alexey Kardashevskiy
This is v6 of an effort to implement Open Firmware Client Interface in QEMU. The feature is described in 6/6, 1/6..5/6 are small but necessary preparations. With this thing, I can boot unmodified Ubuntu 18.04 and Fedora 30 directly from the disk without SLOF. This is based on sha1 532fe321cf06

Re: [RFC] QEMU Gating CI

2020-02-02 Thread Cleber Rosa
On Fri, Jan 17, 2020 at 02:33:54PM +, Peter Maydell wrote: > On Mon, 2 Dec 2019 at 14:06, Cleber Rosa wrote: > > > > RFC: QEMU Gating CI > > === > > > > This RFC attempts to address most of the issues described in > > "Requirements/GatinCI"[1]. An also relevant write up is

[RFC PATCH 1/2] GitLab CI: avoid calling before_scripts on unintended jobs

2020-02-02 Thread Cleber Rosa
At this point it seems that all jobs depend on those steps, with maybe the EDK2 jobs as exceptions. The jobs that will be added will not want those scripts to be run, so let's move these steps to the appropriate jobs, while still trying to avoid repetition. Signed-off-by: Cleber Rosa ---

[RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-02 Thread Cleber Rosa
This is a crude and straightforward mapping of Peter's "remake-merge-builds" and "pull-buildtest" scripts. Some characteristics were removed for simplicity sake (but eventually will), including: * number of simultaneous make jobs * make's synchronous output, not needed because of previous point

[PATCH qemu] spapr/rtas: Print message from "ibm,os-term"

2020-02-02 Thread Alexey Kardashevskiy
The "ibm,os-term" RTAS call has a single parameter which is a pointer to a message from the guest kernel about the termination cause; this prints it. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_rtas.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/ppc/spapr_rtas.c

[PATCH] boot-order-test: fix memleaks in boot-order-test

2020-02-02 Thread pannengyuan
From: Pan Nengyuan It's not a big deal, but 'check qtest-ppc/ppc64' runs fail if sanitizers is enabled. The memory leak stack is as follow: Direct leak of 128 byte(s) in 4 object(s) allocated from: #0 0x7f11756f5970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970) #1

Re: VW ELF loader

2020-02-02 Thread David Gibson
On Sun, Feb 02, 2020 at 06:38:59PM +0100, Paolo Bonzini wrote: > Il dom 2 feb 2020, 12:51 Alexey Kardashevskiy ha scritto: > > > > QEMU must not load GRUB from disk, that's the firmware's task. If you > > > want to kill SLOF, you can rewrite it, but loading the kernel GRUB from > > > disk

Re: VW ELF loader

2020-02-02 Thread David Gibson
On Sat, Feb 01, 2020 at 08:04:25PM +0100, Paolo Bonzini wrote: > On 01/02/20 14:39, Alexey Kardashevskiy wrote: > > QEMU needs to load GRUB from the disk. The current workaround is to read > > it from qcow2, save in a file and then call load_elf(). Not nice. > > > > 2 problems with that. > > > >

Re: [PATCH] tests: Silent various warnings with pseries

2020-02-02 Thread David Gibson
On Sat, Feb 01, 2020 at 11:46:16PM +0100, Greg Kurz wrote: > Some default features of the pseries machine are only available with > KVM. Warnings are printed when the pseries machine is used with another > accelerator: > > qemu-system-ppc64: warning: TCG doesn't support requested feature, >

Re: [PATCH] tests: Silent various warnings with pseries

2020-02-02 Thread David Gibson
On Sun, Feb 02, 2020 at 06:31:17PM +0100, BALATON Zoltan wrote: > On Sun, 2 Feb 2020, BALATON Zoltan wrote: > > On Sat, 1 Feb 2020, Greg Kurz wrote: > > > Some default features of the pseries machine are only available with > > > KVM. Warnings are printed when the pseries machine is used with

[PATCH v2 7/7] virt/acpi: update golden masters for DSDT update

2020-02-02 Thread Heyi Guo
Differences between disassembled ASL files: diff --git a/DSDT.dsl.orig b/DSDT.dsl index ed3e5f0fa9..10cf70c886 100644 --- a/DSDT.dsl.orig +++ b/DSDT.dsl @@ -5,13 +5,13 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of DSDT, Thu Jan 23 16:00:04 2020 + * Disassembly of

[PATCH v2 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-02-02 Thread Heyi Guo
According to ACPI spec, _ADR should be used for device on a bus that has a standard enumeration algorithm, but not for device which is on system bus and must be enumerated by OSPM. And it is not recommended to contain both _HID and _ADR in a single device. See ACPI 6.3, section 6.1, top of page

[PATCH v2 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices

2020-02-02 Thread Heyi Guo
Using _UID of 0 for all PCI interrupt link devices absolutely violates the spec. Simply increase one by one. Signed-off-by: Heyi Guo --- Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Shannon Zhao Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org ---

[PATCH v2 2/7] arm/virt/acpi: remove meaningless sub device "RP0" from PCI0

2020-02-02 Thread Heyi Guo
The sub device "RP0" under PCI0 in ACPI/DSDT does not contain any method or property other than "_ADR", so it is safe to remove it. Signed-off-by: Heyi Guo Acked-by: "Michael S. Tsirkin" --- Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Shannon Zhao Cc:

[PATCH v2 1/7] bios-tables-test: prepare to change ARM virt ACPI DSDT

2020-02-02 Thread Heyi Guo
We are going to change ARM virt ACPI DSDT table, which will cause make check to fail, so temporarily add related golden masters to ignore list. Signed-off-by: Heyi Guo --- Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Shannon Zhao Cc: qemu-...@nongnu.org Cc:

[PATCH v2 6/7] arm/acpi: simplify the description of PCI _CRS

2020-02-02 Thread Heyi Guo
The original code defines a named object for the resource template but then returns the resource template object itself; the resulted output is like below: Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings { Name (RBUF, ResourceTemplate () { WordBusNumber

[PATCH v2 4/7] arm/acpi: fix PCI _PRT definition

2020-02-02 Thread Heyi Guo
The address field in each _PRT mapping package should be constructed with high word for device# and low word for function#, so it is wrong to use bus_no as the high word. Enumerate all possible slots (i.e. PCI_SLOT_MAX) instead. Signed-off-by: Heyi Guo --- Cc: Peter Maydell Cc: "Michael S.

[PATCH v2 0/7] Some cleanup in arm/virt/acpi

2020-02-02 Thread Heyi Guo
Remove conflict _ADR objects, and fix and refine PCI device definition in ACPI/DSDT. Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Shannon Zhao Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org v1 -> v2: - flow the work flow in tests/qtest/bios-table-test.c to post ACPI

[PATCH] audio/dsound: fix invalid parameters error

2020-02-02 Thread Kővágó, Zoltán
Windows (unlike wine) bails out when IDirectSoundBuffer8::Lock is called with zero length. Also, hw->pos_emul handling was incorrect when calling this function for the first time. Signed-off-by: Kővágó, Zoltán Reported-by: KJ Liew --- I've tested this patch on wine and a borrowed Windows 8.1

Re: [PATCH v4 02/20] hw/arm: add Xunlong Orange Pi PC machine

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 7:04 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > The Xunlong Orange Pi PC is an Allwinner H3 System on Chip > > based embedded computer with mainline support in both U-Boot > > and Linux. The board comes with a Quad Core Cortex A7 @

Re: [PATCH v4 02/20] hw/arm: add Xunlong Orange Pi PC machine

2020-02-02 Thread Niek Linnenbank
On Tue, Jan 21, 2020 at 5:39 PM Igor Mammedov wrote: > On Sun, 19 Jan 2020 01:50:44 +0100 > Niek Linnenbank wrote: > > > The Xunlong Orange Pi PC is an Allwinner H3 System on Chip > > based embedded computer with mainline support in both U-Boot > > and Linux. The board comes with a Quad Core

Re: [RFC PATCH] audio: proper support for float samples in mixeng

2020-02-02 Thread Howard Spoelstra
On Sun, Feb 2, 2020 at 8:38 PM Kővágó, Zoltán wrote: > This adds proper support for float samples in mixeng by adding a new > audio format for it. > > Limitations: only native endianness is supported. > > Signed-off-by: Kővágó, Zoltán > --- > > This patch is meant to be applied on top of

Re: [PATCH v4 10/20] hw/arm/allwinner-h3: add Boot ROM support

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 8:14 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > A real Allwinner H3 SoC contains a Boot ROM which is the > > first code that runs right after the SoC is powered on. > > The Boot ROM is responsible for loading user code (e.g. a

[Bug 1805913] Re: readdir() returns NULL (errno=EOVERFLOW) for 32-bit user-static qemu on 64-bit host

2020-02-02 Thread Marcin Konarski
This problem affected my virtual environment which I used (via qemu- static) to build my project for RaspberryPI platform. After I upgraded my virtual Raspbian to buster release `readdir` stopped working (as described in this thread) due to mapping of 64 inode numbers to qemu 32bit ARM land. I

Re: [PATCH v4 08/20] hw/arm/allwinner: add SD/MMC host controller

2020-02-02 Thread Niek Linnenbank
Hi Philippe, On Sun, Jan 19, 2020 at 8:02 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > The Allwinner System on Chip families sun4i and above contain > > an integrated storage controller for Secure Digital (SD) and > > Multi Media Card (MMC) interfaces. This

Re: [PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-02-02 Thread Niek Linnenbank
Hi Corey, Thanks for reviewing! On Mon, Jan 20, 2020 at 6:59 PM Corey Minyard wrote: > On Sat, Jan 18, 2020 at 04:25:08PM +0100, Philippe Mathieu-Daudé wrote: > > Cc'ing Corey/David for good advices about using UUID. > > Is there any reason you didn't use the built-in qemu UUID for this? It >

Re: [PATCH v4 07/20] hw/arm/allwinner: add Security Identifier device

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 7:57 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > The Security Identifier device found in various Allwinner System on Chip > > designs gives applications a per-board unique identifier. This commit > > adds support for the Allwinner

Re: [PATCH v4 06/20] hw/arm/allwinner: add CPU Configuration module

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 7:52 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > Various Allwinner System on Chip designs contain multiple processors > > that can be configured and reset using the generic CPU Configuration > > module interface. This commit adds

[Bug 1805913] Re: readdir() returns NULL (errno=EOVERFLOW) for 32-bit user-static qemu on 64-bit host

2020-02-02 Thread Philippe Vaucher
Ah, great thanks. It looks like there are patches that fix qemu, although the setup looks a bit complex. I'll report if I get something going. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805913

Re: [PATCH v2] Implement the Screamer sound chip for the mac99 machine type

2020-02-02 Thread Zoltán Kővágó
On 2020-01-28 09:30, Volker Rümelin wrote: Hi, Unfortunately it's not that simple to simply revert the patch since the old backend api no longer exists.  Also I don't have a Mac so it's almost impossible for me to test the results.  I looked at the specified commit and I think I found a

Re: [PATCH] coreaudio: fix coreaudio playback

2020-02-02 Thread Zoltán Kővágó
On 2020-02-02 15:06, Volker Rümelin wrote: There are reports that since commit 2ceb8240fa "coreaudio: port to the new audio backend api" audio playback with CoreAudio is broken. This patch reverts some parts the commit. Because of changes in the audio subsystem the audio clip function in v4.1.0

[RFC PATCH] audio: proper support for float samples in mixeng

2020-02-02 Thread Kővágó, Zoltán
This adds proper support for float samples in mixeng by adding a new audio format for it. Limitations: only native endianness is supported. Signed-off-by: Kővágó, Zoltán --- This patch is meant to be applied on top of "[PATCH] coreaudio: fix coreaudio playback" by Volker Rümelin, available at:

Re: [PATCH v4 04/20] hw/arm/allwinner-h3: add USB host controller

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 7:44 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 7:37 PM, Philippe Mathieu-Daudé wrote: > > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > >> The Allwinner H3 System on Chip contains multiple USB 2.0 bus > >> connections which provide software access using the Enhanced >

Re: [PATCH v4 04/20] hw/arm/allwinner-h3: add USB host controller

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 7:37 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > The Allwinner H3 System on Chip contains multiple USB 2.0 bus > > connections which provide software access using the Enhanced > > Host Controller Interface (EHCI) and Open Host

Re: [PATCH 0/1] coreaudio: fix coreaudio playback

2020-02-02 Thread Howard Spoelstra
On Sun, Feb 2, 2020 at 3:03 PM Volker Rümelin wrote: > Hi, > > here is a new patch for the CoreAudio playback problem. This patch > is Zoltán's patch from > https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02142.html > and a improved version of my patch squashed together. > > I

Re: VW ELF loader

2020-02-02 Thread Paolo Bonzini
Il dom 2 feb 2020, 12:51 Alexey Kardashevskiy ha scritto: > > QEMU must not load GRUB from disk, that's the firmware's task. If you > > want to kill SLOF, you can rewrite it, but loading the kernel GRUB from > > disk within QEMU is a bad idea: the next feature you'll be requested to > >

Re: [PATCH] tests: Silent various warnings with pseries

2020-02-02 Thread BALATON Zoltan
On Sun, 2 Feb 2020, BALATON Zoltan wrote: On Sat, 1 Feb 2020, Greg Kurz wrote: Some default features of the pseries machine are only available with KVM. Warnings are printed when the pseries machine is used with another accelerator: qemu-system-ppc64: warning: TCG doesn't support requested

  1   2   >